*** rama_y has quit IRC | 00:13 | |
*** david-lyle has quit IRC | 00:31 | |
openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 01:22 |
---|---|---|
wxy | Hope somebody could take a look at this one :https://review.openstack.org/#/c/329320/ | 01:24 |
flwang | wxy: ping | 01:48 |
flwang | i have a question about your confirmation patch | 01:48 |
wxy | here | 01:48 |
flwang | seems you just copied the http server code i gave your | 01:49 |
wxy | yes | 01:49 |
wxy | waht should I do next? | 01:49 |
flwang | my question is how can it do confirm? | 01:49 |
flwang | i mean send the confirm request back to zaqar server | 01:49 |
wxy | it revices the confirm information | 01:49 |
wxy | and uses use these information to post a confirm request | 01:50 |
flwang | oh, really? | 01:51 |
flwang | let me double check | 01:51 |
wxy | https://review.openstack.org/#/c/316601/49/doc/source/subscription_confirm.rst | 01:52 |
wxy | this is the step | 01:52 |
flwang | wxy: no i mean, in the sample code | 01:52 |
flwang | https://review.openstack.org/#/c/316601/49/samples/zaqar/subscriber_service_sample.py | 01:52 |
wxy | it is the sample for subscriber service | 01:53 |
wxy | You mean the subscriber need to send the confirm request automatically once it received the confirm information? | 01:54 |
wxy | this is a subscriber service sample for webhook, not for the e-mail | 01:57 |
wxy | the e-maile one will be done in the next patch. | 01:58 |
flwang | my question is how the http server works to accept the confirmation | 01:58 |
wxy | let me see | 02:01 |
wxy | there is some error, the function name should be do_POST and do_GET | 02:08 |
wxy | flwang: when a subscription is created, suppose the subscriber is this sample server, zaqar will send a confirm information to this sample server . Right? | 02:09 |
flwang | yes | 02:09 |
flwang | and then the http server will send a post back to zaqar, IIUC | 02:10 |
wxy | flwang: get your point. | 02:10 |
flwang | cool | 02:12 |
wxy | flwang: I thought this sample server will print the confirm informtion, then users use this information to confirm by themselves. | 02:12 |
wxy | flwang: of cause it can be done by the sample server. | 02:12 |
flwang | as a sample http service, i would like to see it does it automatically | 02:13 |
wxy | flwang: so I just want to show the process to users. | 02:13 |
wxy | flwang: If it does automatically, the subscription will be confirmed once it be created. | 02:14 |
wxy | flwang: Will it mislead users? | 02:14 |
flwang | i can see your point and i will think it again and leave my comments | 02:18 |
wxy | flwang: ok, please review it and i will fix the jenkins'error in the next patch. | 02:23 |
flwang | wxy: cool, thank you | 02:25 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/339953 | 02:31 |
wxy | flwang: maybe we can provide two sample server. one for user operation, another one for automatic operation. | 02:31 |
flwang | wxy: we can do that in one with some configs i think | 02:32 |
wxy | flwang: yes, it's better. | 02:33 |
*** itisha has quit IRC | 02:40 | |
*** adu has joined #openstack-zaqar | 02:48 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Disable DEPRECATED API versions by default https://review.openstack.org/294611 | 02:55 |
*** yanyanhu has joined #openstack-zaqar | 03:01 | |
*** itisha has joined #openstack-zaqar | 03:03 | |
*** yanyanhu has quit IRC | 03:14 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support `messages` API ref https://review.openstack.org/325637 | 03:31 |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support `messages` API ref https://review.openstack.org/341930 | 03:32 |
*** adu has quit IRC | 04:05 | |
*** wanghao_ has joined #openstack-zaqar | 04:08 | |
*** Kevin_Zheng has joined #openstack-zaqar | 04:08 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Disable DEPRECATED API versions by default https://review.openstack.org/294611 | 04:17 |
*** GB21 has joined #openstack-zaqar | 04:34 | |
*** flwang1 has quit IRC | 05:07 | |
*** adu has joined #openstack-zaqar | 05:08 | |
*** adu has quit IRC | 05:33 | |
*** flwang1 has joined #openstack-zaqar | 05:58 | |
*** rcernin has joined #openstack-zaqar | 06:01 | |
*** Ravikiran_K has joined #openstack-zaqar | 06:10 | |
*** flwang1 has quit IRC | 06:26 | |
*** pcaruana has joined #openstack-zaqar | 06:40 | |
*** flwang1 has joined #openstack-zaqar | 07:03 | |
*** rcernin has quit IRC | 07:05 | |
*** tesseract- has joined #openstack-zaqar | 07:10 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Disable DEPRECATED API versions by default https://review.openstack.org/294611 | 07:11 |
*** rcernin has joined #openstack-zaqar | 07:21 | |
*** Ravikiran_K has quit IRC | 07:26 | |
*** GB21 has quit IRC | 07:30 | |
*** flwang1 has quit IRC | 07:41 | |
*** pt_15 has quit IRC | 07:46 | |
*** itisha has quit IRC | 07:50 | |
*** rcernin has quit IRC | 08:00 | |
*** rcernin has joined #openstack-zaqar | 08:13 | |
*** GB21 has joined #openstack-zaqar | 08:17 | |
*** pt_15 has joined #openstack-zaqar | 08:45 | |
openstackgerrit | Merged openstack/zaqar: Add Python 3.5 classifier and venv https://review.openstack.org/340907 | 08:57 |
*** GB21 has quit IRC | 09:53 | |
*** GB21 has joined #openstack-zaqar | 10:35 | |
*** pt_15 has quit IRC | 10:56 | |
*** Ravikiran_K has joined #openstack-zaqar | 12:04 | |
*** GB21 has quit IRC | 12:23 | |
*** dynarro has joined #openstack-zaqar | 12:41 | |
*** wanghao_ has quit IRC | 13:28 | |
*** ametts has joined #openstack-zaqar | 13:33 | |
*** pt_15 has joined #openstack-zaqar | 13:41 | |
*** itisha has joined #openstack-zaqar | 13:42 | |
*** ametts has quit IRC | 13:54 | |
*** adu has joined #openstack-zaqar | 14:03 | |
*** GB21 has joined #openstack-zaqar | 14:05 | |
*** ametts has joined #openstack-zaqar | 14:07 | |
*** GB21 has quit IRC | 14:30 | |
*** pcaruana has quit IRC | 14:39 | |
openstackgerrit | Merged openstack/python-zaqarclient: Add requests-mock to test-requirements.txt https://review.openstack.org/341426 | 15:05 |
*** dynarro has quit IRC | 15:52 | |
*** wxy has quit IRC | 16:11 | |
*** GB21 has joined #openstack-zaqar | 16:19 | |
*** rcernin has quit IRC | 16:21 | |
*** GB21 has quit IRC | 17:02 | |
*** GB21 has joined #openstack-zaqar | 17:05 | |
*** rcernin has joined #openstack-zaqar | 17:32 | |
*** tesseract- has quit IRC | 17:44 | |
*** GB21 has quit IRC | 18:02 | |
*** flwang1 has joined #openstack-zaqar | 18:40 | |
flwang1 | Eva-i: ping | 18:47 |
*** adu has quit IRC | 18:58 | |
flwang1 | flaper87: pls help review https://review.openstack.org/#/c/333655/ when you have time, thanks | 19:07 |
*** flwang1 has quit IRC | 19:19 | |
*** flwang1 has joined #openstack-zaqar | 19:29 | |
*** flwang1 has quit IRC | 19:38 | |
*** adu has joined #openstack-zaqar | 19:49 | |
*** adu has quit IRC | 19:53 | |
*** ametts has quit IRC | 20:00 | |
*** adu has joined #openstack-zaqar | 20:09 | |
*** ametts has joined #openstack-zaqar | 20:15 | |
openstackgerrit | Dan Prince proposed openstack/python-zaqarclient: Create a websocket transport class https://review.openstack.org/342404 | 20:48 |
openstackgerrit | Dan Prince proposed openstack/python-zaqarclient: Create a websocket transport class https://review.openstack.org/342404 | 20:50 |
*** adu has quit IRC | 21:16 | |
*** rcernin has quit IRC | 21:24 | |
*** adu has joined #openstack-zaqar | 21:33 | |
*** flwang1 has joined #openstack-zaqar | 21:45 | |
*** ametts has quit IRC | 22:01 | |
*** openstackgerrit has quit IRC | 22:03 | |
*** openstackgerrit has joined #openstack-zaqar | 22:03 | |
*** adu has quit IRC | 22:11 | |
*** adu has joined #openstack-zaqar | 22:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!