| openstackgerrit | Dan Prince proposed openstack/python-zaqarclient: Create a websocket transport https://review.openstack.org/342404 | 00:26 |
|---|---|---|
| openstackgerrit | Dan Prince proposed openstack/python-zaqarclient: Create a websocket transport https://review.openstack.org/342404 | 00:27 |
| *** yanyanhu has joined #openstack-zaqar | 01:51 | |
| *** yanyanhu_ has joined #openstack-zaqar | 01:51 | |
| *** yanyanhu has left #openstack-zaqar | 01:51 | |
| *** pt_15 has quit IRC | 02:26 | |
| flwang | wxy__: ping | 02:30 |
| *** itisha has quit IRC | 02:30 | |
| flwang | re the subscription confirmation patch | 02:30 |
| wxy__ | flwang: pong | 02:32 |
| flwang | i'm reviewing the patch and do some manual test | 02:32 |
| flwang | so after this patch, if user POST same body for subscriptions without enable the confirm, what's the response code? | 02:33 |
| openstackgerrit | Merged openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/321737 | 02:33 |
| wxy__ | flwang:PUT | 02:34 |
| flwang | PUT? | 02:34 |
| flwang | sorry | 02:35 |
| wxy__ | flwang: will return 400 BedRequest | 02:35 |
| flwang | i make it confused | 02:35 |
| flwang | i mean | 02:35 |
| wxy__ | Oh , I see | 02:35 |
| flwang | if user didn't enable the confirm, and he POST same body | 02:35 |
| flwang | before this patch, we return 409 | 02:35 |
| flwang | after this patch, what's the resp? | 02:35 |
| wxy__ | 201 | 02:36 |
| wxy__ | https://review.openstack.org/#/c/316601/51/zaqar/tests/unit/transport/wsgi/v2_0/test_subscriptions.py | 02:36 |
| wxy__ | the subscription is not confirmed, So the second request will retry confirm and return 201 again. | 02:36 |
| wxy__ | IT's the retry mechanism. | 02:37 |
| flwang | wxy__: ok, got | 02:37 |
| flwang | btw, if you have time, could you pls work on the flavour's api ref | 02:37 |
| flwang | or wanghao has already started on that> | 02:37 |
| flwang | i will work on the message api ref | 02:38 |
| wxy__ | flwang:Sure, I'll ask him or work it by myself | 02:38 |
| flwang | wxy__: cool, thanks | 02:38 |
| flwang1 | wxy__: i'm reviewing https://review.openstack.org/#/c/316601/51/zaqar/notification/notifier.py line 100-101 | 02:48 |
| flwang1 | is it the proxy issue you mentioned before? | 02:48 |
| flwang1 | besides, it's not secure to expose IP address | 02:49 |
| wxy__ | flwang1: yes ,I know. But if the subscriber need to confirm automatically, it must know Zaqar's address | 02:51 |
| flwang1 | why can't it be an domain name? | 02:52 |
| flwang1 | IP address is not acceptable | 02:52 |
| *** pt_15 has joined #openstack-zaqar | 02:54 | |
| wxy__ | flwang1: Domain name is better. | 02:55 |
| flwang1 | yep, so i'm thinking if we should make it configurable | 02:56 |
| *** itisha has joined #openstack-zaqar | 03:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-zaqarclient: Updated from global requirements https://review.openstack.org/343418 | 03:11 |
| *** david-lyle has quit IRC | 03:11 | |
| flwang1 | wxy__: when I tried to confirm the subscription, i got 403 | 03:13 |
| flwang1 | any idea? | 03:13 |
| wxy__ | flwang1: in a meeting just now. | 03:38 |
| flwang1 | ok, ttyl | 03:39 |
| wxy__ | flwang1: could you please show your request? or you used the sample service in my patch? | 03:39 |
| flwang1 | no, i confirm the subscription manually | 03:40 |
| flwang1 | maybe i should try the script in your patch | 03:40 |
| wxy__ | flwang1: It's strange. Need you reproduce. And paste the information to me .Thanks | 03:42 |
| flwang1 | wxy__: http://paste.openstack.org/show/536042/ | 03:44 |
| openstackgerrit | Merged openstack/zaqar: This patch removes extra spaces from files. https://review.openstack.org/342670 | 03:45 |
| wxy__ | flwang1: confirm request should not execute notification/tasks/webhook.py 's code. I don't know how it did. | 03:50 |
| wxy__ | flwang1: I'll add some tempest tests for this patch | 03:50 |
| flwang1 | cool, thanks | 03:50 |
| wxy__ | flwang1: BTW, how can I get the port value from cfg? | 03:52 |
| flwang1 | port of zaqar? | 03:52 |
| wxy__ | flwang1: yes | 03:52 |
| flwang1 | https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/driver.py#L42 | 03:54 |
| flwang1 | are you looking for this? | 03:54 |
| wxy__ | flwang1: Yes, I used "conf['drivers:transport:wsgi'].port" to get it, but it doesn't work. | 04:00 |
| flwang1 | in test? | 04:01 |
| flwang1 | i mean in unit test or the real logic code? | 04:01 |
| wxy__ | flwang1: https://review.openstack.org/#/c/316601/51/zaqar/notification/notifier.py L101 | 04:02 |
| wxy__ | flwang1: Maybe I missed something | 04:02 |
| flwang1 | wxy__: i guess you missed this line self._conf.register_opts(_WSGI_OPTIONS, group=_WSGI_GROUP) | 04:03 |
| flwang1 | without register, you can't access it | 04:03 |
| wxy__ | flwang1: Got it, So I'm totally wrong before. IMO, the config option only need to register once in the project. :( | 04:04 |
| flwang1 | if you're using a global conf, it should be, I'm not 100% sure, you can test it | 04:06 |
| wxy__ | flwang1:OK | 04:09 |
| *** kong has joined #openstack-zaqar | 04:09 | |
| *** adu has joined #openstack-zaqar | 04:58 | |
| *** flwang1 has quit IRC | 05:03 | |
| *** adu has quit IRC | 05:09 | |
| *** rcernin has joined #openstack-zaqar | 05:57 | |
| *** david-lyle has joined #openstack-zaqar | 06:02 | |
| *** flwang1 has joined #openstack-zaqar | 06:03 | |
| *** rcernin has quit IRC | 06:04 | |
| *** rcernin has joined #openstack-zaqar | 06:17 | |
| *** flwang1 has quit IRC | 06:28 | |
| *** pcaruana has joined #openstack-zaqar | 06:29 | |
| *** Ravikiran_K has joined #openstack-zaqar | 06:30 | |
| *** david-lyle has quit IRC | 06:32 | |
| *** flwang1 has joined #openstack-zaqar | 06:45 | |
| *** tesseract- has joined #openstack-zaqar | 06:45 | |
| *** rcernin has quit IRC | 06:48 | |
| *** pcaruana has quit IRC | 06:48 | |
| *** pcaruana has joined #openstack-zaqar | 07:02 | |
| *** rcernin has joined #openstack-zaqar | 07:03 | |
| *** flwang1 has quit IRC | 07:03 | |
| *** flwang1 has joined #openstack-zaqar | 07:22 | |
| *** jtomasek has joined #openstack-zaqar | 08:13 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 10:15 |
| *** yanyanhu_ has quit IRC | 10:20 | |
| *** yanyanhu_ has joined #openstack-zaqar | 10:21 | |
| *** yanyanhu_ has quit IRC | 10:21 | |
| *** pt_15 has quit IRC | 10:36 | |
| *** itisha has quit IRC | 10:40 | |
| *** Ravikiran_K has quit IRC | 10:58 | |
| *** dynarro has joined #openstack-zaqar | 11:51 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 12:02 |
| *** Ravikiran_K has joined #openstack-zaqar | 13:09 | |
| *** pt_15 has joined #openstack-zaqar | 13:19 | |
| *** JAHoagie has joined #openstack-zaqar | 13:38 | |
| *** mpanetta has joined #openstack-zaqar | 13:53 | |
| *** mpanetta has quit IRC | 13:54 | |
| *** mpanetta has joined #openstack-zaqar | 13:54 | |
| *** JAHoagie has quit IRC | 14:00 | |
| *** JAHoagie has joined #openstack-zaqar | 14:02 | |
| *** JAHoagie has quit IRC | 14:36 | |
| *** dynarro has quit IRC | 15:53 | |
| *** pt_15 has quit IRC | 16:06 | |
| *** tesseract- has quit IRC | 16:10 | |
| *** JAHoagie has joined #openstack-zaqar | 16:47 | |
| *** rcernin has quit IRC | 16:53 | |
| *** pcaruana has quit IRC | 16:59 | |
| *** kong has quit IRC | 17:04 | |
| *** flaper87 has quit IRC | 17:05 | |
| *** zigo has quit IRC | 17:06 | |
| *** godlike has quit IRC | 17:06 | |
| *** ameade has quit IRC | 17:06 | |
| *** zigo has joined #openstack-zaqar | 17:06 | |
| *** godlike has joined #openstack-zaqar | 17:07 | |
| *** godlike has joined #openstack-zaqar | 17:07 | |
| *** kong has joined #openstack-zaqar | 17:09 | |
| *** flaper87 has joined #openstack-zaqar | 17:10 | |
| *** ameade has joined #openstack-zaqar | 17:10 | |
| *** flaper87 is now known as Guest53586 | 17:11 | |
| flwang1 | meeting reminder: #openstack-meeting-3 after 25 mins | 17:36 |
| *** rcernin has joined #openstack-zaqar | 17:37 | |
| flwang1 | Eva-i: Guest53586: therve: vkmc: wxy__: wanghao: ryansb: meeting in 5 mins | 17:55 |
| therve | flwang1, Dinner time, sorry :/ | 18:00 |
| flwang1 | therve: no problem :) i can sync with you later :) | 18:01 |
| therve | Cool, thanks | 18:01 |
| *** pcaruana has joined #openstack-zaqar | 18:34 | |
| *** pt_15 has joined #openstack-zaqar | 18:35 | |
| *** itisha has joined #openstack-zaqar | 18:39 | |
| *** ametts has joined #openstack-zaqar | 18:49 | |
| *** Ravikiran_K has quit IRC | 18:52 | |
| *** rcernin has quit IRC | 18:57 | |
| *** rcernin has joined #openstack-zaqar | 19:15 | |
| *** rcernin has quit IRC | 19:16 | |
| *** rcernin has joined #openstack-zaqar | 19:16 | |
| *** rcernin has quit IRC | 20:38 | |
| *** Eva-i has quit IRC | 21:09 | |
| *** Eva-i has joined #openstack-zaqar | 21:13 | |
| *** rcernin has joined #openstack-zaqar | 21:49 | |
| *** rcernin has quit IRC | 21:49 | |
| *** ametts has quit IRC | 21:56 | |
| *** mpanetta has quit IRC | 21:56 | |
| *** pcaruana has quit IRC | 23:05 | |
| *** wanghao_ has joined #openstack-zaqar | 23:10 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!