| *** stanchan has quit IRC | 00:06 | |
| *** JAHoagie has quit IRC | 00:08 | |
| *** stanchan has joined #openstack-zaqar | 00:15 | |
| *** stanchan has quit IRC | 01:02 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 01:18 |
|---|---|---|
| *** stanchan has joined #openstack-zaqar | 01:41 | |
| *** tqtran_ has quit IRC | 01:42 | |
| *** stanchan has quit IRC | 01:57 | |
| *** yanyanhu has joined #openstack-zaqar | 03:11 | |
| flwang | wxy__: ping | 03:28 |
| flwang | so for the subscription confirmation patch | 03:28 |
| flwang | what happened if the confirm required is not enabled, but user pose duplicate subscription? | 03:29 |
| *** stanchan has joined #openstack-zaqar | 03:30 | |
| *** stanchan has quit IRC | 03:45 | |
| wxy__ | flwang, it depends on the subscription's "confirmed" property | 04:00 |
| flwang | wxy__: so that means, even the confirm_required is False, user will still get 204 instead of 409 as before? | 04:01 |
| wxy__ | flwang, I think it should be: 1. if the subscription doesn't contain "confirmed", it should return 409. 2. if the subscription contain "confirmed:True", it should return 409 3. if the subscription contain "confirmed:False", it should return 204, but should not send the notification(the confirm required is not enabled) | 04:05 |
| flwang | what does that mean ' but should not send the notification'? | 04:06 |
| wxy__ | flwang, you mean that if the confirm required is not enabled, zaqar should always return 409? | 04:07 |
| wxy__ | flwang, the confirm notification to the subscriber. | 04:09 |
| flwang | i'm not talking about the notitication | 04:12 |
| flwang | i'm talking about the response code | 04:13 |
| wxy__ | flwang, OK, after my patch, no matter the confirm required is not enabled or not, zaqar will return 409 only when the "confirm" is True. Otherwise ,it will return 204. | 04:16 |
| flwang | wxy__: so because by default the confirm is false, so even the confirm required is not enabled, use will always got 204 for duplicate subscription, right? | 04:17 |
| wxy__ | yes | 04:17 |
| flwang | wxy__: ok, i see | 04:17 |
| wxy__ | this config option is only used for message notification. | 04:19 |
| wxy__ | flwang, if the value is False, the message posted to a queue will always be notified to the subscriber. if the value is True, then subscription need to be confirmed first. | 04:21 |
| flwang | wxy__: right | 04:35 |
| *** Qiming has quit IRC | 04:39 | |
| *** tqtran has joined #openstack-zaqar | 04:42 | |
| *** Qiming has joined #openstack-zaqar | 04:44 | |
| *** tqtran has quit IRC | 04:46 | |
| *** stanchan has joined #openstack-zaqar | 04:58 | |
| *** flwang2 has joined #openstack-zaqar | 04:59 | |
| *** stanchan has quit IRC | 04:59 | |
| *** stanchan has joined #openstack-zaqar | 05:00 | |
| *** flwang1 has quit IRC | 05:01 | |
| *** flwang2 has quit IRC | 05:03 | |
| *** rcernin has joined #openstack-zaqar | 05:16 | |
| *** Qiming has quit IRC | 05:32 | |
| *** Qiming has joined #openstack-zaqar | 05:33 | |
| *** pt_15 has quit IRC | 06:06 | |
| *** jtomasek has quit IRC | 06:09 | |
| *** itisha has quit IRC | 06:10 | |
| *** pcaruana has joined #openstack-zaqar | 06:10 | |
| *** Ravikiran_K has joined #openstack-zaqar | 06:12 | |
| *** stanchan has quit IRC | 06:21 | |
| *** stanchan has joined #openstack-zaqar | 06:28 | |
| *** stanchan has quit IRC | 06:38 | |
| *** tqtran has joined #openstack-zaqar | 06:42 | |
| *** tqtran has quit IRC | 06:47 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 06:50 |
| *** stanchan has joined #openstack-zaqar | 06:52 | |
| *** tesseract- has joined #openstack-zaqar | 06:53 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Subscription Confirmation Support-1 https://review.openstack.org/316601 | 06:54 |
| *** jaosorior has joined #openstack-zaqar | 06:57 | |
| jaosorior | Hello folks, is anyone around? I think I found an issue with the project-id extraction in zaqar but would like to know more details before coding a fix | 06:57 |
| *** stanchan has quit IRC | 07:02 | |
| *** stanchan has joined #openstack-zaqar | 07:09 | |
| wxy | jaosorior: hello. please say more. | 07:18 |
| jaosorior | wxy: While I waited for an answer, I think I found the issue and a solution too. I have reported this https://bugs.launchpad.net/zaqar/+bug/1609662 | 07:19 |
| openstack | Launchpad bug 1609662 in zaqar "Getting the versions of the API fails" [Undecided,New] | 07:19 |
| wxy | jaosorior: looking. | 07:19 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/zaqar: Don't check for project-id if accessing the / route https://review.openstack.org/351039 | 07:22 |
| jaosorior | wxy: That is my proposed solution ^^ But I still need to add tests | 07:22 |
| jaosorior | wxy: While trying to run the unit tests, I'm getting this: Failed to load "zaqar.data.storage" driver for "mongodb" | 07:25 |
| jaosorior | Then it fails with this: pymongo.errors.ServerSelectionTimeoutError: localhost:27017: [Errno 111] Connection refused | 07:25 |
| jaosorior | wxy: Did I miss some setup? | 07:25 |
| wxy | jaosorior: nice catch. https://review.openstack.org/#/c/306782/1 this patch allow users to visit root path without authentication. But https://review.openstack.org/#/c/305035/ forgot this situation. | 07:26 |
| wxy | jaosorior: thanks for doing this. | 07:26 |
| wxy | I guess connection refused means that you should modify the mongodb's config file. | 07:28 |
| jaosorior | wxy: So, is it necessary for me to have mongodb to run the unit tests? | 07:28 |
| jaosorior | thought the access to the database would be mocked for the unit tests or something of the sort | 07:29 |
| therve | Some tests require mongo to run | 07:30 |
| wxy | jaosorior: yes | 07:33 |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #openstack-zaqar | 07:33 | |
| wxy | jaosorior: you can find some decorator like: @testing.requires_mongodb | 07:34 |
| wxy | jaosorior: usually I export some env for zaqar test: export ZAQAR_TEST_REDIS=redis://127.0.0.1:6379 export ZAQAR_TESTS_CONFIGS_DIR=/opt/stack/zaqar/zaqar/tests/etc export ZAQAR_TEST_MONGODB=mongodb://10.229.47.217:27017/zaqar export ZAQARCLIENT_AUTH_FUNCTIONAL=True export ZAQARCLIENT_TEST_FUNCTIONAL=True | 07:35 |
| wxy | jaosorior: the ip need to be changed to yours | 07:35 |
| *** dynarro has joined #openstack-zaqar | 07:37 | |
| jaosorior | wxy: Is there an option to skip the mongodb-related tests? | 07:37 |
| jaosorior | either way for testing the / route they shouldn't be needed | 07:37 |
| therve | jaosorior, ZAQAR_TEST_MONGODB=0 I believe | 07:37 |
| wxy | jaosorior: You can have a try. :) | 07:38 |
| therve | wxy, AFAIK your exports are not useful, you can't pass URLs to ZAQAR_TEST_REDIS or ZAQAR_TEST_MONGODB | 07:41 |
| therve | There is a ZAQAR_TEST_MONGODB_URL var though | 07:42 |
| jaosorior | therve: the env variable you passed didn't work out :( | 07:42 |
| therve | jaosorior, How did you try? | 07:42 |
| jaosorior | export ZAQAR_TEST_MONGODB=0 | 07:42 |
| jaosorior | then I ran tox | 07:43 |
| therve | Yeah I don't know if tox will respect it | 07:43 |
| wxy | therve: thanks, you are right. | 07:44 |
| jaosorior | no biggie. I think I'll just write a functional test anyway. Noticed it was getting complicated to add the before_hooks to unit tests | 07:46 |
| therve | You can just run the tests you care about, anyway | 07:47 |
| *** stanchan has quit IRC | 07:48 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/zaqar: Don't check for project-id if accessing the / route https://review.openstack.org/351039 | 07:49 |
| jaosorior | wxy, therve: Could you give a quick look to that patch? ^^ To see if it makes sense | 07:52 |
| jaosorior | I'm gonna add also another test with the headers in the client. But yeah, just a sanity check so the bug doesn't get a regression | 07:53 |
| therve | That looks okay to me | 07:55 |
| wxy | the code is ok from my sight and works well in my env. | 07:57 |
| *** stanchan has joined #openstack-zaqar | 08:04 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/zaqar: Don't check for project-id if accessing the / route https://review.openstack.org/351039 | 08:06 |
| wxy | therve: I have a question. As zaqar' functional test is non-voting now. Do we hope developer to add this kind of test? | 08:12 |
| *** jaosorior has quit IRC | 08:13 | |
| therve | wxy, You mean the tempest ones? | 08:13 |
| *** jaosorior has joined #openstack-zaqar | 08:13 | |
| wxy | therve: no, for example: https://review.openstack.org/#/c/348699/ gate-dsvm-mongodb-zaqar and gate-dsvm-redis-zaqar | 08:15 |
| therve | Yeah those are tempest tests | 08:16 |
| wxy | like the test in jaosorior' patch. actually, it's non-voting. | 08:16 |
| therve | I'm pretty sure the tests in jaosorior are voting | 08:17 |
| wxy | therve: really? which CI contained it? | 08:17 |
| therve | wxy, The integration job I believe | 08:18 |
| *** stanchan has quit IRC | 08:20 | |
| wxy | therve: oh,yes.I thought they were included in the non-voting job before. | 08:23 |
| *** flwang1 has joined #openstack-zaqar | 08:40 | |
| *** tqtran has joined #openstack-zaqar | 08:44 | |
| jaosorior | great, therve, wxy, by the way, is there a way for zaqar to use middleware? Or is it restrictued to those before_hooks? | 08:48 |
| *** tqtran has quit IRC | 08:49 | |
| *** gb21 has joined #openstack-zaqar | 08:55 | |
| jaosorior | therve, wxy: Can you guys review the fix I did https://review.openstack.org/#/c/351039/ ? | 09:01 |
| wxy | jaosorior: AFAIK, there is no middleware like nova,cinder or other project does. It uses the before_hooks as the middleware. | 09:02 |
| therve | You can use middleware, there is no configurable way to do so | 09:03 |
| *** gb21 has quit IRC | 09:29 | |
| *** dynarro has quit IRC | 10:15 | |
| *** dynarro has joined #openstack-zaqar | 10:21 | |
| *** gb21 has joined #openstack-zaqar | 10:32 | |
| *** dynarro has quit IRC | 10:33 | |
| *** yanyanhu has quit IRC | 10:33 | |
| *** gb21 is now known as GB21 | 10:41 | |
| *** prashanthraghu has joined #openstack-zaqar | 10:57 | |
| *** GB21 has quit IRC | 11:01 | |
| *** GB21 has joined #openstack-zaqar | 11:02 | |
| *** Ravikiran_K has quit IRC | 11:04 | |
| *** prashanthraghu has quit IRC | 11:13 | |
| *** JAHoagie has joined #openstack-zaqar | 11:19 | |
| *** JAHoagie has quit IRC | 11:23 | |
| *** dynarro has joined #openstack-zaqar | 11:49 | |
| *** GB21 has quit IRC | 12:30 | |
| *** tqtran has joined #openstack-zaqar | 12:45 | |
| *** tqtran has quit IRC | 12:50 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/zaqar: Don't check for project-id if accessing the / route https://review.openstack.org/351039 | 13:23 |
| *** JAHoagie has joined #openstack-zaqar | 13:27 | |
| *** andreaf has joined #openstack-zaqar | 13:35 | |
| *** ametts has joined #openstack-zaqar | 13:45 | |
| *** prashanthraghu has joined #openstack-zaqar | 13:59 | |
| *** prashanthraghu has quit IRC | 14:06 | |
| *** jaosorior has quit IRC | 14:17 | |
| *** JAHoagie has quit IRC | 14:22 | |
| *** stanchan has joined #openstack-zaqar | 14:47 | |
| *** stanchan has quit IRC | 14:48 | |
| *** rcernin has quit IRC | 15:09 | |
| *** JAHoagie has joined #openstack-zaqar | 15:19 | |
| *** JAHoagie has quit IRC | 15:26 | |
| *** stanchan has joined #openstack-zaqar | 15:47 | |
| *** ametts has quit IRC | 15:57 | |
| *** ametts has joined #openstack-zaqar | 16:04 | |
| *** pt_15 has joined #openstack-zaqar | 16:42 | |
| *** tqtran has joined #openstack-zaqar | 16:47 | |
| *** itisha has joined #openstack-zaqar | 16:51 | |
| *** tqtran has quit IRC | 16:51 | |
| *** david-lyle has quit IRC | 16:53 | |
| *** david-lyle has joined #openstack-zaqar | 16:53 | |
| *** flaper87 has quit IRC | 17:03 | |
| *** JAHoagie has joined #openstack-zaqar | 17:18 | |
| *** stanchan has quit IRC | 17:37 | |
| *** dynarro has quit IRC | 17:45 | |
| *** tesseract- has quit IRC | 17:53 | |
| *** stanchan has joined #openstack-zaqar | 18:05 | |
| *** stanchan has quit IRC | 18:15 | |
| *** tqtran has joined #openstack-zaqar | 18:17 | |
| *** stanchan has joined #openstack-zaqar | 18:54 | |
| *** stanchan has quit IRC | 18:55 | |
| *** stanchan has joined #openstack-zaqar | 18:56 | |
| *** fifieldt has quit IRC | 19:07 | |
| *** fifieldt has joined #openstack-zaqar | 19:18 | |
| *** pmathews has quit IRC | 19:36 | |
| *** stanchan has quit IRC | 19:36 | |
| openstackgerrit | Merged openstack/zaqar: Don't check for project-id if accessing the / route https://review.openstack.org/351039 | 19:58 |
| *** ametts has quit IRC | 20:05 | |
| *** ametts has joined #openstack-zaqar | 20:10 | |
| *** stanchan has joined #openstack-zaqar | 20:15 | |
| *** flwang1 has quit IRC | 20:16 | |
| *** pmathews has joined #openstack-zaqar | 20:34 | |
| *** pmathews1 has joined #openstack-zaqar | 20:35 | |
| *** pmathews has quit IRC | 20:38 | |
| *** stanchan has quit IRC | 20:41 | |
| *** pmathews1 has quit IRC | 20:44 | |
| *** stanchan has joined #openstack-zaqar | 20:45 | |
| *** pmathews has joined #openstack-zaqar | 21:06 | |
| *** stanchan has quit IRC | 21:18 | |
| *** stanchan has joined #openstack-zaqar | 21:20 | |
| *** ametts has quit IRC | 21:26 | |
| *** pmathews has quit IRC | 21:28 | |
| *** flwang1 has joined #openstack-zaqar | 21:37 | |
| *** pmathews has joined #openstack-zaqar | 21:40 | |
| *** pmathews has quit IRC | 21:49 | |
| *** pmathews has joined #openstack-zaqar | 21:57 | |
| *** stanchan has quit IRC | 22:18 | |
| *** stanchan has joined #openstack-zaqar | 22:20 | |
| *** stanchan has quit IRC | 22:30 | |
| *** stanchan has joined #openstack-zaqar | 22:52 | |
| *** pmathews has quit IRC | 23:41 | |
| *** stanchan has quit IRC | 23:43 | |
| *** stanchan has joined #openstack-zaqar | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!