openstackgerrit | Merged openstack/zun-ui: Fix the path to an enabled folder in plugin.sh https://review.openstack.org/367709 | 00:09 |
---|---|---|
*** flwang1 has quit IRC | 00:31 | |
*** GB21 has joined #openstack-zun | 00:47 | |
*** Wenzhi has joined #openstack-zun | 00:53 | |
*** hieulq has joined #openstack-zun | 01:52 | |
*** yuanying has quit IRC | 02:51 | |
*** flwang1 has joined #openstack-zun | 02:54 | |
*** flwang1 has quit IRC | 03:17 | |
*** yuanying has joined #openstack-zun | 03:50 | |
*** janki has joined #openstack-zun | 04:13 | |
openstackgerrit | Wenzhi Yu proposed openstack/zun: Clean up etcd generated file https://review.openstack.org/368542 | 04:24 |
*** chandankumar has joined #openstack-zun | 04:32 | |
*** hongbin has quit IRC | 04:50 | |
*** adisky has joined #openstack-zun | 04:51 | |
*** GB21 has quit IRC | 05:04 | |
*** GB21 has joined #openstack-zun | 05:18 | |
*** sudipto has joined #openstack-zun | 06:01 | |
*** sudipto_ has joined #openstack-zun | 06:01 | |
*** mikelk has joined #openstack-zun | 07:24 | |
*** Wenzhi has quit IRC | 07:26 | |
*** mkrai has joined #openstack-zun | 07:35 | |
*** vikasc has quit IRC | 08:17 | |
openstackgerrit | Namrata proposed openstack/zun: Nova Integration Spec https://review.openstack.org/354553 | 08:27 |
sudipto | mkrai, hello | 08:42 |
sudipto | after a long time! | 08:42 |
mkrai | Hi sudipto | 08:43 |
mkrai | Yeah I was on leave due to some family emergency | 08:43 |
mkrai | Almost 1 month | 08:43 |
sudipto | oh, i hope things are alright now. | 08:43 |
mkrai | How are you? | 08:43 |
mkrai | Yes better. Thanks :) | 08:43 |
sudipto | Ok glad to know that. I have been super busy as well with a lot of customer travels last month. | 08:45 |
sudipto | However, I could finally get something up for my dev environment for zun using docker itself. | 08:45 |
sudipto | and i think there shouldn't be any more excuses to not contribute code now! | 08:45 |
sudipto | :) | 08:46 |
mkrai | Yeah I will be happy to see your patches upstream for Zun | 08:46 |
mkrai | What will you be working on? | 08:46 |
sudipto | So my observation - for which i wanted to in particular ping you. | 08:47 |
sudipto | when i do a zun delete on a stopped container - it returns a 409 for me. any reason? | 08:48 |
mkrai | Ahh there is a patch upstream to add --force option to delete command | 08:49 |
mkrai | to allow deleting a running container | 08:49 |
sudipto | i mean this is a stopped container. | 08:49 |
mkrai | There is patch for this bug also | 08:50 |
mkrai | Hongbin has submitted it | 08:50 |
sudipto | Ah | 08:52 |
sudipto | Darn, there you go - the first fix just got taken by Mr. Hongbin Lu :) | 08:52 |
*** openstackgerrit has quit IRC | 09:04 | |
*** openstackgerrit has joined #openstack-zun | 09:05 | |
*** mfedosin has joined #openstack-zun | 09:43 | |
*** tbh has joined #openstack-zun | 09:50 | |
*** mkrai has quit IRC | 09:52 | |
*** vikasc has joined #openstack-zun | 10:00 | |
*** tbh has quit IRC | 10:16 | |
*** tbh has joined #openstack-zun | 10:19 | |
*** tbh has quit IRC | 10:21 | |
*** shu-mutou is now known as shu-mutou-AFK | 10:39 | |
*** GB21 has quit IRC | 10:40 | |
*** tbh has joined #openstack-zun | 11:07 | |
*** GB21 has joined #openstack-zun | 11:10 | |
*** tbh has quit IRC | 11:32 | |
*** tbh has joined #openstack-zun | 12:07 | |
*** janki has quit IRC | 12:41 | |
*** janki has joined #openstack-zun | 13:09 | |
*** mfedosin has quit IRC | 13:11 | |
*** openstackgerrit has quit IRC | 13:19 | |
*** openstackgerrit has joined #openstack-zun | 13:19 | |
*** mfedosin has joined #openstack-zun | 13:37 | |
*** hongbin has joined #openstack-zun | 14:09 | |
*** janki has quit IRC | 14:43 | |
*** tbh has quit IRC | 14:56 | |
*** tbh has joined #openstack-zun | 15:04 | |
sudipto | hongbin, hello - got a minute? | 15:06 |
hongbin | sudipto: sure | 15:07 |
sudipto | I am trying to fix a bug where if the container state is in 'Error' state - we report a 409 conflict when 'delete' is attempted. | 15:07 |
sudipto | are you aware of it? | 15:07 |
sudipto | I seem to have fixed it - with a myriad of issues that would have to be fixed subsequently, wondering if the right way to take it forward is via bug or a ... ? | 15:08 |
hongbin | I think somebody else fixed it as well :) | 15:08 |
sudipto | sigh! Not merged yet? | 15:09 |
hongbin | https://review.openstack.org/#/c/365290/ | 15:09 |
sudipto | Ok i see it. | 15:09 |
hongbin | will address Madhuri comment | 15:09 |
hongbin | then it will get merged | 15:09 |
sudipto | Sounds like - we are missing the tests for the entire manager.py | 15:10 |
hongbin | Yes, I need to add them back | 15:10 |
sudipto | you want me to add them (in case you don't have them added already) | 15:11 |
hongbin | I wanted to get the patch merge quickly so didn't add tests in many places, this is a bad behaviour :) | 15:11 |
hongbin | yes, if you want | 15:11 |
sudipto | Yeah - i would think - let's add the entire manager.py - and get this patch merged for now | 15:12 |
sudipto | However, I do feel there's a missing piece here, putting the comment on the review. | 15:12 |
hongbin | another option is to merge the fix first | 15:13 |
hongbin | and add a bug to add tests later | 15:14 |
sudipto | yeah i share that thought too | 15:14 |
sudipto | Also - how do we map the ZUN container ids to the docker IDs? | 15:15 |
sudipto | or there is none like that? | 15:15 |
hongbin | In Zun container table, there is a field called "container_id" | 15:16 |
hongbin | The "container_id" will be set to docker IDs, when the container was created in docker. | 15:16 |
hongbin | There is another field called "uuid" | 15:16 |
hongbin | which is the Zun container id | 15:16 |
sudipto | ok got it... | 15:16 |
hongbin | sudipto: A question for you | 15:18 |
sudipto | yeah | 15:18 |
hongbin | sudipto: what do you think about the networking proposal | 15:18 |
hongbin | sudipto: still have concern to depend on Nova? | 15:19 |
sudipto | honestly, i didn't have the time yet to go through it. I got my mini openstack cluster up for development over the last week that i will share with you shortly. I will go through the proposal post that. Sorry about this. | 15:19 |
sudipto | after that cluster was up - i was able to spot this bug | 15:20 |
hongbin | np at all | 15:20 |
*** flaper87 has quit IRC | 15:21 | |
hongbin | just let me know if there is any concern | 15:21 |
sudipto | hongbin, https://github.com/sudswas/zun-docker this is how things are as far as my dev env goes | 15:30 |
sudipto | if you are interested you can take a look, but i have loads of amends to make. | 15:30 |
hongbin | thx! | 15:31 |
hongbin | will try that later | 15:31 |
*** adisky has quit IRC | 15:31 | |
hongbin | sudipto: will mention your work at the team meeting, looks interesting | 15:35 |
sudipto | hongbin, i will automate the entire thing using docker-compose. That should make it a one click thing. | 15:36 |
sudipto | and i need to swap a few items from docker file to the bin/script files - so that the build time things are not repeated while just start stop of the container. | 15:36 |
hongbin | ok | 15:37 |
*** chandankumar has quit IRC | 15:41 | |
*** mikelk has quit IRC | 15:50 | |
tbh | hongbin, I just saw your patch correcting "delete" container option, had same changes in my patch too https://review.openstack.org/#/c/367776/2/zun/compute/manager.py :) | 16:03 |
tbh | hongbin, will change that part | 16:03 |
*** mfedosin has quit IRC | 16:21 | |
*** sudipto has quit IRC | 16:22 | |
*** sudipto_ has quit IRC | 16:22 | |
*** mkrai has joined #openstack-zun | 16:28 | |
*** harlowja has joined #openstack-zun | 17:19 | |
*** sudipto has joined #openstack-zun | 17:38 | |
*** sudipto_ has joined #openstack-zun | 17:38 | |
*** harlowja has quit IRC | 17:43 | |
hongbin | tbh: ok, i will abandon mine | 17:45 |
*** harlowja has joined #openstack-zun | 17:45 | |
*** flwang1 has joined #openstack-zun | 17:48 | |
*** tbh has quit IRC | 18:04 | |
*** mkrai_ has joined #openstack-zun | 18:04 | |
*** mkrai_ has quit IRC | 18:05 | |
*** mkrai has quit IRC | 18:05 | |
*** GB21 has quit IRC | 18:10 | |
openstackgerrit | Merged openstack/zun: Add --force option while deleting containers in Running state https://review.openstack.org/367776 | 18:17 |
*** sudipto has quit IRC | 18:18 | |
*** sudipto_ has quit IRC | 18:18 | |
*** mfedosin has joined #openstack-zun | 20:14 | |
*** vikasc has quit IRC | 20:35 | |
*** vikasc has joined #openstack-zun | 20:49 | |
*** mfedosin has quit IRC | 21:44 | |
*** openstackgerrit has quit IRC | 22:48 | |
*** openstackgerrit has joined #openstack-zun | 22:49 | |
*** hongbin has quit IRC | 23:20 | |
*** shubhams has joined #openstack-zun | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!