*** devlaps has joined #openstack-zun | 00:01 | |
*** hongbin has quit IRC | 00:20 | |
*** manikanta_ has quit IRC | 00:35 | |
*** manikanta_tadi has joined #openstack-zun | 01:05 | |
*** zhurong has joined #openstack-zun | 01:14 | |
*** yanyanhu has joined #openstack-zun | 01:32 | |
*** manikanta_tadi has quit IRC | 01:55 | |
*** kevinz has joined #openstack-zun | 02:00 | |
*** devlaps has quit IRC | 02:07 | |
*** manikanta_tadi has joined #openstack-zun | 02:08 | |
*** hongbin has joined #openstack-zun | 02:21 | |
*** shu-mutou has joined #openstack-zun | 02:29 | |
*** hongbin has quit IRC | 02:32 | |
*** kevinz has quit IRC | 02:35 | |
*** kevinz has joined #openstack-zun | 02:35 | |
*** yuanying has quit IRC | 02:46 | |
*** kevinz has quit IRC | 02:50 | |
*** kevinz has joined #openstack-zun | 02:50 | |
*** zhurong_ has joined #openstack-zun | 02:53 | |
*** zhurong has quit IRC | 02:55 | |
*** yuanying has joined #openstack-zun | 02:55 | |
*** kevinz has quit IRC | 03:20 | |
*** vikasc has joined #openstack-zun | 03:35 | |
*** shubhams has quit IRC | 03:43 | |
*** zhangjl has joined #openstack-zun | 03:47 | |
*** manikanta_tadi has quit IRC | 03:48 | |
*** yuanying has quit IRC | 03:49 | |
*** zhangjl1 has joined #openstack-zun | 03:53 | |
*** zhangjl has quit IRC | 03:55 | |
*** yuanying has joined #openstack-zun | 04:18 | |
*** hongbin has joined #openstack-zun | 04:30 | |
*** hongbin has quit IRC | 04:30 | |
*** sudipto has joined #openstack-zun | 04:31 | |
*** sudipto_ has joined #openstack-zun | 04:31 | |
*** sudipto_ has quit IRC | 04:54 | |
*** sudipto has quit IRC | 04:54 | |
*** catinthe_ has quit IRC | 05:19 | |
*** sudipto has joined #openstack-zun | 05:19 | |
*** sudipto_ has joined #openstack-zun | 05:20 | |
*** catintheroof has joined #openstack-zun | 05:21 | |
*** catintheroof has quit IRC | 05:26 | |
openstackgerrit | Namrata proposed openstack/zun: Moving inspect image from containers driver to image driver https://review.openstack.org/404546 | 05:28 |
---|---|---|
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 06:13 |
*** trinaths has joined #openstack-zun | 06:17 | |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 06:40 |
openstackgerrit | Namrata proposed openstack/zun: Moving inspect image from containers driver to image driver https://review.openstack.org/404546 | 06:42 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 06:43 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 06:53 |
*** yanyanhu has quit IRC | 06:59 | |
*** yanyanhu has joined #openstack-zun | 06:59 | |
*** sudipto has quit IRC | 07:50 | |
*** sudipto_ has quit IRC | 07:50 | |
*** yanyanhu has quit IRC | 07:53 | |
*** yanyanhu has joined #openstack-zun | 07:56 | |
*** trinaths has quit IRC | 07:58 | |
*** zhurong_ has quit IRC | 08:04 | |
*** zhurong has joined #openstack-zun | 08:04 | |
*** trinaths has joined #openstack-zun | 08:07 | |
*** exploreshaifali has joined #openstack-zun | 08:30 | |
*** sudipto_ has joined #openstack-zun | 08:40 | |
*** sudipto has joined #openstack-zun | 08:40 | |
*** zhangjl1 has quit IRC | 09:24 | |
*** zhurong has quit IRC | 10:02 | |
*** janki has joined #openstack-zun | 10:07 | |
*** exploreshaifali has quit IRC | 10:13 | |
*** exploreshaifali has joined #openstack-zun | 10:16 | |
sudipto_ | mkrai, hi, i was doing a few reviews, but i don't quite agree with this fix: https://review.openstack.org/#/c/403890/1 - your thoughts? | 10:17 |
*** anteaya has quit IRC | 10:19 | |
*** yanyanhu has quit IRC | 10:19 | |
*** anteaya has joined #openstack-zun | 10:31 | |
*** tbh has joined #openstack-zun | 10:43 | |
*** tbh has quit IRC | 10:50 | |
*** janki has quit IRC | 11:05 | |
*** shu-mutou has quit IRC | 11:18 | |
*** sudipto has quit IRC | 11:23 | |
*** sudipto_ has quit IRC | 11:23 | |
*** exploreshaifali has quit IRC | 12:00 | |
*** trinaths has quit IRC | 12:27 | |
*** exploreshaifali has joined #openstack-zun | 12:27 | |
*** catintheroof has joined #openstack-zun | 12:29 | |
*** catinthe_ has joined #openstack-zun | 12:32 | |
*** catintheroof has quit IRC | 12:34 | |
*** exploreshaifali has quit IRC | 12:39 | |
*** catintheroof has joined #openstack-zun | 13:12 | |
*** catinthe_ has quit IRC | 13:16 | |
*** sudipto_ has joined #openstack-zun | 13:18 | |
*** sudipto has joined #openstack-zun | 13:18 | |
*** prameswar_ has joined #openstack-zun | 13:50 | |
*** prameswar_ has left #openstack-zun | 13:53 | |
*** prameswar has joined #openstack-zun | 13:54 | |
*** sudipto_ has quit IRC | 14:35 | |
*** sudipto has quit IRC | 14:35 | |
openstackgerrit | Namrata proposed openstack/zun: Moving inspect image from containers driver to image driver https://review.openstack.org/404546 | 14:35 |
*** devlaps has joined #openstack-zun | 14:52 | |
prameswar | hi i added PS here : https://review.openstack.org/#/c/404558/ . i need to write unit test for that but this https://review.openstack.org/#/c/404558/4/zunclient/v1/containers.py file have similar function create delete start stop etc. that also don't have unit test case . point me if there. so any suggestion "how to write test case and which library i need to use ? | 14:57 |
prameswar | unittest ? | 14:58 |
*** sudipto has joined #openstack-zun | 15:17 | |
*** sudipto_ has joined #openstack-zun | 15:17 | |
*** hongbin has joined #openstack-zun | 15:42 | |
prameswar | hi hongbin , i added PS here : https://review.openstack.org/#/c/404558/ . i need to write unit test for that but this https://review.openstack.org/#/c/404558/4/zunclient/v1/containers.py file have similar function create delete start stop etc. that also don't have unit test case . point me if there. so any suggestion "how to write test case and which library i need to use ? unittest ? | 16:00 |
hongbin | prameswar: ok, let me check | 16:01 |
hongbin | prameswar: that file doesn't seem to have any test in before. you are right | 16:07 |
hongbin | prameswar: i will comment on the review | 16:07 |
prameswar | yes, please | 16:08 |
hongbin | prameswar: done | 16:14 |
prameswar | thanks hongbin | 16:15 |
hongbin | prameswar: for the containers_shell.py , consider adding something like: https://review.openstack.org/#/c/385574/6/zunclient/tests/v1/test_containers_shell.py | 16:15 |
prameswar | ok thanks , i will do | 16:17 |
hongbin | thx | 16:19 |
sudipto_ | hongbin, prameswar my comment on the review, is not about the UT, hopefully you would be alright addressing that. | 16:34 |
sudipto_ | hongbin, have you tried the docker remote APIs? | 16:36 |
hongbin | sudipto_: i think yes. docker-py is using the docker remote APIs | 16:37 |
hongbin | sudipto_: the error is strange, i can only reproduce it in a vm | 16:38 |
hongbin | sudipto_: no in other vms | 16:38 |
sudipto_ | hongbin, ok - the other thing i was looking at is the attach terminal spec - where i was trying to get into the nits of the docker remote APIs and how we could basically look at just specifying the host:port_id of the docker daemon and be able to do all the things on it. | 16:39 |
sudipto_ | hongbin, basically if we can talk to the docker APIs via the host_ip:docker_port - then how do you like the sun-compute agent? | 16:40 |
sudipto_ | as in what's the real use of the sun-compute agent in that case? | 16:40 |
sudipto_ | hongbin, https://docs.docker.com/engine/reference/api/docker_remote_api_v1.21/ | 16:40 |
hongbin | sudipto_: yes, that needs more thinking | 16:41 |
hongbin | sudipto_: maybe zun-compute is not needed at all | 16:41 |
sudipto_ | hongbin, yeah so i paused a bit when i saw that. I am running some experiments right now. | 16:42 |
hongbin | sudipto_: however, we need a way to scale out the deployment (i.e. multiple zun-api , multiple zun-compute) | 16:42 |
sudipto_ | well - in such a case, we could do something like nova-cells. | 16:44 |
sudipto_ | ? | 16:44 |
hongbin | sudipto_: i am not familiar with nova-cells | 16:44 |
sudipto_ | hongbin, http://docs.openstack.org/juno/config-reference/content/section_compute-cells.html some documentation | 16:44 |
sudipto_ | hongbin, we needn't follow this, but in such a case, we may not need a sun-compute for every host. | 16:44 |
sudipto_ | a sun-compute could manage a cluster of hosts. | 16:45 |
sudipto_ | grrr...the auto-correct | 16:45 |
hongbin | sudipto_: yes, that might be possible | 16:45 |
sudipto_ | ok brb post dinner... | 16:46 |
hongbin | sudipto_: but that is for docker . if we move to other container runtime (i.e. OCI), we might need a local agent (i am not sure) | 16:46 |
hongbin | ok | 16:46 |
sudipto_ | hongbin, good point... | 16:46 |
hongbin | sudipto_: in addition, the glance image pulling & loading also needs to be done by a local agent | 16:51 |
*** catintheroof has quit IRC | 17:11 | |
*** catintheroof has joined #openstack-zun | 17:12 | |
sudipto_ | hongbin, yeah i guess, it's ok to not call the remote APIs as such | 17:24 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 17:46 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 17:57 |
*** sudipto_ has quit IRC | 18:06 | |
*** sudipto has quit IRC | 18:06 | |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 18:55 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 19:03 |
openstackgerrit | prameswar proposed openstack/python-zunclient: added run command support at client side https://review.openstack.org/404558 | 19:13 |
*** prameswar has quit IRC | 19:18 | |
*** prameswar has joined #openstack-zun | 19:44 | |
*** catintheroof has quit IRC | 19:54 | |
*** prameswar has quit IRC | 20:10 | |
*** devlaps has quit IRC | 20:36 | |
*** tbh has joined #openstack-zun | 20:38 | |
*** tbh has quit IRC | 20:45 | |
*** catintheroof has joined #openstack-zun | 20:54 | |
*** jayaura has quit IRC | 21:19 | |
*** mkrai has quit IRC | 21:19 | |
*** devlaps has joined #openstack-zun | 21:34 | |
*** hongbin has quit IRC | 22:01 | |
*** Guest32810 has joined #openstack-zun | 22:14 | |
*** mkrai has joined #openstack-zun | 22:26 | |
*** catintheroof has quit IRC | 23:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!