| *** harlowja_ has quit IRC | 00:32 | |
| *** harlowja has joined #openstack-zun | 00:51 | |
| *** zhurong has joined #openstack-zun | 01:13 | |
| *** yanyanhu has joined #openstack-zun | 01:42 | |
| *** gyx has joined #openstack-zun | 01:57 | |
| *** zhangjl has joined #openstack-zun | 02:28 | |
| *** gyx has quit IRC | 02:50 | |
| *** yuanying has quit IRC | 02:50 | |
| *** gyx has joined #openstack-zun | 02:51 | |
| *** harlowja has quit IRC | 02:55 | |
| *** kevinz has joined #openstack-zun | 02:56 | |
| *** kevinz has quit IRC | 03:04 | |
| *** kevinz has joined #openstack-zun | 03:05 | |
| *** kevinz has quit IRC | 03:24 | |
| *** yuanying has joined #openstack-zun | 03:50 | |
| *** yuanying has quit IRC | 03:50 | |
| *** yuanying has joined #openstack-zun | 03:51 | |
| *** pksingh has joined #openstack-zun | 04:17 | |
| *** prameswar has joined #openstack-zun | 04:17 | |
| *** yuanying has quit IRC | 04:23 | |
| *** yuanying has joined #openstack-zun | 04:24 | |
| *** yuanying has quit IRC | 04:24 | |
| *** yuanying has joined #openstack-zun | 04:25 | |
| *** yuanying has quit IRC | 04:25 | |
| *** sudipto has joined #openstack-zun | 04:58 | |
| *** sudipto_ has joined #openstack-zun | 04:58 | |
| *** pksingh has quit IRC | 04:58 | |
| sudipto_ | mkrai, hi there, good morning. | 05:16 |
|---|---|---|
| mkrai | Hi sudipto_ | 05:17 |
| mkrai | Good morning | 05:17 |
| *** yuanying has joined #openstack-zun | 05:26 | |
| *** trinaths has joined #openstack-zun | 05:27 | |
| *** prameswar has quit IRC | 05:29 | |
| *** pksingh has joined #openstack-zun | 05:31 | |
| *** yuanying has quit IRC | 05:35 | |
| *** yuanying has joined #openstack-zun | 05:36 | |
| *** klkumar has joined #openstack-zun | 05:42 | |
| *** yuanying has quit IRC | 05:49 | |
| *** GB21 has joined #openstack-zun | 05:52 | |
| *** kevinz has joined #openstack-zun | 05:54 | |
| *** prameswar has joined #openstack-zun | 06:10 | |
| *** klkumar has quit IRC | 06:14 | |
| *** klkumar has joined #openstack-zun | 06:15 | |
| *** pksingh has quit IRC | 06:17 | |
| *** pksingh has joined #openstack-zun | 06:25 | |
| *** yuanying has joined #openstack-zun | 06:28 | |
| *** pksingh has quit IRC | 06:48 | |
| *** yuanying_ has joined #openstack-zun | 06:55 | |
| *** zhurong has quit IRC | 06:57 | |
| *** zhurong has joined #openstack-zun | 06:58 | |
| *** yuanying has quit IRC | 06:58 | |
| *** prameswar has quit IRC | 07:06 | |
| *** GB21 has quit IRC | 07:09 | |
| *** yuanying_ has quit IRC | 07:14 | |
| *** GB21 has joined #openstack-zun | 07:21 | |
| *** pksingh has joined #openstack-zun | 07:27 | |
| *** janki has joined #openstack-zun | 07:27 | |
| *** GB21 has quit IRC | 07:34 | |
| *** GB21 has joined #openstack-zun | 07:45 | |
| *** GB21 has quit IRC | 07:55 | |
| sudipto_ | mkrai, any reason why - we would like to convert a dictionary, back to a Image dictionary and then back to an Image object? (I understand one is a API image object and another one is the generic Image object) here: https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/images.py#L186 | 08:29 |
| sudipto_ | I am writing a patch to optimise this | 08:31 |
| mkrai | sudipto_: We are not using wsme to validate inputs | 08:38 |
| mkrai | So the Image API class objects help to validate the input | 08:38 |
| mkrai | If you see the types are defined in fields | 08:39 |
| sudipto_ | mkrai, yeah i did see that | 08:39 |
| sudipto_ | mkrai, also - we seem to revalidate the RPC output here: https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/images.py#L87 - is that true/necessary? | 08:46 |
| *** janki has quit IRC | 08:47 | |
| sudipto_ | unset_fields_except -- this method seems to be in api/base i think maybe that compels this to be converted to an "Image" type | 08:48 |
| mkrai | yes | 08:48 |
| mkrai | https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/images.py#L71 | 08:48 |
| mkrai | I was sending the same line ;) | 08:48 |
| pksingh | sudipto: mkrai , i have a blueprint for api validations and all such things, https://blueprints.launchpad.net/zun/+spec/api-json-input-validation | 08:51 |
| pksingh | may be that will handle such issues | 08:51 |
| sudipto_ | sigh! when i remove dictcompat from the Image Object. The problem is - it looses the nature of being a dictionary and hence you can't do L87 | 08:52 |
| sudipto_ | pksingh, that's more like it :) | 08:52 |
| sudipto_ | I get a sense we are converting the objects, way too many times from objects to dict and back | 08:52 |
| *** janki has joined #openstack-zun | 08:53 | |
| mkrai | Yes it seems so. I guess in that case first we need to complete the API validation bp | 08:54 |
| mkrai | And then removing dictcompact would be possible | 08:54 |
| sudipto_ | mkrai, i am going to go ahead and do a patch on the image.py for now - and add a TODO there...but upto you guys - if you want to hold it till the api validation bp is done. | 08:58 |
| mkrai | I think that's fine | 08:58 |
| mkrai | Please go ahead with your fix for dictcompact removal. | 08:59 |
| openstackgerrit | zhangjl proposed openstack/zun: TrivialFix: Replace six.iteritems() with .items() https://review.openstack.org/409036 | 09:03 |
| *** pksingh has quit IRC | 09:04 | |
| *** strigazi_AFK is now known as strigazi | 09:10 | |
| *** pksingh has joined #openstack-zun | 09:11 | |
| openstackgerrit | Sudipta Biswas proposed openstack/zun: Remove dict-compat from the image object https://review.openstack.org/408412 | 09:23 |
| sudipto_ | mkrai, alrite...here's one that i just pushed ^ hopefully jenkins will pass on this. | 09:23 |
| mkrai | let's wait for the gate to pass | 09:25 |
| *** exploreshaifali has joined #openstack-zun | 09:39 | |
| *** yanyanhu has quit IRC | 09:39 | |
| *** pksingh has quit IRC | 09:39 | |
| *** pksingh has joined #openstack-zun | 09:44 | |
| *** zhurong has quit IRC | 09:46 | |
| *** kevinz has quit IRC | 09:46 | |
| sudipto_ | mkrai, the gate seems to have answered. | 09:48 |
| *** GB21 has joined #openstack-zun | 09:49 | |
| *** pksingh has quit IRC | 10:04 | |
| *** pksingh has joined #openstack-zun | 10:11 | |
| *** pksingh has quit IRC | 10:12 | |
| *** pksingh has joined #openstack-zun | 10:12 | |
| openstackgerrit | huhaoran proposed openstack/zun: Add UT for docker driver https://review.openstack.org/409058 | 10:13 |
| openstackgerrit | guo yunxian proposed openstack/zun: Remove unused variables https://review.openstack.org/408502 | 10:18 |
| *** zhangjl has left #openstack-zun | 10:21 | |
| *** tbh has joined #openstack-zun | 10:23 | |
| *** sudipto_ has quit IRC | 10:27 | |
| *** sudipto has quit IRC | 10:27 | |
| *** exploreshaifali has quit IRC | 10:28 | |
| *** prameswar has joined #openstack-zun | 10:29 | |
| *** GB21 has quit IRC | 10:39 | |
| *** janki has quit IRC | 10:47 | |
| *** janki has joined #openstack-zun | 10:58 | |
| *** GB21 has joined #openstack-zun | 11:01 | |
| *** pksingh has quit IRC | 11:07 | |
| *** pksingh has joined #openstack-zun | 11:19 | |
| *** mfedosin has quit IRC | 11:22 | |
| *** pksingh has quit IRC | 11:22 | |
| *** exploreshaifali has joined #openstack-zun | 11:37 | |
| *** klkumar has quit IRC | 11:45 | |
| *** klkumar has joined #openstack-zun | 11:55 | |
| *** exploreshaifali has quit IRC | 12:00 | |
| *** zhangjl has joined #openstack-zun | 12:13 | |
| *** gyx has quit IRC | 12:33 | |
| *** GB21 has quit IRC | 12:40 | |
| *** zhangjl has quit IRC | 12:50 | |
| *** trinaths has quit IRC | 13:03 | |
| *** sudipto_ has joined #openstack-zun | 13:12 | |
| *** sudipto has joined #openstack-zun | 13:12 | |
| *** janki has quit IRC | 13:59 | |
| *** kevinz has joined #openstack-zun | 14:11 | |
| *** GB21 has joined #openstack-zun | 14:45 | |
| *** vikasc has joined #openstack-zun | 15:18 | |
| *** kevinz has quit IRC | 15:19 | |
| *** pksingh has joined #openstack-zun | 15:49 | |
| *** catintheroof has joined #openstack-zun | 15:54 | |
| *** pksingh has quit IRC | 15:55 | |
| *** pksingh has joined #openstack-zun | 15:57 | |
| *** pksingh has quit IRC | 15:59 | |
| *** hongbin has joined #openstack-zun | 15:59 | |
| openstackgerrit | Merged openstack/zun: TrivialFix: Replace six.iteritems() with .items() https://review.openstack.org/409036 | 16:02 |
| *** exploreshaifali has joined #openstack-zun | 16:06 | |
| *** sudipto_ has quit IRC | 16:19 | |
| *** sudipto has quit IRC | 16:19 | |
| *** sudipto has joined #openstack-zun | 16:19 | |
| *** sudipto_ has joined #openstack-zun | 16:20 | |
| *** pksingh has joined #openstack-zun | 16:22 | |
| *** kragniz has quit IRC | 16:32 | |
| *** kragniz has joined #openstack-zun | 16:33 | |
| *** exploreshaifali has quit IRC | 16:56 | |
| *** GB21 has quit IRC | 17:16 | |
| *** klkumar has quit IRC | 17:25 | |
| *** strigazi is now known as strigazi_AFK | 17:43 | |
| *** exploreshaifali has joined #openstack-zun | 17:56 | |
| *** vikasc has quit IRC | 18:00 | |
| *** GB21 has joined #openstack-zun | 18:05 | |
| *** sudipto has quit IRC | 18:17 | |
| *** sudipto_ has quit IRC | 18:17 | |
| *** prameswar has quit IRC | 18:23 | |
| *** prameswar has joined #openstack-zun | 18:27 | |
| *** harlowja has joined #openstack-zun | 18:32 | |
| *** harlowja_ has joined #openstack-zun | 18:34 | |
| *** harlowja has quit IRC | 18:35 | |
| *** GB21 has quit IRC | 18:36 | |
| *** exploreshaifali has quit IRC | 18:38 | |
| *** exploreshaifali has joined #openstack-zun | 18:47 | |
| *** exploreshaifali has quit IRC | 18:51 | |
| *** pksingh has quit IRC | 19:18 | |
| *** openstack has joined #openstack-zun | 19:46 | |
| *** prameswar has quit IRC | 20:32 | |
| *** tbh has quit IRC | 22:08 | |
| openstackgerrit | Hongbin Lu proposed openstack/zun: Enable Nova driver in gate pipeline https://review.openstack.org/409354 | 22:32 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!