openstackgerrit | Hongbin Lu proposed openstack/zun master: [WIP] Add compute node table to DB https://review.openstack.org/436714 | 00:07 |
---|---|---|
*** hongbin has quit IRC | 00:08 | |
*** jwcroppe has joined #openstack-zun | 00:47 | |
*** catintheroof has quit IRC | 00:51 | |
*** Wenzhi has joined #openstack-zun | 00:54 | |
*** Wenzhi has quit IRC | 00:55 | |
*** Wenzhi has joined #openstack-zun | 00:55 | |
openstackgerrit | miaohb proposed openstack/python-zunclient master: Revise the functional env in tox.ini https://review.openstack.org/436275 | 01:05 |
*** kevinz has joined #openstack-zun | 01:15 | |
*** openstackgerrit has quit IRC | 01:23 | |
*** yanyanhu has joined #openstack-zun | 01:40 | |
*** jwcroppe has quit IRC | 02:08 | |
*** jwcroppe has joined #openstack-zun | 02:11 | |
*** jwcroppe has quit IRC | 02:28 | |
*** openstackgerrit has joined #openstack-zun | 02:31 | |
openstackgerrit | feng.shengqin proposed openstack/zun master: Support the command "zun top" https://review.openstack.org/432198 | 02:31 |
*** yuanying has quit IRC | 02:32 | |
*** diga has joined #openstack-zun | 02:36 | |
*** hongbin has joined #openstack-zun | 03:01 | |
*** pksingh has joined #openstack-zun | 03:03 | |
pksingh | hongbin: hello, good evening | 03:03 |
hongbin | pksingh: hey pradeep, sup | 03:03 |
pksingh | hongbin: how was the day? | 03:04 |
hongbin | it is good | 03:04 |
pksingh | hongbin: so at home now? | 03:04 |
hongbin | pksingh: yes | 03:04 |
pksingh | hongbin: good :) | 03:04 |
pksingh | hongbin: i want to have your views on https://review.openstack.org/#/c/428602/ | 03:05 |
hongbin | looking into it | 03:05 |
pksingh | hongbin: i was thinking if non-zero exist code really means invalid command? | 03:05 |
*** diga has quit IRC | 03:08 | |
hongbin | pksingh: i agree with you that we should not return 400 on non-zero return | 03:08 |
*** diga has joined #openstack-zun | 03:08 | |
pksingh | hongbin: currently exec does not support interactive mode, right? | 03:09 |
hongbin | pksingh: i just checked the docker behaviour, it doesn't return 400 as well | 03:09 |
hongbin | pksingh: afaik, no | 03:09 |
hongbin | pksingh: will file a bug for that | 03:09 |
pksingh | hongbin: so i was thinking either we dont fix the bug or return exit code with the output? | 03:10 |
hongbin | pksingh: i think it is better to return exit code with 200 response | 03:10 |
hongbin | pksingh: then, the cli should return the same exit code from the server | 03:11 |
pksingh | hongbin: yes, i think that would be better | 03:11 |
hongbin | so i propose to modify the response as {"output" ",,,,", "exitcode" xx} | 03:12 |
pksingh | hongbin: yes that will be ok as of now | 03:12 |
hongbin | yes, will comment on the review about that | 03:12 |
pksingh | hongbin: ok sure, thnx | 03:12 |
pksingh | hongbin: i have a question related to https://review.openstack.org/#/c/432857/, | 03:14 |
pksingh | hongbin: your comment 'It seems it is uncommon to have an API to pull an image into all hosts.', can you explain it little bit please | 03:15 |
hongbin | pksingh: i mean it is just strange to have this command | 03:15 |
pksingh | hongbin: from beginning i dont like this command, to be honest | 03:16 |
hongbin | pksingh: i was thinking the nova point of view, nova doesn't have api to pull vm images into all hosts, so it is strange | 03:16 |
pksingh | hongbin: but nova dont have such use case | 03:16 |
hongbin | pksingh: yes, perhaps, you are right | 03:16 |
hongbin | pksingh: my concern is that if there is 1000 hosts, pull images down into all hosts will generate a lot of traffic | 03:17 |
pksingh | hongbin: cant we pull the image parallely on all nodes at a time, is it feasible? | 03:17 |
hongbin | pksingh: it might be possible | 03:17 |
openstackgerrit | feng.shengqin proposed openstack/zun master: Zun exec should fail when the command failed https://review.openstack.org/428602 | 03:18 |
hongbin | pksingh: however, i am not a big fan for this api | 03:18 |
pksingh | hongbin: yes you are right, but it will be one time activity, or admin can login to each host and pull the image manually | 03:18 |
hongbin | pksingh: i don't feel strong about this, it can be implemented in that way, i guess it won't matter | 03:19 |
pksingh | hongbin: for now, i think it should take one parameter which is the compute-host name, where it can pull the image | 03:21 |
hongbin | pksingh: it works for me | 03:21 |
pksingh | hongbin: ok, i think that will be good, if the users ask for a single command in future for pulling images on all the nodes at a time, we can implement that latter | 03:22 |
hongbin | pksingh: yes | 03:23 |
pksingh | ok i will put this on review | 03:24 |
pksingh | hongbin: thnx | 03:25 |
hongbin | np | 03:26 |
*** yuanying has joined #openstack-zun | 03:34 | |
*** janki has joined #openstack-zun | 03:55 | |
*** Wenzhi has quit IRC | 04:28 | |
openstackgerrit | Hongbin Lu proposed openstack/zun master: Add compute node table to DB https://review.openstack.org/436714 | 04:51 |
*** hongbin has quit IRC | 04:51 | |
*** sudipto_ has joined #openstack-zun | 04:52 | |
*** sudipto has joined #openstack-zun | 04:52 | |
*** pksingh has quit IRC | 05:35 | |
*** Wenzhi has joined #openstack-zun | 05:41 | |
*** pksingh has joined #openstack-zun | 05:46 | |
openstackgerrit | Merged openstack/python-zunclient master: Handle various permutation of query params https://review.openstack.org/435797 | 06:27 |
openstackgerrit | Merged openstack/python-zunclient master: Add image_driver option to create and run https://review.openstack.org/435138 | 06:28 |
openstackgerrit | Merged openstack/python-zunclient master: Generalize the usage of _remove_null_params https://review.openstack.org/435135 | 06:28 |
*** pksingh has quit IRC | 06:34 | |
*** pksingh has joined #openstack-zun | 06:35 | |
*** pksingh has quit IRC | 06:44 | |
openstackgerrit | feng.shengqin proposed openstack/python-zunclient master: _remove_null_params in OSC needs be synchronized https://review.openstack.org/436799 | 07:25 |
*** yuanying has quit IRC | 07:33 | |
*** pksingh has joined #openstack-zun | 07:51 | |
openstackgerrit | feng.shengqin proposed openstack/python-zunclient master: Update in OSC needs _remove_null_params https://review.openstack.org/436807 | 07:55 |
*** yuanying has joined #openstack-zun | 08:15 | |
openstackgerrit | Eli Qiao proposed openstack/zun master: devstack: restore xtrace in zun nova lib https://review.openstack.org/436818 | 08:23 |
*** Wenzhi has quit IRC | 08:55 | |
openstackgerrit | bhavani proposed openstack/zun master: removed coding: utf-8 https://review.openstack.org/435921 | 09:06 |
*** pksingh has quit IRC | 09:13 | |
*** Wenzhi has joined #openstack-zun | 09:30 | |
*** Wenzhi has quit IRC | 09:34 | |
*** yanyanhu has quit IRC | 10:04 | |
*** kevinz has quit IRC | 10:08 | |
*** himani has joined #openstack-zun | 10:13 | |
*** himani has quit IRC | 10:24 | |
*** pksingh has joined #openstack-zun | 10:55 | |
*** pksingh has quit IRC | 11:15 | |
*** Wenzhi has joined #openstack-zun | 11:23 | |
*** sudipto has quit IRC | 11:25 | |
*** sudipto_ has quit IRC | 11:25 | |
*** Wenzhi has quit IRC | 11:33 | |
*** sudipto_ has joined #openstack-zun | 12:30 | |
*** sudipto has joined #openstack-zun | 12:30 | |
*** sudipto has quit IRC | 13:30 | |
*** sudipto_ has quit IRC | 13:30 | |
*** sudipto_ has joined #openstack-zun | 13:43 | |
*** sudipto has joined #openstack-zun | 13:43 | |
*** zhurong has joined #openstack-zun | 13:47 | |
*** zhurong has quit IRC | 15:07 | |
*** hongbin has joined #openstack-zun | 15:23 | |
*** janki has quit IRC | 15:38 | |
openstackgerrit | Sudipta Biswas proposed openstack/zun master: [DO NOT MERGE] Add ComputeNode Tracker https://review.openstack.org/436572 | 15:40 |
sudipto_ | hongbin, ^ I have added the test cases, but will wait for you to do the schema thinking - hence have suggested to NOT merge this. | 15:42 |
hongbin | sudipto_: ack | 15:43 |
*** catintheroof has joined #openstack-zun | 15:43 | |
hongbin | sudipto_: this is the schema patch: https://review.openstack.org/#/c/436714/ , fixing the gate now | 15:44 |
sudipto_ | Missed the test cases file sigh :( | 15:44 |
openstackgerrit | Hongbin Lu proposed openstack/zun master: Add compute node table to DB https://review.openstack.org/436714 | 15:46 |
*** adisky_ has joined #openstack-zun | 15:50 | |
*** catintheroof has quit IRC | 16:33 | |
*** catintheroof has joined #openstack-zun | 16:38 | |
*** catintheroof has quit IRC | 16:38 | |
*** catintheroof has joined #openstack-zun | 16:38 | |
*** catintheroof has quit IRC | 16:43 | |
*** catintheroof has joined #openstack-zun | 16:53 | |
*** catintheroof has quit IRC | 16:58 | |
*** catintheroof has joined #openstack-zun | 17:15 | |
*** diga has quit IRC | 17:15 | |
*** catintheroof has quit IRC | 17:18 | |
*** catintheroof has joined #openstack-zun | 17:19 | |
openstackgerrit | Sudipta Biswas proposed openstack/zun master: Add ComputeNode Tracker https://review.openstack.org/436572 | 17:48 |
sudipto_ | hongbin, I cherry picked my change on top of yours and posted the patch ^ | 17:49 |
*** irenab has quit IRC | 17:50 | |
*** irenab has joined #openstack-zun | 17:50 | |
sudipto_ | I will review your patch tomorrow morning.. | 17:59 |
*** adisky_ has quit IRC | 17:59 | |
*** sudipto_ has quit IRC | 18:00 | |
*** sudipto has quit IRC | 18:00 | |
*** jwcroppe has joined #openstack-zun | 18:12 | |
*** catintheroof has quit IRC | 19:48 | |
*** jwcroppe has quit IRC | 19:51 | |
*** catintheroof has joined #openstack-zun | 20:11 | |
*** catintheroof has quit IRC | 20:11 | |
*** catintheroof has joined #openstack-zun | 20:12 | |
*** jwcroppe has joined #openstack-zun | 20:27 | |
*** ykuo_ has joined #openstack-zun | 22:04 | |
*** eliqiao has quit IRC | 22:17 | |
*** eliqiao has joined #openstack-zun | 22:18 | |
openstackgerrit | Hongbin Lu proposed openstack/zun master: Generate and register ssl config https://review.openstack.org/437176 | 22:21 |
*** jwcroppe has quit IRC | 22:22 | |
*** jwcroppe has joined #openstack-zun | 22:23 | |
*** jwcroppe has quit IRC | 22:27 | |
*** jwcroppe has joined #openstack-zun | 22:33 | |
*** jwcroppe has quit IRC | 22:37 | |
*** jwcroppe has joined #openstack-zun | 22:44 | |
*** catintheroof has quit IRC | 22:47 | |
*** jwcroppe has quit IRC | 23:01 | |
openstackgerrit | Hongbin Lu proposed openstack/zun master: [WIP] Add wsgi script file and sample config https://review.openstack.org/437190 | 23:37 |
openstackgerrit | Hongbin Lu proposed openstack/zun master: [WIP] Add wsgi script file and sample config https://review.openstack.org/437190 | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!