| *** Shunli has joined #openstack-zun | 00:18 | |
| openstackgerrit | feng.shengqin proposed openstack/python-zunclient master: Add image-list and pull to osc https://review.openstack.org/467861 | 00:53 |
|---|---|---|
| *** yuanying_ has joined #openstack-zun | 01:01 | |
| *** yuanying has quit IRC | 01:02 | |
| *** yuanying_ has quit IRC | 01:30 | |
| *** yuanying has joined #openstack-zun | 01:34 | |
| openstackgerrit | Merged openstack/python-zunclient master: Client support for service-enable/disable https://review.openstack.org/460026 | 01:35 |
| openstackgerrit | miaohb proposed openstack/python-zunclient master: Client support for service force-down https://review.openstack.org/463077 | 01:48 |
| *** zhurong has joined #openstack-zun | 01:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zun master: Updated from global requirements https://review.openstack.org/468251 | 01:59 |
| *** hongbin has joined #openstack-zun | 02:25 | |
| Shunli | @hongbin, there? | 02:29 |
| hongbin | Shunli: hey | 02:29 |
| Shunli | https://review.openstack.org/#/c/467915/ | 02:29 |
| Shunli | you prefer to change to 2.0 API and not compatible with API before 2.0？ | 02:30 |
| Shunli | ? | 02:30 |
| hongbin | Shunli: checking the comments | 02:30 |
| hongbin | Shunli: it version of docker-py is decided by the requirement i think | 02:31 |
| hongbin | Shunli: therefore, right now, the version is 1.x | 02:31 |
| hongbin | Shunli: unless you install by ignoring the requirements.txt, which is not hte practice | 02:32 |
| Shunli | So, you prefer to change requirements to docker-py >2.0, and change the related API call in zun? | 02:32 |
| hongbin | Shunli: I think changing requirements to docker (2.0) is hte only way to go if we want to do the upgrade | 02:34 |
| hongbin | Shunli: otherwise, there is no way to do the version upgrade (if hte requiremnt doesn't change, the version is unchanged) | 02:34 |
| hongbin | Shunli: my point is the version declared in requirement totally decided hte version of hte docker client, so it seems there is no need to use if ... else ... to handle different version | 02:35 |
| hongbin | because there is only one version at a point of view | 02:36 |
| Shunli | for now docker-py=1.x, it maybe 1.x or 2.0. | 02:36 |
| hongbin | https://github.com/openstack/zun/blob/master/requirements.txt#L34 | 02:37 |
| Shunli | I think my patch just make the current code works fine with 2.0 API. | 02:37 |
| Shunli | sorry, I means the installed docker-py maybe 1.x or 2.0 | 02:38 |
| hongbin | i don't think it is possible to install docker-py 2.0 right now | 02:38 |
| hongbin | since the version in https://github.com/openstack/zun/blob/master/requirements.txt#L34 is 1.8.1 | 02:39 |
| hongbin | zun installation will pick docker-py 1.8.1 to install | 02:39 |
| Shunli | it's >=1.8/1 | 02:39 |
| Shunli | 1.8.1 | 02:40 |
| hongbin | Shunli: i see what you mean | 02:40 |
| hongbin | Shunli: however, i think docker-py are all 1.x | 02:40 |
| Shunli | as my devstack shutdown, i restart it and then encoutered the problem. | 02:41 |
| hongbin | Shunli: for docker 2.x, they renamed the package to "docker" (not "docker-py") | 02:41 |
| hongbin | sudo pip install -c /opt/stack/requirements/upper-constraints.txt -e /opt/stack/zun | 02:41 |
| hongbin | the above command is what zun used to do the installation | 02:42 |
| hongbin | i guess it will correct the version back to 1.x | 02:42 |
| Shunli | I checked the docker-py version. | 02:42 |
| hongbin | i see | 02:43 |
| Shunli | there is two, one is docker and version=2.3.0, one is docker-py and version=1.10.6 | 02:43 |
| hongbin | $ sudo pip freeze | grep docker docker-py==1.10.6 | 02:43 |
| hongbin | i see | 02:44 |
| hongbin | i don't have 2.3.0 so i didn't see the problem | 02:44 |
| hongbin | Shunli: ok, if you want to keep both version, i won't disagree with it | 02:45 |
| Shunli | 1.10.6 seems is a broken package on my en. | 02:45 |
| hongbin | i see | 02:45 |
| Shunli | i guess the code called 2.3.0 docker package now | 02:45 |
| hongbin | yes, i want to drop 1.10.6 as well | 02:45 |
| hongbin | Shunli: could you put docker into the requirement.txt as well? | 02:46 |
| Shunli | OK. I think we can compatible with 1.x and 2.x before we complete the 2.0 adopt BP. | 02:47 |
| hongbin | yes, i am fine with it | 02:47 |
| Shunli | sure. | 02:47 |
| hongbin | sounds good | 02:48 |
| Shunli | which docker version should we use now? | 02:48 |
| hongbin | Shunli: thanks for bringing up the issue, sorry i didn't recognize it for a while | 02:48 |
| hongbin | the version in hte reqiurement is the version we should use | 02:48 |
| hongbin | that is docker-py >= 1.8.1 | 02:49 |
| Shunli | ah, the 'docker' you mean is the py wrapper of the docker client, right、 | 02:50 |
| Shunli | the one client which package name is docker? | 02:50 |
| *** vikasc has joined #openstack-zun | 02:50 | |
| hongbin | "docker" was renamed from "docker-py" | 02:50 |
| Shunli | I miss understanding it to docker-engine. | 02:50 |
| *** yuanying has quit IRC | 02:51 | |
| hongbin | oh, it is not the docker daemin, it is the version of hte docker python client | 02:51 |
| Shunli | OK, i see. | 02:51 |
| hongbin | for docker daemon, it is declared by the docker api version i think | 02:51 |
| hongbin | https://github.com/openstack/zun/blob/master/zun/conf/docker.py#L22 | 02:52 |
| hongbin | it is 1.23 | 02:52 |
| Shunli | ack, thx | 02:52 |
| hongbin | np | 02:52 |
| *** yuanying_ has joined #openstack-zun | 02:55 | |
| *** XueFeng has joined #openstack-zun | 03:49 | |
| openstackgerrit | Merged openstack/zun-ui master: Add images panel into admin dashboard https://review.openstack.org/467916 | 03:53 |
| *** hongbin has quit IRC | 04:04 | |
| *** zhurong has quit IRC | 04:07 | |
| openstackgerrit | Merged openstack/zun master: Updated from global requirements https://review.openstack.org/468251 | 04:41 |
| *** zhurong has joined #openstack-zun | 04:45 | |
| *** yuanying_ has quit IRC | 04:57 | |
| *** yuanying has joined #openstack-zun | 04:57 | |
| *** janki has joined #openstack-zun | 05:04 | |
| *** yuanying has quit IRC | 05:23 | |
| *** goku has joined #openstack-zun | 05:29 | |
| *** yuanying has joined #openstack-zun | 05:29 | |
| *** himani has quit IRC | 05:35 | |
| *** himani has joined #openstack-zun | 05:47 | |
| *** yuanying has quit IRC | 06:02 | |
| *** yuanying has joined #openstack-zun | 06:05 | |
| *** shu-mutou-AWAY has quit IRC | 06:07 | |
| *** zhurong has quit IRC | 06:54 | |
| *** zhurong has joined #openstack-zun | 06:59 | |
| *** XueFeng has quit IRC | 07:17 | |
| *** egonzalez has joined #openstack-zun | 07:27 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** Namrata has joined #openstack-zun | 08:06 | |
| *** Shunli has quit IRC | 08:10 | |
| *** Shunli has joined #openstack-zun | 08:11 | |
| *** openstackgerrit has joined #openstack-zun | 09:04 | |
| openstackgerrit | Merged openstack/zun master: Raise ImageNotFound when image not found in docker https://review.openstack.org/467107 | 09:04 |
| *** zhurong has quit IRC | 09:19 | |
| *** Shunli has quit IRC | 09:27 | |
| *** caowei has joined #openstack-zun | 10:17 | |
| openstackgerrit | Rajat Sharma proposed openstack/zun master: Replace assertEqual([], items) with assertEmpty(items) https://review.openstack.org/468358 | 10:55 |
| *** Qiming has quit IRC | 11:01 | |
| *** Qiming has joined #openstack-zun | 11:06 | |
| *** caowei has quit IRC | 11:13 | |
| *** Qiming has quit IRC | 11:22 | |
| *** Qiming has joined #openstack-zun | 11:26 | |
| *** Qiming has quit IRC | 11:30 | |
| *** Qiming has joined #openstack-zun | 11:34 | |
| *** Qiming has quit IRC | 11:41 | |
| *** Qiming has joined #openstack-zun | 11:47 | |
| *** Qiming has quit IRC | 11:52 | |
| *** Qiming has joined #openstack-zun | 11:53 | |
| *** Qiming_ has joined #openstack-zun | 11:54 | |
| *** Qiming has quit IRC | 11:58 | |
| *** Namrata has quit IRC | 12:53 | |
| *** dims has quit IRC | 13:07 | |
| *** goku has quit IRC | 13:19 | |
| *** jwcroppe has quit IRC | 13:56 | |
| *** jwcroppe has joined #openstack-zun | 13:57 | |
| *** jwcroppe has quit IRC | 14:01 | |
| *** dims has joined #openstack-zun | 14:04 | |
| *** jwcroppe has joined #openstack-zun | 14:17 | |
| *** hongbin has joined #openstack-zun | 14:24 | |
| *** jwcroppe has quit IRC | 14:44 | |
| *** jwcroppe has joined #openstack-zun | 14:44 | |
| *** jwcroppe_ has joined #openstack-zun | 14:48 | |
| *** jwcroppe has quit IRC | 14:49 | |
| *** janki has quit IRC | 15:08 | |
| *** egonzalez has quit IRC | 15:35 | |
| *** janki has joined #openstack-zun | 15:46 | |
| *** jwcroppe_ has quit IRC | 17:50 | |
| *** janki has quit IRC | 18:43 | |
| openstackgerrit | Hongbin Lu proposed openstack/zun master: [WIP] Add more tempest tests for container run https://review.openstack.org/468214 | 19:15 |
| *** adisky_ has quit IRC | 19:29 | |
| *** jwcroppe_ has joined #openstack-zun | 19:39 | |
| *** catintheroof has joined #openstack-zun | 21:33 | |
| *** catintheroof has quit IRC | 21:39 | |
| openstackgerrit | Hongbin Lu proposed openstack/zun master: Add more tempest tests for container run https://review.openstack.org/468214 | 22:38 |
| *** hongbin has quit IRC | 23:21 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!