| *** mhen_ is now known as mhen | 02:57 | |
| frickler | yosal_: starting with the last question: some people publish their IRC name on their membership profile, so you can check https://openinfra.dev/a/community/members. | 07:49 |
|---|---|---|
| frickler | but also lots of developer are not on IRC | 07:50 |
| frickler | how reviewers are notified depends on their settings, most should notice comments and react to them within a reasonable time, which I'd consider to be a couple of days. if you do not get a response after that, asking on IRC is a good option | 07:51 |
| frickler | there are no strict rules on when to mark a discussion as done. when in doubt, you can leave it open | 07:52 |
| frickler | the difference between "reply" and "quote" is just that the latter includes a copy of the previous comment in case you want to reply very spicifically to that | 07:53 |
| frickler | "ack" generates a reply with content "ack", just as a shortcut. "done" is similar, but also sets the "done" flag | 07:54 |
| frickler | all of these are good questions and we should likely include these in our documentation, thanks for bringing them up | 07:55 |
| frickler | fungi: ^^ do you want to pick this up as part of bridging-the-gap? | 07:56 |
| yosal_ | Thank you very much | 08:03 |
| fungi | frickler: i guess the takeaway is that contributor documentation could refer to gerrit ui documentation like https://review.opendev.org/Documentation/user-review-ui.html#inline-comments (that talks about reply vs quote vs ack...) | 11:29 |
| frickler | ah, that link doesn't actually take me to the anchor, that was a bit confusing. but yes, that might be good to link to, however the more important part for me would be to explain a bit the expected social contract | 12:25 |
| fungi | interesting, the ui implies that should be a linkable heading (i copied the link from the little chain-link icon that appears next to it) | 15:07 |
| fungi | and yeah, agreed, maybe the social interactions go in the contributor guide and then we link from there to the ui documentation. i'm mainly just wary of duplicating gerrit's own documentation, especially since it changes over time and then we end up with divergent instructions | 15:09 |
| Yosef | Very interesting document | 15:48 |
| Gues__________________________ | ... | 18:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!