*** dobson has joined #openvswitch | 00:11 | |
*** vdasari has joined #openvswitch | 01:11 | |
*** ihrachys has quit IRC | 01:12 | |
*** vdasari has quit IRC | 01:19 | |
*** vdasari has joined #openvswitch | 01:20 | |
*** vdasari has quit IRC | 01:24 | |
*** vdasari has joined #openvswitch | 01:24 | |
*** vdasari has quit IRC | 01:28 | |
*** vdasari has joined #openvswitch | 01:28 | |
*** dalvarez has quit IRC | 01:48 | |
*** dholler has quit IRC | 02:07 | |
*** dholler has joined #openvswitch | 02:19 | |
*** dalvarez has joined #openvswitch | 02:30 | |
*** acidfu_ has quit IRC | 02:40 | |
*** psahoo has joined #openvswitch | 02:50 | |
*** vdasari has quit IRC | 03:06 | |
*** zhouhan_ has quit IRC | 03:35 | |
*** zhouhan_ has joined #openvswitch | 03:37 | |
*** anilvenkata has joined #openvswitch | 04:55 | |
*** lamawithonel has quit IRC | 05:07 | |
*** mmichelson has quit IRC | 05:29 | |
*** links has joined #openvswitch | 05:36 | |
*** mmichelson has joined #openvswitch | 05:41 | |
*** psahoo has quit IRC | 05:47 | |
*** anilvenkata_ has joined #openvswitch | 05:53 | |
*** psahoo has joined #openvswitch | 05:55 | |
*** anilvenkata has quit IRC | 05:56 | |
*** eelco has joined #openvswitch | 06:02 | |
*** anilvenkata has joined #openvswitch | 06:05 | |
*** anilvenkata_ has quit IRC | 06:06 | |
*** psahoo has quit IRC | 06:33 | |
*** psahoo has joined #openvswitch | 06:36 | |
*** anilvenkata has quit IRC | 06:38 | |
*** anilvenkata has joined #openvswitch | 06:38 | |
*** mmirecki has joined #openvswitch | 06:47 | |
*** slaweq has joined #openvswitch | 07:09 | |
*** psahoo has quit IRC | 07:29 | |
*** psahoo has joined #openvswitch | 07:37 | |
*** dceara has joined #openvswitch | 07:51 | |
*** jaicaa has quit IRC | 08:14 | |
*** jaicaa has joined #openvswitch | 08:17 | |
*** gmg has joined #openvswitch | 08:27 | |
*** gmg has quit IRC | 08:55 | |
*** timothy has joined #openvswitch | 09:27 | |
*** jraju__ has joined #openvswitch | 10:05 | |
*** links has quit IRC | 10:05 | |
*** zhouhan_ has quit IRC | 10:17 | |
*** zhouhan has joined #openvswitch | 10:17 | |
numans | bern, probably you can explore OVN :) | 10:17 |
---|---|---|
bern | numans: thanks, there are so many rabbit holes for me to explore during lockdown ;) | 10:20 |
numans | :) | 10:20 |
bern | I hope to be able to blog something along the lines of ovs for mortals | 10:20 |
bern | at (that mythical) some point | 10:21 |
bern | I watched the video flaviof posted yesterday; I will need to watch it again. If I can understand enough about OVN/OVS/Faucet with the knowledge I already have about enterprise networking, I hope to invent whole new rabbit holes and hopefully even emerge with something useful. | 10:23 |
numans | All the best. | 10:23 |
bern | :) | 10:23 |
*** JamesBenson has joined #openvswitch | 11:41 | |
*** psahoo has quit IRC | 12:08 | |
*** psahoo has joined #openvswitch | 12:25 | |
*** troulouliou_div2 has joined #openvswitch | 12:32 | |
*** ihrachys has joined #openvswitch | 12:36 | |
*** vdasari has joined #openvswitch | 12:53 | |
*** bostondriver has joined #openvswitch | 13:01 | |
*** psahoo has quit IRC | 13:03 | |
*** acidfu_ has joined #openvswitch | 13:09 | |
*** jraju__ has quit IRC | 13:22 | |
*** vdasari has quit IRC | 13:23 | |
*** matteo has quit IRC | 14:10 | |
*** matteo has joined #openvswitch | 14:11 | |
*** mmirecki has quit IRC | 14:16 | |
*** dcbw has joined #openvswitch | 14:19 | |
*** gmg has joined #openvswitch | 14:47 | |
*** gmg has quit IRC | 14:49 | |
*** slaweq has quit IRC | 15:06 | |
*** slaweq has joined #openvswitch | 15:11 | |
*** eelco has quit IRC | 15:15 | |
*** gmg1 has joined #openvswitch | 15:38 | |
*** gregwork has joined #openvswitch | 16:03 | |
*** acidfoo_ has joined #openvswitch | 16:16 | |
*** acidfu_ has quit IRC | 16:17 | |
*** zhouhan_ has joined #openvswitch | 16:51 | |
*** dholler has quit IRC | 16:53 | |
*** zhouhan has quit IRC | 16:55 | |
*** timothy has quit IRC | 17:07 | |
*** ryzhyk has joined #openvswitch | 17:14 | |
mmichelson | Hi everyone, I'm going to start the meeting | 17:14 |
*** blp has joined #openvswitch | 17:14 | |
_lore_ | hi all | 17:14 |
blp | Morning all. | 17:14 |
mmichelson | #startmeeting ovn-community-development-discussion | 17:14 |
openstack | Meeting started Thu May 14 17:14:56 2020 UTC and is due to finish in 60 minutes. The chair is mmichelson. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:14 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:14 |
openstack | The meeting name has been set to 'ovn_community_development_discussion' | 17:15 |
mmichelson | Just as a reminder, we're coming up on hard freeze. Thanks to everyone for mentioning which patches they want included in 20.06 | 17:15 |
mmichelson | I'm planning to spend time today and tomorrow to help with the review effort on those patches | 17:15 |
mmichelson | I plan to create the 20.06 branch on Monday | 17:16 |
mmichelson | As far as my activity goes, After doing the GROUP_MOD message split patch, I took on some of the smaller issues that have been reported as of late. Thanks to everyone who has helped review those patches | 17:16 |
mmichelson | And that's all from me. | 17:17 |
blp | I have a quick update. | 17:17 |
blp | I rebased the OVN DDlog code against master earlier this week. All the tests pass. | 17:17 |
blp | ryzhyk has been working on performance. | 17:17 |
blp | That's all I have for the moment, unless there are questions. | 17:18 |
ryzhyk | Yes, I am making progress on performance, but we need scale tests. | 17:18 |
mmichelson | blp, ryzhyk awesome! | 17:18 |
ryzhyk | So far I've been using Han's old scale test log, but it is getting increasingly irrelevant with all the changes to OVN since it was created. | 17:19 |
ryzhyk | (that's it from me) | 17:19 |
numans | ryzhyk, If you want explore this one - https://github.com/dceara/ovn-heater | 17:20 |
numans | for the scale testing. | 17:20 |
ryzhyk | numans: thanks! | 17:20 |
numans | But we are planning to run a scale test with the ddlog changes. We need to figure out a way to compile ovn-northd-ddlog in the container images. Once that is done, it should be straightforward. | 17:21 |
numans | I can go real quick. | 17:21 |
blp | Yeah, we'll do some preliminary work and then we can figure out how to do that. | 17:21 |
numans | Ok. sounds good. | 17:22 |
numans | I did some reviews this week. And I spent much of the time refactoring/reworking on patch 1 and 2 of my I-P patch series | 17:22 |
numans | Thanks to dceara for the reviews. | 17:22 |
numans | I'll continue to do that and planning to submit v6 by tomorrow. | 17:23 |
numans | I appreciate more reviewers joining in :). | 17:23 |
numans | That's it from me. | 17:23 |
dceara | hi all | 17:24 |
*** zhouhan_ has quit IRC | 17:25 | |
dceara | numans, ryzhyk I can hack ovn-heater to compile ovn-northd-ddlog for the scale test container images. I just need to know what branches to use | 17:25 |
*** zhouhan has joined #openvswitch | 17:25 | |
zhouhan | numans: sorry that I didn't get time to review your I-P patches last week. I will resume this week. | 17:25 |
numans | zhouhan, thanks. | 17:25 |
blp | dceara: We're in a little bit of a transition at the moment, we'll get back to you on that. | 17:26 |
dceara | blp, sure | 17:26 |
zhouhan | can someone pin the link to the meeting logs? | 17:27 |
mmichelson | zhouhan, I don't understand what you mean by "pin" | 17:28 |
flaviof | zhouhan: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ | 17:28 |
numans | flaviof, you forgot to use the #link :) | 17:28 |
flaviof | LOL | 17:28 |
zhouhan | mmichelson: I meant, pin in this IRC channel, like the "FAQ: http://docs.openvswitch.org/en/latest/faq/" | 17:29 |
flaviof | there is a handy link to that dir in ovn.org too | 17:29 |
zhouhan | thanks flaviof | 17:29 |
mmichelson | ah ok | 17:29 |
zhouhan | May I go next? | 17:30 |
mmichelson | #topic Open vSwitch, a Linux Foundation Collaborative Project || FAQ: http://docs.openvswitch.org/en/latest/faq/ || Hyper-V meeting Tues 10:00 Pacific || OVN meeting Thurs 10:15 am US Pacific || Use ovs-discuss@openvswitch.org for questions if you don't get an answer here. || OVN weekly meeting logs can be found at: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/ | 17:30 |
mmichelson | oh crap it's /topic isn't it | 17:30 |
mmichelson | And I don't have permission | 17:31 |
mmichelson | zhouhan, go ahead | 17:31 |
zhouhan | Firstly I have a question regarding the OVS FAQ on the compatibility | 17:31 |
blp | I can change the topic. | 17:31 |
zhouhan | 2.11.x3.10 to 4.18 | 17:31 |
zhouhan | 2.12.x3.10 to 5.0 | 17:31 |
zhouhan | 2.14.x3.10 to 5.5 | 17:31 |
*** ChanServ sets mode: +o blp | 17:31 | |
zhouhan | It didn't mention 2.13, why is that? | 17:31 |
*** blp changes topic to "Open vSwitch, a Linux Foundation Collaborative Project || FAQ: http://docs.openvswitch.org/en/latest/faq/ || Hyper-V meeting Tues 10:00 Pacific || OVN meeting Thurs 10:15 am US Pacific || Use ovs-discuss@openvswitch.org for questions if you don't get an answer here. || OVN weekly meeting logs can be found at: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/" | 17:31 | |
zhouhan | blp: do you know? | 17:31 |
*** ChanServ sets mode: -o blp | 17:32 | |
flaviof | blp++ | 17:32 |
*** dcbw has quit IRC | 17:32 | |
blp | zhouhan: Probably just overlooked. | 17:32 |
zhouhan | We tried 2.13 compiling with 5.4, it has a message: configure: error: Linux kernel in /lib/modules/5.4.0-31.generic.x86_64/build is version 5.4.0, but version newer than 5.0.x is not supported (please refer to the FAQ for advice) | 17:33 |
zhouhan | So it seems not an overlook, but on purpose ... | 17:33 |
zhouhan | It's confusing though | 17:33 |
zhouhan | I continued debugging the problem of: deferred action limit reached, drop record action | 17:34 |
blp | zhouhan: It looks like 2.13.x supports the same versions as 2.12.x. | 17:34 |
zhouhan | ok, thanks blp | 17:35 |
zhouhan | I think I made some progress on the endless recirc problem. The issue was that there is slowpath required for the actions while there is also a group action which requires dp_hash + recirc | 17:35 |
blp | OK, I sent a patch to update the FAQ. | 17:36 |
blp | zhouhan: Oh that's a little awkward. Do you have a lead on a fix? | 17:36 |
zhouhan | Whenever this combination comes, it tries to execute dp_hash in userspace, and only do recirc in kernel | 17:36 |
zhouhan | However, the usespace hash generated is not carried for injecting the packet to datapath, so after recirc back, the upcall doesn't have dp_hash value, again. | 17:37 |
blp | Oh. Have you figured out why we don't pass the dp_hash back? | 17:38 |
zhouhan | So when it hits the same group action, it generates recirc and dp_hash actions again | 17:38 |
blp | Is that the easy fix? | 17:38 |
zhouhan | At this time, the recirc_id generated is the same as the older one because all the metadata in state is the same, which caused the loop | 17:38 |
zhouhan | blp: I haven't got time on the fix yet. | 17:39 |
zhouhan | blp: I think there are two options | 17:39 |
blp | Userspace does know how to put dp_hash into a flow, see odp_flow_key_from_flow__(). | 17:39 |
zhouhan | thanks for the pointer! | 17:39 |
blp | It will do so if it detects recirc support in the datapath. Perhaps it's not being detected properly? | 17:40 |
blp | I think we log whether that feature is detected as supported. Check the log, if that's the problem then we should fix the detection logic. | 17:40 |
zhouhan | I think this is one option. The other option is always do dp_hash in datapath instead of "trying to help" in userspace | 17:40 |
blp | I think there is some reason why we do that, although I don't recall what it was. | 17:40 |
zhouhan | I wonder if dp_hash anyway requires recirc in datapath, why would it help by doing dp_hash in userspace | 17:41 |
* numans says bye and disappears. | 17:41 | |
blp | What's the reason that it gets slow-pathed to begin with? | 17:41 |
zhouhan | The other question is why is there slowpath required in the first place | 17:41 |
* blp waves at numans | 17:42 | |
zhouhan | blp: exactly | 17:42 |
blp | "trace" should explain the reason for slow-pathing. | 17:42 |
zhouhan | blp: the scenario is ping LRP's IP. The LR is replying ICMP by simply setting fields, and I can't tell why is slowpath needed | 17:43 |
blp | Some fields aren't supported for setting in the datapath, that could be the reason. | 17:43 |
blp | But ofproto/trace should say. For example, if it's because of fields that the datapath can't set, it should say something about unsupported actions. | 17:44 |
imaximets | blp, zhouhan: execute.hash that passed back to datapath could only be set from the upcall->hash, i.e. the hash that received from the datapath during upcall. Userspace never passes dp_hash that calculated by userspace to datapath, it only returns same hash that was calculated by datapath itself before upcall. | 17:44 |
zhouhan | blp: ofproto/trace only tells slowpath needed, but didn't tell which action requires that. | 17:44 |
blp | OK, it should be possible to figure it out. Do you have the trace handy? | 17:45 |
zhouhan | imaximets: is it possible to pass it back (i.e. is it a small fix?) | 17:45 |
zhouhan | Final flow: icmp,reg11=0xe,reg12=0x18,reg14=0xa,reg15=0x11,tun_id=0xa0011ff0002,tun_src=10.172.66.12,tun_dst=10.78.211.43,tun_ipv6_src=::,tun_ipv6_dst=::,tun_gbp_id=0,tun_gbp_flags=0,tun_tos=0,tun_ttl=0,tun_erspan_ver=0,tun_flags=csum|key,metadata=0xff0002,in_port=457,vlan_tci=0x0000,dl_src=aa:aa:bb:00:01:02,dl_dst=aa:aa:bb:00:03:01,nw_src=10.227.183.232,nw_dst=10.9.0.1,nw_tos=0,nw_ecn=0,nw_ttl=53,icmp_type=8,icmp_code=0 | 17:45 |
zhouhan | Megaflow: recirc_id=0,eth,icmp,tun_id=0xa0011ff0002,tun_src=10.172.66.12,tun_dst=10.78.211.43,tun_tos=0,tun_flags=-df+csum+key,in_port=457,vlan_tci=0x0000/0x1000,dl_src=aa:aa:bb:00:01:02,dl_dst=aa:aa:bb:00:03:01,nw_src=10.227.183.232,nw_dst=10.9.0.1,nw_ttl=53,nw_frag=no,icmp_type=0x8/0xff,icmp_code=0x0/0xff | 17:45 |
zhouhan | Datapath actions: ct_clear,ct_clear,ct_clear,set(eth(src=aa:aa:aa:00:01:01,dst=aa:aa:aa:00:00:01)),set(ipv4(src=10.9.0.1,dst=10.227.183.232,ttl=254)),set(icmp(type=0,code=0)),hash(l4(0)),recirc(0x3) | 17:45 |
zhouhan | This flow is handled by the userspace slow path because it: | 17:46 |
zhouhan | - Uses action(s) not supported by datapath. | 17:46 |
blp | It's not a good idea to pass a userspace-caluclated hash back to the kernel because the kernel would calculate a different value. | 17:46 |
zhouhan | blp: This is the last part of trace | 17:46 |
imaximets | zhouhan, I'm not sure. It might be possible to check if we have no upcall->hash, but have dp_hash and pass dp_hash to execute.hash instead, but I'm not sure. | 17:46 |
zhouhan | blp: imaximets: Then do you think it is a better idea to always do dp_hash in datapath? | 17:46 |
imaximets | zhouhan, I think, yes, it's better than 'datapath hash' is calculated by datapath. | 17:47 |
zhouhan | (sorry this might have taken too long, in case someone else want to update) | 17:47 |
blp | It's the set actions for ICMP that are doing it. The datapath doesn't know how to change ICMP. | 17:48 |
imaximets | s/than/when/ | 17:48 |
zhouhan | blp: is it the ICMP fields setting require slowpath? | 17:49 |
blp | zhouhan: yes | 17:49 |
zhouhan | blp: ok, thanks! | 17:49 |
zhouhan | blp: it would be better if trace can just point this out :) | 17:49 |
blp | zhouhan: yes | 17:49 |
zhouhan | other than this, I was involved in some discussions and also trying to fix some bugs in ovn. | 17:50 |
*** acidfoo_ has quit IRC | 17:50 | |
zhouhan | One of the discussion was about ARP flows exploding in LRs. I think I can work out the configurably disable static ARP resolve in LR, which would solve the issue for ovn-k8s. | 17:51 |
zhouhan | That's my update :) | 17:51 |
*** acidfoo_ has joined #openvswitch | 17:51 | |
_lore_ | zhouhan: regarding gateway flow issue, IIRC this chunks was to distribute non DVR traffic | 17:52 |
zhouhan | _lore_: I got your point, but why was different prirority needed? | 17:52 |
_lore_ | I need to get back to it since I can't recall the details now | 17:53 |
zhouhan | _lore_: ok, thanks! | 17:53 |
zhouhan | _lore_: It seems an optimization, right? | 17:53 |
_lore_ | nope | 17:53 |
_lore_ | let's say you have FIP 192.168.1.1 | 17:54 |
_lore_ | this is to distribute traffic for 192.168.1.0/24 IIRC | 17:54 |
_lore_ | but I will check | 17:54 |
zhouhan | _lore_: ok, I was thinking we could revert it, if it is an optimization and if we couldn't solve the route priority problem before the release | 17:54 |
_lore_ | what is the issue you are facing? | 17:55 |
zhouhan | _lore_: If you see my example, the /16 route is overriding the /24 route, which is wrong | 17:55 |
_lore_ | ack | 17:56 |
_lore_ | I will look into it | 17:56 |
zhouhan | thanks _lore_ | 17:56 |
_lore_ | yw :) | 17:56 |
*** ryzhyk has quit IRC | 17:57 | |
_lore_ | zhouhan: do you have a unit-test for it? | 17:57 |
zhouhan | _lore_: here is what I did in a sandbox: | 17:59 |
zhouhan | 989 ovn-nbctl lr-add lr1 | 17:59 |
zhouhan | 990 ovn-nbctl lrp-add lr1 lrp1 aa:aa:aa:aa:aa:01 192.168.0.1/24 | 17:59 |
zhouhan | 991 ovn-nbctl lrp-add lr1 lrp2 aa:aa:aa:aa:aa:02 192.168.100.1/24 | 17:59 |
zhouhan | 992 ovn-nbctl lr-route-add lr1 10.0.0.0/24 192.168.0.2 | 17:59 |
zhouhan | 993 ovn-nbctl lr-route-add lr1 10.0.0.0/16 192.168.100.2 | 17:59 |
zhouhan | 994 ovn-sbctl lflow-list | 17:59 |
zhouhan | 995 ovn-nbctl --help | grep gateway | 17:59 |
zhouhan | 996 ovn-sbctl show | 17:59 |
zhouhan | 997 ovn-nbctl lrp-set-gateway-chassis lrp1 chassis-1 | 17:59 |
zhouhan | 998 ovn-sbctl lflow-list | 17:59 |
_lore_ | ok, thx | 17:59 |
_lore_ | I think we should add some unitest for it | 18:00 |
blp | _lore_: please! | 18:02 |
_lore_ | will do :) | 18:02 |
*** acidfoo_ has quit IRC | 18:03 | |
mmichelson | Anyone else want to take a turn at the mic? | 18:05 |
flaviof | bye all! | 18:06 |
blp | bye! | 18:09 |
dceara | bye! | 18:10 |
mmichelson | #endmeeting | 18:11 |
openstack | Meeting ended Thu May 14 18:11:20 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:11 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-05-14-17.14.html | 18:11 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-05-14-17.14.txt | 18:11 |
openstack | Log: http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-05-14-17.14.log.html | 18:11 |
*** acidfoo_ has joined #openvswitch | 18:30 | |
*** dceara has quit IRC | 18:53 | |
*** anilvenkata has quit IRC | 19:17 | |
*** slaweq has quit IRC | 19:51 | |
*** slaweq has joined #openvswitch | 19:59 | |
*** mmirecki has joined #openvswitch | 20:20 | |
*** mmirecki has quit IRC | 20:44 | |
*** gmg1 has quit IRC | 21:22 | |
*** JamesBenson has quit IRC | 21:34 | |
*** acidfoo_ has quit IRC | 21:40 | |
*** slaweq has quit IRC | 22:02 | |
*** tbachman_ has joined #openvswitch | 22:05 | |
*** tbachman has quit IRC | 22:05 | |
*** tbachman_ is now known as tbachman | 22:05 | |
*** dceara has joined #openvswitch | 22:11 | |
*** dceara has quit IRC | 22:28 | |
*** acidfoo_ has joined #openvswitch | 22:45 | |
*** tbachman_ has joined #openvswitch | 22:52 | |
*** tbachman has quit IRC | 22:53 | |
*** tbachman_ is now known as tbachman | 22:53 | |
*** bostondriver has quit IRC | 23:04 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!