Thursday, 2020-08-13

*** yamamoto has joined #openvswitch00:00
*** yamamoto has quit IRC00:05
*** |subz3r0| has quit IRC00:12
*** webczat has quit IRC00:13
*** |subz3r0| has joined #openvswitch00:29
*** |subz3r0| has joined #openvswitch00:29
*** |subz3r0| has quit IRC00:34
*** |subz3r0| has joined #openvswitch00:35
*** |subz3r0| has joined #openvswitch00:35
*** rcernin has quit IRC01:11
*** rcernin has joined #openvswitch01:11
*** yamamoto has joined #openvswitch01:52
*** zhouhan_ has quit IRC02:50
*** zhouhan has joined #openvswitch02:51
*** rcernin has quit IRC03:06
*** armax has quit IRC03:08
*** dcbw has quit IRC03:33
*** rcernin has joined #openvswitch03:52
*** psahoo has joined #openvswitch03:52
*** yamamoto has quit IRC04:36
*** yamamoto has joined #openvswitch04:39
*** anilvenkata has joined #openvswitch05:23
*** JamesBenson has quit IRC05:25
*** JamesBenson has joined #openvswitch05:27
*** JamesBenson has quit IRC05:31
*** dholler has joined #openvswitch05:43
*** jaicaa has quit IRC06:07
*** jaicaa has joined #openvswitch06:10
*** Limech has quit IRC06:31
*** psahoo_ has joined #openvswitch06:33
*** psahoo_ has quit IRC06:40
*** slaweq has joined #openvswitch06:46
*** psahoo_ has joined #openvswitch06:47
*** psahoo has quit IRC06:48
*** JamesBenson has joined #openvswitch06:50
*** zhouhan has quit IRC06:54
*** zhouhan has joined #openvswitch06:54
*** JamesBenson has quit IRC06:55
*** dholler has quit IRC06:56
*** dholler has joined #openvswitch06:56
*** maciejjozefczyk has joined #openvswitch06:57
*** dholler has quit IRC06:58
*** dholler has joined #openvswitch06:59
*** psahoo has joined #openvswitch07:26
*** zhouhan_ has joined #openvswitch07:50
*** zhouhan has quit IRC07:53
*** jpwgarrison has quit IRC07:54
*** jpwgarrison has joined #openvswitch07:54
*** maciejjozefczyk_ has joined #openvswitch08:14
*** maciejjozefczyk has quit IRC08:15
*** maciejjozefczyk has joined #openvswitch08:15
*** maciejjozefczyk_ has quit IRC08:19
*** psahoo_ has quit IRC08:43
*** JamesBenson has joined #openvswitch08:51
*** JamesBenson has quit IRC08:56
*** links has joined #openvswitch09:03
*** rcernin has quit IRC09:05
*** psahoo_ has joined #openvswitch09:05
*** JamesBenson has joined #openvswitch09:26
*** JamesBenson has quit IRC09:30
*** rcernin has joined #openvswitch09:58
*** rcernin has quit IRC10:40
*** rcernin has joined #openvswitch10:48
*** rcernin has quit IRC11:00
*** yamamoto has quit IRC11:01
*** yamamoto has joined #openvswitch11:23
*** yamamoto has quit IRC11:29
*** bostondriver has joined #openvswitch11:59
*** yamamoto has joined #openvswitch12:03
*** webczat has joined #openvswitch12:05
*** yamamoto has quit IRC12:11
*** acidfu has joined #openvswitch12:40
*** riuzen has joined #openvswitch12:46
*** JamesBenson has joined #openvswitch12:46
*** JamesBenson has quit IRC12:51
riuzenHi, I wanna create ovn cluster for my 3nodes Openstack controller. Is it enough just using pacemaker to make my ovn db on active-stanby? Or, I also have to create ovsdb cluster replication?12:51
*** zhouhan has joined #openvswitch12:57
*** zhouhan_ has quit IRC12:59
*** JamesBenson has joined #openvswitch13:01
*** fbl has quit IRC14:17
*** fbl has joined #openvswitch14:23
*** riuzen has quit IRC14:35
*** armax has joined #openvswitch14:40
*** psahoo has quit IRC14:44
*** JamesBen_ has joined #openvswitch15:16
*** JamesBenson has quit IRC15:17
*** psahoo_ has quit IRC16:15
*** acidfoo has joined #openvswitch16:20
*** acidfu has quit IRC16:23
*** dceara has joined #openvswitch16:34
*** dholler has quit IRC17:07
*** labelette has joined #openvswitch17:12
imaximetsHi there.  It seems like time for the OVN weekly meeting.17:19
zhouhanHi17:19
imaximetsOK.  Let me just start it and other will join, I hope. :)17:20
imaximets#startmeeting ovn_community_development_discussion17:20
openstackMeeting started Thu Aug 13 17:20:33 2020 UTC and is due to finish in 60 minutes.  The chair is imaximets. Information about MeetBot at http://wiki.debian.org/MeetBot.17:20
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.17:20
openstackThe meeting name has been set to 'ovn_community_development_discussion'17:20
imaximetsAFAIK, mmichelson and dceara will not be here today.17:21
imaximetsnumans, are you here?17:21
*** zhouhan_ has joined #openvswitch17:21
*** zhouhan_ has quit IRC17:21
*** zhouhan_ has joined #openvswitch17:21
imaximetsOK.  I could start with a quick update.17:22
imaximetsThis week I looked at issues with DB sizes.  Mostly SB DB size.17:23
imaximetsIt seems like we creating lots of identical lflows for each logical datapath.17:24
*** zhouhan has quit IRC17:24
imaximetsAnd that might be optimized by only having one lflow referencing all logical datapaths it should be applicable to.17:24
numansimaximets, zhouhan_ Hi17:25
imaximetsI don't know how exactly and under which conditions this could be done, but I'm looking into that.17:25
numansI'm late17:25
imaximetsThat's it from my side.17:26
*** zhouhan_ has quit IRC17:26
numansimaximets, Thanks for looking into that.17:26
*** zhouhan has joined #openvswitch17:26
imaximetszhouhan seems to have connection issues.17:26
numansimaximets, yeah there are many flows which are repetitive17:26
numansI can go real quick.17:27
imaximetsnumans, It all yours. :)17:27
numansI did some reviews.17:27
zhouhanimaximets: sorry I was in readonly mode. I was asking if there is any example?17:27
imaximetszhouhan, for example we had a lot of reject ACL flows.17:28
* numans will contnue after this discussion.17:28
zhouhanimaximets: with the optimization, do we still need datapath information in the flow?17:28
numanszhouhan, what do you mean by "we still need datapath information ..."17:29
imaximetszhouhan, I thought to have a new table, e.g. Datapath_Group with sets of logical datapaths and have a single reference to a set from the logical flow.17:29
zhouhannumans: I mean, if the flows are common for all datapaths, then we can replace them with just one flow, removing the datapath match.17:30
*** links has quit IRC17:30
numanszhouhan, ok. That makes sense too.17:31
imaximetszhouhan, I see, but we have switches and routers and flow might be only applicable for switches, but not routers.17:31
imaximetsat least.17:32
numansimaximets, may be a new column option which says its for logical switches or for routers.17:32
zhouhanimaximets: if that's the case, would it be better to add a datapath type, instead of creating groups?17:32
imaximetszhouhan, that make sense.  Good point.  Need to explore usecases deeply to understand if it's possible/feasible to have smaller groups.17:33
imaximetszhouhan, one more case is lfows for port group. e.g. port group specific ACLs.17:34
zhouhanI think it is good to optimize such cases if it is low hanging fruit, but I would avoid heavy changes for that, because I think the number of datapaths is much smaller than the number of ports. The size of the flow table mainly determined by number of ports.17:35
zhouhanimaximets: oh, I didn't notice that. If it is for all port groups, it may be straightforward to optimize, too.17:36
numanszhouhan, in the case of ovn-k8s, where its switch per node, there could be significat flows if say number of computes is 10017:37
numansok.17:37
zhouhannumans: even though, it is normal to have 10x more ports than number of computes, right?17:38
zhouhansometimes, even 100x17:38
numansyeah.17:38
imaximetszhouhan, ok.  we definitely still need to explore some usecases and see if it will have real benefits in real-world cases.  Work in progress. :)17:39
zhouhanimaximets: sure, thanks!17:40
zhouhannumans: please continue. I will update after you.17:40
numanszhouhan, thanks.17:41
numansSo I did some reviews.17:42
numansand a couple of small bug fix patches.17:42
numansThere is one issue reported by openshift on openstack scenario17:42
numansthe etcd cluster is having a downtime and a new leader is elected when some tests are run17:43
numansand the leader change happens when ovn-controller program flows and it updates the conjunction ids of existing flows17:43
numansit is for ACLs which results in conjunction17:43
numansSo I'm working on making conjunction ids persistent17:44
numansso that when a port is added to a  port group or during a recompute, we use the same conjunction id.17:44
numansIt is not a big issue. But there is a very very small window for packet drops.17:44
zhouhannumans: sorry, how does etcd cluster impact ovn-controller?17:45
numanszhouhan, etcd cluster is running as application pods17:45
numansso the etcd traffic gets disrupted when ovn-controller changes the conjunction id for ACL flows which allow traffic for these etcd ports17:46
numanszhouhan, the CI test creates other pods and other ACLs and while processing those, ovn-controller is updating the existing flows17:46
zhouhanI see, does it happen only during flow recompute17:46
zhouhan?17:46
numanszhouhan, it also happens when a port is added to the port group17:47
zhouhanok17:47
numanszhouhan, with the new I-P patches, the issue is not seen often17:47
zhouhanI wonder is it a generic problem even without conjunction flows.17:47
numansas we don't recompute enough now17:47
numansbut the issue is still seen when the CI is run with parallel=2 itseems.17:48
numansI'm not sure what parallel=2 exactly mean, I assume more tests are run in parallle17:48
numansparallel.17:48
zhouhani.e. problem when there are updates in OVS flows, groups, meters, is it possible to see transient traffic broke?17:49
numanszhouhan, that's what I observed.17:49
zhouhanor, is conjunction ID recompute is the only thing we worry about?17:49
numanszhouhan, the issue is seen when the ACL is added like this -- "ip && .. inport == @pg1 && tcp.dst >=900 && tcp.dst <=901"17:50
numanszhouhan, and the issue is not seen when 2 separate ACLs are added for these 2 tcp dst ports17:50
numansso I think its happening when conjunction is involved17:50
zhouhannumans: I understand that the problem you saw is related to conjunction. I was just thinking is there similar issue even without using conjunction.17:51
numanszhouhan, I don't  think so.17:51
zhouhannumans: that's great.17:51
numanszhouhan, in the case of conjunction, we do FLOW_MOD.17:51
numanszhouhan, in other cases, we don't do FLOW_MOD right ?17:51
numansI think either the OF flow will be deleted and added again17:52
zhouhannumans: I don't remember. Maybe we can check offline. I don't remember either is there any chance ct-zone-id, etc. could have similar issue.17:52
numansor nothing happens.17:52
numanszhouhan, ok17:52
numanssounds good17:52
numansmay be we can discuss further when I submit the patch17:52
zhouhannumans: yeah, sounds good17:53
numansone point though - I'm planning to revisit the lflow expr patches which we had revertd earlier.17:53
numansto solve this issue.17:53
numansThat's it from me.17:53
zhouhanI can go quickly17:53
imaximetszhouhan, sure.17:54
zhouhanI found the root cause of the scale-test regression in 20.03 compared with 2.12. It has nothing to do with 20.03 OVN, but related to the upstream OVS.17:54
numansgreat finding. I didn't see the patch closely though.17:55
zhouhanIt is a change in ovsdb IDL code that caused the problem. I reverted the patch and the performance is comparable with 2.12 now. The revert is merged by imaximets. Thanks imaximets for the review.17:55
imaximetszhouhan, thanks for finding this!17:56
numanszhouhan, its on the client IDL side right ?17:56
zhouhannumans: yes17:56
numanszhouhan, ok. cool.17:56
zhouhanNow with this solved, I can compare 20.03 v.s. 20.06 more fairly, because northd doesn't appear to be the main bottleneck now.17:57
zhouhanThere is obvious latency reduce in 20.06, thanks to numans's I-P improvement for handling changes in local chassis.17:58
zhouhanNow there are still bottlenecks in ovn-controller ofctrl_put() when number of ports is big enough. I am working on incrementally installing flows.17:59
numanszhouhan, that's cool.17:59
numanszhouhan, anilvenkata had a WIP patch to improve the ofctl_put. But he switched his focus else where. I'll just share the commit in his private branch.18:00
numansplease take a look in case if that interests you.18:00
zhouhannumans: cool. Thanks a lot!18:01
zhouhanWhile working on this, I also found a bug related to conjunction when I-P is involved. It was introduced by the patch that handling merging conjunction flows from different logical flows.18:01
numansok.18:01
zhouhanI fixed this first, and working on the tests, hope to send a patch soon.18:01
numansthat's great. Looking forward to it.18:01
zhouhanthat's my update18:02
imaximetszhouhan, Thanks!18:02
imaximetsAnyone else here?18:02
numanszhouhan, I just need another minute to share the commit18:04
zhouhannumans: no worries. We can share offline.18:05
numansimaximets, I think we are done.18:05
numanszhouhan, sounds good.18:05
imaximetsOK.  Let's call it. :)18:05
zhouhanLet's end the meeting and discuss secrets to punish the people who don't join :)18:05
imaximetsThanks everyone!18:05
imaximetszhouhan, :)18:05
imaximets#endmeeting18:05
openstackMeeting ended Thu Aug 13 18:05:48 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)18:05
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-13-17.20.html18:05
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-13-17.20.txt18:05
openstackLog:            http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-13-17.20.log.html18:05
numansbYE18:07
numansBye18:07
imaximetsBye.18:07
flaviofzhouhan: er: secrets to punish the people who don't join? 8$18:20
flaviofsorry I'm stuck on things and never com in time.18:20
flaviofbut I'm around. Nothikng new to say, so I keep my mouth shut too. ;)18:20
flaviofit is awesome hearing about all the activities y'all into! rock on!!!18:21
zhouhanflaviof: haha. Please keep the secret :D18:21
flaviofzhouhan++  <318:21
*** jon_d___ has quit IRC18:38
*** jon_d___ has joined #openvswitch18:38
*** dceara has quit IRC18:46
*** maciejjozefczyk has quit IRC18:47
*** zhouhan has quit IRC18:58
*** zhouhan has joined #openvswitch18:58
*** acidfoo has quit IRC19:45
*** acidfoo has joined #openvswitch19:56
*** acidfoo has quit IRC20:01
*** yamamoto has joined #openvswitch20:13
*** yamamoto has quit IRC20:18
*** jtollet has joined #openvswitch20:33
*** slaweq has quit IRC20:37
*** zhouhan has quit IRC21:03
*** zhouhan has joined #openvswitch21:04
*** jtollet has quit IRC21:15
*** jtollet has joined #openvswitch21:16
*** jtollet_ has joined #openvswitch21:17
*** jtollet has quit IRC21:17
*** dceara has joined #openvswitch21:18
*** bostondriver has quit IRC21:19
*** yamamoto has joined #openvswitch21:55
*** dceara has quit IRC22:00
*** rcernin has joined #openvswitch22:00
*** armax has quit IRC22:07
*** bostondriver has joined #openvswitch22:24
*** bostondriver has quit IRC22:26
*** yamamoto has quit IRC22:31
*** jtollet_ has quit IRC22:41
*** armax has joined #openvswitch22:49
*** zhouhan has quit IRC22:52
*** zhouhan has joined #openvswitch22:52
*** fbl_ has joined #openvswitch23:52
*** fbl has quit IRC23:53

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!