Thursday, 2020-08-20

*** armax has quit IRC00:14
*** yamamoto has joined #openvswitch00:23
*** yamamoto has quit IRC01:08
*** rcernin has quit IRC01:19
*** rcernin has joined #openvswitch01:29
*** yamamoto has joined #openvswitch01:58
*** zhouhan_ has joined #openvswitch02:15
*** zhouhan has quit IRC02:18
*** rcernin has quit IRC02:28
*** rcernin has joined #openvswitch02:30
*** rcernin has quit IRC03:24
*** anilvenkata has joined #openvswitch03:33
*** zhouhan_ has quit IRC03:35
*** zhouhan has joined #openvswitch03:39
*** rcernin has joined #openvswitch03:47
*** anilvenkata has quit IRC04:36
*** psahoo has joined #openvswitch04:43
*** dholler has joined #openvswitch05:24
*** sri_ has quit IRC05:56
*** yamamoto has quit IRC05:56
*** sri_ has joined #openvswitch05:57
*** JamesBenson has quit IRC06:05
*** JamesBenson has joined #openvswitch06:09
*** JamesBenson has quit IRC06:14
*** yamamoto has joined #openvswitch06:22
*** JamesBenson has joined #openvswitch06:49
*** JamesBenson has quit IRC07:08
*** slaweq has joined #openvswitch07:08
*** lostd has joined #openvswitch07:28
*** lostd_ has quit IRC07:31
*** dceara has joined #openvswitch07:32
*** jamespage has quit IRC07:40
*** kklimonda has quit IRC07:41
*** lathiat has quit IRC07:42
*** gregwork has quit IRC07:42
*** kklimonda has joined #openvswitch07:44
*** kklimonda has quit IRC07:44
*** lostd has quit IRC07:45
*** jamespage has joined #openvswitch07:46
*** kklimonda has joined #openvswitch07:55
*** lathiat has joined #openvswitch07:55
*** gregwork has joined #openvswitch07:55
*** rcernin has quit IRC07:58
*** _lore_ has quit IRC08:10
*** _lore_ has joined #openvswitch08:11
*** ktraynor has joined #openvswitch08:19
*** sri_ has quit IRC08:30
*** sri_ has joined #openvswitch08:30
*** lathiat has quit IRC08:30
*** lathiat has joined #openvswitch08:30
*** gregwork has quit IRC08:30
*** gregwork has joined #openvswitch08:30
*** psahoo has quit IRC09:17
*** psahoo has joined #openvswitch09:32
*** JamesBenson has joined #openvswitch10:14
*** JamesBenson has quit IRC10:19
*** psahoo has quit IRC10:21
*** psahoo has joined #openvswitch10:35
*** psahoo has quit IRC10:40
*** psahoo has joined #openvswitch10:52
*** psahoo has quit IRC11:08
*** yamamoto has quit IRC11:10
*** yamamoto has joined #openvswitch11:10
*** yamamoto has quit IRC11:11
*** psahoo has joined #openvswitch11:22
*** yamamoto has joined #openvswitch11:24
*** zhouhan has quit IRC11:45
*** zhouhan has joined #openvswitch11:51
*** psahoo has quit IRC12:09
*** JamesBenson has joined #openvswitch12:15
*** jaicaa has quit IRC12:19
*** JamesBenson has quit IRC12:20
*** jaicaa has joined #openvswitch12:22
*** JamesBenson has joined #openvswitch12:25
*** aconole has joined #openvswitch12:26
*** acidfoo has joined #openvswitch12:32
*** bostondriver has joined #openvswitch12:51
*** anilvenkata has joined #openvswitch13:06
*** yamamoto has quit IRC14:24
*** armax has joined #openvswitch14:50
*** yamamoto has joined #openvswitch15:01
*** yamamoto has quit IRC15:09
*** tbachman has joined #openvswitch15:52
*** yamamoto has joined #openvswitch16:01
*** dceara has quit IRC16:09
*** yamamoto has quit IRC16:12
*** zhouhan_ has joined #openvswitch16:24
*** acidfoo has quit IRC16:25
*** zhouhan has quit IRC16:27
*** acidfoo has joined #openvswitch16:41
*** acidfoo has quit IRC16:46
*** acidfoo has joined #openvswitch17:03
numansHello17:15
*** zhouhan_ has quit IRC17:16
*** zhouhan has joined #openvswitch17:17
zhouhanhi17:17
numansI think we can start17:17
numans#meeting17:17
numansforgot the commands.17:17
numans#startmeeting ovn_community_development_discussion17:18
openstackMeeting started Thu Aug 20 17:18:14 2020 UTC and is due to finish in 60 minutes.  The chair is numans. Information about MeetBot at http://wiki.debian.org/MeetBot.17:18
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.17:18
openstackThe meeting name has been set to 'ovn_community_development_discussion'17:18
numansHello everyone17:18
numansI can start.17:19
numansThis week I worked on persisting the conj ids for the conjunction flows17:19
flaviofhi all17:19
numansI submitted a patch for that.17:20
numansI also worked on the expr caching which is on top of the conj id fix.17:20
numansIt is almost ready. Need to do some testing.17:20
numansWith the caching I see a good amount of improvement. With around 80k lflows in my local setup, without caching full recompute takes around 5 seconds17:21
numansand with the caching it takes around 2 seconds.17:21
numansI'll submit the patches soon.17:21
zhouhansounds great!17:21
numans#link https://patchwork.ozlabs.org/project/openvswitch/patch/20200820083912.3240721-1-numans@ovn.org/17:21
numansthe patches are right now here -17:22
numans#link https://github.com/numansiddique/ovn/commits/lflow_cache_improv/v1/p317:22
numansif someone is interested to take a look.17:22
numansI think that's it from me for this week.17:22
zhouhannumans: I will take a look, maybe next week17:22
numanszhouhan, thanks.17:23
zhouhanI can go next17:23
zhouhanI worked on ovn-controller flow installation incremental processing, and a bug fix for conjunction combined flows17:24
numanssure17:24
zhouhanThe patch series is almost ready: #link https://github.com/hzhou8/ovn/tree/i-p-flow-install17:24
numanscool.17:25
numansany improvements you noticed in your testing ?17:25
zhouhanIn scale test it shows around 50% CPU reduce of ovn-controller. While in perf it shows the ~40% of ofctrl_put() is gone17:25
numansthat's great.17:25
zhouhanThe scale is 12k lports17:25
zhouhanThe data structures were changed a lot, for handling the M:N mapping of lflow <-> desired-flows, which solves the conjunction problem :)17:26
zhouhanThe last piece I am working on is to solve the "delete and add back" problem for incremental flow installation, because that adds a lot of unnecessary OpenFlow messages.17:28
zhouhanI will send the patch after this solved (which is a small optimization)17:28
numanszhouhan, delete and add back in the ofctrl.c right ?17:28
numansor in lflow.c where we remove the desired flows and then add back when handling I-P changes ?17:29
zhouhannumans: yes, there are many situations this happens, e.g. when physical_run() is executed, all the "hc_uuid" flows are deleted first and added back every time.17:29
zhouhannumans: not in lflow.c, but in physical.c17:29
numanszhouhan, ok.17:30
numanssounds good.17:30
zhouhanI am falling behind the reviews, will catch up.17:30
zhouhanThat's is from me17:30
zhouhans/is/it17:30
numanszhouhan, need your eye on this one from dumitru - https://patchwork.ozlabs.org/project/openvswitch/patch/1597922284-3341-1-git-send-email-dceara@redhat.com/17:30
numanswhenever you get some time.17:30
zhouhannumans: ack17:31
numansI'll take a look next week.17:31
numansthanks.17:31
numansflaviof, you have anything sir ?17:31
flaviofhey!17:31
numanshey!17:32
flaviofyes, actually... I just wanted to mention about 2 cool OVN developments from the world of Openstack17:32
flaviof1)Lucas Private Chassis changes merging soon! With that, networking-ovn17:32
flaviofin neutron uses the Chassis_Private table -- when available -- for coordinating nb_cfg with chassis and northd. Big boost!17:32
numansnice17:32
flaviof#link https://review.opendev.org/#/c/707626/ Use the Chassis_Private table for agents healthcheck17:32
flaviof#link https://github.com/flavio-fernandes/ovn/commit/4adc10f58127e45b5883f2e7cb1c702720b95043 the ovn changes to support it ^^17:32
flaviof2)Port forwarding feature merged for "V" release. Actually there is just one Gerrit change17:33
flaviofleft, which has already been reviewed. OVN load balancers are the core functionality for that feature.17:33
flaviof#link https://review.opendev.org/#/q/topic:ovn/port_forwarding+(status:open+OR+status:merged) OVN port forwarding17:33
flaviofThank you all for the help with these! And that is all from me.17:33
numansbecause of which for the cluster db, the upgrade_cluster is never called17:35
numansflaviof, that's great. Thanks for the update.17:35
numansI have one question regarding the run_nb/sb_ovsdb commands in ovn-ctl script.17:35
numansRight now these variants "exec" ovsdb-server and run in foreground.17:35
*** yangyapeng has quit IRC17:35
numansany comments on how can we address this ?17:36
numanszhouhan, ^ if you have any comments.17:36
zhouhannumans: I'm not sure what's the issue?17:36
numanszhouhan, when the ovn dbs get upgraded17:37
numanszhouhan, and when CMS restarts the raft ovsdb cluster17:37
numansusing ovn_nb_ovsdb and ovn_sb_ovsdb17:37
numansthe dbs never gets upraded to the latest schema17:37
numansunless CMS runs the ovsdb-client convert command itself to upgrade the dbs.17:38
numanszhouhan, my question is it better to handle this in the ovn-ctl script ? or let CMS handle it ?17:38
zhouhanOh, I never noticed this problem. Is it a bug?17:38
numanszhouhan, you will not see this issue if you ovn-ctl start_northd/start_nb_ovsdb17:38
numanszhouhan, you would see only if you use run_nb/sb_ovsdb.17:39
zhouhanI remember the ovn-ctl scripts always upgrade DBs (and also makes a backup)17:39
zhouhannumans: Oh, I see.17:39
numanshttps://github.com/ovn-org/ovn/blob/master/utilities/ovn-ctl#L29917:39
numansthis code never gets executed as ovsdb-server is exec'd17:39
numanszhouhan, I thought of handling this by running ovsdb-server in background and then call "wait <pid> at the end17:40
numansif ovn-ctl can't solve it, CMS scripts needs to handle the db upgrades.17:41
*** yangyapeng has joined #openvswitch17:41
numansMay be I'll propose a patch to fix it in ovn-ctl and we can discuss it over there.17:42
zhouhannumans: run_xxx and start_xxx both calls start_ovsdb__(), why one works and the other doesn't?17:42
numanszhouhan, because run_xxx doesn't daemonize ovsdb-server17:43
zhouhannumans: yes, a patch would be good. I need more time to understand the details :)17:43
numanszhouhan, sure. I'll send a patch.17:43
numansThanks.17:43
zhouhanwhy demonization is impacting the upgrading behavior17:43
zhouhan(I will check offline)17:44
numanszhouhan, daemonization works fine.17:44
numanszhouhan, run_xxx doesn't  daemonize and hence ""$@" "$file" at L291 returns only after ovsdb-server exits17:44
zhouhannumans: Ah, I see17:45
numansactually we use "exec ovsdb-server" so it never returns17:45
numansOk. we can discuss over ML.17:45
numansAnyone else ?17:46
zhouhanHaven't heard from blp and Leonid for DDLog17:47
numansOk. I think we can end the meeting.17:47
numanszhouhan, oops sorry.17:48
numansgo ahead17:48
zhouhanI wonder what's the status17:48
numansyeah. Me too.17:48
flaviof+117:48
zhouhanShall we post a thread in ML17:48
numans+117:48
numanssounds good to me.17:48
zhouhanOk, I'll send one, and hopefully we can get some plan moving forward17:49
zhouhannumans: I think we can end the meeting now :)17:50
numansThanks.17:50
numansBye17:50
zhouhanbye17:51
numans#endmeeting17:51
openstackMeeting ended Thu Aug 20 17:51:07 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)17:51
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-20-17.18.html17:51
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-20-17.18.txt17:51
openstackLog:            http://eavesdrop.openstack.org/meetings/ovn_community_development_discussion/2020/ovn_community_development_discussion.2020-08-20-17.18.log.html17:51
flaviofbye bye17:51
numansflaviof, you missed out by a second in the logs :)17:51
flaviofnumans: lol no worries17:53
numans:)17:53
flaviofnumans: next time I will say "bye" instead of "bye bye". Maybe then I will be fast enough :) :)17:54
numansflaviof, lol .. sounds good17:54
flaviof<317:54
*** gregwork has quit IRC18:04
*** yamamoto has joined #openvswitch18:09
*** acidfoo has quit IRC18:11
*** yamamoto has quit IRC18:28
*** fbl has joined #openvswitch18:29
*** fbl_ has quit IRC18:30
*** fbl has quit IRC19:35
*** yamamoto has joined #openvswitch20:27
*** yamamoto has quit IRC20:46
*** acidfoo has joined #openvswitch20:48
*** acidfoo has quit IRC20:58
*** zhouhan has quit IRC21:13
*** zhouhan_ has joined #openvswitch21:13
*** acidfoo has joined #openvswitch21:15
*** fbl has joined #openvswitch21:29
*** yamamoto has joined #openvswitch21:33
*** slaweq has quit IRC21:34
*** aconole has quit IRC21:35
*** yamamoto has quit IRC21:45
*** bostondriver has quit IRC21:56
*** darkemon1 has joined #openvswitch22:00
*** darkemon has quit IRC22:02
*** darkemon1 is now known as darkemon22:02
*** acidfoo has quit IRC22:07
*** rcernin has joined #openvswitch22:50
*** yangyapeng has quit IRC23:00
*** yangyapeng has joined #openvswitch23:04
*** rcernin has quit IRC23:06
*** rcernin has joined #openvswitch23:08
*** yamamoto has joined #openvswitch23:45
*** sri_ has quit IRC23:55
*** yamamoto has quit IRC23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!