Monday, 2015-07-13

« Sunday, 2015-07-12 Index Tuesday, 2015-07-14 »
*** logan2 has quit IRC00:01
*** topshare has quit IRC00:07
*** logan2 has joined #puppet-openstack00:08
*** xingchao has quit IRC00:13
*** markvoelker has quit IRC00:32
*** ducttape_ has joined #puppet-openstack00:50
*** openstackgerrit has quit IRC00:51
*** openstackgerrit has joined #puppet-openstack00:52
*** topshare has joined #puppet-openstack00:53
*** iurygregory has quit IRC01:09
*** ducttape_ has quit IRC01:26
mfischsbadia: yo01:59
mfischsbadia: did Puppetlabs agree to move our namespace in the forge? I thought it was an open question01:59
*** xingchao has joined #puppet-openstack02:13
*** gildub has joined #puppet-openstack02:15
EmilienMmfisch: I released them there02:37
*** topshare has quit IRC03:02
mfischawesome03:09
*** topshare has joined #puppet-openstack03:21
*** topshare has quit IRC03:23
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082703:27
openstackgerritEmilien Macchi proposed openstack/puppet-openstacklib: openstack provider: increase timeout to 20  https://review.openstack.org/20098203:54
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082703:55
*** xingchao has quit IRC03:56
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082704:08
*** topshare has joined #puppet-openstack04:23
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082704:23
*** pcaruana has quit IRC05:08
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_trust for Keystone V3 API  https://review.openstack.org/20099605:39
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_trust for Keystone V3 API  https://review.openstack.org/20099605:57
*** khappone has quit IRC06:10
*** khappone has joined #puppet-openstack06:11
*** rwsu has joined #puppet-openstack06:14
*** rwsu has quit IRC06:16
*** hogepodge has quit IRC06:19
*** hogepodge has joined #puppet-openstack06:26
*** sergmelikyan has joined #puppet-openstack06:28
*** gildub_ has joined #puppet-openstack06:32
*** pcaruana has joined #puppet-openstack06:42
*** ddmitriev has joined #puppet-openstack06:52
*** sergmelikyan has quit IRC06:58
*** xingchao has joined #puppet-openstack07:13
*** dgurtner has joined #puppet-openstack07:18
*** dgurtner has quit IRC07:18
*** dgurtner has joined #puppet-openstack07:18
*** xingchao has quit IRC07:26
*** jpena has joined #puppet-openstack07:28
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_trust for Keystone V3 API  https://review.openstack.org/20099607:45
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_trust for Keystone V3 API  https://review.openstack.org/20099607:51
openstackgerritJavier Peña proposed openstack/puppet-ceilometer: Simplify parameters for rpc_backend  https://review.openstack.org/19603607:51
*** chem has joined #puppet-openstack07:56
*** xingchao has joined #puppet-openstack07:57
*** jistr has joined #puppet-openstack08:02
*** gildub has quit IRC08:09
*** xingchao has quit IRC08:15
*** paramite has joined #puppet-openstack08:18
*** xingchao has joined #puppet-openstack08:28
*** sergmelikyan has joined #puppet-openstack08:43
*** kbyrne has quit IRC09:10
socialoh hay, can we have this in? https://review.openstack.org/#/c/19666809:13
*** xingchao has quit IRC09:14
*** kbyrne has joined #puppet-openstack09:15
*** sergmelikyan has quit IRC09:19
*** sergmelikyan has joined #puppet-openstack09:26
*** paramite is now known as paramite|afk09:48
*** derekh has joined #puppet-openstack09:51
*** paramite|afk is now known as paramite09:51
*** cdelatte has joined #puppet-openstack10:56
*** xingchao has joined #puppet-openstack11:08
*** gildub has joined #puppet-openstack11:12
*** sergmelikyan has quit IRC11:15
*** gildub has quit IRC11:23
*** dgurtner has quit IRC11:24
*** xingchao has quit IRC11:25
*** xingchao has joined #puppet-openstack11:28
*** sergmelikyan has joined #puppet-openstack11:30
*** sergmelikyan has quit IRC11:31
*** blentz has joined #puppet-openstack11:33
*** dgurtner has joined #puppet-openstack11:35
*** dgurtner has quit IRC11:35
*** dgurtner has joined #puppet-openstack11:35
*** sergmelikyan has joined #puppet-openstack11:41
EmilienMgood morning11:41
*** sergmelikyan has quit IRC11:46
socialEmilienM: will you have time for https://review.openstack.org/#/c/196668 ?11:50
EmilienMsocial: yes, maybe today11:51
*** gfidente has joined #puppet-openstack11:53
*** dprince has joined #puppet-openstack11:53
*** sergmelikyan has joined #puppet-openstack11:54
*** dgurtner has quit IRC12:03
*** dgurtner has joined #puppet-openstack12:04
*** dgurtner has quit IRC12:04
*** dgurtner has joined #puppet-openstack12:04
*** topshare has quit IRC12:06
*** jayg|g0n3 is now known as jayg12:10
*** paramite is now known as paramite|afk12:14
*** paramite|afk is now known as paramite12:16
*** ducttape_ has joined #puppet-openstack12:28
*** topshare has joined #puppet-openstack12:31
*** sergmelikyan has quit IRC12:38
*** sergmelikyan has joined #puppet-openstack12:47
*** sergmelikyan has quit IRC12:48
*** sergmelikyan has joined #puppet-openstack12:49
*** ducttape_ has quit IRC12:50
*** ddmitriev1 has joined #puppet-openstack12:54
crinkleEmilienM: is it safe to say the sprint will be 9/2-9/4?13:00
EmilienMI was about to close the poll13:00
EmilienMcrinkle: yes13:00
crinklemmk13:00
EmilienMcrinkle: (early) good morning!13:02
crinklegood morning13:04
*** richm has joined #puppet-openstack13:05
openstackgerritYanis Guenane proposed openstack/puppet-cinder: Sync cinder::db::sync with new standard  https://review.openstack.org/19669313:05
*** paramite is now known as paramite|afk13:06
*** sergmelikyan has quit IRC13:08
*** sergmelikyan has joined #puppet-openstack13:09
*** bklei has quit IRC13:09
*** sergmelikyan has quit IRC13:18
*** rcallawa has joined #puppet-openstack13:20
*** jpena is now known as jpena|lunch13:26
openstackgerritYanis Guenane proposed openstack/puppet-designate: Creation of designate::db::sync  https://review.openstack.org/19662213:26
*** paramite|afk is now known as paramite13:32
*** iurygregory has joined #puppet-openstack13:33
*** paramite is now known as paramite|afk13:44
*** dfisher has joined #puppet-openstack13:48
*** ferest has joined #puppet-openstack13:51
openstackgerritMichael Polenchuk proposed openstack/puppet-neutron: Jumbo frames between instances  https://review.openstack.org/19999913:53
*** ferest has quit IRC13:54
*** sergmelikyan has joined #puppet-openstack14:15
openstackgerritMerged openstack/puppet-openstack-cookiecutter: Handle the postgresql md5password in specs  https://review.openstack.org/20059014:24
*** sergmelikyan has quit IRC14:30
*** jpena|lunch is now known as jpena14:31
*** paramite|afk is now known as paramite14:33
*** markvoelker has joined #puppet-openstack14:33
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-specs: Blueprint: Define our master branch policy  https://review.openstack.org/18014114:35
*** vinsh_ has joined #puppet-openstack14:38
*** paramite_ has joined #puppet-openstack14:40
*** vinsh has quit IRC14:40
*** sergmelikyan has joined #puppet-openstack14:41
*** markvoelker_ has joined #puppet-openstack14:42
*** sergmelikyan has quit IRC14:42
*** sergmelikyan has joined #puppet-openstack14:42
openstackgerritMerged openstack/puppet-nova: Add ability to override compute_driver  https://review.openstack.org/20054314:43
*** markvoelker has quit IRC14:44
*** linkedinyou has quit IRC14:48
*** mdorman has joined #puppet-openstack14:55
openstackgerritMerged openstack/puppet-neutron: Creation of neutron::db::sync  https://review.openstack.org/19666814:55
richmEmilienM: re: roles resource - I just got a packstack failure because swift creates the keystone_role admin using ensure_resource15:07
richmEmilienM: so looks like we have to use ensure_resource in the roles resource :P15:08
EmilienMrichm: well, it should be packstack to update their manifests15:08
richmEmilienM: It's not packstack, it's swift::keystone::auth15:09
EmilienMalso, you can set the configure_role to False15:09
EmilienMoh I see, ok15:09
richmEmilienM: I am concerned because this is a case of "it worked before, now it's not working" after upgrade15:09
*** topshare has quit IRC15:10
*** paramite is now known as paramite|afk15:11
openstackgerritLukas Bezdicka proposed openstack/puppet-neutron: Run neutron db sync also for each neutron module  https://review.openstack.org/20087715:15
EmilienMrichm: will look right after my dailys crum15:15
richmEmilienM: I am testing a fix right now15:16
EmilienMrichm: I also found weird things last night with v3 + WSGI enabled15:16
richmok15:16
EmilienMrichm: https://review.openstack.org/20082715:17
EmilienMrichm: it fails now, but I'll look today15:17
EmilienMrichm: logs are interested to see15:17
*** topshare has joined #puppet-openstack15:18
richmwth?  Error: Execution of '/usr/bin/openstack domain create --format shell admin_domain --enable --description Domain for admin v3 users' returned 1: ERROR: openstack Not Found (HTTP 404)15:18
sergmelikyanHi EmilienM, stackforge/puppet-murano is renamed to openstack/murano, this commit is last thing left https://review.openstack.org/19272715:18
richmlooks like the problem when it doesn't create the domain15:18
sergmelikyancan you vote?15:18
*** cwolferh has quit IRC15:19
EmilienMsergmelikyan: will do15:19
richmEmilienM: I run packstack exclusively with keystone wsgi15:19
richmI've tested all of my v3 patches using keystone wsgi15:19
sergmelikyanEmilienM: thank you!15:19
EmilienMsergmelikyan: it's already voted BTW15:19
*** rwsu has joined #puppet-openstack15:19
*** paramite|afk is now known as paramite15:20
EmilienMrichm: weird. I was thinking, could it be apache too long to start, like a race condition here?15:20
*** markvoelker has joined #puppet-openstack15:20
*** markvoelker_ has quit IRC15:22
*** topshare has quit IRC15:23
*** markvoelker has quit IRC15:23
richmEmilienM: could be15:28
EmilienMrichm: back15:28
EmilienMrichm: so you're doing a fix for which module?15:28
EmilienMrichm: my patch?15:28
socialEmilienM: question is, should I just do exec with setsebool?15:28
EmilienMsocial: there is a selinux module afik15:28
EmilienMsocial: and selinux resource in puppet15:29
*** sergmelikyan has quit IRC15:29
socialuu selboolean15:30
socialnice15:30
*** bklei has joined #puppet-openstack15:33
EmilienMrichm: can I push on https://review.openstack.org/#/c/199676 ?15:35
*** _morgan has quit IRC15:36
*** nibalizer has quit IRC15:36
*** _matthias_ has quit IRC15:36
*** maximov has quit IRC15:36
*** sac has quit IRC15:36
*** dachary has quit IRC15:36
*** gsilvis has quit IRC15:36
*** derekh has quit IRC15:36
*** leanderthal has quit IRC15:36
*** mwhahaha has quit IRC15:36
*** pasquier-s has quit IRC15:36
*** ikke-t has quit IRC15:36
*** tristanC has quit IRC15:36
*** mwoodson has quit IRC15:36
*** _morgan has joined #puppet-openstack15:37
*** gsilvis has joined #puppet-openstack15:37
*** tristanC has joined #puppet-openstack15:37
*** sac has joined #puppet-openstack15:37
*** nibalizer has joined #puppet-openstack15:37
*** mwoodson has joined #puppet-openstack15:37
*** _matthias_ has joined #puppet-openstack15:37
*** maximov has joined #puppet-openstack15:37
*** mwoodson has quit IRC15:37
*** mwoodson has joined #puppet-openstack15:37
*** ikke-t has joined #puppet-openstack15:37
*** pcaruana has quit IRC15:38
*** pasquier-s has joined #puppet-openstack15:38
*** dachary has joined #puppet-openstack15:39
*** mwhahaha has joined #puppet-openstack15:39
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Transform keystone::roles::admin Class into a Define  https://review.openstack.org/19967615:39
*** derekh has joined #puppet-openstack15:39
EmilienMrichm: ^15:39
openstackgerritLukas Bezdicka proposed openstack/puppet-keystone: Setup SELinux booleans if running in httpd  https://review.openstack.org/20122915:41
EmilienMsocial: should not it be packaging thing ^ ?15:41
EmilienMIMHO, openstack-horizon package should handle SElinux15:42
socialEmilienM: why? openstack-horizon provides service15:42
socialEmilienM: let me ask someone more experienced :)15:42
EmilienMsocial: so does openstack-selinux.rpm15:42
socialEmilienM: openstack-selinux rpm is hack that should not exist15:43
EmilienMsocial: it's out of topic I think15:43
socialEmilienM: but turning on booleans in openstack-horizon is also possible solution15:43
EmilienMsocial: 1/ openstack-selinux is (until now) the official package to setup SELinux on nodes 2/ we don't override resources (files, selinux, users/groups, etc) with packaging15:43
socialEmilienM: issue is that it allows several ways of deployment which means it should not pick one by default and should not enable httpd keystone setup15:44
socialEmilienM: so it's up to deployer to enable the bools15:44
EmilienMthis can be discussed15:44
socialEmilienM: simillar to when you run haproxy instead of nova on nova port, you as deployer changed default setup, but yeah, I'll forward this to packagers15:45
EmilienMyour patch is going to fail the CI anyway15:45
EmilienMSELinux is not enabled on trusty15:45
socialEmilienM: that's why it tests whether the selinux is enabled :)15:45
EmilienMsocial: you're trying to solve an issue that we should fix in packaging, not in Puppet15:45
EmilienMsocial: no I'm talking about https://review.openstack.org/#/c/201229/1/manifests/wsgi/apache.pp,cm15:45
EmilienMah15:46
EmilienMthere is a test, indeed15:46
sociallet's give it -1 for now15:46
socialand get someone from packaging to look at it15:46
EmilienMsocial: I get your pain, no worries15:47
EmilienMsocial: it's just we have to fix the issues the right way15:47
socialbut in my opinion if you are doing nondefault deployment (which is the question here) you should as deployer take care of selinux15:47
richmpackstack test worked - now doing spec/beaker test15:47
socialEmilienM: anyway that one is not that burning as https://review.openstack.org/#/c/200877/ which I'm not sure if it's clean way of fixing the issues15:50
*** sergmelikyan has joined #puppet-openstack15:50
EmilienMsocial: could you please report bugs on Launchpad & use a topic (see spredzy's work aboug db_sync) for this patch?15:51
EmilienMsocial: having BZ in commit message do not really helpp15:51
*** morazi has quit IRC15:52
openstackgerritMerged openstack/puppet-modulesync-configs: spec: Add spec_helper_acceptance to common files  https://review.openstack.org/19962115:58
EmilienMxingchao: in same time, woot ^15:58
xingchaoEmilienM: aha :)15:59
*** xingchao has quit IRC16:02
*** aimon has quit IRC16:03
*** dalgaaf has quit IRC16:08
*** sergmelikyan has quit IRC16:09
*** vinsh_ has quit IRC16:13
*** vinsh_ has joined #puppet-openstack16:13
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082716:13
*** cwolferh has joined #puppet-openstack16:14
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Transform keystone::roles::admin Class into a Define  https://review.openstack.org/19967616:19
openstackgerritMerged openstack/puppet-glance: Add support for RabbitMQ connection heartbeat  https://review.openstack.org/19435416:21
*** mgarza_ has joined #puppet-openstack16:22
openstackgerritMerged openstack/puppet-cinder: Add support for RabbitMQ connection heartbeat  https://review.openstack.org/19434316:26
openstackgerritMerged openstack/puppet-nova: Add support for RabbitMQ connection heartbeat  https://review.openstack.org/19431516:28
*** leanderthal has joined #puppet-openstack16:29
*** paramite_ has quit IRC16:30
*** paramite has quit IRC16:35
*** dgurtner has quit IRC16:44
*** aimon has joined #puppet-openstack16:45
*** ducttape_ has joined #puppet-openstack16:45
EmilienMcrinkle: richm and I found some issues in puppet-keystone/v3 and probably something in openstacklib16:48
EmilienMrichm: I'm writing a bug report16:48
crinkleyay bugs \o/16:49
EmilienMcrinkle: this one is funky16:49
EmilienMfunky = funny + tricky16:49
*** derekh has quit IRC16:55
*** jpena has quit IRC16:56
*** morazi has joined #puppet-openstack16:58
EmilienMrichm, crinkle: https://bugs.launchpad.net/puppet-keystone/+bug/147405916:59
openstackLaunchpad bug 1474059 in puppet-keystone "when WSGI enabled: domain service is unavailable during first Puppet run" [Undecided,New]16:59
crinkleEmilienM: the "Notice: Puppet::Provider::Openstack: domain service is unavailable. Will retry for up to 10 seconds." is irrelevant, it means it waited and tried again17:00
crinkleEmilienM: the error starts on "Error: Could not prefetch keystone_domain provider 'openstack': undefined method `collect' for nil:NilClass"17:00
richmok - this is what I did - I just replaced 'keystone' with 'httpd' in keystone_domain.rb autorequire(:service)17:00
EmilienMrichm: and it worked??17:00
richmnow I get two errors only - it seems the tests for ports 5000 and 35357 are not working17:00
EmilienMrichm: the service name is not looked up then17:00
EmilienMwth17:00
EmilienMcrinkle: ok thx17:00
crinkleer i might be wrong, what richm is saying makes it sound relevant17:01
richmI thought the service name was 'keystone', no matter if it was using eventlet or wsgi17:01
EmilienMyes17:02
EmilienMme too17:02
crinklethere is a service resource named keystone but it will be ensure => stopped if using wsgi17:02
crinkleand the httpd service is the one that matters17:02
richmso how do we fix this so that autorequire(:service) 'keystone' will actually work?17:02
*** xingchao has joined #puppet-openstack17:02
crinklejust have two autorequires17:02
EmilienMohh17:02
EmilienMrichm: something like https://github.com/puppetlabs/puppetlabs-firewall/blob/69fa795bc36d738a8aed26ad8c2dd79ff3d135fa/lib/puppet/type/firewallchain.rb#L151-L15717:03
richmautorequire(:service) ['keystone', 'httpd'] ?17:03
*** aimon_ has joined #puppet-openstack17:03
EmilienMno because it will never be created if not using WSGI17:03
richmhow does the keystone_domain.rb type code know if we are using eventlet or wsgi?17:03
EmilienMrichm: look iptalbes code17:03
*** aimon has quit IRC17:03
crinklerichm: it doesn't need to know, just autorequire both of them17:04
crinklerichm: whichever one is in the catalog is the one that it will use17:04
richmand it will just ignore the other one if it is not in the catalog?17:04
EmilienMcrinkle: it won't wail if it does not find one of both?17:04
crinkleEmilienM: no17:04
* EmilienM reading https://docs.puppetlabs.com/guides/custom_types.html#automatic-relationships17:04
*** aimon has joined #puppet-openstack17:04
richmso autorequire(:service) { ['keystone', 'httpd']  }17:04
EmilienM"Note that this won’t throw an error if resources with those names do not exist"17:05
crinkleautorequire just adds the relationship if the resource is in the catalog17:05
EmilienMcrinkle wrote that doc I'm sure !17:05
crinkleotherwise it doesn't care17:05
richmack17:05
EmilienMrichm: do you submit the patch?17:05
*** aimon_ has quit IRC17:08
richm117:08
richm1) every type needs to have ['httpd', 'keystone']17:09
richm2) this needs to be backported back to juno17:09
EmilienMyes17:09
richmsince we supported wsgi in juno (and even before, I think)17:09
EmilienMfor 2, I don't know17:09
EmilienMnobody reported the bug before it's weird17:09
richmI would think that we would have had problems, except that probably the intersection of the sets of people using wsgi, and those using puppet, is the null set17:10
EmilienMhttps://github.com/openstack/puppet-keystone/blob/stable/juno/lib/puppet/type/keystone_role.rb#L2517:10
EmilienMyes17:10
EmilienMwe need to fix juno17:10
richmok17:10
richmI can patch that17:10
richmis there a bug open yet?17:10
EmilienMhttps://bugs.launchpad.net/puppet-keystone/+bug/147405917:10
openstackLaunchpad bug 1474059 in puppet-keystone "when WSGI enabled: domain service is unavailable during first Puppet run" [Critical,New]17:10
EmilienMrichm: you patch juno and I patch master/kilo ok ?17:11
richmwell, whoever patches master, we'll just cherry pick that patch to kilo and juno?17:11
EmilienMno17:11
EmilienMdon't you think it fails to merge?17:12
EmilienMmaybe not, indeed17:12
EmilienMrichm: ok, go ahead to patch master first17:12
richmif it fails, I'll manually fixup the cherry17:12
richmok17:12
EmilienMrichm: perfect17:12
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082717:15
richmok - problem17:22
richmwhat if 'httpd' is in the catalog, in a way that is completely unrelated to keystone - that is, keystone is using eventlet so the service name is just 'keystone'17:22
richmwhat will happen now that we have an autorequire(:service) ['httpd', 'keystone']17:23
richm?17:23
richmwill it wait until the completely unrelated 'httpd' service is up and running?17:23
*** delattec has joined #puppet-openstack17:23
richmfor example, if you have horizon and keystone in the same manifest, and keystone is using eventlet, not wsgi?17:24
*** cdelatte has quit IRC17:27
*** jistr has quit IRC17:31
EmilienMrichm: I think it's ok, we just want the relationship if the resource is in the catalog17:34
EmilienMbut there is a race condition here17:34
EmilienMrichm: in fact no, thanks to the autorequire, we are sure the resource will be created *after* apache is started, even if not used17:35
EmilienMI don't see any trouble here, any thoughts?17:35
*** pabelanger has joined #puppet-openstack17:37
EmilienMpabelanger: good to know you might join our sprint17:39
EmilienMpabelanger: I was planning to work on CI things17:39
pabelangerEmilienM, either way, going to start attending weekly meetings and see if I can lend a hand17:39
EmilienMpabelanger: awesome!17:40
EmilienMwe need hands on CI17:40
EmilienMfor example, i'm currently thinking at how to get logs in our jobs17:40
pabelangerEmilienM, Ya. Want to get more REL coverage for our -infra puppet modules, figured I learn from how openstack-puppet is doing it.  I know crinkle is doing a lot of work on it too17:40
EmilienMpabelanger: see https://review.openstack.org/#/c/199712/17:40
*** xarses has quit IRC17:40
*** morazi has quit IRC17:41
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: get logs in jenkins workspace  https://review.openstack.org/19971217:41
EmilienMpabelanger: also working on running tempest on our beaker jobs17:43
EmilienMpabelanger: https://review.openstack.org/#/c/19856117:43
pabelangerEmilienM, interesting. Ya, still trying to wrap my head around some of the beaker stuff.  But looks like the right tool for more functional testing17:43
EmilienMpabelanger: and the last big thing I want to do is to have a new job to run a whole openstack node17:43
*** sergmelikyan has joined #puppet-openstack17:43
pabelangerEmilienM, Ya, that would be nice. I've always thought of writing a devstack project out of puppet modules for testing tempest. Then running it in parallel to devstack17:45
pabelangerthat way, we'd be testing packaging too, vs git install17:45
EmilienMthis is our plan17:45
EmilienMpabelanger: we have a grenade plan also, but let me take my lunch and I come back :)17:46
pabelangerEmilienM, Ya, I've never had time to focus on it. If you have a etherpad / spec about the effort I'd be interested in reading it.17:46
pabelangerEmilienM, My first effort of a devstack style project using puppet was for something I was working on before joining Red Hat. https://github.com/kickstandproject-dev/grunt17:47
pabelangerpretty simple, but worked well for my needs17:47
pabelangerwas using puppet-keystone and puppet-ceilometer for my functional testing17:47
pabelangerbut, I was installing my code from git, vs packages17:48
pabelangerended up using facter if I wanted to override puppet variables17:48
pabelangerat run time17:48
*** morazi has joined #puppet-openstack17:51
EmilienMpabelanger: nice17:57
EmilienMi'll look in dept17:57
EmilienMpabelanger: no I don't have any etherpad or spec, but I'm preparing an etherpad today17:58
EmilienMit was just in my mind17:58
EmilienMand I was playing with CI17:58
pabelangerEmilienM, Ya, same. Something I've always been wanting to work on, if I had some time to do it :)17:58
EmilienMpabelanger: I do have the time17:59
pabelangerEmilienM, well, if you get an etherpad going, I'm more then happy to collaborate.17:59
EmilienMpabelanger: I now focus 60% of my time to Puppet/CI17:59
pabelangerEmilienM, Ya, I think I could get some time to focus on it too18:00
*** xarses has joined #puppet-openstack18:04
*** vinay_ has quit IRC18:08
openstackgerritClayton O'Neill proposed openstack/puppet-designate: Add hooks for external install & svc management  https://review.openstack.org/19717218:08
richmEmilienM: re: httpd/keystone - I think it may be a problem18:14
EmilienMrichm: why?18:14
richmconsider a case where both horizon and keystone are in the same manifest18:14
richmkeystone uses eventlet18:15
richmkeystone_domain.rb types etc. use autorequire(:service) ['httpd', 'keystone']18:15
richmthat means, since 'httpd' is in the catalog, that keystone has to wait for both keystone and httpd18:15
richmwhat if horizon needs keystone to be up before it can configure httpd appropriately?18:16
richmthen you get a deadlock18:16
richmkeystone is waiting for 'httpd', and horizon is waiting for 'keystone'18:16
EmilienMpabelanger: https://etherpad.openstack.org/p/puppet-openstack-CI18:17
EmilienMpabelanger: all my mind is in there18:17
pabelangerEmilienM, okay, will check it out in a bit18:18
EmilienMrichm: horizon is waiting for keystone?18:18
richmEmilienM: yes18:18
richmlet's say horizon has to ensure some sort of keystone resource e.g. the horizon user, before it starts18:19
EmilienMright18:21
EmilienMrichm: I have a solution18:22
EmilienMmaybe18:23
EmilienMrichm: maybe with an anchor18:25
EmilienMbut last time I talked about anchors, people insulted me :)18:26
EmilienMrichm: I don't see any dep between puppet horizon & puppet-keystone18:28
*** sergmelikyan has quit IRC18:29
*** rwsu has quit IRC18:29
*** sergmelikyan has joined #puppet-openstack18:30
mgagneEmilienM: I like anchor when done correctly =)18:32
*** dfisher has quit IRC18:33
*** delattec has quit IRC18:33
EmilienMmgagne: I don't any other solution here18:33
EmilienMmgagne: but afik, anchors need PuppetDB, right?18:33
mgagneEmilienM: no18:34
*** delattec has joined #puppet-openstack18:34
EmilienMcool I'm wrong18:34
mgagneEmilienM: they are just dummy resources which you can "anchor to" (create relationships)18:34
EmilienMexactly what we need18:34
mgagneEmilienM: and force containment/order18:34
EmilienMcrinkle: wdyt?18:34
*** gfidente has quit IRC18:41
mfischdid you guys all get contrib codes to register for Tokyo?18:43
mfischI got one but I have a non-puppet commit I think18:43
EmilienMmgagne, richm: what if we put in ::keystone: Service[$service_name] -> Keystone_domain<||>18:48
pabelangerEmilienM, adding an update to etherpad18:49
pabelangerjust brain dumping18:49
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082718:50
*** sergmelikyan has quit IRC18:50
EmilienMpabelanger: you're duplicating the AIO thing I wrote18:50
*** dfisher has joined #puppet-openstack18:50
pabelangerEmilienM, Ah, I didn't know what AIO was18:50
crinkleEmilienM: anchor wfm18:51
EmilienMcrinkle: and having Service[$service_name] -> Keystone_domain<||> in init.pp ?18:51
crinkleEmilienM: i thought keystone_domain would autorequire the ancjor18:52
EmilienMcrinkle: if I do Service[$service_name] -> Keystone_domain<||> - I don't use anchor18:52
crinklei would rather not have -> Keystone_domain<||>18:53
EmilienMwhy ?18:53
crinkle<||> has the problem that it realizes virtual resources and i can imagine that a user might want to have virtual keystone domain resources18:54
crinklewhat is insufficient about tje anchor idea?18:54
EmilienMok go for anchor18:54
crinklei'm on phone so typing slow18:54
EmilienMcrinkle: multi tasking :P18:54
EmilienMrichm: starting anchor code right now18:54
openstackgerritPaul Belanger proposed openstack/puppet-openstack-integration: Add LICENSE file  https://review.openstack.org/20129618:58
EmilienMcrinkle: I see the case when pacemaker is managing keystone or apache18:58
openstackgerritPaul Belanger proposed openstack/puppet-openstack-integration: [WIP] Initial commit for keystone  https://review.openstack.org/20129819:05
*** aimon has quit IRC19:11
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130019:14
EmilienMmgagne, crinkle: ^19:14
crinkleEmilienM: what about that case?19:14
EmilienMcrinkle: pacemaker?19:14
crinkleEmilienM: yes?19:14
*** aimon has joined #puppet-openstack19:15
pabelangerEmilienM, my understanding was http://www.apache.org/licenses/LICENSE-2.0.txt was preferred for openstack projects.19:15
EmilienMcrinkle: I don't see the trouble here, since we just change the service_provider of Service resource when running pacemaker. But Service['keystone'] is still enabled19:15
pabelangertrying to find some documentation about it, but could be wrong19:15
EmilienMpabelanger: you're prob right, just thought to highlight it19:16
EmilienMpabelanger: not worth -1 though19:16
pabelangerEmilienM, okay. Going to ask either way19:17
crinklebtw i'm in and out this afternoon, back later tonight19:18
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082719:18
EmilienMcrinkle: ack19:18
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082719:23
EmilienMpabelanger: how do you plan to structure the manifests for AIO?19:30
EmilienMwe might need design discussion19:30
pabelangerEmilienM, agreed. I was thinking each service has its own manifest, which would be included from a top-level manifest.19:32
crinklemaybe a spec would be good19:32
pabelangersomething like single.pp would include keystone.pp which is setup for a single node19:32
EmilienMcrinkle: +119:32
pabelangerdon't have an issue getting a spec up19:32
pabelangerfigure I'd hack something up first19:32
pabelangerI imagine everybody has a way of doing it already envisioned in their head19:33
EmilienMpabelanger: instead of create a composition layer, I would rather see some Hiera around here19:33
*** aimon has quit IRC19:33
EmilienMit will save a lot of code and allow flexibility19:33
*** aimon has joined #puppet-openstack19:34
pabelangerhiera is possible19:36
openstackgerritPaul Belanger proposed openstack/puppet-openstack-integration: Give execute permissions to install_modules.sh  https://review.openstack.org/20130719:40
openstackgerritPaul Belanger proposed openstack/puppet-openstack-integration: [WIP] Initial commit for keystone  https://review.openstack.org/20129819:40
*** cwolferh has quit IRC19:41
*** blentz has quit IRC19:43
*** aimon has quit IRC19:44
*** blentz has joined #puppet-openstack19:45
*** aimon has joined #puppet-openstack19:46
EmilienMcrinkle: anchor does not work in the patch. If you around can you explain why exactly virtual resource can't work for us?19:46
EmilienMrichm: the anchor is not created19:48
EmilienMrichm: I'm looking at why19:48
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130019:53
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082719:54
*** rwsu has joined #puppet-openstack19:55
*** imcsk8_ has joined #puppet-openstack20:01
*** imcsk8 has quit IRC20:02
*** aimon has quit IRC20:05
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130020:06
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082720:06
*** aimon has joined #puppet-openstack20:07
*** dgurtner has joined #puppet-openstack20:09
*** dgurtner has quit IRC20:09
*** dgurtner has joined #puppet-openstack20:09
*** rwsu has quit IRC20:16
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: validate Keystone with Tempest  https://review.openstack.org/19856120:21
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: validate Keystone with Tempest  https://review.openstack.org/19856120:25
*** rwsu has joined #puppet-openstack20:29
EmilienMHunner or _ody: I think we need help with https://bugs.launchpad.net/puppet-keystone/+bug/147405920:29
openstackLaunchpad bug 1474059 in puppet-keystone "when WSGI enabled: domain service is unavailable during first Puppet run" [Critical,In progress] - Assigned to Emilien Macchi (emilienm)20:29
openstackgerritPaul Belanger proposed openstack/puppet-openstack-integration: [WIP] Initial commit for keystone  https://review.openstack.org/20129820:30
*** jayg is now known as jayg|g0n320:35
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130020:39
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082720:39
*** cwolferh has joined #puppet-openstack20:40
*** rcallawa has quit IRC20:41
HunnerEmilienM: side note, the collect on nil is because https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone_domain/openstack.rb#L107 should be something like `(request('domain','list') || []).collect`20:42
richmare you sure that request doesn't return [] if no domains are found?20:44
richmI mean, how could it have worked this way for all this time?20:44
richmDid we just get lucky for several weeks?20:44
EmilienMHunner: ^20:46
EmilienMI can't make the Anchor thing working :(20:47
richmhttps://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L2520:48
Hunnerrichm: https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L20 starts out nil20:50
Hunnerand is what is returned, so yes it returns nil20:50
HunnerSo better idea would be to have that default to Array.new instead of nil20:50
richmit doesn't always return an array20:51
HunnerEmilienM: It sounds like you think openstacklib's request method for timing out is not working correctly?20:51
Hunnerrichm: Okay, then never mind20:51
richmand it still doesn't explain why it works at all20:51
EmilienMHunner: also I'm wondering why https://review.openstack.org/201300 do not work20:52
richmso basically, every time request('object', 'list') is called and returns an empty list, we should get an exception?20:52
richmI'm not arguing that for safety's sake, returning || [] is probably the right thing to do20:53
richmI'm just trying to figure out what underlying condition is causing request() to return nil20:54
*** rcallawa has joined #puppet-openstack20:54
*** delatte has joined #puppet-openstack20:57
*** rcallawa has quit IRC20:58
richmbecause https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L27 parse_csv will _always_ return an array20:58
richmor raise an exception20:58
Hunnerrichm: Yeah, response.collect is fine. It will return nil if it hits the rescue and break without ever getting a value20:58
richmare you saying that it is possible for https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L30-L33 to raise an exception that would cause rv to be nil?20:59
*** delattec has quit IRC21:00
richmand not raise the exception to the caller instead?21:00
richmHunner: ^^21:01
richmHunner: because afaict, collect will _always_ return an array, even if it is empty21:02
richmso, not nil there either21:02
Hunnerrichm: https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L26 could raise and cause rv to be nil21:02
richmHunner: then why don't I see the exception that it is raising?21:02
richmmaybe the withenv is absorbing the raise and turning it into a nil return?21:03
Hunnerrichm: Because it's caught by the rescue... that's why you see the first sleep message before the collect on nil message21:03
richmHunner: caught here?  https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L5221:04
richmok21:04
richmso if we timeout, it will return nil21:04
Hunneryep21:04
HunnerAnd something appears to be wrong with the timeout code since it just says 10 seconds then moves on21:05
*** delattec has joined #puppet-openstack21:05
richmhmm - 1) would it be better to return nil to the providers, or raise some sort of timeout exception? 2) what exactly should the subclass provider do if request times out?21:07
*** delatte has quit IRC21:08
openstackgerritBradley Klein proposed openstack/puppet-monasca: Change to support api config for remote database  https://review.openstack.org/20018221:15
*** dprince has quit IRC21:15
Hunnerrichm: I think timeouts are unexpected and so returning nil is the wrong thing to do. https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L5821:16
HunnerThat should be a raise. The only break should be above before the rescue after rv is set21:16
richmso a timeout should raise some sort of Timeout exception to the caller?21:17
*** imcsk8_ is now known as imcsk821:22
richmHunner: ^^21:23
richmI guess that's fine.  It will get propagated all the way out to the main app if the caller doesn't know what to do21:24
HunnerOr just raise the original e, since at that point it's considered correct?21:24
richmHunner: yes21:24
EmilienMrichm, Hunner: in that case, is it possible 1/ httpd is longer to start than the eventlet process, so we take more time to be ready for the keystone_domain request 2/ oslib does not handle well timeouts ?21:36
richmyes, we could increase the timeout, but to what value?21:37
EmilienMrichm: I already tried yesterday21:37
EmilienMto 2021:37
EmilienMand it did not change anything21:37
HunnerI think the timeout may be broken, as in it says it's going to wait but doesn't21:38
EmilienMHunner: does the autorequire waits for a running service?21:39
crinklei'm surprised this hasn't been an issue before21:39
HunnerEmilienM: Autoreqire is basically adding `require` right? So if you have a service resource, that would be evaluated before any resources that autorequire it21:39
HunnerEmilienM: Whether it is ensure => stopped or running21:40
EmilienMok21:40
Hunnercrinkle: I don't know about the history of the code, but something looks fishy in that bug's output and smells like the timeout being shortcircuited21:40
*** bklei_ has joined #puppet-openstack21:42
crinkleit's typical for it to fail once, show that message, and then recover21:42
crinkleif it was timing out it would repeat the message21:42
*** bklei has quit IRC21:43
crinklecurrent_time wouldn't be > end_time until after a few more tries and it would keep spitting out that message21:43
crinklethat's why i think that notice is a red herring21:44
crinklei'm curious if the output one the line previous was about the service restarting21:44
EmilienMcrinkle: the question is: why does it work on eventlet and fails on wsgi. My first thought was about a race condition when starting the process (I think it takes more time to start httpd than keystone eventlet)21:48
crinkleEmilienM: but then it would show that and repeat the "Will retry for..." message while it was waiting21:49
crinklethat's what that's for21:49
EmilienMcrinkle: I tried with 20s last night, same result21:50
crinklei would try running the command by itself and see what it does21:50
EmilienMI think we have two issues here21:50
EmilienM1/ timeout message21:50
EmilienM2/ keystone resource orchestration to make sure to create them *after* keystone is run whatever wsgi or eventlet21:51
crinkleso after puppet exits, see it apache is running and see if keystone responds to commands21:51
* crinkle afk21:51
EmilienMHunner: I was wrong, when running wsgi, autorequire is useless currently, because service['keystone'] is stopped21:52
EmilienMHunner: we wanted to add ['httpd'] in the autorequire but it's a bad idea for the reason in the https://review.openstack.org/#/c/201300/ commit message21:53
EmilienMI'im still convainced an Anchor would help21:53
HunnerEmilienM: I'm not sure about your intended order of operations when using/not using http... :/21:54
HunnerIt sounds like sometimes you manage one service and sometimes two?21:54
HunnerAre you managing httpd from another module, or in the keystone module?21:54
*** dgurtner has quit IRC21:54
EmilienMHunner: 1/ if I run eventlet, Service['keystone'] ensure => running21:55
EmilienMHunner: 1/ if I run wsgi, Service['keystone'] ensure => stopped21:55
EmilienMoops 2/21:55
EmilienMHunner: the 2/ make sure apache is running since we include ::apache21:55
EmilienMand we have a dependency in init21:55
HunnerAnd does it go keystone => apache => resources when using apache?21:55
EmilienMhttps://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L52921:56
EmilienMno21:56
EmilienMwe 1/ make sure to stop keystone 2/ start apache21:56
EmilienM File['/etc/keystone/keystone.conf'] -> Keystone_config<||> ~> Service[httpd]21:56
EmilienMhttps://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L866-L87321:57
EmilienMHunner: look that ^21:57
EmilienMstopped21:57
HunnerEmilienM: What if you throw an anchor on the end of https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L529 and make resources autorequire that anchor?21:58
EmilienMHunner: I was doing that now21:58
EmilienMHunner: my mistake is I did the anchor in the keystone::service21:58
EmilienMbut the service is disabled21:58
EmilienMI'm so dumb21:58
EmilienMHunner: on which resource then?21:59
EmilienMon Service[$service_name] probably22:00
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130022:04
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082722:04
EmilienMHunner: ^22:05
*** morazi has quit IRC22:07
*** rcallawa has joined #puppet-openstack22:11
EmilienMrichm, crinkle, Hunner my patch works22:12
EmilienMI just tested it22:13
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: Use an Anchor when service is managed  https://review.openstack.org/20130022:14
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: acceptance: run keystone in a WSGI server by default  https://review.openstack.org/20082722:15
EmilienMmfisch: I have wsgi working out of the box now, please forget my questions from last night22:15
*** rcallawa_ has joined #puppet-openstack22:21
*** rcallawa has quit IRC22:23
EmilienMrichm: with my patch, I don't see any timeout issue22:24
richmEmilienM: excellent22:27
*** markvoelker has joined #puppet-openstack22:27
*** markvoelker has quit IRC22:27
*** markvoelker has joined #puppet-openstack22:27
*** gildub has joined #puppet-openstack22:33
EmilienMrichm: though we would keep an eye on this issue22:38
richmyes22:38
*** morazi has joined #puppet-openstack22:44
*** rwsu has quit IRC22:52
*** mdorman has quit IRC23:09
*** dfisher has quit IRC23:10
*** mgarza_ has quit IRC23:12
*** ducttape_ has quit IRC23:16
openstackgerritMerged openstack/puppet-openstack-specs: Blueprint: Define our master branch policy  https://review.openstack.org/18014123:17
*** xarses has quit IRC23:18
*** topshare has joined #puppet-openstack23:28
openstackgerritMerged openstack/puppet-monasca: Change to support api config for remote database  https://review.openstack.org/20018223:39
*** xarses has joined #puppet-openstack23:42
*** ducttape_ has joined #puppet-openstack23:44
*** ducttape_ has quit IRC23:48
*** topshare has quit IRC23:52
*** xingchao has quit IRC23:53
*** xingchao has joined #puppet-openstack23:53
« Sunday, 2015-07-12 Index Tuesday, 2015-07-14 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!