| *** topshare has quit IRC | 00:07 | |
| *** xarses has quit IRC | 00:22 | |
| openstackgerrit | Merged openstack/puppet-openstacklib: Add include on ::mysql::server https://review.openstack.org/199822 | 00:25 |
|---|---|---|
| *** ducttape_ has joined #puppet-openstack | 00:32 | |
| *** xarses has joined #puppet-openstack | 00:41 | |
| *** bitblt has quit IRC | 00:44 | |
| *** xingchao has quit IRC | 00:50 | |
| *** xingchao has joined #puppet-openstack | 00:50 | |
| *** topshare has joined #puppet-openstack | 00:53 | |
| *** xingchao has quit IRC | 00:53 | |
| *** aimon has joined #puppet-openstack | 00:58 | |
| *** topshare has quit IRC | 01:18 | |
| *** rcallawa_ has quit IRC | 01:18 | |
| *** rcallawa has joined #puppet-openstack | 01:18 | |
| *** topshare has joined #puppet-openstack | 01:23 | |
| *** dprince has quit IRC | 01:36 | |
| *** bklei has joined #puppet-openstack | 01:36 | |
| *** ilbot3 has quit IRC | 01:45 | |
| *** ilbot3 has joined #puppet-openstack | 01:47 | |
| *** markvoelker has quit IRC | 01:54 | |
| *** bklei has quit IRC | 01:56 | |
| *** markvoelker has joined #puppet-openstack | 02:00 | |
| openstackgerrit | Merged openstack/puppet-openstack-integration: puppetfile: Bump puppetlabs-inifile module to 1.4.x https://review.openstack.org/199988 | 02:02 |
| *** rcallawa_ has joined #puppet-openstack | 02:03 | |
| *** rcallawa has quit IRC | 02:07 | |
| openstackgerrit | Merged openstack/puppet-openstack_extras: Fixup README.md table of contents https://review.openstack.org/198803 | 02:12 |
| openstackgerrit | Merged openstack/puppet-ceilometer: Simplify parameters for rpc_backend https://review.openstack.org/196036 | 02:17 |
| *** markvoelker has quit IRC | 02:18 | |
| openstackgerrit | Merged openstack/puppet-neutron: N1Kv:Adding params for IPv6 communication with VSM https://review.openstack.org/200735 | 02:24 |
| *** xarses_ has joined #puppet-openstack | 02:42 | |
| *** xarses has quit IRC | 02:45 | |
| *** bklei has joined #puppet-openstack | 02:57 | |
| *** richm has quit IRC | 02:57 | |
| *** bklei has quit IRC | 03:01 | |
| *** fvollero has quit IRC | 03:06 | |
| *** ducttape_ has quit IRC | 03:14 | |
| openstackgerrit | Merged openstack/puppet-sahara: spec: Update deprecated rspec keywords https://review.openstack.org/199620 | 03:18 |
| *** ducttape_ has joined #puppet-openstack | 03:20 | |
| openstackgerrit | Merged openstack/puppet-keystone: fix module install reference https://review.openstack.org/199810 | 03:21 |
| *** topshare has quit IRC | 03:28 | |
| *** topshare has joined #puppet-openstack | 03:30 | |
| *** markvoelker has joined #puppet-openstack | 03:35 | |
| *** markvoelker_ has joined #puppet-openstack | 03:38 | |
| *** ducttape_ has quit IRC | 03:39 | |
| *** markvoelker has quit IRC | 03:40 | |
| *** bklei has joined #puppet-openstack | 04:01 | |
| *** markvoelker has joined #puppet-openstack | 04:04 | |
| *** bklei has quit IRC | 04:06 | |
| *** markvoelker_ has quit IRC | 04:07 | |
| *** markvoelker_ has joined #puppet-openstack | 04:08 | |
| *** markvoelker has quit IRC | 04:09 | |
| *** gildub has quit IRC | 04:14 | |
| *** linkedinyou has joined #puppet-openstack | 04:18 | |
| *** rcallawa has joined #puppet-openstack | 04:26 | |
| *** topshare has quit IRC | 04:26 | |
| *** rcallawa_ has quit IRC | 04:27 | |
| *** topshare has joined #puppet-openstack | 04:31 | |
| *** danieru has quit IRC | 04:35 | |
| *** danieru has joined #puppet-openstack | 04:36 | |
| *** gildub has joined #puppet-openstack | 04:41 | |
| *** saneax_ has quit IRC | 04:50 | |
| *** francois has quit IRC | 04:57 | |
| *** francois has joined #puppet-openstack | 04:57 | |
| *** markvoelker has joined #puppet-openstack | 05:06 | |
| *** markvoelker_ has quit IRC | 05:06 | |
| *** markvoelker_ has joined #puppet-openstack | 05:08 | |
| *** markvoelker has quit IRC | 05:11 | |
| LimorStotland | Hi all stupid questions... i have the puppet for mistral and i want to contribute it. where should i open the BP and to where should i contribute it? | 05:14 |
| *** topshare has quit IRC | 05:48 | |
| *** bklei has joined #puppet-openstack | 05:50 | |
| *** topshare has joined #puppet-openstack | 05:51 | |
| *** rhefner has quit IRC | 05:51 | |
| *** dboik has joined #puppet-openstack | 05:53 | |
| *** bklei has quit IRC | 05:55 | |
| *** dboik has quit IRC | 05:57 | |
| *** paramite has joined #puppet-openstack | 06:02 | |
| *** stamak has joined #puppet-openstack | 06:18 | |
| *** topshare has quit IRC | 06:29 | |
| *** topshare has joined #puppet-openstack | 06:33 | |
| *** saneax has joined #puppet-openstack | 06:39 | |
| *** stamak has quit IRC | 07:04 | |
| *** samuelBartel has joined #puppet-openstack | 07:06 | |
| *** topshare_ has joined #puppet-openstack | 07:07 | |
| *** topshare has quit IRC | 07:09 | |
| *** paramite is now known as paramite|afk | 07:11 | |
| *** paramite|afk is now known as paramite | 07:19 | |
| *** zigo has quit IRC | 07:24 | |
| *** zigo has joined #puppet-openstack | 07:25 | |
| *** topshare_ has quit IRC | 07:28 | |
| *** _stowa has quit IRC | 07:30 | |
| *** _stowa_ has joined #puppet-openstack | 07:35 | |
| *** topshare has joined #puppet-openstack | 07:37 | |
| *** bklei has joined #puppet-openstack | 07:39 | |
| *** bklei has quit IRC | 07:44 | |
| *** dgurtner has joined #puppet-openstack | 07:45 | |
| *** dachary has quit IRC | 07:45 | |
| *** dachary has joined #puppet-openstack | 07:45 | |
| *** _stowa_ is now known as _stowa | 07:46 | |
| *** topshare has quit IRC | 07:50 | |
| *** andreww has joined #puppet-openstack | 07:55 | |
| *** sergmelikyan has joined #puppet-openstack | 07:56 | |
| *** topshare has joined #puppet-openstack | 07:56 | |
| *** xarses_ has quit IRC | 07:57 | |
| *** jayg|g0n3 has quit IRC | 07:57 | |
| *** jayg|g0n3 has joined #puppet-openstack | 08:00 | |
| *** dmellado has left #puppet-openstack | 08:08 | |
| *** jistr has joined #puppet-openstack | 08:12 | |
| *** fvollero has joined #puppet-openstack | 08:12 | |
| *** fvollero has quit IRC | 08:16 | |
| *** fvollero has joined #puppet-openstack | 08:16 | |
| *** gildub has quit IRC | 08:18 | |
| *** markvoelker_ has quit IRC | 08:21 | |
| *** fvollero has quit IRC | 08:24 | |
| *** fvollero has joined #puppet-openstack | 08:25 | |
| *** fvollero has quit IRC | 08:26 | |
| *** fvollero has joined #puppet-openstack | 08:26 | |
| *** topshare has quit IRC | 08:30 | |
| *** stamak has joined #puppet-openstack | 08:34 | |
| *** topshare has joined #puppet-openstack | 08:34 | |
| *** derekh has joined #puppet-openstack | 08:35 | |
| *** markvoelker has joined #puppet-openstack | 08:36 | |
| *** LimorStotland_ has joined #puppet-openstack | 08:43 | |
| *** markvoelker has quit IRC | 08:45 | |
| *** LimorStotland__ has joined #puppet-openstack | 08:45 | |
| *** LimorStotland_ has quit IRC | 08:45 | |
| *** LimorStotland has quit IRC | 08:46 | |
| *** dalgaaf has quit IRC | 08:48 | |
| *** markvoelker has joined #puppet-openstack | 08:51 | |
| *** LimorStotland__ has quit IRC | 08:53 | |
| *** LimorStotland has joined #puppet-openstack | 08:53 | |
| *** markvoelker has quit IRC | 08:56 | |
| rcarrillocruz | morning folks | 09:00 |
| rcarrillocruz | what's the convention for documenting parameters on puppet classes | 09:00 |
| rcarrillocruz | required params first, optional last | 09:00 |
| rcarrillocruz | ? | 09:00 |
| *** derekh has quit IRC | 09:02 | |
| *** markvoelker has joined #puppet-openstack | 09:06 | |
| *** paramite is now known as paramite|afk | 09:07 | |
| *** markvoelker has quit IRC | 09:10 | |
| *** dalgaaf has joined #puppet-openstack | 09:12 | |
| *** markvoelker has joined #puppet-openstack | 09:20 | |
| *** aarefiev has quit IRC | 09:22 | |
| *** markvoelker has quit IRC | 09:25 | |
| *** bklei has joined #puppet-openstack | 09:28 | |
| *** bklei has quit IRC | 09:32 | |
| *** markvoelker has joined #puppet-openstack | 09:35 | |
| *** markvoelker has quit IRC | 09:40 | |
| *** LimorStotland has quit IRC | 09:48 | |
| *** markvoelker has joined #puppet-openstack | 09:49 | |
| *** markvoelker has quit IRC | 09:54 | |
| *** sergmelikyan has quit IRC | 09:57 | |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack/puppet-ironic: Add bifrost manifest https://review.openstack.org/202025 | 09:59 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack/puppet-ironic: Add bifrost manifest https://review.openstack.org/202025 | 10:01 |
| *** markvoelker has joined #puppet-openstack | 10:04 | |
| openstackgerrit | Yanis Guenane proposed openstack/puppet-tripleo: Implement firewalling in tripleo::firewall https://review.openstack.org/202027 | 10:05 |
| *** sergmelikyan has joined #puppet-openstack | 10:06 | |
| *** markvoelker has quit IRC | 10:08 | |
| *** rcallawa has quit IRC | 10:10 | |
| *** rcallawa has joined #puppet-openstack | 10:10 | |
| *** gildub has joined #puppet-openstack | 10:12 | |
| *** barthalion has quit IRC | 10:17 | |
| *** markvoelker has joined #puppet-openstack | 10:19 | |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack/puppet-ironic: Add bifrost manifest https://review.openstack.org/202025 | 10:20 |
| *** paramite|afk is now known as paramite | 10:22 | |
| *** markvoelker has quit IRC | 10:23 | |
| *** markvoelker has joined #puppet-openstack | 10:33 | |
| *** sergmelikyan has quit IRC | 10:36 | |
| *** rcallawa_ has joined #puppet-openstack | 10:37 | |
| *** markvoelker has quit IRC | 10:38 | |
| *** rcallawa has quit IRC | 10:41 | |
| *** rcallawa_ has quit IRC | 10:41 | |
| *** rcallawa has joined #puppet-openstack | 10:42 | |
| *** rcallawa_ has joined #puppet-openstack | 10:46 | |
| *** markvoelker has joined #puppet-openstack | 10:48 | |
| *** rcallawa has quit IRC | 10:49 | |
| *** markvoelker has quit IRC | 10:54 | |
| *** topshare has quit IRC | 10:54 | |
| EmilienM | good morning folks | 10:59 |
| EmilienM | rcarrillocruz: you have good examples in our modules, let me know if you need some code highlight | 10:59 |
| *** markvoelker has joined #puppet-openstack | 11:02 | |
| *** sergmelikyan has joined #puppet-openstack | 11:07 | |
| *** markvoelker has quit IRC | 11:07 | |
| rcarrillocruz | EmilienM: hiya, upped https://review.openstack.org/202025 , created example and followed documentation as ::ironic manifest | 11:09 |
| rcarrillocruz | thx | 11:09 |
| EmilienM | rcarrillocruz: cool, let me look | 11:09 |
| rcarrillocruz | EmilienM: where are you based btw? France or are you in the US | 11:09 |
| rcarrillocruz | you appear to have a wide range of working hours | 11:09 |
| EmilienM | rcarrillocruz: eastern | 11:10 |
| EmilienM | rcarrillocruz: you? | 11:10 |
| rcarrillocruz | CET, Spain | 11:10 |
| EmilienM | cool :) | 11:10 |
| _nick | EmilienM: i've got a couple of rdo-related bugs logged that are an easy fix - what's the etiquette as far as submitting a PR goes? one per bug or a single PR that addresses both? | 11:10 |
| EmilienM | _nick: the bugs need to be reported on Launchpad and submitted as a regular patch via Gerrit system with the tag Closes-bug: # - More doc here: http://docs.openstack.org/infra/manual/developers.html | 11:11 |
| _nick | yep, i've reported them both on launchpad - and thanks, just thought i'd double check and ask the obvious before making a fool of myself ;) | 11:13 |
| *** gildub has quit IRC | 11:13 | |
| *** markvoelker has joined #puppet-openstack | 11:17 | |
| *** bklei has joined #puppet-openstack | 11:17 | |
| *** rcallawa_ has quit IRC | 11:20 | |
| *** markvoelker has quit IRC | 11:21 | |
| *** bklei has quit IRC | 11:21 | |
| *** markvoelker has joined #puppet-openstack | 11:24 | |
| *** openstack has joined #puppet-openstack | 11:38 | |
| *** markvoelker has joined #puppet-openstack | 11:39 | |
| *** markvoelker has quit IRC | 11:44 | |
| *** xingchao has joined #puppet-openstack | 11:51 | |
| *** rcallawa has joined #puppet-openstack | 11:53 | |
| *** markvoelker has joined #puppet-openstack | 11:54 | |
| *** delattec has joined #puppet-openstack | 11:56 | |
| *** markvoelker has quit IRC | 11:58 | |
| *** topshare has joined #puppet-openstack | 11:59 | |
| *** topshare has quit IRC | 12:00 | |
| openstackgerrit | Nick Jones proposed openstack/puppet-neutron: VPNaaS package name updates for RHEL / CentOS 7 https://review.openstack.org/202065 | 12:05 |
| *** markvoelker has joined #puppet-openstack | 12:08 | |
| *** jayg|g0n3 is now known as jayg | 12:09 | |
| *** leeuwenrjj has joined #puppet-openstack | 12:09 | |
| *** ducttape_ has joined #puppet-openstack | 12:10 | |
| *** topshare has joined #puppet-openstack | 12:12 | |
| *** topshare has quit IRC | 12:12 | |
| *** markvoelker has quit IRC | 12:13 | |
| *** topshare has joined #puppet-openstack | 12:13 | |
| openstackgerrit | Xiaohua Yuan proposed openstack/puppet-manila: Move qpid settings to oslo_messaging_qpid section https://review.openstack.org/199374 | 12:17 |
| *** bklei has joined #puppet-openstack | 12:18 | |
| *** morazi has joined #puppet-openstack | 12:18 | |
| *** bklei has quit IRC | 12:22 | |
| *** markvoelker has joined #puppet-openstack | 12:23 | |
| *** topshare has quit IRC | 12:24 | |
| *** ducttape_ has quit IRC | 12:27 | |
| *** markvoelker has quit IRC | 12:28 | |
| *** magicboiz has joined #puppet-openstack | 12:31 | |
| magicboiz | Hello there! | 12:32 |
| magicboiz | Anyone smarter than me who can help me with this?: | 12:32 |
| magicboiz | Error: Could not retrieve catalog from remote server: Error 400 on SERVER: $concat_basedir not defined. Try running again with pluginsync=true on the [master] and/or [main] section of your node's '/etc/puppet/puppet.conf'. at /etc/puppet/environments/production/modules/concat/manifests/setup.pp:20 on node | 12:32 |
| magicboiz | I have "pluginsync=true" enabled on master and main and agent sections of puppet.conf | 12:33 |
| magicboiz | also I'm running foreman... | 12:33 |
| magicboiz | puppet 3.8.1 | 12:33 |
| magicboiz | foreman 1.8.2 | 12:34 |
| *** dprince has joined #puppet-openstack | 12:34 | |
| *** Vinsh has quit IRC | 12:37 | |
| *** markvoelker has joined #puppet-openstack | 12:37 | |
| EmilienM | magicboiz: have you tried pluginsync=true on puppetmaster ? | 12:38 |
| magicboiz | <EmilienM>: it's enabled on puppet.conf, in master section.... isn't it enough? I running apache/passenger btw... | 12:40 |
| EmilienM | ah | 12:41 |
| EmilienM | did not read correctly | 12:41 |
| *** markvoelker has quit IRC | 12:42 | |
| magicboiz | root@puppetmaster:/etc/puppet/environments# !facter | 12:43 |
| magicboiz | facter concat_basedir | 12:43 |
| magicboiz | Already evaluated rest at /var/lib/gems/1.9.1/gems/facter-2.4.4/lib/facter/gce.rb:4, reevaluating anyways | 12:43 |
| magicboiz | Already evaluated rest at /var/lib/gems/1.9.1/gems/facter-2.4.4/lib/facter/ec2.rb:21, reevaluating anyways | 12:43 |
| magicboiz | Already evaluated rest at /var/lib/gems/1.9.1/gems/facter-2.4.4/lib/facter/ec2.rb:38, reevaluating anyways | 12:43 |
| magicboiz | facter doesn't return anything... | 12:44 |
| *** topshare has joined #puppet-openstack | 12:44 | |
| EmilienM | magicboiz: maybe you would be luckier to ask on #puppet channel maybe | 12:45 |
| magicboiz | ok, I'll try there, I asked here because I was trying the openstack module.... | 12:46 |
| magicboiz | thx | 12:46 |
| *** saneax has quit IRC | 12:48 | |
| EmilienM | magicboiz: which module? | 12:50 |
| EmilienM | swift I would bet | 12:50 |
| *** markvoelker has joined #puppet-openstack | 12:52 | |
| *** ferest has joined #puppet-openstack | 12:54 | |
| *** markvoelker has quit IRC | 12:56 | |
| *** markvoelker has joined #puppet-openstack | 13:01 | |
| *** sergmelikyan has joined #puppet-openstack | 13:05 | |
| *** markvoelker has quit IRC | 13:09 | |
| *** markvoelker has joined #puppet-openstack | 13:09 | |
| *** markvoelker_ has joined #puppet-openstack | 13:10 | |
| *** markvoelker has quit IRC | 13:14 | |
| *** bklei has joined #puppet-openstack | 13:14 | |
| *** richm has joined #puppet-openstack | 13:15 | |
| *** bklei has quit IRC | 13:15 | |
| *** bklei has joined #puppet-openstack | 13:15 | |
| *** bklei has quit IRC | 13:19 | |
| *** ferest has quit IRC | 13:23 | |
| rcarrillocruz | EmilienM: i haven't written beaker unit tests so far, do we have puppet-openstack specific guides? | 13:24 |
| rcarrillocruz | before going to google and getting my head around official docs | 13:24 |
| *** dfisher has joined #puppet-openstack | 13:25 | |
| *** topshare has quit IRC | 13:25 | |
| EmilienM | rcarrillocruz: I don't ask for beaker tests, only rspec (see specs/classes) | 13:25 |
| rcarrillocruz | erm, rspec | 13:26 |
| rcarrillocruz | see? no idea on puppet unit testing :-) | 13:26 |
| EmilienM | rcarrillocruz: I'm on a call right now, I'll help you today | 13:27 |
| EmilienM | or anyone else here | 13:27 |
| rcarrillocruz | no biggie, i'll dive in rspec tutorials, thx | 13:28 |
| *** derekh has joined #puppet-openstack | 13:30 | |
| _nick | EmilienM: https://review.openstack.org/#/c/202065/ is mine, if anything looks / smells bad let me know | 13:30 |
| *** ddmitriev has quit IRC | 13:46 | |
| *** sergmelikyan has quit IRC | 13:47 | |
| *** jistr is now known as jistr|mtg | 13:49 | |
| *** rhefner has joined #puppet-openstack | 13:59 | |
| *** dboik has joined #puppet-openstack | 14:03 | |
| *** ducttape_ has joined #puppet-openstack | 14:04 | |
| dboik | EmilienM: hi | 14:10 |
| *** xingchao has quit IRC | 14:16 | |
| *** topshare has joined #puppet-openstack | 14:25 | |
| *** topshare has quit IRC | 14:25 | |
| *** sergmelikyan has joined #puppet-openstack | 14:28 | |
| *** markvoelker has joined #puppet-openstack | 14:28 | |
| *** topshare has joined #puppet-openstack | 14:30 | |
| *** topshare has quit IRC | 14:31 | |
| *** markvoel_ has joined #puppet-openstack | 14:31 | |
| *** markvoelker has quit IRC | 14:31 | |
| *** rbrooker has joined #puppet-openstack | 14:31 | |
| *** topshare has joined #puppet-openstack | 14:31 | |
| *** markvoelker_ has quit IRC | 14:32 | |
| *** jistr|mtg is now known as jistr | 14:33 | |
| *** markvoel_ has quit IRC | 14:33 | |
| *** xingchao has joined #puppet-openstack | 14:34 | |
| openstackgerrit | Denis Egorenko proposed openstack/puppet-sahara: Configure rpc options separately from ceilometer notifications https://review.openstack.org/198744 | 14:34 |
| openstackgerrit | Denis Egorenko proposed openstack/puppet-sahara: Add distribute mode for Sahara https://review.openstack.org/192721 | 14:34 |
| EmilienM | dboik: hey | 14:36 |
| dboik | EmilienM: I made some more changes to https://review.openstack.org/#/c/197181. Can you take another look and let me know what you think of the approach? | 14:37 |
| EmilienM | dboik: sure! I was talking with jayg about that in our daily meeting | 14:37 |
| dboik | ok cool, thanks! | 14:38 |
| *** sergmelikyan has quit IRC | 14:48 | |
| *** leeuwenrjj has quit IRC | 14:48 | |
| *** jasondotstar has joined #puppet-openstack | 14:49 | |
| *** markvoelker has joined #puppet-openstack | 14:53 | |
| rcarrillocruz | hmm | 14:54 |
| *** sergmelikyan has joined #puppet-openstack | 14:54 | |
| rcarrillocruz | so, playing with rspec tests | 14:54 |
| *** sergmelikyan has quit IRC | 14:54 | |
| rcarrillocruz | i've done bundle install on puppet-ironic | 14:54 |
| rcarrillocruz | and that seemd to have installed puppet 4.2.0 gem | 14:54 |
| EmilienM | rcarrillocruz: yes it does | 14:54 |
| *** markvoelker_ has joined #puppet-openstack | 14:54 | |
| rcarrillocruz | which breaks rake tests ( i get some error 'Could not autoload puppet/provider/package/pkgdmg' ) | 14:55 |
| *** paramite has quit IRC | 14:55 | |
| rcarrillocruz | searching on irc history, crinkle suggested to other user to downgrade to puppet 3 | 14:55 |
| rcarrillocruz | is that accurate still? | 14:55 |
| rcarrillocruz | i'll find out shortly | 14:56 |
| rcarrillocruz | installing puppet gem v 3.8.1 | 14:56 |
| EmilienM | rcarrillocruz: AFIK, Puppet tests should pass 4.2: https://review.openstack.org/#/c/202025/ | 14:56 |
| EmilienM | maybe your test is not correct? | 14:56 |
| *** topshare has quit IRC | 14:56 | |
| rcarrillocruz | well, i get that error for already existing tests , have not added my tests yet | 14:56 |
| *** mdorman has joined #puppet-openstack | 14:56 | |
| EmilienM | rcarrillocruz: why does it pass our CI now? | 14:57 |
| *** sergmelikyan has joined #puppet-openstack | 14:57 | |
| rcarrillocruz | must be something on my env for sure | 14:57 |
| EmilienM | rcarrillocruz: http://logs.openstack.org/25/202025/3/check/gate-puppet-ironic-puppet-unit-latest/b2a35d0/console.html#_2015-07-15_10_26_23_701 | 14:57 |
| *** markvoelker has quit IRC | 14:58 | |
| EmilienM | I guess it's in your env | 14:58 |
| crinkle | rcarrillocruz: what version of rspec-puppet do you have? | 14:58 |
| crinkle | earlier versions didn't work with puppet 4 | 14:58 |
| EmilienM | should be 2.1.0 | 14:58 |
| EmilienM | afik | 14:58 |
| rcarrillocruz | i'll tell you in a sec | 14:58 |
| EmilienM | crinkle: o/ | 14:58 |
| crinkle | EmilienM: o/ | 14:59 |
| *** topshare has joined #puppet-openstack | 14:59 | |
| rcarrillocruz | rspec-puppet (2.2.0, 2.1.0) | 15:00 |
| rcarrillocruz | is that ok? | 15:00 |
| *** sergmelikyan has quit IRC | 15:00 | |
| *** stamak has quit IRC | 15:01 | |
| crinkle | should be | 15:01 |
| *** sergmelikyan has joined #puppet-openstack | 15:02 | |
| rcarrillocruz | does that output means that i have two different versions of rspec-puppet? | 15:02 |
| EmilienM | this is was we test in os infra | 15:02 |
| rcarrillocruz | i'm completely new to the ruby ecosystem of tools | 15:02 |
| rcarrillocruz | hmm | 15:02 |
| rcarrillocruz | interesting | 15:02 |
| rcarrillocruz | so | 15:02 |
| rcarrillocruz | downgrading to puppet 3.8.1 | 15:02 |
| rcarrillocruz | makes tests to pass | 15:02 |
| rcarrillocruz | 140 examples, 0 failures | 15:02 |
| *** sergmelikyan has quit IRC | 15:03 | |
| EmilienM | mhh | 15:04 |
| EmilienM | that's weird | 15:04 |
| EmilienM | we also test rspec-puppet 2.1.0 with puppet 3.8.1 and 4.2 | 15:04 |
| rcarrillocruz | anyway, will dig into that later | 15:05 |
| rcarrillocruz | quick 101 on rspec tests, i must add a class on /spec/classes for the bifrost stuff | 15:05 |
| rcarrillocruz | anything else? fixtures, examples? | 15:05 |
| rcarrillocruz | i take example is kind of actual data you pass to the tests to run | 15:05 |
| rcarrillocruz | ? | 15:05 |
| crinkle | examples would be nice but we're not actually great at keeping examples up to date | 15:06 |
| crinkle | you can add to the acceptance tests | 15:06 |
| crinkle | in spec/acceptance | 15:06 |
| rcarrillocruz | ok | 15:06 |
| rcarrillocruz | so spec/class | 15:06 |
| rcarrillocruz | spec/acceptance | 15:06 |
| crinkle | yep | 15:06 |
| rcarrillocruz | let me see what's already in there for puppet-ironic | 15:06 |
| EmilienM | acceptance is functional testing | 15:06 |
| *** sergmelikyan has joined #puppet-openstack | 15:07 | |
| * rcarrillocruz is happy to learn new things, not thrilled with ruby tho | 15:07 | |
| *** xingchao has quit IRC | 15:13 | |
| *** topshare has quit IRC | 15:19 | |
| *** topshare has joined #puppet-openstack | 15:20 | |
| *** saneax has joined #puppet-openstack | 15:24 | |
| *** cwolferh has quit IRC | 15:24 | |
| *** sergmelikyan has quit IRC | 15:44 | |
| *** andreww has quit IRC | 15:46 | |
| *** aimon has quit IRC | 15:52 | |
| *** stamak has joined #puppet-openstack | 15:54 | |
| *** saneax has quit IRC | 15:55 | |
| *** logan2 has quit IRC | 16:00 | |
| *** topshare has quit IRC | 16:01 | |
| *** andreww has joined #puppet-openstack | 16:05 | |
| *** cwolferh has joined #puppet-openstack | 16:09 | |
| *** xingchao has joined #puppet-openstack | 16:14 | |
| *** stamak has quit IRC | 16:23 | |
| *** markvoelker_ has quit IRC | 16:40 | |
| *** markvoelker has joined #puppet-openstack | 16:42 | |
| openstackgerrit | Denis Egorenko proposed openstack/puppet-sahara: Configure rpc options separately from ceilometer notifications https://review.openstack.org/198744 | 16:43 |
| *** aimon has joined #puppet-openstack | 16:43 | |
| EmilienM | crinkle, nibalizer: I'm about being away for one week. I wanted to re-sync about openstack integration CI. 1/ I suggest to push another patchset on https://review.openstack.org/201584, regarding my reviews and have this job voting from start, so we can have functional testing from start for this repo at least - 2/ start a PoC of a minimal OpenStack installationg, using our work in beaker manifests (example with keystone+wsgi is a good start I | 16:43 |
| EmilienM | think) | 16:44 |
| *** jistr has quit IRC | 16:50 | |
| *** pabelanger has quit IRC | 16:57 | |
| *** pabelanger has joined #puppet-openstack | 16:57 | |
| openstackgerrit | Denis Egorenko proposed openstack/puppet-sahara: Add distribute mode for Sahara https://review.openstack.org/192721 | 16:59 |
| *** derekh has quit IRC | 17:01 | |
| EmilienM | pabelanger: last comment | 17:01 |
| EmilienM | pabelanger: on https://review.openstack.org/#/c/201584 | 17:02 |
| *** stamak has joined #puppet-openstack | 17:05 | |
| *** rcallawa has quit IRC | 17:08 | |
| *** logan2 has joined #puppet-openstack | 17:10 | |
| *** rcallawa has joined #puppet-openstack | 17:11 | |
| pabelanger | EmilienM, Ah, learned something about zuul. fixing | 17:15 |
| pabelanger | also, I think puppet-.*$ hits all of puppet-openstack-integration jobs | 17:16 |
| pabelanger | well, it does I should say | 17:17 |
| *** guimaluf has joined #puppet-openstack | 17:25 | |
| guimaluf | hey guys, when running puppet agent in my kesytone node, puppet hangs while executing Debug: Executing '/usr/bin/openstack project list --quiet --format csv --long' | 17:26 |
| guimaluf | it executes right in the CLI but in puppet it hangs.... any idea? | 17:27 |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/puppet-openstack-specs: Enabling-federation https://review.openstack.org/190361 | 17:28 |
| *** mgarza_ has joined #puppet-openstack | 17:32 | |
| iurygregory | hey EmilienM, i have moved the spec to liberty folder and changed the index =) | 17:42 |
| *** dalgaaf has quit IRC | 17:48 | |
| openstackgerrit | Lukas Bezdicka proposed openstack/puppet-neutron: Run neutron db sync also for each neutron module https://review.openstack.org/200877 | 17:51 |
| EmilienM | iurygregory: cool, will look | 17:51 |
| openstackgerrit | Andrey Shestakov proposed openstack/puppet-nova: Add ability to set scheduler_use_baremetal_filters https://review.openstack.org/202215 | 17:52 |
| guimaluf | EmilienM, could you help me with this? when running puppet agent in my kesytone node, puppet hangs while executing Debug: Executing '/usr/bin/openstack project list --quiet --format csv --long' | 17:54 |
| EmilienM | guimaluf: I can help if you provide us your manifest | 17:54 |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/puppet-openstack-specs: Enabling-federation https://review.openstack.org/190361 | 17:55 |
| iurygregory | thanks EmilienM =) | 17:56 |
| guimaluf | EmilienM, http://paste.openstack.org/show/378162/ | 17:57 |
| openstackgerrit | Lukas Bezdicka proposed openstack/puppet-neutron: Run neutron db sync also for each neutron module https://review.openstack.org/200877 | 17:59 |
| social | now it will magicly pass without duplicate declaration >.> | 18:00 |
| richm | guimaluf: is this with the latest puppet-keystone from git? | 18:00 |
| guimaluf | richm, 6.0.0 | 18:00 |
| guimaluf | not master | 18:00 |
| guimaluf | but stable kilo | 18:00 |
| richm | guimaluf: what happens if you run this from the command line: | 18:01 |
| EmilienM | sync db is at false, why? | 18:01 |
| EmilienM | keystone will fail to start I think if you don't run db sync | 18:01 |
| *** rcallawa has quit IRC | 18:01 | |
| richm | # OS_IDENTITY_API_VERSION=3 OS_TOKEN="your admin token" OS_URL=http://localhost:35357/v3 openstack project list --long | 18:01 |
| richm | guimaluf: ^^^ | 18:01 |
| EmilienM | richm: see my comment, I don't think keystone can run if dbsync has not been run | 18:02 |
| richm | ok - then ps -ef|grep keystone | 18:02 |
| *** stamak has quit IRC | 18:04 | |
| guimaluf | richm, I doesn't have v3 endpoint | 18:07 |
| guimaluf | EmilienM, causa I usualy run mannualy | 18:07 |
| guimaluf | EmilienM, and I'm testing on production... so I was afraid of massing the DB | 18:08 |
| EmilienM | lol | 18:08 |
| EmilienM | guimaluf: my guess is keystone does not start because you don't run db sync | 18:08 |
| *** rcallawa has joined #puppet-openstack | 18:09 | |
| EmilienM | the use case of having this boolean is when running multi node or pacemaker, and you need to avoid race condition in running dbsync | 18:09 |
| guimaluf | EmilienM, but keystone it's started! | 18:12 |
| EmilienM | guimaluf: and logs? | 18:12 |
| EmilienM | can you paste it? | 18:12 |
| *** mdorman has quit IRC | 18:15 | |
| *** mdorman has joined #puppet-openstack | 18:16 | |
| *** dalgaaf has joined #puppet-openstack | 18:19 | |
| richm | guimaluf: what do you mean "doesn't have v3 endpoint"? | 18:21 |
| richm | guimaluf: are you using Kilo version of Keystone? | 18:21 |
| richm | guimaluf: if so, then yes, you have /v3 endpoint | 18:22 |
| richm | unless that endpoint is created by db sync, and you haven't run db sync in a very long time | 18:23 |
| guimaluf | richm, my db is synced, but I've not created the v3 endpoint in keystone.... | 18:27 |
| EmilienM | you should not have to | 18:30 |
| *** andreww is now known as xarses | 18:32 | |
| *** vinsh has joined #puppet-openstack | 18:36 | |
| richm | guimaluf: you don't have to create the v3 endpoint - if you are using Juno or later, it should be there - and Icehouse too I believe | 18:39 |
| richm | so try the command I pasted above | 18:40 |
| richm | guimaluf: then, if that works, try https instead of http | 18:40 |
| guimaluf | richm, i'm using kilo | 18:41 |
| guimaluf | richm, can I check which OS_* vars it's been use? | 18:42 |
| richm | guimaluf: not sure what you mean by check which OS_* vars it's been use | 18:42 |
| guimaluf | richm, username, tenant, etc. | 18:43 |
| guimaluf | richm, where puppet get this from? keystone.conf? | 18:43 |
| richm | guimaluf: puppet runs the command exactly as I have pasted it above | 18:44 |
| richm | guimaluf: it uses your admin_token from /etc/keystone/keystone.conf and constructs the url | 18:45 |
| richm | guimaluf: which is why I'm asking what that command outputs for you | 18:45 |
| *** ducttape_ has quit IRC | 18:47 | |
| guimaluf | richm, sorry I miss it | 18:48 |
| richm | # OS_IDENTITY_API_VERSION=3 OS_TOKEN="your admin token" OS_URL=http://localhost:35357/v3 openstack project list --long | 18:48 |
| richm | guimaluf: ^^^ | 18:48 |
| guimaluf | richm, it uses http right? | 18:49 |
| richm | guimaluf: you specified to use https in your manifest - so try both "http:" and "https:" | 18:49 |
| guimaluf | rich it hangs on https! | 18:52 |
| guimaluf | INFO: urllib3.connectionpool Starting new HTTPS connection (1): localhost | 18:52 |
| guimaluf | maybe certificate does not include localhost? | 18:52 |
| guimaluf | richm, if I use the url included in certificate it works | 18:54 |
| guimaluf | richm, :) exactly that! | 18:54 |
| EmilienM | disable SSL :) | 18:55 |
| guimaluf | using http it doesn't work | 18:56 |
| *** markvoelker has quit IRC | 18:58 | |
| *** ducttape_ has joined #puppet-openstack | 19:02 | |
| guimaluf | richm, EmilienM using http I got this NFO: urllib3.connectionpool Starting new HTTP connection (1): localhost | 19:03 |
| guimaluf | DEBUG: urllib3.connectionpool Setting read timeout to None | 19:03 |
| *** dgurtner has quit IRC | 19:05 | |
| guimaluf | EmilienM, why use localhost when using ssl? it shouldn't use the AUTH_URL instead? | 19:07 |
| *** mgarza_ has quit IRC | 19:11 | |
| *** mgarza has joined #puppet-openstack | 19:11 | |
| *** dgurtner has joined #puppet-openstack | 19:13 | |
| *** dgurtner has quit IRC | 19:13 | |
| *** dgurtner has joined #puppet-openstack | 19:13 | |
| guimaluf | richm, there is any way to override this OS_URL var? any var in manifest that I could change it? | 19:13 |
| *** stamak has joined #puppet-openstack | 19:15 | |
| *** ashestakov has joined #puppet-openstack | 19:20 | |
| ashestakov | hello | 19:20 |
| ashestakov | review pls https://review.openstack.org/#/c/202215/ | 19:21 |
| *** rcallawa has quit IRC | 19:23 | |
| EmilienM | ashestakov: done | 19:26 |
| *** dgurtner has quit IRC | 19:26 | |
| ashestakov | @EmilienM: should i add baremetal_scheduler_default_filters also? | 19:27 |
| *** rcallawa has joined #puppet-openstack | 19:27 | |
| EmilienM | ashestakov: how would you like to configure it otherwise? | 19:27 |
| EmilienM | ashestakov: are you using the default one? | 19:27 |
| ashestakov | it has default value in nova, and it is ok for my case | 19:28 |
| ashestakov | but i can add it same | 19:28 |
| *** rcallawa has quit IRC | 19:29 | |
| *** rcallawa has joined #puppet-openstack | 19:30 | |
| EmilienM | ashestakov: I think it makes sense though I don't know if it's useful to change it, is there any other filter? | 19:30 |
| EmilienM | for baremetal I mean | 19:30 |
| ashestakov | i don't know about non default filters | 19:31 |
| *** stamak has quit IRC | 19:42 | |
| *** markvoelker has joined #puppet-openstack | 19:43 | |
| richm | guimaluf: puppet-keystone contructs the URL to use from either 1) the DEFAULT admin_endpoint in keystone.conf or 2) http(s)://admin_bind_host:admin_port/v3 | 19:44 |
| richm | guimaluf: it uses http if [ssl] and [ssl] enable and [ssl] enable = True in keystone.conf | 19:44 |
| *** markvoelker has quit IRC | 19:45 | |
| richm | if there is no admin_bind_host in keystone.conf, it will use your ip address, which will cause https to fail | 19:46 |
| guimaluf | richm, I've tested with http and https, boths hang.... I think my problem is 'localhost' | 19:46 |
| *** markvoelker has joined #puppet-openstack | 19:46 | |
| richm | guimaluf: if keystone is listening to https, then http will hang | 19:46 |
| richm | or fail in some odd way | 19:46 |
| richm | guimaluf: so does it work if you use https://full.hostname.from.cert/v3 ? | 19:47 |
| guimaluf | richm, it works! | 19:47 |
| guimaluf | richm, it's the only way that works | 19:47 |
| guimaluf | richm, localhost, IP address... nothing of this works | 19:48 |
| guimaluf | richm, only full.hostname.from.cert | 19:48 |
| richm | guimaluf: yes, that is as designed | 19:48 |
| richm | guimaluf: that is the mitm attack prevention | 19:48 |
| richm | guimaluf: Did your manifest work before upgrading to use puppet-keystone 6.0.0? That is, is this a regression? | 19:49 |
| guimaluf | richm, I'd installed keystone by hand, just now I'm trying to install via puppet-keystone | 19:50 |
| richm | guimaluf: ok - so this is the first time you have tried it | 19:50 |
| *** mgarza has quit IRC | 19:50 | |
| guimaluf | richm, exactly :) | 19:50 |
| richm | guimaluf: so we need to figure out how you can specify the parameters to make https work | 19:50 |
| *** mgarza has joined #puppet-openstack | 19:50 | |
| guimaluf | so I'm trying to adjust the puppet installation with the configs I've already have | 19:50 |
| guimaluf | richm, thats the point | 19:51 |
| guimaluf | i'm looking to puppet-keystone source code | 19:51 |
| guimaluf | to figure out | 19:51 |
| richm | guimaluf: looks like you should specify admin_endpoint to class ::keystone | 19:51 |
| richm | specify it as 'https://full.hostname.from.cert:35357/' | 19:52 |
| guimaluf | richm, without /v3 right? | 19:53 |
| richm | guimaluf: right | 19:55 |
| openstackgerrit | Adam Vinsh proposed openstack/puppet-swift: Add support for dedicated replication network. https://review.openstack.org/177037 | 19:57 |
| *** mgarza has quit IRC | 20:01 | |
| *** mgarza has joined #puppet-openstack | 20:02 | |
| guimaluf | richm, aeeeeeeee!!! :D working! | 20:04 |
| richm | guimaluf: excellent | 20:05 |
| guimaluf | richm, thank you very very much :) | 20:08 |
| * EmilienM waves on richm | 20:08 | |
| *** mgarza has quit IRC | 20:10 | |
| *** mgarza has joined #puppet-openstack | 20:10 | |
| EmilienM | mgagne: can we have an URL that track our bugs in Puppet modules? | 20:12 |
| mgagne | EmilienM: with project group yes :D | 20:12 |
| mgagne | otherwise I guess we will have to find an other way | 20:12 |
| EmilienM | mgagne: so today, we can't, right? | 20:14 |
| mgagne | yea, I don't know how | 20:14 |
| mgagne | I'm sure there are plenty of tools written by openstack people somewhere to deal with it | 20:15 |
| *** stamak has joined #puppet-openstack | 20:15 | |
| *** cwolferh has quit IRC | 20:30 | |
| *** dgurtner has joined #puppet-openstack | 20:34 | |
| *** dgurtner has quit IRC | 20:34 | |
| *** dgurtner has joined #puppet-openstack | 20:34 | |
| *** jasondotstar has quit IRC | 20:37 | |
| mdorman | clayton: there? | 20:39 |
| clayton | ? | 20:39 |
| mdorman | saw your comments on some of the db sync reviews, where it was set to notify the class instead of the exec | 20:39 |
| mdorman | i was curious, what’s the behavior when something notifies a class? does anything actually happen? when i saw that code in the review i kinda just assumed that by notifying a class, it would send notifications to all resources in the class | 20:40 |
| mdorman | but that is probably not what happens? | 20:40 |
| clayton | it notifies everything in the class | 20:40 |
| _ody | yep | 20:40 |
| mdorman | ah,ok | 20:40 |
| clayton | most of my comments were that he had changed the semantics | 20:40 |
| clayton | in most cases packages were notifying the db sync exec and he changed them to just be done before | 20:41 |
| mdorman | oh oh ok | 20:41 |
| clayton | which means db syncs won't run on upgrades, which is a pretty huge issue imo | 20:41 |
| mdorman | hyphens and tildes look almost exactly the same in gerrit to me, so i didn’t notice that | 20:41 |
| clayton | he changed ~> to -> which is *really* hard to see in the font gerrit uses. | 20:41 |
| mdorman | yup. | 20:41 |
| mdorman | ok cool. well i was just curious about the notify class thing. thanks | 20:42 |
| mdorman | another wrinkle in the brain | 20:42 |
| clayton | I checked them all because I've seen it get accidently reverted before | 20:42 |
| ashestakov | review pls https://review.openstack.org/#/c/202215/ | 20:42 |
| *** jasondotstar has joined #puppet-openstack | 20:46 | |
| *** dboik has quit IRC | 20:47 | |
| *** morazi has quit IRC | 20:48 | |
| *** mgarza has quit IRC | 20:48 | |
| *** mgarza has joined #puppet-openstack | 20:49 | |
| EmilienM | ashestakov: why false? | 20:50 |
| EmilienM | ashestakov: it's not the default in OpenStack AFI | 20:50 |
| EmilienM | AFIK | 20:50 |
| *** tdb has quit IRC | 20:50 | |
| *** dgurtner has quit IRC | 20:53 | |
| *** dboik has joined #puppet-openstack | 20:53 | |
| ashestakov | it used only by ironic_host_manager | 20:54 |
| ashestakov | https://github.com/openstack/nova/blob/master/nova/scheduler/ironic_host_manager.py#L34 | 20:54 |
| EmilienM | ashestakov: yeah so I suggest you let the default like it's in OpenStack if the scheduler is enabled | 20:55 |
| ashestakov | you mean if scheduler_use_baremetal_filter=true then baremetal_scheduler_default_filters=[array] ? | 20:56 |
| EmilienM | ashestakov: I think yeah | 20:56 |
| mwhahaha | or would undef be better as to not set it but provide the option to set it | 20:57 |
| mwhahaha | to allow for the shipped defaults? | 20:57 |
| EmilienM | that's a good option too | 20:57 |
| mwhahaha | i think for optional stuff it might be best to use undef as to not force something that might change in code later | 20:58 |
| openstackgerrit | Cody Herriges proposed openstack/puppet-nova: Enable nova service by default https://review.openstack.org/184656 | 20:58 |
| EmilienM | mwhahaha: wfm | 20:58 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-keystone: acceptance: validate Keystone with Tempest https://review.openstack.org/198561 | 21:00 |
| *** mgarza has quit IRC | 21:01 | |
| *** mgarza has joined #puppet-openstack | 21:02 | |
| *** rcallawa_ has joined #puppet-openstack | 21:04 | |
| openstackgerrit | Andrey Shestakov proposed openstack/puppet-nova: Add ability to set default baremetal filters https://review.openstack.org/202215 | 21:06 |
| ashestakov | mwhahaha: you mean undef for list of filters? | 21:07 |
| mwhahaha | both | 21:07 |
| *** rcallawa has quit IRC | 21:07 | |
| *** dprince has quit IRC | 21:07 | |
| *** rcallawa_ has quit IRC | 21:08 | |
| *** tdb has joined #puppet-openstack | 21:09 | |
| *** jasondotstar has quit IRC | 21:09 | |
| ashestakov | but scheduler_use_baremetal_filters is boolean | 21:10 |
| mwhahaha | i think that one would be ok | 21:10 |
| mwhahaha | but the filters should be undef | 21:10 |
| EmilienM | the idea is, when you enable it (boolean to true), you got the default filter | 21:10 |
| mwhahaha | what's the default behaviour for nova_config with a value of undef? | 21:11 |
| clayton | it won't add or remove the value | 21:11 |
| mwhahaha | which is why i said undef, so it by default would do nothing and only if someone wants true/false would it do something | 21:11 |
| *** mgarza has quit IRC | 21:13 | |
| *** mgarza_ has joined #puppet-openstack | 21:13 | |
| ashestakov | so scheduler_use_baremetal_filters=false and baremetal_scheduler_default_filters=undef ? | 21:15 |
| mwhahaha | I think that would be ok | 21:15 |
| ashestakov | @EmilienM: are you agree? | 21:17 |
| EmilienM | ashestakov: yeah | 21:17 |
| ashestakov | nova_config { 'DEFAULT/baremetal_scheduler_default_filters': value => join($baremetal_scheduler_default_filters,',') | 21:19 |
| ashestakov | should it work if undef? | 21:20 |
| mwhahaha | good question | 21:22 |
| ashestakov | just tried, no | 21:23 |
| mwhahaha | i'd wrap that in an if $baremetal_scheduler_default_filters then | 21:23 |
| mwhahaha | rather than if $scheduler_use_baremetal_filters | 21:24 |
| mwhahaha | similar to the isolated_images block on lines 112-120 | 21:24 |
| openstackgerrit | Andrey Shestakov proposed openstack/puppet-nova: Add ability to set default baremetal filters https://review.openstack.org/202215 | 21:25 |
| ashestakov | check pls | 21:26 |
| *** dboik_ has joined #puppet-openstack | 21:26 | |
| *** cwolferh has joined #puppet-openstack | 21:26 | |
| mwhahaha | looks ok to me, will need to see CI pass | 21:28 |
| *** dboik has quit IRC | 21:30 | |
| EmilienM | crinkle: I'm playing with zuul-clooner, and I'm looking for a way to find for a commit, it's latest stable branch (about upgrade job) | 21:30 |
| EmilienM | like: zuul cloner to checkout the latest stable branch instead of master | 21:31 |
| *** dboik_ has quit IRC | 21:31 | |
| EmilienM | maybe a macro to export ZUUL_BRANCH with the latest stable branch of the commit I'm doing | 21:32 |
| * EmilienM asking on infra channel | 21:34 | |
| *** stamak has quit IRC | 21:34 | |
| *** mgarza_ has quit IRC | 21:43 | |
| *** mgarza has joined #puppet-openstack | 21:44 | |
| *** aimon has quit IRC | 21:50 | |
| *** gfidente has quit IRC | 21:59 | |
| *** ashestakov has quit IRC | 22:04 | |
| *** mgarza has quit IRC | 22:11 | |
| *** mgarza has joined #puppet-openstack | 22:12 | |
| *** jayg is now known as jayg|g0n3 | 22:18 | |
| *** aimon has joined #puppet-openstack | 22:21 | |
| *** EmilienM is now known as EmilienM|off | 22:22 | |
| *** topshare has joined #puppet-openstack | 22:25 | |
| *** EmilienM|off is now known as EmilienM | 22:37 | |
| pabelanger | EmilienM, crinkle added comments to review. | 22:38 |
| EmilienM | crinkle: how do you want to gate the repo? | 22:39 |
| EmilienM | ie: how to test if manifest will actually work? | 22:40 |
| EmilienM | I agree this is not a module, but still we are doing to write manifests, IMHO we need testing | 22:41 |
| crinkle | but this is the thing doing the testing | 22:41 |
| pabelanger | We'd create a new gate job that would run this code on a node | 22:42 |
| crinkle | i don't see how adding unit tests and beaker tests on top of what we already have t othe individual modules could be helpful | 22:42 |
| crinkle | pabelanger: right | 22:42 |
| pabelanger | the validate is ran properly, either check puppet results from CLI and / or tempest jobs results | 22:42 |
| EmilienM | crinkle: ok for not having unit | 22:42 |
| EmilienM | crinkle: but we can have beaker jobs that run the manifests | 22:42 |
| EmilienM | and see if it works | 22:42 |
| EmilienM | because if you break the integration manifest, it will break all modules CI | 22:43 |
| pabelanger | but, if we run puppet apply on the actually scenario001.pp on the remote nodes, do we need beaker at all? | 22:43 |
| EmilienM | before running scenario001.pp you need to push the file into the repo and for that we need to gate that | 22:44 |
| pabelanger | right | 22:44 |
| crinkle | can we just start with the puppet-check-jobs and as this evolves we can figure out what to do next? | 22:44 |
| pabelanger | zuul can do that | 22:44 |
| pabelanger | crinkle, ya, that's what I was hoping for too | 22:44 |
| EmilienM | crinkle: I suggested to have beaker jobs from DAY1 so we can test what we want to actually deploy later | 22:44 |
| crinkle | pabelanger: ++ sorry i'm picking this up a little late | 22:44 |
| pabelanger | I think we each have ways of seeing the actual gate for this working, but think we need hammer it out in spec / etherpad | 22:45 |
| EmilienM | crinkle: how do you test scenarios001.pp is not breaking puppet-keystone deployment? | 22:45 |
| EmilienM | if you do a mistake in this file and it's merged, all modules CI will be broken | 22:45 |
| EmilienM | that's the reason I wanted to start with beaker jobs to gate the repo itself | 22:46 |
| crinkle | EmilienM: so you propose to run all the tests for all the modules on every patch to puppet-openstack-integration? because that is the only way to be sure that it won't break anything | 22:46 |
| pabelanger | puppet-keystone will have a new gate called gate-openstack-integration-full-tempest-run right? | 22:46 |
| pabelanger | or something like that | 22:46 |
| EmilienM | pabelanger: yes something like this | 22:46 |
| EmilienM | crinkle: I propose for now, we have one single job: gate-openstack-integration-full for example | 22:47 |
| pabelanger | so that gate job, to me won't be using beaker.... but being deployed onto a bare node then simply calling puppet apply .pp | 22:47 |
| EmilienM | and this job is run on all modules, included puppet-openstack-integration | 22:47 |
| EmilienM | so puppet-openstack-integration can be tested itself | 22:47 |
| pabelanger | right | 22:47 |
| pabelanger | but I don't think beaker needed, since we have the infra CI tools to do it | 22:48 |
| EmilienM | but how do you want to test it without beaker? | 22:48 |
| EmilienM | openstack project have the same issue with tempest | 22:48 |
| crinkle | i think whether we use beaker to do it or not is a later discussion | 22:48 |
| EmilienM | they run a job and tempest needs to gate also this job | 22:48 |
| pabelanger | for each new .pp file we add, we'd get a new jenkins node going to run the test | 22:48 |
| EmilienM | crinkle: fine with me, I just wanted to start something that we can actually test | 22:49 |
| EmilienM | and not some random manifests that we don't really test in our gate | 22:49 |
| crinkle | EmilienM: we don't even have any tests yet | 22:49 |
| EmilienM | crinkle: I'm used to work in TDD and to me this kind of repo needs to include manifest + test in one commit | 22:49 |
| pabelanger | so, we are good for just puppet-check-jobs to start | 22:50 |
| crinkle | pabelanger: i think emilien is arguing against that | 22:50 |
| EmilienM | and how do you test the manifest? | 22:50 |
| crinkle | i am +1 just puppet-check-jobs to start | 22:50 |
| EmilienM | pabelanger: ? | 22:50 |
| *** saneax has joined #puppet-openstack | 22:50 | |
| pabelanger | we need to agree on how we are actually going to test | 22:50 |
| crinkle | i like the idea of one integration job that runs on all the modules and the integration repo itself, i don't care whether it uses beaker, but until we know what the test is going to look like we shouldn't add more jobs | 22:51 |
| pabelanger | we don't have to merge the code right now | 22:51 |
| EmilienM | so we push manifests and we wait to patch puppet-keystone later that'll run the job and hopefully works | 22:51 |
| pabelanger | we can -1 workflow until CI part is done | 22:51 |
| EmilienM | crinkle: I don't want more jobs now | 22:51 |
| EmilienM | crinkle: just *one* for one repo | 22:51 |
| EmilienM | I don't want to run the integration job for all modules now | 22:51 |
| crinkle | EmilienM: so the puppet-check-job is okay? | 22:51 |
| EmilienM | sure | 22:51 |
| crinkle | okay | 22:51 |
| EmilienM | but I also want beaker for the repo itself | 22:51 |
| crinkle | let's do that later | 22:52 |
| pabelanger | how does beaker scale with more then 1 host? | 22:52 |
| crinkle | pabelanger: beaker can do multihost | 22:52 |
| EmilienM | pabelanger: it's really early to talk about multi node | 22:52 |
| EmilienM | we already talked about that yesterday | 22:52 |
| pabelanger | right | 22:52 |
| EmilienM | but to me, having tests for the manifest itself is not too early | 22:52 |
| pabelanger | but for each .pp scenario we need a fresh node to test on right? | 22:52 |
| EmilienM | it's part of TDD | 22:52 |
| pabelanger | trying to understand on beaker does that | 22:52 |
| EmilienM | yes | 22:53 |
| pabelanger | with zuul / nodepool I know how to do it | 22:53 |
| EmilienM | let's focus on one scenario, one .pp now | 22:53 |
| pabelanger | just create a new job in jenkins | 22:53 |
| pabelanger | ok | 22:53 |
| pabelanger | redoing code | 22:53 |
| crinkle | EmilienM: if we add a beaker job now that means we're committing ourselves to making the next commit add spec/spec_helper_acceptance.rb and a gemfile and rakefile and a test, so let's do that later | 22:53 |
| EmilienM | pabelanger: that's the point, crinkle does not want beaker job now for the repo itself | 22:53 |
| EmilienM | crinkle: I was thinking at 1/ push a patch for basic structure and make the job pass 2/ with gerrit dependency, push another patch on top of 1/ with a first manifest and the test | 22:54 |
| EmilienM | and thanks to that ^ we can test what we actually want to deploy | 22:54 |
| pabelanger | ya, need to learn more about beaker | 22:55 |
| crinkle | EmilienM: my only point is that we don't have our plan ironed out yet, there seems to be disagreement over whether to even use beaker or not, so just for the moment let's hold off on adding that job until we have a spec ironed out | 22:55 |
| EmilienM | ok | 22:56 |
| EmilienM | unfortunately I have to go now for some personal reasons | 22:56 |
| EmilienM | I'll catch-up next week. I'm happy if you can make progress on this work, feel free to do how you think it's the best. thanks crinkle and pabelanger | 22:56 |
| EmilienM | o/ | 22:57 |
| *** dfisher has quit IRC | 23:03 | |
| *** EmilienM is now known as EmilienM|off | 23:03 | |
| *** mgarza has quit IRC | 23:04 | |
| *** topshare has quit IRC | 23:06 | |
| *** jasondotstar has joined #puppet-openstack | 23:07 | |
| *** topshare has joined #puppet-openstack | 23:09 | |
| *** jasondotstar has quit IRC | 23:10 | |
| *** xavpaice has left #puppet-openstack | 23:11 | |
| *** topshare has quit IRC | 23:14 | |
| *** topshare has joined #puppet-openstack | 23:17 | |
| *** rbrooker has quit IRC | 23:27 | |
| *** ducttape_ has quit IRC | 23:30 | |
| *** xarses has quit IRC | 23:31 | |
| *** gildub has joined #puppet-openstack | 23:34 | |
| *** topshare has quit IRC | 23:43 | |
| *** topshare has joined #puppet-openstack | 23:44 | |
| *** mdorman has quit IRC | 23:45 | |
| *** topshare_ has joined #puppet-openstack | 23:46 | |
| *** xingchao has quit IRC | 23:48 | |
| *** topshare has quit IRC | 23:49 | |
| *** xingchao has joined #puppet-openstack | 23:49 | |
| *** topshare_ has quit IRC | 23:51 | |
| *** xarses has joined #puppet-openstack | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!