Wednesday, 2015-09-30

« Tuesday, 2015-09-29 Index Thursday, 2015-10-01 »
*** openstackgerrit has quit IRC00:01
*** xingchao has joined #puppet-openstack00:02
*** openstackgerrit has joined #puppet-openstack00:02
*** morazi has quit IRC00:02
*** openstack has joined #puppet-openstack00:04
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Deletes tenant parameter from keystone_user  https://review.openstack.org/22874400:07
*** Guest62975 has joined #puppet-openstack00:10
*** Guest62975 has quit IRC00:15
*** xingchao has joined #puppet-openstack00:22
*** TC01 has joined #puppet-openstack00:47
*** TC01 has quit IRC01:17
mfisch_ody: clayton and I are there01:25
*** Guest35835 has joined #puppet-openstack01:25
*** Guest35835 has quit IRC01:30
*** cdelatte has quit IRC01:31
openstackgerritMatt Fischer proposed openstack/puppet-nova: redefine the virsh secret if needed  https://review.openstack.org/22916701:32
openstackgerritMatt Fischer proposed openstack/puppet-heat: Make the role for heat_stack_user configurable  https://review.openstack.org/22553301:44
richmgildub: hello01:50
*** angdraug has quit IRC01:51
*** jfluhmann has joined #puppet-openstack02:07
gildubrichm, never mind, just saw your comment about doing indirection fix before, for kilo02:17
richmgildub: yeah, I forgot about that :P02:18
gildubrichm, no worries, although that would have been *way* less painful ;)02:18
richmyeah02:20
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/22662402:28
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/22662402:37
*** richm has quit IRC02:48
gildubrichm, chem, I looked at 226919, this is nice.02:49
gildubmichchap, hi - You're doing such a good review job I can't stop coming back to you :)03:27
gildubmichchap, could you please review those: https://review.openstack.org/226624 and  https://review.openstack.org/228744 ?03:28
michchapgildub: sure :)03:28
gildubmichchap, Thanks! The reason 226624 was done before 228744 is because it might be back ported to kilo, the puppet indirection is *bad* (efficiency and not apparently not supported)03:29
gildubmichchap, I'm saying that because the second patch removes most of code fixed in the first one. It sounds weird :(03:30
michchapgildub: that makes sense, thanks.03:30
gildubmichchap, cool :)03:31
*** v1k0d3n has quit IRC03:37
*** v1k0d3n has joined #puppet-openstack03:38
*** gfidente has quit IRC03:39
*** rahulait has joined #puppet-openstack03:59
*** v1k0d3n has quit IRC04:06
*** gildub has quit IRC04:08
*** jfluhmann has quit IRC04:16
*** sanjayu has joined #puppet-openstack04:18
*** sanjayu has quit IRC04:25
*** gildub has joined #puppet-openstack04:27
*** sanjayu has joined #puppet-openstack04:40
*** sanjayu has quit IRC04:52
*** iurygregory has quit IRC05:10
*** LimorStotland has joined #puppet-openstack05:20
*** sanjayu has joined #puppet-openstack05:24
*** vinsh has quit IRC05:26
*** rahulait has quit IRC05:36
*** LimorStotland has quit IRC05:51
*** itsuugo has joined #puppet-openstack06:04
*** leanderthal has joined #puppet-openstack06:05
*** vinsh has joined #puppet-openstack06:08
*** LimorStotland has joined #puppet-openstack06:09
*** xarses has quit IRC06:20
*** xarses has joined #puppet-openstack06:20
*** xarses has quit IRC06:21
*** xarses has joined #puppet-openstack06:22
*** xarses has quit IRC06:22
*** xarses has joined #puppet-openstack06:23
*** xarses has quit IRC06:23
*** xarses has joined #puppet-openstack06:24
*** itsuugo has quit IRC06:28
*** sanjayu has quit IRC06:31
*** sergmelikyan has joined #puppet-openstack06:32
*** sanjayu has joined #puppet-openstack06:38
openstackgerritGilles Dubreuil proposed openstack/puppet-keystone: Add semantic title for keystone_tenant.  https://review.openstack.org/22691906:39
zigoHi guys !07:03
zigoI have Liberty rc1 fully packaged and fully working, my CI passes tempest tests, minus some setup issues.07:04
zigoI wonder how I can help to test Debian more using upstream puppet stuff.07:04
zigoI just read that, once more, there's some work needed to be done on upstream puppet things, so that it can support both Debian & Ubuntu.07:04
zigoEmilienM: Hello ! ^07:05
*** arnaud_orange has joined #puppet-openstack07:08
*** rahulait has joined #puppet-openstack07:09
*** khushbu_ has joined #puppet-openstack07:14
*** sergmelikyan has quit IRC07:19
*** chem has quit IRC07:28
*** sergmelikyan has joined #puppet-openstack07:33
*** dgurtner has joined #puppet-openstack07:33
*** dgurtner has joined #puppet-openstack07:33
*** itsuugo has joined #puppet-openstack07:34
*** khushbu_ has quit IRC07:35
*** jpena has joined #puppet-openstack07:36
*** gildub has quit IRC07:48
*** sergmelikyan has quit IRC07:51
*** xarses has quit IRC07:52
*** xarses has joined #puppet-openstack07:53
openstackgerritDavid Gurtner proposed stackforge/puppet-ceph: Be more specific with CentOS7 package exclude  https://review.openstack.org/21409307:53
*** xarses has quit IRC07:55
*** xarses_ has joined #puppet-openstack07:55
*** sergmelikyan has joined #puppet-openstack07:57
*** gfidente has joined #puppet-openstack07:59
*** jistr has joined #puppet-openstack08:02
*** itsuugo has quit IRC08:08
openstackgerritJavier Peña proposed openstack/puppet-swift: Add support for swift-object-expirer service  https://review.openstack.org/21154908:09
*** khushbu_ has joined #puppet-openstack08:15
*** derekh has joined #puppet-openstack08:16
*** rahulait has quit IRC08:18
*** markvoelker has quit IRC08:20
*** rochaporto has joined #puppet-openstack08:21
*** linkedinyou has quit IRC08:21
*** linkedinyou has joined #puppet-openstack08:28
*** sanjayu has quit IRC08:38
*** paramite has joined #puppet-openstack08:43
*** sanjayu has joined #puppet-openstack08:53
*** asabbas has joined #puppet-openstack09:01
*** khushbu_ has quit IRC09:01
*** khushbu has joined #puppet-openstack09:02
openstackgerritMaksym Yatsenko proposed openstack/puppet-nova: [WIP]  https://review.openstack.org/22930809:03
*** arnaud_orange has quit IRC09:08
*** markvoelker has joined #puppet-openstack09:21
*** markvoelker has quit IRC09:26
*** paramite is now known as paramite|afk09:28
*** khushbu has quit IRC09:44
*** khushbu has joined #puppet-openstack09:47
*** sergmelikyan has quit IRC09:51
*** itsuugo has joined #puppet-openstack09:56
*** khushbu has quit IRC10:03
*** paramite|afk is now known as paramite10:07
*** asabbas is now known as aslam10:09
*** khushbu has joined #puppet-openstack10:11
*** khushbu has quit IRC10:18
*** LimorStotland has quit IRC10:18
*** jasondotstar_afk is now known as jasondotstar10:19
*** sergmelikyan has joined #puppet-openstack10:23
*** LimorStotland has joined #puppet-openstack10:36
*** mjblack has quit IRC11:12
*** sergmelikyan has quit IRC11:19
*** itsuugo has quit IRC11:21
*** markvoelker has joined #puppet-openstack11:22
*** mjblack has joined #puppet-openstack11:25
*** markvoelker has quit IRC11:27
*** khushbu_ has joined #puppet-openstack11:30
*** sergmelikyan has joined #puppet-openstack11:31
*** paramite is now known as paramite|afk11:32
*** aarefiev has quit IRC11:35
*** paramite|afk is now known as paramite11:36
*** aarefiev has joined #puppet-openstack11:38
*** cdelatte has joined #puppet-openstack11:39
*** LimorStotland has quit IRC11:48
*** iurygregory has joined #puppet-openstack11:53
*** chem has joined #puppet-openstack11:53
iurygregorygood morning :D11:55
*** jpena is now known as jpena|lunch11:55
*** morazi has joined #puppet-openstack11:57
*** arnaud_orange has joined #puppet-openstack12:01
*** markvoelker has joined #puppet-openstack12:03
*** jtomasek has joined #puppet-openstack12:04
*** dprince has joined #puppet-openstack12:08
iurygregoryanyone can take a look in: https://review.openstack.org/#/c/223777/ https://review.openstack.org/#/c/208054/ =)12:12
*** ducttape_ has joined #puppet-openstack12:13
*** jayg|g0n3 is now known as jayg12:15
*** LimorStotland has joined #puppet-openstack12:16
EmilienMgood morning12:17
iurygregoryo/12:19
*** ducttape_ has quit IRC12:40
openstackgerritAdam Vinsh proposed openstack/puppet-swift: Manage swift with swiftinit service provider  https://review.openstack.org/20322012:40
*** jtomasek has quit IRC12:41
*** jtomasek has joined #puppet-openstack12:41
*** itsuugo has joined #puppet-openstack12:46
*** arnaud_orange has quit IRC12:48
*** xingchao has quit IRC12:48
*** vinsh_ has joined #puppet-openstack12:48
*** v1k0d3n has joined #puppet-openstack12:51
*** richm has joined #puppet-openstack12:51
*** vinsh has quit IRC12:52
*** sanjayu has quit IRC12:52
*** IBerezovskiy has joined #puppet-openstack13:05
*** jpena|lunch is now known as jpena13:08
*** xingchao has joined #puppet-openstack13:19
*** vinsh has joined #puppet-openstack13:21
*** vinsh_ has quit IRC13:21
*** itsuugo has quit IRC13:28
*** khushbu_ has quit IRC13:35
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: Cleanup some legacy code  https://review.openstack.org/22907113:35
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: run_tests: drop dupplicated code  https://review.openstack.org/22942613:35
openstackgerritMerged openstack/puppet-openstack-integration: scenario001: enable object service  https://review.openstack.org/22845013:37
*** v1k0d3n has quit IRC13:44
*** v1k0d3n has joined #puppet-openstack13:44
*** nihilifer has quit IRC13:47
*** nihilifer has joined #puppet-openstack13:47
*** nihilifer has quit IRC13:47
*** nihilifer has joined #puppet-openstack13:47
*** ducttape_ has joined #puppet-openstack13:51
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-cookiecutter: Updates on config provider  https://review.openstack.org/22943913:53
*** sergmelikyan has quit IRC13:54
*** v1k0d3n has quit IRC13:54
*** v1k0d3n has joined #puppet-openstack13:54
openstackgerritEmilien Macchi proposed openstack/puppet-aodh: puppet-aodh: Initial commit  https://review.openstack.org/22501513:56
*** arnaud_orange has joined #puppet-openstack13:56
openstackgerritEmilien Macchi proposed openstack/puppet-tempest: Allow to enable Trove tests  https://review.openstack.org/22944514:03
*** sergmelikyan has joined #puppet-openstack14:04
dmsimardEmilienM: is aodh available in liberty ?14:06
dmsimardI haven't been following it too much - just saw your comment about it not being packaged yet14:06
*** dfisher has joined #puppet-openstack14:07
*** itsuugo has joined #puppet-openstack14:08
EmilienMdmsimard: yeah, it's in progress by pradk14:08
dmsimardEmilienM: ok14:09
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy & test Trove  https://review.openstack.org/22945014:09
*** ferest has joined #puppet-openstack14:20
*** ducttape_ has quit IRC14:22
*** ducttape_ has joined #puppet-openstack14:23
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Add semantic title for keystone_tenant.  https://review.openstack.org/22691914:24
*** ferest has quit IRC14:26
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Add semantic title for keystone_tenant.  https://review.openstack.org/22691914:37
*** LimorStotland has quit IRC14:40
*** bklei has joined #puppet-openstack14:57
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy & test Trove  https://review.openstack.org/22945014:57
*** aslam has quit IRC15:03
*** jistr has quit IRC15:07
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: scenario001: use 2 workers for sahara-api  https://review.openstack.org/22947015:08
*** paramite has quit IRC15:10
openstackgerritJay_Clark proposed openstack/puppet-nova: Fix for Bug #1484402  https://review.openstack.org/22947215:12
openstackbug 1484402 in puppet-nova "no interface for modify the port of nova-api " [Low,Confirmed] https://launchpad.net/bugs/148440215:12
*** mdorman has joined #puppet-openstack15:15
*** itsuugo has quit IRC15:17
openstackgerritJay_Clark proposed openstack/puppet-nova: Removing merge kruft.  https://review.openstack.org/22947515:18
*** rochaporto has quit IRC15:20
*** arnaud_orange has quit IRC15:26
*** jtomasek has quit IRC15:27
*** leanderthal has quit IRC15:43
EmilienMcrinkle: https://review.openstack.org/#/c/229071/ is tested against all modules (see https://goo.gl/7AjoiR ) - I think we can safely merge it15:55
EmilienMcrinkle: which means we don't have the legacy code as blocker anymore for the fixtures topic.15:55
dmsimardEmilienM: hmmm, doesn't look like that worked, still no /etc/ceph in http://logs.openstack.org/99/229099/2/check/gate-puppet-ceph-puppet-beaker-rspec-dsvm-centos7/5f41541/15:55
EmilienMdmsimard: the nodepool images are nightly built15:55
EmilienMcheck on http://nodepool.openstack.org/15:55
dmsimardoh, so tomorrow then15:56
EmilienMmaybe15:56
EmilienMif build works15:56
*** IBerezovskiy has quit IRC15:57
*** imcsk8_ is now known as imcsk8|afk16:00
bkerodmsimard: Ever figure out those swift issues? I didn't see anything new in the logs.16:01
*** bklei has quit IRC16:02
dmsimardbkero: no, the improved log fetch won't be in until tomorrow and I haven't looked tbh16:02
dmsimardthere might be a legit issue16:02
bkeroyeah16:03
bkeroI saw your recheck earlier, so I thought you might have encountered the issue on something else or it might have been transient.16:03
bkeroSomething like "[Wed Sep 30 14:59:50.371504 2015] [core:warn] [pid 22501] (13)Permission denied: AH00056: connect to listener on [::]:8080"16:06
EmilienMdmsimard: just fyi - we're about to re-enabling selinux (enforced mode)16:07
dmsimardEmilienM: ok16:07
dmsimardEmilienM: the new package is already in16:07
EmilienMI know and it works16:07
EmilienMif our team could review https://goo.gl/tljZvW and revisit https://review.openstack.org/226830 - thanks16:12
EmilienMnibalizer: I don't get your comment on https://review.openstack.org/226830 - have you read the thread about it?16:13
*** rahulait has joined #puppet-openstack16:20
*** mentat has joined #puppet-openstack16:21
EmilienMI dropped a comment16:22
*** xingchao has quit IRC16:31
*** dgurtner has quit IRC16:47
*** ilbot3 has quit IRC16:48
openstackgerritEmilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy & test Trove  https://review.openstack.org/22945016:51
*** ilbot3 has joined #puppet-openstack16:52
*** rahulait has quit IRC16:52
*** wabu_ has left #puppet-openstack16:53
*** derekh has quit IRC16:57
degorenkoEmilienM, hey, take a look please https://review.openstack.org/#/c/219275/17:00
*** LimorStotland has joined #puppet-openstack17:13
crinkleEmilienM: why are the puppet-openstack-integration tests failing? these don't look like packaging issues to me http://logs.openstack.org/26/229426/1/check/gate-puppet-openstack-integration-dsvm-trusty/53c4af5/console.html#_2015-09-30_16_16_46_035 http://logs.openstack.org/26/229426/1/check/gate-puppet-openstack-integration-dsvm-centos7/f41d774/console.html#_2015-09-30_14_06_27_34517:14
EmilienMcrinkle: the first link is a race condition I also discovered yesterday17:18
EmilienMI have no idea why ceilometer/eventlet is started before apache, since we disable it in puppet17:18
crinkleubuntu starts its services at boot17:19
EmilienMhttps://github.com/openstack/puppet-ceilometer/blob/master/manifests/api.pp#L134-L13817:19
crinkleer at installation17:19
*** LimorStotland has quit IRC17:19
EmilienMcrinkle: this it what I thought too, but I could not reproduce in my env17:19
EmilienMI tried to remove/install package and the service was not started.17:20
EmilienManyway, we can make sure the service is stopped in Puppet but this is already the case here: https://github.com/openstack/puppet-ceilometer/blob/master/manifests/api.pp#L134-L13817:20
EmilienMso I don't know how to deal with that issue yet.17:20
EmilienMcrinkle: the second link is happenning randomly.17:21
EmilienMour integration jobs are pretty unstable now, because of some tempest tests/scenarios that sometimes fail or work17:21
EmilienMit's probably bugs in OpenStack, I would investigate later17:21
crinklethese issues should have been discovered before that code was merged, now i can't trust the test results when reviewing patches for that repo17:21
EmilienMcrinkle: they used to pass CI17:23
openstackgerritAthlan-Guyot sofer proposed openstack/puppet-keystone: Add semantic title for keystone_tenant.  https://review.openstack.org/22691917:23
*** sergmelikyan has quit IRC17:24
EmilienMcrinkle: I might be wrong, but I think our job is installing too much services now17:25
EmilienMand it could lead to unstability17:25
EmilienMcrinkle: I tried this: https://review.openstack.org/#/c/228597/ and it failed because of dependency cycle issue17:28
EmilienMI should restore it17:28
openstackgerritEmilien Macchi proposed openstack/puppet-ceilometer: wsgi: make sure eventlet process is stopped before httpd  https://review.openstack.org/22859717:30
openstackgerritColleen Murphy proposed openstack/puppet-ceilometer: Ensure ceilometer is stopped before starting httpd  https://review.openstack.org/22953817:31
*** xingchao has joined #puppet-openstack17:32
EmilienMcrinkle: we have the same patch ^ lol17:32
crinkleoh i'll drop mine17:32
EmilienMcrinkle: so I tried this on my env, and it failed (I used before =>) will see with ->17:33
EmilienMGem::InstallError: fog-google requires Ruby version >= 2.0.17:36
EmilienMhttps://jenkins01.openstack.org/job/gate-puppet-ceilometer-puppet-beaker-rspec-dsvm-trusty/54/console17:36
EmilienMwe have a problem \o/17:37
EmilienM"Houston..."17:38
EmilienMour CI is broken17:38
EmilienMcrinkle: https://github.com/fog/fog-google/commit/a66b16fa7c2373f9c8be2e80bc942ad8d13ece3f17:38
crinkle>.<17:39
EmilienMwe need to pin the gem I guess17:39
EmilienMpatch all our modules17:39
EmilienMtrusty is running 1.917:40
EmilienMtrusty is running ruby 1.917:40
*** dgurtner has joined #puppet-openstack17:41
*** dgurtner has quit IRC17:41
*** dgurtner has joined #puppet-openstack17:41
EmilienMas a workaround until Trusty uses ruby 2.0, I suggest we pin fog-google17:42
crinkletrusty is never going to use 2.017:42
crinklei'm going to file a bug with beaker so they can deal with it17:43
EmilienMcrinkle: the only requirement is https://github.com/puppetlabs/beaker/blob/master/beaker.gemspec#L5417:45
EmilienMso I guess we can pin fog to ~> 1.25 but not using too recent fog-google17:45
EmilienMeven here, the constraint is too large: https://github.com/fog/fog/blob/v1.34.0/fog.gemspec#L6017:46
EmilienMI wonder if we can pin fog-google then17:47
nibalizerEmilienM: responded17:47
EmilienMnibalizer: we need unit tests dependencies because we have libraries17:48
EmilienMlike openstacklib17:48
EmilienMopenstack has the same 'issue' with Oslo, they also use Depends-On for unit testing17:48
EmilienMthanks to Global Requirements, we keep consistent dependencies17:49
EmilienMnibalizer: if you patch openstacklib with a new Provider that will be consummed in puppet-keystone, your patch in puppet-keystone will fail because unit test can't pass since the patch in openstacklib is not merged17:50
openstackgerritDenis Egorenko proposed openstack/puppet-nova: Rewrite nova_network provider with using only nova client  https://review.openstack.org/22954817:50
*** dprince has quit IRC17:50
EmilienMnibalizer: I agree with you that this pattern I propose is not used by Puppet community. Do you have another proposal then?17:51
*** jpena is now known as jpena|away17:53
nibalizerwell you can't merge it even with a depends-on17:53
nibalizeryou still have to wait until the patch adding a provider to openstacklib lands17:54
EmilienMnibalizer: it's not a merge issue.17:55
EmilienMnibalizer: it's about testing a feature or bugfix17:55
EmilienMthis feature is a "nice to have", we could probably live without it17:56
*** imcsk8|afk is now known as imcsk817:56
EmilienMit's just something our community is asking - cc mwhahaha and some others17:56
EmilienMand I agree it's a nice feature, very useful17:56
openstackgerritEmilien Macchi proposed openstack/puppet-ceilometer: Gemfile: pin fog-google to ~> 0.1.0  https://review.openstack.org/22955217:58
EmilienMcrinkle: in the meantime ^17:58
mwhahahayou can workflow a depends-on even if the item it depends on hasn't been merged yet. it just won't land until the other change. the issue is being able to do cross module CI testing for inflight changes17:58
EmilienMyes, like we like doing with our beaker jobs, and recently with integration jobs17:59
mwhahahasince there's so many interdependencies between openstack stuff17:59
EmilienMcrinkle: do you think the dependency can be changed in puppetlabs/beaker ?17:59
nibalizerEmilienM: do you have a link to how the openstack folk do it with oslo and depends-on?18:01
nibalizerEmilienM: i see the value in the feature18:02
nibalizeras in that ML thread, its a tradeoff between features and complexity18:02
EmilienMnibalizer: https://rbtcollins.wordpress.com/2015/04/28/dealing-with-deps-in-openstack/18:02
nibalizercomplexity hurts the project by making it harder to debug and harder for newcommers18:02
crinkleEmilienM: I filed https://tickets.puppetlabs.com/browse/BKR-564 and pinged anode18:02
EmilienMnibalizer: otherwise, let's create a rake task for OpenStack Infra18:03
EmilienMnibalizer: and change our jobs to run this task18:03
EmilienMnibalizer: so we keep the fixtures and everyone is happy18:03
nibalizerso that blog isn't about this18:05
nibalizerthats about python transitive dependencys and dependency solving18:06
nibalizeralso its about installing into a virtualenv and running i think devstack/tempest, not e.g. the nova unit tests18:06
EmilienMnibalizer: right, I pasted the wrong link18:07
EmilienMcrinkle: thanks for the bug18:07
*** dprince has joined #puppet-openstack18:07
EmilienMnibalizer: so, what's your suggestion ?18:07
nibalizerwhat's wrong with doing nothing?18:09
EmilienMnibalizer: seriously?18:10
EmilienMnibalizer: in my comment on https://review.openstack.org/#/c/226830/ - I explained you why I did that, we can't just ignore the facts, can we?18:11
*** dmsimard is now known as dmsimard|afk18:11
EmilienM1/ unit tests are not run against the same dependencies as functional tests18:12
EmilienMthis is a big issue, last week I ran a bug where puppet-qpid code in puppet-nova was too old - we did not track it because fixtures pin an old release, beaker a new one but we don't test QPID18:12
EmilienMthat means our code is potentially not passing unit tests when using the same dependencies as beaker/integration18:13
nibalizerwell the definition of a bug is a problem in code that has landed imho18:13
nibalizerif you need depends-on its because there is code that hasn't landed yet18:13
EmilienMit's not about depends-on now18:13
EmilienM2/ unit tests are not using the same dependencies (fixtures.yaml is not consistent across all modules !)18:14
nibalizerwhat is it about18:14
EmilienMnibalizer: I wrote it in Gerrit18:14
EmilienMand 3/ because we use fixtures, our patches can't use Depends-On zuul feature for unit tests18:14
nibalizerin the commit messaeg?18:14
nibalizeror in the discussion18:14
EmilienMno, in PatchSet 24 comment18:14
EmilienMI wrote a comment for you18:14
EmilienMto explain our motivation18:14
EmilienMto make it18:14
EmilienMnibalizer: how do you solve 1/ and 2/ ?18:15
nibalizeri have to get lunch18:16
nibalizerill pop on after and we can continue this18:16
EmilienMme too, it's 2.15pm18:16
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: Add ironic-inspector support  https://review.openstack.org/22369018:16
EmilienMnibalizer: i would like to continue that discussion after18:16
*** openstackgerrit has quit IRC18:16
*** openstackgerrit has joined #puppet-openstack18:17
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: Add ironic-inspector support  https://review.openstack.org/22369018:31
*** ibravo has joined #puppet-openstack18:31
*** _ducttape_ has joined #puppet-openstack18:44
*** linkedinyou has quit IRC18:44
*** xarses_ has quit IRC18:45
*** ducttape_ has quit IRC18:46
*** openstackgerrit has quit IRC18:46
*** openstackgerrit has joined #puppet-openstack18:47
mwhahahaEmilienM: I remember you updated the apt requirements to 2.1.x in opesntack-integration, what was that for?18:50
crinkleEmilienM: looks like puppetlabs is going to fix and release beaker soonish18:53
crinkleso we might not have to do anything18:53
EmilienMcrinkle: they are very responsive, it's awesome18:55
*** ducttape_ has joined #puppet-openstack18:55
EmilienMmwhahaha: I updated the Puppetfile yes, so we can test puppetlabs-apt 2.x18:56
EmilienMmwhahaha: any issue?18:56
mwhahahaNo just wondering if we needed to do the same18:56
mwhahahadidn't know if there was a technical reason18:56
*** _ducttape_ has quit IRC18:56
mwhahahawe're using 1.8.0 and i just happen to be messing with our puppetfile18:56
EmilienMcrinkle: https://github.com/puppetlabs/beaker/pull/97318:56
*** linkedinyou has joined #puppet-openstack18:57
EmilienMmwhahaha: it was a major update for the module, we wanted our modules using it so we stay on the edge18:58
mwhahahaok18:58
mwhahahathanks18:58
EmilienMmwhahaha: because it's important for us to make sure our module work with our dependencies18:58
EmilienMthe Puppetfile is willing to be updated quite often I guess18:59
EmilienM_ody: it's odd we can't see your CI http://jenkins-beaker.delivery.puppetlabs.net/job/qe_beaker_btc-intn/1587/18:59
*** dmsimard|afk is now known as dmsimard19:03
_odyEmilienM: Nigel sent out an email to puppet-dev a while back, we had to shut off public access temporarily.  https://groups.google.com/forum/#!searchin/puppet-dev/jenkins/puppet-dev/24WeTcFk8Co/tONeSrl9BQAJ19:07
EmilienM_ody: thx19:08
*** ducttape_ has quit IRC19:10
*** ducttape_ has joined #puppet-openstack19:10
_odyI need a couple Ansible users or ex-users willing to volunteer to be interviewed by our UX and product teams.  Please just PM me if you're willing.19:11
*** xarses_ has joined #puppet-openstack19:12
_odyActually...doesn't have to be Ansible, things like fabric or rundeck are valid too.19:12
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: Add ironic-inspector support  https://review.openstack.org/22369019:13
*** _ducttape_ has joined #puppet-openstack19:14
*** ducttape_ has quit IRC19:15
EmilienMcrinkle: re: integration job failures - on centos, it's seems random though, like this one: http://logs.openstack.org/70/229470/1/check/gate-puppet-openstack-integration-dsvm-centos7/e374fd1/console.html#_2015-09-30_18_38_48_17119:20
EmilienMit looks like it comes from here: http://logs.openstack.org/70/229470/1/check/gate-puppet-openstack-integration-dsvm-centos7/e374fd1/logs/nova/nova-compute.txt.gz#_2015-09-30_18_38_08_06719:21
crinkleEmilienM: the difference I see between that http://logs.openstack.org/71/229071/4/check/gate-puppet-openstack-integration-dsvm-centos7/482718e/console.html is hpcloud vs rax19:22
crinklemight be related19:22
EmilienMcrinkle: we have the same flavors, right?19:22
crinklei don't know what's different between them19:23
EmilienMwell, we can easily find out19:24
EmilienMcrinkle: to me, it's still random because the failures ^^^^ are for a scenario that used to work, and it's failing randomly now19:24
EmilienMboth flavors have 8GB of Ram and 8 VCPU19:25
crinkleokay19:25
crinklei guess you're right, maybe just putting too many things on one node19:26
EmilienMcrinkle: I should stop pushing more tests on integ19:26
crinkleneed to figure out how devstack gets away with it19:26
EmilienMyeah19:26
EmilienMcrinkle: actually they don't have this issue because they don't install everything like we do19:26
EmilienMie: glance CI installs devstack with basic components, but not sahara for example19:27
EmilienMin our case, we install everything19:27
crinklei thought that was the point of the integrated gate?19:27
EmilienMmaybe I missed something then19:27
crinkle¯\_(ツ)_/¯19:27
EmilienMcrinkle: do you have an example of job?19:27
crinkleEmilienM: ?19:28
EmilienMcrinkle: do you have an example of integration job for OpenStack?19:28
crinkleEmilienM: no i don't have more knowledge than you19:28
crinklemaybe mtreinish can help us out?19:28
EmilienMcrinkle: look Glance for example: https://review.openstack.org/#/c/218869/19:28
EmilienMthey have gate-tempest-dsvm-full19:29
EmilienMand it's only installing cinder, glance, keystone nova and swift;19:29
mtreinishcrinkle: with?19:29
EmilienMmtreinish: we are having a lot of random failures in tempest19:29
*** dprince has quit IRC19:29
EmilienMhttp://logs.openstack.org/70/229470/1/check/gate-puppet-openstack-integration-dsvm-centos7/e374fd1/console.html#_2015-09-30_18_38_48_171 is an example19:29
EmilienMthey are random19:30
EmilienMwe think it could be because we're installing too much services on the same node19:30
EmilienMmtreinish: we're installing/testing nova/neutron/keystone/cinder/glance/swift/sahara/heat/ceilometer (trove & horizon are wip)19:30
mtreinishEmilienM: so my gut feeling is that you're putting too much on a single slave19:31
EmilienMyes19:31
mtreinishhaving cinder tests timeout at 300 sec might just mean things are moving too slowly19:31
mtreinishsame with the nova failure from the scheduler19:31
EmilienMit makes sense19:31
EmilienMwe have several options19:32
EmilienM1/ increase timeout where we can and continue to live with that19:32
EmilienM2/ drop some services19:33
EmilienM3/ split scenario001 and have scenario002 - share services across 2 scenarios19:33
EmilienMI'm exploring 1/ now, because 2/ is not what we want, and 3/ will consumme more CI jobs (we're already using an important number of jobs...)19:36
openstackgerritJohn Trowbridge proposed openstack/puppet-ironic: Add ironic-inspector support  https://review.openstack.org/22369019:39
openstackgerritRamkumar Gowrishankar proposed openstack/puppet-neutron: Support for Nuage Neutron plugin and Nuage VRS in puppet-neutron  https://review.openstack.org/21479819:40
*** ibravo has quit IRC19:44
*** _ducttape_ has quit IRC19:57
*** ducttape_ has joined #puppet-openstack19:57
*** rahulait has joined #puppet-openstack20:01
EmilienMcrinkle: beside nova timeouts, I noticed neutron server sometimes fails to create ports because it thinks ovs agent is down (heartbeat)20:04
mtreinishEmilienM: so I actually think splitting the services is what you want to do20:14
mtreinishI'd recommend something a bit more layered20:14
mtreinishlike base IaaS and then things like sahara, trove and  heat seperately20:14
mtreinishit also seperates concerns a bit more, because the higher level stuff depends on a working IaaS cloud20:15
mtreinishsry, I'm split like 4 ways right now my feedback loop might be a bit slow20:15
EmilienMmtreinish: it's going to consume more CI resources though20:16
mtreinishso20:17
mtreinishEmilienM: tempest runs like 30 jobs :)20:17
mtreinishyou're still a far way off from that20:17
EmilienMit's something we might consider, indeed20:17
nibalizerEmilienM: ok i am back20:17
EmilienMnibalizer: hope you had great lunch, I took some energy for this rainy day20:18
nibalizercool20:18
EmilienMnibalizer: so let me summarize again: we have 3 problems20:19
EmilienMdocumented in https://review.openstack.org/#/c/226830/ comments (see my reply to you)20:19
EmilienMDepends-On feature is a "nice to have", which is one of the 3 problems I'm trying to solve.20:20
EmilienMwe still need to test modules against same dependencies in unit & functional tests20:20
EmilienMand we still need to keep consistent the dependencies20:21
nibalizerEmilienM: so for both 1 & 2 I think that's fine20:21
nibalizerunit tests are local to the project20:21
*** jayg is now known as jayg|g0n320:21
nibalizerthey only matter to the project being tested20:21
EmilienM"that's fine" == we can ignore the issues?20:21
nibalizerthat's what I am thinking20:22
EmilienMI disagree here20:22
nibalizerunit tests and acceptance tests are different tests20:22
*** ducttape_ has quit IRC20:23
EmilienMthey are different in the result, but using the same dependencies just make sense.20:23
*** ducttape_ has joined #puppet-openstack20:24
EmilienMnibalizer: so for you, it does not matter to test puppet-keystone with different versions of puppetlabs-apache2 in unit & functional?20:25
nibalizerso how does that happen?20:25
nibalizerhttps://review.openstack.org/#/c/226830/24/.fixtures.yml it looks like nova doesn't even use apache?20:26
nibalizeror didn't prior to your patch?20:26
EmilienMnibalizer: functional testing is pulling Puppetfile that contains the version we really want to test. unit testing is using fixtures file in repos, that is does not contain the same version of functional testing, and is hard to control (not centralied)20:26
EmilienMcentralized*20:26
*** xarses_ is now known as xarses20:27
EmilienMnibalizer: in progress: https://review.openstack.org/21331520:27
nibalizerok20:28
nibalizerya thats fair20:28
nibalizerI mean it's not bad20:28
nibalizerit's better20:29
EmilienMI don't see what I'm doing wrong here20:29
nibalizerI think a) it's fine to do it the old way20:30
nibalizerbut b) your way is better20:30
nibalizerand c) the complexity I don't like20:30
EmilienMnibalizer: since I'm doing puppet openstack, it very rarely happened to me to have to edit fixtures file locally20:31
EmilienMthis is the only "complex" thing we're changing20:32
openstackgerritJay_Clark proposed openstack/puppet-nova: Fix for Bug #1484402  https://review.openstack.org/22947520:32
openstackbug 1484402 in puppet-nova "no interface for modify the port of nova-api " [Low,Confirmed] https://launchpad.net/bugs/1484402 - Assigned to Jay_Clark (jay-clark)20:32
nibalizerEmilienM: ok20:32
nibalizeri'll stop objecting20:32
EmilienMpeople will have to take Puppetfile from our repo, modify it at their wish and change env20:32
nibalizerok20:32
nibalizerwe'll document it20:33
EmilienMlet's give a try20:34
EmilienMif we have bad feedback from our users, we can still revert20:34
EmilienMor improve it on the fly20:34
EmilienMmtreinish: I'm considering splitting now, I notices 4 kinds of timeouts that are going to be hard to fix...20:35
EmilienMmtreinish: I'm just sending an emailt to ML to get feedback before20:35
mtreinishEmilienM: yeah, you don't really want to up the timeouts either because you'll likely hit the per test timeout20:36
nibalizerya20:36
mtreinishor the jenkins job timeout20:36
EmilienM++20:36
EmilienMwe knew that would happen20:36
nibalizerim considering a ruby gem/function that is basically detect_and_zuul_clone_repo <reponame>20:36
EmilienMit's just until now it was green :)20:36
nibalizerthat way some of the stuff in both this rakefile and all over spec_helper_acceptance can be shortened20:36
nibalizeralso google-fog/beaker is :(20:37
EmilienMnibalizer: crinkle had a great idea, to create a gem, see https://review.openstack.org/22912620:37
nibalizeroh nice20:38
EmilienMyeah, it will help a lot for consistency20:38
*** sergmelikyan has joined #puppet-openstack20:39
*** ibravo has joined #puppet-openstack20:40
*** _ducttape_ has joined #puppet-openstack20:40
*** ducttape_ has quit IRC20:41
nibalizerya20:44
nibalizercrinkle: see andreas on 22912620:45
nibalizerEmilienM: too20:45
EmilienMnibalizer: I replied, and it should not block. jeblair already told me in the past we could add repos without governance merge. because the proejct is already big tent20:46
nibalizerok20:49
*** itsuugo has joined #puppet-openstack20:53
*** apuimedo has quit IRC20:56
*** jpena|away is now known as jpena|zzz20:57
*** apuimedo has joined #puppet-openstack21:00
*** rahulait has quit IRC21:01
*** gildub has joined #puppet-openstack21:06
EmilienMcrinkle: I'm seriously wondering if we should keep upgrade jobs for now21:07
gildubEmilienM, hi - Please review https://review.openstack.org/22662421:07
EmilienMcrinkle: do you think their current state is useful to have in our CI ?21:07
crinkleEmilienM: why are they broken?21:08
EmilienMcrinkle: most of them actually work21:08
EmilienMcrinkle: I'm just wondering how useful they are at this time21:09
EmilienMcrinkle: I was thinking, dropping them and replace by a second scenario if we decide to split our integration manifest21:09
EmilienMcrinkle: I haven't taken time in this cycle to work on upgrades - the upgrade jobs were really experimental21:09
gildubActually, any core member please review https://review.openstack.org/22662421:10
crinkleEmilienM: i'm fine with removing the upgrade job21:10
crinkleEmilienM: but i don't think it's an either-or necessarily21:10
EmilienMcrinkle: do you think it's acceptable to have 2 more jobs?21:10
gilduband https://review.openstack.org/228744 too, please.21:11
EmilienMfor scenario002 (if we decide the split)21:11
crinklemaybe?21:11
crinkle¯\_(ツ)_/¯21:12
*** Guest37880 has joined #puppet-openstack21:13
*** Guest37880 has quit IRC21:17
openstackgerritJay_Clark proposed openstack/puppet-nova: Fix for Bug #1484402  https://review.openstack.org/22963421:22
openstackbug 1484402 in puppet-nova "no interface for modify the port of nova-api " [Low,Confirmed] https://launchpad.net/bugs/1484402 - Assigned to Jay_Clark (jay-clark)21:22
jasondotstarEmilienM: think I've fixed the issues, and added the spec tests. I'm sure you'll let me know if there's something else required... :-)21:23
EmilienMjasondotstar: your commit message is a mess21:24
EmilienMhttps://review.openstack.org/#/c/229634/1//COMMIT_MSG,cm21:24
jasondotstarEmilienM: ok...21:24
EmilienMyou have 3 change-id21:24
EmilienMyour titile is not good21:24
EmilienMlet me give you an example21:24
jasondotstarplz21:25
EmilienMjasondotstar: https://review.openstack.org/#/c/226624/21:26
EmilienMa title, a description and the "Closes-Bug: #XXX"21:26
EmilienMthe "Change-Id" thing is generated by git21:26
crinklejasondotstar: did you squash instead of fixup in your rebase perhaps?21:26
jasondotstarcrinkle: i did squash, yes.21:26
jasondotstarhence the messy commit msg I assume :-/21:27
*** sergmelikyan has quit IRC21:27
crinklethat would mix the commit messages all together, if you choose fixup in the interactive rebase menu it will discard the commit message21:27
* jasondotstar needs better git-fu21:27
EmilienMjasondotstar: you have 3 patches also21:27
jasondotstargit rebase -i HEAD~2  ?21:27
crinklejasondotstar: looks like HEAD~3 but yep21:28
jasondotstarEmilienM: the last one is the only one needed tho, right? it includes the others21:28
jasondotstarcrinkle: i did two squashes trying to fix it....21:29
jasondotstarEmilienM: other than tidying up the commit msg, are the tests correct?21:29
*** sergmelikyan has joined #puppet-openstack21:30
EmilienMjasondotstar: yes21:33
jasondotstarEmilienM: fair enough. I'll make fix the commit msg and abandon those earlier patches21:34
jasondotstars/make//21:34
*** angdraug has joined #puppet-openstack21:34
EmilienMjasondotstar: any progress on zaqar?21:34
jasondotstarEmilienM: indeed21:35
jasondotstarit's WIP but take a look: https://review.openstack.org/#/c/229036/21:35
jasondotstarEmilienM: ^21:35
jasondotstarno tests yet.21:35
EmilienMjasondotstar: I saw that21:35
jasondotstaroh ok21:36
jasondotstarthe one nut to crack is fixing the pymongo update21:36
EmilienMwe have a bunch of modules without functional testing, i'm currently dressing a list and making sure we are working on that.21:36
jasondotstarnot much of a rubyist, but I followed the spec written for nova21:37
jasondotstarso I think I can write the tests needed for zaqar21:37
jasondotstareverything lands on a rpm-based node.... need to work on the deb stuff next for that module.21:38
jasondotstarand finish building up the conf file.21:38
jasondotstarre: writing tests - +1. perhaps I can cut a few teeth helping w/ that.21:39
jasondotstarEmilienM: ^21:39
openstackgerritJay_Clark proposed openstack/puppet-nova: Allows the modification of the nova-api ports  https://review.openstack.org/22964421:48
*** sergmelikyan has quit IRC21:49
openstackgerritGuilherme Balzana proposed openstack/puppet-swift: Add swift-informant middleware support  https://review.openstack.org/22964621:50
*** ducttape_ has joined #puppet-openstack21:53
*** _ducttape_ has quit IRC21:54
EmilienMcrinkle: wdyt about my comment on https://review.openstack.org/#/c/229646 ?21:56
crinkleEmilienM: I think I agree, it looks like swift-informant isn't even an openstack project?21:58
*** iurygregory has quit IRC21:59
crinklebased on the github url it looks like maybe a rackspace project?21:59
EmilienMcrinkle: right21:59
EmilienMI googled it and could not find any reference to upstream work21:59
EmilienMwe should not accept this kind of patch, because it's not encouraging upstream collaboration.21:59
crinkleagree22:00
EmilienMcrinkle: the middleware is 3 years old - /me sighs22:03
EmilienMit should be in https://github.com/openstack/swift/tree/master/swift/common/middleware22:03
*** myatsenko has quit IRC22:04
EmilienMcrinkle: https://github.com/pandemicsyn/swift-informant/issues/1722:05
*** aarefiev has quit IRC22:09
*** morazi has quit IRC22:11
EmilienMplease review https://review.openstack.org/#/c/229426/ and https://review.openstack.org/#/c/229071/ -  Since now, we don't expect integration jobs "stable" anymore... (see thread on ML)22:16
*** dgurtner has quit IRC22:27
*** mdorman has quit IRC22:53
*** dfisher has quit IRC23:02
*** ducttape_ has quit IRC23:14
EmilienMangdraug: not much feedback about puppet-neutron/third party stuffs23:14
EmilienMI'm preparing a patch now, there are a lot of third party resources (repo/packages/services)23:14
*** sc` has quit IRC23:18
angdraugEmilienM: apologies about taking so long to respond, I agree with your conclusion on the thread23:26
openstackgerritEmilien Macchi proposed openstack/puppet-neutron: disable third-party software management  https://review.openstack.org/22967523:27
EmilienMangdraug: ^23:27
angdraug+123:29
gildubcrinkle, EmilienM, please review https://review.openstack.org/226624 and https://review.openstack.org/178456, so we get those boulders out of the way, thanks!23:31
EmilienMnot sure what we can do with https://review.openstack.org/#/c/178456/23:33
angdraugadded a link from 209997 to 22967523:33
EmilienMgildub: https://review.openstack.org/#/c/226624/13/spec/acceptance/keystone_wsgi_apache_spec.rb,cm23:34
EmilienMgildub: how can we know you're backward compatible?23:34
EmilienMyou're changing the interface23:34
EmilienMraise(Puppet::Error, "Missing domain name for resource #{name}")23:35
EmilienMiirc, if you use the previous interface, you have this error ^23:35
gildubcrinkle, EmilienM, sorry second link is wrong, I meant https://review.openstack.org/22874423:36
EmilienMthe 2 patches need a lot of attention23:36
gildubEmilienM, that said a Keystone patch to support V3 endpoints in v2 seems on its way23:36
EmilienMit's EOD for me23:36
EmilienMI'm not sure we can merge https://review.openstack.org/#/c/226624/ right now23:37
EmilienMis it backward compatible?23:37
EmilienMgildub, richm ^23:37
gildubEmilienM, the resource title has to be name::domain because:23:38
gildubEmilienM, 1. The tenant parameter for ::keystone::resource::service_identity requires it23:39
gildubEmilienM, 2. The title must be consistent across the catalog23:40
EmilienMgildub: can you reply to my question?23:41
gildubEmilienM, I'm talking for the acceptance test to be running green. Now the keystone_tenant/user provider can still use just <name> and pass domain as a parameter23:41
EmilienMgildub: is it backward compatible?23:41
openstackgerritEmilien Macchi proposed openstack/puppet-keystone: test old keystone_tenant interface  https://review.openstack.org/22968123:41
EmilienMtesting it ^23:41
gildubEmilienM, well until we got the upgrade test running nobody is going to be sure isn't?23:42
EmilienMgildub: the what?23:43
EmilienMmy question is simple: can I use keystone_tenant old interface?23:43
EmilienMgildub: like I'm testing in my patch ^23:44
EmilienMif not, your work is not backward compatible and can't be merged.23:44
gildubEmilienM, yes its backward compatible23:44
EmilienMi've -2'ed the patch until my test is green23:45
gildubEmilienM, great, I go to the beach for the rest of the day then.23:45
EmilienMgildub: maybe but I don't see (or I missed it) tests that test it.23:45
EmilienMgildub: ?23:45
gildubEmilienM, It's not because the acceptance test change that it means anything to the backward support, the unit tests do23:46
EmilienMgildub: maybe, I just don't see it, maybe you can highlight it?23:48
EmilienMgildub: ?23:51
gildubEmilienM, lines 165-207 => https://review.openstack.org/#/c/226624/13/spec/unit/provider/keystone_tenant/openstack_spec.rb23:51
EmilienMindeed, unit tests seem good23:52
EmilienMI have other concerns, I'm writting a review in Gerrit23:52
gildubEmilienM, ok thanks, just looking forward to get that one out of the way to be able to move on.23:53
EmilienMgildub: me too, don't worry23:53
gildubEmilienM, k23:54
EmilienMgildub: this code is really critical, since it's used everywhere in our modules - I just pay x2 attention23:54
gildubEmilienM, fair enough!23:56
EmilienMgildub: see my comment23:56
gildubEmilienM, looking23:56
« Tuesday, 2015-09-29 Index Thursday, 2015-10-01 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!