*** mwoodson has quit IRC | 00:14 | |
*** mwoodson has joined #puppet-openstack | 00:14 | |
*** guessi has joined #puppet-openstack | 00:19 | |
*** sanjayu has quit IRC | 00:53 | |
*** guessi has left #puppet-openstack | 01:06 | |
*** imcsk8 has joined #puppet-openstack | 01:10 | |
*** imcsk8_ has quit IRC | 01:10 | |
*** ducttape_ has joined #puppet-openstack | 02:14 | |
*** guessi has joined #puppet-openstack | 02:37 | |
*** ducttape_ has quit IRC | 02:40 | |
*** ducttape_ has joined #puppet-openstack | 02:47 | |
*** ducttape_ has quit IRC | 03:08 | |
*** _ody has quit IRC | 03:16 | |
*** guessi has left #puppet-openstack | 03:37 | |
*** _ody has joined #puppet-openstack | 03:44 | |
*** lavaboy has joined #puppet-openstack | 04:00 | |
*** sergmelikyan has joined #puppet-openstack | 04:07 | |
*** sergmelikyan has quit IRC | 04:11 | |
*** sanjayu has joined #puppet-openstack | 05:27 | |
*** lavaboy has quit IRC | 05:33 | |
*** lavaboy has joined #puppet-openstack | 05:34 | |
*** saravanankr has joined #puppet-openstack | 05:36 | |
*** guessi has joined #puppet-openstack | 05:42 | |
*** saravanankr has quit IRC | 05:52 | |
*** guessi has left #puppet-openstack | 05:52 | |
*** darkxploit has quit IRC | 05:55 | |
*** saravanankr has joined #puppet-openstack | 06:09 | |
*** darkxploit has joined #puppet-openstack | 06:11 | |
*** aarefiev_ has quit IRC | 06:28 | |
*** leanderthal has joined #puppet-openstack | 06:28 | |
*** jtomasek has joined #puppet-openstack | 06:28 | |
*** aarefiev has joined #puppet-openstack | 06:30 | |
*** khushbu has joined #puppet-openstack | 06:42 | |
*** arnaud_orange has joined #puppet-openstack | 06:42 | |
*** arnaud_orange has quit IRC | 06:49 | |
*** arnaud_orange has joined #puppet-openstack | 07:04 | |
*** jpena has joined #puppet-openstack | 07:30 | |
*** sergmelikyan has joined #puppet-openstack | 07:32 | |
*** sergmelikyan has quit IRC | 07:34 | |
*** dgurtner has joined #puppet-openstack | 07:46 | |
*** sergmelikyan has joined #puppet-openstack | 08:03 | |
*** paramite has joined #puppet-openstack | 08:10 | |
*** khushbu has quit IRC | 08:14 | |
*** gfidente has joined #puppet-openstack | 08:16 | |
*** gfidente has quit IRC | 08:16 | |
*** gfidente has joined #puppet-openstack | 08:16 | |
*** sergmelikyan has quit IRC | 08:28 | |
*** mattymo has quit IRC | 08:29 | |
*** mattymo has joined #puppet-openstack | 08:29 | |
*** sergmelikyan has joined #puppet-openstack | 08:38 | |
*** jistr has joined #puppet-openstack | 08:38 | |
*** paramite is now known as paramite|afk | 08:47 | |
*** sergmelikyan has quit IRC | 08:59 | |
*** jistr has quit IRC | 09:00 | |
*** paramite|afk is now known as paramite | 09:00 | |
*** jistr has joined #puppet-openstack | 09:01 | |
*** paramite is now known as paramite|afk | 09:02 | |
*** markvoelker has joined #puppet-openstack | 09:05 | |
*** markvoelker_ has joined #puppet-openstack | 09:06 | |
*** jmccrory has quit IRC | 09:07 | |
*** jmccrory has joined #puppet-openstack | 09:08 | |
*** markvoelker has quit IRC | 09:09 | |
*** sergmelikyan has joined #puppet-openstack | 09:11 | |
*** sergmelikyan has quit IRC | 09:12 | |
*** sergmelikyan has joined #puppet-openstack | 09:14 | |
*** paramite|afk is now known as paramite | 09:18 | |
*** rochaporto has joined #puppet-openstack | 09:18 | |
openstackgerrit | Christian Schwede proposed openstack/puppet-swift: Define ${name}-auditors in storage/generic.pp https://review.openstack.org/230914 | 09:19 |
---|---|---|
*** markvoelker_ has quit IRC | 09:20 | |
*** paramite is now known as paramite|afk | 09:23 | |
myatsenko | mfisch: hello Matt! You wrote you faced with some problem, | 09:26 |
myatsenko | is it related to this patch - https://review.openstack.org/#/c/209412/ ? | 09:26 |
*** sergmelikyan has quit IRC | 09:27 | |
*** sergmelikyan has joined #puppet-openstack | 09:29 | |
*** paramite|afk is now known as paramite | 09:31 | |
*** sergmelikyan has quit IRC | 09:40 | |
openstackgerrit | Christian Schwede proposed openstack/puppet-swift: Define ${name}-auditors in storage/generic.pp https://review.openstack.org/230914 | 09:43 |
openstackgerrit | Yanis Guenane proposed openstack/puppet-cinder: Specify a dedicated keystone user for cinderv2 https://review.openstack.org/230922 | 09:52 |
*** degorenko has joined #puppet-openstack | 09:54 | |
*** IBerezovskiy has joined #puppet-openstack | 09:58 | |
*** iberezovskiy has joined #puppet-openstack | 09:58 | |
*** sergmelikyan has joined #puppet-openstack | 10:00 | |
*** sergmelikyan has quit IRC | 10:24 | |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-keystone: Add semantic title for keystone_tenant. https://review.openstack.org/226919 | 10:35 |
*** sergmelikyan has joined #puppet-openstack | 10:41 | |
*** paramite has quit IRC | 10:46 | |
*** paramite has joined #puppet-openstack | 10:46 | |
*** _skolekonov is now known as skolekonov | 10:51 | |
*** igajsin has joined #puppet-openstack | 10:55 | |
*** lavaboy has quit IRC | 11:00 | |
openstackgerrit | Yanis Guenane proposed openstack/puppet-horizon: Create horizon::keystone::auth https://review.openstack.org/230949 | 11:06 |
openstackgerrit | Yanis Guenane proposed openstack/puppet-horizon: Create horizon::keystone::auth https://review.openstack.org/230949 | 11:08 |
*** igajsin has left #puppet-openstack | 11:08 | |
*** sergmelikyan has quit IRC | 11:19 | |
*** iurygregory has joined #puppet-openstack | 11:30 | |
iurygregory | good morning people :D | 11:31 |
EmilienM | good morning | 11:39 |
degorenko | morning o/ | 11:42 |
iurygregory | \o | 11:43 |
openstackgerrit | Denis Egorenko proposed openstack/puppet-nova: Use OpenstackClient for nova providers auth https://review.openstack.org/226862 | 11:44 |
openstackgerrit | Denis Egorenko proposed openstack/puppet-nova: Use OpenstackClient for nova providers auth https://review.openstack.org/226862 | 11:48 |
*** darkxploit has quit IRC | 11:52 | |
*** jayg|g0n3 is now known as jayg | 11:54 | |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-ceilometer: Add ability to override class parameters https://review.openstack.org/229918 | 12:00 |
*** trown|outttypeww is now known as trown | 12:00 | |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-ceilometer: Add ability to override class parameters https://review.openstack.org/229918 | 12:02 |
*** v1k0d3n has joined #puppet-openstack | 12:04 | |
*** darkxploit has joined #puppet-openstack | 12:04 | |
*** sergmelikyan has joined #puppet-openstack | 12:09 | |
*** ducttape_ has joined #puppet-openstack | 12:14 | |
*** saravanankr has quit IRC | 12:23 | |
*** dprince has joined #puppet-openstack | 12:23 | |
*** ducttape_ has quit IRC | 12:27 | |
openstackgerrit | Merged openstack/puppet-openstacklib: Add os_service_default fact https://review.openstack.org/229050 | 12:34 |
EmilienM | mwhahaha: it seems your patch is merged ^ - could you clean-up anything useless in openstacklib from previous proposals? | 12:37 |
EmilienM | mwhahaha: or pobably just adjusting, like the is_service_default function | 12:38 |
mwhahaha | ok | 12:39 |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Switch cinder to use os_service_default fact https://review.openstack.org/229095 | 12:40 |
*** jpena is now known as jpena|lunch | 12:40 | |
*** sergmelikyan has quit IRC | 12:47 | |
*** sergmelikyan has joined #puppet-openstack | 12:53 | |
degorenko | guys, take a look please: https://review.openstack.org/#/q/status:open+project:openstack/puppet-nova+topic:bp/use-openstackclient-in-module-resources,n,z | 12:54 |
*** sanjayu has quit IRC | 12:57 | |
*** sanjayu has joined #puppet-openstack | 12:57 | |
*** sanjayu has quit IRC | 12:58 | |
*** sanjayu has joined #puppet-openstack | 12:58 | |
*** sanjayu has quit IRC | 12:59 | |
*** sanjayu has joined #puppet-openstack | 12:59 | |
openstackgerrit | Merged openstack/puppet-glance: file backend: do not inherit from glance::api https://review.openstack.org/230556 | 13:05 |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Application resource implementation https://review.openstack.org/220238 | 13:15 |
*** rochaporto has quit IRC | 13:18 | |
*** sergmelikyan has quit IRC | 13:19 | |
*** blentz_ is now known as blentz | 13:20 | |
openstackgerrit | John Trowbridge proposed openstack/puppet-ironic: Add ironic-inspector support https://review.openstack.org/223690 | 13:23 |
*** sergmelikyan has joined #puppet-openstack | 13:25 | |
openstackgerrit | Li Chengyuan proposed stackforge/puppet-ceph: Change keyring file mode default value to 0644 instead of 0600 https://review.openstack.org/230993 | 13:29 |
*** morazi has joined #puppet-openstack | 13:32 | |
*** jasondotstar|afk is now known as jasondotstar | 13:32 | |
*** dfisher has joined #puppet-openstack | 13:42 | |
*** mattymo has quit IRC | 13:46 | |
*** mattymo has joined #puppet-openstack | 13:47 | |
*** mattymo has quit IRC | 13:47 | |
*** jpena|lunch is now known as jpena | 13:48 | |
*** mattymo__ has joined #puppet-openstack | 13:49 | |
*** mattymo__ has quit IRC | 13:49 | |
*** tiswanso has joined #puppet-openstack | 13:50 | |
*** mattymo has joined #puppet-openstack | 13:51 | |
*** mattymo has quit IRC | 13:55 | |
*** ferest has joined #puppet-openstack | 13:55 | |
*** mattymo__ has joined #puppet-openstack | 13:55 | |
*** mattymo__ has quit IRC | 13:55 | |
*** mattymo1 has joined #puppet-openstack | 13:55 | |
*** mattymo has joined #puppet-openstack | 13:57 | |
*** dfisher has quit IRC | 13:57 | |
*** dfisher has joined #puppet-openstack | 13:58 | |
*** sanjayu has quit IRC | 13:58 | |
*** ducttape_ has joined #puppet-openstack | 14:00 | |
openstackgerrit | Drew Fisher proposed openstack/puppet-glance: Remove POSIX users, groups, and file modes. https://review.openstack.org/211593 | 14:11 |
*** ferest has quit IRC | 14:11 | |
dfisher | let's see if CI likes me this morning | 14:11 |
*** richm has joined #puppet-openstack | 14:14 | |
*** Guest38101 is now known as zeus | 14:14 | |
*** zeus has quit IRC | 14:14 | |
*** zeus has joined #puppet-openstack | 14:14 | |
*** paramite is now known as paramite|afk | 14:24 | |
openstackgerrit | Li Chengyuan proposed stackforge/puppet-ceph: Change keyring file mode default value to 0644 instead of 0600 https://review.openstack.org/230993 | 14:27 |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Client and dashboard class implementation https://review.openstack.org/218333 | 14:28 |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Application resource implementation https://review.openstack.org/220238 | 14:28 |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Switch cinder to use os_service_default fact https://review.openstack.org/229095 | 14:28 |
*** paramite|afk is now known as paramite | 14:36 | |
*** ChanServ sets mode: -o EmilienM | 14:40 | |
*** devnull0 has joined #puppet-openstack | 14:48 | |
*** mdorman has joined #puppet-openstack | 14:52 | |
*** EmilienM has quit IRC | 14:55 | |
*** EmilienM has joined #puppet-openstack | 14:55 | |
*** paramite has quit IRC | 14:58 | |
*** ChanServ sets mode: +o EmilienM | 14:59 | |
*** tiswanso has quit IRC | 15:00 | |
*** _ducttape_ has joined #puppet-openstack | 15:36 | |
*** _ducttape_ has quit IRC | 15:37 | |
*** _ducttape_ has joined #puppet-openstack | 15:38 | |
*** ducttape_ has quit IRC | 15:39 | |
EmilienM | rubygems servers have issue today, expect some CI issues | 15:48 |
*** angdraug has joined #puppet-openstack | 15:48 | |
*** sergmelikyan has quit IRC | 15:51 | |
*** richm has quit IRC | 15:59 | |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-cinder: Allow RBD host to be configurable https://review.openstack.org/231068 | 15:59 |
mfisch | myatsenko: yes, it broke us | 16:04 |
mfisch | myatsenko: also it should be backend_host, host is deprecated | 16:04 |
*** fedexo has joined #puppet-openstack | 16:06 | |
*** bnemec has joined #puppet-openstack | 16:11 | |
clayton | myatsenko: https://review.openstack.org/231068 is my fix for the issue | 16:12 |
*** imcsk8 is now known as imcsk8|afk | 16:17 | |
mfisch | clayton: do we really need the absent stuff? I thought cinder supported service_default | 16:21 |
aderyugin | crinkle, mfish, mgagne, sbadia, spredzy: review https://review.openstack.org/#/c/216682/ and merge if possible. Already got +2 from EmilienM. | 16:23 |
*** trown is now known as trown|lunch | 16:24 | |
*** gfidente is now known as gfidente|afk | 16:26 | |
*** jistr has quit IRC | 16:26 | |
mfisch | clayton: nm on my comment | 16:31 |
*** jpena has quit IRC | 16:40 | |
*** ducttape_ has joined #puppet-openstack | 16:40 | |
*** skolekonov is now known as _skolekonov | 16:43 | |
*** _ducttape_ has quit IRC | 16:43 | |
*** dgurtner has quit IRC | 16:50 | |
*** richm has joined #puppet-openstack | 16:50 | |
*** trown|lunch is now known as trown | 16:57 | |
*** iberezovskiy has quit IRC | 16:58 | |
*** fedexo has quit IRC | 17:01 | |
*** iurygregory has quit IRC | 17:09 | |
trown | EmilienM: should I recheck https://review.openstack.org/#/c/223690/ only failures are upgrade and gem install failures on a couple of the unit tests | 17:21 |
EmilienM | trown: yes | 17:22 |
dfisher | EmilienM is rubygems back to life? | 17:22 |
*** xarses has quit IRC | 17:23 | |
EmilienM | sounds unstable | 17:24 |
*** richm has quit IRC | 17:26 | |
EmilienM | mfisch, clayton, mgagne, crinkle: when you got time, I would like more eyes on https://review.openstack.org/#/c/226624/ - it's some "not backward compatibible" stuff for liberty. | 17:28 |
EmilienM | since domains were experimental for us, I guess such a design change is acceptable | 17:30 |
*** openstackgerrit has quit IRC | 17:31 | |
*** openstackgerrit has joined #puppet-openstack | 17:32 | |
*** rahulait has joined #puppet-openstack | 17:40 | |
*** fedexo has joined #puppet-openstack | 17:41 | |
*** xarses has joined #puppet-openstack | 17:44 | |
*** sergmelikyan has joined #puppet-openstack | 17:48 | |
*** fedexo has quit IRC | 17:48 | |
*** angdraug has quit IRC | 17:50 | |
*** iurygregory has joined #puppet-openstack | 17:50 | |
EmilienM | mfisch: could you justify your +1 on https://review.openstack.org/#/c/231068/ ? (why not +2) | 17:51 |
EmilienM | I'm always curious why core folks use +1 without comments. | 17:51 |
mfisch | didn't want to +2 something from someone from my company with whom I've discussed this | 17:51 |
clayton | I assumed it's because he avoiding looking biased. | 17:51 |
EmilienM | clayton: lol | 17:51 |
mfisch | I'd be happy to be the 2nd +2 | 17:51 |
EmilienM | we already had this discussion with spredzy and sbadia | 17:52 |
mfisch | this isnt Horizon right ducttape_ ? We expect other companies to +2 our work ;) | 17:52 |
EmilienM | as soon the review & discussions remains open, I don't think we should have the "company barrier" | 17:52 |
mfisch | I'm +2 on it for sure ;) | 17:52 |
ducttape_ | no comment mfisch | 17:52 |
mfisch | I'd like to get some feedback from the original author as well | 17:53 |
EmilienM | what I mean is, if the patch is good, and we're not doing ninja reviews (ie, not let some time to review it), it's fine | 17:53 |
EmilienM | clayton: why do you drop the test on https://review.openstack.org/#/c/231068/1/spec/classes/cinder_volume_rbd_spec.rb,cm ? | 17:54 |
clayton | because it should have never been in that file | 17:54 |
clayton | that's a volume test file, but the feature being tested is a backend feature. | 17:54 |
EmilienM | clayton: ok. I've +2-ed | 17:54 |
EmilienM | clayton, mfisch: I would be happy if you could look https://review.openstack.org/#/c/226624/ asap | 17:55 |
*** fedexo has joined #puppet-openstack | 17:58 | |
*** openstackgerrit has quit IRC | 18:01 | |
*** openstackgerrit has joined #puppet-openstack | 18:02 | |
openstackgerrit | Merged openstack/puppet-keystone: wsgi: make sure keystone service is stopped before starting httpd https://review.openstack.org/230626 | 18:04 |
mfisch | EmilienM: I have no idea from the commit message what this is really supposed to do | 18:07 |
EmilienM | well, there is a thread about that, also a bug report and read the very last comment | 18:07 |
EmilienM | mfisch: ^ | 18:08 |
beddari | generally this project isn't the greatest ever at commit messages ;) | 18:14 |
*** fedexo has quit IRC | 18:15 | |
*** sergmelikyan has quit IRC | 18:17 | |
*** sergmelikyan has joined #puppet-openstack | 18:20 | |
*** gchamoul has quit IRC | 18:21 | |
dmsimard | EmilienM: FYI spotted failing CI in https://review.openstack.org/#/c/230626/, checking | 18:31 |
EmilienM | dmsimard: :( | 18:31 |
EmilienM | our CI is blocked again... | 18:31 |
EmilienM | dmsimard: http://logs.openstack.org/34/230634/1/gate/gate-puppet-ceilometer-puppet-beaker-rspec-dsvm-centos7/ade4768/console.html#_2015-10-05_17_57_27_879 | 18:32 |
dmsimard | EmilienM: I didn't see that one, I was looking elsehwere, i.e http://logs.openstack.org/26/230626/1/check/gate-puppet-openstack-integration-scenario001-dsvm-centos7/89d9527/console.html#_2015-10-05_17_40_22_955 | 18:36 |
EmilienM | dmsimard: don't look at that | 18:36 |
dmsimard | why not | 18:37 |
EmilienM | everything is fixed by https://review.openstack.org/230431 | 18:37 |
EmilienM | after https://review.openstack.org/230431 - integration job should be more stable | 18:37 |
dmsimard | EmilienM: Ok so you got a problem with just that package install failure then ? | 18:37 |
dmsimard | That looks like a general failure, even epel fails right below | 18:38 |
dmsimard | Can you re-run it ? | 18:38 |
EmilienM | dmsimard: I did recheck | 18:39 |
EmilienM | let's see if it works now | 18:39 |
trown | by the grace of the rubygems gods https://review.openstack.org/#/c/223690/ has passed all but the centos upgrade test... is that one expected to fail? | 18:40 |
*** imcsk8|afk is now known as imcsk8 | 18:43 | |
*** bklei has joined #puppet-openstack | 18:44 | |
*** sergmelikyan has quit IRC | 19:03 | |
*** rgowrishankar has joined #puppet-openstack | 19:12 | |
*** rahulait has quit IRC | 19:14 | |
*** sanjayu has joined #puppet-openstack | 19:19 | |
*** sanjayu has quit IRC | 19:27 | |
dmsimard | EmilienM: did that CI come back clean ? | 19:30 |
EmilienM | dmsimard: looks like | 19:31 |
dmsimard | \o/ | 19:31 |
dmsimard | trown: don't think that's a normal failure: http://logs.openstack.org/90/223690/26/check/gate-puppet-ironic-puppet-beaker-rspec-upgrade-dsvm-centos7/cf3be0b/console.html#_2015-10-05_18_34_31_507 | 19:34 |
dmsimard | (checking if it's our fault) | 19:34 |
dmsimard | trown: does that ring you a bell? http://logs.openstack.org/90/223690/26/check/gate-puppet-ironic-puppet-beaker-rspec-upgrade-dsvm-centos7/cf3be0b/console.html#_2015-10-05_18_34_26_284 | 19:37 |
trown | dmsimard: hmm... that would seem related to the change at least... | 19:39 |
trown | EmilienM: what is the difference between the upgrade and non-upgrade acceptance jobs? | 19:39 |
EmilienM | trown: https://wiki.openstack.org/wiki/Puppet/CI | 19:40 |
trown | thanks | 19:41 |
trown | dmsimard: EmilienM I do not really get how the upgrade test would fail that way | 19:45 |
EmilienM | trown: have you look logs? | 19:46 |
trown | for inspector the upgrade test should be pretty much equivalent to the non-upgrade test, since there is nothing inspector related on master | 19:46 |
trown | EmilienM: http://logs.openstack.org/90/223690/26/check/gate-puppet-ironic-puppet-beaker-rspec-upgrade-dsvm-centos7/cf3be0b/console.html#_2015-10-05_18_34_26_284 | 19:46 |
openstackgerrit | Merged openstack/puppet-ceilometer: auth: drop service dependency for Keystone_user_role https://review.openstack.org/230634 | 19:46 |
trown | EmilienM: it is clearly failing running ironic-inspector-dbsync... but why would it fail there and not in the non-upgrade case | 19:46 |
*** gfidente|afk has quit IRC | 19:46 | |
EmilienM | trown: it's sounds like packaging stuff, isn't? | 19:47 |
trown | EmilienM: but `ironic-inspector-dbsync --config-file /etc/ironic-inspector/inspector.conf upgrade` is run exactly once in both cases, why does it fail on one and not the other | 19:47 |
EmilienM | trown: I have no idea, I'm not Ironic expert | 19:48 |
EmilienM | what I understand is, doin db_sync after a first puppet run fails | 19:49 |
EmilienM | maybe it's not your patch | 19:49 |
EmilienM | have you looked if the job is green on other patches? | 19:49 |
EmilienM | what about ubuntu? | 19:49 |
trown | ubuntu does not have inspector, so it passes | 19:49 |
trown | because the patch is a noop there | 19:49 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Split scenarios001 in two scenarios https://review.openstack.org/230431 | 19:53 |
EmilienM | crinkle: do you see anything else I can do for https://review.openstack.org/226830 or is it fine now? | 19:53 |
*** iurygregory has left #puppet-openstack | 19:58 | |
*** iurygregory has joined #puppet-openstack | 19:58 | |
crinkle | EmilienM: it's still rm -rf'ing stuff when it shouldn't be | 20:08 |
*** dprince has quit IRC | 20:09 | |
crinkle | EmilienM: hmm though i don't see that part in your patch | 20:09 |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-neutron: Set new ml2::ovs parameters to use SERVICE DEFAULT https://review.openstack.org/230536 | 20:10 |
crinkle | EmilienM: it rm -rf's here http://git.openstack.org/cgit/openstack/puppet-openstack-integration/tree/install_modules.sh#n41 | 20:11 |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-neutron: Set new ml2::ovs parameters to use service default https://review.openstack.org/230536 | 20:11 |
*** markvoelker has joined #puppet-openstack | 20:12 | |
EmilienM | crinkle: when using fixtures, if the test pass, spec/fixtures/modules is cleaup | 20:15 |
EmilienM | with my patch, it will also be cleanup | 20:15 |
crinkle | EmilienM: but if the tests don't pass they should not be cleaned up | 20:15 |
crinkle | EmilienM: with your patch they are always re-cloned even if tests failed | 20:16 |
EmilienM | crinkle: spec_clean is run only if test pass, or? | 20:16 |
crinkle | EmilienM: no install_modules.sh always rm -rf's everything no matter what | 20:16 |
crinkle | it doesn't matter if spec_clean is run | 20:16 |
EmilienM | crinkle: yes, but we are not talking about the same rm_rf | 20:17 |
EmilienM | I'm talking post-tests | 20:17 |
crinkle | i'm talking about this one http://git.openstack.org/cgit/openstack/puppet-openstack-integration/tree/install_modules.sh#n41 | 20:17 |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-neutron: dbsync should only notify services that use the db https://review.openstack.org/231161 | 20:17 |
EmilienM | install_modules.sh is for pre-tests | 20:17 |
openstackgerrit | Ivan Chavero proposed openstack/puppet-neutron: Split SR-IOV configuration file into driver and agent pieces https://review.openstack.org/221991 | 20:17 |
crinkle | if i run "bundle exec rake spec" it will still run spec_prep and still run install_modules.sh | 20:17 |
EmilienM | crinkle: should not we cleanup the dir *after* tests? | 20:18 |
crinkle | EmilienM: it should not clean up if tests fail | 20:18 |
EmilienM | crinkle: how can we do that? | 20:19 |
crinkle | and this has nothing to do with after the tests, i'm saying before tests it is running rm -rf | 20:19 |
crinkle | EmilienM: i think we should not be using install_modules.sh or we should clean up that script so it doesn't mess with the unit tests | 20:19 |
crinkle | 1) the rm -rf is not good, 2) the puppet module list is not good, 3) the gem install r10k is not good | 20:20 |
crinkle | this script isn't general enough for us to be using it in unit tests | 20:20 |
EmilienM | crinkle: we could create a new script | 20:21 |
EmilienM | crinkle: would that work for you? | 20:21 |
crinkle | we should extract the common parts into a functions file | 20:21 |
EmilienM | ok | 20:21 |
crinkle | so install_external(), install_openstack(), install_all(), and the part that does the csplit on the puppetfile would be useful in both cases | 20:21 |
EmilienM | crinkle: oki | 20:22 |
EmilienM | crinkle: i do it | 20:22 |
*** rahulait has joined #puppet-openstack | 20:29 | |
*** jayg is now known as jayg|g0n3 | 20:30 | |
mwhahaha | anyone know why the beaker tests are blowing up on the <SERVICE DEFAULT> stuff when it gets moved to a fact? https://review.openstack.org/#/c/229095/ it's making it to the config as <SERVICE DEFAULT> for whatever reason | 20:35 |
mwhahaha | http://logs.openstack.org/95/229095/4/check/gate-puppet-cinder-puppet-beaker-rspec-dsvm-centos7/c6d4407/logs/cinder/api.txt.gz#_2015-10-05_15_09_36_229 | 20:35 |
EmilienM | oh nice | 20:36 |
mwhahaha | or did we not merge that part yet | 20:38 |
EmilienM | mwhahaha: https://github.com/openstack/puppet-openstacklib/commits/master | 20:38 |
mwhahaha | no i mean the part that handles <SERVICE DEFAULT> was that in oslo config or within openstack_config provider? | 20:39 |
mwhahaha | cause i'm not seeing anything in the openstack_config that specifically deals with <SERVICE DEFAULT> | 20:40 |
EmilienM | mwhahaha: it does | 20:40 |
EmilienM | mwhahaha: https://github.com/openstack/puppet-cinder/search?utf8=%E2%9C%93&q=%3CSERVICE+DEFAULT%3E&type=Code | 20:41 |
mwhahaha | i know, thats why i'm so confused | 20:41 |
mwhahaha | i know it's in puppet-cinder | 20:41 |
mwhahaha | but i'm not seeing anything that fixes it in the confnigs | 20:42 |
mwhahaha | configs | 20:42 |
mwhahaha | where is the part that handles the string of '<SERVICE DEFAULT>' when it gets written, was that in oslo? | 20:42 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Create functions for common bits https://review.openstack.org/231171 | 20:42 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Create install_modules_unit.sh https://review.openstack.org/231175 | 20:45 |
EmilienM | crinkle: if I drop the rm -rf from the bash script, can we keep it in Rakefile? | 20:46 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures https://review.openstack.org/226830 | 20:48 |
crinkle | EmilienM: then it won't work properly for the beaker tests | 20:48 |
EmilienM | crinkle: no, in Rakefile | 20:48 |
EmilienM | if I keep Rakefile doing the rm_rf, but not in install_modules_unit.sh | 20:48 |
EmilienM | install_modules.sh will be for beaker jobs | 20:49 |
EmilienM | install_modules_unit.sh will be for unit jobs | 20:49 |
crinkle | the rakefile should only be rm_rf'ing in spec_clean | 20:49 |
EmilienM | ok | 20:49 |
EmilienM | crinkle: but last time, I told you it will fail if you run tests and stop | 20:50 |
EmilienM | if you run rake and then stop, you have to cleanup the dir | 20:50 |
EmilienM | because nothing will do it for you otherwise | 20:50 |
crinkle | EmilienM: it should be doing this: https://github.com/puppetlabs/puppetlabs_spec_helper/blob/master/lib/puppetlabs_spec_helper/rake_tasks.rb#L123 | 20:50 |
EmilienM | crinkle: I don't understand what's wrong with this rm_rf | 20:52 |
EmilienM | crinkle: why do you want to git clone again? | 20:52 |
EmilienM | we had this discussion last week | 20:52 |
EmilienM | and we admitted doing a ln_s was fine | 20:53 |
crinkle | EmilienM: okay which rm_rf are we talking about now | 20:53 |
crinkle | EmilienM: what i don't want is rm -rf modules/* | 20:53 |
EmilienM | crinkle: L71 | 20:53 |
crinkle | of what | 20:53 |
EmilienM | rm_rf("spec/fixtures/modules/#{modname}") | 20:53 |
EmilienM | of https://review.openstack.org/226830 | 20:53 |
crinkle | i'm fine with that | 20:53 |
EmilienM | crinkle: so I guess https://review.openstack.org/226830 is fine for you now | 20:54 |
EmilienM | if it pass CI and if you're fine with the deps | 20:54 |
crinkle | i think so | 20:54 |
EmilienM | hmm wait | 20:54 |
*** angdraug has joined #puppet-openstack | 20:55 | |
EmilienM | crinkle: who is in charge of cleaning spec/fixtures/modules if test pass? | 20:55 |
crinkle | EmilienM: spec_clean | 20:55 |
EmilienM | I dropped that code | 20:55 |
crinkle | why? | 20:55 |
EmilienM | I don't know | 20:56 |
EmilienM | it's a mistake of me | 20:56 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures https://review.openstack.org/226830 | 20:57 |
EmilienM | ok, let's wait and see if CI pass | 20:57 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures https://review.openstack.org/226830 | 21:01 |
mwhahaha | oh i think i figured it out | 21:02 |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Switch cinder to use os_service_default fact https://review.openstack.org/229095 | 21:04 |
mwhahaha | lets see if that works | 21:04 |
EmilienM | yeah :D | 21:04 |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Switch cinder to use os_service_default fact https://review.openstack.org/229095 | 21:04 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Fix README table markdown syntax https://review.openstack.org/231188 | 21:05 |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Switch cinder to use os_service_default fact https://review.openstack.org/229095 | 21:06 |
*** trown is now known as trown|outttypeww | 21:08 | |
*** zigo has quit IRC | 21:09 | |
*** spredzy has quit IRC | 21:09 | |
*** zigo has joined #puppet-openstack | 21:10 | |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-neutron: dbsync should only notify services that use the db https://review.openstack.org/231161 | 21:10 |
*** spredzy has joined #puppet-openstack | 21:11 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy & test Trove https://review.openstack.org/229450 | 21:14 |
EmilienM | there is a nice condition in puppet-cinder | 21:26 |
EmilienM | cinder type-create randomly fails: http://logs.openstack.org/71/231171/1/check/gate-puppet-openstack-integration-scenario001-dsvm-trusty/58abf5c/console.html#_2015-10-05_21_06_12_882 | 21:27 |
EmilienM | look at the timestamp, and look cinder api logs: http://logs.openstack.org/71/231171/1/check/gate-puppet-openstack-integration-scenario001-dsvm-trusty/58abf5c/logs/cinder/cinder-api.txt.gz#_2015-10-05_21_06_12_882 | 21:27 |
*** dfisher has quit IRC | 21:27 | |
EmilienM | cinder-api is not finished to start but puppet runs the Exec | 21:28 |
EmilienM | crinkle: like you said, testing is useful :) | 21:28 |
*** linkedinyou has quit IRC | 21:30 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-cinder: type: Add retry to Exec resource https://review.openstack.org/231197 | 21:34 |
EmilienM | crinkle: https://review.openstack.org/#/c/226830/ and its deps are ready for review | 21:35 |
*** devnull0 has quit IRC | 21:36 | |
*** angdraug has quit IRC | 22:09 | |
*** morazi has quit IRC | 22:10 | |
*** angdraug has joined #puppet-openstack | 22:11 | |
*** EmilienM sets mode: +o spredzy | 22:14 | |
*** openstackgerrit has quit IRC | 22:16 | |
*** rcarrillocruz has quit IRC | 22:17 | |
*** openstackgerrit has joined #puppet-openstack | 22:17 | |
mfisch | EmilienM: lets talk about https://review.openstack.org/#/c/231197 | 22:18 |
mfisch | we should be using the healthcheck stuff here right? | 22:18 |
*** rcarrillocruz has joined #puppet-openstack | 22:20 | |
*** bklei has quit IRC | 22:20 | |
EmilienM | mfisch: how that? | 22:20 |
mfisch | I think Yanis worked on this | 22:20 |
mfisch | https://github.com/puppet-community/puppet-healthcheck | 22:20 |
mfisch | you can put a dep on cinder being functional before those providers run | 22:21 |
EmilienM | wow, that's a new dependency | 22:21 |
mfisch | (also in our talk next week) | 22:21 |
EmilienM | indeed | 22:21 |
EmilienM | this is something that we could investigate | 22:21 |
EmilienM | for long term | 22:21 |
nibalizer | well note that healthcheck is super experimental | 22:21 |
EmilienM | yeah, that's why I said "wow" | 22:22 |
mfisch | we've been using it in prod for some time | 22:22 |
mfisch | our own version | 22:22 |
nibalizer | but I think openstack-puppet is on the cutting edge so if yall want to push this stuff I'm down | 22:22 |
mfisch | switched to that one recently | 22:22 |
nibalizer | wow | 22:22 |
mfisch | come to our talk on Thursday! | 22:22 |
nibalizer | so it was functionaly the same? | 22:22 |
mfisch | yeah | 22:22 |
nibalizer | oh right are yall here for puppetconf? | 22:22 |
nibalizer | when is openstackbeers | 22:22 |
mfisch | Thu? | 22:23 |
mfisch | I'm not in until Wed | 22:23 |
EmilienM | every night? | 22:23 |
nibalizer | EmilienM: my man! | 22:23 |
*** mdorman has quit IRC | 22:23 | |
EmilienM | mfisch: for short term, we should go ahead with https://review.openstack.org/231197 | 22:23 |
mfisch | sure | 22:23 |
EmilienM | mfisch: during the summit, we can talk about healthcheck. Can you create a topic? | 22:23 |
EmilienM | https://etherpad.openstack.org/p/HND-puppet | 22:24 |
mfisch | yeah where's the link... jinx | 22:24 |
mfisch | nibalizer: must remember rain jacket! | 22:24 |
mfisch | I forget it rains in other places sometimes | 22:24 |
EmilienM | is it raining in PDX ? | 22:24 |
mfisch | I assume always | 22:24 |
EmilienM | lol | 22:24 |
nibalizer | its actually super warm | 22:25 |
mfisch | 65 then | 22:25 |
mfisch | lol | 22:25 |
EmilienM | I'm off for tonight, cheers | 22:30 |
bkero | actually 81 | 22:30 |
bkero | (27) | 22:30 |
*** angdraug has quit IRC | 22:44 | |
openstackgerrit | Ivan Chavero proposed openstack/puppet-neutron: Split SR-IOV configuration file into driver and agent pieces https://review.openstack.org/221991 | 22:45 |
*** rgowrishankar has quit IRC | 22:57 | |
*** ducttape_ has quit IRC | 23:13 | |
*** ducttape_ has joined #puppet-openstack | 23:15 | |
*** jtomasek has quit IRC | 23:15 | |
*** ducttape_ has quit IRC | 23:15 | |
*** rahulait has quit IRC | 23:18 | |
*** pradk has quit IRC | 23:30 | |
*** angdraug has joined #puppet-openstack | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!