openstackgerrit | Merged openstack/puppet-ceilometer: Add required db subclass to README.md https://review.openstack.org/265049 | 00:03 |
---|---|---|
*** xarses has quit IRC | 00:04 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-cinder: Update tests to leverage rspec-puppet-facts https://review.openstack.org/242330 | 00:04 |
_ody | EmilienM: Can you point me at a failed job resulting from what https://review.openstack.org/#/c/266069 is reverting? | 00:04 |
_ody | I don't see failures from rabbitmq related things on the patch that was previously merged. | 00:05 |
EmilienM | _ody: all recent jobs | 00:05 |
EmilienM | look at https://review.openstack.org/266004 for example | 00:05 |
EmilienM | I reported the bug https://bugzilla.redhat.com/show_bug.cgi?id=1297580 | 00:06 |
openstack | bugzilla.redhat.com bug 1297580 in openstack-cinder "cinder GID is stolen by epmd" [Urgent,New] - Assigned to eharney | 00:06 |
EmilienM | but basically, all jobs for scenario001 on centos7 are failing because of this bug | 00:06 |
*** rahulait has quit IRC | 00:06 | |
EmilienM | you can look at all scenario001/centos7 jobs since 5th january | 00:07 |
EmilienM | _ody: ^ | 00:07 |
*** rahulait has joined #puppet-openstack | 00:07 | |
_ody | ok. I was just expecting to see it in the orginal change's related tests. | 00:07 |
_ody | I must just be overlooking something | 00:07 |
*** zhangjn has joined #puppet-openstack | 00:10 | |
*** zhangjn has quit IRC | 00:12 | |
*** xarses has joined #puppet-openstack | 00:17 | |
_ody | EmilienM: Is this a case where the init system claims rabbitmq launched successfully what it doesn't actually do so? I can see cinder is unable to connect to rabbitmq but I don't see the reason why. | 00:19 |
*** markvoelker has quit IRC | 00:20 | |
openstackgerrit | Merged openstack/puppet-neutron: Adds the ability to force metadata with dhcp agent https://review.openstack.org/265048 | 00:22 |
*** dgurtner has quit IRC | 00:24 | |
EmilienM | _ody: ok let me explain | 00:33 |
EmilienM | I did that patch because at the end we will want to have rabbitmq ready *before* any openstack service | 00:34 |
EmilienM | but the problem is https://bugzilla.redhat.com/show_bug.cgi?id=1297580 which is preventing us to do so | 00:34 |
openstack | bugzilla.redhat.com bug 1297580 in openstack-cinder "cinder GID is stolen by epmd" [Urgent,New] - Assigned to eharney | 00:34 |
EmilienM | when this bug ^ is fixed in Fedora, we'll be able to install rabbitmq before openstack (cinder included) | 00:35 |
EmilienM | and so the orchestration that we want | 00:35 |
EmilienM | but until that, we need a workaround (the revert I proposed) | 00:35 |
EmilienM | so we can have our integration jobs green | 00:35 |
EmilienM | in the meantime, if you observe openstack logs, you might notice openstack services can start before rabbitmq but they'll try to reconnect to amqp again | 00:36 |
EmilienM | thanks to something in oslo.messaging | 00:36 |
EmilienM | _ody: is it fine now? | 00:36 |
*** ntpttr has joined #puppet-openstack | 00:40 | |
openstackgerrit | Merged openstack/puppet-openstack-integration: Revert "rabbitmq: make sure RabbitMQ resources are created before running OpenStack" https://review.openstack.org/266069 | 00:46 |
*** ntpttr has left #puppet-openstack | 00:46 | |
*** angdraug has quit IRC | 00:52 | |
*** zhangjn has joined #puppet-openstack | 00:58 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: use new parameters to configure neutron/notifications https://review.openstack.org/264387 | 00:58 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Improve logging for OpenStack services https://review.openstack.org/265426 | 00:59 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: enable Aodh on ubuntu platform https://review.openstack.org/265061 | 01:00 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Test Mitaka on UCA & RDO https://review.openstack.org/255635 | 01:00 |
*** natarej_ has quit IRC | 01:11 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Test Mitaka on UCA & RDO https://review.openstack.org/255635 | 01:14 |
*** markvoelker has joined #puppet-openstack | 01:21 | |
*** markvoelker has quit IRC | 01:25 | |
*** markvoelker has joined #puppet-openstack | 01:25 | |
openstackgerrit | Xiaohua Yuan proposed openstack/puppet-designate: Add related parameters to designate::api https://review.openstack.org/260024 | 01:57 |
*** xingchao has joined #puppet-openstack | 02:01 | |
*** cwolferh has quit IRC | 02:32 | |
*** zhangjn has quit IRC | 02:43 | |
*** ilbot3 has quit IRC | 02:45 | |
*** zhangjn has joined #puppet-openstack | 02:48 | |
*** ilbot3 has joined #puppet-openstack | 02:48 | |
*** xingchao_ has joined #puppet-openstack | 02:50 | |
*** xingchao has quit IRC | 02:52 | |
*** rahulait has quit IRC | 02:58 | |
*** zhangjn has quit IRC | 02:58 | |
*** zhangjn has joined #puppet-openstack | 03:05 | |
*** spredzy has quit IRC | 03:07 | |
*** spredzy has joined #puppet-openstack | 03:10 | |
*** zhangjn has quit IRC | 03:15 | |
openstackgerrit | Merged openstack/puppet-openstack-integration: Provide a toggle to disable repository management by puppet https://review.openstack.org/258136 | 03:17 |
openstackgerrit | Merged openstack/puppet-murano: Change default admin_user and admin_tenant_name https://review.openstack.org/254250 | 03:18 |
*** zhangjn has joined #puppet-openstack | 03:19 | |
openstackgerrit | Merged openstack/puppet-keystone: Fix multiple typos in README https://review.openstack.org/265812 | 03:38 |
*** baker has joined #puppet-openstack | 03:45 | |
*** cwolferh has joined #puppet-openstack | 03:46 | |
*** michchap has quit IRC | 03:52 | |
*** baker_ has joined #puppet-openstack | 03:52 | |
*** baker has quit IRC | 03:55 | |
*** zhangjn has quit IRC | 03:56 | |
*** michchap has joined #puppet-openstack | 03:56 | |
*** cwolferh has quit IRC | 04:03 | |
openstackgerrit | Xingchao Yu proposed openstack/puppet-nova: Change section name for memcached_servers param https://review.openstack.org/266136 | 04:04 |
*** rahulait has joined #puppet-openstack | 04:27 | |
*** morazi has joined #puppet-openstack | 04:30 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-aodh: Add rspec-puppet-facts to the spec_helper https://review.openstack.org/264538 | 04:38 |
openstackgerrit | Alex Schultz proposed openstack/puppet-aodh: Update tests to leverage rspec-puppet-facts https://review.openstack.org/266142 | 04:38 |
*** cwolferh has joined #puppet-openstack | 04:42 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-aodh: Update tests to leverage rspec-puppet-facts https://review.openstack.org/266142 | 04:46 |
*** richm has quit IRC | 04:49 | |
*** markvoelker has quit IRC | 04:58 | |
*** michchap has quit IRC | 05:14 | |
*** michchap has joined #puppet-openstack | 05:15 | |
*** zerda has joined #puppet-openstack | 05:25 | |
*** Guest8334 is now known as saneax_AFK | 05:32 | |
*** zhangjn has joined #puppet-openstack | 05:35 | |
*** v1k0d3n has quit IRC | 05:42 | |
*** jaosorior has joined #puppet-openstack | 05:47 | |
*** zhangjn has quit IRC | 05:48 | |
*** zhangjn has joined #puppet-openstack | 05:50 | |
*** markvoelker has joined #puppet-openstack | 05:59 | |
*** saneax_AFK is now known as saneax | 06:01 | |
*** saneax is now known as Guest53927 | 06:02 | |
*** rahulait has quit IRC | 06:04 | |
*** markvoelker has quit IRC | 06:06 | |
*** baker_ has quit IRC | 06:10 | |
*** zhangjn has quit IRC | 06:35 | |
*** zhangjn has joined #puppet-openstack | 06:35 | |
*** zhangjn_ has joined #puppet-openstack | 06:38 | |
*** zhangjn has quit IRC | 06:40 | |
*** jaosorior has quit IRC | 06:48 | |
*** xingchao has joined #puppet-openstack | 06:51 | |
*** xingchao_ has quit IRC | 06:53 | |
*** xingchao_ has joined #puppet-openstack | 07:01 | |
*** xingchao has quit IRC | 07:04 | |
*** jaosorior has joined #puppet-openstack | 07:09 | |
*** zhangjn_ has quit IRC | 07:23 | |
*** zhangjn has joined #puppet-openstack | 07:30 | |
*** degorenko has joined #puppet-openstack | 07:52 | |
openstackgerrit | Christian Schwede proposed openstack/puppet-gnocchi: Add missing metricd service https://review.openstack.org/265772 | 07:55 |
*** jpena has joined #puppet-openstack | 07:56 | |
*** jpena is now known as jpena|mtg | 07:56 | |
*** jtomasek has joined #puppet-openstack | 07:57 | |
*** dgurtner has joined #puppet-openstack | 08:00 | |
*** jistr has joined #puppet-openstack | 08:06 | |
*** jistr is now known as jistr|doc | 08:07 | |
*** foxhunt_away is now known as foxhunt72 | 08:08 | |
*** zhangjn has quit IRC | 08:14 | |
*** zhangjn has joined #puppet-openstack | 08:16 | |
*** karimb has joined #puppet-openstack | 08:19 | |
openstackgerrit | Christian Schwede proposed openstack/puppet-gnocchi: Add missing metricd service https://review.openstack.org/265772 | 08:26 |
*** samuelBartel has joined #puppet-openstack | 08:27 | |
*** zhangjn has quit IRC | 08:50 | |
openstackgerrit | Merged openstack/puppet-openstack-integration: use new parameters to configure neutron/notifications https://review.openstack.org/264387 | 08:52 |
*** xingchao has joined #puppet-openstack | 08:52 | |
*** xingchao_ has quit IRC | 08:55 | |
*** zhangjn has joined #puppet-openstack | 08:58 | |
*** jistr|doc has quit IRC | 08:59 | |
*** karimb has quit IRC | 09:02 | |
openstackgerrit | Xingchao Yu proposed openstack/puppet-glance: Add memcached_servers parameter https://review.openstack.org/266248 | 09:05 |
*** imcsk8 is now known as imcsk8|zZz | 09:05 | |
openstackgerrit | Denis Egorenko proposed openstack/puppet-heat: Switch Heat to $::os_service_default - part 2 https://review.openstack.org/249711 | 09:09 |
*** gfidente has joined #puppet-openstack | 09:11 | |
*** gfidente has quit IRC | 09:11 | |
*** gfidente has joined #puppet-openstack | 09:11 | |
*** xarses has quit IRC | 09:12 | |
*** xarses has joined #puppet-openstack | 09:13 | |
*** xarses has quit IRC | 09:13 | |
*** xarses has joined #puppet-openstack | 09:14 | |
*** xarses has quit IRC | 09:14 | |
*** xarses has joined #puppet-openstack | 09:15 | |
*** openstackgerrit has quit IRC | 09:17 | |
*** openstackgerrit has joined #puppet-openstack | 09:18 | |
*** jistr has joined #puppet-openstack | 09:20 | |
*** igajsin has joined #puppet-openstack | 09:22 | |
*** igajsin has quit IRC | 09:27 | |
*** karimb has joined #puppet-openstack | 09:27 | |
*** chem has joined #puppet-openstack | 09:28 | |
*** paramite has joined #puppet-openstack | 09:32 | |
*** derekh has joined #puppet-openstack | 09:35 | |
*** zhangjn has quit IRC | 09:37 | |
*** igajsin has joined #puppet-openstack | 09:37 | |
openstackgerrit | tobe proposed openstack/puppet-keystone: Use recommended abbreviation of the classes https://review.openstack.org/266259 | 09:38 |
*** clayton has quit IRC | 09:51 | |
*** clayton has joined #puppet-openstack | 09:51 | |
*** dh64 has quit IRC | 09:52 | |
*** morazi has quit IRC | 09:52 | |
*** dh64 has joined #puppet-openstack | 09:53 | |
*** derekh has quit IRC | 09:54 | |
*** derekh has joined #puppet-openstack | 09:55 | |
*** social has quit IRC | 09:55 | |
*** social has joined #puppet-openstack | 09:55 | |
*** morazi has joined #puppet-openstack | 09:56 | |
*** markvoelker has joined #puppet-openstack | 10:02 | |
*** igajsin has quit IRC | 10:03 | |
*** igajsin has joined #puppet-openstack | 10:05 | |
*** markvoelker has quit IRC | 10:07 | |
*** igajsin has quit IRC | 10:12 | |
*** morazi has quit IRC | 10:15 | |
*** derekh has quit IRC | 10:16 | |
*** vinsh_ has joined #puppet-openstack | 10:16 | |
*** xingchao_ has joined #puppet-openstack | 10:18 | |
*** derekh has joined #puppet-openstack | 10:19 | |
*** vinsh has quit IRC | 10:19 | |
*** morazi has joined #puppet-openstack | 10:19 | |
*** xingchao has quit IRC | 10:21 | |
*** igajsin has joined #puppet-openstack | 10:25 | |
*** rochaporto has joined #puppet-openstack | 10:30 | |
*** paramite is now known as paramite|afk | 10:30 | |
openstackgerrit | Gael Chamoulaud proposed openstack/puppet-heat: [WIP] Revise keystone/trusts config to avoid deprecated options https://review.openstack.org/265865 | 10:31 |
*** xingchao_ has quit IRC | 10:37 | |
*** jaosorior has quit IRC | 10:55 | |
*** jaosorior has joined #puppet-openstack | 10:55 | |
*** zhangjn has joined #puppet-openstack | 11:00 | |
openstackgerrit | Liao Penghui proposed openstack/puppet-keystone: Fix bug for wrong config section of ssl configs. https://review.openstack.org/266295 | 11:11 |
*** yottatsa has quit IRC | 11:11 | |
*** openstackgerrit has quit IRC | 11:17 | |
*** openstackgerrit has joined #puppet-openstack | 11:18 | |
openstackgerrit | Merged openstack/puppet-gnocchi: Add missing metricd service https://review.openstack.org/265772 | 11:23 |
openstackgerrit | Merged openstack/puppet-vitrage: Update typo https://review.openstack.org/263177 | 11:25 |
openstackgerrit | Merged openstack/puppet-zaqar: Update typo https://review.openstack.org/263176 | 11:27 |
openstackgerrit | Merged openstack/puppet-barbican: Update typo https://review.openstack.org/263185 | 11:28 |
*** zhangjn has quit IRC | 11:30 | |
openstackgerrit | Merged openstack/puppet-ceilometer: Improve format of the documentations. https://review.openstack.org/265670 | 11:31 |
openstackgerrit | Merged openstack/puppet-aodh: Update typo https://review.openstack.org/263186 | 11:31 |
openstackgerrit | Merged openstack/puppet-gnocchi: Update typo https://review.openstack.org/263183 | 11:32 |
*** zerda has quit IRC | 11:35 | |
*** dalees has quit IRC | 11:37 | |
*** _nick is now known as yankcrime | 11:41 | |
openstackgerrit | yuan.lu proposed openstack/puppet-cinder: Fix wrong location for lock_path of params https://review.openstack.org/266308 | 11:42 |
*** IvanBerezovskiy1 has joined #puppet-openstack | 11:43 | |
*** jaosorior has quit IRC | 11:49 | |
*** jaosorior has joined #puppet-openstack | 11:50 | |
*** markvoelker has joined #puppet-openstack | 12:03 | |
*** dgurtner has quit IRC | 12:07 | |
*** dgurtner has joined #puppet-openstack | 12:07 | |
*** dgurtner has quit IRC | 12:07 | |
*** dgurtner has joined #puppet-openstack | 12:07 | |
*** markvoelker has quit IRC | 12:08 | |
*** IvanBerezovskiy1 has quit IRC | 12:10 | |
*** dalees has joined #puppet-openstack | 12:11 | |
*** IvanBerezovskiy1 has joined #puppet-openstack | 12:12 | |
*** zhangjn has joined #puppet-openstack | 12:14 | |
openstackgerrit | Liao Penghui proposed openstack/puppet-keystone: Fix bug for wrong config section of ssl configs. https://review.openstack.org/266295 | 12:16 |
EmilienM | hello | 12:22 |
*** paramite|afk is now known as paramite | 12:24 | |
EmilienM | degorenko: hey, have you looked at https://etherpad.openstack.org/p/puppet-openstack-ci-mitaka ? We have some sahara issues on master | 12:27 |
*** iurygregory has joined #puppet-openstack | 12:37 | |
degorenko | EmilienM, hey, yeah, i saw your letter on openstack-dev list, i'm trying find out what's wrong | 12:37 |
*** zhangjn has quit IRC | 12:49 | |
*** dprince has joined #puppet-openstack | 12:58 | |
*** markvoelker has joined #puppet-openstack | 13:04 | |
*** ducttape_ has quit IRC | 13:08 | |
*** ducttape_ has joined #puppet-openstack | 13:09 | |
*** derekh has quit IRC | 13:11 | |
*** dgurtner_ has joined #puppet-openstack | 13:13 | |
*** dgurtner_ has quit IRC | 13:13 | |
*** dgurtner_ has joined #puppet-openstack | 13:13 | |
openstackgerrit | Martin Mágr proposed openstack/puppet-neutron: LBaaSv2 support https://review.openstack.org/234728 | 13:14 |
*** markvoelker has quit IRC | 13:15 | |
*** dgurtner has quit IRC | 13:15 | |
*** derekh has joined #puppet-openstack | 13:16 | |
*** narasimhasv has joined #puppet-openstack | 13:22 | |
*** jayg|g0n3 is now known as jayg | 13:22 | |
EmilienM | degorenko: are you able to reproduce? | 13:22 |
EmilienM | degorenko: I can help you to reproduce | 13:22 |
EmilienM | degorenko: you follow https://github.com/openstack/puppet-openstack-integration#all-in-one | 13:23 |
EmilienM | but before running all-in-one.sh, you change the scenario in the script. Sahara is in scenario002. Also you need to run on centos7 | 13:23 |
openstackgerrit | Denis Egorenko proposed openstack/puppet-heat: Use identity_uri and auth_uri by default https://review.openstack.org/261326 | 13:27 |
degorenko | EmilienM, i'm able to reproduce | 13:27 |
*** omartsyniuk_ has joined #puppet-openstack | 13:27 | |
degorenko | some internal tasks | 13:27 |
*** ducttape_ has quit IRC | 13:27 | |
degorenko | i'm going to run second deploy | 13:27 |
degorenko | for scenario002 | 13:27 |
*** trown|outttypeww is now known as trown | 13:28 | |
degorenko | EmilienM, btw, for sahara floating bug - as developers said me - it can be problem with pymysql driver in sahara, or in pymysql driver :) that's all what i have | 13:29 |
*** narasimhasv has quit IRC | 13:33 | |
*** markvoelker has joined #puppet-openstack | 13:35 | |
degorenko | EmilienM, and i've reproduced problem with sahara on mitaka. Looks like package problem. | 13:37 |
EmilienM | degorenko: any logs? | 13:37 |
EmilienM | degorenko: join #rdo if packaging problem | 13:37 |
degorenko | EmilienM, the same as you gave - ImportError: cannot import name main | 13:37 |
EmilienM | degorenko: that's a weird error | 13:38 |
degorenko | after when i will find problem | 13:38 |
*** zhangjn has joined #puppet-openstack | 13:39 | |
*** zhangjn has quit IRC | 13:39 | |
*** zhangjn has joined #puppet-openstack | 13:39 | |
degorenko | EmilienM, lol, on my env heat, neutron and glance are also dead | 13:42 |
EmilienM | yeah? weird | 13:43 |
iurygregory | crazy things o.o | 13:43 |
degorenko | EmilienM, you also have this problem | 13:45 |
degorenko | take a look | 13:45 |
degorenko | http://logs.openstack.org/35/255635/15/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7/b42f618/console.html#_2016-01-12_01_21_42_296 | 13:45 |
degorenko | random line | 13:45 |
degorenko | glance, ironic and etc | 13:45 |
degorenko | really looks like package problem | 13:46 |
degorenko | the same for neutron | 13:46 |
EmilienM | degorenko: it's not a n issue | 13:46 |
EmilienM | this line is not an issue AFIK, I've seen that lot of times | 13:47 |
degorenko | EmilienM, what's about log files then: http://logs.openstack.org/35/255635/15/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7/b42f618/logs/glance/api.txt.gz#_2016-01-12_01_31_19_157 | 13:48 |
EmilienM | degorenko: this one is a valid error | 13:48 |
degorenko | ok, then continue investigating sahara problem | 13:49 |
*** iurygregory has left #puppet-openstack | 13:50 | |
*** iurygregory has joined #puppet-openstack | 13:50 | |
*** jpena|mtg has quit IRC | 13:51 | |
EmilienM | degorenko: if you have anything blocking in rdo, go ahead on #rdo channel, they are very responsive | 13:51 |
openstackgerrit | Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv https://review.openstack.org/265357 | 13:54 |
*** xingchao has joined #puppet-openstack | 13:55 | |
*** karimb has quit IRC | 13:59 | |
degorenko | EmilienM, i've found problem | 13:59 |
degorenko | service py files are empty | 14:00 |
EmilienM | degorenko: w00t ? | 14:00 |
degorenko | take a look on rdo chat | 14:01 |
degorenko | i've posted link to paste.openstack | 14:01 |
*** jpena|mtg has joined #puppet-openstack | 14:02 | |
openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: [WIP] Add possibility to use mod_proxy for radosgw https://review.openstack.org/266027 | 14:04 |
*** karimb has joined #puppet-openstack | 14:05 | |
*** richm has joined #puppet-openstack | 14:10 | |
openstackgerrit | Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv https://review.openstack.org/265357 | 14:11 |
openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: [WIP] Add possibility to use mod_proxy for radosgw https://review.openstack.org/266027 | 14:19 |
*** Guest53927 is now known as saneax_AFK | 14:21 | |
openstackgerrit | Xingchao Yu proposed openstack/puppet-glance: Add memcached_servers parameter https://review.openstack.org/266248 | 14:26 |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: Use HAProxy 'transparent' bind option instead of sysctl ip_nonlocal https://review.openstack.org/265309 | 14:28 |
*** karimb_ has joined #puppet-openstack | 14:35 | |
*** karimb_ has quit IRC | 14:35 | |
*** karimb has quit IRC | 14:38 | |
*** mdorman has joined #puppet-openstack | 14:39 | |
*** jaosorior has quit IRC | 14:40 | |
openstackgerrit | Lukas Bezdicka proposed openstack/puppet-neutron: Install service packages on api nodes https://review.openstack.org/200877 | 14:41 |
EmilienM | our weekly meeting will start in 15 min on #openstack-meeting-4, you can look at our agenda: https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-20160112 | 14:44 |
*** kbyrne has quit IRC | 14:46 | |
EmilienM | social: do you have an update to give on https://review.openstack.org/182281 ? | 14:48 |
EmilienM | do you need some help? | 14:48 |
degorenko | EmilienM, my patch for sahara is merged :) waiting for updated package and will try to run tests again :) | 14:50 |
EmilienM | degorenko: cool | 14:50 |
*** mkarpin has joined #puppet-openstack | 14:50 | |
*** mwoodson has quit IRC | 14:50 | |
*** mwoodson has joined #puppet-openstack | 14:51 | |
*** astupnikov has joined #puppet-openstack | 14:51 | |
mflobo | Hi EmilienM, question about gerrit process | 14:52 |
mflobo | EmilienM, what I need to move forward with puppet-ec2api puppet modules? https://review.openstack.org/#/c/252959/ and https://review.openstack.org/#/c/251857/ | 14:53 |
_ody | SURPRISE! I got out of bed before meeeting time today. | 14:54 |
mflobo | EmilienM, maybe just wait for more +1s ? :) | 14:54 |
mflobo | oh, right, meeting now | 14:54 |
_ody | mflobo: Bringing them up in my browser, I'll review them with my first cup of coffee. | 14:55 |
mflobo | _ody, thanks | 14:55 |
_ody | and we'll need to ping infra too, they have to merge. | 14:56 |
degorenko | will look these patches too | 14:57 |
*** ducttape_ has joined #puppet-openstack | 14:57 | |
*** mwoodson has quit IRC | 14:58 | |
mflobo | degorenko, thanks too! | 14:58 |
*** xarses has quit IRC | 14:59 | |
*** dfisher has joined #puppet-openstack | 15:02 | |
*** mwoodson has joined #puppet-openstack | 15:02 | |
openstackgerrit | Gael Chamoulaud proposed openstack/puppet-heat: Revise keystone/trusts config to avoid deprecated options https://review.openstack.org/265865 | 15:02 |
openstackgerrit | Merged openstack/puppet-cinder: Remove outdated scheduler_driver from documentation https://review.openstack.org/265691 | 15:04 |
*** skolekonov has quit IRC | 15:06 | |
*** skolekonov has joined #puppet-openstack | 15:06 | |
*** v1k0d3n has joined #puppet-openstack | 15:09 | |
openstackgerrit | Merged openstack/puppet-glance: Create glance::cache::logging class https://review.openstack.org/238096 | 15:11 |
EmilienM | gchamoul: feel free to join our upstream meeting if you need help on unit tests for swift | 15:18 |
gchamoul | EmilienM: yes I will join once the daughter will be back home from school | 15:19 |
openstackgerrit | Merged openstack/puppet-trove: Add rabbit_ha_queues option https://review.openstack.org/214458 | 15:21 |
*** baker has joined #puppet-openstack | 15:22 | |
openstackgerrit | Merged openstack/puppet-neutron: Rename admin_state_up method to avoid conflict with accessor https://review.openstack.org/265373 | 15:23 |
openstackgerrit | Merged openstack/puppet-neutron: Do not manage network, subnet, router resources if prefetch fails https://review.openstack.org/265386 | 15:23 |
openstackgerrit | Merged openstack/puppet-trove: Introduce amqp_durable_queues option https://review.openstack.org/214477 | 15:24 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Improve logging for OpenStack services https://review.openstack.org/265426 | 15:25 |
*** skolekonov has quit IRC | 15:26 | |
*** kbyrne has joined #puppet-openstack | 15:29 | |
*** kbyrne has quit IRC | 15:29 | |
*** kbyrne has joined #puppet-openstack | 15:30 | |
dmsimard | EmilienM: hmm, I think there's a problem with this line: https://github.com/openstack-infra/project-config/blob/master/jenkins/scripts/copy_puppet_logs.sh#L138 ? | 15:30 |
dmsimard | fails for me http://paste.openstack.org/show/483605/ | 15:30 |
EmilienM | dmsimard: upstream meeting | 15:30 |
dmsimard | oops, okay. | 15:30 |
*** imcsk8|zZz is now known as imcsk8 | 15:34 | |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Fix incorrect configuration for Murano Service Broker API https://review.openstack.org/254181 | 15:36 |
*** rahulait has joined #puppet-openstack | 15:37 | |
*** xarses has joined #puppet-openstack | 15:37 | |
EmilienM | dmsimard: weird, you're missing a variable I guess | 15:43 |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Fix bug for deprecated vnc options. https://review.openstack.org/266443 | 15:44 |
openstackgerrit | Merged openstack/puppet-murano: Fix incorrect default metadata_dir and api_url parameters https://review.openstack.org/255869 | 15:46 |
*** dhollinger has joined #puppet-openstack | 15:46 | |
dmsimard | EmilienM: found it, missing lsb_release command | 15:48 |
*** kbyrne has quit IRC | 15:50 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Test Mitaka on UCA & RDO https://review.openstack.org/255635 | 15:50 |
EmilienM | chem: ^ I added it in Depends-On | 15:51 |
*** saneax_AFK is now known as saneax | 15:53 | |
*** saneax is now known as Guest71407 | 15:53 | |
*** rochaporto has quit IRC | 15:57 | |
*** rochaporto has joined #puppet-openstack | 15:57 | |
EmilienM | dmsimard: cool | 16:02 |
*** astupnikov has quit IRC | 16:02 | |
_ody | gchamoul: Can you please shoot me a link to you failing tests so I can throw it on my queue to look at? | 16:03 |
gchamoul | _ody: https://review.openstack.org/#/c/250233/ | 16:04 |
gchamoul | _ody: that's not related by code introduction in puppet-swift ... but some rspec tests were failing since puppet 4.3.0 came out and that change was expecting to fix that | 16:06 |
openstackgerrit | Ricardo Carrillo Cruz proposed openstack/puppet-ironic: Allow passing the whole contents of bifrost_global_vars https://review.openstack.org/222914 | 16:07 |
_ody | gotcha. They unified some of the parser code in 4.3 and it caused us (Puppet OpenStack) some issues. More than I'd expect from a point release. | 16:08 |
*** kbyrne has joined #puppet-openstack | 16:09 | |
openstackgerrit | Lukas Bezdicka proposed openstack/puppet-ceilometer: Support identity_uri and auth_uri properly and add auth_version option https://review.openstack.org/182281 | 16:12 |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Change SSL options to [ssl] section. https://review.openstack.org/266454 | 16:12 |
*** zhangjn has quit IRC | 16:13 | |
openstackgerrit | yuan.lu proposed openstack/puppet-cinder: Fix wrong location for lock_path of params https://review.openstack.org/266308 | 16:17 |
openstackgerrit | Merged openstack/puppet-openstack_extras: Add os_service_default fact for tests https://review.openstack.org/265472 | 16:18 |
_ody | gchamoul: I think it is a bug in puppet. | 16:25 |
gchamoul | _ody: so if it is, it affects puppet 4.3.0 and 4.3.1 | 16:28 |
*** degorenko is now known as _degorenko|afk | 16:30 | |
*** foxhunt72 is now known as foxhunt_away | 16:33 | |
_ody | gchamoul: It does indeed. | 16:34 |
_ody | https://tickets.puppetlabs.com/browse/PUP-5660 | 16:35 |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Make Horizon DB sync optional https://review.openstack.org/262011 | 16:36 |
gchamoul | _ody: thx | 16:41 |
openstackgerrit | Merged openstack/puppet-keystone: Use recommended abbreviation of the classes https://review.openstack.org/266259 | 16:41 |
_ody | gchamoul: I escalated internally and got word that fixes are coming soon. Final regression tests will be ready tomorrow. | 16:42 |
openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: Add possibility to use mod_proxy for radosgw https://review.openstack.org/266027 | 16:43 |
gchamoul | _ody: so no way to workaround before the fix, right? | 16:43 |
_ody | no | 16:43 |
*** jpena|mtg has quit IRC | 16:45 | |
*** derekh has quit IRC | 16:46 | |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-murano: Fix incorrect configuration for Murano Service Broker API https://review.openstack.org/254181 | 16:46 |
openstackgerrit | Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv https://review.openstack.org/265357 | 16:47 |
dmsimard | EmilienM: I don't think this line is necessary if you add read privileges to all the files in the command right after: https://github.com/openstack-infra/project-config/blob/master/jenkins/scripts/copy_puppet_logs.sh#L168 | 16:48 |
dmsimard | mind if I remove it ? | 16:48 |
EmilienM | dmsimard: we need directory access which is given by "x" I think | 16:50 |
dmsimard | EmilienM: We can set all folders to 755 and files to 644 I guess | 16:51 |
EmilienM | yeah | 16:51 |
dmsimard | ok i'll figure something out and submit it - ty | 16:51 |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Fix bug for deprecated vnc options. https://review.openstack.org/266443 | 16:58 |
dmsimard | EmilienM: added you on https://review.openstack.org/266482 | 17:00 |
EmilienM | dmsimard: ack | 17:03 |
*** rochaporto has quit IRC | 17:03 | |
*** rochaporto has joined #puppet-openstack | 17:03 | |
*** rochaporto has quit IRC | 17:03 | |
*** rochaporto has joined #puppet-openstack | 17:03 | |
*** samuelBartel has quit IRC | 17:04 | |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-openstack-integration: [WIP] scenario002: enable application catalog service https://review.openstack.org/250436 | 17:09 |
openstackgerrit | yuan.lu proposed openstack/puppet-ceilometer: Set auth_region to $::os_service_default https://review.openstack.org/266489 | 17:09 |
openstackgerrit | yuan.lu proposed openstack/puppet-horizon: Improve format of the documentations. https://review.openstack.org/266504 | 17:37 |
*** xingchao has quit IRC | 17:42 | |
*** xingchao has joined #puppet-openstack | 17:42 | |
openstackgerrit | yuan.lu proposed openstack/puppet-ceilometer: Set auth_region to $::os_service_default https://review.openstack.org/266489 | 17:44 |
*** rochaporto has quit IRC | 17:45 | |
*** xingchao has quit IRC | 17:47 | |
*** xingchao has joined #puppet-openstack | 17:48 | |
EmilienM | \o/ mitaka jobs are green for scenario001/centos and scenario002/trusty | 17:48 |
*** xingchao has quit IRC | 17:48 | |
EmilienM | https://review.openstack.org/#/c/255635/ | 17:48 |
EmilienM | dmsimard: ^ | 17:48 |
*** xingchao has joined #puppet-openstack | 17:48 | |
dmsimard | EmilienM: wat? | 17:48 |
dmsimard | Oh | 17:49 |
dmsimard | I thought you said they were all green | 17:49 |
EmilienM | dmsimard: can you check if versions are good ? http://logs.openstack.org/35/255635/16/check/gate-puppet-openstack-integration-scenario001-tempest-dsvm-centos7/cfbb631/logs/rpm-qa.txt.gz | 17:49 |
*** paramite has quit IRC | 17:49 | |
iurygregory | yeah \o/ | 17:50 |
EmilienM | _degorenko|afk: I confirm chem's patch works for puppet-neutron | 17:50 |
*** IvanBerezovskiy1 has left #puppet-openstack | 17:52 | |
*** xingchao has quit IRC | 17:53 | |
*** foxhunt_away is now known as foxhunt72 | 17:55 | |
EmilienM | mwhahaha: fyi https://bugs.launchpad.net/puppet-nova/+bug/1533257 | 17:57 |
openstack | Launchpad bug 1533257 in puppet-nova "VNC options need to move to [vnc] section" [Medium,New] - Assigned to Liao Penghui (liaoishere) | 17:57 |
EmilienM | I think i'm going to work on it | 17:57 |
EmilienM | if nobody is already on it, because we have this warning for long time now | 17:57 |
mwhahaha | ok | 17:57 |
EmilienM | _degorenko|afk: ping https://bugs.launchpad.net/puppet-nova/+bug/1533269 for deprecations | 17:58 |
openstack | Launchpad bug 1533269 in puppet-nova "SSL options is deprecating and move to [ssl] section" [Undecided,Confirmed] - Assigned to Liao Penghui (liaoishere) | 17:58 |
*** iurygregory has left #puppet-openstack | 17:58 | |
*** iurygregory has joined #puppet-openstack | 17:58 | |
*** baker has quit IRC | 18:02 | |
*** trown is now known as trown|lunch | 18:02 | |
*** jistr has quit IRC | 18:03 | |
*** mkarpin has quit IRC | 18:03 | |
*** gfidente is now known as gfidente|afk | 18:11 | |
*** angdraug has joined #puppet-openstack | 18:16 | |
*** jaosorior has joined #puppet-openstack | 18:27 | |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Fix bug for deprecated vnc options. https://review.openstack.org/266443 | 18:29 |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Change SSL options to [ssl] section. https://review.openstack.org/266454 | 18:30 |
openstackgerrit | Liao Penghui proposed openstack/puppet-ceilometer: Move workers options to specific sctions. https://review.openstack.org/266523 | 18:32 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Test Mitaka on UCA & RDO https://review.openstack.org/255635 | 18:37 |
EmilienM | dmsimard: ^ will look results after my run | 18:37 |
dmsimard | EmilienM: cool | 18:37 |
EmilienM | hopefully sahara is fixed | 18:37 |
dmsimard | colonwq: got your email, will review today although I no longer have an environment to test it in | 18:37 |
dmsimard | EmilienM: would love your +1 on https://review.openstack.org/#/c/266482/ if you think it makes sense | 18:39 |
colonwq | dmsimard, thanks. I just put names together. I could ship you my Dockerfiles. They work well engough to pass the RHEL/CentOS tests. | 18:39 |
openstackgerrit | Liao Penghui proposed openstack/puppet-ceilometer: Move workers options to specific sctions. https://review.openstack.org/266523 | 18:39 |
*** dgurtner_ has quit IRC | 18:39 | |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Change SSL options to [ssl] section. https://review.openstack.org/266454 | 18:40 |
openstackgerrit | Liao Penghui proposed openstack/puppet-nova: Fix bug for deprecated vnc options. https://review.openstack.org/266443 | 18:41 |
dmsimard | colonwq: sure | 18:42 |
*** foxhunt72 is now known as foxhunt_away | 18:47 | |
*** jaosorior has quit IRC | 19:00 | |
*** jaosorior has joined #puppet-openstack | 19:00 | |
*** trown|lunch is now known as trown | 19:06 | |
*** guimaluf has joined #puppet-openstack | 19:10 | |
*** imcsk8 is now known as imcsk8|afk | 19:11 | |
dmsimard | colonwq: reviewed | 19:14 |
*** jaosorior has quit IRC | 19:31 | |
*** jaosorior has joined #puppet-openstack | 19:32 | |
*** xarses has quit IRC | 19:40 | |
*** xarses has joined #puppet-openstack | 19:41 | |
*** cwolferh has quit IRC | 19:42 | |
dmsimard | EmilienM: we have success on both scenario001 and scenario002 for mitaka trunk :) | 19:43 |
EmilienM | dmsimard: nice | 19:54 |
EmilienM | dmsimard: congrats | 19:54 |
EmilienM | dmsimard: can we promote ? :) | 19:59 |
mwhahaha | are we going to run liberty and mitaka jobs or are we just going to do a complete switch | 20:08 |
colonwq | dmsimard, Thanks. I saw them just as I left for lunch. I will work on correcting the issues. | 20:09 |
EmilienM | mwhahaha: complete I hope | 20:09 |
EmilienM | mwhahaha: we're close. | 20:09 |
EmilienM | only aodh is failing now on trusty | 20:10 |
mwhahaha | personally i'd like to have both | 20:10 |
mwhahaha | but ok | 20:10 |
dmsimard | EmilienM: I'd love to have tripleo coverage on it first | 20:10 |
EmilienM | mwhahaha: me too! | 20:10 |
EmilienM | dmsimard: otherwise, I'll keep using this delorean URL | 20:10 |
EmilienM | until you have a promoted repo that works | 20:10 |
EmilienM | if I keep using this URL, it should be stable no? | 20:11 |
EmilienM | except if you update deps I guess | 20:11 |
dmsimard | EmilienM: well, stable in the sense that it won't change | 20:11 |
dmsimard | deps don't move that much | 20:11 |
*** gfidente|afk has quit IRC | 20:11 | |
EmilienM | cool it works for me | 20:11 |
dmsimard | but we will create a mitaka one soon I believe | 20:11 |
EmilienM | as long we run mitaka | 20:11 |
EmilienM | so maybe aodh is fixed by today | 20:12 |
EmilienM | I'm working on it | 20:12 |
*** dprince has quit IRC | 20:23 | |
*** baker has joined #puppet-openstack | 20:25 | |
*** rahulait has quit IRC | 20:31 | |
mfisch | Anyone know why puppet-keystone calls this '/usr/bin/openstack domain show --format shell Default' like 50 times? | 20:41 |
mfisch | in a row? | 20:41 |
mfisch | EmilienM: % | 20:41 |
mfisch | richm: ^ | 20:41 |
mfisch | ? | 20:41 |
mfisch | oh wow its calling once per tenant | 20:43 |
mfisch | what a waste | 20:43 |
mfisch | and once per user | 20:43 |
*** jaosorior has quit IRC | 20:44 | |
mdorman | yeah. | 20:44 |
richm | mfisch: kilo? liberty? | 20:56 |
mfisch | kilo | 20:56 |
mfisch | kilo openstack we're on an older version of master puppet | 20:57 |
mfisch | I wonder why it needs a domain show per tenant | 20:57 |
mfisch | let me get a log | 20:57 |
mfisch | so much domain calls: https://gist.github.com/matthewfischer/00b382e0b42b2ca4e4f8 | 21:00 |
EmilienM | it would be great to know which commit you are in puppet-keystone | 21:02 |
mfisch | commit 849d18bc7dc73fb0aaca1f7baa0b25d95495ee56 | 21:03 |
mfisch | Author: Alex Schultz <aschultz@mirantis.com> | 21:03 |
mfisch | Date: Wed Dec 30 11:30:56 2015 -0700 | 21:03 |
mwhahaha | wasn't me :o | 21:03 |
mfisch | is this new behavior? | 21:03 |
mfisch | I just noticed but doesnt mean its new | 21:03 |
mwhahaha | i doubt it's new | 21:05 |
mwhahaha | would seem like a lack of caching or some scoping related thing when it goes to populate all of the resources defined | 21:06 |
*** rahulait has joined #puppet-openstack | 21:06 | |
mfisch | im curious why it needs to run once per project and once per user | 21:06 |
mfisch | in staging we had like 20 test domains and that was way way way worse | 21:07 |
mfisch | I had to clean them up | 21:07 |
mwhahaha | how many users do you have listed in your catalog? | 21:07 |
mfisch | it was spending 1/2 the puppet run in that code | 21:07 |
*** jayg is now known as jayg|g0n3 | 21:07 | |
mfisch | mwhahaha: looking | 21:07 |
*** rahulait has quit IRC | 21:08 | |
mfisch | 100ish | 21:08 |
mfisch | 80 projects | 21:08 |
mwhahaha | i want to say i ran accross this if you don't define the domain in the name or something | 21:09 |
mfisch | in the name of what? | 21:10 |
mfisch | we dont do anything with domains in puppet | 21:10 |
mwhahaha | to populate the resource | 21:10 |
mwhahaha | sec | 21:10 |
mwhahaha | https://github.com/openstack/puppet-keystone/blob/stable/kilo/lib/puppet/provider/keystone.rb#L53-L66 | 21:10 |
*** imcsk8|afk is now known as imcsk8 | 21:12 | |
mfisch | whats the relationship between this and projects/users? | 21:12 |
mwhahaha | wait are you on the kilo module or master? | 21:13 |
mwhahaha | nm just scrolled up | 21:14 |
mfisch | master | 21:14 |
mwhahaha | so i think it is related to the v3 stuff | 21:14 |
mfisch | well I agree | 21:14 |
mfisch | I just want to know what its doing | 21:14 |
mwhahaha | i ran into something similar | 21:14 |
mfisch | domain show doesn't take a tenant for context does it? | 21:14 |
mwhahaha | there's also https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L116-L120 | 21:14 |
mfisch | if domain show doesnt pass in a tenant or user there's no point to call it 500 times | 21:15 |
mwhahaha | I'm not sure it's related to what I saw (because i thought it was fixed) but what I ran into was it was trying to populate the default domains tuff | 21:15 |
mwhahaha | let me see if i can find the change I had related to my problem | 21:15 |
mfisch | it all works, I should be clear on that | 21:16 |
mfisch | just seems unncessary | 21:16 |
mwhahaha | wonder if it was https://bugs.launchpad.net/puppet-keystone/+bug/1517187 | 21:18 |
openstack | Launchpad bug 1517187 in puppet-keystone "Default domain not calculated when no keystone_user/keystone_tenant/keystone_user_role is defined." [Critical,Fix committed] - Assigned to Sofer Athlan-Guyot (sofer-athlan-guyot) | 21:18 |
mwhahaha | so if you're not providing the default domain it goes and pulls it or something | 21:18 |
*** jtomasek has quit IRC | 21:18 | |
*** itsuugo has quit IRC | 21:18 | |
mwhahaha | or something to that effect | 21:18 |
mwhahaha | where it's something that was introduced with the v2/v3 support magic in the providers | 21:19 |
mfisch | so its mad that my keystone resources have no domain specified? | 21:20 |
*** itsuugo has joined #puppet-openstack | 21:20 | |
mwhahaha | it might be, the provider magic that we do around these is so hard to follow :/ | 21:21 |
*** ntpttr has joined #puppet-openstack | 21:21 | |
mwhahaha | https://review.openstack.org/#/c/244900/ or it might be related to that | 21:21 |
mwhahaha | that was my problem | 21:21 |
mwhahaha | forgot it was in neutron and it tries to pull keystone tenant stuff | 21:21 |
mwhahaha | mfisch: i bet it's from https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L215-L229 which always gets called | 21:31 |
*** dgurtner has joined #puppet-openstack | 21:36 | |
*** dgurtner has quit IRC | 21:36 | |
*** dgurtner has joined #puppet-openstack | 21:36 | |
*** cwolferh has joined #puppet-openstack | 21:38 | |
*** foxhunt_away is now known as foxhunt72 | 21:40 | |
mfisch | looking | 21:43 |
mfisch | mwhahaha: under what context is that used, for iterating projects/users? | 21:44 |
mwhahaha | i have no idea i can't find a reference to it | 21:45 |
mfisch | me either | 21:45 |
mwhahaha | but those are the only two places where domain show is done as far as i can tell | 21:46 |
mfisch | that code has to be unused | 21:48 |
mwhahaha | yea i think it's coming from the domain_name_from_id | 21:48 |
mwhahaha | which is part of keystone_tenant, keystone_user and keystone_user_role | 21:48 |
mwhahaha | also your gist has a domain of 'Default' in it | 21:48 |
mfisch | yep | 21:49 |
mfisch | but domain_name_from_id should cache | 21:50 |
mfisch | it tries to anyway | 21:50 |
mwhahaha | https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone_tenant/openstack.rb#L72-L83 | 21:50 |
openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Remove unused provider code https://review.openstack.org/266585 | 21:51 |
mfisch | lets see if its really used ^ | 21:51 |
mwhahaha | it should but i wonder are the best practices for doing caching on such things | 21:51 |
mfisch | I dont know enough ruby but is that hash not getting saved? | 21:52 |
mfisch | @foo means basically static method var right? | 21:53 |
mfisch | (I should not use the Cism) | 21:53 |
*** trown is now known as trown|outttypeww | 21:53 | |
mwhahaha | local scope var i think | 21:53 |
mfisch | does it stick around once filled? | 21:54 |
_ody | @ is an instance variable so scoped to the instance of the class the method belongs to | 22:02 |
mwhahaha | so basically it has to make the call for every instance of keystone_tenant, keystone_user and keystone_user_role right? | 22:08 |
*** TheBallPI has joined #puppet-openstack | 22:10 | |
TheBallPI | What's the best way to install the ceph-puppet moduel? https://github.com/openstack/puppet-ceph | 22:10 |
_ody | mwhahaha: With something that is self.method it should only be once, when the type/provider combo is first used. | 22:12 |
_ody | methods without self are contained to the instance of the resource. | 22:12 |
*** ntpttr has quit IRC | 22:12 | |
*** ntpttr has joined #puppet-openstack | 22:13 | |
mwhahaha | so is it because in keystone_tenant it is not called via self, it's not getting attached to the type/provider combo but instead contained to the instance of the resource? | 22:14 |
mwhahaha | but that wouldn't work for https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone_tenant/openstack.rb#L72-L83 because we could call it with multiple domains | 22:14 |
mwhahaha | so it seems as those the caching in keystone.rb need to be improved and the usage switched to self | 22:15 |
mwhahaha | to allow for caching multiple domains | 22:15 |
mwhahaha | oh nevermind it should be ok so we just need to update it to use self.domain_name_from_id | 22:16 |
mwhahaha | because it's using the ID for @domain_hash | 22:16 |
mwhahaha | mfisch: you should try updating the usages of domain_name_from_id to self.domain_name_from_id and see if it fixes it :D | 22:19 |
mfisch | I put some prints in the code | 22:25 |
mfisch | none of this block gets hit at all | 22:25 |
mfisch | https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L106-L109 | 22:25 |
mfisch | so I dont know where the shows come from | 22:25 |
*** cwolferh has quit IRC | 22:30 | |
*** ntpttr has quit IRC | 22:38 | |
*** baker_ has joined #puppet-openstack | 22:43 | |
*** baker has quit IRC | 22:45 | |
*** dhollinger has quit IRC | 22:47 | |
mfisch | mwhahaha: fetch_domain is what's being called over and over | 22:51 |
mfisch | and the caller of that is self.set_domain_for_name | 22:52 |
mfisch | which we couldn't figure out where it was called... | 22:52 |
openstackgerrit | David Gurtner proposed openstack/puppet-ceph: Override Service provider for mon and rgw services https://review.openstack.org/249267 | 22:52 |
*** cwolferh has joined #puppet-openstack | 22:56 | |
mwhahaha | hmmm | 22:59 |
mwhahaha | so it looks like that needs some caching or something | 23:03 |
*** ntpttr has joined #puppet-openstack | 23:03 | |
openstackgerrit | yuan.lu proposed openstack/puppet-ceilometer: Set auth_region to $::os_service_default https://review.openstack.org/266489 | 23:05 |
mfisch | mwhahaha: I found it | 23:06 |
mfisch | mwhahaha: set_domain_for_name is called by the user and project providers and does NO caching | 23:06 |
mfisch | mwhahaha: its not the id code | 23:06 |
mfisch | I will see if I can fix | 23:06 |
mwhahaha | well we can cache fetch_domain | 23:06 |
mwhahaha | that's the fix | 23:06 |
mwhahaha | we should only call fetch_domain once i would assume, the issue i guess is when we make changes to the domain but if we're only fetching the ID does is there anything that might cause problem? | 23:07 |
mwhahaha | but if the only thing we're looking for is domain -> ID which you can't change, caching shouldn't be a problem | 23:08 |
mfisch | what is set_domain_for_name returning | 23:08 |
mfisch | the lack of return foo is annoying me in ruby | 23:08 |
dfisher | the implicit "return the last thing you touched" thing? | 23:09 |
dfisher | because I *hate* that about Ruby. | 23:09 |
mfisch | yeah its just not as readable as it could be | 23:09 |
mwhahaha | @domain_hash[id] is what it's returning | 23:10 |
mfisch | we just need a reverse of the other hash | 23:10 |
mfisch | domain[name] = id | 23:10 |
mwhahaha | for fetch domain we should just do something similar to the @domain_hash elsewhere | 23:11 |
mfisch | Im debating if it makes sense in fetch_domain or in the domain_for_name code | 23:11 |
mwhahaha | the question i would have is what data is returned from fetch_domain | 23:12 |
mwhahaha | is it just a name and an id? | 23:12 |
mwhahaha | if so fetch domain should have a @domain_hash like in domain_name_from_id | 23:13 |
mwhahaha | where we key of a domain name | 23:13 |
mfisch | domain show has desc, enabled, id, and name | 23:13 |
mfisch | I think we only use id and name | 23:13 |
mwhahaha | so the issue comes in when domains are updated | 23:13 |
mfisch | I think thats all we need | 23:13 |
mfisch | domains should not be given a new ID | 23:13 |
mfisch | id <-> name shouldnt change | 23:13 |
mwhahaha | right | 23:14 |
mwhahaha | but enabled might | 23:14 |
mwhahaha | or name might | 23:14 |
mfisch | a name might be new or deleted | 23:14 |
mwhahaha | which fetch_domain also pulled | 23:14 |
mfisch | if domain[name] is not found, we run the show | 23:14 |
mfisch | that handles new domains, that handles renames | 23:14 |
mfisch | deletes fail regardless of cache | 23:14 |
mfisch | fail to lookup I mean | 23:14 |
mfisch | we're not using enabled are we? I didnt see it | 23:14 |
mwhahaha | not sure | 23:15 |
mfisch | let me hack up some code and try ity | 23:15 |
mwhahaha | that would be the only dangerous thing | 23:15 |
mwhahaha | description updates might have issues too | 23:16 |
mwhahaha | just pointing out where we need to be careful :) | 23:16 |
mfisch | unless we need those fields this new hash is just an exact opposite of the other hash | 23:19 |
mwhahaha | we could also create a new function to just fetch domain id | 23:20 |
mwhahaha | and only cache that | 23:20 |
mfisch | what I have so far | 23:25 |
mfisch | https://gist.github.com/matthewfischer/9a8a9b32be444a32f0a3 | 23:25 |
mwhahaha | so shouldn't it be self.domain_id_from_name | 23:25 |
mwhahaha | based on what _ody said previously? | 23:26 |
mfisch | thats what I have? | 23:26 |
mwhahaha | https://gist.github.com/matthewfischer/9a8a9b32be444a32f0a3#file-domain-diff-L34 | 23:26 |
mwhahaha | on line 34 | 23:26 |
mfisch | ah with a self | 23:26 |
mfisch | I wonder if they can share var names | 23:27 |
mwhahaha | probably not | 23:29 |
mwhahaha | unless it's doing the exact same thing | 23:29 |
mwhahaha | then i couldn't see why not | 23:29 |
mfisch | yeah agreed | 23:29 |
mwhahaha | well it's domain by name by id and domain id by name right? | 23:30 |
mwhahaha | they should be able to share | 23:30 |
mfisch | the hashes are backwards of each other keys and values switched | 23:30 |
mfisch | Error: Could not prefetch keystone_tenant provider 'openstack': can't convert Symbol into Integer | 23:31 |
mfisch | have a typo somewhere | 23:31 |
mwhahaha | There's probably an optimization to be had, i'd use two vars for now to prove it out :) | 23:31 |
mfisch | agree | 23:32 |
mfisch | I want to see it work first then I can improve it | 23:32 |
*** ntpttr has quit IRC | 23:36 | |
*** ntpttr has joined #puppet-openstack | 23:38 | |
*** logan2 has joined #puppet-openstack | 23:42 | |
*** logan2 is now known as logan- | 23:42 | |
*** angdraug has quit IRC | 23:48 | |
mdorman | mfisch: any particular reason you do the conversion to integer here? https://github.secureserver.net/cloudplatform/openstack-puppet-nova/blob/master/lib/puppet/provider/nova.rb#L201 with nova cells, the aggregate id’s look something like this: api!cell_01@22 so for my needs I need it treated like a string. | 23:49 |
*** ducttape_ has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!