| crinkle | mfisch: clayton do you still deploy designate in virtualenvs with puppet? or any other openstack services? | 00:04 |
|---|---|---|
| clayton | no, we deploy it in docker now | 00:14 |
| clayton | but it's a virtalenv inside the docker container | 00:15 |
| clayton | we use this code + the puppet-designate module - https://github.com/twc-openstack/puppet-os_docker | 00:15 |
| clayton | we also deploy heat and nova the same way | 00:21 |
| clayton | going to probably do neutron or keystone next | 00:21 |
| crinkle | clayton: hmm okay | 00:23 |
| *** rahulait has quit IRC | 00:24 | |
| *** xarses has quit IRC | 00:45 | |
| *** rcernin has quit IRC | 00:46 | |
| *** dfisher has quit IRC | 00:52 | |
| *** mdorman has quit IRC | 00:56 | |
| *** ducttape_ has joined #puppet-openstack | 01:15 | |
| *** xarses has joined #puppet-openstack | 01:23 | |
| *** nlahouti has quit IRC | 01:28 | |
| *** ducttape_ has quit IRC | 01:29 | |
| mfisch | is anyone using the neutron_router_interface provider? | 01:33 |
| *** rahulait has joined #puppet-openstack | 01:52 | |
| *** ducttape_ has joined #puppet-openstack | 02:01 | |
| *** angdraug has quit IRC | 02:26 | |
| *** ducttape_ has quit IRC | 02:29 | |
| *** ducttape_ has joined #puppet-openstack | 02:31 | |
| *** cwolferh has quit IRC | 02:31 | |
| *** ducttape_ has quit IRC | 02:39 | |
| *** brandon has quit IRC | 02:43 | |
| *** ilbot3 has quit IRC | 02:45 | |
| *** ilbot3 has joined #puppet-openstack | 02:48 | |
| *** ducttape_ has joined #puppet-openstack | 02:49 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add api_paste type/provider for Sahara https://review.openstack.org/281613 | 02:51 |
| *** kindjal has joined #puppet-openstack | 03:06 | |
| kindjal | Does anyone have an example of puppet-manila? | 03:06 |
| *** gildub has quit IRC | 03:11 | |
| *** rahulait has quit IRC | 03:14 | |
| *** ducttape_ has quit IRC | 03:30 | |
| *** gildub has joined #puppet-openstack | 03:35 | |
| *** ducttape_ has joined #puppet-openstack | 03:36 | |
| EmilienM | kindjal: https://github.com/openstack/puppet-manila/blob/master/spec/acceptance/basic_manila_spec.rb is a good start | 03:37 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-keystone: Mitaka master updates https://review.openstack.org/280385 | 03:45 |
| *** ducttape_ has quit IRC | 03:46 | |
| *** nlahouti has joined #puppet-openstack | 03:49 | |
| *** nlahouti1 has joined #puppet-openstack | 03:50 | |
| *** fedexo has joined #puppet-openstack | 03:52 | |
| *** nlahouti has quit IRC | 03:53 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 04:03 |
| *** ducttape_ has joined #puppet-openstack | 04:11 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 04:11 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Cinder with RBD backend https://review.openstack.org/281624 | 04:28 |
| *** ducttape_ has quit IRC | 04:28 | |
| *** richm has quit IRC | 04:30 | |
| *** saneax_AFK is now known as saneax | 04:34 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 04:46 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 04:47 |
| EmilienM | crinkle: I think we have an orchestration issue with the disable admin token class, I'm trying to solve it here: https://review.openstack.org/#/c/280385/ | 04:49 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-keystone: CI test - never merge https://review.openstack.org/281626 | 04:49 |
| EmilienM | and I think puppet-keystone gate is currently broken | 04:49 |
| EmilienM | crinkle: should we really require keystone::roles::admin ? | 04:50 |
| crinkle | EmilienM: require it where? | 04:52 |
| EmilienM | crinkle: https://github.com/openstack/puppet-keystone/blob/master/manifests/disable_admin_token_auth.pp#L15 | 04:52 |
| EmilienM | I think it can causes issue | 04:52 |
| EmilienM | all beaker tests are failing right now | 04:52 |
| EmilienM | because in some beaker tests, we change the default domain | 04:53 |
| EmilienM | and openrc needs to be updated but in the right order I think | 04:53 |
| crinkle | EmilienM: yes it needs to be required because the admin user needs to be created with the admin token before it gets disabled | 04:53 |
| crinkle | they were passing when we merged the thing | 04:53 |
| EmilienM | right, I'm sure I screwed up something | 04:54 |
| EmilienM | I'll dig tomorrow | 04:54 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 04:58 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 04:59 |
| EmilienM | I confirm puppet-keystone beaker jobs are broken: https://jenkins04.openstack.org/job/gate-puppet-keystone-puppet-beaker-rspec-dsvm-trusty/311/consoleFull | 05:00 |
| crinkle | EmilienM: can we maybe just keep that beaker test in the keystone module and remove it from the integration repo | 05:02 |
| EmilienM | crinkle: what do you want to remove from integ? the class? | 05:02 |
| EmilienM | revert https://github.com/openstack/puppet-openstack-integration/commit/becca2e139d389f579d5241e9dfa499267aeecec ? | 05:02 |
| crinkle | yes the disable_admin_token_auth class | 05:02 |
| EmilienM | crinkle: I would like to have this class in our integration tests though | 05:03 |
| EmilienM | I thought it might be useful to test it | 05:04 |
| EmilienM | with other components, like glance, neutron | 05:04 |
| EmilienM | crinkle: I can try to revert it | 05:07 |
| EmilienM | I'll dig a little bit more tomorrow. | 05:07 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 05:27 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 05:27 |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add api_paste type/provider for Sahara https://review.openstack.org/281613 | 05:32 |
| *** gildub has quit IRC | 06:13 | |
| *** furlongm has joined #puppet-openstack | 06:18 | |
| *** jaosorior has quit IRC | 06:23 | |
| *** jaosorior has joined #puppet-openstack | 06:24 | |
| *** nlahouti1 has quit IRC | 06:35 | |
| *** nlahouti has joined #puppet-openstack | 06:35 | |
| *** fedexo has quit IRC | 06:47 | |
| *** fedexo has joined #puppet-openstack | 06:54 | |
| *** rcernin has joined #puppet-openstack | 07:50 | |
| *** samuelBartel has quit IRC | 07:52 | |
| *** foxhunt_away is now known as foxhunt72 | 08:03 | |
| *** skolekonov_ has joined #puppet-openstack | 08:10 | |
| *** dgurtner has joined #puppet-openstack | 08:10 | |
| *** dgurtner has quit IRC | 08:10 | |
| *** dgurtner has joined #puppet-openstack | 08:10 | |
| *** jtomasek|afk is now known as jtomasek | 08:15 | |
| *** fedexo has quit IRC | 08:20 | |
| *** jpena has joined #puppet-openstack | 08:27 | |
| *** nlahouti has quit IRC | 08:28 | |
| *** leanderthal|afk is now known as leanderthal | 08:29 | |
| *** hjensas has joined #puppet-openstack | 08:42 | |
| *** hjensas has joined #puppet-openstack | 08:42 | |
| *** johnmilton has joined #puppet-openstack | 08:50 | |
| *** gfidente has joined #puppet-openstack | 09:10 | |
| *** igajsin1 has left #puppet-openstack | 09:15 | |
| *** paramite has joined #puppet-openstack | 09:32 | |
| *** samuelBartel has joined #puppet-openstack | 09:45 | |
| *** johnmilton has quit IRC | 09:51 | |
| *** derekh has joined #puppet-openstack | 09:56 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #puppet-openstack | 10:03 | |
| *** davideagle_ has joined #puppet-openstack | 10:29 | |
| *** dalees has quit IRC | 10:30 | |
| *** dalees has joined #puppet-openstack | 10:34 | |
| openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: Add possibility to use mod_proxy for radosgw https://review.openstack.org/266027 | 10:36 |
| *** aarefiev has quit IRC | 10:37 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add the capability to configure api-paste.ini with config.pp https://review.openstack.org/281756 | 10:47 |
| *** kindjal_ has joined #puppet-openstack | 10:57 | |
| *** kindjal has quit IRC | 10:57 | |
| *** kindjal_ is now known as kindjal | 10:57 | |
| *** _degorenko|afk is now known as degorenko | 11:01 | |
| *** andybotting has quit IRC | 11:09 | |
| *** aarefiev has joined #puppet-openstack | 11:11 | |
| *** davideagle_ has quit IRC | 11:22 | |
| *** davideagle_ has joined #puppet-openstack | 11:29 | |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add the capability to configure api-paste.ini with config.pp https://review.openstack.org/281756 | 11:34 |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add the capability to configure api-paste.ini with config.pp https://review.openstack.org/281756 | 11:37 |
| openstackgerrit | zhongshengping proposed openstack/puppet-sahara: Add the capability to configure api-paste.ini with config.pp https://review.openstack.org/281756 | 11:38 |
| EmilienM | hello | 12:40 |
| degorenko | hey o/ | 12:41 |
| EmilienM | degorenko: fyi, I'll me 100% off tomorrow | 12:42 |
| degorenko | EmilienM, ok, ack :) | 12:42 |
| EmilienM | degorenko: and fyi puppet-keystone beaker jobs are broken | 12:42 |
| EmilienM | https://review.openstack.org/#/c/281626/ | 12:43 |
| degorenko | that's not good :( | 12:43 |
| * degorenko looking | 12:43 | |
| EmilienM | because of https://review.openstack.org/280350 | 12:43 |
| *** johnmilton has joined #puppet-openstack | 12:43 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Glance with RBD backend https://review.openstack.org/281455 | 12:43 |
| EmilienM | I wanted to revert it but I think that's not good | 12:44 |
| EmilienM | we need to fix beaker | 12:44 |
| EmilienM | I'm trying to fix here: https://review.openstack.org/#/c/280385/ | 12:44 |
| EmilienM | but I failed until now | 12:44 |
| degorenko | how it passed then tests before? | 12:45 |
| degorenko | i'm about keystone_disable_admin_token_auth_spec.rb | 12:45 |
| degorenko | oh, we do nothing here | 12:45 |
| degorenko | i see | 12:46 |
| EmilienM | degorenko: crinkle did the patch before me in puppet-keystone https://review.openstack.org/256248 | 12:46 |
| degorenko | yeah, i've +2 it | 12:47 |
| *** dalees has quit IRC | 12:47 | |
| *** dalees has joined #puppet-openstack | 12:48 | |
| openstackgerrit | Merged openstack/puppet-tripleo: Upgrade all packages after puppet managed ones https://review.openstack.org/268257 | 12:49 |
| degorenko | EmilienM, looks like providers also use token_auth | 12:51 |
| *** davideagle_ has quit IRC | 12:54 | |
| *** morazi has joined #puppet-openstack | 12:54 | |
| *** ducttape_ has joined #puppet-openstack | 12:58 | |
| *** ducttape_ has quit IRC | 13:11 | |
| *** jayg|g0n3 is now known as jayg | 13:13 | |
| *** paramite is now known as paramite|afk | 13:13 | |
| *** jayg is now known as jayg|g0n3 | 13:14 | |
| *** jayg|g0n3 is now known as jayg | 13:14 | |
| *** karimb has joined #puppet-openstack | 13:20 | |
| openstackgerrit | James Slagle proposed openstack/puppet-tripleo: packages: secure upgrade workflow from dependency cycles https://review.openstack.org/281846 | 13:23 |
| *** alee_dinner has quit IRC | 13:23 | |
| gfidente | EmilienM, do you know if there is a reason why puppet-ceph doesn't allow setting of 'host=' key? | 13:26 |
| EmilienM | gfidente: no idea | 13:26 |
| gfidente | can I go adding it or is it not included by choice? | 13:27 |
| EmilienM | i don't know this param | 13:27 |
| gfidente | ack will add it | 13:27 |
| EmilienM | but go ahead | 13:27 |
| openstackgerrit | Giulio Fidente proposed openstack/puppet-cinder: Allow customization of DEFAULT/host https://review.openstack.org/281851 | 13:33 |
| *** davideagle_ has joined #puppet-openstack | 13:33 | |
| *** karimb has quit IRC | 13:37 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 13:39 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-zaqar: Add acceptance spec for zaqar with mongo. https://review.openstack.org/279351 | 13:44 |
| *** jpena is now known as jpena|lunch | 13:44 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 13:46 |
| *** ducttape_ has joined #puppet-openstack | 13:50 | |
| *** hjensas has quit IRC | 13:50 | |
| *** ducttape_ has quit IRC | 13:51 | |
| *** davideagle_ has quit IRC | 13:56 | |
| *** richm has joined #puppet-openstack | 13:56 | |
| openstackgerrit | Oleksiy Molchanov proposed openstack/puppet-ceph: Add possibility to use mod_proxy for radosgw https://review.openstack.org/266027 | 13:58 |
| *** paramite|afk is now known as paramite | 13:59 | |
| *** hjensas has joined #puppet-openstack | 14:04 | |
| *** hjensas has joined #puppet-openstack | 14:04 | |
| *** ducttape_ has joined #puppet-openstack | 14:08 | |
| *** skolekonov_ has quit IRC | 14:12 | |
| *** davideagle_ has joined #puppet-openstack | 14:14 | |
| *** ducttape_ has quit IRC | 14:14 | |
| openstackgerrit | Merged openstack/puppet-openstack-integration: scenario001: deploy Glance with RBD backend https://review.openstack.org/281455 | 14:15 |
| *** ducttape_ has joined #puppet-openstack | 14:19 | |
| *** ducttape_ has quit IRC | 14:23 | |
| *** jaosorior has quit IRC | 14:24 | |
| *** jaosorior has joined #puppet-openstack | 14:25 | |
| *** kindjal has quit IRC | 14:26 | |
| *** davideagle_ has quit IRC | 14:29 | |
| *** davideagle_ has joined #puppet-openstack | 14:35 | |
| *** alee_dinner has joined #puppet-openstack | 14:36 | |
| *** jtomasek has quit IRC | 14:39 | |
| *** jtomasek has joined #puppet-openstack | 14:44 | |
| *** ducttape_ has joined #puppet-openstack | 14:48 | |
| *** jpena|lunch is now known as jpena | 14:50 | |
| *** dfisher has joined #puppet-openstack | 14:53 | |
| *** ducttape_ has quit IRC | 14:54 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 14:56 |
| *** ducttape_ has joined #puppet-openstack | 14:56 | |
| *** jaosorior has quit IRC | 14:58 | |
| *** jaosorior has joined #puppet-openstack | 14:59 | |
| *** ducttape_ has quit IRC | 14:59 | |
| *** xarses has quit IRC | 15:04 | |
| *** kindjal has joined #puppet-openstack | 15:05 | |
| *** saneax is now known as saneax_AFK | 15:05 | |
| chem | jayg: I posted some comments and a patch on the puppet-pacemaker lint patch | 15:07 |
| chem | jayg: I assume that you have created a patch for adding the headers to the file. | 15:07 |
| chem | jayg: I think you should adjust part of it, see my comments :) | 15:08 |
| jayg | chem: ok, will look at your comments after call | 15:12 |
| *** davideagle_ has quit IRC | 15:14 | |
| *** davideagle_ has joined #puppet-openstack | 15:17 | |
| *** davideagle_ has quit IRC | 15:30 | |
| *** cwolferh has joined #puppet-openstack | 15:35 | |
| *** xarses has joined #puppet-openstack | 15:38 | |
| openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 15:42 |
| *** ducttape_ has joined #puppet-openstack | 15:46 | |
| *** yottatsa has joined #puppet-openstack | 15:47 | |
| *** davideagle_ has joined #puppet-openstack | 15:48 | |
| *** iurygregory has quit IRC | 15:51 | |
| *** paramite is now known as paramite|afk | 15:53 | |
| *** morazi has quit IRC | 15:53 | |
| *** angdraug has joined #puppet-openstack | 15:55 | |
| *** iurygregory has joined #puppet-openstack | 15:57 | |
| *** skolekonov_ has joined #puppet-openstack | 15:59 | |
| *** mdorman has joined #puppet-openstack | 16:00 | |
| IvanBerezovskiy | EmilienM: you will be glad to know https://review.openstack.org/#/c/279460/ | 16:00 |
| *** alee_dinner is now known as alee | 16:01 | |
| IvanBerezovskiy | and CI is coming! :) | 16:01 |
| EmilienM | IvanBerezovskiy: I already commented | 16:01 |
| *** morazi has joined #puppet-openstack | 16:02 | |
| IvanBerezovskiy | EmilienM: you are welcome to review as well ;) | 16:02 |
| *** zigo has quit IRC | 16:03 | |
| *** zigo has joined #puppet-openstack | 16:05 | |
| *** hjensas has quit IRC | 16:05 | |
| *** gchamoul has quit IRC | 16:05 | |
| *** rcernin has quit IRC | 16:17 | |
| *** paramite|afk is now known as paramite | 16:19 | |
| *** gchamoul has joined #puppet-openstack | 16:21 | |
| jayg | chem: ok, updated https://review.openstack.org/#/c/280683 if you want to take a look before I run recheck | 16:24 |
| chem | jayg: the check will run anyway I think | 16:25 |
| jayg | ah, k | 16:26 |
| jayg | (didn't seem like it did last time, maybe I was too impatient) | 16:26 |
| chem | jayg: this LGTM, I just removed two rogues space because I'm being pedantic, I'll +2 now | 16:33 |
| chem | jayg: I'm just waiting for the tests to be triggered and then I'll +2 | 16:36 |
| *** haplo37 has joined #puppet-openstack | 16:39 | |
| *** leanderthal is now known as leanderthal|afk | 16:39 | |
| *** skolekonov__ has joined #puppet-openstack | 16:40 | |
| *** skolekonov_ has quit IRC | 16:42 | |
| *** holser_ has joined #puppet-openstack | 16:43 | |
| degorenko | chem, hey :) can you review my cinder patch again? :) it should be ready now | 16:47 |
| *** skolekonov_ has joined #puppet-openstack | 16:49 | |
| *** skolekonov__ has quit IRC | 16:53 | |
| *** foxhunt72 is now known as foxhunt_away | 16:56 | |
| *** davideagle_ has quit IRC | 16:58 | |
| *** nlahouti has joined #puppet-openstack | 16:59 | |
| *** skolekonov__ has joined #puppet-openstack | 16:59 | |
| *** skolekonov__ has quit IRC | 17:00 | |
| jayg | chem: thanks for catching those, I thought I had cleaned them all :) | 17:01 |
| *** yottatsa has quit IRC | 17:01 | |
| *** dgurtner has quit IRC | 17:02 | |
| *** skolekonov_ has quit IRC | 17:03 | |
| *** fedexo has joined #puppet-openstack | 17:04 | |
| *** ericksonsantos has joined #puppet-openstack | 17:11 | |
| *** dmsimard is now known as rdobot | 17:11 | |
| *** rdobot is now known as dmsimard | 17:13 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 17:18 |
| openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 17:25 |
| chem | degorenko: will do, tomorrow morning, is that ok ? | 17:26 |
| degorenko | chem, sure, thanks | 17:26 |
| openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Create PKI signing folder if pki setup is enabled https://review.openstack.org/281972 | 17:27 |
| *** fedexo has quit IRC | 17:27 | |
| *** samuelBartel has quit IRC | 17:29 | |
| *** saneax_AFK is now known as saneax | 17:30 | |
| chem | jayg the infra is slow today... will give a look at it latter and if green (no reason it won't be, but hell, let's do it the right way) I'll put +2 | 17:31 |
| *** ayoung has joined #puppet-openstack | 17:32 | |
| jayg | chem: fair enough, I was just checking for any results as well | 17:33 |
| jayg | had a transient error yesterday that needed recheck, so I'll watch for results | 17:33 |
| *** dhollinger has joined #puppet-openstack | 17:34 | |
| ayoung | OK, working on the last two providers for the Keystone Federation APIs: mapping and federation protocol. Doing the last on first. I've cloned: (reverse-i-search)`cp': sudo cp /etc/puppet/modules/keystone/spec/unit/type/keystone_identity_provider_spec.rb /etc/puppet/modules/keystone/spec/unit/type/keystone_federation_protocol_spec.rb | 17:35 |
| ayoung | and | 17:35 |
| ayoung | made the following dir: | 17:35 |
| ayoung | /etc/puppet/modules/keystone/lib/puppet/provider/keystone_federation_protocol/openstack.rb | 17:35 |
| ayoung | and replaced identity_provider with federataion_protocol | 17:36 |
| *** rcernin has joined #puppet-openstack | 17:36 | |
| ayoung | well, except without the typo | 17:36 |
| ayoung | and | 17:36 |
| ayoung | cat protocol.pp | 17:36 |
| ayoung | keystone_federation_protocol { 'keycloak':\n ensure => present\n}\n | 17:36 |
| ayoung | (\n added by me to not spam | 17:36 |
| ayoung | but: | 17:37 |
| ayoung | sudo puppet apply protocol.pp | 17:37 |
| ayoung | Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type keystone_federation_protocol at /home/heat-admin/protocol.pp:3 on node overcloud-controller-0.localdomainWrapped exception: | 17:37 |
| ayoung | So it seems it is not finding my new thing | 17:37 |
| ayoung | pastes are http://paste.openstack.org/show/487457/ and http://paste.openstack.org/show/487456/ | 17:39 |
| ayoung | richm, EmilienM, or mfisch ^^ ? | 17:44 |
| jayg | ayoung: did you add type in addition to provider? that is what it looks like the error is saying is missing | 17:49 |
| jayg | you spec requires 'puppet/type/keystone_federation_protocol' | 17:49 |
| ayoung | jayg, I thought so...let me double check | 17:50 |
| *** dgurtner has joined #puppet-openstack | 17:50 | |
| jayg | but the pastes above show only provider/keystone_federation_protocol/openstack.rb | 17:50 |
| ayoung | jay file is /etc/puppet/modules/keystone/spec/unit/type/keystone_federation_protocol_spec.rb | 17:50 |
| ayoung | jayg, in this one http://paste.openstack.org/show/487456/ | 17:51 |
| jayg | right, that is the spec, but I mean in /lib/puppet/type | 17:51 |
| ayoung | ah | 17:51 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Cinder and Nova with RBD backend https://review.openstack.org/281624 | 17:52 |
| ayoung | jayg, ayuh. that was it | 17:53 |
| jayg | cool :) | 17:53 |
| ayoung | here's hoping that I don't hose my system too badly... | 17:53 |
| EmilienM | ayoung: use a vm :P | 17:54 |
| ayoung | EmilienM, I am. I need to get setup better for Puppet development, though | 17:55 |
| ayoung | I'm using a tripleo overcloud controller node, | 17:55 |
| EmilienM | ayoung: I use vagrant: http://my1.fr/blog/puppet-module-functional-testing-with-vagrant-openstack-and-beaker/ | 17:55 |
| EmilienM | or https://github.com/openstack/puppet-openstack-integration#all-in-one | 17:56 |
| ayoung | jayg, EmilienM, OK...so it failed, but in a good way: | 17:57 |
| ayoung | http://paste.openstack.org/show/487461/ | 17:57 |
| ayoung | that makes sense to me, didn;'t have the idp or mapping in the call. | 17:58 |
| *** alee is now known as alee_lunch | 17:58 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 17:58 |
| openstackgerrit | Ben Nemec proposed openstack/puppet-tripleo: Handle redirects for Horizon https://review.openstack.org/281991 | 18:00 |
| *** degorenko is now known as _degorenko|afk | 18:02 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Cinder and Nova with RBD backend https://review.openstack.org/281624 | 18:02 |
| *** ducttape_ has quit IRC | 18:11 | |
| *** saneax is now known as saneax_AFK | 18:14 | |
| *** derekh has quit IRC | 18:16 | |
| openstackgerrit | Giulio Fidente proposed openstack/puppet-cinder: Set default branch to stable/liberty in .gitreview https://review.openstack.org/281997 | 18:21 |
| openstackgerrit | Giulio Fidente proposed openstack/puppet-cinder: Allow customization of DEFAULT/host https://review.openstack.org/281998 | 18:21 |
| *** ducttape_ has joined #puppet-openstack | 18:23 | |
| *** jpena has quit IRC | 18:34 | |
| openstackgerrit | Merged openstack/puppet-cinder: Allow customization of DEFAULT/host https://review.openstack.org/281851 | 18:40 |
| *** gfidente has quit IRC | 18:47 | |
| *** jaosorior has quit IRC | 19:04 | |
| *** dgurtner has quit IRC | 19:09 | |
| *** mdorman has quit IRC | 19:10 | |
| openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Create PKI signing folder if pki setup is enabled https://review.openstack.org/281972 | 19:12 |
| mfisch | EmilienM: I dont understand your selinux comment | 19:14 |
| mfisch | can I add what? | 19:14 |
| EmilienM | damn | 19:14 |
| EmilienM | sorry for that I wanted to cancel it | 19:14 |
| EmilienM | in a separate patch I want to add selinux_ignore_defaults | 19:14 |
| EmilienM | because if SElinux is enforced we can have troubles if keystone packaging already manage this dir | 19:15 |
| mfisch | let me check ubuntu | 19:16 |
| mfisch | maybe we dont need this folder at all | 19:16 |
| EmilienM | no need for ubuntu | 19:16 |
| mfisch | does RDO have it? | 19:16 |
| EmilienM | (for selinux) | 19:16 |
| EmilienM | nope | 19:16 |
| mfisch | ok | 19:16 |
| EmilienM | but I've seen many cases in openstack where we manage dirs already managed by packaging | 19:16 |
| EmilienM | and it leads to selinux issues | 19:16 |
| mfisch | ok | 19:16 |
| EmilienM | let me show you an example | 19:16 |
| EmilienM | mfisch: https://github.com/puppetlabs/puppetlabs-rabbitmq/commit/0227f762070ffbbea3c28d6a60174de98fa4cc1c | 19:17 |
| mfisch | interesting | 19:17 |
| mfisch | but yeah that should be a separate patch I think | 19:17 |
| EmilienM | no worries | 19:18 |
| *** angdraug has quit IRC | 19:20 | |
| *** ducttape_ has quit IRC | 19:21 | |
| openstackgerrit | Ben Kero proposed openstack/puppet-openstack-integration: Add ability to manually install puppet modules https://review.openstack.org/282014 | 19:21 |
| *** paramite has quit IRC | 19:24 | |
| *** alee_lunch is now known as alee | 19:28 | |
| *** ducttape_ has joined #puppet-openstack | 19:30 | |
| openstackgerrit | Ben Kero proposed openstack/puppet-openstack-integration: Add ability to manually install puppet modules https://review.openstack.org/282020 | 19:30 |
| openstackgerrit | Ben Kero proposed openstack/puppet-openstack-integration: Add ability to pass puppet args in as env var https://review.openstack.org/282023 | 19:32 |
| *** brandon has joined #puppet-openstack | 19:35 | |
| *** dgurtner has joined #puppet-openstack | 19:35 | |
| *** rcernin has quit IRC | 19:55 | |
| bkero | ^ backports to liberty branch | 20:02 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (4 for 2..3) | 20:03 |
| ayoung | Error: Invalid parameter mapping(:mapping) | 20:03 |
| ayoung | Error: /Stage[main]/Main/Keystone_federation_protocol[keycloak]/ensure: change from absent to present failed: Invalid parameter mapping(:mapping) | 20:03 |
| ayoung | what am I doing wrong? | 20:03 |
| ayoung | jayg, EmilienM ? | 20:04 |
| kindjal | puppet-manila installs an ancient manila client: 0.1~git20140208-0ubuntu1 | 20:04 |
| kindjal | I do not see a more modern client in the apt repos… | 20:04 |
| kindjal | should there be: provider => pip in the client.pp module? | 20:05 |
| EmilienM | kindjal: we don't support source installs, only packaging. But contributions are welcome | 20:05 |
| EmilienM | ayoung: which code? | 20:05 |
| kindjal | EmilienM: Is it correct that puppet-manila install that older client? I mean, it doesn’t work... | 20:06 |
| kindjal | Is that a bug? Or am I doing something wrong? | 20:06 |
| EmilienM | kindjal: it depends on your repos config | 20:06 |
| EmilienM | puppet-manila does not manage the repos for you | 20:06 |
| ayoung | EmilienM, I'm hacking up a new provider | 20:07 |
| EmilienM | it's just run "apt-get intall python-manilaclient', nothing else. | 20:07 |
| ayoung | I can paste. 1 sec | 20:07 |
| EmilienM | kindjal: or yum install.. | 20:07 |
| EmilienM | but we don't configure repos for you | 20:07 |
| EmilienM | so if you say package is old, its not because of puppet-manila | 20:07 |
| EmilienM | but your repo config | 20:07 |
| kindjal | this is: http://ubuntu-cloud.archive.canonical.com/ubuntu trusty-updates/kilo main | 20:07 |
| kindjal | which doesn’t appear to have python-manilaclient | 20:07 |
| *** markvoelker_ has joined #puppet-openstack | 20:07 | |
| EmilienM | well, you running Kilo, obviously it's old ;-) | 20:08 |
| EmilienM | you should check in your manifests what is installing Kilo repository. | 20:08 |
| EmilienM | and update it | 20:08 |
| ayoung | EmilienM, http://paste.openstack.org/show/487476/ | 20:08 |
| kindjal | EmilienM: ok, thanks | 20:08 |
| ayoung | EmilienM, and, this is just "learn by Cargo culting" not near production code | 20:08 |
| EmilienM | ayoung: I'm about to leave now and I'm back Monday, so I prefer being honest and say I can't help right now. But next week I'm all yours if you want | 20:09 |
| ayoung | So I am hardcoding the list call on line 64 | 20:09 |
| ayoung | EmilienM, No problem. We can talk on Monday | 20:09 |
| *** todin_ has joined #puppet-openstack | 20:09 | |
| EmilienM | mfisch: fyi puppet-keystone beaker jobs are broken | 20:10 |
| EmilienM | since yesterday | 20:10 |
| EmilienM | an attempt to fix them: https://review.openstack.org/#/c/280385/ -- but not successful yet. | 20:10 |
| EmilienM | if nobody takes over it, I'll look on Monday | 20:10 |
| *** markvoelker has quit IRC | 20:12 | |
| *** tlbr_ has quit IRC | 20:12 | |
| *** bnemec has quit IRC | 20:12 | |
| *** todin has quit IRC | 20:12 | |
| *** xenolog has quit IRC | 20:12 | |
| *** tristanC has quit IRC | 20:12 | |
| *** tlbr has joined #puppet-openstack | 20:12 | |
| *** xenolog has joined #puppet-openstack | 20:12 | |
| *** tristanC has joined #puppet-openstack | 20:13 | |
| *** bnemec has joined #puppet-openstack | 20:13 | |
| *** kgalanov has quit IRC | 20:15 | |
| *** social has quit IRC | 20:15 | |
| *** social has joined #puppet-openstack | 20:15 | |
| *** kgalanov has joined #puppet-openstack | 20:17 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-nova: rbd: make sure libvirt is run before get-or-set virsh secret https://review.openstack.org/282044 | 20:17 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Cinder and Nova with RBD backend https://review.openstack.org/281624 | 20:17 |
| *** mdorman has joined #puppet-openstack | 20:32 | |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: deploy & test Zaqar https://review.openstack.org/281515 | 20:34 |
| *** rahulait has joined #puppet-openstack | 20:39 | |
| *** rahulait has quit IRC | 20:41 | |
| *** cwolferh has quit IRC | 20:44 | |
| jayg | ayoung: sorry, wasn't watching irc, did you add :mapping to the type/ declaration as well? I have seen similar errors when I did not add it in bot provider and type | 20:45 |
| ayoung | jayg, nope. let me do that | 20:46 |
| ayoung | jayg, what is the simplest way to make that read/write? | 20:47 |
| ayoung | newparam(:name, :namevar => true) do | 20:48 |
| tristanC | EmilienM: so beside the "collect exported resources" red warning, is there a way to make the puppet-gnocchi less verbose ? It seems like each statements are reschedulling restart of all gnocchi services, resulting in quite big puppet logs | 20:48 |
| ayoung | newvalues(/\S+/) | 20:48 |
| ayoung | end | 20:48 |
| ayoung | like that but with mapping? | 20:48 |
| EmilienM | tristanC: yes, you don't need to run puppet with debug options | 20:48 |
| jayg | ayoung: I think so, depends how much you need to limit content, though I am no expert in that area | 20:48 |
| EmilienM | tristanC: and serviecs should not restart at each puppet run | 20:49 |
| EmilienM | tristanC: our CI is currently testing gnocchi puppet runs as being idempotent, and they are idempotent | 20:49 |
| tristanC | EmilienM: those are 'Info' log, see http://paste.openstack.org/show/487479/ | 20:49 |
| EmilienM | which means first puppet run takes care of config/services and second does nothing | 20:49 |
| EmilienM | your exec is not idempotent | 20:50 |
| EmilienM | this is how we do: https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/provision.pp#L25-L36 | 20:50 |
| tristanC | EmilienM: it's not about being indepotent, this is output from the very first run | 20:50 |
| EmilienM | ah ok | 20:50 |
| EmilienM | yeah, you're usin --debug I guess | 20:51 |
| EmilienM | use -vt and you'll see less output | 20:51 |
| EmilienM | tristanC: https://docs.puppetlabs.com/puppet/latest/reference/man/apply.html#USAGE | 20:51 |
| tristanC | EmilienM: this is Info, we don't run debug | 20:52 |
| EmilienM | you won't see all those "Info" things without --debug | 20:52 |
| EmilienM | what options do you use? | 20:52 |
| tristanC | $ssh puppet apply --test --environment sf --modulepath=/etc/puppet/environments/sf/modules/:/etc/puppet/modules/ $manifest | 20:52 |
| EmilienM | --test: Enable the most common options used for testing. These are 'verbose', 'detailed-exitcodes' and 'show_diff'. | 20:53 |
| ayoung | jayg, getting further | 20:53 |
| EmilienM | tristanC: --test is enabling --verbose, so maybe that's why | 20:53 |
| ayoung | now it creates the entry, buty tries to do it every time. I get this error | 20:53 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': undefined method `collect' for "\n":Puppet::Util::Execution::ProcessOutput | 20:53 |
| ayoung | EmilienM, go away! | 20:54 |
| EmilienM | tristanC: in your manifest, I suggest you to add an "onlyif" or an "unless" to make it idempotent. | 20:54 |
| EmilienM | ayoung: yeah... I'm leaving, just helping tristanC | 20:54 |
| openstackgerrit | Colleen Murphy proposed openstack/puppet-keystone: Fix rabbitmq ssl logic https://review.openstack.org/280462 | 20:55 |
| *** nlahouti has quit IRC | 20:56 | |
| tristanC | okay, so I'll just hide those Gnocchi:: service rescheduling then... thank | 20:56 |
| jayg | ayoung: is that coolect in the paste from before or something new? | 20:57 |
| tristanC | would be sweet to make puppet not schedule any restart and just write configurations | 20:58 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-nova: rbd: make sure libvirt is run before get-or-set virsh secret https://review.openstack.org/282044 | 20:59 |
| openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: deploy Cinder and Nova with RBD backend https://review.openstack.org/281624 | 21:00 |
| EmilienM | tristanC: it should not restart any service at second puppet run | 21:00 |
| EmilienM | our CI is testing it | 21:00 |
| EmilienM | I need to drop off, please report a bug in launchpad if you find something weird, we'll take care of it. | 21:01 |
| *** rahulait has joined #puppet-openstack | 21:03 | |
| *** cdelatte has quit IRC | 21:05 | |
| *** johnmilton has quit IRC | 21:05 | |
| tristanC | EmilienM: Thank you | 21:06 |
| mfisch | Does the client_package_name in keystone's manifest/python.pp have any value? | 21:12 |
| mfisch | client.pp doesn't use it | 21:12 |
| mfisch | I'm going to remove it | 21:12 |
| *** brandon has quit IRC | 21:13 | |
| mfisch | actually does this whole class have any value? | 21:14 |
| mfisch | dang it, everyone usesit | 21:15 |
| openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Make client & python classes behave the same https://review.openstack.org/282065 | 21:21 |
| jayg | ayoung: I am heading out, but am here tomorrow if you need any more help from me | 21:25 |
| *** jayg is now known as jayg|g0n3 | 21:27 | |
| *** leanderthal|afk has quit IRC | 21:30 | |
| *** cdelatte has joined #puppet-openstack | 21:31 | |
| *** mdorman has quit IRC | 21:31 | |
| openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb https://review.openstack.org/254548 | 21:34 |
| *** gildub has joined #puppet-openstack | 21:48 | |
| openstackgerrit | Matt Fischer proposed openstack/puppet-keystone: Remove deprecated tenant_ LDAP parameters https://review.openstack.org/282073 | 21:56 |
| *** nlahouti has joined #puppet-openstack | 22:02 | |
| *** cwolferh has joined #puppet-openstack | 22:03 | |
| ayoung | mfisch, good one! | 22:04 |
| ayoung | kill that LDAP assignemtn cruft | 22:04 |
| mfisch | yeah | 22:04 |
| mfisch | that one made me happy | 22:04 |
| mfisch | im working on reconfiguring some anchors to allow alternative install methods like venv and docker and fixing stuff that I see | 22:05 |
| mfisch | if project gets renamed again Im quitting openstack | 22:06 |
| *** hjensas has joined #puppet-openstack | 22:07 | |
| ayoung | mfisch, so..I'm trying to write a provider via cargo culting an old one | 22:13 |
| ayoung | and getting this | 22:13 |
| mfisch | EmilienM: looking at your review | 22:13 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': undefined method `collect' for #<Puppet::Util::Execution::ProcessOutput:0x000000034a3050> | 22:13 |
| ayoung | Error: Execution of '/bin/openstack federation protocol create --format shell --identity-provider keycloak --mapping keycloak-saml2 saml2' returned 1: Conflict occurred attempting to store federation_protocol - Duplicate Entry (HTTP 409) (Request-ID: req-40f7b12f-b1f3-44e5-b48e-d4fe7fff1805) | 22:13 |
| *** colonwq has quit IRC | 22:14 | |
| ayoung | mfisch, he better not be here. | 22:14 |
| mfisch | ayoung: do you already have a saml2 defined? | 22:14 |
| ayoung | list.collect do |federation_protocol| | 22:14 |
| ayoung | current_resource = | 22:14 |
| *** rahulait has quit IRC | 22:14 | |
| ayoung | mfisch, yeah, but that is not the problem | 22:14 |
| ayoung | I tried to get just the top line | 22:15 |
| ayoung | that failure leads to the second, so I know why that is happening | 22:15 |
| ayoung | mfisch, what I don't get is the undefined collect message | 22:15 |
| mfisch | so is the undef method what you're digging into? | 22:15 |
| mfisch | ok | 22:15 |
| ayoung | mfisch, I would expect the show to fail...I'll past the code | 22:16 |
| mfisch | ok | 22:16 |
| *** rahulait has joined #puppet-openstack | 22:16 | |
| ayoung | mfisch, http://paste.openstack.org/show/487505/ | 22:16 |
| mfisch | im not a ruby expert but I assume that you're not getting any output and so collect is failing? | 22:16 |
| ayoung | oh...if that is it, then I can guess why.... | 22:16 |
| ayoung | let me try to fix the show command | 22:17 |
| mfisch | puts "#{list}" | 22:17 |
| mfisch | between 2/3 | 22:17 |
| ayoung | +-------+----------------+ | 22:18 |
| ayoung | | id | mapping | | 22:18 |
| ayoung | +-------+----------------+ | 22:18 |
| ayoung | | saml2 | keycloak-saml2 | | 22:18 |
| ayoung | +-------+----------------+ | 22:18 |
| mfisch | thats what list looks like? | 22:19 |
| ayoung | yep | 22:19 |
| ayoung | so maybe a format thing? | 22:19 |
| ayoung | --shell? | 22:19 |
| mfisch | I think usually we use csv format and some other options | 22:19 |
| mfisch | '--quiet', '--format', 'csv' | 22:20 |
| ayoung | ok...lemm try | 22:20 |
| mfisch | I thought request did that for you | 22:20 |
| mfisch | thats in the request code | 22:20 |
| richm | methinks the compound request string is throwing off request() | 22:21 |
| mfisch | crinkle: can you tell me how to run spec tests now with r10k? | 22:22 |
| mfisch | bundle install && bundle exec rake spec no longer works | 22:22 |
| mfisch | /var/lib/gems/1.9.1/bin/r10k: No such file or directory | 22:22 |
| *** colonwq has joined #puppet-openstack | 22:22 | |
| ayoung | mfisch, Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (6 for 2..3) | 22:22 |
| mfisch | openstack client right? | 22:23 |
| crinkle | mfisch: i had that problem too and decided to let the ci run it for me >.> | 22:23 |
| ayoung | mfisch, yeah | 22:23 |
| mfisch | crinkle: thats what I've been doing | 22:23 |
| crinkle | mfisch: i don't know what changed | 22:23 |
| crinkle | mfisch: are you using rbenv or rvm? | 22:23 |
| ayoung | mfisch, I was trying the format from the 'identity provider' provuider (heh) and that works OK | 22:24 |
| ayoung | that looks like this | 22:24 |
| richm | ayoung: it should be something like this | 22:24 |
| richm | request('federation protocol', 'list', '--identity-provider', 'keycloak') | 22:24 |
| ayoung | list = request('identity provider', 'list') | 22:24 |
| ayoung | list.collect do |identity_provider| | 22:24 |
| ayoung | current_resource = | 22:24 |
| ayoung | request('identity provider', 'show', identity_provider[:id]) | 22:24 |
| richm | and | 22:24 |
| ayoung | richm, I started with that, but it complained... | 22:24 |
| richm | ayoung: what was the complaint? | 22:24 |
| ayoung | lert me roll back | 22:25 |
| mfisch | request should be doing all the csv foo for you | 22:25 |
| mfisch | crinkle: I dont even know | 22:25 |
| mfisch | crinkle: I will ask osdev | 22:25 |
| mfisch | maybe help someone else | 22:25 |
| ayoung | richm, Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (7 for 2..3) | 22:25 |
| ayoung | Error: Execution of '/bin/openstack federation protocol create --format shell --identity-provider keycloak --mapping keycloak-saml2 saml2' returned 1: Conflict occurred attempting to store federation_protocol - Duplicate Entry (HTTP 409) (Request-ID: req-1713afb0-ee8f-4664-91b4-83c0dfab2a84) | 22:26 |
| ayoung | richm, Ah...I bet is another one of those spec things. I need to say more params are allowable somewhere? | 22:26 |
| crinkle | mfisch: EmilienM might have insight | 22:26 |
| ayoung | crinkle, we depend on him too much | 22:26 |
| ayoung | he's gone til monday | 22:26 |
| mfisch | ayoung: can you paste the line thats used for that federation list? | 22:27 |
| crinkle | ah | 22:27 |
| mfisch | the command | 22:27 |
| ayoung | list = request('federation protocol', 'list', '--quiet', '--format', 'csv' ,'--identity-provider', 'keycloak') | 22:27 |
| ayoung | mfisch, let me see where the error comes from, | 22:27 |
| richm | ayoung: omit the '--quiet', '--format', 'csv' , | 22:27 |
| richm | request with a 2nd argument of 'list' will do that automatically | 22:28 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (4 for 2..3) | 22:28 |
| mfisch | richm: yeah thats what I meant when I said I think request() wil do that for you | 22:28 |
| mfisch | sorry for the bad original info | 22:28 |
| ayoung | so this opne is different from most lists in that it needs the id-p variable | 22:28 |
| ayoung | is this a problem with the call to the openstack client expecting it to be param-less? | 22:29 |
| mfisch | opne? | 22:29 |
| ayoung | Dinner TIME! | 22:29 |
| richm | ayoung: try list = request('federation protocol', 'list', ['--identity-provider', 'keycloak']) | 22:29 |
| mfisch | crinkle: solved r10k with a symlink | 22:30 |
| crinkle | mfisch: hax | 22:31 |
| *** saneax_AFK is now known as saneax | 22:31 | |
| mfisch | i am 31337 | 22:31 |
| crinkle | mfisch: it works for me with rvm and not with rbenv...though these are different machines so that might not be the only difference | 22:31 |
| *** dgurtner has quit IRC | 22:52 | |
| ayoung | richm, Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (4 for 2..3) | 22:52 |
| *** saneax is now known as saneax_AFK | 22:53 | |
| ayoung | richm, ok, I think I can fake it out with an array | 22:54 |
| ayoung | richm, "id","mapping" | 22:55 |
| ayoung | "saml2","keycloak-saml2" | 22:55 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': undefined method `collect' for "\"id\",\"mapping\"\n\"saml2\",\"keycloak-saml2\"\n":Puppet::Util::Execution::ProcessOutput | 22:55 |
| ayoung | the top two lines are the output from puts "#{list}" | 22:55 |
| crinkle | mfisch: if you follow what jjb does instead of using normal ruby management tools it works http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/puppet-module-jobs.yaml#n15 | 22:56 |
| *** kindjal has quit IRC | 22:56 | |
| *** kindjal has joined #puppet-openstack | 22:57 | |
| *** gildub has quit IRC | 22:59 | |
| *** cdelatte has quit IRC | 22:59 | |
| *** dhollinger has quit IRC | 23:02 | |
| *** alee has quit IRC | 23:03 | |
| richm | ayoung: I don't understand - list_of_things = request('thing', 'list', ['arg1', 'arg2']) | 23:05 |
| richm | this is valid syntax used elsewhere | 23:05 |
| ayoung | richm, I think that works. I think it is the constructor that is failing | 23:05 |
| ayoung | undefined method `collect' for "\"id\",\"mapping\"\n\"saml2\",\"keycloak-saml2\"\n" | 23:05 |
| *** jtomasek has quit IRC | 23:05 | |
| ayoung | that calls new | 23:06 |
| ayoung | richm, let me paste the current code in toto | 23:06 |
| richm | ayoung: the output of request('thing', 'list', ...) should be an array of hashes | 23:06 |
| richm | the method `collect' is a valid method for an array object | 23:07 |
| ayoung | http://paste.openstack.org/show/487509/ | 23:07 |
| ayoung | ah, maybe it does not think it is an array due to the \n | 23:08 |
| richm | ayoung: hold on | 23:08 |
| richm | ayoung: try this | 23:08 |
| richm | ayoung: list = request('federation protocol', 'list', ['--identity-provider', 'keycloak']) | 23:08 |
| richm | ayoung: same with show | 23:09 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (5 for 2..3) | 23:09 |
| richm | wtf | 23:09 |
| richm | that is the exact same syntax used in several places | 23:10 |
| richm | ayoung: that is coming from the 'list' command, not the 'show' command? because the show command has the same problem | 23:11 |
| richm | the show command should be this | 23:11 |
| richm | request('federation protocol', 'show', ['--identity-provider', 'keycloak', federation_protocol[:id]]) | 23:11 |
| ayoung | yeah, that is from list. When list executes correctly I get a different problem | 23:12 |
| *** rahulait has quit IRC | 23:12 | |
| ayoung | richm, http://paste.openstack.org/show/487509/ | 23:12 |
| ayoung | what implements "request" here? | 23:12 |
| richm | ayoung: that's the old paste | 23:12 |
| ayoung | where is the base class | 23:13 |
| ayoung | richm, I know, but you see the show command in there | 23:13 |
| ayoung | haven't changed it | 23:13 |
| ayoung | richm, OK, walk me through this, because I know nothing from ruby: | 23:13 |
| ayoung | equire 'puppet/provider/keystone' | 23:14 |
| richm | ayoung: https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L207 | 23:14 |
| richm | ayoung: which calls https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L60 | 23:14 |
| richm | the third argument is either a single string property, or an array of properties - it must be one object, at any rate | 23:15 |
| ayoung | does that --format shell seemed to work | 23:15 |
| richm | ayoung: here is an example of how to use request('thing', 'list', [list of args]) | 23:16 |
| richm | ayoung: https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone_user/openstack.rb#L125 | 23:16 |
| ayoung | richm, nope I lied | 23:17 |
| ayoung | did not work | 23:17 |
| richm | ayoung: here is an example of using 'show' with an array of args: https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L134 | 23:19 |
| richm | ayoung: If you are doing exactly as in the examples, then we'll have to get creative in debugging this thing | 23:20 |
| ayoung | richm, the problem is def the list right now. I'm going to hack toward what the baseclass does | 23:20 |
| *** haplo37 has quit IRC | 23:20 | |
| richm | ayoung: can you paste the current code you're using? http://paste.openstack.org/show/487509/ is the old wrong code | 23:22 |
| ayoung | richm, will do.editing ATM | 23:26 |
| ayoung | richm, http://paste.openstack.org/show/487513/ | 23:29 |
| richm | ayoung: replace line 74 with list = request('federation protocol', 'list', ['--identity-provider', 'keycloak']) | 23:32 |
| richm | ayoung: remove line 75 | 23:32 |
| richm | ayoung: replace line 81 with this | 23:32 |
| richm | request('federation protocol', 'show', ['--identity-provider', 'keycloak', federation_protocol[:id]]) | 23:33 |
| ayoung | Error: Could not prefetch keystone_federation_protocol provider 'openstack': wrong number of arguments (5 for 2..3) | 23:33 |
| richm | but there aren't 5 arguments . . . there are 3 :P | 23:33 |
| richm | ayoung: I suppose you could hack puppet-openstacklib/lib/puppet/provider/openstack.rb | 23:35 |
| *** kindjal has quit IRC | 23:35 | |
| richm | in def self.request add a puts "properties #{properties}" | 23:35 |
| richm | then | 23:35 |
| richm | in def self.openstack | 23:35 |
| richm | add puts "args #{args} and #{*args}" | 23:35 |
| richm | find out wth is actually being passed to these methods | 23:36 |
| ayoung | richm, I need to get this set up better for development. Right now I'm hacking as root inside /etc/puppet | 23:37 |
| ayoung | should I clone https://github.com/openstack/puppet-openstacklib to start? | 23:37 |
| ayoung | or can I get away with just cloning https://github.com/openstack/puppet-keystone | 23:38 |
| richm | ayoung: I suppose you have already cloned puppet-keystone | 23:38 |
| richm | ayoung: and you don't need to clone puppet-openstacklib if you're just going to hack on a file for the purposes of debugging (unless you find an actual bug) | 23:39 |
| ayoung | nope, this is all out of the git tree to date...thought it was going to be quick and dirty... | 23:39 |
| ayoung | its 3 sshs deep on a tripleo controller node | 23:39 |
| richm | yow | 23:39 |
| ayoung | ssh to Hardware, ssh to undercloud, ssh to controller | 23:40 |
| ayoung | I am guessing I can ssh direct from HW to controller, though | 23:40 |
| openstackgerrit | James Slagle proposed openstack/puppet-cinder: Revert "Allow customization of DEFAULT/host" https://review.openstack.org/282098 | 23:40 |
| ayoung | Hi Ho Triple O | 23:40 |
| *** hjensas has quit IRC | 23:41 | |
| openstackgerrit | James Slagle proposed openstack/puppet-cinder: Revert "Allow customization of DEFAULT/host" https://review.openstack.org/282098 | 23:41 |
| *** openstackgerrit has quit IRC | 23:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:47 | |
| *** openstackgerrit_ has joined #puppet-openstack | 23:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:48 | |
| *** openstackgerrit_ has joined #puppet-openstack | 23:49 | |
| ayoung | richm, OK, I have it git cloned. How to tst puppet apply against the local dir? | 23:49 |
| *** gildub has joined #puppet-openstack | 23:50 | |
| ayoung | --modulepath=/home/heat-admin/puppet-keystone | 23:50 |
| richm | ayoung: I think you use puppet resource or puppet edit to exercise self.prefetch | 23:50 |
| *** openstackgerrit_ has quit IRC | 23:55 | |
| openstackgerrit | ayoung proposed openstack/puppet-keystone: first hack at keystone_federation_protocol https://review.openstack.org/282103 | 23:56 |
| *** dfisher has quit IRC | 23:56 | |
| ayoung | richm, that is my WIP | 23:56 |
| *** openstackgerrit_ has joined #puppet-openstack | 23:56 | |
| ayoung | richm, let's work with that review: annotate what you think needs to be done;. | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!