*** ducttape_ has quit IRC | 00:00 | |
*** ducttape_ has joined #puppet-openstack | 00:01 | |
*** ducttape_ has quit IRC | 00:04 | |
*** furlongm has quit IRC | 00:05 | |
*** furlongm has joined #puppet-openstack | 00:05 | |
*** ducttape_ has joined #puppet-openstack | 00:15 | |
*** ducttape_ has quit IRC | 00:19 | |
*** ayoung has joined #puppet-openstack | 00:45 | |
*** ayoung has quit IRC | 01:00 | |
*** ducttape_ has joined #puppet-openstack | 01:03 | |
*** ducttape_ has quit IRC | 01:09 | |
*** ducttape_ has joined #puppet-openstack | 01:13 | |
*** ducttape_ has quit IRC | 01:16 | |
*** cdelatte has quit IRC | 01:29 | |
*** ducttape_ has joined #puppet-openstack | 01:33 | |
*** ducttape_ has quit IRC | 01:42 | |
*** rstarmer has quit IRC | 01:50 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-cookiecutter: Add CI scripts https://review.openstack.org/344911 | 02:18 |
---|---|---|
openstackgerrit | Emilien Macchi proposed openstack/puppet-modulesync-configs: Add CI scripts https://review.openstack.org/344916 | 02:20 |
EmilienM | mwhahaha: we have CI jobs for ^ ! | 02:21 |
EmilienM | I'll work on it tomorrow to make sure the script pass | 02:21 |
*** jistr has quit IRC | 02:32 | |
*** jistr has joined #puppet-openstack | 02:33 | |
mwhahaha | Ok | 02:36 |
*** ebalduf has quit IRC | 02:37 | |
*** richm has quit IRC | 02:56 | |
*** ducttape_ has joined #puppet-openstack | 03:01 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/puppet-barbican: WIP - Move barbican to authtoken https://review.openstack.org/347105 | 03:22 |
*** ebalduf has joined #puppet-openstack | 03:41 | |
*** ducttape_ has quit IRC | 03:42 | |
*** jtomasek has quit IRC | 04:39 | |
*** jtomasek has joined #puppet-openstack | 04:58 | |
*** ntpttr- has quit IRC | 04:59 | |
*** ntpttr- has joined #puppet-openstack | 05:03 | |
*** ntpttr- has quit IRC | 05:15 | |
*** ntpttr- has joined #puppet-openstack | 05:17 | |
*** rstarmer has joined #puppet-openstack | 05:23 | |
openstackgerrit | Merged openstack/puppet-openstacklib: Increase command_timeout for openstackclient commands https://review.openstack.org/346994 | 05:28 |
*** jtomasek has quit IRC | 05:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL https://review.openstack.org/347134 | 06:11 |
*** rstarmer has quit IRC | 06:13 | |
*** leanderthal|afk is now known as leanderthal | 06:18 | |
*** ntpttr- has quit IRC | 06:24 | |
*** ntpttr- has joined #puppet-openstack | 06:26 | |
*** rstarmer has joined #puppet-openstack | 06:31 | |
*** ntpttr- has quit IRC | 06:37 | |
*** rstarmer has quit IRC | 06:38 | |
*** rstarmer has joined #puppet-openstack | 06:39 | |
*** tesseract- has joined #puppet-openstack | 06:39 | |
*** ntpttr- has joined #puppet-openstack | 06:39 | |
*** shardy has joined #puppet-openstack | 06:52 | |
*** rstarmer has quit IRC | 06:52 | |
*** rstarmer has joined #puppet-openstack | 07:01 | |
*** atom_ has joined #puppet-openstack | 07:02 | |
*** dgurtner has joined #puppet-openstack | 07:06 | |
*** dgurtner has quit IRC | 07:06 | |
*** dgurtner has joined #puppet-openstack | 07:06 | |
*** rcernin has joined #puppet-openstack | 07:06 | |
*** rstarmer has quit IRC | 07:09 | |
*** rstarmer has joined #puppet-openstack | 07:12 | |
*** alee has quit IRC | 07:15 | |
openstackgerrit | Carlos Camacho proposed openstack/puppet-tripleo: Add pacemaker mistral profile https://review.openstack.org/343346 | 07:18 |
*** rstarmer has quit IRC | 07:18 | |
*** ebalduf has quit IRC | 07:27 | |
*** ifarkas_afk is now known as ifarkas | 07:28 | |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-trove: Configure keystone authtoken options https://review.openstack.org/346685 | 07:33 |
*** toMeloos has joined #puppet-openstack | 07:33 | |
*** rstarmer has joined #puppet-openstack | 07:46 | |
*** rstarmer has quit IRC | 07:56 | |
*** rstarmer has joined #puppet-openstack | 08:03 | |
*** rstarmer has quit IRC | 08:08 | |
*** alee has joined #puppet-openstack | 08:09 | |
openstackgerrit | Su Zhengwei proposed openstack/puppet-glance: Fix inconsistent between puppet and install guide https://review.openstack.org/334137 | 08:17 |
*** derekh has joined #puppet-openstack | 08:29 | |
*** paramite has joined #puppet-openstack | 08:32 | |
*** jtomasek has joined #puppet-openstack | 08:33 | |
openstackgerrit | Ade Lee proposed openstack/puppet-openstack-integration: scenario001: enable Barbican and Volume Encryption testing https://review.openstack.org/339806 | 08:45 |
*** saneax_AFK is now known as saneax | 09:05 | |
*** gfidente has joined #puppet-openstack | 09:12 | |
*** gfidente has quit IRC | 09:12 | |
*** gfidente has joined #puppet-openstack | 09:12 | |
*** xarses_ has joined #puppet-openstack | 09:48 | |
*** xarses_ has quit IRC | 09:48 | |
*** xarses_ has joined #puppet-openstack | 09:49 | |
*** xarses_ has quit IRC | 09:49 | |
*** xarses_ has joined #puppet-openstack | 09:50 | |
*** rstarmer has joined #puppet-openstack | 09:50 | |
*** xarses has quit IRC | 09:50 | |
*** rstarmer has quit IRC | 09:55 | |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-mistral: Prepare 8.2.0 (mitaka) https://review.openstack.org/346195 | 10:02 |
*** rstarmer has joined #puppet-openstack | 10:04 | |
*** aernhart has joined #puppet-openstack | 10:14 | |
openstackgerrit | Merged openstack/puppet-octavia: Adding health_worker.pp https://review.openstack.org/343044 | 10:17 |
*** _degorenko|afk is now known as degorenko | 10:18 | |
*** rstarmer has quit IRC | 10:22 | |
*** rstarmer has joined #puppet-openstack | 10:24 | |
*** ntpttr- has quit IRC | 10:30 | |
*** ntpttr- has joined #puppet-openstack | 10:35 | |
*** Ahharu has joined #puppet-openstack | 10:36 | |
Ahharu | hello | 10:36 |
Ahharu | I am getting hit since this morning with this from puppet-keystone module | 10:36 |
Ahharu | Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error creating type specialization of an Apache::Listen-Type, Cannot use Integer where a resource title String is expected at /home/ahharu/puppet-testing/puppet-midonet_openstack/spec/fixtures/modules/apache/manifests/vhost.pp:411:39 at /home/ahharu/puppet-testing/puppet-midonet_openstack/spec/fixtures/modules/keystone/manifests/wsgi/apach | 10:36 |
Ahharu | any idea? | 10:36 |
*** johnmilton has quit IRC | 10:45 | |
openstackgerrit | Merged openstack/puppet-cinder: SolidFire backend deployment should use $::os_service_default https://review.openstack.org/345632 | 10:45 |
openstackgerrit | Merged openstack/puppet-mistral: Add missing tag on python-mistralclient package. https://review.openstack.org/346808 | 10:45 |
*** rstarmer has quit IRC | 10:53 | |
*** rstarmer has joined #puppet-openstack | 10:58 | |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Added Contrail puppet interfaces for tripleo https://review.openstack.org/347250 | 11:01 |
openstackgerrit | Merged openstack/puppet-cinder: Removing deprecated cluster_id db var https://review.openstack.org/346745 | 11:06 |
*** trown|outtypewww is now known as trown | 11:17 | |
*** rstarmer has quit IRC | 11:19 | |
*** rstarmer has joined #puppet-openstack | 11:28 | |
*** rstarmer has quit IRC | 11:29 | |
*** johnmilton has joined #puppet-openstack | 11:31 | |
*** rstarmer has joined #puppet-openstack | 11:35 | |
*** richm has joined #puppet-openstack | 11:54 | |
*** iberezovskiy|off is now known as iberezovskiy | 11:55 | |
*** paramite is now known as paramite|afk | 11:55 | |
*** cdelatte has joined #puppet-openstack | 11:56 | |
*** rstarmer has quit IRC | 11:57 | |
iberezovskiy | Ahharu, what's you apache and keystone module versions? | 11:58 |
*** ducttape_ has joined #puppet-openstack | 12:00 | |
*** shardy is now known as shardy_lunch | 12:01 | |
Ahharu | I seem to have found the culprit @iberezovskiy | 12:07 |
Ahharu | its that keystone module defaults ports to integers | 12:07 |
Ahharu | thus this fails in puppet 3 when it check for the ports being defined | 12:07 |
Ahharu | I added this to my keystone::wsgi::apache | 12:07 |
Ahharu | public_port => '5000', admin_port => '35357', | 12:07 |
degorenko | chem, hey, can you take a look on https://review.openstack.org/#/c/330623/ ? | 12:09 |
chem | degorenko: sure | 12:11 |
degorenko | thanks | 12:11 |
*** ducttape_ has quit IRC | 12:15 | |
chem | degorenko: I have serevals idea to stub this stuff, let me do some tests to find out which is the best | 12:15 |
degorenko | chem, feel free to re-upload | 12:15 |
chem | degorenko: ack | 12:15 |
EmilienM | hello | 12:22 |
EmilienM | mjblack: can you look https://review.openstack.org/#/c/329991/ when you around? | 12:23 |
openstackgerrit | Michele Baldessari proposed openstack/puppet-tripleo: Move nova constraints from controller manifest to each service https://review.openstack.org/347309 | 12:24 |
iurygregory | morning | 12:25 |
*** ericksonsantos has joined #puppet-openstack | 12:27 | |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: Create role for the fake openstack-core resource https://review.openstack.org/347315 | 12:30 |
iurygregory | alee, i forgot to update the acceptance sorry | 12:34 |
alee | iurygregory, yeah - I figured it was something like that | 12:35 |
iurygregory | i've update let's see if is gonna work =D | 12:36 |
*** moravec has quit IRC | 12:36 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/puppet-barbican: WIP - Move barbican to authtoken https://review.openstack.org/347105 | 12:36 |
EmilienM | alee: progress on testing? | 12:39 |
alee | EmilienM, yes in fact | 12:39 |
alee | EmilienM, so the problem I had yesterday was that the user needed to have admin role to delete a secret | 12:40 |
EmilienM | all is red https://review.openstack.org/#/c/339806/ | 12:40 |
alee | EmilienM, when I added admin role to tempest roles, I was abe to delete the secret successfully | 12:40 |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: Next generation HA architecture work https://review.openstack.org/342650 | 12:41 |
alee | EmilienM, but -- there are some other network visibility tests that fail - perhaps because the user is not supposed to be an admin | 12:41 |
alee | EmilienM, which is why all is red I think | 12:41 |
alee | EmilienM, but yesterday I pushed a change to barbican which allows a secret creator to delete their own secret | 12:42 |
alee | EmilienM, so when that newest barbican package goes through, the new admin role will be unneccessary | 12:42 |
EmilienM | alee: which new package? | 12:43 |
EmilienM | how old? | 12:43 |
alee | EmilienM, well - the change probably merged last night sometime .. looking .. | 12:43 |
EmilienM | we are promoting right now https://review.openstack.org/#/c/347134/ | 12:43 |
alee | EmilienM, https://review.openstack.org/#/c/311830/ | 12:44 |
EmilienM | k | 12:44 |
EmilienM | I'm glad our CI started to do real tests | 12:44 |
alee | EmilienM, merged 9 hours ago .. | 12:44 |
alee | not sure when the latest build was done. | 12:45 |
EmilienM | alee: we'll have the patch in ~30 min | 12:45 |
alee | EmilienM, cool | 12:45 |
EmilienM | alee: it's easy to check yourself | 12:45 |
EmilienM | alee: https://trunk.rdoproject.org/centos7-master/report.html | 12:45 |
EmilienM | alee: and https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/repos.pp#L34 | 12:46 |
EmilienM | that's all; | 12:46 |
alee | EmilienM, once the admin role was added, I encountered another problem with attaching the volume .. which I need to follow on with cinder devs | 12:46 |
alee | EmilienM, cool .. | 12:46 |
alee | EmilienM, http://logs.openstack.org/06/339806/35/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/422a18a/logs/nova/nova-compute.txt.gz#_2016-07-26_09_17_19_167 | 12:47 |
alee | EmilienM, I think its related to http://logs.openstack.org/06/339806/35/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/422a18a/logs/nova/nova-compute.txt.gz#_2016-07-26_09_17_16_924 | 12:47 |
alee | but need to check with cinder guys | 12:48 |
alee | EmilienM, anyways barbican is doing the right thing - the question is why attaching the volume is failing here. | 12:48 |
alee | EmilienM, did we ever run volume encryption tests in our scenarios (without barbican) before? | 12:49 |
EmilienM | alee: no | 12:49 |
*** paramite|afk is now known as paramite | 12:51 | |
alee | EmilienM, ok -- the exception thatis being thrown is here : https://github.com/openstack/nova/blob/master/nova/volume/encryptors/cryptsetup.py#L46 | 12:51 |
*** morazi has joined #puppet-openstack | 12:51 | |
alee | EmilienM, notice the note about libvirt drivers .. | 12:51 |
EmilienM | in scenario001, we use rbd, not in scenario002 | 12:52 |
alee | EmilienM, yeah - so maybe it needs to be moved to scenario002 | 12:53 |
EmilienM | alee: so we can't encrypt volumes with ceph? | 12:53 |
alee | EmilienM, I'm not sure -- I'm going to check with eharney when he gets online | 12:54 |
*** dmsimard is now known as dmsimard|afk | 12:58 | |
EmilienM | alee: isn't it any doc somewhere? | 12:59 |
EmilienM | https://ask.openstack.org/en/question/80306/does-cinder-in-kilo-supports-encryption-with-ceph/ | 13:00 |
*** severion has joined #puppet-openstack | 13:00 | |
EmilienM | https://bugs.launchpad.net/cinder/+bug/1440227 | 13:00 |
openstack | Launchpad bug 1440227 in Cinder "Not all volume drivers set the 'encrypted' key in connection_info" [Medium,Fix released] - Assigned to Matt Riedemann (mriedem) | 13:00 |
EmilienM | sounds it's supported, no? | 13:01 |
alee | EmilienM, sounds like it is .. | 13:02 |
alee | EmilienM, I had not heard of it not being supported before | 13:02 |
alee | but the cinder guys should be able to say whats going on | 13:02 |
*** bklei has joined #puppet-openstack | 13:09 | |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-openstacklib: Introduce openstack_resource_id_getter function https://review.openstack.org/330623 | 13:11 |
chem | degorenko: just an idea, didn't test in real deployment, let me know if that works for you ^ | 13:12 |
*** shardy_lunch is now known as shardy | 13:15 | |
degorenko | chem, ok, thanks, let's wait for ci | 13:18 |
degorenko | chem, it works on my local tests | 13:23 |
chem | degorenko: great, so that will do it :) | 13:24 |
degorenko | chem, btw, what do you think about this function? Is it good to mix function with provider stuff? | 13:24 |
chem | degorenko: it looks to me like a code smell, there is no other exemple of function checking the local state on the node | 13:25 |
degorenko | chem, didnt get :) can you rephrase please | 13:26 |
chem | degorenko: well, I check in all other openstack modules and dependend module and puppetlab function and no one run a command on the server (local state) in a function | 13:28 |
chem | degorenko: this should be the job of a provider I think, hence the "code smell" | 13:29 |
degorenko | chem, ah, right, but there is no way to get output from provider to some var, right? | 13:29 |
degorenko | chem, also, my doubts about this command are: 1) it will be useful only when all services are upped; 2) we can't use this function on deployment stage | 13:30 |
chem | degorenko: not that I know of. The dogme is that you puppet manifest should not be calculated in any way with data that will appear later ... or something like that. Well puppet ain't chef :) | 13:31 |
*** moravec has joined #puppet-openstack | 13:32 | |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Corrected syntax mistakes https://review.openstack.org/347385 | 13:32 |
chem | degorenko: the right aproche could be for the provider that handles the configuration with the uuid to calculate the good one I think. but I like background on the use case | 13:33 |
degorenko | chem, that make sense, but also may be some situations when we can get calculated data only on some deployment stage :) and then we can use only execs :D | 13:33 |
degorenko | chem, i guess, in our cause - use case for such function - is set some id to config | 13:34 |
chem | degorenko: uuid that we get at run time ... I get it now | 13:35 |
degorenko | chem, yeah :) | 13:35 |
chem | degorenko: so we should have a *_config_to_uuid provider I think | 13:36 |
chem | degorenko: should be easy to implement as a descendant class of *_config provider | 13:36 |
degorenko | chem, probably some other config provider right, which will take as argument config name and command (in openstack cli format? ) and will call config provider inside | 13:36 |
chem | degorenko: yeap my though exactly | 13:37 |
degorenko | chem, ok, i think we can raise this question on review | 13:37 |
degorenko | chem, probably, there is also other way for using uuid - not only for configs | 13:37 |
degorenko | i don't know, let's find out! | 13:37 |
chem | degorenko: so wdyt, we put that on discussion for tomorrow meeting ? | 13:38 |
degorenko | chem, today ;) | 13:39 |
chem | degorenko: oups ... yes, today ... It's very hot where I live and my brain is melting away | 13:39 |
degorenko | chem, and where are you from? :) | 13:43 |
chem | degorenko: south of France near Montpellier, current temperature is 34 degree under shadow. | 13:44 |
degorenko | chem, ah, that's like in Russia, on south and Volga based cities | 13:46 |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Cleanup https://review.openstack.org/347395 | 13:46 |
chem | degorenko: each time I read Volga I think about Michel Strogoff :) | 13:47 |
*** ayoung has joined #puppet-openstack | 13:48 | |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Cleanup2 https://review.openstack.org/347396 | 13:48 |
degorenko | chem, hm, action of this novel is in Siberia :D | 13:49 |
chem | degorenko: I think it follow the volga at some point | 13:49 |
chem | s/it/he/ | 13:50 |
degorenko | chem, not sure, but i didn't read that :) Volga river located on european side of Russia, before Ural mountains and Irkuts | 13:51 |
chem | degorenko: oki, so now I will think about nothing when I read Volga :) (but I will check out on a map later ...) | 13:53 |
iurygregory | alee, it work, tonight i'll add tests and release notes :D | 13:53 |
alee | iurygregory, great | 13:54 |
degorenko | chem, you can think about the biggest river in europe :D | 13:54 |
degorenko | chem, i've added topic for meeting btw | 13:55 |
chem | degorenko: volga passes through nijni-novgrod, as Michel does, so it does appear in the book (http://verne.garmtdevries.nl/pics/maps/mi_1_full.jpg) And yeah ... this is a hell of a river! | 13:56 |
degorenko | chem, well :) main actions i guess are in Siberia, but oki. And Nijni-Novgorod much more northern then my Saratov :D | 13:58 |
*** xarses_ has quit IRC | 14:00 | |
*** dfisher has joined #puppet-openstack | 14:08 | |
degorenko | dfisher, hey | 14:10 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-cookiecutter: Add CI scripts https://review.openstack.org/344911 | 14:10 |
*** atom_ has quit IRC | 14:10 | |
dfisher | degorenko: morning | 14:10 |
dfisher | still reading mails. | 14:10 |
degorenko | dfisher, chem updated patch with opesntack_id_getter :) but we have another solution for this also | 14:10 |
dfisher | oh sweet. thanks chem! | 14:10 |
degorenko | dfisher, this function is for setting some uuid to config right? | 14:11 |
dfisher | yes | 14:11 |
dfisher | specifically the router_id in l3_agent.ini | 14:11 |
degorenko | dfisher, so we have another solution then | 14:11 |
* dfisher all ears | 14:11 | |
degorenko | dfisher, take a look on my comment to function patch :) | 14:12 |
dfisher | ok, the withenv block? | 14:12 |
degorenko | dfisher, no, with new provider + config provider | 14:13 |
* dfisher wince | 14:13 | |
dfisher | so, it won't work as a provider | 14:13 |
dfisher | at least, as far as I understand it | 14:13 |
degorenko | dfisher, but if our new provider will write to config - it will :) | 14:13 |
openstackgerrit | Matthew J Black proposed openstack/puppet-gnocchi: WIP Keystone authoken resource changes https://review.openstack.org/347417 | 14:14 |
dfisher | sec, getting you an example | 14:14 |
degorenko | i guess we can discuss it in weekly meeting today | 14:14 |
*** emccormick has joined #puppet-openstack | 14:17 | |
dfisher | the problem is that if you have this: | 14:17 |
dfisher | http://paste.openstack.org/show/542109/ | 14:17 |
degorenko | dfisher, not exactly | 14:18 |
dfisher | the problem is the neutron:agents::l3 class | 14:18 |
dfisher | not the new provider | 14:18 |
dfisher | it will set router_id = | 14:18 |
dfisher | and then try to start the service | 14:18 |
dfisher | and puke (because use_namespaces = false and router_id is not set to anything) | 14:18 |
dfisher | then the new provider will set it. and re-enable the service | 14:19 |
dfisher | then, 20 minutes later puppet agent will run again and redo that entire dance | 14:19 |
dfisher | where agents::l3 unsets it | 14:20 |
dfisher | and restarts the service | 14:20 |
dfisher | causing it to puke | 14:20 |
dfisher | then the new provider sets it and fixes everything | 14:20 |
dfisher | and over and over | 14:20 |
degorenko | dfisher, we can add some new deps anchors for this | 14:20 |
dfisher | but we'd have to add new anchors in *every* module | 14:21 |
dfisher | not just neutron | 14:21 |
degorenko | dfisher, we have to add in case we need this provider | 14:21 |
degorenko | once we need it - we add new anchor | 14:21 |
dfisher | i'm not sure I understand why we'd do all this churn when a function works more or less just fine. | 14:22 |
degorenko | dfisher, mixing provider stuff with function - not best solution :) | 14:22 |
degorenko | also we have to execute this code on master | 14:22 |
dfisher | right. | 14:22 |
*** ebalduf has joined #puppet-openstack | 14:23 | |
degorenko | dfisher, that's just a suggestion - it is not like, current implementation is crap lets do it in other way - no | 14:23 |
chem | dfisher: degorenko who is currently writing the router_id thing | 14:23 |
dfisher | right, i knwo :) | 14:23 |
dfisher | chem: i am | 14:23 |
chem | dfisher: no, I mean, how it currently works ? | 14:24 |
dfisher | i have to go afk for about 5 minutes | 14:24 |
dfisher | be right back | 14:24 |
degorenko | chem, didn't get your question. how works what? | 14:24 |
mjblack | EmilienM: I provided feedback on that one change | 14:25 |
EmilienM | thx | 14:25 |
chem | degorenko: the router_id uuid should be set when by which module, do you have a code example that is currently working with your patch ? | 14:25 |
EmilienM | danpawlik: ^ | 14:25 |
degorenko | chem, ah, got it now, well, then, dfisher i guess has answer on this question | 14:26 |
danpawlik | EmilienM, mjblack: checking | 14:26 |
degorenko | chem, i saw also couple of ironic patches | 14:26 |
degorenko | chem, like that https://review.openstack.org/#/c/328921 - but it is not ready i think | 14:27 |
chem | degorenko: oki, so we should start from there to find the best way, with real code that would work with the function and then backtrack to see if there is a provider that could do the job without messing up every thing | 14:27 |
toMeloos | Just tried to use puppetlabs-haproxy 1.5 with puppetlabs-concat 2.2 and it seems broken. Anybody else tried haproxy with concat 2 yet? | 14:29 |
chem | degorenko: oki, so if in any *_config provider we see a key that end by _uuid then we do the convertion | 14:29 |
degorenko | chem, btw, we already have some custom providers https://github.com/openstack/puppet-tempest/blob/master/lib/puppet/provider/tempest_neutron_net_id_setter/openstack.rb | 14:30 |
degorenko | i guess then we can vote for one global provider for such goals | 14:31 |
dfisher | chem: yes. one sec | 14:31 |
degorenko | dfisher, fyi ^ | 14:31 |
dfisher | right, EmilienM pointed me at those already | 14:32 |
dfisher | and as I said, i've tried the provider route | 14:32 |
dfisher | and agents::l3 is the problem | 14:32 |
degorenko | dfisher, but we can use your function, in case of first deploy | 14:32 |
degorenko | when all services are not ready | 14:33 |
degorenko | can't* | 14:33 |
dfisher | chem: http://paste.us.oracle.com/25521 | 14:33 |
degorenko | dfisher, 404 | 14:33 |
dfisher | oh dammit | 14:34 |
dfisher | http://paste.openstack.org/show/542113/ | 14:34 |
dfisher | sorry. | 14:34 |
mwhahaha | line #15 is bad in that paste btw | 14:34 |
dfisher | works fine for me ;) | 14:35 |
degorenko | dfisher, so, in this case, in first run it will not be executed | 14:35 |
mwhahaha | yea it works, but you don't need to quote it ;) | 14:35 |
dfisher | k | 14:35 |
degorenko | if you use one catalog for all services, like in our p-o-i jobs | 14:35 |
chem | dfisher: I cannot see how it works, as it's evaluated at compile time when, for a first install, there is no resource created at all | 14:35 |
dfisher | that's correct. it doesn't work on the first pass. | 14:36 |
dfisher | it never will | 14:36 |
*** haplo37__ has joined #puppet-openstack | 14:36 | |
degorenko | or you need to create another catalog (another puppet file and run) for neutron services and for keystone | 14:36 |
degorenko | then it will | 14:36 |
dfisher | i create a second manifest for just l3 | 14:37 |
degorenko | but it is not run time solution :) | 14:37 |
dfisher | nope. it sure isn't. | 14:37 |
EmilienM | degorenko: so we need a meeting for the 2 points in the etherpad? | 14:37 |
EmilienM | https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-20160726 | 14:37 |
degorenko | EmilienM, well, we can discuss it here. It just for information | 14:37 |
chem | dfisher: this is set by neutron_l3_agent_config, can we assume that at the time this is run the router_id is created thanks to all existing dependency ? | 14:39 |
EmilienM | well, we can do a meeting if you want | 14:39 |
EmilienM | but I already see discussion here so... | 14:39 |
dfisher | chem: yes. I've already created a router with the neutron_router provider | 14:39 |
chem | so if neutron_l3_agent_config is smart enought to get the uuid from the name then it's done all in run/manifest, no ? | 14:40 |
dfisher | neutron_l3_agent_config is, sadly, not smart enough | 14:41 |
dfisher | (neither is neutron itself for that matter) | 14:41 |
chem | dfisher: I know, but I think that the code you've created should belong to this provider, in some way | 14:42 |
dfisher | how do you reconcile the issues with agents::l3 unsetting router_id? | 14:42 |
chem | dfisher: I don't know about this issue, I just looked at the past you've provided | 14:43 |
* dfisher nods | 14:43 | |
*** ntpttr__ has joined #puppet-openstack | 14:43 | |
*** xarses_ has joined #puppet-openstack | 14:44 | |
chem | dfisher: why would it unset the value, I don't get this ? | 14:44 |
dfisher | chem: http://paste.openstack.org/show/542109/ | 14:44 |
dfisher | so in neutron::agents::l3 | 14:44 |
dfisher | if use_namespaces is false | 14:44 |
chem | dfisher: oki I got it | 14:44 |
dfisher | it sets router_id to whatever's passed in | 14:45 |
dfisher | in this case, undef / "" | 14:45 |
dfisher | then agents::l3 enables the service | 14:45 |
dfisher | which pukes because router_id isn't set correctly | 14:45 |
degorenko | EmilienM, we can drop meeting today. What do you think about first point in ehterpad? | 14:45 |
chem | dfisher: but what I'm saying is something like this http://paste.openstack.org/show/542116/ | 14:46 |
EmilienM | i'm currently in tripleo meeting | 14:46 |
chem | in agents::l3 | 14:47 |
EmilienM | I'll look after | 14:47 |
dfisher | chem: that would totally work. I don't know how to modify the provider to account for that, however | 14:47 |
degorenko | chem, +1 for your solution | 14:47 |
dfisher | ^ | 14:47 |
degorenko | dfisher, there is nothing hard to implement that :) | 14:48 |
chem | dfisher: well that shouldn't be a big deal, but I'm so short on time right now ... | 14:48 |
dfisher | it's Ruby. everything's hard (for me) :) | 14:48 |
chem | hehe | 14:48 |
dfisher | chem: if you have an example somewhere, I can copy and paste like a champ | 14:48 |
degorenko | only one problem from my vision - how to detect what we should ask from openstack client in chem way | 14:48 |
chem | degorenko: we hardcode it in the code based on the key name ? | 14:49 |
degorenko | chem, but then we need to hardcode some request every time? | 14:50 |
*** ducttape_ has joined #puppet-openstack | 14:50 | |
chem | degorenko: there is no other way. It would have been one function per uuid anyway. If there is some common code appearing then we refactor. | 14:51 |
degorenko | well, ok | 14:52 |
*** aderyugin has quit IRC | 14:52 | |
*** atom_ has joined #puppet-openstack | 14:53 | |
*** aderyugin has joined #puppet-openstack | 14:53 | |
*** aderyugin has quit IRC | 14:54 | |
*** aderyugin has joined #puppet-openstack | 14:54 | |
chem | degorenko: dfisher I see a way to implement this. Will try for the next 15 min and see how it goes | 14:55 |
*** aderyugin has quit IRC | 14:55 | |
dfisher | if you have a rough mock-up, I can take it from there and try it | 14:55 |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Corrected syntax mistakes https://review.openstack.org/347385 | 14:56 |
EmilienM | meeting in 3 min | 14:57 |
*** xarses_ is now known as xarses | 14:57 | |
degorenko | EmilienM, we have some conclusion on 2 point. Do we need meeting for 1 point? :) | 14:58 |
degorenko | because as i see it now - we putting bunch of new parameters to some classes. May be can go through way that use logging and db classes? | 14:58 |
degorenko | mwhahaha, ^ | 14:58 |
dfisher | i can't even find documentation on 'value => $router_name, from_name => true;' (the from_name => true) piece | 14:58 |
degorenko | dfisher, it is not exist yet | 14:59 |
dfisher | aaaand that's why | 14:59 |
degorenko | it was chem idea how to do this trick with uuid | 14:59 |
dfisher | ok. will wait for chem. | 15:00 |
*** aderyugin has joined #puppet-openstack | 15:00 | |
EmilienM | yeah, let's do a quick meeting | 15:01 |
dfisher | what's the room again? | 15:01 |
*** rcernin has quit IRC | 15:05 | |
danpawlik | openstack-meeting-4 | 15:08 |
danpawlik | dfisher: openstack-meeting-4 :) | 15:08 |
* dfisher nods | 15:08 | |
dfisher | thanks! | 15:08 |
openstackgerrit | Clayton O'Neill proposed openstack/puppet-cinder: Cinder hooks support https://review.openstack.org/344464 | 15:10 |
iurygregory | EmilienM, doing the pacth for meeting | 15:12 |
EmilienM | ack | 15:12 |
*** danpawlik has quit IRC | 15:13 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/puppet-openstack-guide: Update meetings #88 https://review.openstack.org/347445 | 15:17 |
* iurygregory lunch time brb | 15:17 | |
*** Ahharu has quit IRC | 15:21 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-ironic: Allow to configure [ssh] section in ironic config https://review.openstack.org/347449 | 15:22 |
EmilienM | trown: ^ | 15:22 |
*** bklei has quit IRC | 15:22 | |
EmilienM | trown: doing instack patch now | 15:23 |
trown | EmilienM: thanks I think... note quickstart has to support mitaka and liberty | 15:23 |
*** Guest51132 is now known as med_ | 15:23 | |
*** med_ has quit IRC | 15:24 | |
*** med_ has joined #puppet-openstack | 15:24 | |
trown | seems like a lot of work for something only tripleo-quickstart will ever use | 15:24 |
*** aderyugin has quit IRC | 15:24 | |
trown | and that is not broken atm... | 15:24 |
*** aderyugin has joined #puppet-openstack | 15:24 | |
EmilienM | trown: ok, I'm trying to help with master atm | 15:26 |
trown | EmilienM: ya I think the puppet-ironic patch is good regardless... just saying I wouldnt patch anything into instack-undercloud | 15:27 |
trown | EmilienM: as master has generic hiera override anyways | 15:27 |
trown | EmilienM: and quickstart can switch to it unless we backported everything to liberty which seems like a bad idea given what we have works | 15:28 |
trown | s/can/cant/ | 15:28 |
*** saneax is now known as saneax_AFK | 15:29 | |
*** leanderthal is now known as leanderthal|afk | 15:30 | |
*** vinsh has joined #puppet-openstack | 15:31 | |
openstackgerrit | Merged openstack/puppet-openstack-integration: Enable ironic tests back for Ubuntu https://review.openstack.org/346713 | 15:34 |
EmilienM | damn I see that http://logs.openstack.org/95/346195/3/check/gate-puppet-mistral-puppet-beaker-rspec-ubuntu-trusty/c807ccc/console.html#_2016-07-26_14_13_10_385053 | 15:39 |
EmilienM | iberezovskiy: cool work ^ | 15:39 |
mwhahaha | i think that pure json error has been there for a while i believe | 15:40 |
*** ifarkas is now known as ifarkas_afk | 15:40 | |
*** tesseract- has quit IRC | 15:43 | |
EmilienM | mwhahaha: it worked at 6:41 AM | 15:43 |
EmilienM | today | 15:43 |
mwhahaha | oh it's trusty | 15:44 |
mwhahaha | probably need a pin for mitaka/liberty then | 15:44 |
EmilienM | again? | 15:45 |
EmilienM | but why did it work thing morning | 15:45 |
EmilienM | I'm finishing a task and I'll look | 15:45 |
mwhahaha | something got released with a bumped requirement for json_pure i guess | 15:45 |
mwhahaha | hard to say unless we have the old logs | 15:45 |
*** ntpttr__ has quit IRC | 15:47 | |
*** atom_ has quit IRC | 15:49 | |
EmilienM | old logs: http://logs.openstack.org/95/346195/3/check/gate-puppet-mistral-puppet-beaker-rspec-ubuntu-trusty/0278949/console.html | 15:49 |
EmilienM | I'll look in a bit | 15:49 |
mwhahaha | 2.0.2 - July 26, 2016 (136 KB) | 15:53 |
mwhahaha | once again | 15:53 |
mwhahaha | 2.0.2 includes a ~> 2 where 2.0.1 was a >= 0 | 15:53 |
mwhahaha | so getting screwed on a dep we probably don't even use :/ | 15:54 |
*** ntpttr__ has joined #puppet-openstack | 15:54 | |
EmilienM | damn | 15:57 |
EmilienM | mwhahaha: did you see which dep? | 15:57 |
mwhahaha | json_pure itself | 15:57 |
EmilienM | oh | 15:57 |
EmilienM | let's pin it? | 15:57 |
mwhahaha | yea | 15:58 |
EmilienM | ok, I'm doing it | 15:58 |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-openstacklib: WIP: add a way for provider to transform value in config. https://review.openstack.org/347463 | 15:59 |
*** trown is now known as trown|lunch | 15:59 | |
openstackgerrit | Saravanan KR proposed openstack/puppet-vswitch: Add DPDK driver modprobe for loading modules on reboot https://review.openstack.org/347464 | 15:59 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack_spec_helper: Pin json_pure to 2.0.1 https://review.openstack.org/347465 | 16:00 |
EmilienM | mwhahaha: looks good? ^ | 16:00 |
dfisher | chem: ah ha. i see now | 16:00 |
mwhahaha | yea should be | 16:00 |
EmilienM | mwhahaha: damn, we'll need https://review.openstack.org/#/c/344913/ first and its backport | 16:01 |
EmilienM | mwhahaha: do you know this error? http://logs.openstack.org/13/344913/1/check/gate-puppet-openstack-libraries-puppet-syntax-3-centos-7/53fbc09/console.html#_2016-07-26_14_08_10_673430 | 16:01 |
mwhahaha | no i can look into it though | 16:01 |
EmilienM | i'm trying to reproduce it | 16:02 |
EmilienM | ok I have it on my laptop | 16:03 |
*** johnmilton has quit IRC | 16:03 | |
alee | EmilienM, ok confirmed -- https://bugs.launchpad.net/cinder/+bug/1463525 | 16:04 |
openstack | Launchpad bug 1463525 in Cinder "There is no volume encryption support for rbd-backed volumes" [Undecided,Triaged] | 16:04 |
openstackgerrit | Athlan-Guyot sofer proposed openstack/puppet-neutron: WIP: transform name to uuid. https://review.openstack.org/347468 | 16:05 |
chem | dfisher: degorenko so I've done some prototyping of the idea in above two patch | 16:05 |
chem | dfisher: degorenko completly untested, just code coming from my brain to gerrit | 16:05 |
* dfisher nods | 16:05 | |
dfisher | i see them both. | 16:06 |
EmilienM | alee: ok, so move it to scenario002 | 16:06 |
degorenko | chem, will look | 16:06 |
degorenko | one for openstacklib and other neutron right? | 16:06 |
degorenko | chem, ^ | 16:06 |
alee | EmilienM, ok - will do | 16:06 |
chem | degorenko: yep | 16:06 |
degorenko | ack | 16:06 |
alee | EmilienM, I should be able to pick up the latest barbican package , right? | 16:06 |
chem | degorenko: dfisher feel free to push patch on it if you like it, I don't have much bandwidth currently | 16:06 |
EmilienM | alee: I showed you how you can check yourself, isn't? | 16:06 |
*** ntpttr__ has quit IRC | 16:07 | |
EmilienM | alee: https://review.openstack.org/#/c/347134/ is still in gate, so no. | 16:07 |
*** ntpttr__ has joined #puppet-openstack | 16:07 | |
alee | EmilienM, ok | 16:08 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL https://review.openstack.org/347134 | 16:12 |
dfisher | do WIP git reviews have jenkins run on them? | 16:13 |
EmilienM | alee: now we have it ^ | 16:13 |
EmilienM | dfisher: yes. | 16:13 |
alee | EmilienM, cool beans thanks | 16:14 |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: Create role for the fake openstack-core resource https://review.openstack.org/347315 | 16:14 |
degorenko | chem, should not it be transform_to here? https://review.openstack.org/#/c/347468/1/lib/puppet/provider/neutron_l3_agent_config/ini_setting.rb | 16:14 |
EmilienM | mwhahaha: when I run rake manually it works | 16:15 |
mwhahaha | k i'll take a look in a few | 16:15 |
EmilienM | with FUTURE_PARSER=yes it fails | 16:15 |
EmilienM | but with FUTURE_PARSER=no it works | 16:16 |
*** richm has quit IRC | 16:16 | |
*** richm has joined #puppet-openstack | 16:16 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack_spec_helper: run_syntax_tests: add logic to find which puppet version to test https://review.openstack.org/344913 | 16:18 |
EmilienM | mwhahaha: in the meantime, I disable it | 16:18 |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: Remove global openstack-core resource https://review.openstack.org/347472 | 16:18 |
dfisher | degorenko: are you currently working on either of chem's two patches? | 16:28 |
dfisher | if not, i'll start poking at them., | 16:28 |
*** derekh has quit IRC | 16:30 | |
*** rwsu has joined #puppet-openstack | 16:37 | |
*** chem` has joined #puppet-openstack | 16:37 | |
*** chem has quit IRC | 16:37 | |
*** dmsimard|afk is now known as dmsimard | 16:47 | |
*** bklei has joined #puppet-openstack | 16:52 | |
*** dhollinger has quit IRC | 16:54 | |
*** foxhunt_away is now known as foxhunt72 | 16:55 | |
degorenko | dfisher, go ahead, was afk :) | 16:57 |
dfisher | no problem. | 16:57 |
dfisher | will start poking at it soon. | 16:57 |
*** ntpttr__ has quit IRC | 17:01 | |
*** johnmilton has joined #puppet-openstack | 17:01 | |
*** ntpttr__ has joined #puppet-openstack | 17:04 | |
openstackgerrit | craig delatte proposed openstack/puppet-cinder: Cinder hooks support https://review.openstack.org/344464 | 17:05 |
*** paramite has quit IRC | 17:06 | |
*** johnmilton has quit IRC | 17:07 | |
degorenko | dfisher, i have only one doubt - see my comment above | 17:09 |
degorenko | i think neutron patch has typo error | 17:09 |
openstackgerrit | Ade Lee proposed openstack/puppet-openstack-integration: scenario002: enable Barbican and Volume Encryption testing https://review.openstack.org/339806 | 17:09 |
degorenko | transform -> trasnform_to | 17:09 |
dfisher | right | 17:09 |
dfisher | was going to mess with that. | 17:09 |
degorenko | ah, ok | 17:09 |
*** jtomasek has quit IRC | 17:10 | |
degorenko | dfisher, can you also upload test patch may be? | 17:10 |
dfisher | yep | 17:10 |
dfisher | will do all of the above | 17:10 |
dfisher | just need to get done with what I'm whacking on right now | 17:11 |
dfisher | 235672- things at once, per usual | 17:11 |
EmilienM | alee: thx for helping on it | 17:12 |
*** shardy has quit IRC | 17:13 | |
alee | EmilienM, no worries - going to grab dinner now -- hopefully it'll pass .. | 17:13 |
alee | EmilienM, will check on it later tonight | 17:13 |
EmilienM | alee: ok | 17:13 |
alee | EmilienM, if I've made a typo or something obvious , feel free to correct if you notice before I do | 17:14 |
*** trown|lunch is now known as trown | 17:14 | |
*** alee is now known as alee_dinner | 17:14 | |
EmilienM | ok | 17:14 |
*** alee_dinner has quit IRC | 17:16 | |
*** johnmilton has joined #puppet-openstack | 17:19 | |
mwhahaha | EmilienM: that error is because it's running puppet4 i think | 17:20 |
mwhahaha | http://logs.openstack.org/13/344913/1/check/gate-puppet-openstack-libraries-puppet-syntax-3-centos-7/53fbc09/console.html#_2016-07-26_14_07_42_534687 | 17:21 |
EmilienM | dang | 17:21 |
*** dhollinger has joined #puppet-openstack | 17:21 | |
EmilienM | I missed export PUPPET_GEM_VERSION='~> {puppet_version}' | 17:22 |
EmilienM | double dang | 17:22 |
EmilienM | mwhahaha: nice catch | 17:23 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack_spec_helper: run_syntax_tests: add logic to find which puppet version to test https://review.openstack.org/344913 | 17:23 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-cookiecutter: Add CI scripts https://review.openstack.org/344911 | 17:28 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-modulesync-configs: Add CI scripts https://review.openstack.org/344916 | 17:28 |
EmilienM | chem`: fyi^ we'll have more CI jobs for cookiecutter and modulesync | 17:29 |
*** ebalduf has quit IRC | 17:29 | |
iurygregory | nice :D | 17:29 |
*** chem` is now known as chem | 17:29 | |
chem | EmilienM: nice, will have a look | 17:29 |
EmilienM | chem, iurygregory: we'll have lint, syntax, unit and beaker | 17:32 |
iurygregory | EmilienM, awesome :D | 17:32 |
*** foxhunt72 is now known as foxhunt_away | 17:34 | |
openstackgerrit | Giulio Fidente proposed openstack/puppet-tripleo: profile/base/nova: declare nova class properly https://review.openstack.org/328347 | 17:41 |
*** gfidente is now known as gfidente|afk | 17:44 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-tripleo: profile/base/nova: declare nova class properly https://review.openstack.org/328347 | 17:47 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-tripleo: profile/base/nova: declare nova class and configure cache correctly. https://review.openstack.org/328347 | 17:48 |
*** ntpttr__ has quit IRC | 17:48 | |
*** _stowa has joined #puppet-openstack | 17:51 | |
*** iberezovskiy is now known as iberezovskiy|off | 17:55 | |
*** _stowa has quit IRC | 17:55 | |
*** degorenko is now known as _degorenko|afk | 17:55 | |
*** ntpttr__ has joined #puppet-openstack | 17:56 | |
*** priteau has joined #puppet-openstack | 17:57 | |
*** moravec has quit IRC | 17:58 | |
*** moravec has joined #puppet-openstack | 17:59 | |
*** leanderthal|afk has quit IRC | 18:07 | |
EmilienM | mwhahaha: can you look https://review.openstack.org/#/c/347465/ please? | 18:08 |
openstackgerrit | Michael Henkel proposed openstack/puppet-tripleo: Corrected syntax mistakes https://review.openstack.org/347385 | 18:32 |
openstackgerrit | Merged openstack/puppet-openstack-cookiecutter: Add CI scripts https://review.openstack.org/344911 | 18:34 |
*** danpawlik has joined #puppet-openstack | 18:36 | |
*** delattec has joined #puppet-openstack | 18:37 | |
*** delattec has quit IRC | 18:39 | |
*** delattec has joined #puppet-openstack | 18:41 | |
*** cdelatte has quit IRC | 18:41 | |
EmilienM | chem: https://review.openstack.org/#/c/344913/3/run_syntax_tests.sh | 18:45 |
EmilienM | I don't understand your comment | 18:45 |
EmilienM | we test if puppet < 4 in the first conditional and set parser to yes | 18:45 |
EmilienM | chem: I think I replied | 18:47 |
EmilienM | chem: no, puppet syntax will ignore the variable : | 18:47 |
EmilienM | https://github.com/gds-operations/puppet-syntax/blob/master/lib/puppet-syntax/tasks/puppet-syntax.rb#L33 | 18:47 |
mwhahaha | if you ran that manually with PUPPET_VERSION='3.8' you won't get the future parser | 18:48 |
mwhahaha | ie. manually | 18:48 |
chem | EmilienM: no you put is to ${FUTURE_PARSER:-yes}, which mean that if FUTURE_PARSER is set then you don't get yes. But it's more the else part that bother me (a little, not strong minded on this, he) where you can have puppet > 4 and future_parse set to yes (from the env) | 18:49 |
*** hjensas has quit IRC | 18:49 | |
EmilienM | chem: not a problem | 18:49 |
EmilienM | see https://github.com/gds-operations/puppet-syntax/blob/master/lib/puppet-syntax/tasks/puppet-syntax.rb#L33 | 18:49 |
EmilienM | it's just ignored ! | 18:49 |
chem | EmilienM: I've seen a unicorn! | 18:49 |
chem | EmilienM: ack, thanks for the clarifacation | 18:49 |
chem | EmilienM: but my first comment as mwhahaha point out is kinda still valid | 18:50 |
EmilienM | mwhahaha: right | 18:50 |
EmilienM | I guess we can address that later | 18:50 |
dfisher | chem: seeing errors with your two patches and I'm not sure how to reconcile: http://paste.openstack.org/show/542163/ | 18:51 |
chem | EmilienM: you can add this : puppet_major_version = `echo $PUPPET_VERSION | cut -d. -1` | 18:51 |
chem | EmilienM: and be done with it :) | 18:51 |
EmilienM | chem: ok I'm doing it thanks | 18:51 |
dfisher | does neutron_l3_agent_config need to inherit from the openstacklib openstack_config provider? | 18:52 |
dfisher | because right now, it's got: | 18:52 |
dfisher | require File.join(File.dirname(__FILE__), '..','..','..', | 18:52 |
dfisher | 'puppet/provider/neutron') | 18:52 |
dfisher | Puppet::Type.type(:neutron_l3_agent_config).provide( | 18:52 |
dfisher | :ini_setting, | 18:52 |
dfisher | :parent => Puppet::Type.type(:openstack_config).provider(:ini_setting) | 18:52 |
dfisher | ) do | 18:52 |
dfisher | change that to … uh … :openstack_setting instead of :ini_setting ? | 18:53 |
danpawlik | Hello, to create new relates notes page for puppet-nova module, I just need to type tox -e venv -- reno new <NEW FEATURE> or there is other way? | 18:53 |
dfisher | wait, no. | 18:53 |
dfisher | it already is. | 18:53 |
* dfisher duh | 18:53 | |
*** danpawlik has left #puppet-openstack | 18:56 | |
chem | dfisher: the inheritance chain is correct. let me check something about the syntax and I get back to you | 18:56 |
*** danpawlik has joined #puppet-openstack | 18:56 | |
dfisher | no problem. | 18:56 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-cookiecutter: run_syntax: use PUPPET_MAJOR_VERSION https://review.openstack.org/347519 | 18:56 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-cookiecutter: run_syntax: use PUPPET_MAJOR_VERSION https://review.openstack.org/347519 | 18:58 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-modulesync-configs: Add CI scripts https://review.openstack.org/344916 | 18:58 |
chem | dfisher: in the paste you put ini_settings.rb instead of ini_setting.rb, just a copy/paste error ? | 18:58 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack_spec_helper: run_syntax_tests: add logic to find which puppet version to test https://review.openstack.org/344913 | 18:59 |
EmilienM | chem: done ^ can you review it please? | 18:59 |
chem | EmilienM: yep | 18:59 |
dfisher | chem: yes. jsut a typo | 18:59 |
dfisher | chem: i'm trying your patches by just making the changes to the installed modules | 18:59 |
chem | dfisher: that's correct, I'm doing the same :) | 19:00 |
*** ntpttr__ has quit IRC | 19:00 | |
dfisher | :) | 19:01 |
danpawlik | if I add new feature like MultiStrOpt for parameter (https://review.openstack.org/#/c/329991/) in release notes I should add description into upgrade section, or ? | 19:04 |
*** dgurtner has quit IRC | 19:05 | |
*** haplo37__ has quit IRC | 19:06 | |
openstackgerrit | Merged openstack/puppet-openstack_spec_helper: Pin json_pure to 2.0.1 https://review.openstack.org/347465 | 19:06 |
EmilienM | we need it in liberty too | 19:07 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack_spec_helper: Pin json_pure to 2.0.1 https://review.openstack.org/347524 | 19:08 |
*** rain has joined #puppet-openstack | 19:12 | |
*** rain is now known as Guest90133 | 19:13 | |
openstackgerrit | Daniel Pawlik proposed openstack/puppet-nova: Add MultiStrOpt for scheduler_available_filters https://review.openstack.org/329991 | 19:13 |
openstackgerrit | Brent Eagles proposed openstack/puppet-octavia: Adding housekeeping.pp https://review.openstack.org/347527 | 19:16 |
*** Guest90133 has quit IRC | 19:18 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-ironic: Allow to configure [ssh] section in ironic config https://review.openstack.org/347449 | 19:24 |
EmilienM | mwhahaha, chem: good ? https://review.openstack.org/#/c/347519/ | 19:28 |
mwhahaha | ya | 19:29 |
EmilienM | ok | 19:29 |
EmilienM | I think we can release a new Mitaka tomorrow then | 19:29 |
*** Guest90133 has joined #puppet-openstack | 19:30 | |
chem | dfisher: oki, to sum up, type inheritence is not implemented (may or may not be working, have to check https://groups.google.com/forum/#!topic/puppet-dev/67WvuAe-CBs). So for now you can just add newparam(:transform_to) to neutron/lib/puppet/type/neutron_l3_agent_config.rb | 19:31 |
dfisher | ah, ok. will do | 19:31 |
chem | dfisher: it fails with another error though :) | 19:31 |
dfisher | hot damn | 19:32 |
* dfisher excited | 19:32 | |
chem | dfisher: I have to leave now, it's quite late here, but ... | 19:32 |
dfisher | no worries. | 19:32 |
dfisher | we can keep plugging away at it | 19:32 |
chem | dfisher: be aware that the value needs to be untransformed in some way to preserve idempotency when fetch back from the system, so "def value" need some tweeking as well | 19:33 |
dfisher | chem: Error: /Stage[main]/Main/Neutron_l3_agent_config[DEFAULT/router_id]: Could not evaluate: undefined method `empty' for "uuid":String | 19:34 |
dfisher | that one? | 19:34 |
chem | dfisher: yep, must be something stupid | 19:34 |
dfisher | ok. will poke. | 19:34 |
dfisher | thanks again for the help | 19:34 |
chem | dfisher: if you have some input just add code to the review, I will have another (fresh) look tomorrow | 19:34 |
dfisher | i will | 19:34 |
dfisher | g'night! | 19:34 |
chem | thanks, bye | 19:35 |
*** chem is now known as chem|off | 19:35 | |
*** dgurtner has joined #puppet-openstack | 19:36 | |
*** dgurtner has quit IRC | 19:36 | |
*** dgurtner has joined #puppet-openstack | 19:36 | |
*** danpawlik has left #puppet-openstack | 19:36 | |
chem|off | EmilienM: +1 | 19:37 |
EmilienM | chem|off: go to bed ! | 19:37 |
EmilienM | chem|off: thanks :) | 19:37 |
openstackgerrit | Daniel Pawlik proposed openstack/puppet-watcher: Added planer sections https://review.openstack.org/341788 | 19:40 |
*** dgurtner has quit IRC | 19:42 | |
openstackgerrit | Merged openstack/puppet-openstack_spec_helper: Pin json_pure to 2.0.1 https://review.openstack.org/347524 | 19:42 |
dfisher | can puppet providers inherit from multiple providers? | 19:47 |
openstackgerrit | Merged openstack/puppet-openstack-cookiecutter: run_syntax: use PUPPET_MAJOR_VERSION https://review.openstack.org/347519 | 19:48 |
*** alee_dinner has joined #puppet-openstack | 19:49 | |
EmilienM | alee_dinner: you didn't copy scenario001 to scenario002 correctly ... | 19:53 |
EmilienM | you missed attach_encrypted_volume | 19:53 |
alee_dinner | EmilienM, looking .. yeah -- I was about to look through to see what I missed | 19:55 |
EmilienM | alee_dinner: and your patch breaks Swift tests... | 19:55 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: enable Barbican and Volume Encryption testing https://review.openstack.org/339806 | 19:55 |
EmilienM | alee_dinner: I'll let you figure why it breaks swift tests.. | 19:55 |
EmilienM | probabily some keystone thing with roles | 19:55 |
EmilienM | you said, we don't need role? | 19:55 |
EmilienM | we don't need specific role? | 19:55 |
alee_dinner | I took out the admin role | 19:56 |
alee_dinner | we still need creator role | 19:56 |
EmilienM | ah | 19:56 |
EmilienM | it breaks swift i think. | 19:56 |
alee_dinner | but thats barbican specific | 19:56 |
alee_dinner | (I thought) | 19:56 |
EmilienM | alee_dinner: http://logs.openstack.org/06/339806/36/check/gate-puppet-openstack-integration-3-scenario002-tempest-centos-7/4961870/console.html#_2016-07-26_17_54_50_792169 | 19:56 |
alee_dinner | EmilienM, ok - tempest_roles I think has "Member" as default | 19:59 |
alee_dinner | EmilienM, so if we add creator it needs to be "Member,creator" | 19:59 |
alee_dinner | and that should fix swift | 19:59 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: enable Barbican and Volume Encryption testing https://review.openstack.org/339806 | 20:01 |
EmilienM | alee_dinner: lets try | 20:01 |
alee_dinner | EmilienM, I think it needs to be "Member,creator" and not ['Member', 'creator'] | 20:03 |
alee_dinner | EmilienM, I tried the other way and it did not work before | 20:03 |
EmilienM | alee_dinner: why? | 20:03 |
EmilienM | it's because juan did a mistake in puppet-tempest | 20:03 |
EmilienM | the parameter is an array | 20:04 |
alee_dinner | EmilienM, could be - but I did read similar things in tempest.conf file .. | 20:05 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-tempest: Ensure tempest_roles is an array https://review.openstack.org/347541 | 20:08 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario002: enable Barbican and Volume Encryption testing https://review.openstack.org/339806 | 20:08 |
EmilienM | alee_dinner: ^ | 20:08 |
EmilienM | now it will be an array | 20:08 |
alee_dinner | cool :) | 20:09 |
EmilienM | alee_dinner: please never do "a,b" as a string | 20:09 |
EmilienM | use arrays... | 20:09 |
alee_dinner | EmilienM, oh defineitely | 20:15 |
dfisher | what's the git magic to pull a WIP patch? I want to take chem's https://review.openstack.org/#/c/347463/ and add to it | 20:17 |
*** delattec has quit IRC | 20:18 | |
iurygregory | dfisher, you want to push a new patch set right? | 20:21 |
dfisher | yes | 20:21 |
dfisher | isn't there a git clone <mumble> refs/mumble/bumble thing? | 20:21 |
iurygregory | you have puppet-openstacklib in your machine? | 20:21 |
iurygregory | cd puppet-openstacklib | 20:22 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-modulesync-configs: Add CI scripts https://review.openstack.org/344916 | 20:22 |
dfisher | from github or the package? | 20:22 |
iurygregory | dfisher, git ;) | 20:22 |
iurygregory | git review -d 347463 | 20:22 |
dfisher | awesome. | 20:22 |
iurygregory | when you do your changes just do git add and git commit --amend | 20:23 |
iurygregory | and git review =) | 20:23 |
EmilienM | iurygregory: so was it you or denis to push the first authtoken.pp class? | 20:23 |
dfisher | iurygregory: thanks! | 20:23 |
iurygregory | EmilienM, i work on the poc tonight, do you think i can do for barbican? or do you have other module in mind? | 20:24 |
iurygregory | dfisher, nope o/ | 20:24 |
openstackgerrit | Drew Fisher proposed openstack/puppet-openstacklib: WIP: add a way for provider to transform value in config. https://review.openstack.org/347463 | 20:27 |
EmilienM | iurygregory: you can start by whatever you like | 20:27 |
EmilienM | start simple and iterate | 20:27 |
iurygregory | EmilienM, ack ;) | 20:27 |
openstackgerrit | Drew Fisher proposed openstack/puppet-neutron: WIP: transform name to uuid. https://review.openstack.org/347468 | 20:33 |
openstackgerrit | Merged openstack/puppet-openstack_spec_helper: run_syntax_tests: add logic to find which puppet version to test https://review.openstack.org/344913 | 20:38 |
*** jtomasek has joined #puppet-openstack | 20:40 | |
*** jtomasek has quit IRC | 20:41 | |
*** jtomasek has joined #puppet-openstack | 20:41 | |
alee_dinner | EmilienM, something else broken -- all tests failing .. | 20:47 |
*** cdelatte has joined #puppet-openstack | 20:50 | |
openstackgerrit | Merged openstack/puppet-openstack-guide: Update meetings #88 https://review.openstack.org/347445 | 20:58 |
*** trown is now known as trown|outtypewww | 21:02 | |
*** cdelatte has quit IRC | 21:15 | |
*** ntpttr__ has joined #puppet-openstack | 21:23 | |
*** mjb has quit IRC | 21:25 | |
*** mjb has joined #puppet-openstack | 21:28 | |
*** toMeloos has quit IRC | 21:29 | |
*** dgurtner has joined #puppet-openstack | 21:32 | |
*** dgurtner has quit IRC | 21:32 | |
*** dgurtner has joined #puppet-openstack | 21:32 | |
openstackgerrit | Edward Balduf proposed openstack/puppet-cinder: SolidFire backend deployment should use $::os_service_default https://review.openstack.org/347066 | 21:36 |
*** dgurtner has quit IRC | 21:37 | |
*** ayoung has quit IRC | 21:45 | |
*** ntpttr__ has quit IRC | 21:54 | |
*** ntpttr__ has joined #puppet-openstack | 21:55 | |
*** openstackgerrit has quit IRC | 22:03 | |
*** openstackgerrit has joined #puppet-openstack | 22:04 | |
*** moravec has quit IRC | 22:22 | |
*** priteau has quit IRC | 22:23 | |
*** ntpttr__ has quit IRC | 22:24 | |
*** bklei has quit IRC | 22:34 | |
*** bklei has joined #puppet-openstack | 22:35 | |
*** bklei has quit IRC | 22:40 | |
*** openstackgerrit has quit IRC | 22:48 | |
*** openstackgerrit has joined #puppet-openstack | 22:48 | |
*** ducttape_ has quit IRC | 22:53 | |
*** morazi has quit IRC | 22:55 | |
*** vinsh has quit IRC | 23:06 | |
*** bklei has joined #puppet-openstack | 23:13 | |
*** xarses has quit IRC | 23:38 | |
*** dfisher has quit IRC | 23:57 | |
*** ducttape_ has joined #puppet-openstack | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!