*** Guest67611 is now known as saneax_AFK | 00:53 | |
*** ducttape_ has quit IRC | 01:34 | |
*** ducttape_ has joined #puppet-openstack | 01:35 | |
*** ilbot3 has quit IRC | 01:46 | |
*** ilbot3 has joined #puppet-openstack | 01:48 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario003: re-enable trove https://review.openstack.org/351953 | 01:57 |
---|---|---|
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: Revert "run_tests: stop mistral testing" https://review.openstack.org/339813 | 02:01 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: gnocchi: export db-sync output in logs https://review.openstack.org/356178 | 02:09 |
openstackgerrit | Michael Liu proposed openstack/puppet-magnum: Add itesm for keystone_authtoken using class keystone::resource::authtoken https://review.openstack.org/351980 | 02:47 |
*** ducttape_ has quit IRC | 02:49 | |
*** dhollinger has joined #puppet-openstack | 03:07 | |
*** ducttape_ has joined #puppet-openstack | 03:13 | |
*** ducttape_ has quit IRC | 03:36 | |
openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Update Jewel Ceph RGW to support Keystone V3 https://review.openstack.org/347956 | 03:39 |
*** dhollinger has quit IRC | 04:11 | |
*** ducttape_ has joined #puppet-openstack | 04:36 | |
*** ducttape_ has quit IRC | 04:41 | |
openstackgerrit | Merged openstack/puppet-openstacklib: Add missing namevar method to openstack_config provider https://review.openstack.org/355235 | 04:52 |
*** jaosorior has joined #puppet-openstack | 05:13 | |
*** ducttape_ has joined #puppet-openstack | 05:38 | |
*** ducttape_ has quit IRC | 05:43 | |
*** rcernin has joined #puppet-openstack | 05:46 | |
openstackgerrit | Karthik S proposed openstack/puppet-neutron: Set firewall driver for SR-IOV ports https://review.openstack.org/343505 | 05:47 |
*** saneax_AFK is now known as saneax | 05:52 | |
*** saneax is now known as Guest18059 | 05:52 | |
openstackgerrit | Merged openstack/puppet-tripleo: Defaults empty hash to kernel_modules and sysctl_settings https://review.openstack.org/355615 | 06:06 |
openstackgerrit | Merged openstack/puppet-tripleo: Align hiera keys with service names https://review.openstack.org/353582 | 06:06 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL https://review.openstack.org/356245 | 06:12 |
*** Guest18059 is now known as saneax_AFK | 06:15 | |
*** gfidente has quit IRC | 06:18 | |
*** ebalduf has quit IRC | 06:21 | |
*** sofie has joined #puppet-openstack | 06:32 | |
openstackgerrit | Charlie Llewellyn proposed openstack/puppet-cinder: Add variable to set availabilty zone fallback https://review.openstack.org/356255 | 06:35 |
openstackgerrit | Michele Baldessari proposed openstack/puppet-tripleo: Enable aodh systemd services on non-bootstrap nodes https://review.openstack.org/356110 | 06:36 |
*** ducttape_ has joined #puppet-openstack | 06:39 | |
*** sofie has quit IRC | 06:44 | |
*** ducttape_ has quit IRC | 06:45 | |
*** leanderthal|afk is now known as leanderthal | 06:54 | |
*** markvoelker has quit IRC | 07:00 | |
*** tesseract- has joined #puppet-openstack | 07:00 | |
*** gfidente has joined #puppet-openstack | 07:00 | |
*** foxhunt_away is now known as foxhunt72 | 07:02 | |
*** johnma has joined #puppet-openstack | 07:16 | |
openstackgerrit | Merged openstack/puppet-tripleo: Add cinder-backup profiles https://review.openstack.org/311218 | 07:20 |
*** johnma has left #puppet-openstack | 07:21 | |
*** amoralej|off is now known as amoralej | 07:26 | |
*** dtantsur|afk is now known as dtantsur | 07:49 | |
*** markvoelker has joined #puppet-openstack | 08:00 | |
*** markvoelker has quit IRC | 08:05 | |
*** ducttape_ has joined #puppet-openstack | 08:08 | |
*** chem has joined #puppet-openstack | 08:09 | |
*** ducttape_ has quit IRC | 08:12 | |
openstackgerrit | Carlos Camacho proposed openstack/puppet-tripleo: Fix deployment steps for AODH profiles https://review.openstack.org/352372 | 08:22 |
*** priteau has joined #puppet-openstack | 08:24 | |
*** paramite has joined #puppet-openstack | 08:31 | |
*** dgurtner has joined #puppet-openstack | 08:33 | |
*** _degorenko|afk is now known as degorenko | 08:52 | |
openstackgerrit | Carlos Camacho proposed openstack/puppet-nova: Removing WARNING: line has more than 140 characters in puppet-nova profiles https://review.openstack.org/355409 | 08:55 |
*** xarses_ has joined #puppet-openstack | 08:55 | |
*** derekh has joined #puppet-openstack | 08:57 | |
*** xarses has quit IRC | 08:58 | |
openstackgerrit | Lukas Bezdicka proposed openstack/puppet-ironic: Introduce ironic::ipxe class https://review.openstack.org/354125 | 08:59 |
openstackgerrit | Erno Kuvaja proposed openstack/puppet-manila: Add CephFSNative driver logic https://review.openstack.org/353928 | 09:00 |
*** markvoelker has joined #puppet-openstack | 09:01 | |
*** markvoelker has quit IRC | 09:06 | |
*** gfidente has quit IRC | 09:07 | |
*** ducttape_ has joined #puppet-openstack | 09:08 | |
*** ducttape_ has quit IRC | 09:13 | |
*** gfidente has joined #puppet-openstack | 09:26 | |
*** maestropandy has joined #puppet-openstack | 09:29 | |
*** maestropandy has left #puppet-openstack | 09:30 | |
openstackgerrit | Merged openstack/puppet-tacker: Add authtoken class https://review.openstack.org/351779 | 09:32 |
*** openstack has joined #puppet-openstack | 10:17 | |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-oslo: Add support for oslo privsep management https://review.openstack.org/356007 | 10:20 |
openstackgerrit | Ivan Berezovskiy proposed openstack/puppet-nova: [WIP] Manage privsep helper for nova https://review.openstack.org/356005 | 10:21 |
*** hjensas has quit IRC | 10:45 | |
openstackgerrit | Erno Kuvaja proposed openstack/puppet-ceph: Expose osd crush update on start option https://review.openstack.org/356376 | 10:45 |
*** hjensas has joined #puppet-openstack | 10:46 | |
*** hjensas has joined #puppet-openstack | 10:46 | |
openstackgerrit | Carlos Camacho proposed openstack/puppet-nova: Removing WARNING: line has more than 140 characters in puppet-nova profiles https://review.openstack.org/355409 | 10:50 |
*** paramite has quit IRC | 10:52 | |
*** paramite has joined #puppet-openstack | 10:53 | |
openstackgerrit | Erno Kuvaja proposed openstack/puppet-ceph: Expose osd crush update on start option https://review.openstack.org/356376 | 10:59 |
openstackgerrit | Saravanan KR proposed openstack/puppet-neutron: SR-IOV numvfs config is made persistent across reboots https://review.openstack.org/352494 | 11:03 |
openstackgerrit | Erno Kuvaja proposed openstack/puppet-ceph: Expose osd crush update on start option https://review.openstack.org/356376 | 11:07 |
*** ducttape_ has joined #puppet-openstack | 11:10 | |
openstackgerrit | Michele Baldessari proposed openstack/puppet-tripleo: Configure galera-monitor on all controller nodes https://review.openstack.org/356390 | 11:11 |
*** dtantsur is now known as dtantsur|bbl | 11:11 | |
*** ducttape_ has quit IRC | 11:15 | |
openstackgerrit | Alexey Deryugin proposed openstack/puppet-trove: Configure keystone authtoken options https://review.openstack.org/346685 | 11:32 |
*** jaosorior has quit IRC | 11:35 | |
*** jaosorior has joined #puppet-openstack | 11:36 | |
*** amoralej is now known as amoralej|lunch | 11:40 | |
*** ansmith has joined #puppet-openstack | 11:49 | |
EmilienM | hello | 11:53 |
*** morazi has joined #puppet-openstack | 11:59 | |
*** jayg|g0n3 is now known as jayg | 12:01 | |
*** johnmilton has quit IRC | 12:02 | |
*** markvoelker has joined #puppet-openstack | 12:09 | |
*** ducttape_ has joined #puppet-openstack | 12:10 | |
openstackgerrit | Lukas Bezdicka proposed openstack/puppet-ironic: Introduce ironic::ipxe class https://review.openstack.org/354125 | 12:10 |
EmilienM | iberezovskiy, degorenko: hey! any progress on https://review.openstack.org/#/c/355632/ ? :) | 12:12 |
*** jpena is now known as jpena|lunch | 12:15 | |
*** cdelatte has joined #puppet-openstack | 12:16 | |
*** dprince has joined #puppet-openstack | 12:16 | |
EmilienM | iberezovskiy, degorenko: tripleo is waiting for this patch, it's kind of urgent | 12:17 |
*** chem has quit IRC | 12:18 | |
*** chem has joined #puppet-openstack | 12:19 | |
openstackgerrit | Pradeep Kilambi proposed openstack/puppet-tripleo: Move ceilometer api to run under apache wsgi https://review.openstack.org/352476 | 12:19 |
*** johnmilton has joined #puppet-openstack | 12:22 | |
Jokke_ | iurygregory: thanks for all your help on the reviews. https://review.openstack.org/#/c/353928/ is passing the tests again! | 12:23 |
*** ducttape_ has quit IRC | 12:23 | |
openstackgerrit | Carlos Camacho proposed openstack/puppet-nova: Removing WARNING: line has more than 140 characters in puppet-nova profiles https://review.openstack.org/355409 | 12:27 |
*** johnmilton has quit IRC | 12:27 | |
openstackgerrit | Merged openstack/puppet-tripleo: Fix deployment steps for AODH profiles https://review.openstack.org/352372 | 12:29 |
iurygregory | Jokke_, you're welcome o/ | 12:30 |
iurygregory | morning people | 12:30 |
*** guimaluf has joined #puppet-openstack | 12:30 | |
*** johnmilton has joined #puppet-openstack | 12:41 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add manifests to inject and trust CA certificates https://review.openstack.org/353021 | 12:43 |
openstackgerrit | Charlie Llewellyn proposed openstack/puppet-cinder: Fixed alginment and added test https://review.openstack.org/356359 | 12:45 |
iberezovskiy | EmilienM, unfortunately, Fuel Ci is broken. so we can't merge our adapt patch. I think we need to unblock you first. but let's please wait for mwhahaha. I want to notify him about this problem | 12:46 |
EmilienM | ok | 12:46 |
EmilienM | we don't want to break you more :) | 12:46 |
*** fultonj_ has joined #puppet-openstack | 12:46 | |
degorenko | EmilienM, fuel ci is already broken by our internal problems, so, it doesnt matter if we will merge your patch | 12:47 |
degorenko | but agree, lets wait for Alex | 12:47 |
openstackgerrit | Sven Anderson proposed openstack/puppet-openstack-integration: scenario003: Enable ec2api tempest tests https://review.openstack.org/356442 | 12:48 |
EmilienM | ok | 12:48 |
iberezovskiy | EmilienM, jfyi https://review.openstack.org/#/c/356007/ | 12:52 |
beagles | and the winning recheck goes to iurygregory ! | 12:53 |
beagles | thanks man | 12:54 |
beagles | did they disable osic or something? | 12:54 |
EmilienM | iberezovskiy: oh nice | 12:55 |
EmilienM | beagles: your patch got merged? | 12:55 |
beagles | EmilienM, yup | 12:55 |
EmilienM | beagles: congrats \o/ | 12:57 |
beagles | EmilienM, it was a team effort :) | 12:57 |
EmilienM | and stars | 12:57 |
beagles | yup it looks like they disabled osic | 12:59 |
*** ducttape_ has joined #puppet-openstack | 13:00 | |
*** paramite has quit IRC | 13:03 | |
iurygregory | beagles, haha tks \o/ | 13:03 |
*** mkarpin has quit IRC | 13:04 | |
*** mkarpin has joined #puppet-openstack | 13:06 | |
EmilienM | chem: what should we do with https://review.openstack.org/#/c/354872/ ? | 13:08 |
EmilienM | merge it until next version of puppet? | 13:09 |
EmilienM | it's blocking multiple patches | 13:09 |
chem | EmilienM: they have release it master and backported it, but yes, in the meantime we could merge it. I'm just afraid that we just forget to remove it. | 13:10 |
EmilienM | chem: do they have released it? | 13:10 |
chem | EmilienM: merged to stable: 05a7ced, and merged to master 2 days ago | 13:11 |
EmilienM | ah, so it's not released | 13:11 |
*** amoralej|lunch is now known as amoralej | 13:12 | |
chem | nope | 13:12 |
chem | EmilienM: I've just added a comment asking for a quick release. | 13:14 |
*** fultonj_ has quit IRC | 13:15 | |
*** fultonj_ has joined #puppet-openstack | 13:16 | |
*** fultonj_ has quit IRC | 13:16 | |
EmilienM | nice! | 13:16 |
chem | in the meantime, we can merge it and let an note on the next weekling meeting to revert it if released | 13:17 |
chem | EmilienM: ^ ? | 13:17 |
EmilienM | chem: yes | 13:17 |
EmilienM | I did a recheck | 13:18 |
EmilienM | +2 now | 13:18 |
chem | ack, I'm updating https://etherpad.openstack.org/p/puppet-openstack-weekly-meeting-20160823 | 13:18 |
*** jpena|lunch is now known as jpena | 13:18 | |
openstackgerrit | Erno Kuvaja proposed openstack/puppet-ceph: Expose osd crush update on start option https://review.openstack.org/356376 | 13:19 |
EmilienM | chem: thx | 13:20 |
*** fultonj has quit IRC | 13:20 | |
iurygregory | EmilienM, can you +A https://review.openstack.org/#/c/356014/ ? ^^ | 13:22 |
*** fultonj has joined #puppet-openstack | 13:22 | |
EmilienM | iurygregory: done! | 13:23 |
EmilienM | almost 100 meetings! | 13:23 |
iurygregory | yeah | 13:23 |
iurygregory | :D | 13:23 |
iurygregory | did you have sucess in know the TripleO problem in nova authtoken? | 13:24 |
*** dtantsur|bbl is now known as dtantsur | 13:24 | |
openstackgerrit | Merged openstack/puppet-openstack-guide: Update meeting #90 https://review.openstack.org/356014 | 13:26 |
*** ducttape_ has quit IRC | 13:26 | |
EmilienM | iurygregory: not yet | 13:27 |
iurygregory | EmilienM, ok, i was about to try the recheck lol | 13:28 |
EmilienM | iurygregory: I did it, because the tripleo error was not related | 13:28 |
iurygregory | EmilienM, awesome :D | 13:28 |
beagles | EmilienM++ | 13:43 |
beagles | "recheck this is insane" lol | 13:43 |
EmilienM | lol | 13:43 |
*** xarses_ has quit IRC | 13:47 | |
*** xarses_ has joined #puppet-openstack | 13:48 | |
*** karthiks_afk is now known as karthiks | 13:50 | |
*** danpawlik has joined #puppet-openstack | 13:54 | |
*** ducttape_ has joined #puppet-openstack | 13:55 | |
mwhahaha | iberezovskiy: is it still broken? | 14:05 |
*** xarses_ has quit IRC | 14:06 | |
*** dfisher has joined #puppet-openstack | 14:08 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-tempest: trove: add db_flavor_ref parameter https://review.openstack.org/356491 | 14:11 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: scenario003: re-enable trove https://review.openstack.org/351953 | 14:12 |
EmilienM | tripleo CI is currently blocked to promote to latest trunk and we might need https://review.openstack.org/#/c/355632/ asap | 14:13 |
EmilienM | mwhahaha, iberezovskiy: would it be ok to land the puppet patch? | 14:14 |
mwhahaha | yea gimme a sec to try and catch up this morning, we can probably land it | 14:15 |
iberezovskiy | mwhahaha, as I can see it was fixed some minutes ago, but I didn't check | 14:15 |
mwhahaha | yea it looks like it's fixed now | 14:16 |
*** xarses_ has joined #puppet-openstack | 14:30 | |
EmilienM | mwhahaha: should we recheck fuel CI? | 14:38 |
iberezovskiy | not yet | 14:41 |
EmilienM | ok | 14:41 |
EmilienM | iberezovskiy: it would be great if we could merge it today, just fyi | 14:42 |
iberezovskiy | yep, I understand | 14:42 |
iberezovskiy | I'm on it | 14:42 |
karthiks | EmilienM, regarding https://review.openstack.org/#/c/343505/3/manifests/agents/ml2/sriov.pp@78, if we need to set a fixed value in puppet, wouldn't it be appropriate to set it as default. | 14:45 |
EmilienM | karthiks: the default value in neutron doesn't work? | 14:46 |
karthiks | EmilienM, As far as I understand from http://docs.openstack.org/mitaka/networking-guide/adv-config-sriov.html, (section Enable neutron sriov-agent) this configuration needs to be given explicitly | 14:50 |
EmilienM | karthiks: ok then | 14:50 |
EmilienM | karthiks: +2 | 14:51 |
EmilienM | and we're waiting for tripleo/fuel CI to be green | 14:51 |
karthiks | Thanks EmilienM :) | 14:51 |
openstackgerrit | Pradeep Kilambi proposed openstack/puppet-tripleo: Clean up unused params from aodh profiles https://review.openstack.org/356523 | 14:51 |
*** derekh has quit IRC | 14:52 | |
*** openstackgerrit has quit IRC | 15:03 | |
*** openstackgerrit has joined #puppet-openstack | 15:04 | |
openstackgerrit | Keith Schincke proposed openstack/puppet-ceph: Update Jewel Ceph RGW to support Keystone V3 https://review.openstack.org/347956 | 15:10 |
*** dprince has quit IRC | 15:11 | |
*** ducttape_ has quit IRC | 15:11 | |
*** dhollinger has joined #puppet-openstack | 15:19 | |
*** saneax_AFK is now known as saneax | 15:26 | |
*** saneax is now known as Guest66466 | 15:27 | |
colonwq | xarses_, If I hit the patch enough, it will work and I will have a flat spot on my head. | 15:27 |
*** leanderthal is now known as leanderthal|afk | 15:39 | |
*** foxhunt72 is now known as foxhunt_away | 15:39 | |
*** ducttape_ has joined #puppet-openstack | 15:40 | |
beagles | EmilienM (and anyone else who wants to chime in) while I don't have much puppet experience - nor ruby for that matter - I do like to apply what I learn as I go. The reason I ask is I'm wondering how rigorous I should go on reviewing puppet patches. My feeling is be as rigorous as I know how and if I'm wrong somebody who knows better will correct me. | 15:51 |
*** jaosorior has quit IRC | 15:51 | |
beagles | thoughts? | 15:52 |
EmilienM | beagles: I started the review process by looking how others used to review and what were common use | 15:52 |
EmilienM | just pick some patches under review, and try to see if the patch has the doc, is tested, is following conventions: http://docs.openstack.org/developer/puppet-openstack-guide/coding-style.html | 15:53 |
beagles | EmilienM, ack | 15:53 |
EmilienM | if it's passing CI, if the commit message is good | 15:53 |
EmilienM | for the code itself, it comes by reading existing code and be aware about how to write good puppet manifests | 15:53 |
beagles | the usual :) | 15:54 |
beagles | it's a bit interesting as each community has - even within the mundane things like commit messages - different standards | 15:57 |
beagles | so the reviewing the reviewers is the big thing I need to work at | 15:57 |
*** ebalduf has joined #puppet-openstack | 15:57 | |
beagles | EmilienM, thanks | 15:58 |
*** rcernin has quit IRC | 15:58 | |
*** bodepd has quit IRC | 15:59 | |
*** dtantsur is now known as dtantsur|brb | 16:00 | |
*** amoralej is now known as amoralej|off | 16:06 | |
*** danpawlik has quit IRC | 16:13 | |
EmilienM | yeah ! https://review.openstack.org/#/c/356491/ really helps to run trove tests | 16:14 |
EmilienM | if anyone can review it ^ | 16:14 |
EmilienM | there is one more failure but I think it's a bug in trove/tempest tests, I'm on it | 16:14 |
EmilienM | http://logs.openstack.org/53/351953/8/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/6bfc661/console.html#_2016-08-17_14_48_58_392634 | 16:14 |
EmilienM | but the 2 other failures we had are gone with my puppet-tempest patch | 16:14 |
*** dprince has joined #puppet-openstack | 16:27 | |
EmilienM | not sure I'm doing right: https://review.openstack.org/356587 | 16:28 |
beagles | degorenko, iberezovskiy, the reason I asked that question of EmilienM above is I was in the middle of reviewing https://review.openstack.org/#/c/344918/ and I got to wondering "what's too far?". Maybe you can advise me a bit here? | 16:36 |
openstackgerrit | Carlos Camacho proposed openstack/puppet-nova: Removing WARNING: line has more than 140 characters in puppet-nova profiles https://review.openstack.org/355409 | 16:37 |
*** rwsu has quit IRC | 16:38 | |
*** dtantsur|brb is now known as dtantsur | 16:49 | |
*** tesseract- has quit IRC | 17:00 | |
*** rcernin has joined #puppet-openstack | 17:26 | |
iberezovskiy | beagles, good comments I think | 17:29 |
iberezovskiy | beagles, the main idea on review for me is to do not say 'this is wrong', the idea is to describe what's exactly wrong and suggest how to fix, attach links for additional information if possible | 17:31 |
beagles | iberezovskiy, ack | 17:35 |
openstackgerrit | Merged openstack/puppet-openstack-integration: Promote RDO repository to latest consistent URL https://review.openstack.org/356245 | 17:36 |
*** priteau has quit IRC | 17:36 | |
openstackgerrit | Merged openstack/puppet-tempest: trove: add db_flavor_ref parameter https://review.openstack.org/356491 | 17:36 |
*** dtantsur is now known as dtantsur|afk | 17:37 | |
beagles | iberezovskiy, what are your thoughts on two resources conflicting with each other, ie 'eth0:4', 'eth0:1' | 17:37 |
iberezovskiy | it won't conflict because of different title | 17:38 |
iberezovskiy | but they will manage the same configuration file | 17:38 |
beagles | iberezovskiy, in puppet they will but they end up hitting the same file yeah | 17:38 |
iberezovskiy | I think it's the user issue, because he provided incorrect input | 17:38 |
beagles | iberezovskiy, it just ends up being a user issue | 17:38 |
beagles | yeah what you said :) | 17:38 |
iberezovskiy | :) | 17:38 |
openstackgerrit | Pradeep Kilambi proposed openstack/puppet-tripleo: Move ceilometer api to run under apache wsgi https://review.openstack.org/352476 | 18:02 |
EmilienM | iberezovskiy: thx a lot | 18:07 |
iberezovskiy | EmilienM, thx for the patience. mwhahaha can land both patches then | 18:10 |
iberezovskiy | I'm off for today | 18:10 |
*** iberezovskiy is now known as iberezovskiy|off | 18:10 | |
*** xarses_ has quit IRC | 18:13 | |
dmsimard | EmilienM: hi | 18:16 |
dmsimard | This is sort of weird: https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L88 | 18:16 |
dmsimard | Since the module includes itself (rather than copy itself?), it installs the master branch of puppet-openstack-integration in /etc/puppet/modules instead of whatever version I'm executing run_tests.sh from | 18:17 |
dmsimard | so for instance I'm trying to reproduce the designate issues outside the gate to troubleshoot and it's unable to find openstack_integration::designate because the master branch doesn't have it | 18:18 |
dmsimard | Shouldn't p-o-i do a puppet module install of itself or something like that instead ? | 18:18 |
mwhahaha | zuul cloner overwrites it i think | 18:22 |
mwhahaha | in the gate | 18:23 |
*** gfidente has quit IRC | 18:24 | |
*** laurosn2 has joined #puppet-openstack | 18:26 | |
*** _ducttape_ has joined #puppet-openstack | 18:27 | |
dmsimard | I'm testing outside the gate, though :p | 18:27 |
EmilienM | dmsimard: hi | 18:28 |
EmilienM | I see your problem | 18:28 |
EmilienM | you'll need to hack something in functions | 18:29 |
*** ducttape_ has quit IRC | 18:30 | |
dmsimard | EmilienM: here? https://github.com/openstack/puppet-openstack-integration/blob/master/functions#L67 | 18:32 |
EmilienM | maybe yeah | 18:33 |
dmsimard | and the hack would be to delete the openstack_integration module from /etc/puppet/modules and copy itself to /etc/puppet/modules ? | 18:33 |
dmsimard | :( | 18:33 |
*** degorenko is now known as _degorenko|afk | 18:37 | |
openstackgerrit | Lars Kellogg-Stedman proposed openstack/puppet-tripleo: [WIP] updates to fluentd support https://review.openstack.org/353507 | 18:48 |
EmilienM | mwhahaha: we good for https://review.openstack.org/#/c/355632/ ? | 18:51 |
mwhahaha | not yet, trying to land the fuel fix (waiting on ci) | 18:51 |
mwhahaha | if it doesn't come through i'll just land that one anyway in a bit | 18:51 |
mwhahaha | https://review.openstack.org/#/c/356336/ if you're following along at home :D | 18:52 |
EmilienM | sorry to push | 18:52 |
EmilienM | the reason is tripleo CI blocked for 3 days | 18:52 |
mwhahaha | no it's ok, i'm hoping in the next hour | 18:53 |
EmilienM | kk | 18:53 |
iurygregory | EmilienM, can you ping when TripleO be unblocked? =) | 18:54 |
*** _ducttape_ has quit IRC | 18:56 | |
*** ducttape_ has joined #puppet-openstack | 18:57 | |
EmilienM | iurygregory: when the puppet-ironic is merged :) | 18:57 |
iurygregory | EmilienM, ok ;D | 18:58 |
*** paramite has joined #puppet-openstack | 18:59 | |
*** laurosn2 has quit IRC | 19:07 | |
*** beagles is now known as beagles_biab | 19:08 | |
*** paramite has quit IRC | 19:08 | |
*** danpawlik has joined #puppet-openstack | 19:15 | |
mwhahaha | life in openstack, watching paint dry aka waiting for CI | 19:20 |
EmilienM | lol | 19:21 |
iurygregory | mwhahaha, go watch the olympic games XD | 19:21 |
danpawlik | mwhahaha: xD | 19:21 |
iurygregory | while you wait for CI | 19:21 |
EmilienM | I don't have a TV :( | 19:22 |
iurygregory | EmilienM, internet LOL | 19:22 |
EmilienM | what is that? | 19:22 |
mwhahaha | nbc has a lock on the coverage in the US (and it's awful) | 19:22 |
EmilienM | I'm really old school | 19:22 |
EmilienM | my laptop crash when I run youtube video | 19:23 |
iurygregory | EmilienM, LOL | 19:23 |
EmilienM | I have a tablet | 19:23 |
iurygregory | you have a mac no? | 19:23 |
EmilienM | no | 19:23 |
iurygregory | sad =( | 19:23 |
EmilienM | old dell xps :P | 19:23 |
mwhahaha | he runs linux i think so that's probably the problem ;) | 19:23 |
iurygregory | linux is not the problem hahah we watch olympic games in the second monitor here at the lab :D | 19:24 |
EmilienM | I'm watching zuul | 19:25 |
EmilienM | which is more than olympic game | 19:25 |
iurygregory | Yeah | 19:26 |
EmilienM | "trying to make CI working" is like olympic sometimes | 19:26 |
EmilienM | but we'll survive | 19:26 |
EmilienM | if mwhahaha merges my patch | 19:27 |
EmilienM | :-P | 19:27 |
EmilienM | /rent | 19:27 |
mwhahaha | sooon | 19:27 |
EmilienM | /rant* even | 19:27 |
iurygregory | EmilienM, the sab pat is that you don't recive a gold medal for have the CI working haha | 19:27 |
iurygregory | sad* | 19:27 |
*** ayoung has quit IRC | 19:27 | |
*** danpawlik has quit IRC | 19:28 | |
EmilienM | we all receive a medal | 19:28 |
EmilienM | the medal will be Newton release | 19:28 |
*** _ducttape_ has joined #puppet-openstack | 19:28 | |
*** xarses_ has joined #puppet-openstack | 19:29 | |
* mwhahaha grumbles about memory utilization | 19:30 | |
iurygregory | EmilienM, good one :D | 19:30 |
mwhahaha | almost there on fuel ci, deploy passed just waiting for health checks so i can merge that patch (hopefully in the next 5-10 mins) | 19:30 |
*** ducttape_ has quit IRC | 19:32 | |
EmilienM | ok | 19:33 |
*** johnmilton has quit IRC | 19:34 | |
*** xarses_ has quit IRC | 19:34 | |
*** xarses_ has joined #puppet-openstack | 19:44 | |
mwhahaha | yay it passed come on jenkins | 19:44 |
*** danpawlik has joined #puppet-openstack | 19:45 | |
-openstackstatus- NOTICE: The volume for logs.openstack.org filled up rather suddenly, causing a number of jobs to fail with a POST_FAILURE result and no logs; we're manually expiring some logs now to buy breathing room, but any changes which hit that in the past few minutes will need to be rechecked and/or approved again | 19:46 | |
mwhahaha | booo logs.openstack.org | 19:46 |
EmilienM | yay | 19:47 |
*** _ducttape_ has quit IRC | 19:49 | |
mwhahaha | hmm | 19:49 |
*** ducttape_ has joined #puppet-openstack | 19:50 | |
mwhahaha | i guess i was looking at the wrong tab, it failed let me double check it's not related and i might just force it | 19:51 |
mwhahaha | EmilienM: just merge your change to unblock tripleo and i'll work on getting the fuel patch landed soon | 19:52 |
*** dgurtner has quit IRC | 19:52 | |
mwhahaha | pesky CI shenanigans today | 19:52 |
EmilienM | mwhahaha: i don't want to break your CI too | 19:52 |
mwhahaha | it's already hosed for probably completely unrelated reasons | 19:53 |
mwhahaha | i've retriggered the fuel-ci for it so it'll be another 2 hours before it comes back | 19:54 |
EmilienM | dang | 19:58 |
EmilienM | we really need to land this patch in puppet-ironic | 19:58 |
mwhahaha | EmilienM: did you see https://review.openstack.org/#/c/355203/ | 19:58 |
EmilienM | mwhahaha: no | 19:58 |
EmilienM | thanks | 19:58 |
EmilienM | looking | 19:59 |
EmilienM | mwhahaha: -2 | 19:59 |
mwhahaha | :o | 19:59 |
EmilienM | -6 | 20:00 |
EmilienM | I wish I could -6 sometimes | 20:00 |
EmilienM | mwhahaha: do we wait 2 more hours? lol | 20:01 |
mwhahaha | just land it | 20:02 |
*** rwsu has joined #puppet-openstack | 20:02 | |
mwhahaha | it doesn't break noop or anything and we don't test ironic in CI | 20:02 |
mwhahaha | i'll get our fix landed later today | 20:02 |
mwhahaha | or i will | 20:03 |
EmilienM | ok thx | 20:03 |
*** xarses_ has quit IRC | 20:12 | |
*** xarses_ has joined #puppet-openstack | 20:12 | |
*** danpawlik has quit IRC | 20:17 | |
*** danpawlik has joined #puppet-openstack | 20:17 | |
*** ayoung has joined #puppet-openstack | 20:18 | |
*** jayg is now known as jayg|g0n3 | 20:18 | |
*** dprince has quit IRC | 20:19 | |
EmilienM | mwhahaha: wdyt about https://review.openstack.org/#/c/354872/ until puppetlabs release > 4.6.0 ? | 20:21 |
mwhahaha | i guess as a temporary thing | 20:21 |
mwhahaha | but the number of places we need to do that for various modules is quite annoying | 20:22 |
EmilienM | puppet-keystone is kind of prio | 20:22 |
mwhahaha | yea | 20:22 |
EmilienM | as it breaks beaker jobs | 20:22 |
EmilienM | other projects *only* have unit-latest broken | 20:23 |
EmilienM | which is non voting | 20:23 |
mwhahaha | better to pin to puppet agent 1.5.2? | 20:23 |
mwhahaha | cause that's ultimately what's doing it | 20:23 |
mwhahaha | i think we'll end up with weird parse order issues if we have to go include everything | 20:23 |
*** cdelatte has quit IRC | 20:25 | |
*** danpawlik has quit IRC | 20:25 | |
mfisch | chem: ping | 20:27 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-guide: CI: updates about current jobs https://review.openstack.org/354122 | 20:27 |
EmilienM | mfisch: what's up | 20:28 |
mfisch | working on this weird domain Id bug with franza | 20:28 |
mfisch | we can see the default domain Id changing after a resource is made | 20:28 |
mfisch | kinda strange | 20:28 |
mfisch | http://paste.openstack.org/show/559094/ | 20:29 |
mfisch | after we create the heat domain the default domain ID changes | 20:29 |
EmilienM | you running master? | 20:29 |
mfisch | which is wrong | 20:29 |
EmilienM | fork? | 20:29 |
mfisch | no | 20:29 |
mfisch | you think this is fixed? | 20:29 |
mfisch | we're a bit behind but thise code looks the same from what I saw | 20:29 |
EmilienM | no, just making sure we test the same code | 20:29 |
EmilienM | what is your manifest? | 20:30 |
EmilienM | can we reproduce in CI? our scripts test idempotency | 20:30 |
mfisch | We're from March 16 | 20:30 |
mfisch | do we create a domain in any of our tests? | 20:30 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration: nova: switch libvirt_virt_type from qemu to kvm https://review.openstack.org/356695 | 20:31 |
EmilienM | dmsimard: ^ | 20:31 |
dmsimard | EmilienM: http://logs.openstack.org/99/355599/1/check/gate-tempest-dsvm-full-ubuntu-xenial/fbe5f9b/logs/etc/nova/nova.conf.txt.gz | 20:31 |
EmilienM | mfisch: lol | 20:31 |
EmilienM | is it a real question ahah | 20:31 |
dmsimard | virt_type = qemu | 20:32 |
EmilienM | dmsimard: ah so I can cancelt it | 20:32 |
mfisch | hah I dont even remember | 20:32 |
EmilienM | mfisch: https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/default_domain_spec.rb | 20:32 |
EmilienM | mfisch: look in https://github.com/openstack/puppet-keystone/tree/master/spec/acceptance :) | 20:32 |
dmsimard | EmilienM: well, no | 20:32 |
dmsimard | EmilienM: feel free to let it go | 20:32 |
EmilienM | mfisch: we also test here: https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/keystone_wsgi_apache_spec.rb | 20:33 |
EmilienM | dmsimard: let's see how it works :) | 20:33 |
mfisch | EmilienM: I bet I could get this to fail by changing the intergration tests | 20:34 |
EmilienM | sure, please try | 20:35 |
EmilienM | mfisch: again, what is your manifest? | 20:35 |
*** Jokke_ has quit IRC | 20:35 | |
mfisch | EmilienM: adding to the bug | 20:35 |
mfisch | LP 1614141 | 20:36 |
openstack | Launchpad bug 1614141 in puppet-keystone "Need to create heat domain without changing the default_domain_id" [Undecided,New] https://launchpad.net/bugs/1614141 | 20:36 |
mfisch | pretty basic just some ensure resources | 20:36 |
mfisch | on keystone_domain | 20:36 |
*** Jokke_ has joined #puppet-openstack | 20:37 | |
openstackgerrit | Merged openstack/puppet-ironic: conductor: add api_url parameter https://review.openstack.org/355632 | 20:38 |
*** danpawlik has joined #puppet-openstack | 20:38 | |
EmilienM | mfisch: why don't use use https://github.com/openstack/puppet-heat/blob/master/manifests/keystone/domain.pp ? | 20:39 |
mfisch | lol because of the other bug I filed earlier that you commented on | 20:39 |
mfisch | heat and Keystone on different nodes | 20:39 |
mfisch | thats where the code came from | 20:39 |
EmilienM | ah | 20:39 |
EmilienM | indeed | 20:40 |
*** rcernin has quit IRC | 20:40 | |
EmilienM | what I would do is : | 20:41 |
EmilienM | 1) patch heat::keystone::domain to add a new conditional if $manage_heat_config | 20:41 |
EmilienM | 2) use heat::keystone::domain on keystone server and set manage_domain, manage_user and manage_role to True | 20:41 |
EmilienM | 3) use heat::keystone::domain and set $manage_heat_config to True and the other to False | 20:42 |
EmilienM | and honestly, I don't understand 100% the bug description | 20:43 |
EmilienM | "Even if I set the identity/default_domain_id to default, the mistake persists." | 20:43 |
EmilienM | from keystone.conf? | 20:43 |
EmilienM | did you configure something into heat.conf? | 20:44 |
EmilienM | and why did you mention the idempotency problem, which isn't mentionned in the bug report | 20:44 |
*** ansmith has quit IRC | 20:47 | |
mfisch | EmilienM: I think I found it | 20:47 |
mfisch | weird corner case | 20:47 |
mfisch | will update the bug | 20:47 |
EmilienM | bug set to incomplete | 20:47 |
EmilienM | yeah and please make it a bit more clear | 20:48 |
EmilienM | mfisch: and also please submit a patch into puppet-heat | 20:48 |
EmilienM | do not duplicate code like this in your manifests, this is really durty | 20:48 |
*** danpawlik has quit IRC | 20:48 | |
mfisch | agreed on dirty | 20:48 |
EmilienM | your use case is really valid (containers) | 20:48 |
mfisch | EmilienM: this bug happens when the default domain is NOT in your catalog and a non-default domain IS | 20:48 |
EmilienM | mhh i'm not sure to get it :) | 20:49 |
mfisch | confirming now | 20:49 |
mfisch | you can make a catalog that does not define the default domain | 20:49 |
mfisch | but that does define a domain called "matt" | 20:49 |
mfisch | then this code fails | 20:49 |
openstackgerrit | David Moreau Simard proposed openstack/puppet-openstack-integration: Parameterize the libvirt_virt_type parameter so it can be overridden https://review.openstack.org/356708 | 20:51 |
EmilienM | mfisch: so in our CI we do not define a default domain | 20:52 |
EmilienM | https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/keystone.pp#L52 | 20:52 |
mfisch | openning all your CI link spam again mon ami | 20:52 |
EmilienM | you say, if I add keystone_domain { 'mfish' } it will fail? | 20:52 |
mfisch | I can make it not fail if you set is_default to false on the mfish | 20:53 |
mfisch | the failure is just a warning | 20:53 |
EmilienM | mfisch: can you look https://github.com/openstack/puppet-openstack-integration/blob/master/manifests/keystone.pp and try to submit a patch that test this corner case? | 20:53 |
EmilienM | I'm really unsure about how to reproduce it | 20:54 |
EmilienM | and you seem the best person to do it | 20:54 |
mfisch | EmilienM: can I just fork this test and push a review up? | 20:54 |
mfisch | will that show it? | 20:54 |
iurygregory | what error you get mfisch ? | 20:54 |
mfisch | iurygregory: a warning | 20:54 |
mfisch | let me update the bug since nothing is clear right now | 20:55 |
mfisch | but I could break this test easily | 20:55 |
EmilienM | mfisch: fork what? | 20:55 |
EmilienM | this is not a test | 20:55 |
EmilienM | this is a manifest | 20:55 |
mfisch | sure | 20:55 |
mfisch | an integraton manifest | 20:55 |
mfisch | I can make one that breaks by changing about 8 lines | 20:55 |
EmilienM | we have 3 scenarios, right? | 20:55 |
EmilienM | they run keystone | 20:56 |
EmilienM | so modify this keystone.pp to make it fail and we'll see what is the problem | 20:56 |
mfisch | yep ok | 20:57 |
EmilienM | thanks! | 20:57 |
mfisch | iurygregory: updated | 20:59 |
mfisch | https://bugs.launchpad.net/puppet-keystone/+bug/1614141 | 20:59 |
openstack | Launchpad bug 1614141 in puppet-keystone "creating a keystone_domain can make it the default even though is_default is false" [Undecided,Incomplete] | 20:59 |
mfisch | see if that makes sense to you ^ | 20:59 |
mfisch | I'm going to work on the integration for slave driver EmilienM ;) | 20:59 |
openstackgerrit | Charlie Llewellyn proposed openstack/puppet-cinder: Fixed alginment and added test https://review.openstack.org/356359 | 21:00 |
iurygregory | mfisch, tks I'll look at home =) | 21:03 |
EmilienM | mfisch: lol | 21:03 |
mfisch | iurygregory: can I have my guy re-file the bug in portuguese? | 21:04 |
iurygregory | mfisch, oh is the laurosn problem? | 21:05 |
iurygregory | O.o | 21:05 |
mfisch | iurygregory: this guy went to your school | 21:05 |
mfisch | he lives here now | 21:05 |
*** danpawlik has joined #puppet-openstack | 21:05 | |
iurygregory | mfisch, oh awesome XD , there is no need to be in portugiese =) | 21:06 |
mfisch | I was j/k | 21:07 |
mfisch | just cool that 2 guys fro the same school working on this | 21:07 |
iurygregory | I'll try to help be sure o/ just need to finish internal things for tomorrow deadline | 21:08 |
openstackgerrit | Matt Fischer proposed openstack/puppet-openstack-integration: Break tests for 1614141 https://review.openstack.org/356726 | 21:09 |
mfisch | EmilienM: I think thats all you need for a corner case ^ | 21:10 |
mfisch | let me make a better commit msg | 21:10 |
openstackgerrit | Matt Fischer proposed openstack/puppet-openstack-integration: Break tests for 1614141 https://review.openstack.org/356726 | 21:11 |
mfisch | iurygregory: so this was originally filed by a guy you met, Franza | 21:14 |
mfisch | Franciraldo | 21:14 |
iurygregory | mfisch, yeah i saw the comments in bug :D | 21:14 |
EmilienM | oh wow | 21:17 |
EmilienM | https://review.openstack.org/#/c/356695/ | 21:17 |
EmilienM | dmsimard: ^ it pass CI | 21:17 |
openstackgerrit | David Moreau Simard proposed openstack/puppet-openstack-integration: Parameterize the libvirt_virt_type parameter so it can be overridden https://review.openstack.org/356708 | 21:17 |
dmsimard | EmilienM: lol wtf | 21:17 |
dmsimard | EmilienM: well | 21:17 |
dmsimard | EmilienM: I /think/ nested KVM works, even without kvm_nested=1 | 21:18 |
dmsimard | It'll just be slow because hardware extensions aren't exposed | 21:18 |
EmilienM | virt_type=kvm | 21:18 |
bkero | It will fall back to qemu | 21:18 |
dmsimard | bkero: you think ? | 21:18 |
bkero | That's how I've seen it behave | 21:18 |
EmilienM | can you see in our logs? http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/ | 21:18 |
EmilienM | if we actually run kvm? | 21:18 |
bkero | dmsimard: Yeah, I've seen whole clouds accidentally not kvm_nested=1, and everything worked. VMs were just slow. | 21:19 |
EmilienM | I see in http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/dstat.txt.gz | 21:19 |
dmsimard | EmilienM: we'd probably see it here if tempest wouldn't kill the VMs http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/ps.txt.gz | 21:19 |
EmilienM | qemu-kvm | 21:19 |
EmilienM | you can see it in dstat | 21:19 |
dmsimard | EmilienM: oh, and otherwise you'd just have qemu ? | 21:19 |
EmilienM | ah no | 21:19 |
EmilienM | qemu-kvm is also started on other jobs without this patch | 21:20 |
EmilienM | how can we check? | 21:20 |
bkero | That's just the binary name I think. | 21:20 |
dmsimard | yeah, you kinda need the whole process line and args to check what hypervisor it runs | 21:20 |
EmilienM | in libvirt logs? http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/libvirt/qemu/ | 21:20 |
EmilienM | I have one: | 21:20 |
bkero | The option is -enable-kvm | 21:20 |
EmilienM | http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/libvirt/qemu/instance-0000000b.txt.gz | 21:20 |
dmsimard | like http://paste.openstack.org/show/559102/ | 21:20 |
bkero | or I guess passing -machine=blah,accel=kvm | 21:20 |
dmsimard | http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/libvirt/qemu/instance-0000000b.txt.gz looks right to me | 21:21 |
EmilienM | I have accel=kvm | 21:21 |
bkero | If it didn't throw a "no kvm support" message, it is probably enabled | 21:21 |
EmilienM | oh ben is right | 21:21 |
bkero | qemu throws that to stdout/stderr | 21:21 |
EmilienM | looks this is a job without kvm: | 21:21 |
EmilienM | http://logs.openstack.org/45/356245/1/gate/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/528a28f/logs/libvirt/qemu/instance-0000000a.txt.gz | 21:21 |
EmilienM | and there is no accel=kvm | 21:22 |
bkero | accel=tcg. Wonder what tcg is | 21:22 |
EmilienM | let's see in syslog | 21:22 |
EmilienM | http://logs.openstack.org/95/356695/1/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/1741c97/logs/syslog.txt.gz#_Aug_17_20_44_32 | 21:22 |
dmsimard | that ran on centos-7-osic-cloud1-3573896 | 21:22 |
EmilienM | Hypervisor detected: KVM | 21:22 |
EmilienM | ah nevermind | 21:22 |
bkero | TCG = tiny code generator, probably some HLE | 21:22 |
EmilienM | it's the VM itself | 21:22 |
dmsimard | I'd be curious to check something off of Rackspace, which runs Xen | 21:22 |
bkero | Do you have the output of /proc/cpuinfo? | 21:23 |
bkero | Can check for 'vmx' flag | 21:23 |
dmsimard | lol, all 6 jobs ran from osic | 21:23 |
dmsimard | T_T | 21:23 |
bkero | http://logs.openstack.org/45/356245/1/gate/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/528a28f/logs/cpuinfo.txt.gz looks so | 21:23 |
dmsimard | Maybe osic exposes nested and stuff | 21:23 |
dmsimard | I would expect the job to fail on other providers | 21:23 |
EmilienM | we can do recheck to see if it works again | 21:24 |
dmsimard | EmilienM: can we do a recheck until we hit something else than osic | 21:24 |
EmilienM | maybe we can use facter to determine if nested virt is enabled | 21:25 |
EmilienM | and whether or not set qemu as value | 21:25 |
EmilienM | but yeah, it's weird kvm is not tested | 21:25 |
EmilienM | dmsimard: osic is not like other rackspace clouds FYI | 21:26 |
EmilienM | it's not rackspace cloud servers, etc | 21:26 |
EmilienM | it's another project afik | 21:26 |
* dmsimard shrugs | 21:27 | |
bkero | Different clouds pass different settings to their hypervisors. I wouldn't necessarily expect nested=1 everywhere | 21:27 |
dmsimard | yeah, exactly | 21:27 |
*** gfidente has joined #puppet-openstack | 21:27 | |
dmsimard | especially since it's not a nodepool provider requirement | 21:27 |
dmsimard | (although I would've somehow expected otherwise) | 21:28 |
bkero | You could add a new label to zuul and tell it which providers have nested kvm, then have the jobs run on that. | 21:28 |
dmsimard | seriously, we're testing openstack on openstack clouds without nested virt as a requirement | 21:28 |
dmsimard | that sounds pretty awkward | 21:28 |
dmsimard | bkero: not a bad idea | 21:28 |
*** Guest66466 is now known as saneax_AFK | 21:29 | |
openstackgerrit | Merged openstack/puppet-openstack-guide: CI: updates about current jobs https://review.openstack.org/354122 | 21:31 |
bkero | dmsimard: That might not be accepted as an undue burden on a single provider | 21:31 |
bkero | What about doing multinode testing with ironic? | 21:32 |
dmsimard | yeah they're not interested in any way that would facilitate targetting nested virt deployment scenarios | 21:34 |
bkero | clarkb says it's unreliable | 21:34 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-tripleo: (mitaka only) loadbalancer: manage ipv6 sysctl https://review.openstack.org/356755 | 21:42 |
EmilienM | couldn't we use an existing fact? | 21:45 |
EmilienM | to find out if kvm is available? | 21:45 |
dmsimard | EmilienM: but then you'd be sort of randomly testing nested or non-nested | 21:46 |
EmilienM | yeah | 21:46 |
EmilienM | I'll abandon my patch | 21:46 |
EmilienM | it's risky | 21:47 |
EmilienM | I'm sad | 21:47 |
EmilienM | we were the first one doing that :P | 21:47 |
dmsimard | EmilienM: I submitted https://review.openstack.org/#/c/356708/ | 21:47 |
dmsimard | I'll leverage it with weirdo. | 21:47 |
EmilienM | I saw | 21:47 |
EmilienM | -6 | 21:47 |
dmsimard | ? | 21:47 |
EmilienM | it's my new score | 21:48 |
EmilienM | ok I go running now, please don't break CI | 21:48 |
dmsimard | SPACESHIP OPERATOR | 21:51 |
dmsimard | I love the name of that operator. | 21:51 |
iurygregory | O.o | 21:51 |
iurygregory | spaceship? | 21:51 |
iurygregory | hahah | 21:51 |
dmsimard | iurygregory: https://docs.puppet.com/puppet/latest/reference/lang_collectors.html | 21:52 |
dmsimard | Resource collectors (AKA the spaceship operator) | 21:52 |
iurygregory | dmsimard, ohhhh | 21:52 |
dmsimard | <| |> looks like a spaceship :) | 21:52 |
EmilienM | <| |> -- -- -- -- <| |> | 21:53 |
EmilienM | it's a battle of spaceships | 21:53 |
EmilienM | ok I go now | 21:53 |
iurygregory | hahahah awesome name | 21:54 |
dmsimard | Is it possible to check the value of another fact within a fact ? | 21:56 |
dmsimard | i.e, a custom fact that'd check the value of another fact in order to return an appropriate value | 21:57 |
dmsimard | or would I need to run a literal "facter" command within the custom fact to retrieve the value | 21:57 |
dmsimard | Ah, you can check with Facter.value(:fact) | 21:59 |
dmsimard | Cool. | 21:59 |
*** ayoung has quit IRC | 22:14 | |
*** amoralej|off has quit IRC | 22:24 | |
dmsimard | EmilienM: fyi, hacky but it works :p https://review.openstack.org/#/c/356774/2/packstack/puppet/modules/packstack/lib/facter/default_hypervisor.rb | 22:26 |
dmsimard | EmilienM: I can submit it to openstacklib in a more generic format if you like the approach | 22:27 |
dmsimard | puppet-nova defaults to kvm | 22:27 |
*** amoralej has joined #puppet-openstack | 22:30 | |
openstackgerrit | Daniel Pawlik proposed openstack/puppet-watcher: Change authtoken to class https://review.openstack.org/356792 | 22:30 |
*** dhollinger has quit IRC | 22:31 | |
*** saneax_AFK is now known as saneax | 22:33 | |
*** saneax is now known as Guest65663 | 22:34 | |
*** danpawlik has quit IRC | 22:37 | |
EmilienM | dmsimard: yes it would work | 22:42 |
EmilienM | well I wouldn't have written a fact for that | 22:42 |
EmilienM | but it works | 22:42 |
*** beagles_biab is now known as beagles | 22:42 | |
dmsimard | EmilienM: it's a required hack in the context of packstack | 22:42 |
EmilienM | i met a spaceship when I ran | 22:42 |
EmilienM | not sure if it's /me tired | 22:43 |
EmilienM | dmsimard: if $::is_virtual { $hypervisor = 'qemu' } else { $hypervisor = 'kvm' } would also work | 22:43 |
dmsimard | That's exactly what Packstack has and it doesn't allow for someone to run qemu on baremetal or kvm on virtual. | 22:44 |
dmsimard | So I made the hypervisor configurable while keeping the same default/backwards compat | 22:44 |
EmilienM | excellent | 22:44 |
EmilienM | +6 | 22:44 |
*** xarses_ has quit IRC | 22:45 | |
*** ducttape_ has quit IRC | 22:58 | |
*** dfisher has quit IRC | 23:02 | |
EmilienM | mfisch: your patch is working well https://review.openstack.org/#/c/356726/ | 23:10 |
EmilienM | I don't see where could be the bug | 23:11 |
EmilienM | at least the puppet runs are idempotent | 23:11 |
*** ayoung has joined #puppet-openstack | 23:18 | |
*** fultonj has quit IRC | 23:37 | |
*** rwsu has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!