*** rwsu has joined #puppet-openstack | 02:06 | |
*** ilbot3 has quit IRC | 02:44 | |
*** ilbot3 has joined #puppet-openstack | 02:56 | |
*** ykarel|away has joined #puppet-openstack | 04:09 | |
*** ykarel|away is now known as ykarel | 04:13 | |
*** skramaja has joined #puppet-openstack | 04:55 | |
*** ratailor has joined #puppet-openstack | 04:59 | |
*** markvoelker has quit IRC | 05:00 | |
*** jaganathan has joined #puppet-openstack | 05:14 | |
*** udesale has joined #puppet-openstack | 05:32 | |
*** markvoelker has joined #puppet-openstack | 06:00 | |
*** vinsh has quit IRC | 06:22 | |
*** vinsh has joined #puppet-openstack | 06:25 | |
*** jtomasek has joined #puppet-openstack | 06:50 | |
*** rcernin has quit IRC | 06:59 | |
*** dtantsur|afk is now known as dtantsur | 07:01 | |
*** spectr has joined #puppet-openstack | 07:11 | |
*** spectr has quit IRC | 07:12 | |
*** oidgar has joined #puppet-openstack | 07:12 | |
*** udesale has quit IRC | 07:32 | |
*** agurenko has joined #puppet-openstack | 07:41 | |
*** ykarel is now known as ykarel|lunch | 07:44 | |
*** shardy has joined #puppet-openstack | 07:49 | |
*** karthiks has quit IRC | 08:06 | |
*** yprokule has joined #puppet-openstack | 08:07 | |
*** ccamacho has joined #puppet-openstack | 08:14 | |
*** rmart04 has joined #puppet-openstack | 08:16 | |
*** udesale has joined #puppet-openstack | 08:19 | |
*** tesseract has joined #puppet-openstack | 08:23 | |
*** karthiks has joined #puppet-openstack | 08:23 | |
*** ykarel|lunch is now known as ykarel | 08:31 | |
*** karthiks has quit IRC | 08:33 | |
*** karthiks has joined #puppet-openstack | 08:33 | |
*** jpena|off is now known as jpena | 08:43 | |
*** amoralej|off is now known as amoralej | 09:01 | |
*** tdasilva has quit IRC | 09:09 | |
*** melodyzhou has joined #puppet-openstack | 09:12 | |
*** melodyzhou has quit IRC | 09:13 | |
*** oidgar has quit IRC | 09:13 | |
*** tdasilva has joined #puppet-openstack | 09:15 | |
*** etingof has quit IRC | 09:16 | |
*** dtantsur_ has joined #puppet-openstack | 09:21 | |
*** dtantsur has quit IRC | 09:22 | |
*** dtantsur_ is now known as dtantsur | 09:22 | |
*** etingof has joined #puppet-openstack | 09:30 | |
*** etingof has quit IRC | 09:35 | |
*** derekh has joined #puppet-openstack | 09:41 | |
*** etingof has joined #puppet-openstack | 09:48 | |
*** gfidente has joined #puppet-openstack | 09:56 | |
*** gfidente has quit IRC | 09:56 | |
*** gfidente has joined #puppet-openstack | 09:56 | |
*** chem has joined #puppet-openstack | 09:56 | |
*** rcernin has joined #puppet-openstack | 10:01 | |
*** salmankhan has joined #puppet-openstack | 10:18 | |
*** ratailor has quit IRC | 10:30 | |
*** ratailor has joined #puppet-openstack | 10:47 | |
*** ratailor_ has joined #puppet-openstack | 10:53 | |
*** ratailor has quit IRC | 10:56 | |
*** udesale has quit IRC | 11:30 | |
*** ansmith has quit IRC | 11:39 | |
*** oidgar has joined #puppet-openstack | 11:48 | |
*** salmankhan has quit IRC | 12:21 | |
*** asilenkov has quit IRC | 12:24 | |
*** asilenkov has joined #puppet-openstack | 12:26 | |
*** salmankhan has joined #puppet-openstack | 12:27 | |
*** morazi has joined #puppet-openstack | 12:43 | |
*** jpena is now known as jpena|lunch | 12:58 | |
*** amoralej is now known as amoralej|lunch | 13:00 | |
*** ansmith has joined #puppet-openstack | 13:12 | |
*** dprince has joined #puppet-openstack | 13:15 | |
*** shardy is now known as shardy_lunch | 13:22 | |
openstackgerrit | Mateusz Kowalski proposed openstack/puppet-ironic master: Allow setting inspector timeout value https://review.openstack.org/521657 | 13:25 |
---|---|---|
openstackgerrit | Mateusz Kowalski proposed openstack/puppet-ironic master: Allow setting inspector timeout value https://review.openstack.org/521657 | 13:29 |
*** rcernin has quit IRC | 13:30 | |
*** ratailor_ is now known as ratailor | 13:31 | |
*** alee has quit IRC | 13:37 | |
*** amoralej|lunch is now known as amoralej | 13:44 | |
*** trown|outtypewww is now known as trown | 13:44 | |
*** udesale has joined #puppet-openstack | 13:45 | |
*** shardy_lunch is now known as shardy | 13:45 | |
*** rmart04 has quit IRC | 13:48 | |
*** jpena|lunch is now known as jpena | 13:50 | |
*** foxhunt_away is now known as foxhunt72 | 13:51 | |
*** skramaja has quit IRC | 14:03 | |
*** jaganathan has quit IRC | 14:12 | |
*** ratailor has quit IRC | 14:21 | |
*** clayton has quit IRC | 14:27 | |
*** clayton has joined #puppet-openstack | 14:30 | |
*** markvoelker has quit IRC | 14:31 | |
*** markvoelker has joined #puppet-openstack | 14:31 | |
openstackgerrit | Pradeep Kilambi proposed openstack/puppet-ceilometer stable/ocata: Add support to set host param https://review.openstack.org/521862 | 14:39 |
*** pradk has joined #puppet-openstack | 14:41 | |
openstackgerrit | Pradeep Kilambi proposed openstack/puppet-ceilometer stable/newton: Add support to set host param https://review.openstack.org/521868 | 14:45 |
*** foxhunt72 is now known as foxhunt_away | 14:48 | |
*** oidgar has quit IRC | 15:03 | |
*** udesale has quit IRC | 15:08 | |
*** agurenko has quit IRC | 15:08 | |
*** agurenko has joined #puppet-openstack | 15:09 | |
*** vinsh has quit IRC | 15:11 | |
*** vinsh has joined #puppet-openstack | 15:12 | |
*** vinsh_ has joined #puppet-openstack | 15:16 | |
*** agurenko has quit IRC | 15:17 | |
*** agurenko has joined #puppet-openstack | 15:18 | |
*** ykarel is now known as ykarel|away | 15:19 | |
*** vinsh has quit IRC | 15:19 | |
*** ykarel|away has quit IRC | 15:24 | |
*** jistr is now known as jistr|mtg | 15:59 | |
openstackgerrit | Merged openstack/puppet-cinder stable/pike: Dell EMC VMAX: Fixes driver dependency using ensure https://review.openstack.org/520150 | 16:00 |
*** vinsh_ has quit IRC | 16:01 | |
*** oidgar has joined #puppet-openstack | 16:12 | |
*** jistr|mtg is now known as jistr | 16:16 | |
*** chem has quit IRC | 16:25 | |
*** vinsh has joined #puppet-openstack | 16:35 | |
EmilienM | mnaser, iurygregory : can you please review https://review.openstack.org/#/c/521593/ ? thanks | 16:38 |
EmilienM | I'll need to backport it as well | 16:38 |
iurygregory | EmilienM, doing now | 16:40 |
EmilienM | thx! | 16:41 |
iurygregory | +A ;) | 16:41 |
*** ccamacho has quit IRC | 16:42 | |
*** salmankhan has quit IRC | 16:42 | |
*** salmankhan has joined #puppet-openstack | 16:44 | |
*** chem has joined #puppet-openstack | 16:45 | |
EmilienM | iurygregory: thx!! | 16:48 |
*** salmankhan has quit IRC | 16:51 | |
*** salmankhan has joined #puppet-openstack | 16:53 | |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration stable/pike: install_modules_unit: list modules https://review.openstack.org/521938 | 16:53 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration stable/ocata: install_modules_unit: list modules https://review.openstack.org/521939 | 16:54 |
openstackgerrit | Emilien Macchi proposed openstack/puppet-openstack-integration stable/newton: install_modules_unit: list modules https://review.openstack.org/521940 | 16:54 |
*** agurenko has quit IRC | 16:54 | |
iurygregory | yw =D | 16:54 |
*** dtantsur is now known as dtantsur|afk | 16:55 | |
*** openstackstatus has quit IRC | 16:58 | |
*** openstackstatus has joined #puppet-openstack | 17:00 | |
*** ChanServ sets mode: +v openstackstatus | 17:00 | |
openstackgerrit | Alex Schultz proposed openstack/puppet-nova stable/ocata: Pass arguments as array for nova-manage provider https://review.openstack.org/521945 | 17:01 |
colonwq | mwhahaha, (or anyone else) My last unit test failure is something basic that I have not figured out how to pass. Any suggestions would be greatly appreciated: http://logs.openstack.org/31/519531/6/check/legacy-puppet-tripleo-puppet-unit-4.8-centos-7/56aa6dd/job-output.txt.gz#_2017-11-16_16_36_57_939706 | 17:02 |
*** ratailor has joined #puppet-openstack | 17:04 | |
mnaser | colonwq: looking | 17:05 |
mnaser | oh thats a puppet-tripleo thing but ill look :p | 17:05 |
mnaser | colonwq: Ceph::Key["client.${cinder_rbd_client_name}"] could not necessarily be defined what you want to do is use a resource collector so id replace it with | 17:06 |
colonwq | One of THOSE patches. :) | 17:06 |
mnaser | Ceph::Key< title == "client.${cinder_rbd_client_name}" > | 17:06 |
mnaser | Ceph::Key< title == "client.${cinder_rbd_client_name}" > -> Exec["exec-setfacl-${cinder_rbd_client_name}-cinder"] | 17:06 |
colonwq | mnaser, I did not know that. I'll update and add the title and test. | 17:07 |
mnaser | colonwq: or alternatively you can add the ceph::key in the unit tests | 17:08 |
*** ntpttr_laptop has joined #puppet-openstack | 17:08 | |
*** tesseract has quit IRC | 17:09 | |
*** ratailor has quit IRC | 17:10 | |
*** ansmith has quit IRC | 17:24 | |
mwhahaha | would be beter to add the proper keys to the test rather than relying on the spaceships | 17:27 |
EmilienM | I think we have a big problem | 17:27 |
EmilienM | but puppet-tripleo/newton unit tests deploys modules from master | 17:27 |
EmilienM | http://logs.openstack.org/81/521281/2/check/puppet-openstack-unit-4.8-centos-7/c6eadd6/job-output.txt.gz#_2017-11-21_17_18_09_132573 | 17:27 |
iurygregory | :O | 17:28 |
* EmilienM eating french croissant | 17:28 | |
EmilienM | oh wait | 17:31 |
EmilienM | no | 17:31 |
EmilienM | nevermind, it's all good | 17:31 |
* EmilienM should really go back to bed | 17:31 | |
iurygregory | or prob you need more coffee EmilienM | 17:34 |
mwhahaha | EmilienM: we need to pin haproxy | 17:36 |
mwhahaha | EmilienM: http://logs.openstack.org/81/521281/2/check/puppet-openstack-unit-4.8-centos-7/c6eadd6/job-output.txt.gz#_2017-11-21_17_19_37_977693 absolutepath wasn't added until after 4.12.0 in puppet stdlib i think | 17:36 |
mwhahaha | EmilienM: http://logs.openstack.org/81/521281/2/check/puppet-openstack-unit-4.8-centos-7/c6eadd6/job-output.txt.gz#_2017-11-21_17_18_11_139943 | 17:37 |
EmilienM | mwhahaha: ahhh | 17:37 |
EmilienM | mwhahaha: and we didn't catch it because we don't use haproxy in p-o-i | 17:37 |
mwhahaha | test is pulling in haproxy 1.5.0 which needs 4.13 | 17:37 |
mwhahaha | so that's the fix | 17:37 |
mwhahaha | either up stdlib or match the packaging of haproxy | 17:37 |
EmilienM | ok, let me check that now | 17:38 |
mwhahaha | yea we package 4.13.1 | 17:38 |
mwhahaha | up stdlib | 17:38 |
EmilienM | in newton: puppet-stdlib-4.13.1-0.20161117202107.dcef77a.el7.centos.noarch | 17:38 |
mwhahaha | https://github.com/redhat-openstack/rdoinfo/blob/master/rdo.yml#L842 | 17:39 |
EmilienM | ok | 17:39 |
EmilienM | I'll do that | 17:39 |
mwhahaha | https://github.com/redhat-openstack/rdoinfo/blob/master/rdo.yml#L649 | 17:39 |
mwhahaha | we use puppet-haproxy 1.5.0 | 17:39 |
EmilienM | are you a bot? you go too fast. | 17:39 |
mwhahaha | i'm in a good mood today | 17:39 |
mwhahaha | ci isn't royally screwed up | 17:39 |
mwhahaha | :D | 17:39 |
EmilienM | good because I'm not | 17:39 |
EmilienM | ok so '4.21.0' in master, but :ref => '4.15.0' in ocata | 17:40 |
mwhahaha | so we're testing with newer | 17:41 |
mwhahaha | cause 4.14.0 is in ocata and 4.18.0 is pike | 17:41 |
EmilienM | master :-O | 17:41 |
EmilienM | I think we should pin puppetlabs-haproxy, no? | 17:42 |
mwhahaha | probably if we're not going to unpin it | 17:42 |
mwhahaha | 1.5.0 is the latest | 17:42 |
EmilienM | it's newton, not going to change I think | 17:42 |
mwhahaha | in newton yea | 17:42 |
mwhahaha | but since it's 1.5.0-2 there might be some hash we have to pin to | 17:42 |
EmilienM | also, master is a bad pin for newton | 17:42 |
EmilienM | imho, we need to pin newton/ocata/pike | 17:43 |
EmilienM | like we do in p-o-i | 17:43 |
EmilienM | otherwise it can break at anytime | 17:43 |
mwhahaha | yes | 17:43 |
EmilienM | ok, I'll do that | 17:43 |
EmilienM | easy task, I can do it | 17:43 |
openstackgerrit | Merged openstack/puppet-openstack-integration master: install_modules_unit: list modules https://review.openstack.org/521593 | 17:43 |
*** derekh has quit IRC | 17:58 | |
*** agurenko has joined #puppet-openstack | 17:58 | |
*** trown is now known as trown|lunch | 18:03 | |
*** jistr is now known as jistr|off|trng | 18:04 | |
*** yprokule has quit IRC | 18:13 | |
*** amoralej is now known as amoralej|off | 18:16 | |
openstackgerrit | Merged openstack/puppet-glance stable/pike: Switch to Zuul v3 testing https://review.openstack.org/519934 | 18:18 |
*** jpena is now known as jpena|off | 18:20 | |
*** ccamacho has joined #puppet-openstack | 18:24 | |
colonwq | mnaser, I got them all fixed. thanks for the help. | 18:25 |
*** shardy has quit IRC | 18:26 | |
iurygregory | EmilienM, if you need the backports merged fast just let me know =) | 18:26 |
EmilienM | that's fine, mwhahaha will get them | 18:27 |
*** ccamacho has quit IRC | 18:33 | |
*** ccamacho has joined #puppet-openstack | 18:36 | |
*** ntpttr_laptop has quit IRC | 18:45 | |
*** ansmith has joined #puppet-openstack | 18:49 | |
*** ntpttr_laptop has joined #puppet-openstack | 18:51 | |
*** oidgar has quit IRC | 19:02 | |
*** trown|lunch is now known as trown | 19:03 | |
*** gfidente is now known as gfidente|afk | 19:20 | |
openstackgerrit | Merged openstack/puppet-nova stable/ocata: Pass arguments as array for nova-manage provider https://review.openstack.org/521945 | 19:26 |
*** ccamacho has quit IRC | 19:28 | |
Kvisle | Can someone look at why https://review.openstack.org/#/c/511730/ is stuck with a downvote from CI? | 19:36 |
openstackgerrit | Merged openstack/puppet-openstack-integration stable/newton: install_modules_unit: list modules https://review.openstack.org/521940 | 19:36 |
Kvisle | oh, it has a merge conflict now. | 19:37 |
openstackgerrit | Merged openstack/puppet-openstack-integration stable/pike: install_modules_unit: list modules https://review.openstack.org/521938 | 19:46 |
*** jtomasek has quit IRC | 19:51 | |
openstackgerrit | Merged openstack/puppet-openstack-integration stable/pike: Add unit jobs in zuul v3 https://review.openstack.org/516518 | 20:04 |
*** morazi has quit IRC | 20:10 | |
*** salmankhan has quit IRC | 20:24 | |
openstackgerrit | Mateusz Kowalski proposed openstack/puppet-ironic master: Allow setting inspector timeout value https://review.openstack.org/521657 | 20:57 |
*** gfidente|afk has quit IRC | 21:07 | |
mgagne | is there a way to not rely on admin_token to provision keystone resources? I see that keystone types still rely on DEFAULT/admin_token | 21:08 |
*** etingof has quit IRC | 21:20 | |
*** etingof has joined #puppet-openstack | 21:22 | |
mwhahaha | thought we made that optional | 21:23 |
mwhahaha | mgagne: what version? i don't see any references to auth_token | 21:25 |
mgagne | mwhahaha: https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L187-L189 | 21:26 |
mgagne | but maybe I'm misreading the code | 21:27 |
mgagne | and in fact, I didn't see the call to super | 21:27 |
mwhahaha | oh i was looking for auth_token | 21:27 |
mgagne | and I suspect the parent class is the one supporting password auth | 21:27 |
mwhahaha | it falls back to admin token | 21:27 |
mwhahaha | if normal auth fails | 21:28 |
mwhahaha | https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L233 | 21:28 |
mwhahaha | so if you have normal auth it should use that | 21:28 |
mgagne | awesome, will try, thanks! | 21:28 |
mwhahaha | https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L77 | 21:29 |
mwhahaha | and our credentials stuff https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/credentials.rb | 21:29 |
mgagne | I'm just missing the link between those 2, what injects credentials? | 21:30 |
mwhahaha | didn't you write this stuff? :D | 21:30 |
mgagne | no lol | 21:30 |
mgagne | I'll keep digging and will figure out something for sure | 21:30 |
mwhahaha | it's all black magic | 21:31 |
mgagne | not a bad thing to get familiar with this part of the code | 21:31 |
mgagne | hehe | 21:31 |
mwhahaha | https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/auth.rb | 21:31 |
mgagne | provider extends auth which provides request already: https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack/auth.rb#L35 | 21:31 |
mwhahaha | because https://github.com/openstack/puppet-keystone/blob/master/lib/puppet/provider/keystone.rb#L9 | 21:31 |
mgagne | yea | 21:31 |
mgagne | good stuff | 21:31 |
*** etingof has quit IRC | 21:31 | |
mgagne | now to remove that middleware from our internal boxes :D | 21:31 |
mgagne | thanks for the help! | 21:32 |
*** etingof has joined #puppet-openstack | 21:32 | |
mwhahaha | yea that was 2 cycles ago i think when they killed of that | 21:32 |
mgagne | one last thing | 21:32 |
mgagne | /root/openrc | 21:32 |
mgagne | I don't really like that it's hardcoded here | 21:32 |
mwhahaha | it also accepts ENV vars from the run if that file isn't there | 21:33 |
mwhahaha | so you can just pass them in to the puppet execution | 21:33 |
mgagne | yea, but not gonna happen :P | 21:33 |
* mwhahaha shrugs | 21:33 | |
mwhahaha | unfortunately we have to know where to go looking | 21:33 |
mgagne | would there be a way to make it configurable and/or consider more Puppetish path? | 21:33 |
mwhahaha | so you could extend it but there has to be somewhere | 21:33 |
mgagne | like is there a "standard" path where Puppet stores secrets or credentials? | 21:33 |
mwhahaha | there isn't | 21:34 |
mwhahaha | unless you do like eyaml or some trickery with hiera | 21:34 |
mgagne | =( | 21:34 |
mwhahaha | which is way too complex for this | 21:34 |
mgagne | yea | 21:34 |
mwhahaha | it's not really hard coded as you could in theory run it as a different user | 21:34 |
mgagne | ok, will continue to check then. thanks! | 21:34 |
mgagne | well... wouldn't be an easy task ;) | 21:35 |
mwhahaha | right so that's why it's /root/openrc :D | 21:35 |
mgagne | /etc/puppetlabs/puppet/openrc? =) | 21:35 |
mwhahaha | no because perms | 21:35 |
mwhahaha | it's your admin creds for your cloud | 21:36 |
mgagne | isn't puppet already running as root? | 21:36 |
mwhahaha | right so why not keep the important cred file locked up in /root | 21:36 |
mwhahaha | which other users probably don't have access to | 21:36 |
mgagne | because I feel root is for user stuff, not system stuff | 21:36 |
*** dprince has quit IRC | 21:37 | |
mwhahaha | if you want to suggest an optional path then sure | 21:37 |
mwhahaha | but it would still need to look in /root/openrc for backwards compatibility | 21:37 |
mwhahaha | patches welcome :D | 21:37 |
mwhahaha | but it's not a foreign concept to keep the cloud rc file in /root | 21:38 |
mgagne | oh yea, I'm not the kind of guy to break backward compat =) | 21:38 |
mwhahaha | it's been this way since kilo, https://github.com/openstack/puppet-openstacklib/blob/kilo-eol/lib/puppet/provider/openstack/auth.rb#L5 | 21:38 |
mwhahaha | so | 21:38 |
mgagne | I agree but we do have human using root and messing with /root/openrc without knowing that a service/system reads it | 21:38 |
mwhahaha | it's got a long history | 21:38 |
mwhahaha | well perhaps your humans should keep their dirty hands off that file :D | 21:39 |
mgagne | they are humans, what can you do :D | 21:39 |
mwhahaha | electro shock therapy | 21:39 |
mwhahaha | or puppetize it https://github.com/openstack/puppet-openstack_extras/blob/master/manifests/auth_file.pp | 21:40 |
mgagne | suggestion duly noted :D | 21:40 |
*** salmankhan has joined #puppet-openstack | 21:49 | |
*** rcernin has joined #puppet-openstack | 21:50 | |
*** salmankhan has quit IRC | 21:54 | |
*** trown is now known as trown|outtypewww | 21:58 | |
*** hjensas has quit IRC | 22:10 | |
*** etingof has quit IRC | 22:13 | |
*** markvoelker has quit IRC | 22:16 | |
*** markvoelker has joined #puppet-openstack | 22:27 | |
*** etingof has joined #puppet-openstack | 22:35 | |
*** salmankhan has joined #puppet-openstack | 22:57 | |
*** salmankhan has quit IRC | 23:06 | |
*** bnemec has quit IRC | 23:09 | |
*** hjensas has joined #puppet-openstack | 23:11 | |
*** bnemec has joined #puppet-openstack | 23:12 | |
*** hjensas has quit IRC | 23:36 | |
*** ntpttr_laptop has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!