Tuesday, 2018-04-03

« Monday, 2018-04-02 Index Wednesday, 2018-04-04 »
*** jistr has quit IRC00:02
*** jistr has joined #puppet-openstack00:03
*** andreww has quit IRC00:35
*** markvoelker_ has joined #puppet-openstack01:02
*** markvoelker has quit IRC01:06
*** gyankum has joined #puppet-openstack01:14
openstackgerritMerged openstack/puppet-openstack-cookiecutter master: Support puppet 4.8 and latest for libraries unit test  https://review.openstack.org/55568401:18
openstackgerritMerged openstack/puppet-modulesync-configs master: Support puppet 4.8 and latest for libraries unit test  https://review.openstack.org/55568501:18
*** ilbot3 has quit IRC01:46
openstackgerritMerged openstack/puppet-openstack_spec_helper master: Support puppet 4.8 and latest for libraries unit test  https://review.openstack.org/55568101:50
*** ilbot3 has joined #puppet-openstack01:56
*** armaan_ has quit IRC02:30
*** armaan has joined #puppet-openstack02:31
openstackgerritzhongshengping proposed openstack/puppet-aodh master: Deprecate auth_uri option  https://review.openstack.org/55834003:02
*** gyan_ has joined #puppet-openstack03:04
*** gyankum has quit IRC03:04
*** gyan__ has joined #puppet-openstack03:05
*** gyan_ has quit IRC03:09
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834403:17
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834403:17
openstackgerritzhongshengping proposed openstack/puppet-aodh master: Deprecate auth_uri option  https://review.openstack.org/55834003:17
*** ykarel|away has joined #puppet-openstack03:49
*** ykarel|away is now known as ykarel04:05
*** markvoelker_ has quit IRC04:16
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834404:53
*** jaosorior has joined #puppet-openstack04:57
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri option  https://review.openstack.org/55836104:57
openstackgerritzhongshengping proposed openstack/puppet-keystone master: Deprecate auth_uri option  https://review.openstack.org/55834404:58
openstackgerritzhongshengping proposed openstack/puppet-aodh master: Deprecate auth_uri option  https://review.openstack.org/55834004:59
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836105:01
*** jtomasek has joined #puppet-openstack05:34
*** jtomasek has quit IRC05:35
*** jtomasek has joined #puppet-openstack05:51
*** markvoelker has joined #puppet-openstack06:17
*** cgfbee has quit IRC06:48
*** markvoelker has quit IRC06:51
*** armaan_ has joined #puppet-openstack06:53
*** armaan has quit IRC06:53
*** cgfbee has joined #puppet-openstack06:54
*** tesseract has joined #puppet-openstack07:00
openstackgerritDaniel Pawlik proposed openstack/puppet-openstack-integration master: Enable Mistral tests  https://review.openstack.org/55283307:03
*** ykarel_ has joined #puppet-openstack07:04
*** gyan_ has joined #puppet-openstack07:04
*** gyan__ has quit IRC07:04
*** ykarel has quit IRC07:04
*** gyan__ has joined #puppet-openstack07:05
*** ykarel__ has joined #puppet-openstack07:06
openstackgerritDaniel Pawlik proposed openstack/puppet-openstack-integration master: Enable Mistral tests  https://review.openstack.org/55283307:09
*** gyan_ has quit IRC07:09
*** ykarel_ has quit IRC07:09
openstackgerritDaniel Pawlik proposed openstack/puppet-openstack-integration master: Enable Mistral tests  https://review.openstack.org/55283307:10
*** ykarel__ is now known as ykarel07:30
*** amoralej|off is now known as amoralej07:34
*** jpena|off is now known as jpena07:37
*** jaosorior has quit IRC07:38
*** skramaja has joined #puppet-openstack07:39
*** jaosorior has joined #puppet-openstack07:44
*** markvoelker has joined #puppet-openstack07:47
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55841907:59
*** vnogin has joined #puppet-openstack08:10
*** vnogin has quit IRC08:11
*** shardy has joined #puppet-openstack08:11
*** vnogin has joined #puppet-openstack08:12
*** markvoelker has quit IRC08:21
*** agurenko has joined #puppet-openstack08:23
*** vnogin has quit IRC08:29
*** vnogin has joined #puppet-openstack08:34
openstackgerritzhongshengping proposed openstack/puppet-aodh master: Deprecate auth_uri option  https://review.openstack.org/55834008:49
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55836108:50
openstackgerritzhongshengping proposed openstack/puppet-trove master: Deprecate auth_uri option  https://review.openstack.org/55843108:55
openstackgerritzhongshengping proposed openstack/puppet-congress master: Deprecate auth_uri option  https://review.openstack.org/55843208:55
openstackgerritzhongshengping proposed openstack/puppet-freezer master: Deprecate auth_uri option  https://review.openstack.org/55843308:55
openstackgerritzhongshengping proposed openstack/puppet-vitrage master: Deprecate auth_uri option  https://review.openstack.org/55843408:55
openstackgerritzhongshengping proposed openstack/puppet-magnum master: Deprecate auth_uri option  https://review.openstack.org/55843508:55
openstackgerritzhongshengping proposed openstack/puppet-mistral master: Deprecate auth_uri option  https://review.openstack.org/55843608:55
openstackgerritzhongshengping proposed openstack/puppet-watcher master: Deprecate auth_uri option  https://review.openstack.org/55843708:55
openstackgerritzhongshengping proposed openstack/puppet-tacker master: Deprecate auth_uri option  https://review.openstack.org/55843808:55
openstackgerritzhongshengping proposed openstack/puppet-octavia master: Deprecate auth_uri option  https://review.openstack.org/55843908:55
openstackgerritzhongshengping proposed openstack/puppet-glare master: Deprecate auth_uri option  https://review.openstack.org/55844008:55
openstackgerritzhongshengping proposed openstack/puppet-ec2api master: Deprecate auth_uri option  https://review.openstack.org/55844108:55
openstackgerritzhongshengping proposed openstack/puppet-sahara master: Deprecate auth_uri option  https://review.openstack.org/55844208:55
openstackgerritzhongshengping proposed openstack/puppet-manila master: Deprecate auth_uri option  https://review.openstack.org/55844308:55
openstackgerritzhongshengping proposed openstack/puppet-heat master: Deprecate auth_uri option  https://review.openstack.org/55844408:55
openstackgerritzhongshengping proposed openstack/puppet-gnocchi master: Deprecate auth_uri option  https://review.openstack.org/55844508:55
openstackgerritzhongshengping proposed openstack/puppet-designate master: Deprecate auth_uri option  https://review.openstack.org/55844708:55
openstackgerritzhongshengping proposed openstack/puppet-zaqar master: Deprecate auth_uri option  https://review.openstack.org/55844608:55
openstackgerritzhongshengping proposed openstack/puppet-panko master: Deprecate auth_uri option  https://review.openstack.org/55844808:55
openstackgerritzhongshengping proposed openstack/puppet-glance master: Deprecate auth_uri option  https://review.openstack.org/55844908:55
openstackgerritzhongshengping proposed openstack/puppet-ironic master: Deprecate auth_uri option  https://review.openstack.org/55845008:55
openstackgerritzhongshengping proposed openstack/puppet-nova master: Deprecate auth_uri option  https://review.openstack.org/55845108:55
openstackgerritzhongshengping proposed openstack/puppet-barbican master: Deprecate auth_uri option  https://review.openstack.org/55845208:55
openstackgerritzhongshengping proposed openstack/puppet-cinder master: Deprecate auth_uri option  https://review.openstack.org/55845308:55
openstackgerritzhongshengping proposed openstack/puppet-ceilometer master: Deprecate auth_uri option  https://review.openstack.org/55845408:56
openstackgerritzhongshengping proposed openstack/puppet-neutron master: Deprecate auth_uri parameter  https://review.openstack.org/55841909:01
*** gfidente has joined #puppet-openstack09:02
*** gfidente has quit IRC09:02
*** gfidente has joined #puppet-openstack09:02
openstackgerritThomas Goirand proposed openstack/puppet-openstack-integration master: Fixed puppet repo & key in Debian  https://review.openstack.org/55845709:13
*** salmankhan has joined #puppet-openstack09:14
*** markvoelker has joined #puppet-openstack09:18
openstackgerritzhongshengping proposed openstack/puppet-openstack-cookiecutter master: Deprecate auth_uri option  https://review.openstack.org/55846009:20
*** armaan_ has quit IRC09:31
*** armaan has joined #puppet-openstack09:31
*** armaan has quit IRC09:36
*** salmankhan has quit IRC09:42
openstackgerritzhongshengping proposed openstack/puppet-openstack-cookiecutter master: Deprecate auth_uri option  https://review.openstack.org/55846009:45
*** markvoelker has quit IRC09:52
*** salmankhan has joined #puppet-openstack09:52
*** dtantsur|afk is now known as dtantsur10:18
*** armaan has joined #puppet-openstack10:26
*** vnogin has quit IRC10:30
*** vnogin has joined #puppet-openstack10:38
*** markvoelker has joined #puppet-openstack10:48
*** skramaja has quit IRC11:12
*** skramaja has joined #puppet-openstack11:13
*** rcernin has quit IRC11:20
openstackgerritMerged openstack/puppet-ceilometer master: Add cinder metrics to polling.yaml  https://review.openstack.org/55811111:21
*** markvoelker has quit IRC11:22
*** salmankhan1 has joined #puppet-openstack11:27
*** salmankhan has quit IRC11:29
*** salmankhan1 is now known as salmankhan11:29
*** salmankhan has quit IRC11:31
*** salmankhan has joined #puppet-openstack11:34
*** dprince has joined #puppet-openstack11:34
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848311:36
*** salmankhan1 has joined #puppet-openstack11:36
*** salmankhan has quit IRC11:38
*** salmankhan1 is now known as salmankhan11:38
*** alee has quit IRC11:44
openstackgerritThomas Goirand proposed openstack/puppet-openstack-integration master: Use Debian's repo when using Debian  https://review.openstack.org/55848511:45
*** jpena is now known as jpena|lunch11:46
openstackgerritTobias Urdin proposed openstack/puppet-ceilometer stable/queens: Add cinder metrics to polling.yaml  https://review.openstack.org/55848611:48
*** amoralej is now known as amoralej|lunch12:06
*** dtantsur is now known as dtantsur|brb12:06
*** alee has joined #puppet-openstack12:15
*** trown|outtypewww is now known as trown12:16
*** markvoelker has joined #puppet-openstack12:19
*** gyan__ has quit IRC12:21
*** markvoelker has quit IRC12:23
*** markvoelker has joined #puppet-openstack12:24
*** salmankhan has quit IRC12:32
*** salmankhan has joined #puppet-openstack12:34
openstackgerritThomas Goirand proposed openstack/puppet-openstack-integration master: Fixed puppet repo & key in Debian  https://review.openstack.org/55845712:44
*** colonwq has joined #puppet-openstack12:44
*** alee has quit IRC12:45
openstackgerritThomas Goirand proposed openstack/puppet-openstack-integration master: Fixed puppet repo & key in Debian  https://review.openstack.org/55845712:49
*** jpena|lunch is now known as jpena12:50
*** alee has joined #puppet-openstack12:51
*** vnogin has quit IRC12:57
*** vnogin has joined #puppet-openstack12:58
openstackgerritThomas Goirand proposed openstack/puppet-openstack-integration master: Use Debian's repo when using Debian  https://review.openstack.org/55848512:59
*** trown is now known as trown|brb12:59
*** trown|brb is now known as trown13:01
*** vnogin has quit IRC13:02
*** vnogin has joined #puppet-openstack13:02
*** amoralej|lunch is now known as amoralej13:08
*** trozet has joined #puppet-openstack13:13
*** skramaja has quit IRC13:14
*** skramaja has joined #puppet-openstack13:14
*** ykarel is now known as ykarel|away13:20
*** ykarel|away has quit IRC13:25
*** morazi has joined #puppet-openstack13:27
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848313:32
zigoThis last one does work ! :)13:33
zigo(just tested)13:33
zigoI need it to be merged, otherwise it's going to be hard to test.13:33
zigoOr can I push that in the Puppet file?13:33
zigoGosh ... There's python-nova and such everywhere, where in fact, Debian now switched to python3-nova !13:45
zigoWhy is the puppet project even carying about this package, it should NOT !13:46
*** ykarel|away has joined #puppet-openstack13:51
*** ykarel|away is now known as ykarel13:51
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Do not expect python-nova  https://review.openstack.org/55851213:53
zigoAlso, i wonder if I shouldn't patch all to use python3-*client in case of Debian ...13:54
*** dtantsur|brb is now known as dtantsur13:59
openstackgerritHamdy Khader proposed openstack/puppet-cinder master: Add NVMeOF backend  https://review.openstack.org/55852014:07
*** vnogin has quit IRC14:07
*** vnogin has joined #puppet-openstack14:12
openstackgerritSandhya Dasu proposed openstack/puppet-neutron stable/newton: New configuration being added for Cisco UCSM ML2 driver  https://review.openstack.org/53742114:20
*** trown is now known as trown|brb14:27
*** agurenko has quit IRC14:28
*** trown|brb is now known as trown14:30
*** morazi has quit IRC14:42
*** trown has quit IRC14:48
*** trown has joined #puppet-openstack14:50
*** morazi has joined #puppet-openstack14:54
openstackgerritMerged openstack/puppet-openstack-guide master: fix job name  https://review.openstack.org/55786514:55
openstackgerritMerged openstack/puppet-openstack-guide master: Added puppet-openstack-syntax-5 job introduction  https://review.openstack.org/55786614:55
mnaserzigo: do you have any better alternative way of installing the nova client?14:57
zigomnaser: What do you mean?14:57
mnaseri mean we have to 'hardcode' the python client package name somewhere to be able to install it14:58
zigomnaser: I think it should be ok to always install the Python 3 version.14:58
mnaserzigo: not all distros are as awesome as you about shipping python 3 :D14:58
zigomnaser: In fact, it should be ok to do nothing, as the python{3,}-nova package depends on the python{3,}-novaclient ! :)14:59
* zigo checks for that fact in ubuntu15:00
zigoAlso, I should have use os_packaging_type rather than operatingsystem.15:02
zigoHum...15:02
zigoUbuntu doesn't have Depends: python-novaclient in nova.15:02
*** vnogin has quit IRC15:02
zigomnaser: how would you do "do nothing" in case of Debian then?15:03
mnaserzigo: that puppet manifest is if someone actually wants to install the nova client, so imagine if you have a server that you want to have the nova client on (only), so we don't want it to be noop15:04
zigoOh ok, indeed.15:04
mnaserzigo: however, the ideal cleaner way would be to add this under the nova::params list of vars, one default and maybe a debian specific one and update that manifest to point towards the variable15:05
mnaserthat way, we don't have switch's all over the place, it's just the resource and it's evaluated for a different os15:05
zigomnaser: Why do you think it would be bad to always install the python3 version of the client?15:05
*** sai_p has joined #puppet-openstack15:05
zigoEvery distro ship it, no?15:05
mnaserzigo: i don't think rdo/redhat ships it :(15:05
mnaserso i'm not opposed to it, but that's the reasoning15:06
zigoRight, then if os familly is Debian, then do py3 ...15:06
mnaserzigo: hence, https://github.com/openstack/puppet-nova/blob/master/manifests/params.pp15:06
mnaserwe add $client_package_name = 'python-novaclient' for redhat15:06
mnaser$client_package_name = 'python3-novaclient' for debian15:06
mnaserand then we avoid that switch in nova::client and just point directly to that param15:06
zigoHum...15:07
zigoSo basically, just scrap what I did in client.pp and we're good to go, right?15:07
*** vnogin has joined #puppet-openstack15:08
openstackgerritThomas Goirand proposed openstack/puppet-nova master: Do not expect python-nova  https://review.openstack.org/55851215:09
zigoHow come this one fails on CentOS ? https://review.openstack.org/#/c/558483/ I'm not even touching it...15:10
*** tesseract has quit IRC15:32
*** vnogin has quit IRC15:39
*** atoth has quit IRC15:41
*** vnogin has joined #puppet-openstack15:42
mnaserzigo: fatal: unable to access 'https://github.com/puppetlabs/puppetlabs-mysql/': TCP connection reset by peer15:55
mnasercentos failure is unrelated, dont worry about it, you can recheck15:55
mnaserunit tests failed probably because that python-nova was removed15:55
*** atoth has joined #puppet-openstack15:56
*** vnogin has quit IRC16:01
*** ykarel is now known as ykarel|afk16:04
*** vnogin has joined #puppet-openstack16:05
*** mgagne_ has quit IRC16:11
*** mgagne_ has joined #puppet-openstack16:11
*** skramaja has quit IRC16:17
*** vnogin has quit IRC16:19
*** vnogin has joined #puppet-openstack16:21
*** dtantsur is now known as dtantsur|brb16:21
*** vnogin has quit IRC16:22
*** trozet has quit IRC16:26
*** trozet has joined #puppet-openstack16:31
*** gfidente has quit IRC16:46
*** trown is now known as trown|lunch17:00
*** jpena is now known as jpena|off17:00
openstackgerritMerged openstack/puppet-openstack_spec_helper stable/pike: Revert "Switch puppet vertion to 4.8 for unit test"  https://review.openstack.org/55568217:10
*** jtomasek has quit IRC17:13
*** salmankhan has quit IRC17:20
*** amoralej is now known as amoralej|off17:31
*** ykarel|afk has quit IRC17:46
*** trown|lunch is now known as trown18:01
*** dtantsur|brb is now known as dtantsur18:25
openstackgerritMerged openstack/puppet-neutron stable/newton: New configuration being added for Cisco UCSM ML2 driver  https://review.openstack.org/53742118:34
*** armaan has quit IRC18:38
*** armaan has joined #puppet-openstack18:39
*** dprince has quit IRC18:41
*** commavir_ has joined #puppet-openstack18:43
*** _bmjen has joined #puppet-openstack18:46
*** EmilienM_ has joined #puppet-openstack18:46
*** rook_ has joined #puppet-openstack18:47
*** jaganathan has quit IRC18:47
*** commavir has quit IRC18:47
*** EmilienM has quit IRC18:47
*** bmjen has quit IRC18:47
*** rook has quit IRC18:47
*** EmilienM_ is now known as EmilienM18:48
*** dtantsur is now known as dtantsur|afk18:49
*** EmilienM has quit IRC18:49
*** EmilienM has joined #puppet-openstack18:49
*** jaganathan has joined #puppet-openstack18:53
*** shardy has quit IRC18:55
*** shardy has joined #puppet-openstack18:56
*** jtomasek has joined #puppet-openstack19:13
*** rook_ is now known as rook19:25
*** shardy has quit IRC19:25
*** shardy has joined #puppet-openstack19:27
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848319:36
*** jtomasek has quit IRC19:36
*** dprince has joined #puppet-openstack19:45
zigomwhahaha: Around?19:55
mwhahahazigo: sup?19:55
zigomwhahaha: I'm tryiing to fix openstack_extras for Debian. So far, I believe I managed to make it work, but overriding the release name doesn't work, as per the unit tests.19:56
zigomwhahaha: http://logs.openstack.org/83/558483/3/check/puppet-openstack-unit-4.8-centos-7/8552d32/job-output.txt.gz#_2018-04-03_19_49_25_90961719:56
zigomwhahaha: My patch is at: https://review.openstack.org/#/c/558483/19:56
*** pradk has joined #puppet-openstack19:56
*** pradk has quit IRC19:56
zigoCould you help me to fix it? :)19:56
mwhahahazigo: so let me see19:57
zigomwhahaha: What I suspect is wrong is writing this:19:58
zigo  $whz_name              = "stretch-${::openstack_extras::repo::debian::params::release}-backports"19:58
zigo  $whz_location          = "http://stretch-${::openstack_extras::repo::debian::params::release}.debian.net/debian"19:58
mwhahahayes19:58
mwhahahai am commenting19:58
zigoJust $release ?19:58
mwhahahayea cause you're referencing the variable from the class19:59
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848320:00
zigomwhahaha: I also have a few other patches that are passing ! :)20:00
zigomwhahaha: https://review.openstack.org/558457 and https://review.openstack.org/55848520:01
zigoI'm making quite some progress with running the ./all-in-one.sh ! :)20:01
mwhahahacool20:02
zigoThe good thing is that Linaro guys are pushing an infra patch to add amd64 stretch, so hopefully, we'll be able to use that new image for puppet too.20:03
zigoJust running a single scenario in Debian, to avoid breakage...20:03
zigoThere was too many Ubuntu assemption over time.20:04
zigomwhahaha: Oh, also, my openstack-dashboard-apache attemps to reload apache, but fails, because apache isn't running, somehow. Any idea what's stopping it during the setup?20:05
mwhahahanot really, would have to see a puppet run logs or something20:06
zigomwhahaha: I'm adding || true in the package when calling invoke-rc.d --quiet apache2 reload, that should fix it... :P20:08
zigoThough I found it weird that puppet disable apache and then install horizon.20:08
mwhahahamight just be the service hooks for debian20:09
zigomwhahaha: One last thing: it would make sense to have all the clients switch to python3-fooclient instead of the py2 counterpart in Debian, since everything (but swift) is switched to Py3. Do you think I should send patches for that?20:10
zigoAnd should I make it the default also for Ubuntu, since it's going to be py3 in the next release too?20:10
mwhahahado you know if they'll have py3 versions for rocky?20:11
mwhahahaif so yea it wouldn't hurt to get that going but we'll probably have to wait until they post their m1 packages20:11
zigomwhahaha: They do have py2 and py3 clients in Ubuntu, it's been the case for *years*.20:12
mwhahahayea but do they actual work? :D20:12
zigoIt should be the same package as for in Debian.20:12
zigoSo, yes ... :P20:12
mwhahahamight just pick one module and try it out20:13
mwhahahastart with keystone or something20:13
zigoActually, they started doing packaging... :P20:14
zigoI just had a look, it's not the same packages anymore.20:14
zigomwhahaha: Now I don't get what's wrong: http://logs.openstack.org/83/558483/4/check/puppet-openstack-unit-4.8-centos-7/92c24b4/job-output.txt.gz#_2018-04-03_20_08_58_06442220:16
mwhahahak i'll look again20:16
mwhahahazigo: oh i see it20:21
zigo:)20:21
zigoWhat's going on ?20:21
mwhahahait's u sing queens as the name always20:22
zigo?20:22
mwhahahasec20:22
zigoOh, in 2), right, but in 1) it's really using pike.20:23
mwhahahano it's using strech-queens-backports when you specify the release20:23
mwhahahabecause the params class is basically static20:24
mwhahahaso you can't set $whz_name like that20:24
mwhahahait'd probably be better to just ditch those vars20:24
zigoI'm not following...20:25
mwhahahai'll comment on the review to try and explain20:25
zigoThanks a lot.20:25
zigoIt'd be nice to also replace stretch by the output of lsb_release -c -s20:27
zigoor whatever is the puppet equivalent.20:28
mwhahahathat might be a fact20:28
zigoYeah...20:28
mwhahahayou could use that if it shows up as a fact20:28
* mwhahaha doesn't have a debian box to check the output20:28
zigo# facter | grep stretch20:29
zigolsbdistcodename => stretch20:29
zigo:)20:29
mwhahaha$::lsbdistcodename20:29
zigoSo $::lsbdistcodename20:29
zigoYeah ! :)20:29
mwhahahaonly works if you have the lsb packages installed20:29
mwhahahabut yea20:29
zigomwhahaha: Can I use $::lsbdistcodename in a .rb file as well?20:32
zigoI guess no...20:32
mwhahahadepends20:33
mwhahahathere are ways to query the facts so if you're talking about a puppet .rb fact yea20:33
zigomwhahaha: I was thinking of spec/classes/openstack_extras_repo_debian_debian_spec.rb, but maybe having stretch hardcoded there is fine for now.20:34
mwhahahaso in the spec files you would define the fact20:35
mwhahahain that  @default_Facts.merge({ ...  }) block20:36
mwhahahayou'd have to define a :lsbdistcodename => 'strech'20:36
mwhahahaanyway commented on the issues in the review20:36
* zigo reads20:37
*** colonwq has quit IRC20:48
zigomwhahaha: Took me a while to understand, but I think I got it. Something like this?20:51
zigolocation => regsubst($::openstack_extras::repo::debian::params::whz_location,'DEB_BACKPORT_RELEASENAME',"${::lsbdistcodename}-${release}"),20:51
mwhahahayea20:52
zigoI have set in params:20:52
zigo  $whz_location          = "http://DEB_BACKPORT_RELEASENAME.debian.net/debian"20:52
mwhahahafeel free to rename it from $whz_location20:52
mwhahahai think that's for the wheezy it used to be20:52
mwhahahacould be $deb_location20:52
zigoYeah ! :)20:52
zigoI'll probably do that once I have a patch that passes unit tests ... :P20:53
mwhahaha:D20:53
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848320:53
*** trown is now known as trown|outtypewww21:01
*** colonwq has joined #puppet-openstack21:03
*** alee has quit IRC21:07
*** alee has joined #puppet-openstack21:08
zigoMy call to regsubst() doesn't work21:11
zigo:(21:15
mwhahahayou didn't fix the whz_name21:18
mwhahahait suffers from the same problem21:18
*** colonwq has quit IRC21:18
zigoOh...21:21
*** vnogin has joined #puppet-openstack21:22
*** alee has quit IRC21:23
*** shardy has quit IRC21:25
*** shardy has joined #puppet-openstack21:25
*** vnogin has quit IRC21:27
openstackgerritThomas Goirand proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848321:28
zigomwhahaha: Did I use the correct syntax? https://review.openstack.org/#/c/558483/6/manifests/repo/debian/debian.pp21:29
mwhahahayea i think so21:29
zigo:)21:29
zigoFun, fun ... :P21:30
*** alee has joined #puppet-openstack21:30
*** alee has quit IRC21:31
*** alee has joined #puppet-openstack21:32
*** alee has quit IRC21:34
zigomwhahaha: Nop, my syntax is wrong: http://logs.openstack.org/83/558483/6/check/puppet-openstack-syntax-5/1b42ee3/job-output.txt.gz#_2018-04-03_21_32_46_81729221:34
mwhahahait's a regex, i'll check it in a minute21:35
zigoI checked using irb and the regex part seem good.21:36
zigoBut I'm far from an expert ...21:36
zigoHum...21:36
zigosubscribe   => File["/etc/apt/sources.list.d/${::openstack_extras::repo::debian::params::whz_name}.list"], will be wrong too, no?21:37
mwhahahayea21:37
mwhahahait's probably better to not dynamically do all this stuff if you don't have to21:37
zigoWell, then we wont be able to set alt location.21:38
zigoThat's not very nice, this prevents from using mirrors.21:38
mwhahahawe do mirrors for other ones21:39
mwhahahalet me see21:39
mwhahahathats cause we expose the location via the repo class not the params class21:39
mwhahahazigo: do you mind if i push over your change to align it better with the other repos?21:39
zigoThe annoying bit is that I have the release name in the hostname of the repo, not just the repo name changes.21:39
mwhahahayea we do that with the upstream stuff21:40
zigonot only I wont mind, but I'd be very pleased !21:40
mwhahahak let me do this real quick21:40
zigoThanks so much for your help.21:40
mwhahahakinda annoying for the hostname to change based on release21:51
zigoThat's because I setup one jenkins build server per release.21:52
mwhahahayea we just need to move that out of params21:53
*** rcernin has joined #puppet-openstack21:53
mwhahahafor teh redhat ones we don't config it in params21:53
mwhahahaso i'm doing something similar21:53
zigook21:55
openstackgerritAlex Schultz proposed openstack/puppet-openstack_extras master: Fix stretch queens repo  https://review.openstack.org/55848322:05
mwhahahazigo: -^22:06
* mwhahaha wanders off22:09
zigomwhahaha: But $deb_location from debian.pp wont take what's in params.pp, will it?22:10
* zigo needs to go sleep anyway ... :P22:10
mwhahahaNope22:11
zigoWorked ! :)22:17
zigoEmilienM: https://review.openstack.org/558483 +2w ? :)22:17
EmilienMsure, let me look22:18
zigoEmilienM: If you have time, there's also https://review.openstack.org/558457 and https://review.openstack.org/55848522:20
* zigo has to get up a 6am to go to $work in Geneva and goes to sleep now.22:21
*** shardy has quit IRC22:31
*** shardy has joined #puppet-openstack22:31
*** shardy has quit IRC22:44
*** morazi has quit IRC22:47
*** shardy has joined #puppet-openstack22:49
*** colonwq has joined #puppet-openstack22:50
*** vnogin has joined #puppet-openstack23:21
*** vnogin has quit IRC23:30
*** vnogin has joined #puppet-openstack23:32
*** vnogin has quit IRC23:45
*** dprince has quit IRC23:56
« Monday, 2018-04-02 Index Wednesday, 2018-04-04 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!