opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 01:27 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 05:12 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: DNM: Enforce scope https://review.opendev.org/c/openstack/puppet-keystone/+/818711 | 05:20 |
*** ysandeep|out is now known as ysandeep | 05:42 | |
*** amoralej|off is now known as amoralej | 07:04 | |
amoralej | hi, may you review https://review.opendev.org/c/openstack/puppet-openstack-integration/+/793462 when you have a chance? | 07:11 |
*** ykarel is now known as ykarel|lunch | 07:53 | |
*** ysandeep is now known as ysandeep|lunch | 08:18 | |
*** ysandeep|lunch is now known as ysandeep | 09:24 | |
*** ykarel|lunch is now known as ykarel | 09:53 | |
tobias-urdin | amoralej: just a small nit, otherwise looks fine | 12:00 |
amoralej | lemme check | 12:01 |
amoralej | mm actually what is wrong is absent | 12:02 |
amoralej | but why it works... | 12:02 |
tobias-urdin | you install the same package in run_tests.sh afterwards | 12:03 |
amoralej | yeah, i saw it | 12:07 |
amoralej | fixing it | 12:07 |
opendevreview | Alfredo Moralejo proposed openstack/puppet-openstack-integration master: Add support for for CentOS Stream 9 https://review.opendev.org/c/openstack/puppet-openstack-integration/+/793462 | 12:10 |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 12:37 |
*** amoralej is now known as amoralej|lunch | 13:25 | |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 13:38 |
*** amoralej|lunch is now known as amoralej | 14:04 | |
amoralej | tkajinam, wrt your comment in https://review.opendev.org/c/openstack/puppet-openstack-integration/+/793462/37/functions#221 | 14:14 |
amoralej | wdtm by make it an independend block? | 14:14 |
amoralej | i was thinking in putting first the condition to version_id | 14:15 |
amoralej | -eq 9 | 14:15 |
amoralej | and elif manage_repos = true | 14:15 |
tkajinam | amoralej, https://paste.opendev.org/show/811222/ | 14:18 |
amoralej | ahhhh ok | 14:18 |
tkajinam | currently L221 checks | 14:18 |
tkajinam | if [ "${MANAGE_REPOS}" == "true" ] && [ ${VERSION_ID} -ne 9 ] ; then | 14:18 |
tkajinam | and then L235 checks | 14:19 |
tkajinam | elif [ "${MANAGE_REPOS}" == "true" ] && [ ${VERSION_ID} -eq 9 ] ; then | 14:19 |
tkajinam | but the first condition are same and looks a bit redundant | 14:19 |
amoralej | yeah, ok, makes sense | 14:19 |
tkajinam | :-) | 14:21 |
opendevreview | Alfredo Moralejo proposed openstack/puppet-openstack-integration master: Add support for for CentOS Stream 9 https://review.opendev.org/c/openstack/puppet-openstack-integration/+/793462 | 14:26 |
*** ykarel is now known as ykarel|away | 14:29 | |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 14:39 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: Victoria and before: Switch syntax/unit test job to CentOS8 Stream https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818783 | 14:54 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: [Train-only] Make CentOS8 integration jobs voting https://review.opendev.org/c/openstack/puppet-openstack-integration/+/787756 | 15:00 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: Add CentOS 8 Stream jobs to puppet-openstack https://review.opendev.org/c/openstack/puppet-openstack-integration/+/789434 | 15:00 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: Add CentOS 8 Stream jobs to puppet-openstack https://review.opendev.org/c/openstack/puppet-openstack-integration/+/789434 | 15:03 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: Victoria and before: Switch syntax/unit test job to CentOS8 Stream https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818783 | 15:10 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/train: Drop syntax job on CentOS8 (and CentOS7) https://review.opendev.org/c/openstack/puppet-openstack-integration/+/789464 | 15:10 |
amoralej | tkajinam, given that centos linux 8 is going away on dec 31st, maybe we could just switch existing centos8 jobs to use centos-8-stream | 15:20 |
amoralej | without adding new jobs | 15:20 |
amoralej | fixing repos and nodesets | 15:20 |
amoralej | with same job names | 15:20 |
amoralej | wdyt? | 15:20 |
tkajinam | maybe that is simpler | 15:21 |
tkajinam | I was trying to "backport" all changes and that's why I ended up these redundant changes. but directly modifying jobs in stable branches might be better | 15:23 |
*** ysandeep is now known as ysandeep|out | 15:26 | |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/victoria: Replace CentOS 8 jobs by CentOS 8 Stream jobs https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818788 | 15:32 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/victoria: Remove non-voting ubuntu integration jobs from gate https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818789 | 15:32 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/victoria: Remove non-voting ubuntu integration jobs from gate https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818789 | 15:33 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/victoria: Replace CentOS 8 jobs by CentOS 8 Stream jobs https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818788 | 15:33 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: Remove non-voting ubuntu integration jobs from gate https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818790 | 15:35 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration stable/ussuri: Replace CentOS 8 jobs by CentOS 8 Stream jobs https://review.opendev.org/c/openstack/puppet-openstack-integration/+/818791 | 15:45 |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Use system scope credentials in providers https://review.opendev.org/c/openstack/puppet-nova/+/815850 | 15:54 |
*** amoralej is now known as amoralej|off | 16:20 | |
*** ysandeep|out is now known as ysandeep | 23:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!