opendevreview | zhongshengping proposed openstack/puppet-zaqar master: Prepare Yoga M2 https://review.opendev.org/c/openstack/puppet-zaqar/+/819977 | 03:17 |
---|---|---|
opendevreview | zhongshengping proposed openstack/puppet-placement master: Prepare Yoga M2 https://review.opendev.org/c/openstack/puppet-placement/+/819968 | 03:19 |
opendevreview | zhongshengping proposed openstack/puppet-manila master: Prepare Yoga M2 https://review.opendev.org/c/openstack/puppet-manila/+/819980 | 03:20 |
opendevreview | zhongshengping proposed openstack/puppet-cinder master: Prepare Yoga M2 https://review.opendev.org/c/openstack/puppet-cinder/+/819970 | 03:21 |
opendevreview | Rocky proposed openstack/puppet-swift master: Add rsync parameters for object server https://review.opendev.org/c/openstack/puppet-swift/+/821646 | 04:38 |
*** ysandeep|out is now known as ysandeep | 05:27 | |
*** ysandeep is now known as ysandeep|lunch | 07:26 | |
*** amoralej|off is now known as amoralej | 08:15 | |
*** ysandeep|lunch is now known as ysandeep | 08:41 | |
opendevreview | Merged openstack/puppet-glance master: Fix wrong class used in unit tests https://review.opendev.org/c/openstack/puppet-glance/+/821629 | 08:44 |
*** ysandeep is now known as ysandeep|afk | 09:35 | |
opendevreview | Merged openstack/puppet-openstack_extras master: auth_file: Deprecate tenant_name parameter https://review.opendev.org/c/openstack/puppet-openstack_extras/+/821554 | 10:02 |
opendevreview | Merged openstack/puppet-openstack_extras master: auth_file: Clean up deprecated *_domain parameters https://review.opendev.org/c/openstack/puppet-openstack_extras/+/821556 | 10:10 |
opendevreview | Merged openstack/puppet-sahara master: Add support for more parameters about periodic tasks https://review.opendev.org/c/openstack/puppet-sahara/+/821493 | 10:24 |
opendevreview | Merged openstack/puppet-sahara master: Support tunable parameters for coordination https://review.opendev.org/c/openstack/puppet-sahara/+/821494 | 10:24 |
*** ysandeep|afk is now known as ysandeep | 10:32 | |
*** jpena|off is now known as jpena | 11:42 | |
*** ysandeep is now known as ysandeep|brb | 12:21 | |
opendevreview | Takashi Kajinami proposed openstack/puppet-horizon master: Update description of OPENSTACK_API_VERSIONS https://review.opendev.org/c/openstack/puppet-horizon/+/821701 | 12:42 |
*** ysandeep|brb is now known as ysandeep | 12:48 | |
opendevreview | Takashi Kajinami proposed openstack/puppet-horizon master: Describe default of OPENSTACK_HYPERVISOR_FEATURES['enable_quotas'] https://review.opendev.org/c/openstack/puppet-horizon/+/821702 | 12:49 |
amoralej | tkajinam, https://github.com/openstack/puppet-placement/commit/53594681fa0251170367ec153170843489e274fa is the new problem for packstack, that change the defaults | 13:10 |
amoralej | i'll squash the fix with your patch for rabbitmq deps | 13:10 |
amoralej | ok? | 13:10 |
*** amoralej is now known as amoralej|lunch | 13:16 | |
tkajinam | amoralej|lunch, yes | 13:44 |
tkajinam | no problem | 13:45 |
*** amoralej|lunch is now known as amoralej | 14:04 | |
amoralej | tkajinam, nova-compute is tagged as nova-service, so it fails as the compute node is executed in a different puppet run | 14:08 |
tkajinam | yeah | 14:08 |
amoralej | is there a way to establish that ordering rule but only if both classes are defined? | 14:08 |
amoralej | or we may use Service[whatever] | 14:08 |
tkajinam | that's why I initially used weak ref using Class... and mentioned it would break multinode deployment | 14:08 |
amoralej | similar with ceilometer-polling | 14:10 |
amoralej | Class[Rabbitmq]' for relationship on 'Service[ceilometer-polling]' | 14:10 |
amoralej | https://15ad68a81e62a995aef4-43aabb4aae4dce483640460c00b42163.ssl.cf5.rackcdn.com/821594/5/check/packstack-centos8s-integration-scenario003/c7e992b/logs/latest/manifests/149.202.191.90_compute.pp.log.txt | 14:10 |
*** ysandeep is now known as ysandeep|out | 14:13 | |
tkajinam | let me check which resource I can use | 14:13 |
tkajinam | I initially though of using Service<| name == 'rabbitmq' |> but I need to find the exact resource which manage rabbitmq users | 14:14 |
amoralej | tkajinam, https://github.com/redhat-openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/amqp/enable_rabbitmq.pp | 14:16 |
amoralej | that's what starts rabbit in this case | 14:16 |
amoralej | i'm not sure we create separated users in rabbit, tbh | 14:16 |
amoralej | lemme check | 14:16 |
amoralej | note we have Service['rabbitmq-server'] in deps there | 14:17 |
tkajinam | https://github.com/voxpupuli/puppet-rabbitmq/blob/master/manifests/install/rabbitmqadmin.pp#L48-L57 | 14:17 |
tkajinam | hmm. it might not this one | 14:18 |
tkajinam | oh, ok. so seems Service resource should be enough | 14:19 |
amoralej | tkajinam, https://github.com/redhat-openstack/packstack/blob/master/packstack/puppet/modules/packstack/manifests/amqp/enable_rabbitmq.pp#L32-L33 | 14:20 |
amoralej | so, we are creating the user from rabbitmq class | 14:20 |
* tkajinam is updating the patch | 14:20 | |
amoralej | so, the plan is to use weak deps with Service ? | 14:21 |
amoralej | tkajinam, update your local copy of the patch to get the placement fix | 14:21 |
tkajinam | amoralej, yeah I pulled the latest change | 14:29 |
tkajinam | amoralej, just submitted the updated version | 14:29 |
tkajinam | user name/password is written in config file so the rabbitmq user should be available when rabbitmq is started | 14:30 |
tkajinam | so requiring rabbitmq-server service should be enough | 14:30 |
tkajinam | Service<| name == 'rabbitmq-server' |> is ignored if there is not service resource with name => 'rabbitmq-server' so is supposed to work in compute nodes as well | 14:31 |
amoralej | tkajinam, at least jobs are passing puppet apply steps, so looks promising | 15:14 |
amoralej | tkajinam++ | 15:14 |
tkajinam | amoralej, that's nice :-) | 15:14 |
opendevreview | Merged openstack/puppet-heat master: Use native support to define RequestHeader statement https://review.opendev.org/c/openstack/puppet-heat/+/821091 | 15:25 |
opendevreview | Merged openstack/puppet-heat master: Clean up direct dependencies on puppetlabs-apache https://review.opendev.org/c/openstack/puppet-heat/+/821092 | 15:25 |
amoralej | tkajinam, all jobs passed! :) | 15:43 |
tkajinam | amoralej, great! | 15:44 |
tkajinam | I'll make sure I check packstack as well when merging breaking change. I did it in the past after I broke something but recently I didn't pay much attention to it... | 15:46 |
tkajinam | (though I don't know what was the exact trigger of that dependency issue | 15:47 |
opendevreview | Merged openstack/puppet-neutron stable/xena: Change authentication method for Mellanox sdn controller https://review.opendev.org/c/openstack/puppet-neutron/+/818319 | 16:26 |
amoralej | tkajinam, we run jobs periodically with packstack, that's where we usually find this type of issues | 16:27 |
amoralej | said this, good to check proactively for cases where we think we may have issues | 16:27 |
*** amoralej is now known as amoralej|off | 17:26 | |
*** jpena is now known as jpena|off | 17:37 | |
opendevreview | Merged openstack/puppet-cinder master: Deprecate service validation for cinder-api https://review.opendev.org/c/openstack/puppet-cinder/+/821574 | 18:29 |
opendevreview | Merged openstack/puppet-glance master: Deprecate service validation for glance-api https://review.opendev.org/c/openstack/puppet-glance/+/821578 | 18:46 |
opendevreview | Merged openstack/puppet-watcher master: Deprecate service validation for watcher-api https://review.opendev.org/c/openstack/puppet-watcher/+/821579 | 18:53 |
opendevreview | Merged openstack/puppet-ironic master: Add support for [conductor] bootloader https://review.opendev.org/c/openstack/puppet-ironic/+/821364 | 18:56 |
opendevreview | Merged openstack/puppet-keystone master: Enable credential setup by default https://review.opendev.org/c/openstack/puppet-keystone/+/821567 | 19:28 |
opendevreview | Merged openstack/puppet-openstack-integration master: Neutron: Avoid usage of built-in service validation https://review.opendev.org/c/openstack/puppet-openstack-integration/+/821585 | 19:28 |
opendevreview | Merged openstack/puppet-openstack-integration master: Aodh: Replace deprecated aodh::auth by aodh::service_credentials https://review.opendev.org/c/openstack/puppet-openstack-integration/+/773256 | 19:28 |
opendevreview | Merged openstack/puppet-keystone master: Deprecate support for member_role_id/name https://review.opendev.org/c/openstack/puppet-keystone/+/821569 | 19:36 |
opendevreview | Merged openstack/puppet-keystone master: Deprecate unused admin_endpoint https://review.opendev.org/c/openstack/puppet-keystone/+/821570 | 19:42 |
opendevreview | Merged openstack/puppet-nova master: Deprecate service validation for nova-api https://review.opendev.org/c/openstack/puppet-nova/+/821577 | 19:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!