| *** bhagyashris is now known as bhagyashris|ruck | 04:53 | |
| *** amoralej|off is now known as amoralej | 07:52 | |
| danielfr | Hi guys, apologies for the n00b question but this is my 1st time contributing to an OpenStack project. How does the merge process work? is there a merge time window where all the approved changes are included? I am asking because I submitted this patch a few days ago and despite it has been +2'd already, it is still not merged | 08:10 |
|---|---|---|
| danielfr | https://review.opendev.org/c/openstack/puppet-keystone/+/869823. Is there something else I need to do on my side? Thanks | 08:10 |
| tkajinam | oops. I haven't put my +2 after I modified the patch | 08:14 |
| tkajinam | danielfr, the patch is merged when it gets +2 and +A. We usually require two +2s from two different reviewers and that was just simply pending on 2nd +2 | 08:15 |
| tkajinam | danielfr, we sometimes avoid merging a change when we are working on a new release but don't really have very long freeze window | 08:15 |
| tkajinam | (some projects operate quite strict spec freeze/feature freeze/code freeze | 08:16 |
| *** ysandeep is now known as ysandeep|afk | 08:46 | |
| *** jpena|off is now known as jpena | 08:47 | |
| danielfr | :+1: thanks for the explanation tkajinam! | 08:54 |
| *** ysandeep|afk is now known as ysandeep | 10:05 | |
| opendevreview | Merged openstack/puppet-keystone master: Fix OIDCRedirectURI value https://review.opendev.org/c/openstack/puppet-keystone/+/869823 | 10:24 |
| *** amoralej is now known as amoralej|lunch | 13:24 | |
| *** amoralej|lunch is now known as amoralej | 14:14 | |
| *** ysandeep is now known as ysandeep|out | 16:15 | |
| *** amoralej is now known as amoralej|off | 17:29 | |
| *** jpena is now known as jpena|off | 17:42 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!