*** tkajinam is now known as Guest213 | 08:56 | |
opendevreview | Thomas Goirand proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 12:02 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: federation: Ensure keyston::wsgi::apache is loaded https://review.opendev.org/c/openstack/puppet-keystone/+/909447 | 12:53 |
opendevreview | Thomas Goirand proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 13:08 |
opendevreview | Thomas Goirand proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 13:08 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: federation: Ensure keyston::wsgi::apache is loaded https://review.opendev.org/c/openstack/puppet-keystone/+/909447 | 13:10 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: Fix broken rendering of OIDC Options https://review.opendev.org/c/openstack/puppet-keystone/+/909449 | 13:34 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: Fix broken rendering of OIDC Options https://review.opendev.org/c/openstack/puppet-keystone/+/909449 | 13:37 |
opendevreview | Thomas Goirand proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 14:55 |
zigo | tkajinam: I clearly do not know what I'm doing when adding these tests in the patch just above... | 14:57 |
zigo | I wouldn't mind help ! :) | 14:58 |
zigo | Once they are done, I'll do the release notes. | 14:58 |
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 15:13 |
tkajinam | zigo, you modified the wrong file | 15:13 |
tkajinam | see the updated version | 15:13 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: federation: Ensure keyston::wsgi::apache is loaded https://review.opendev.org/c/openstack/puppet-keystone/+/909447 | 15:20 |
zigo | tkajinam: Oh, thanks ! | 15:22 |
opendevreview | Takashi Kajinami proposed openstack/puppet-keystone master: Fix broken rendering of OIDC Options https://review.opendev.org/c/openstack/puppet-keystone/+/909449 | 15:23 |
zigo | tkajinam: Do you know how I can fetch your new patch in my current branch? I used to do "git review -d 909114" but then that's creating a new branch... | 15:23 |
tkajinam | git review -x 909114 | 15:24 |
zigo | Cheers. | 15:24 |
* zigo adds the release notes | 15:24 | |
zigo | Gosh, the -x destroyed everything, I'll reclone and -d then... | 15:26 |
tkajinam | -x is equivalent to cherry pick | 15:26 |
tkajinam | I guess probably you did it on top of your previous version ? | 15:26 |
zigo | Yeah. I had to git reset --hard to the previous commit, probably ? | 15:31 |
tkajinam | yeah you have to do it on clean master (or at least branch without your previous commit) | 15:31 |
zigo | I'll know for next time then, thanks. | 15:32 |
opendevreview | Thomas Goirand proposed openstack/puppet-swift master: Per daemon log name https://review.opendev.org/c/openstack/puppet-swift/+/909114 | 15:33 |
zigo | tkajinam: BTW, am I allowed to do this? https://review.opendev.org/c/openstack/puppet-openstack-integration/+/909184 | 16:13 |
zigo | Looks like jobs are failing in a non-deterministic way. | 16:14 |
opendevreview | Merged openstack/puppet-openstack-integration master: Updated from Puppet OpenStack modules constraints https://review.opendev.org/c/openstack/puppet-openstack-integration/+/909178 | 17:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!