opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: ceilometer: Fix wrong rendering of ignore_projects https://review.opendev.org/c/openstack/puppet-swift/+/916695 | 00:55 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: ceilometer: Require default_transport_url https://review.opendev.org/c/openstack/puppet-swift/+/916696 | 01:28 |
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: Make sure storage server config files are not world-readable https://review.opendev.org/c/openstack/puppet-swift/+/916623 | 01:48 |
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: Make sure storage server config files are not world-readable https://review.opendev.org/c/openstack/puppet-swift/+/916623 | 01:48 |
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: ceilometer: Require default_transport_url https://review.opendev.org/c/openstack/puppet-swift/+/916696 | 02:51 |
opendevreview | Takashi Kajinami proposed openstack/puppet-barbican master: Remove old note about database options https://review.opendev.org/c/openstack/puppet-barbican/+/916704 | 05:33 |
opendevreview | Takashi Kajinami proposed openstack/puppet-octavia master: Remove deprecated neutron parameters https://review.opendev.org/c/openstack/puppet-octavia/+/916712 | 07:11 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova master: Add nova::compute::libvirt::secret_ceph resource https://review.opendev.org/c/openstack/puppet-nova/+/916390 | 07:13 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova master: Add nova::compute::libvirt::secret_ceph resource https://review.opendev.org/c/openstack/puppet-nova/+/916390 | 07:13 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova master: Use secret_ceph resource in nova::compute::rbd https://review.opendev.org/c/openstack/puppet-nova/+/916391 | 07:13 |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Remove deprecated cells v1 upgrade_levels parameters https://review.opendev.org/c/openstack/puppet-nova/+/916714 | 07:22 |
opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Remove deprecated nova::periodic_interval https://review.opendev.org/c/openstack/puppet-nova/+/916715 | 07:22 |
opendevreview | Merged openstack/puppet-nova master: libvirt: Support array for log_filters and log_outputs https://review.opendev.org/c/openstack/puppet-nova/+/916379 | 08:05 |
d1nuc0m | Hi all, I'm trying to set some policies with puppet-openstacklib, but probably I'm not understanding how to format policies correctly - see an example here https://pastebin.com/tRd40VKm | 08:05 |
d1nuc0m | It leads to error like no implicit conversion of String into Hash | 08:05 |
d1nuc0m | Any suggestion? | 08:06 |
opendevreview | Takashi Kajinami proposed openstack/puppet-octavia master: Remove deprecated neutron parameters https://review.opendev.org/c/openstack/puppet-octavia/+/916712 | 08:35 |
tkajinam | d1nuc0m, I do not recommend using openstacklib::policy directly. each module has its own policy class which manages the required options as well. | 09:01 |
tkajinam | d1nuc0m, and see https://github.com/openstack/puppet-glance/blob/master/manifests/policy.pp#L19-L28 | 09:01 |
tkajinam | in recent versions key can be omitted and the top level key (which is used as title of openstacklib::policy::base defined resource) is used by default | 09:02 |
d1nuc0m | Thank you, I'll use the module parameters | 09:03 |
tkajinam | danfai, https://paste.opendev.org/show/baNLjXwkFNpRvk4EfSkt/ | 09:04 |
tkajinam | Use the same format for the module specific class, too | 09:04 |
tkajinam | danfai, sorry, wrong mention... | 09:04 |
tkajinam | d1nuc0m, ^^^ | 09:04 |
d1nuc0m | No problem, I was wondering what danfai meant XD | 09:05 |
tkajinam | it was picked up by auto complete (d + <tab>). I was too lazy to type the whole nick :-P | 09:05 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova master: Add nova::compute::libvirt::secret_ceph resource https://review.opendev.org/c/openstack/puppet-nova/+/916390 | 09:09 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova master: Use secret_ceph resource in nova::compute::rbd https://review.opendev.org/c/openstack/puppet-nova/+/916391 | 09:10 |
opendevreview | Takashi Kajinami proposed openstack/puppet-glance master: Remove unnecessary openstacklib::policy resource tag https://review.opendev.org/c/openstack/puppet-glance/+/916748 | 09:15 |
d1nuc0m | @tkajinam, probably I'm missing something, tried to use glance::policy and got duplicate declaration even if I'm not using it elsewhere https://paste.opendev.org/show/bqNb5JGwl0RRHJUITFsC/ | 09:17 |
d1nuc0m | tkajinam, sorry for @ | 09:17 |
opendevreview | Takashi Kajinami proposed openstack/puppet-trove master: Remove trove::api::service_credentials https://review.opendev.org/c/openstack/puppet-trove/+/916749 | 09:18 |
tkajinam | d1nuc0m, probably you have it after glance::api ? | 09:19 |
d1nuc0m | Yes tkajinam | 09:19 |
tkajinam | d1nuc0m, if you defined it with parameters then that should be defined before glance::api which includes the glance::policy class | 09:19 |
d1nuc0m | Thank you, or could I put the data in Hiera (?) | 09:21 |
tkajinam | yeah that's also possible | 09:22 |
tkajinam | if you already use hiera then using hiera would be a better approach instead of mixing two methods to give values | 09:22 |
d1nuc0m | Yes I'm using hiera for all the data | 09:24 |
d1nuc0m | tkajinam, just a detail, in Hiera it looks like the key is mandatory (using 2023.2) | 09:30 |
tkajinam | hm that's wired | 09:37 |
d1nuc0m | Yep, I got Evaluation Error: Error while evaluating a Resource Statement, Openstacklib::Policy::Base[context_is_admin]: expects a value for parameter 'key' | 09:38 |
tkajinam | how did you install the puppet modules ? | 09:40 |
tkajinam | maybe you can check if your local code actually contains https://review.opendev.org/c/openstack/puppet-openstacklib/+/904355 | 09:40 |
d1nuc0m | Thanks, it does not (strange as it is deployed through r10k and it is on GitHub...) | 09:45 |
tkajinam | yeah | 09:45 |
d1nuc0m | * EDIT tkajinam I'm on 2023.2 branch, and it still has the old code https://github.com/openstack/puppet-openstacklib/blob/stable/2023.2/manifests/policy/base.pp | 09:45 |
tkajinam | ahh, ok | 09:45 |
tkajinam | it was merged during 2024.1. I misunderstood the timeline | 09:46 |
d1nuc0m | Haven't upgraded to Caracal yet | 09:46 |
tkajinam | then you need "key" | 09:46 |
d1nuc0m | Yeah, then it worked | 09:46 |
tkajinam | good | 09:46 |
d1nuc0m | As now it is working, can a PR to add examples be useful? | 09:47 |
d1nuc0m | It shouldn't take me too much | 09:47 |
tkajinam | I tend to leave it now. we had some challenges with maintaining examples in the past (mainly because people do not update these when updating manifests)... at least we already documented the usage in the parameter description and that may meet the minimum requirement, I guess | 09:48 |
d1nuc0m | I don't know, I struggled to understand it 😅 | 09:49 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstacklib master: Elaborate usage of openstacklib::policy::policies https://review.opendev.org/c/openstack/puppet-openstacklib/+/916752 | 09:57 |
opendevreview | Takashi Kajinami proposed openstack/puppet-openstacklib master: Elaborate usage of openstacklib::policy::policies https://review.opendev.org/c/openstack/puppet-openstacklib/+/916752 | 09:58 |
tkajinam | ^^^ d1nuc0m | 10:01 |
d1nuc0m | Thank you! | 10:02 |
*** finnekit2 is now known as finnekit | 11:39 | |
opendevreview | Tobias Urdin proposed openstack/puppet-nova stable/zed: DNM: test bundler 2.4.22 https://review.opendev.org/c/openstack/puppet-nova/+/916426 | 13:18 |
opendevreview | Merged openstack/puppet-glance master: Remove unnecessary openstacklib::policy resource tag https://review.opendev.org/c/openstack/puppet-glance/+/916748 | 14:26 |
opendevreview | Takashi Kajinami proposed openstack/puppet-swift master: Make sure storage server config files are not world-readable https://review.opendev.org/c/openstack/puppet-swift/+/916623 | 15:54 |
opendevreview | Tobias Urdin proposed openstack/puppet-nova stable/zed: DNM: test bundler 2.4.22 https://review.opendev.org/c/openstack/puppet-nova/+/916426 | 19:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!