| opendevreview | OpenStack Proposal Bot proposed openstack/puppet-openstack-integration master: Updated from Puppet OpenStack modules constraints https://review.opendev.org/c/openstack/puppet-openstack-integration/+/920802 | 02:23 |
|---|---|---|
| opendevreview | Sam Morrison proposed openstack/puppet-ironic stable/2023.1: Bump upper version of puppetlabs-xinetd https://review.opendev.org/c/openstack/puppet-ironic/+/920807 | 06:45 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-nova master: fix: change $modular_libvirt default for RedHat https://review.opendev.org/c/openstack/puppet-nova/+/920722 | 08:24 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Updated from Puppet OpenStack modules constraints https://review.opendev.org/c/openstack/puppet-openstack-integration/+/920802 | 09:15 |
| d1nuc0m | Hi tkajinam, I ask here as it is easier to interact - in rspec tests is "if facts['osfamily'] == 'RedHat'" valid? Or is it a legacy syntax? I found it used in some files, but Zuul seems to not enter in the right case | 09:56 |
| tkajinam | d1nuc0m, I think you have to use the structured pattern such as facts[:os]['family'] | 11:07 |
| d1nuc0m | tkajinam, thank you, so there also is another wrong check, as I copied it | 11:09 |
| d1nuc0m | Let me try | 11:10 |
| d1nuc0m | Here it is | 11:10 |
| d1nuc0m | if facts['osfamily'] == 'RedHat' | 11:10 |
| d1nuc0m | it_configures 'nova compute libvirt services with modular libvirt' | 11:10 |
| d1nuc0m | end | 11:10 |
| d1nuc0m | So it should already have worked (?) | 11:11 |
| tkajinam | d1nuc0m, ah | 11:11 |
| d1nuc0m | I'll send patch set 5, let's wait | 11:11 |
| tkajinam | d1nuc0m, as far as I remember we have both legacy facts and structured facts available in CI, because factor db expose both | 11:11 |
| tkajinam | but I might be wrong. probably we should use the structured one consistently | 11:12 |
| tkajinam | d1nuc0m, I was pulled by some internal things today so didn't get much time on that patch. One option I have in my mind about unit test update is just put modular_libvirt=False in every params (unless modular libvirt is required) | 11:12 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-nova master: fix: change $modular_libvirt default for RedHat https://review.opendev.org/c/openstack/puppet-nova/+/920722 | 11:12 |
| tkajinam | this prevents us from testing defaults but allows us to simplify the overall unit test structure I guess | 11:13 |
| d1nuc0m | With the new patch it should also allow for defaults test (even though it is probably ugly as my first time with rspec) | 11:13 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-nova master: Assume structured fact in unit tests https://review.opendev.org/c/openstack/puppet-nova/+/920820 | 11:15 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-neutron master: Assume structured fact in unit tests https://review.opendev.org/c/openstack/puppet-neutron/+/920821 | 11:15 |
| tkajinam | thx. I'll spend some time tomorrow on it. | 11:16 |
| d1nuc0m | thanks, I hope new patchset will work, otherwise I'll look at it again | 12:26 |
| opendevreview | Sam Morrison proposed openstack/puppet-cinder master: Add manage_package to RBD backend https://review.opendev.org/c/openstack/puppet-cinder/+/920603 | 22:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!