| opendevreview | Thomas Goirand proposed openstack/puppet-neutron master: Add neutron-services-service support https://review.opendev.org/c/openstack/puppet-neutron/+/922306 | 10:40 |
|---|---|---|
| d1nuc0m | Hi guys, a couple of questions | 13:22 |
| d1nuc0m | Is it possible to use URI::regexp to validate a URL in a patch to be proposed to puppet-openstack? | 13:23 |
| d1nuc0m | Or is there a recommended method? | 13:23 |
| zigo | tkajinam: I don't understand what I've done wrong: https://review.opendev.org/c/openstack/puppet-neutron/+/922306 | 13:32 |
| d1nuc0m | zigo, there is an error about a duplicate declaration | 13:40 |
| d1nuc0m | Duplicate declaration: Service[neutron-services-server] is already declared at (file: /home/zuul/workspace/spec/fixtures/modules/neutron/manifests/server.pp, line: 510); cannot redeclare (file: /home/zuul/workspace/spec/fixtures/modules/neutron/manifests/server.pp, line: 525) | 13:40 |
| zigo | d1nuc0m: Yes, thanks, but where in the source code do I have this? | 13:40 |
| zigo | To me, the title line 510 and 525 are different ! | 13:40 |
| d1nuc0m | It's not in your source code | 13:41 |
| d1nuc0m | Not in the manifests at least | 13:41 |
| zigo | In the spec file? | 13:41 |
| d1nuc0m | The Zuul test creates a manifest from the spec and tries to run it | 13:41 |
| d1nuc0m | So the error lines are not referred to the edits you made to the neutron server spec file | 13:42 |
| d1nuc0m | Also in lines 286:287 I see that there is a duplicate of rpc_service_name | 13:43 |
| d1nuc0m | zigo | 13:43 |
| zigo | Oh, that must be it then! | 13:44 |
| zigo | Thanks. | 13:44 |
| d1nuc0m | I don't know, I'm still a newbie to Puppet & specs, but it looks strange to me | 13:45 |
| opendevreview | Thomas Goirand proposed openstack/puppet-neutron master: Add neutron-services-service support https://review.opendev.org/c/openstack/puppet-neutron/+/922306 | 13:46 |
| zigo | Let's see if it passes now! :) | 13:46 |
| tkajinam | d1nuc0m, I'm unsure the actual implementation you have in your mind, but if you aim to implement the parameter value validation at class/defined-type interface layer then using Stdlib::HTTPUrl would be a better choice | 13:59 |
| tkajinam | there are a few such work already done in puppet-oslo or puppet-keystone you can check | 14:00 |
| tkajinam | I'm packed with some internal things this week but would attempt to stay around irc next week, hopefully. | 14:01 |
| d1nuc0m | tkajinam, thank you, I was working on implementing an arbitrary OIDCRedirectURI in puppet-keystone federation | 14:18 |
| d1nuc0m | An I wanted to validate it's a valid URI, problem with Stdlib::HTTPUrl is that it's not an http url | 14:19 |
| opendevreview | Thomas Goirand proposed openstack/puppet-neutron master: Add neutron-services-service support https://review.opendev.org/c/openstack/puppet-neutron/+/922306 | 14:30 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-keystone master: feat: add a param for arbitrary federation OIDCRedirectURI https://review.opendev.org/c/openstack/puppet-keystone/+/922328 | 14:32 |
| opendevreview | Thomas Goirand proposed openstack/puppet-neutron master: Add neutron-services-service support https://review.opendev.org/c/openstack/puppet-neutron/+/922306 | 14:32 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-keystone master: feat: add a param for arbitrary federation OIDCRedirectURI https://review.opendev.org/c/openstack/puppet-keystone/+/922328 | 14:35 |
| d1nuc0m | tkajinam, sent a proposal, maybe this should clarify what I had in mind | 14:38 |
| d1nuc0m | Hopefully we'll be able to check it next week | 14:39 |
| d1nuc0m | As always, thanks for your time :) | 14:39 |
| *** iurygregory_ is now known as iurygregory | 21:28 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!