| opendevreview | Takashi Kajinami proposed openstack/puppet-openstack-integration master: Ironic: Enable ironic-novncproxy https://review.opendev.org/c/openstack/puppet-openstack-integration/+/943078 | 07:36 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/puppet-openstacklib master: Validate input for rabbitmq resources https://review.opendev.org/c/openstack/puppet-openstacklib/+/943225 | 07:45 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-horizon master: docs: switch to Puppet Strings https://review.opendev.org/c/openstack/puppet-horizon/+/943232 | 09:37 |
| d1nuc0m | Hi all, I tried to use Puppet Strings with puppet-horizon, could it be interesting? | 09:38 |
| d1nuc0m | tobias-urdin, you might be interested as mentioned in the copyright headers | 09:39 |
| tobias-urdin | do we win anything from converting to puppet string, since if we don't publish it anywhere does it actually help with anything? did you have to convert it manually or did you use a tool? | 10:16 |
| tobias-urdin | i'm no legal expert, but i don't think we can remove copyright headers and i would assume all file headers should (but maybe doesn't today) include Apache 2.0 license header, we would need to clear that with TC or something to get legal opinion | 10:17 |
| d1nuc0m | Pros: ability to generate a standard reference (usually the reference tab of Puppet Forge modules is generated with strings), automatic detection of parameters type/default; Cons: the work for conversion (there is no dedicated tool AFAIK, so some bash and a manual review) | 10:28 |
| d1nuc0m | Maybe it we should clear it especially as other modules usually don't have the license header in manifests, so it might be a problem if it's actually required | 10:29 |
| d1nuc0m | Eg. puppet-keystone or puppet-nova are Apache-licensed too | 10:30 |
| tkajinam | https://www.apache.org/legal/apply-license.html#new | 11:05 |
| tkajinam | Each original source document (code and documentation, but not the LICENSE and NOTICE files) should include a short license header at the top. If the distribution contains documents not covered by an ICLA, CCLA or Software Grant (such as third-party libraries), consult the policy guide. | 11:05 |
| tkajinam | I thought the header in individual source file is optional but is not :-( | 11:06 |
| tkajinam | hmm but an interesting fact is that for example puppetlabs-inifile uses apache license but it does not have headers in individual files | 11:16 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-openstacklib master: Add Apache license header to all code https://review.opendev.org/c/openstack/puppet-openstacklib/+/943240 | 11:23 |
| tkajinam | I feel like I'm doing something horribly wrong but ... | 11:25 |
| d1nuc0m | tkajinam, is there a legal team or something like that which to ask? Practically all puppet modules are under Apache, but if we have a look at puppetlabs' or puppet's modules they do not use the header too | 11:29 |
| d1nuc0m | Even the stdlib | 11:30 |
| tkajinam | d1nuc0m, maybe legal-discuss@lists.openstack.org ? | 11:32 |
| d1nuc0m | tkajinam, thanks, can I write an email with you and tobias-urdin in CC? | 11:33 |
| d1nuc0m | It looks like there have been some discussions about headers (https://lists.openstack.org/pipermail/openstack-dev/2018-August/133929.html), but the faqs still contain "We do not yet have guidance for when to add or remove a copyright header in source files." (https://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers) | 11:36 |
| tkajinam | d1nuc0m, I think that is the discussion about copyright header, not license header | 11:53 |
| tkajinam | and for python code we ensure the license header is included in every source code by hacking | 11:54 |
| tkajinam | it'd be nice if you can start the thread, but my rough guess is that we are just told to add the license header according to the requirement of Apache license | 11:55 |
| tkajinam | idk if we can add the required check in our CI, though | 11:55 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-openstacklib master: Validate input for rabbitmq resources https://review.opendev.org/c/openstack/puppet-openstacklib/+/943225 | 11:58 |
| opendevreview | Merged openstack/puppet-ironic master: Fix incomplete assertion of conductor package/service https://review.opendev.org/c/openstack/puppet-ironic/+/942903 | 13:05 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-ironic stable/2024.2: Fix incomplete assertion of conductor package/service https://review.opendev.org/c/openstack/puppet-ironic/+/943250 | 13:12 |
| d1nuc0m | tkajinam, done, thanks | 13:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!