| opendevreview | OpenStack Proposal Bot proposed openstack/puppet-openstack-integration master: Updated from Puppet OpenStack modules constraints https://review.opendev.org/c/openstack/puppet-openstack-integration/+/946009 | 02:15 |
|---|---|---|
| opendevreview | Francesco Di Nucci proposed openstack/puppet-nova master: feat: nova::pci add device_specs and report_in_placement https://review.opendev.org/c/openstack/puppet-nova/+/946018 | 07:36 |
| d1nuc0m | Hi all, I tried to add device_specs to nova::pci, but I have a doubt - should it create a single array or multiple entries such as here https://docs.openstack.org/nova/latest/admin/pci-passthrough.html#support-for-multiple-types-of-vfs? | 07:38 |
| d1nuc0m | NP, fixed | 09:07 |
| d1nuc0m | Abandone | 09:07 |
| d1nuc0m | A question about nova::compute - it includes nova::pci and nova::compute::pci, without passing any parameter, how should then pci devices should be configured? Trying to declare a class { 'nova::pci': for example leads to a double declaration as it's already included | 09:17 |
| tobias-urdin | d1nuc0m: try declarating them before the nova::compute class in your manifest | 09:24 |
| d1nuc0m | tobias-urdin, thanks but it's somewhat complicated due to conditionals in my manifests | 09:31 |
| opendevreview | Francesco Di Nucci proposed openstack/puppet-nova master: fix: nova::compute now allows to pass PCI params https://review.opendev.org/c/openstack/puppet-nova/+/946027 | 11:02 |
| d1nuc0m | tobias-urdin, could something like this be a proper solution? https://review.opendev.org/c/openstack/puppet-nova/+/946027 | 11:02 |
| d1nuc0m | I know, missing changelog and tests to review, just to get an idea of I should continue with it | 11:03 |
| tobias-urdin | d1nuc0m: no i think it's include there intentional as to not cause a redeclaration and still load defaults, you're suppose to define the class before nova::compute if you need it | 11:28 |
| tobias-urdin | a include only defines it if there isn't any declaration yet | 11:29 |
| d1nuc0m | tobias-urdin, thanks, it works even though the result is a bit ugly as I have all the includes on top of file :D | 12:19 |
| tobias-urdin | np | 12:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!