| opendevreview | Benedikt Trefzer proposed openstack/puppet-openstacklib master: fix: make policy setting idempotent when using purge_config https://review.opendev.org/c/openstack/puppet-openstacklib/+/952591 | 07:28 |
|---|---|---|
| opendevreview | Benedikt Trefzer proposed openstack/puppet-nova master: make package names overwritable https://review.opendev.org/c/openstack/puppet-nova/+/885895 | 07:38 |
| opendevreview | Benedikt Trefzer proposed openstack/puppet-nova master: make package names overwritable https://review.opendev.org/c/openstack/puppet-nova/+/885895 | 09:25 |
| opendevreview | Tobias Urdin proposed openstack/puppet-watcher master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-watcher/+/958319 | 09:48 |
| opendevreview | Tobias Urdin proposed openstack/puppet-vitrage master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-vitrage/+/958320 | 09:55 |
| opendevreview | Tobias Urdin proposed openstack/puppet-zaqar master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-zaqar/+/958318 | 10:00 |
| opendevreview | Benedikt Trefzer proposed openstack/puppet-nova master: make package names overwritable https://review.opendev.org/c/openstack/puppet-nova/+/885895 | 10:51 |
| tkajinam | tobias-urdin, I'm wondering why we don't see that error in puppet-ceilometer ... | 11:30 |
| tobias-urdin | tkajinam: i tried searching for any references where we might be using params/deps directly in p-o-i but couldn't find any | 11:41 |
| opendevreview | Tobias Urdin proposed openstack/puppet-zaqar master: dnm: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-zaqar/+/958318 | 11:45 |
| tobias-urdin | ^ tested changing inherits to include, a longshot | 11:45 |
| tobias-urdin | might be that inherits changes how the caller_module_name is interpreted https://github.com/puppetlabs/puppetlabs-stdlib/blob/50a6b6b8ee08cfa62271010605e003c0958104e2/lib/puppet/parser/functions/assert_private.rb#L20 | 11:46 |
| tobias-urdin | so that it becomes p-o-i instead of zaqar as caller_module_name | 11:46 |
| opendevreview | Tobias Urdin proposed openstack/puppet-zaqar master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-zaqar/+/958318 | 12:11 |
| tobias-urdin | no luck | 12:11 |
| tkajinam | hmm ok | 12:39 |
| tkajinam | we can probably make deps private at least now and the consider replacing params | 12:39 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-zaqar master: Make deps class private https://review.opendev.org/c/openstack/puppet-zaqar/+/958318 | 12:43 |
| tkajinam | oops I pushed a conflicting update... | 12:44 |
| tkajinam | it's wired that https://review.opendev.org/c/openstack/puppet-vitrage/+/958320 passed, though | 12:45 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-zaqar master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-zaqar/+/958318 | 12:46 |
| tobias-urdin | tkajinam: perhaps some ordering in manifests is affecting that, but that sounds weird and should not happens(?) | 12:52 |
| tkajinam | yeah | 12:53 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-vitrage master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-vitrage/+/958320 | 13:10 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-vitrage master: assert_private() params and deps classes https://review.opendev.org/c/openstack/puppet-vitrage/+/958320 | 13:27 |
| tkajinam | hmmm so the problem seems to appear in a specific pattern, which includes the params class through inherits, before nothing else include the params class via include | 13:27 |
| tkajinam | s/nothing else/anything else/ | 13:27 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-horizon master: Use array to define command line https://review.opendev.org/c/openstack/puppet-horizon/+/958452 | 13:31 |
| opendevreview | Merged openstack/puppet-openstack_spec_helper master: Use full voxpupuli lint plugins https://review.opendev.org/c/openstack/puppet-openstack_spec_helper/+/957884 | 19:04 |
| opendevreview | Merged openstack/puppet-openstack_spec_helper master: Remove redundant puppet-lint configurations https://review.opendev.org/c/openstack/puppet-openstack_spec_helper/+/958334 | 19:04 |
| opendevreview | Merged openstack/puppet-openstack_spec_helper master: Directly execute gem command https://review.opendev.org/c/openstack/puppet-openstack_spec_helper/+/958343 | 19:04 |
| opendevreview | Merged openstack/puppet-octavia master: Add support for [DEFAULT] host option https://review.opendev.org/c/openstack/puppet-octavia/+/958364 | 19:13 |
| opendevreview | Merged openstack/puppet-horizon master: Remove unused params key https://review.opendev.org/c/openstack/puppet-horizon/+/958323 | 19:28 |
| opendevreview | Merged openstack/puppet-magnum master: Add support for [DEFAULT] host option https://review.opendev.org/c/openstack/puppet-magnum/+/958365 | 19:32 |
| opendevreview | Merged openstack/puppet-horizon master: Use array to define command line https://review.opendev.org/c/openstack/puppet-horizon/+/958452 | 19:32 |
| opendevreview | Merged openstack/puppet-watcher master: Fix rendering of [watcher_decision_engine] notification_topics https://review.opendev.org/c/openstack/puppet-watcher/+/958347 | 19:35 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Use undef to use default values https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958317 | 19:37 |
| opendevreview | Merged openstack/puppet-ironic master: inspector: Use ironic-inspector user by default https://review.opendev.org/c/openstack/puppet-ironic/+/958346 | 19:46 |
| opendevreview | Merged openstack/puppet-ironic master: inspector: Add support for [DEFAULT] host https://review.opendev.org/c/openstack/puppet-ironic/+/958357 | 19:47 |
| opendevreview | Merged openstack/puppet-watcher master: Add support for max_*_workers options https://review.opendev.org/c/openstack/puppet-watcher/+/958351 | 19:48 |
| opendevreview | Merged openstack/puppet-watcher master: Deprecate support of removed max_workers option https://review.opendev.org/c/openstack/puppet-watcher/+/958352 | 19:48 |
| opendevreview | Merged openstack/puppet-watcher master: Add support for [DEFAULT] host option https://review.opendev.org/c/openstack/puppet-watcher/+/958366 | 19:48 |
| opendevreview | Merged openstack/puppet-barbican master: Do not always install client https://review.opendev.org/c/openstack/puppet-barbican/+/958342 | 19:48 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Re-enable vitrage https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958332 | 20:01 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Install client packages https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958338 | 20:06 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Capture watcher resources in CI https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958339 | 20:06 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Directly execute gem command https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958344 | 20:19 |
| opendevreview | Merged openstack/puppet-openstack-integration master: Drop neutron::server::service_name https://review.opendev.org/c/openstack/puppet-openstack-integration/+/958345 | 20:19 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!