*** LindaWang has joined #refstack | 00:52 | |
*** claudiub|2 has joined #refstack | 04:40 | |
*** Rockyg has joined #refstack | 04:46 | |
*** markvoelker has quit IRC | 05:16 | |
*** Rockyg has quit IRC | 06:03 | |
*** claudiub has joined #refstack | 06:10 | |
*** claudiub|2 has quit IRC | 06:12 | |
*** xinliang has quit IRC | 06:57 | |
*** xinliang has joined #refstack | 07:10 | |
*** ChanServ sets mode: +o openstack | 07:13 | |
*** markvoelker has joined #refstack | 07:18 | |
*** markvoelker has quit IRC | 07:52 | |
*** markvoelker has joined #refstack | 08:48 | |
*** markvoelker has quit IRC | 09:21 | |
*** markvoelker has joined #refstack | 10:19 | |
*** markvoelker has quit IRC | 10:52 | |
*** claudiub has quit IRC | 11:06 | |
*** markvoelker has joined #refstack | 11:49 | |
*** markvoelker has quit IRC | 11:54 | |
*** markvoelker has joined #refstack | 11:56 | |
*** LindaWang has quit IRC | 12:47 | |
*** LindaWang has joined #refstack | 13:12 | |
*** LindaWang has quit IRC | 16:18 | |
*** catherineD has quit IRC | 16:24 | |
*** catherineD has joined #refstack | 16:27 | |
-openstackstatus- NOTICE: Gerrit OpenIDs have been accidentally overwritten and are in the process of being restored | 18:18 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being taken offline briefly to perform database repair work but should be back up shortly | 18:25 | |
*** ChanServ changes topic to "The Gerrit service on review.openstack.org is being taken offline briefly to perform database repair work but should be back up shortly" | 18:25 | |
*** ChanServ changes topic to "#refstack now we're on storyboard: https://storyboard.openstack.org/#!/project/700" | 19:22 | |
-openstackstatus- NOTICE: OpenIDs for the Gerrit service have been restored from a recent backup and the service is running again; before/after table states are being analyzed now to identify any remaining cleanup needed for changes made to accounts today | 19:22 | |
*** annegentle has joined #refstack | 20:22 | |
*** annegentle has quit IRC | 20:43 | |
mguiney | howdy y'all! | 21:44 |
---|---|---|
fungi | okay, so starting to get prepared for the <thing> you need done to refstack.openstack.org | 21:45 |
mguiney | so: we're currently taking a look at upgrading the refstack database, and need to make sure it is done as foundation admin, which requires the use of a "Foundation" group, as per the docs | 21:45 |
mguiney | oops, sorry to reiterate | 21:46 |
fungi | yeah, doc/source/refstack.rst says to create a group named "Foundation Group" group whereas we already have a "Group for OpenStack Foundation" group in the database | 21:46 |
fungi | so wondering whether these serve different purposes or whether i'm supposed to use the latter | 21:47 |
*** beisner has quit IRC | 21:47 | |
*** mrhillsman has quit IRC | 21:47 | |
fungi | also all the existing groups are named "Group for <something>" so creating a new group named "Foundation Group" would be completely counter to the existing naming convention, which makes me wonder whether the instructions there should be taken literally | 21:49 |
*** beisner has joined #refstack | 21:50 | |
*** mrhillsman has joined #refstack | 21:50 | |
fungi | looks like Group for OpenStack Foundation currently just has hogepodge and mguiney in it | 21:53 |
fungi | also, mguiney said something about "running a script" which requires foundation api permissions... what/where is the script in question? | 21:55 |
* fungi digs in meeting logs in search of clues | 21:55 | |
mguiney | ah, let me link | 21:56 |
mguiney | we are trying to get a patch merged for this real quick, but the script can be found here: | 21:57 |
mguiney | https://github.com/openstack/refstack/blob/master/tools/update-rs-db.py | 21:57 |
fungi | https://git.openstack.org/cgit/openstack/refstack/diff/tools/update-rs-db.py is what i just found in the meeting log | 21:57 |
fungi | ahh, okay, same one | 21:57 |
mguiney | it basically just grabs from a spreadsheet and adds in relevant data pertaining to the product to a given test result | 21:57 |
fungi | and you were waiting for https://review.openstack.org/499956 to get approved i guess | 21:58 |
mguiney | then, if all the updated data and links are valid, it verifies it | 21:58 |
mguiney | yep. | 21:58 |
fungi | looks like i'll need to pass it an api auth token; once i have a refstack account, how do i generate one of those? | 22:00 |
fungi | anyway, if it turns out we should use "Group for OpenStack Foundation" for this purpose, than there are already a couple people in that group who would ostensibly have permission to run the script in question... where are the acls for this defined? | 22:06 |
fungi | s/than/then/ | 22:06 |
fungi | grepping the source to see whether it's hard-coded to a specific group name or configurable | 22:08 |
fungi | seems it looks for an organization with a type of 0 | 22:12 |
fungi | there is only one organization with type=0, as expected | 22:13 |
fungi | and its group_id does indeed match the id in the group table for "Group for OpenStack Foundation" | 22:14 |
fungi | so i _think_ that means mguiney and hogepodge have the necessary permissions already? | 22:14 |
mguiney | ok so i just tracked some of it down | 22:15 |
mguiney | the api uses a file found at $WORKING_DIR/refstack/refstack/api/constants.py to define ownership | 22:15 |
mguiney | the default value, as defined in that file, on my install, is "foundation" | 22:16 |
mguiney | it may be something different on the prod server | 22:16 |
fungi | ROLE_FOUNDATION is at least, but the permissions in refstack/db/sqlalchemy/api.py at least filter on group type FOUNDATION (which constants.py defines as 0) | 22:17 |
fungi | and that maps to "Group for OpenStack Foundation" in the database | 22:17 |
fungi | for the get_foundation_users() function | 22:19 |
mguiney | excellent, so we should(?) have perms after all :/ | 22:19 |
mguiney | i'm so sorry for the trouble | 22:19 |
fungi | no, it's no trouble, i just want to be reasonably sure i don't break something or create more cruft that needs cleaning up | 22:19 |
mguiney | "role foundation" is 0 in mine as well, and i've successfully run the script | 22:20 |
fungi | so, maybe try a fairly trivial operation that requires those permissions just to see? | 22:20 |
mguiney | o7 | 22:20 |
fungi | and if that doesn't work, then we can troubleshoot | 22:20 |
fungi | and if someone shows up with a deeper knowledge of the codebase, maybe they can school us so we spend less time reverse-engineering this | 22:21 |
mguiney | can you access, via a browser, refstack.org/v1/results ? | 22:22 |
mguiney | refstack.openstack.org, excuse me | 22:22 |
mguiney | oh nevermind, hold on | 22:23 |
fungi | fwiw, refstack/api/controllers/products.py ProductsController.get() checks thusly: is_admin = user in db.get_foundation_users() | 22:24 |
fungi | so i expect we're on the right track | 22:24 |
fungi | and yes, https://refstack.openstack.org/ redirects to https://refstack.openstack.org/#/ for me and renders page content | 22:24 |
mguiney | yeah, that's what i noticed when i did a bit of digging | 22:38 |
mguiney | testing now | 22:38 |
*** markvoelker has quit IRC | 23:40 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!