*** markvoelker has joined #refstack | 00:11 | |
*** tosky has quit IRC | 00:52 | |
*** markvoelker has quit IRC | 03:13 | |
*** markvoelker has joined #refstack | 05:44 | |
*** markvoelker has quit IRC | 05:49 | |
*** markvoelker has joined #refstack | 07:46 | |
*** markvoelker has quit IRC | 08:19 | |
*** markvoelker has joined #refstack | 10:16 | |
*** tosky has joined #refstack | 10:27 | |
*** arxcruz|rover is now known as arxcruz|off | 10:33 | |
*** markvoelker has quit IRC | 10:50 | |
*** markvoelker has joined #refstack | 12:47 | |
*** markvoelker has quit IRC | 13:20 | |
*** markvoelker has joined #refstack | 13:33 | |
*** openstackgerrit has quit IRC | 17:33 | |
*** designbybeck has joined #refstack | 18:07 | |
mtreinish | hogepodge, mguiney: what am I supposed to look at? (saw the meeting log) | 20:47 |
---|---|---|
mguiney | ah right. I am currently fighting oslo config to try and get the api utils to recognize both refstack and subunit2sql conf flags | 20:50 |
mguiney | was going to try and forumlate me question a little better before pinging you | 20:50 |
mguiney | *my | 20:50 |
mtreinish | mguiney: ah ok | 20:51 |
mtreinish | mguiney: fwiw my biggest mistake with subunit2sql was using oslo.config and oslo.db to implement it | 20:51 |
mtreinish | when I write consuming code I do not even bother with trying to get the oslo.config stuff working and just call the db api directly with an engine | 20:52 |
mguiney | i'm honestly at this point just considering adding a section in refstack conf with the info we need, given that its only a few flags | 20:53 |
mtreinish | mguiney: like: https://github.com/openstack/openstack-health/blob/master/openstack_health/api.py#L92-L101 and | 20:53 |
* mguiney nods. i'll try that out | 20:53 | |
mtreinish | mguiney: honestly that's what I'd probably do | 20:53 |
mtreinish | I find dealing with oslo.config more of a pain than it's worth | 20:53 |
mguiney | cool, thank you | 20:54 |
mtreinish | although, you're supposed to be able to just leverage CONF.import_opt() to load external opts. When you have to start changing sections and stuff it's no fun | 20:55 |
* mguiney nods | 20:58 | |
mguiney | i'll continue tinkering on it and see what works best | 20:59 |
mguiney | thank you for input, apologies for the very vague question | 20:59 |
mguiney | one more thing- i may have a patch to subumit to subunit2sql that just allows for the optional usage of a flag that you currently cannot use, but allows for the handling of "impure" subunit (like that converted to v2 via command line)and doesnt otherwise affect the current implementation | 21:10 |
mguiney | what would be the best way to submit that | 21:10 |
mguiney | ^mtreinish | 21:10 |
mtreinish | mguiney: like?: https://review.openstack.org/#/c/507192/ | 21:11 |
mguiney | oh look | 21:11 |
mguiney | that's actually exactly the thing | 21:12 |
mtreinish | mguiney: ok cool, feel free to give that a review then. I'll ping masayukig, larainema, oomichi, and andreaf about it to try and get it merged soon | 21:18 |
mguiney | excellent, can do | 21:18 |
andreaf | mtreinish, mguiney: the change looks ok to me, but I'll leave it to masayukig to approve since he reviewed it already before - if he's not around today I can approve it tomorrow morning if it's urgent | 21:24 |
* mguiney nods | 21:24 | |
mguiney | thank you! | 21:24 |
hogepodge | thanks mtreinish and andreaf and mguiney! #teamwork | 21:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!