| *** lifeless has quit IRC | 01:06 | |
| *** lifeless has joined #refstack | 01:11 | |
| *** lifeless has quit IRC | 01:47 | |
| *** lifeless has joined #refstack | 01:49 | |
| *** lifeless has quit IRC | 02:19 | |
| *** lifeless has joined #refstack | 02:20 | |
| *** lifeless_ has joined #refstack | 03:46 | |
| *** lifeless has quit IRC | 03:46 | |
| *** lifeless has joined #refstack | 03:52 | |
| *** lifeless_ has quit IRC | 03:52 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 05:39 |
|---|---|---|
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 05:55 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] patch to test backward compatibilty/ container check https://review.openstack.org/570524 | 06:04 |
| *** kopecmartin has joined #refstack | 07:09 | |
| *** tosky has joined #refstack | 07:40 | |
| *** lifeless_ has joined #refstack | 08:06 | |
| *** lifeless has quit IRC | 08:07 | |
| kopecmartin | tosky, arxcruz|ruck, chandankumar anyone against this? https://review.openstack.org/#/c/573017/ | 08:16 |
| tosky | kopecmartin: why the follow-up commit is called "Remove admin_* from identity section " and not part 2? :) | 08:20 |
| kopecmartin | because it's unrelated patch to the first one, but both of the changes are needed for the third one | 08:20 |
| kopecmartin | I've created a story for the tenant->project change, so we can't forget about part 2 | 08:22 |
| tosky | so can we not call the first one as part 1? | 08:25 |
| kopecmartin | why not? everything which is stored in conf was renamed to from tenant to project, but all comments and variable names (which are not required for the third change) were not changed yet | 08:29 |
| kopecmartin | therefor part 1 and 2, but I'm happy to rename it if needed | 08:29 |
| arxcruz|ruck | kopecmartin: i'm always against big changes | 08:30 |
| chandankumar | my system is little screwed up, except a little delay in reply | 08:32 |
| kopecmartin | arxcruz|ruck, and therefor I divided the change into 2 parts , first is done by the change and the next one will be done later (next sprint probably) :) | 08:34 |
| tosky | ok, ok | 08:41 |
| arxcruz|ruck | guys, can we schedule a meeting and discuss the tempestconf? We still need to set some default behavior and i would like to have everyone synced with that | 08:42 |
| arxcruz|ruck | perhaps even write a doc how to write new services | 08:42 |
| arxcruz|ruck | for example, we are writing the defaults in several places | 08:42 |
| arxcruz|ruck | everyone of us are done it on our patches in a different way | 08:43 |
| arxcruz|ruck | i would like to have it in one single pattern | 08:43 |
| tosky | examples of those several places? | 08:45 |
| tosky | I remember -1 on patches due to this, and patches later fixed | 08:45 |
| *** lifeless has joined #refstack | 08:46 | |
| *** lifeless_ has quit IRC | 08:47 | |
| arxcruz|ruck | tosky: let me search for it | 08:52 |
| arxcruz|ruck | just a sec, because things are on fire on CI | 08:52 |
| arxcruz|ruck | tosky: one example: https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/compute.py#L34 where i'm setting the defaults for compute, perhaps set_default_tempest_options wasn't the best name and here https://github.com/openstack/python-tempestconf/blob/master/config_tempest/main.py#L77-L94 also setting the defaults | 08:58 |
| arxcruz|ruck | tosky: while on chandankumar https://review.openstack.org/#/c/568869/18/config_tempest/services/object_storage.py | 08:58 |
| arxcruz|ruck | he's creating the check_service_status, that should be called by set_default_tempest_options, however it's being called by https://review.openstack.org/#/c/568869/18/config_tempest/services/services.py line 202 | 08:59 |
| tosky | arxcruz|ruck: check_service_status and check_default_tempest_options can be both still present | 09:01 |
| tosky | arxcruz|ruck: if the problem is that check_service_status introduced by chandankumar does the job that set_default_tempest_option should do, that's a different story | 09:01 |
| arxcruz|ruck | tosky: yes | 09:01 |
| arxcruz|ruck | i don't want to be grumpy here but we could use a pattern | 09:02 |
| arxcruz|ruck | just saying | 09:02 |
| tosky | yes, and we have one, no? | 09:02 |
| arxcruz|ruck | if you guys don't agree, i'm also okay | 09:02 |
| tosky | we have set_default_tempest_options | 09:02 |
| arxcruz|ruck | tosky: that's what i'm proposing :) | 09:02 |
| tosky | there is no matter to be grumpy | 09:02 |
| tosky | we already have one | 09:02 |
| arxcruz|ruck | have what ? | 09:02 |
| tosky | a standard | 09:03 |
| arxcruz|ruck | where ? | 09:03 |
| arxcruz|ruck | oh, that's the word | 09:03 |
| arxcruz|ruck | standard | 09:03 |
| arxcruz|ruck | shit, pattern and standard in portuguese is the same word | 09:03 |
| arxcruz|ruck | hehehehe | 09:03 |
| tosky | that said, I'm not sure why check_service_status should be called only by set_default_tempest_options | 09:05 |
| tosky | of course check_service_status should not set conf.set('service_available', 'swift', 'False') | 09:06 |
| tosky | and it should not do if conf.get_bool_value(conf.get_defaulted('service_available', | 09:06 |
| tosky | because the entire point of check_service_status is to do the discovery | 09:06 |
| chandankumar | tosky: arxcruz|ruck anything to update on healthcheck api patch? | 09:17 |
| tosky | chandankumar: sure, just read the log ^^ | 09:18 |
| tosky | adding few comments | 09:22 |
| chandankumar | tosky: not visible | 09:23 |
| chandankumar | on gerrit | 09:23 |
| tosky | adding == present continuous | 09:24 |
| tosky | doing it now | 09:24 |
| tosky | not done yet | 09:24 |
| chandankumar | tosky: thanks :-) | 09:24 |
| *** lifeless has quit IRC | 11:45 | |
| *** lifeless_ has joined #refstack | 11:45 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] patch to test backward compatibilty/ container check https://review.openstack.org/570524 | 11:48 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Replace tenant by project, part 1 https://review.openstack.org/573017 | 12:08 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove admin_* from identity section https://review.openstack.org/573022 | 12:16 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 13:05 |
| kopecmartin | chandankumar, two features in https://review.openstack.org/#/c/568252/22..23/releasenotes/notes/allow-non-admin-user-upload-image-f2274cdec154a76b.yaml ? | 13:13 |
| chandankumar | kopecmartin: it was inter related so | 13:17 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 13:17 |
| chandankumar | kopecmartin: changed | 13:18 |
| kopecmartin | chandankumar, i just haven't seen two features sections anywhere .. ok :) | 13:19 |
| tosky | the problem was that the tag was not correct | 13:19 |
| tosky | the key in the yaml | 13:19 |
| tosky | try to check the generated release notes page from the release notes job | 13:21 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 14:15 |
| chandankumar | tosky: ^^ please have a look, I am not sure, I have made the changes as suggested | 14:30 |
| tosky | chandankumar: from a quick look, it looks you did | 14:39 |
| tosky | chandankumar: minor thing, the variable swift_default = object_storage.check_service_status() | 14:39 |
| tosky | it's not really swift_default, it's more swift_status :) | 14:39 |
| chandankumar | tosky: updating it | 14:41 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 14:45 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove admin_* from identity section https://review.openstack.org/573022 | 14:47 |
| kopecmartin | tosky, have a look on this please https://review.openstack.org/#/c/573017 | 14:49 |
| kopecmartin | we have too many patches :/ | 14:49 |
| tosky | better than none | 14:49 |
| chandankumar | so many things got changed in tempestconf | 14:51 |
| tosky | and some still missing | 14:53 |
| chandankumar | tosky: :-( | 15:25 |
| tosky | chandankumar: eh, I had to write that | 15:26 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 15:33 |
| chandankumar | tosky: time to add py3 gates also in python-tempestconf | 15:35 |
| tosky | chandankumar: if you can make swift work, sure (hint: it won't work) | 15:37 |
| *** lifeless_ has quit IRC | 15:59 | |
| *** lifeless has joined #refstack | 16:00 | |
| *** kopecmartin has quit IRC | 16:33 | |
| chandankumar | tosky: I will make the changes | 16:38 |
| tosky | chandankumar: you can't deploy right now swift/py2 in a full py3 environment | 16:39 |
| tosky | and it requires some non-trivial changes | 16:39 |
| openstackgerrit | Merged openstack/python-tempestconf master: Replace tenant by project, part 1 https://review.openstack.org/573017 | 17:38 |
| *** GregWaines has joined #refstack | 18:35 | |
| -openstackstatus- NOTICE: Zuul was restarted for a software upgrade; changes uploaded or approved between 19:30 and 19:50 will need to be rechecked | 19:58 | |
| *** GregWaines has quit IRC | 19:59 | |
| *** lifeless_ has joined #refstack | 21:28 | |
| *** lifeless has quit IRC | 21:28 | |
| *** lifeless_ has quit IRC | 21:38 | |
| *** lifeless has joined #refstack | 21:44 | |
| *** tosky has quit IRC | 23:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!