*** openstack has joined #refstack | 01:20 | |
*** ChanServ sets mode: +o openstack | 01:20 | |
*** noama has joined #refstack | 04:41 | |
*** kopecmartin has joined #refstack | 06:17 | |
*** lifeless has quit IRC | 06:49 | |
*** arxcruz|off is now known as arxcruz | 08:26 | |
arxcruz | kopecmartin: check my comments on trello board regarding the swift and healthcheck | 10:30 |
---|---|---|
kopecmartin | arxcruz, I'm just reading it | 10:31 |
kopecmartin | arxcruz, so you think that this patch https://review.openstack.org/#/c/573220/ should work? | 10:32 |
arxcruz | kopecmartin: yes, it should not run if swift is False | 10:35 |
arxcruz | regardless the discoverability option | 10:35 |
arxcruz | i don't know why we put discoverability to false, should not run those tests if swift is set to false anyway | 10:35 |
kopecmartin | arxcruz, btw, I just notice, if we don't set discoverability anywhere, will this call work? https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/object_storage.py#L70 | 10:37 |
arxcruz | kopecmartin: lol this will always return True if we don't set manually the discoverability | 10:38 |
arxcruz | because the default is true | 10:38 |
kopecmartin | arxcruz, I meant more if the default will be even obtained, because we are not calling get_defaulted there .. | 10:41 |
arxcruz | oh | 10:42 |
arxcruz | don't know | 10:42 |
* arxcruz don't want to think about it | 10:42 | |
kopecmartin | probably it will return an exception :D | 10:42 |
kopecmartin | yes, I got the exception (no section), I'll fix it | 10:45 |
arxcruz | ok | 10:45 |
kopecmartin | oh, but that's maybe expected, I'm trying to understand those except blogs | 10:53 |
*** tosky has joined #refstack | 11:28 | |
tosky | kopecmartin, arxcruz: hi! Did you found out what is the reason for the packstack failures? Some change in a puppet module? | 11:32 |
* tosky bbl - again :) | 11:33 | |
arxcruz | tosky: o don't remember do see packstack failing | 11:35 |
*** noama has quit IRC | 11:37 | |
kopecmartin | tosky, Hi, i didn't , I wasn't much trying though | 12:02 |
openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: DNM - Testing collect logs https://review.openstack.org/576444 | 12:06 |
tosky | arxcruz: all reviews from yesterday are failing on packstack jobs | 12:07 |
arxcruz | tosky: i see... i'll take a look in a few | 12:15 |
tosky | or we can try to find if someone else hit this too | 12:18 |
* tosky likes the Tom Sawyer approach | 12:21 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix check_service_status https://review.openstack.org/577802 | 12:23 |
*** kopecmartin has quit IRC | 12:47 | |
*** kopecmartin has joined #refstack | 12:48 | |
*** rmart04 has joined #refstack | 12:52 | |
*** kopecmartin has quit IRC | 13:19 | |
*** kopecmartin has joined #refstack | 13:20 | |
tosky | kopecmartin, arxcruz: before other breaking changes land, what do you think about merging my python3 patches? :) | 13:32 |
arxcruz | tosky: sure let's do it!@ | 13:32 |
kopecmartin | tosky, i think i have already reviewed | 13:33 |
tosky | yep, thanks | 13:35 |
tosky | arxcruz, kopecmartin : but first we need to unlock the gates | 13:36 |
tosky | I'm going to reask jpena | 13:36 |
kopecmartin | tosky, btw, https://review.openstack.org/#/c/572418/ do you think this tripleo-multinode gate is failing because this one needs to be merged first? https://review.rdoproject.org/r/#/c/14237/ | 13:40 |
tosky | kopecmartin: I suspect so, yes | 13:42 |
tosky | DEBUG: mv: cannot stat '/builddir/build/BUILDROOT/python-tempestconf-1.1.5-0.20180622123209.65d33b4.el7.x86_64/usr/etc/tempest/*': No such file or directory | 13:42 |
tosky | http://logs.openstack.org/18/572418/8/check/tripleo-ci-centos-7-containers-multinode/4dae687/logs/delorean_logs/65/d3/65d33b4d88bdfe67fa146f5c7524e985943da13b_dev/rpmbuild.log.txt.gz | 13:42 |
kopecmartin | tosky, yeah, but i haven't expected that the gate would be so smart and test packaging | 13:43 |
kopecmartin | :D | 13:43 |
tosky | I'm not sure what is the cleanest way to approach this; if the change in the packaging is merged without https://review.openstack.org/#/c/572418/, things may not work | 13:43 |
tosky | ... | 13:43 |
tosky | so maybe the solution is to keep a dummy file in that directory | 13:44 |
tosky | and remove it later | 13:44 |
tosky | so we can merge first the tempestconf change, than the packaging change, then remove the dummy file | 13:44 |
tosky | maybe it's better to ask to the more expert people in #rdo | 13:44 |
kopecmartin | makes sense, I'll update the patch | 13:45 |
*** rmart04 has quit IRC | 13:46 | |
kopecmartin | tosky, it doesn't have to have any structure, right? just a simple file with a comment maybe | 13:47 |
tosky | kopecmartin: even empty, so that the copy operation does not fail | 13:48 |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove the content of default-overrides.conf https://review.openstack.org/572418 | 13:50 |
arxcruz | tosky: regarding the tempest.conf collection, we need to have our own upload logs, because packstack will not rewrite their collect-logs to add tempest, they said they don't run tempest, so ... | 14:02 |
arxcruz | i'm doing that | 14:02 |
arxcruz | testing right now | 14:02 |
tosky | oh | 14:04 |
tosky | arxcruz: isn't it possible to adapt another existing collect-logs? I guess you already tried | 14:04 |
tosky | with some magic parameter or so | 14:04 |
arxcruz | tosky: yeah, i tried, for devstack it works, because the job inherit from devstack that uses default collect logs | 14:07 |
arxcruz | but the packstack job is inherit from packstack... and i don't think would be good to remove the inheritance just because of the logs, i can overwrite just the collect-logs in the post run | 14:07 |
tosky | arxcruz: I see; do we need a full rewrite, or can we just invoke the collect-logs from packstack and add a role which collects what it is missing? | 14:11 |
arxcruz | tosky: it was three tasks in a playbook | 14:12 |
tosky | arxcruz: uh, ok, let's see | 14:16 |
tosky | I thought you needed to reuse both packstack and devstack roles for collection logs | 14:17 |
arxcruz | tosky: no, devstack is working | 14:31 |
arxcruz | but packstack no | 14:31 |
tosky | yes, I mean | 14:32 |
tosky | when rewriting this section of the job (a post section?), I thought that it would be enough to combine the role for log collection from packstack, and its counterpart from devstack | 14:33 |
tosky | about packstack, jpena wrote this review that should hopefully fix the gates: https://review.openstack.org/#/c/577816/ | 14:34 |
arxcruz | tosky: is this http://logs.openstack.org/44/576444/11/check/python-tempestconf-tempest-packstack-admin/efb613a/job-output.txt.gz#_2018-06-25_12_26_30_318350 | 14:48 |
arxcruz | the error ? | 14:48 |
arxcruz | oh, yeah, it is :) | 14:48 |
arxcruz | just lazy to read irc logs today :) | 14:48 |
*** rmart04 has joined #refstack | 15:41 | |
kopecmartin | tosky, we need review on this https://review.openstack.org/#/c/541273, do you know who to ping? | 15:45 |
kopecmartin | it's done from our side, | 15:45 |
kopecmartin | we need feedback from refstack now | 15:45 |
tosky | ping the usual suspects here, and we can raise it during the next refstack IRC meeting | 15:47 |
*** rmart04 has quit IRC | 15:57 | |
*** Drive has joined #refstack | 16:42 | |
*** kopecmartin has quit IRC | 17:27 | |
openstackgerrit | megan guiney proposed openstack/refstack master: add nodejs install back into setup docs https://review.openstack.org/577887 | 17:56 |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove the content of default-overrides.conf https://review.openstack.org/572418 | 18:04 |
tosky | packstack issue fixed, I just did the recheck dance | 18:09 |
*** Drive has quit IRC | 18:12 | |
openstackgerrit | Merged openstack/refstack master: add nodejs install back into setup docs https://review.openstack.org/577887 | 18:34 |
*** rockyg has joined #refstack | 19:13 | |
*** rockyg has quit IRC | 19:22 | |
*** rockyg has joined #refstack | 19:57 | |
openstackgerrit | megan guiney proposed openstack/refstack master: Subunit Data upload API https://review.openstack.org/530681 | 20:59 |
openstackgerrit | megan guiney proposed openstack/refstack master: Subunit Data upload API https://review.openstack.org/530681 | 21:26 |
*** rockyg has quit IRC | 21:44 | |
*** tosky has quit IRC | 23:34 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!