| *** chkumar|off is now known as chkumar|ruck | 06:53 | |
| *** tosky has joined #refstack | 07:37 | |
| *** kopecmartin has joined #refstack | 07:37 | |
| arxcruz | kopecmartin: regarding https://review.openstack.org/#/c/603159 it's failing on refstack job, shall we fix that first? | 09:09 |
|---|---|---|
| kopecmartin | arxcruz, yes, I'm trying to find out, what's wrong | 09:10 |
| arxcruz | kopecmartin: i know | 09:10 |
| arxcruz | kopecmartin: first, the refstack code look for tennant_name instead of project_name, so it return None, we should change refstack to also look for project_name when load the accounts.yaml | 09:11 |
| arxcruz | kopecmartin: second, I'm not sure, but refstack adds the /v3 and shouldn't, but I'm not 100% sure, i was looking into that on ptg | 09:11 |
| kopecmartin | yeah, I discovered that thing about tenant_name, it's not used in Tempest anymore | 09:12 |
| arxcruz | kopecmartin: in tempest, it check both | 09:12 |
| openstackgerrit | Arx Cruz proposed openstack/refstack-client master: Update refstack client to use project instead of tenant https://review.openstack.org/603616 | 09:20 |
| arxcruz | kopecmartin: i believe this will fix the problem ^ | 09:20 |
| kopecmartin | arxcruz, nice, it looks good | 09:22 |
| arxcruz | kopecmartin: i'm not sure the return should remain tenant_{id|name} or project | 09:23 |
| arxcruz | we will see the gates | 09:23 |
| arxcruz | kopecmartin: if you can update your patch with a depends-on | 09:23 |
| kopecmartin | sure | 09:24 |
| openstackgerrit | Martin Kopec proposed openstack/refstack-client master: Fix overrides and image_path https://review.openstack.org/603159 | 09:25 |
| *** markvoelker has quit IRC | 09:25 | |
| *** markvoelker has joined #refstack | 10:30 | |
| *** markvoelker has quit IRC | 11:00 | |
| *** markvoelker has joined #refstack | 11:57 | |
| *** markvoelker has quit IRC | 12:31 | |
| *** mardim has quit IRC | 12:34 | |
| kopecmartin | arxcruz, more refactoring in refstack is needed in order to get rid of tenane_name :/ | 14:25 |
| arxcruz | kopecmartin: seriously ? | 14:25 |
| arxcruz | didn't work ? | 14:25 |
| kopecmartin | no, it didn't | 14:25 |
| kopecmartin | and when i grepped the source code for tenant_name, there are many other places where it's used | 14:25 |
| tosky | does it mean that it can't work with keystone v3? | 14:27 |
| chkumar|ruck | kopecmartin: arxcruz we also need make sure it does not break the refstack server api it is dependent on them | 14:38 |
| chkumar|ruck | may be hogepodge ^^ can help here | 14:38 |
| arxcruz | tosky: not really, it means either the accounts.yaml uses tenant_name instead of project_name or we update refstack to check for both | 14:40 |
| tosky | arxcruz: can't we simply set tenant_name in the generated accounts.yaml in addition of project_name? | 14:40 |
| tosky | kopecmartin: ^ | 14:40 |
| kopecmartin | tosky, we can, but is it a good idea? | 14:41 |
| tosky | that's what openrc does (from devstack), it sets both OS_PROJECT_NAME and OS_TENANT_NAME | 14:41 |
| kopecmartin | tenant_name is deprecated | 14:41 |
| tosky | deprecated != removed | 14:41 |
| tosky | if it's still used, it should be there | 14:41 |
| tosky | uhm, when was the Identity v2 API removed? | 14:42 |
| kopecmartin | i think that tempest doesn't use it anymore | 14:42 |
| tosky | for master | 14:42 |
| arxcruz | tosky: i don't know because tempest check for both | 14:42 |
| tosky | is it tempest? | 14:42 |
| arxcruz | on tempest side | 14:42 |
| arxcruz | tosky: tempest also uses accounts.yaml to generate the credentials | 14:43 |
| tosky | arxcruz: doesn't keystone v2 code use it? | 14:43 |
| arxcruz | tosky: ¯\_(ツ)_/¯ | 14:44 |
| tosky | if it's used, it's used | 14:44 |
| chkumar|ruck | tosky: https://github.com/openstack/tempest/blob/master/tempest/config.py#L208 | 14:44 |
| tosky | please see if adding it to accounts.yaml makes everything fine | 14:44 |
| tosky | chkumar|ruck: aaand? | 14:45 |
| chkumar|ruck | identity v2 is removed in queens release but we need to support till newton so we need to keep testing that | 14:45 |
| chkumar|ruck | there is currently one job testing v2 http://zuul.openstack.org/builds.html?job_name=swift-dsvm-functional-identity-v2 | 14:47 |
| tosky | chkumar|ruck: did you only look by job name? | 14:49 |
| tosky | I'm not sure that's enough to check the type of tests | 14:49 |
| chkumar|ruck | it is only for swift and kyestone changes | 14:49 |
| tosky | did you see what tempest-full executes on pike? | 14:49 |
| tosky | the name itself is not enough to see if keystone v2 tests are executed | 14:50 |
| chkumar|ruck | tempest-full-pike uses identity v3 by default https://github.com/openstack-dev/devstack/blob/stable/pike/stackrc#L211 from devstack which is what I am getting | 14:57 |
| chkumar|ruck | there is notmuch in zuul.yaml | 14:57 |
| tosky | chkumar|ruck: see ENABLE_IDENTITY_V2=$(trueorfalse True ENABLE_IDENTITY_V2) | 14:59 |
| tosky | that's more relevant | 14:59 |
| chkumar|ruck | http://codesearch.openstack.org/?q=ENABLE_IDENTITY_V2&i=nope&files=&repos= this is what I have basically I am seeing swift jobs only | 15:03 |
| tosky | chkumar|ruck: it's True by default | 15:04 |
| tosky | so no need to set anything | 15:04 |
| tosky | it was switched to False in Queens (correctly, no more v2) | 15:05 |
| chkumar|ruck | yes | 15:05 |
| tosky | tl;dr pike devstack deployes by default with both v3 and v2 | 15:05 |
| chkumar|ruck | so the question is if we get rid of tenenat_name to projest_name or keep it both ? | 15:06 |
| tosky | one thing is what is handled internally in tempestconf; another thing is the input provided to (refstack and) tempest | 15:10 |
| tosky | as long as we print we don't break pike tests, then whatever solution is fine | 15:11 |
| tosky | that's why I suggested to just add tenant_name into accounts.yaml | 15:11 |
| chkumar|ruck | sounds good to me | 15:12 |
| chkumar|ruck | arxcruz: kopecmartin ^^ | 15:12 |
| kopecmartin | tosky, into accounts.yaml? not to tempest.conf? | 15:14 |
| kopecmartin | based on my testing, by adding tenant_name to identity section equal to identity.project_name value, the problem is solved | 15:18 |
| tosky | oh, wherever it is correct | 15:21 |
| *** chkumar|ruck is now known as chkumar|off | 15:34 | |
| openstackgerrit | Martin Kopec proposed openstack/refstack-client master: Fix overrides and image_path https://review.openstack.org/603159 | 15:48 |
| arxcruz | i don't like this approach | 15:49 |
| arxcruz | honestly | 15:49 |
| arxcruz | we are starting to do workarounds with overrides, which i don't like | 15:49 |
| arxcruz | I would like to fix the refstack to check for both tenant and project name | 15:50 |
| arxcruz | that's how tempest do | 15:50 |
| kopecmartin | arxcruz, ok | 15:50 |
| kopecmartin | at least we will see if it's working tihs way | 15:50 |
| tosky | but I didn't want to say to use overrides; I wanted to say that, if tenant_name is needed at this point because refstack still consumes it, it should be set in tempest.conf, without the need for an override | 15:53 |
| *** kopecmartin has quit IRC | 15:56 | |
| hogepodge | I'm good with replacing tenant_name. Keystone v2 is long deprecated in Interop guidelines | 19:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!