*** markvoelker has joined #refstack | 03:57 | |
*** markvoelker has quit IRC | 04:02 | |
*** openstackgerrit has joined #refstack | 06:16 | |
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use member role for demo user https://review.openstack.org/624078 | 06:16 |
---|---|---|
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 07:16 |
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use member role for demo user https://review.openstack.org/624078 | 07:27 |
openstackgerrit | Quique Llorente proposed openstack/python-tempestconf master: Adapt python-tempestconf to python3 https://review.openstack.org/622343 | 07:29 |
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use Member role for demo user https://review.openstack.org/624078 | 07:34 |
*** tosky has joined #refstack | 07:58 | |
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [WIP]First create image, Member role for demo user https://review.openstack.org/624078 | 08:43 |
*** kopecmartin|off is now known as kopecmartin | 08:56 | |
openstackgerrit | Quique Llorente proposed openstack/python-tempestconf master: Adapt python-tempestconf to python3 https://review.openstack.org/622343 | 09:51 |
*** chandan_kumar has joined #refstack | 13:38 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Handle Forbidden exception when creating role https://review.openstack.org/624411 | 14:29 |
kopecmartin | tosky, arxcruz ^^ that should fix the devstack demo job | 14:30 |
arxcruz | kopecmartin: let's see if zuul god will be satisfied | 14:31 |
kopecmartin | sure | 14:32 |
kopecmartin | is the change ok? I'm asking just to prevent rechecking it later | 14:32 |
openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Added python-tempestconf-tempest-devstack-py3 https://review.openstack.org/622865 | 14:35 |
tosky | kopecmartin: did you find out what triggered the issue (aka "why was it working before?") | 14:37 |
kopecmartin | tosky, I'm still searching .. it was working because listing roles for a demo user was forbidden | 14:38 |
tosky | kopecmartin: and isn't it forbidden now too? | 14:39 |
kopecmartin | no | 14:39 |
kopecmartin | i reproduced it, i still have the env if you want to take a look | 14:39 |
tosky | oh, creation is now forbidden | 14:40 |
tosky | but if listing was forbidden, and now it isn't, why doesn't tempestconf find the role? Maybe because it is not assigned to the demo user? | 14:41 |
kopecmartin | tosky, only these roles are present by default: http://paste.openstack.org/show/737019/ | 14:42 |
chandan_kumar | kopecmartin:is it not the case that those roles are only used/meant for admin user only ? | 14:46 |
kopecmartin | chandan_kumar, probably .. at least only admin user can create a role | 14:47 |
tosky | chandan_kumar, kopecmartin: roles and users and independent | 14:50 |
tosky | roles are used to associate a users or a group to a project or a domain | 14:50 |
tosky | (or to a system, but that's a special case) | 14:50 |
tosky | (the system, not a system) | 14:50 |
tosky | kopecmartin: and member is there; Member and member are the same | 14:51 |
kopecmartin | tosky, is it just in this case or all roles are not case sensitive? | 14:53 |
chandan_kumar | tosky: but in previous cases on tripleo side, it behaves differently | 14:53 |
tosky | kopecmartin: roles are not case sensitive | 14:53 |
tosky | roles are not case sensitive :) | 14:54 |
tosky | let me find the relevant documentation | 14:54 |
kopecmartin | tosky, so then we have to modify this statement https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/object_storage.py#L52 | 14:54 |
tosky | tripleo may or may not create the same set of roles than devstack does | 14:54 |
tosky | uhm, or better, let me check one thing | 14:56 |
tosky | it depends on the keystone backend | 14:56 |
tosky | when using MySQL and SQLite, keystone is case-insensitive | 14:57 |
tosky | same for LDAP | 14:57 |
tosky | it's case-sensitive when using PostgreSQL | 14:57 |
chandan_kumar | kopecmartin: https://review.openstack.org/#/c/624411/ this fix is it possible to handle the same https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/object_storage.py#L43 below here? | 14:58 |
tosky | kopecmartin: would it work if you try to check if the role exist? | 14:58 |
kopecmartin | chandan_kumar, yes | 15:00 |
tosky | (for the record: https://docs.openstack.org/keystone/latest/admin/case-insensitive.html ) | 15:00 |
*** markvoelker has joined #refstack | 15:00 | |
kopecmartin | tosky, what do you mean? it checks if the role exists here https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/object_storage.py#L52 and on line 56 | 15:01 |
kopecmartin | chandan_kumar, it is possible, however in that case the except block will not know if listing or creating is the problem .. do we want that? | 15:03 |
chandan_kumar | kopecmartin: i think so | 15:04 |
kopecmartin | chandan_kumar, I'll wait to see if it solved the issue in the job and then I'll push another patchset which does that | 15:05 |
chandan_kumar | kopecmartin: use this card for tracking https://tree.taiga.io/project/tripleo-ci-board/issue/502?kanban-status=2027734 added your review here | 15:07 |
kopecmartin | chandan_kumar, do you know why refstack job fails with the same issue although it was fixed in our devstack demo job (see the review 624411 in zuul )? | 15:23 |
kopecmartin | http://logs.openstack.org/11/624411/1/check/refstack-client-devstack-tempestconf/d357c2d/job-output.txt.gz#_2018-12-11_15_10_33_591182 | 15:24 |
chandan_kumar | kopecmartin: need to check whether that review is picked up or not here | 15:27 |
kopecmartin | it's not, how to do it? | 15:27 |
chandan_kumar | by refstack-cleint job | 15:27 |
chandan_kumar | kopecmartin: http://logs.openstack.org/11/624411/1/check/refstack-client-devstack-tempestconf/d357c2d/job-output.txt.gz#_2018-12-11_15_09_35_142044 | 15:28 |
chandan_kumar | kopecmartin: not sure need to check with infra | 15:28 |
kopecmartin | chandan_kumar, the way how it's installed it seems that we are using not current python-tempestconf (cherry picked about the newest changes) to gate python-tempestconf changes, that's not good | 15:29 |
kopecmartin | https://github.com/openstack/refstack-client/blob/master/roles/generate-tempestconf-refstack/tasks/main.yaml#L6 | 15:29 |
chandan_kumar | kopecmartin: -c master is used for tempest branch | 15:29 |
chandan_kumar | not for tempestconf | 15:29 |
kopecmartin | python-tempestconf is installed together with tempest inside that setup_env script | 15:30 |
chandan_kumar | kopecmartin: yes | 15:30 |
kopecmartin | and if setup_env doesn't cherry pick python-tempestconf than old python-tempestconf is used | 15:31 |
chandan_kumar | one min | 15:31 |
kopecmartin | old = without the latest change it's gating | 15:31 |
chandan_kumar | kopecmartin: https://github.com/openstack/refstack-client/blob/master/setup_env#L111 -> it will clone the master branch | 15:32 |
chandan_kumar | kopecmartin: this part also needs to be fixed | 15:33 |
kopecmartin | yes | 15:34 |
kopecmartin | we should add a new task which installs the newest python-tempestconf in another venv and used that venv for running python-tempestconf | 15:34 |
chandan_kumar | kopecmartin: in order to land current patch, we need to make refstack job nv then | 15:34 |
kopecmartin | or something like that | 15:34 |
kopecmartin | i guess, because now it looks like a checkmate :D | 15:35 |
chandan_kumar | kopecmartin: yes hehe | 15:35 |
tosky | kopecmartin: I think whac-a-mole is the word that you are looking for | 15:35 |
kopecmartin | is it? /me googling what it is :D :D | 15:36 |
kopecmartin | tosky, chandan_kumar how can i make the job non-voting? | 15:43 |
chandan_kumar | kopecmartin: one | 15:43 |
chandan_kumar | kopecmartin: just add voting: false | 15:44 |
kopecmartin | where? | 15:44 |
chandan_kumar | just below the job | 15:44 |
tosky | kopecmartin: http://git.openstack.org/cgit/openstack/sahara-tests/tree/.zuul.yaml#n28 | 15:44 |
tosky | or even http://git.openstack.org/cgit/openstack/sahara-tests/tree/.zuul.yaml#n12 | 15:45 |
chandan_kumar | yes better example :-) | 15:45 |
kopecmartin | in our .zuul.yaml file, right? .. tripleo-ci-centos-7-scenario002-multinode-oooq-container is non voting too, but i don't see any voting:false in .zuul.yaml | 15:46 |
kopecmartin | that confuses me | 15:46 |
tosky | kopecmartin: maybe it has voting: false in the place where it's defined (tripleo-ci) | 15:48 |
kopecmartin | probably yes .. ok, I'm editing the patch | 15:49 |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Handle Forbidden exception when creating role https://review.openstack.org/624411 | 15:52 |
kopecmartin | chandan_kumar, will you fix refstack's job or should I ? | 15:53 |
*** markvoelker has quit IRC | 15:55 | |
*** markvoelker has joined #refstack | 15:56 | |
*** markvoelker has quit IRC | 16:01 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Handle Forbidden exception when creating role https://review.openstack.org/624411 | 17:09 |
*** kopecmartin is now known as kopecmartin|off | 17:16 | |
*** markvoelker has joined #refstack | 21:45 | |
*** markvoelker has quit IRC | 21:49 | |
*** markvoelker has joined #refstack | 22:24 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Handle Forbidden exception when creating role https://review.openstack.org/624411 | 23:24 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!