| *** openstackstatus has quit IRC | 02:22 | |
| *** openstack has joined #refstack | 02:25 | |
| *** ChanServ sets mode: +o openstack | 02:25 | |
| *** markvoelker has joined #refstack | 04:35 | |
| *** markvoelker has quit IRC | 04:40 | |
| *** markvoelker has joined #refstack | 05:06 | |
| *** andreaf has quit IRC | 06:09 | |
| *** andreaf has joined #refstack | 06:12 | |
| *** kopecmartin|off is now known as kopecmartin | 07:53 | |
| *** tosky has joined #refstack | 09:44 | |
| *** markvoelker has quit IRC | 12:18 | |
| *** irclogbot_3 has quit IRC | 13:26 | |
| *** irclogbot_3 has joined #refstack | 13:29 | |
| *** openstack has joined #refstack | 15:40 | |
| *** ChanServ sets mode: +o openstack | 15:40 | |
| kopecmartin | tosky, hi, when you have a minute, can you have a look? :) https://review.openstack.org/#/c/640865/ | 15:59 |
|---|---|---|
| tosky | kopecmartin: the problem is that I realized too late that the previous change had a small issue | 16:00 |
| tosky | if we continue this way, set_service_availability will be empty | 16:00 |
| tosky | but we can't remove it, as it's part of the "public API" | 16:00 |
| kopecmartin | hmm | 16:01 |
| tosky | so I wonder if it makes sense to continue this way, or move the code which sets the availability status for each service inside set_service_availability to do another loop and set the service availability, looping again over the discovered services | 16:01 |
| kopecmartin | let me check | 16:01 |
| kopecmartin | tosky, what do you mean by public API? I don't think anyone uses only certain parts of the tool, so why would that bet a problem? | 16:05 |
| kopecmartin | the only thing which should be untouched is the CLI | 16:05 |
| tosky | kopecmartin: we froze few methods to not break refstack | 16:06 |
| tosky | I guess we didn't do it consistently for all methods | 16:07 |
| tosky | so that method is probably not really used nor useful outside tempestconf | 16:07 |
| kopecmartin | oh refstack ... yeah, i don't see the method in the refstack's source code either , so it seems we were clever enough when we integrated pyhon-tempestconf to refstack :D | 16:09 |
| tosky | we call config_tempest() from config_tempest.main | 16:09 |
| tosky | and set_config_availability is called internally there, so I guess we can consider just config_tempest to be the interface | 16:10 |
| tosky | ok, ok | 16:10 |
| kopecmartin | :) | 16:11 |
| *** kopecmartin is now known as kopecmartin|off | 17:05 | |
| tosky | infra people kindly rebooted refstack.openstack.org | 18:19 |
| tosky | now, there is an issue on packstack | 18:19 |
| *** tosky has quit IRC | 22:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!