*** altlogbot_1 has quit IRC | 00:10 | |
*** altlogbot_2 has joined #refstack | 00:12 | |
*** markvoelker has joined #refstack | 04:14 | |
*** markvoelker has quit IRC | 04:18 | |
*** kopecmartin|off is now known as kopecmartin | 06:06 | |
*** markvoelker has joined #refstack | 06:15 | |
*** markvoelker has quit IRC | 06:49 | |
*** tosky has joined #refstack | 07:21 | |
*** markvoelker has joined #refstack | 07:46 | |
*** markvoelker has quit IRC | 08:18 | |
*** openstackgerrit has joined #refstack | 08:38 | |
openstackgerrit | Chandan Kumar (raukadah) proposed openstack/python-tempestconf master: Donot remove auth.tempest_roles section https://review.opendev.org/660606 | 08:38 |
---|---|---|
*** chandankumar has joined #refstack | 08:41 | |
chandankumar | kopecmartin: Hello | 08:46 |
chandankumar | kopecmartin: Do we still requires orchestration section? | 08:46 |
kopecmartin | kopecmartin, what orchestration section? | 08:47 |
chandankumar | kopecmartin: https://logs.rdoproject.org/32/20832/5/check/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset017-queens/605d927/logs/undercloud/home/zuul/tempest/etc/tempest.conf.txt.gz | 08:48 |
kopecmartin | maybe not, as heat has heat-tempest-plugin and it uses its own section .. [heat_plugin] or something like that | 08:50 |
kopecmartin | but I'd rather confirm with heat people | 08:50 |
chandankumar | kopecmartin: https://opendev.org/openstack/python-tempestconf/src/branch/master/config_tempest/users.py#L55 | 08:51 |
chandankumar | kopecmartin: do we know why we are removing this https://opendev.org/openstack/python-tempestconf/src/branch/master/config_tempest/users.py#L83 ? | 08:54 |
kopecmartin | chandankumar, https://github.com/openstack/python-tempestconf/commit/310fd11709b79dc212b804294aae007c683642a2 | 08:54 |
kopecmartin | need to try it on devstack, maybe it doesn't have to be removed completely .. | 08:55 |
chandankumar | kopecmartin: there is other issue also | 08:55 |
chandankumar | if auth.tempest_roles = member is setted | 08:55 |
kopecmartin | then start with creating a bug | 08:55 |
chandankumar | and as extra overrides someone passes auth.tempest_roles = creator | 08:56 |
chandankumar | it got replaced | 08:56 |
chandankumar | I think it should be appended | 08:56 |
kopecmartin | if you pass an override, you'll override any value set there previously .. | 08:59 |
chandankumar | kopecmartin: https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L334 | 08:59 |
chandankumar | it is also coming from here | 08:59 |
kopecmartin | use --append if you want to append a value | 09:00 |
chandankumar | kopecmartin: in order to fix the queens, https://logs.rdoproject.org/32/20832/5/check/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-queens/e11e2cd/logs/undercloud/home/zuul/tempest.log.txt.gz#_2019-05-22_07_38_27 | 09:00 |
chandankumar | kopecmartin: --append is not implemented in validate-tempest role | 09:00 |
kopecmartin | then implement it, what's the problem> | 09:00 |
kopecmartin | ? | 09:00 |
chandankumar | we are in the process of deprecating it | 09:01 |
tosky | where it == validate-tempest, right? But then the replacement should provide that | 09:01 |
tosky | and in the meantime, --append can still be used | 09:02 |
tosky | in any case, not a problem of tempestconf, if it provides the functionality | 09:03 |
chandankumar | tosky: currently there is one blocker we need to implement clouds.yaml support for overcloud then we will remove it completely | 09:03 |
chandankumar | let me see | 09:03 |
tosky | chandankumar: but then the replacement should provide the functionality | 09:04 |
kopecmartin | chandankumar, it seems is a complex issue, if you think a change on python-tempestconf side is needed, create a bug on storyboard stating what's wrong, how you suggest to fix it , why, link it with other bugs and important information .. etc. | 09:04 |
tosky | that too | 09:06 |
*** markvoelker has joined #refstack | 09:15 | |
*** lifeless_ is now known as lifeless | 09:46 | |
*** markvoelker has quit IRC | 09:49 | |
chandankumar | kopecmartin: https://review.opendev.org/#/c/660613/ and https://review.opendev.org/660351 | 09:59 |
chandankumar | let's wait for the result https://review.rdoproject.org/r/#/c/20832/ | 09:59 |
chandankumar | kopecmartin: it is not going to work | 10:19 |
chandankumar | above takes care of member role | 10:19 |
chandankumar | but not Member role | 10:19 |
chandankumar | in Tripleo and packstack Member role is used | 10:19 |
*** markvoelker has joined #refstack | 10:46 | |
tosky | argh, not again | 11:10 |
chandankumar | kopecmartin: https://storyboard.openstack.org/#!/story/2005755 | 11:15 |
*** markvoelker has quit IRC | 11:18 | |
kopecmartin | chandankumar, as I'm looking at this log https://logs.rdoproject.org/32/20832/5/check/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-queens/e11e2cd/logs/undercloud/home/zuul/tempest.log.txt.gz#_2019-05-22_07_38_27 | 11:19 |
kopecmartin | it fails, because the job didn't specify role as an override | 11:19 |
kopecmartin | therefore python-tempestconf uses the default value (_member_) which is not present in the environment and therefore it removes the whole option | 11:19 |
chandankumar | kopecmartin: https://review.opendev.org/#/c/660036/ caused | 11:19 |
chandankumar | kopecmartin: I am going to include it in the same review | 11:20 |
kopecmartin | this is tripleo CI automation issue | 11:21 |
kopecmartin | this change is wrong https://review.opendev.org/#/c/660036/ | 11:21 |
chandankumar | tempest comes under tripleo ci | 11:22 |
chandankumar | kopecmartin: https://storyboard.openstack.org/#!/story/2005756 | 11:22 |
kopecmartin | it's build on incorrect presumption that this reveiw https://review.opendev.org/#/c/638617/ is doing something it is not | 11:22 |
chandankumar | kopecmartin: yes | 11:25 |
chandankumar | kopecmartin: https://storyboard.openstack.org/#!/story/2005756 | 11:25 |
tosky | chandankumar: what does it mean that "tempest comes under tripleo ci"? | 12:13 |
tosky | in this context and channel | 12:14 |
*** markvoelker has joined #refstack | 12:16 | |
chandankumar | tosky: sorry , it was not meant for here | 12:26 |
*** markvoelker has quit IRC | 12:29 | |
*** tosky has quit IRC | 14:45 | |
*** tosky has joined #refstack | 14:46 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix checking of roles https://review.opendev.org/660748 | 14:57 |
chandankumar | kopecmartin: ^^ we also need to handle Member case | 16:04 |
chandankumar | both member and Member | 16:04 |
kopecmartin | chandankumar, hmm, ok, i don't see a problem in that, if it's already trying member, it can also try Member | 16:08 |
chandankumar | kopecmartin: we have added workaround there | 16:09 |
chandankumar | kopecmartin: https://review.opendev.org/#/c/660649/ -> if above patches fixes that | 16:10 |
chandankumar | I can abandon that | 16:10 |
*** kopecmartin is now known as kopecmartin|off | 16:25 | |
*** chandankumar is now known as raukadah | 17:14 | |
*** samueldmq has joined #refstack | 17:51 | |
*** tosky has quit IRC | 18:30 | |
*** tosky has joined #refstack | 18:30 | |
openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix checking of roles https://review.opendev.org/660748 | 19:49 |
*** tosky has quit IRC | 23:11 | |
*** tosky has joined #refstack | 23:11 | |
*** tosky has quit IRC | 23:34 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!