| *** tosky has quit IRC | 00:56 | |
| *** irclogbot_0 has quit IRC | 08:24 | |
| *** szaher has quit IRC | 08:24 | |
| *** beisner has quit IRC | 08:24 | |
| *** openstackgerrit has quit IRC | 08:24 | |
| *** fungi has quit IRC | 08:24 | |
| *** kopecmartin has quit IRC | 08:24 | |
| *** arxcruz has quit IRC | 08:24 | |
| *** jhesketh has quit IRC | 08:24 | |
| *** andreaf has quit IRC | 08:24 | |
| *** mgagne has quit IRC | 08:24 | |
| *** lifeless has quit IRC | 08:24 | |
| *** jhesketh has joined #refstack | 08:24 | |
| *** beisner has joined #refstack | 08:24 | |
| *** openstackgerrit has joined #refstack | 08:24 | |
| *** kopecmartin has joined #refstack | 08:24 | |
| *** irclogbot_0 has joined #refstack | 08:24 | |
| *** mgagne has joined #refstack | 08:24 | |
| *** lifeless has joined #refstack | 08:24 | |
| *** fungi has joined #refstack | 08:24 | |
| *** szaher has joined #refstack | 08:24 | |
| *** andreaf has joined #refstack | 08:24 | |
| *** arxcruz has joined #refstack | 08:24 | |
| *** tosky has joined #refstack | 09:00 | |
| tosky | I'm reviewing the tempestconf change, really, give me a few more minutes :) | 09:51 |
|---|---|---|
| tosky | arxcruz: when someone puts energy in reviewing a change (rechecking it, for example, and helping with the related dependencies), and the said person is around, it'd be nice to leave some time for that person to recheck a change | 10:14 |
| tosky | especially if we are talking about one hour more or less | 10:15 |
| arxcruz | tosky: ? | 10:15 |
| tosky | arxcruz: https://review.opendev.org/#/c/694956/ | 10:15 |
| arxcruz | tosky: so, kopecmartin ping me this morning to review it, which i did, i check the code, check the jobs, but i did not check all the coments | 10:17 |
| tosky | arxcruz: if you had stopped at checking the jobs, that would have been fine | 10:17 |
| tosky | what have you gained by single-approving it? | 10:17 |
| tosky | do I single approve every change? No, I wait for the other people (and gently ping them when it's needed) | 10:17 |
| arxcruz | tosky: I did by mistake, he asked for review two patches i open in two tabs | 10:19 |
| arxcruz | tosky: i never single approve patches | 10:19 |
| tosky | fine, I see, ok | 10:19 |
| tosky | but now removing +w is pointless: I added +2 in the meantime | 10:19 |
| tosky | otherwise I would have toggled -w | 10:20 |
| arxcruz | kopecmartin | arxcruz: chkumar|ruck, when you have a moment, please, have a look: https://review.opendev.org/#/c/697077 , https://review.opendev.org/#/c/694956/ | 10:20 |
| arxcruz | that was his message this morning, i by accident +w the different one | 10:20 |
| tosky | arxcruz: 697077 is already approved | 10:20 |
| *** tosky has quit IRC | 10:21 | |
| *** tosky has joined #refstack | 10:21 | |
| arxcruz | tosky: as i said, it was a mistake, didn't meant to bypass other people reviews, too many tabs open in the browser | 10:22 |
| tosky | ack, oki | 10:22 |
| tosky | you can readd +w, I guess | 10:23 |
| openstackgerrit | Merged openstack/python-tempestconf master: Add train jobs, make master packstack non voting https://review.opendev.org/697077 | 10:33 |
| openstackgerrit | Merged openstack/python-tempestconf master: Don't use name of a service as a key https://review.opendev.org/694956 | 15:09 |
| *** tosky has quit IRC | 18:54 | |
| *** tosky has joined #refstack | 22:10 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!