| *** tosky has quit IRC | 00:42 | |
| openstackgerrit | Martin Kopec proposed osf/refstack master: Add shared-file-system guideline https://review.opendev.org/c/osf/refstack/+/779034 | 07:49 |
|---|---|---|
| *** tosky has joined #refstack | 08:34 | |
| kopecmartin | tosky: arxcruz hi, when you have a moment: https://review.opendev.org/c/osf/python-tempestconf/+/772304 https://review.opendev.org/c/osf/python-tempestconf/+/778551 | 09:32 |
| tosky | kopecmartin: but then shouldn't the base class for the placement service just be Service? | 09:34 |
| kopecmartin | let me chekc | 09:35 |
| kopecmartin | tosky: hmm, Service class returns [] for set_versions, there's no logic defined there | 09:36 |
| tosky | ok, we may have a problem of "unclear naming" | 09:36 |
| kopecmartin | VersionedService has this: https://opendev.org/osf/python-tempestconf/src/branch/master/config_tempest/services/base.py#L172-L175 | 09:36 |
| tosky | apart from that, all the gates (including the tripleo ones, where the endpoint ends with /placement) seem happy, so... | 09:37 |
| kopecmartin | might be , anything we can address in a different patch? | 09:38 |
| tosky | nah | 09:38 |
| tosky | what I get is that the service is versioned, just the endpoint isn't | 09:39 |
| kopecmartin | i was confused with that too when i was debugging the bug | 09:40 |
| openstackgerrit | Martin Kopec proposed osf/refstack master: Target name in the downloaded list's name https://review.opendev.org/c/osf/refstack/+/779101 | 12:21 |
| openstackgerrit | Martin Kopec proposed osf/refstack master: Add shared-file-system guideline https://review.opendev.org/c/osf/refstack/+/779034 | 12:21 |
| openstackgerrit | Merged osf/refstack master: Target name in the downloaded list's name https://review.opendev.org/c/osf/refstack/+/779101 | 16:02 |
| openstackgerrit | Merged osf/refstack master: Add shared-file-system guideline https://review.opendev.org/c/osf/refstack/+/779034 | 16:04 |
| *** arxcruz is now known as arxcruz|off | 21:04 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!