| *** DennyZhang has joined #savanna | 05:41 | |
| *** DennyZhang has quit IRC | 06:08 | |
| *** nadya_ has joined #savanna | 06:56 | |
| *** nadya_ has quit IRC | 07:14 | |
| *** yrunts has joined #savanna | 13:20 | |
| *** yrunts has quit IRC | 13:20 | |
| *** yrunts has joined #savanna | 13:20 | |
| *** qwerty_nor has joined #savanna | 13:55 | |
| mattf | yrunts++ for reaching out to resolve a review | 13:58 |
|---|---|---|
| *** tmckay has joined #savanna | 14:21 | |
| tmckay | mattf, https://review.openstack.org/#/c/64741 looks like boilerplate. Is that standard test wrapper stuff? | 14:46 |
| tmckay | How much is custom for savannaclient? | 14:47 |
| mattf | tmckay, it is very much boilerplate, copied all over the place honestly. there is a little customization for savannaclient (instead of novaclient) | 14:49 |
| tmckay | thanks, I hadn't really poked at the test stuff before. Nice that it's standard. | 14:50 |
| mattf | standard-ish | 14:50 |
| mattf | there's so much c&p code in OS | 14:50 |
| tmckay | hmm, maybe another OS project to haul all the meta-common stuff into one place? :) | 14:51 |
| *** yrunts has quit IRC | 15:04 | |
| *** ruhe has joined #savanna | 15:12 | |
| *** bouncy has joined #savanna | 15:29 | |
| *** ruhe has left #savanna | 15:33 | |
| *** guest234234 has joined #savanna | 15:34 | |
| *** ruhe2 has joined #savanna | 15:36 | |
| *** rnirmal has joined #savanna | 15:47 | |
| *** jmaron has joined #savanna | 15:47 | |
| tmckay | jmaron, welcome | 15:51 |
| tmckay | fancy meeting you here | 15:51 |
| * tmckay runs for snacks | 15:51 | |
| *** qwerty_nor has quit IRC | 15:54 | |
| jmaron | hi *he responded once returning from refilling his coffee bucket* | 15:54 |
| *** guest234234 has left #savanna | 16:12 | |
| *** guest23423423 has joined #savanna | 16:12 | |
| *** ruhe2 is now known as _ruhe | 16:13 | |
| *** _ruhe is now known as ruhe2 | 16:15 | |
| *** yrunts has joined #savanna | 16:16 | |
| *** ruhe2 is now known as _ruhe | 16:19 | |
| *** DennyZhang has joined #savanna | 16:20 | |
| *** _ruhe has left #savanna | 16:22 | |
| *** DennyZhang has quit IRC | 16:37 | |
| *** guest23423423 has left #savanna | 16:38 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Eliminate extra newlines in generated workflow.xml https://review.openstack.org/64857 | 16:49 |
| tmckay | bah, I forgot the pep8 again! | 16:53 |
| tmckay | I need to alias git review | 16:53 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Eliminate extra newlines in generated workflow.xml https://review.openstack.org/64857 | 16:54 |
| *** bouncy has quit IRC | 17:15 | |
| *** bouncy has joined #savanna | 17:16 | |
| *** ruhe has joined #savanna | 17:32 | |
| *** bouncy has quit IRC | 17:37 | |
| *** nadya_ has joined #savanna | 17:57 | |
| *** ruhe is now known as _ruhe | 17:57 | |
| *** _ruhe is now known as ruhe | 18:13 | |
| *** ruhe is now known as _ruhe | 18:28 | |
| *** nadya_ has quit IRC | 18:30 | |
| *** nadya_ has joined #savanna | 18:30 | |
| *** nadya_ has quit IRC | 18:31 | |
| *** nadya_ has joined #savanna | 18:32 | |
| *** _ruhe is now known as ruhe | 18:33 | |
| *** akuznetsov has joined #savanna | 18:41 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Eliminate extra newlines in generated workflow.xml https://review.openstack.org/64857 | 18:59 |
| *** nadya_ has quit IRC | 19:05 | |
| *** nadya_ has joined #savanna | 19:05 | |
| *** nadya_ has quit IRC | 19:10 | |
| tmckay | aignatov, ping | 19:46 |
| ruhe | tmckay: he probably left his computer at work on | 19:50 |
| ruhe | we still have holidays here | 19:50 |
| tmckay | :) | 19:50 |
| tmckay | ruhe, thanks. I noticed that there are integration tests for mapreduce/pig, but nothing for hive (and of course the new java action workflow) | 19:50 |
| tmckay | I'm wondering how hard it is to test the integration test itself. Those run in the lab, don't they? | 19:51 |
| ruhe | yes, we have a dedicated hardware to run these tests | 19:51 |
| tmckay | this is my question. Do we want to expand edp integration tests, and how easily can I develop them | 19:51 |
| ruhe | it would definitely be useful to cover hive and java action. and you can contribute to that part without any problem. just add your code to https://git.openstack.org/cgit/openstack/savanna/tree/savanna/tests/integration, it'll run and you'll see if it works | 19:53 |
| tmckay | ruhe, okay. Is there a way to force a run so I don't have to wait? (I think I've seen people use comments for that) | 19:54 |
| tmckay | patch, run, patch, run, patch, run ... | 19:54 |
| ruhe | once most of the folks get back from holidays (which will be on jan13) you'll be able to ping those who manage the lab and jenkins | 19:55 |
| tmckay | okay, thanks | 19:55 |
| ruhe | re "patch, run, patch, run, patch, run ..." doesn't it happend automatically? | 19:55 |
| tmckay | I think so, but it takes a little while. I am impatient :) | 19:55 |
| ruhe | oh, i see :) | 19:56 |
| ruhe | current hardware works fine with 3 integration tests running at the same time. so there will always be some queue | 19:57 |
| ruhe | there soon will be a way to retrigger jenkins jobs by leaving a comment in gerrit. it'll help in cases of tests failed because of faulty environment, not because of the change itself | 19:59 |
| tmckay | okay, thanks | 20:12 |
| *** yrunts has quit IRC | 20:27 | |
| openstackgerrit | A change was merged to openstack/savanna-dashboard: Changing name of "Jar" jobs to "MapReduce" https://review.openstack.org/64718 | 20:49 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Fix typos in edp integration test utility method name https://review.openstack.org/64906 | 20:54 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Eliminate extra newlines in generated workflow.xml https://review.openstack.org/64857 | 21:09 |
| *** tmckay is now known as _tmckay | 21:28 | |
| *** SergeyLukjanov has joined #savanna | 22:10 | |
| *** qwerty_nor has joined #savanna | 23:04 | |
| *** SergeyLukjanov has quit IRC | 23:26 | |
| openstackgerrit | A change was merged to openstack/savanna: Fix deleting cinder volumes https://review.openstack.org/64183 | 23:29 |
| *** ruhe is now known as _ruhe | 23:44 | |
| *** rnirmal has quit IRC | 23:54 | |
| openstackgerrit | A change was merged to openstack/savanna: Added unit-tests to Heat engine https://review.openstack.org/62768 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!