| *** xuhaiwei_ has quit IRC | 00:06 | |
| *** xuhaiwei has joined #senlin | 00:10 | |
| *** zhenguo has joined #senlin | 01:24 | |
| *** mathspanda has joined #senlin | 01:50 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Misc tweaking to action behavior https://review.openstack.org/218673 | 01:51 |
|---|---|---|
| *** Yanyanhu has joined #senlin | 02:01 | |
| *** elynn has joined #senlin | 02:10 | |
| *** elynn_ has joined #senlin | 02:14 | |
| *** elynn has quit IRC | 02:14 | |
| *** elynn has joined #senlin | 02:14 | |
| *** elynn has quit IRC | 02:19 | |
| *** elynn has joined #senlin | 02:21 | |
| *** elynn_ has quit IRC | 02:27 | |
| *** elynn_ has joined #senlin | 02:29 | |
| Yanyanhu | hi, xuhaiwei, are you around? | 02:31 |
| xuhaiwei | yes | 02:32 |
| Yanyanhu | https://review.openstack.org/218047 I think there could be some problems to use 'translate_exception' decorator for those two methods in sdk driver module | 02:34 |
| Yanyanhu | since invoke_with_catch function expects at leat on parameter but those two functions who are decorated are actually not instance method or classmethod of a Class | 02:35 |
| Yanyanhu | so the code will complain 'invoke_with_catch expect at least one param but 0 given' | 02:36 |
| xuhaiwei | ok, I will see it | 02:37 |
| *** elynn__ has joined #senlin | 02:37 | |
| Yanyanhu | ok, thanks :) | 02:37 |
| Yanyanhu | the error msg is just like the result in the functional test case http://logs.openstack.org/47/218047/1/experimental/gate-senlin-dsvm-functional/355fa4c/console.html.gz | 02:38 |
| *** elynn__ has quit IRC | 02:39 | |
| *** elynn has quit IRC | 02:40 | |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Revise policy_type functional test https://review.openstack.org/218707 | 02:45 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Add 'singleton' property to base policy https://review.openstack.org/218708 | 02:59 |
| *** Tennyson has joined #senlin | 02:59 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Misc tweaking to action behavior https://review.openstack.org/218673 | 03:18 |
| *** lawrance_ has joined #senlin | 03:50 | |
| *** LiuWei has joined #senlin | 04:02 | |
| openstackgerrit | Merged stackforge/senlin: Misc tweaking to action behavior https://review.openstack.org/218673 | 05:38 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Fix a bug in cluster scale in action https://review.openstack.org/218740 | 06:15 |
| *** huangtianhua has joined #senlin | 06:25 | |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Invoke parse_exception directly to handle exception in sdk driver https://review.openstack.org/218743 | 06:27 |
| *** Qiming has joined #senlin | 06:28 | |
| Yanyanhu | hi, xuhaiwei, Qiming, just proposed a patch to fix the exception handling in sdk driver https://review.openstack.org/218743 | 06:28 |
| Yanyanhu | since the decorator is not suitbale for those two functions in sdk driver module, I just invoke parse_exception directly to make the translation | 06:29 |
| xuhaiwei | Yanyanhu, I have thought about it long, just cant get a good solution for this problem | 06:29 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Expose event choice from scaling policy https://review.openstack.org/218744 | 06:29 |
| Yanyanhu | hi, xuhaiwei, yes, so I think maybe we can just treat these two function specially and invoke parse_exception directly | 06:30 |
| Yanyanhu | we just don't use decorator to wrap the translation progress | 06:31 |
| Qiming | looks like the right solution to me | 06:32 |
| Qiming | the create_connection operation was only invoked from the constructors of all openstack/* drivers | 06:33 |
| Qiming | those constructors are not suitable for a translate_exception decorator | 06:33 |
| xuhaiwei | ok, agree | 06:34 |
| Yanyanhu | ok, so we just treat them as special cases. And maybe in future, we can find a better solution to cover all these cases, we change it then | 06:34 |
| Yanyanhu | hi, Qiming, just saw your comment on the patch for cluster scale in action | 06:38 |
| Yanyanhu | I think you're right | 06:39 |
| Yanyanhu | after the event is supported, we don't need to rely on count is negative to tell whether this is a scale in or out action | 06:39 |
| Yanyanhu | so should we change it back as before? or we use this as an interim solution? | 06:40 |
| Qiming | once 218744 is merged, we fix the integer problem | 06:41 |
| Qiming | and we can treat it as the basis from now on | 06:41 |
| Yanyanhu | ok | 06:41 |
| openstackgerrit | Merged stackforge/senlin: Invoke parse_exception directly to handle exception in sdk driver https://review.openstack.org/218743 | 06:44 |
| openstackgerrit | Merged stackforge/senlin: Expose event choice from scaling policy https://review.openstack.org/218744 | 07:02 |
| Yanyanhu | hi, Qiming, xuhaiwei, seems the cluster action workflow is broken for some bugs http://paste.openstack.org/show/434488/ | 07:34 |
| Yanyanhu | looks like the start_time of action is not filled correctly | 07:34 |
| xuhaiwei | cant reproduce the error | 07:36 |
| Yanyanhu | hi, xuhaiwei, you can pull the latest code and try again | 07:37 |
| Yanyanhu | just happened recently | 07:37 |
| xuhaiwei | i did it | 07:38 |
| Yanyanhu | oh, if so, maybe my db's problem | 07:38 |
| xuhaiwei | my environment is a little, I even can't do cluster-list | 07:38 |
| xuhaiwei | a little strange | 07:38 |
| Yanyanhu | ... | 07:38 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Revise policy_type functional test https://review.openstack.org/218707 | 07:40 |
| Yanyanhu | ah, I see | 07:43 |
| Yanyanhu | hi, Qiming, since the start_time of action is assigned value in db side | 07:44 |
| Yanyanhu | http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/actions/base.py#n475 | 07:44 |
| Yanyanhu | therefor, the start_time of action loaded in this line is actually None. http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/actions/base.py#n468 | 07:45 |
| Yanyanhu | seems we need to reload the action again after step2... | 07:45 |
| Yanyanhu | or we can revise the logic of start_time assignment | 07:46 |
| Qiming | reload the action? | 07:59 |
| Qiming | that will create yet a new context, right? | 08:00 |
| Yanyanhu | just need to rebuild it | 08:00 |
| Yanyanhu | use Action.load(context, db_action=res) | 08:00 |
| Qiming | why rebuild is needed? | 08:00 |
| Qiming | yes, read that code haed | 08:00 |
| Qiming | ahead | 08:00 |
| Qiming | what will happen? | 08:00 |
| Qiming | if will do a constructor right? | 08:01 |
| Yanyanhu | since the start_time property of action which loaded in step1 is None I think | 08:01 |
| Qiming | then the __init__ will create a new context? | 08:01 |
| Yanyanhu | let me see | 08:01 |
| Qiming | you need a whole picture when doing this kind of revision | 08:02 |
| Yanyanhu | hmm, that's true | 08:02 |
| Yanyanhu | I think we can't solve the problem unless finish the TODO in the comment | 08:02 |
| Qiming | it can be solved easily | 08:03 |
| Yanyanhu | why we need to do this conversion in line http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/actions/base.py#n101 | 08:03 |
| Qiming | the passed in context is a dict | 08:04 |
| Qiming | well the action.context must be a RequestContext instance | 08:04 |
| Yanyanhu | yes, but I mean if the passed in context is dict, why we need to do context.to_dict() | 08:05 |
| Yanyanhu | maybe we can just directly use it as input param for req_context.RequestContext.from_dict | 08:05 |
| Yanyanhu | oh, you mean the passed in param for req_context.RequestContext.from_dict is a dict? | 08:06 |
| Yanyanhu | hmm, this is a problem | 08:06 |
| Qiming | cannot recall the reason, that line looks stupid | 08:06 |
| Yanyanhu | em | 08:08 |
| Yanyanhu | so maybe we should revise the start_time assignment logic? | 08:08 |
| Yanyanhu | for example put it into action layer | 08:08 |
| Qiming | where is it assigned? | 08:13 |
| Yanyanhu | now, it's in action_acquire db api | 08:13 |
| Qiming | so after this line: http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/actions/base.py#n476 | 08:14 |
| Qiming | no, line 480, actually | 08:15 |
| Qiming | we have the action lock at hand | 08:15 |
| Qiming | the start_time is correctly set in db | 08:15 |
| Qiming | but not in the object in memory | 08:16 |
| Yanyanhu | yes | 08:16 |
| Qiming | we can just do a line "self.start_time = timestamp" at line 480, right? | 08:16 |
| Yanyanhu | right | 08:16 |
| Yanyanhu | this is the simplist solution | 08:16 |
| Yanyanhu | so we fix it using this way? | 08:18 |
| Qiming | yep | 08:22 |
| Yanyanhu | got it | 08:22 |
| Qiming | don't see other better way to solve it | 08:22 |
| Yanyanhu | ok, will propose a patch. The engine can't work now for this issue... | 08:22 |
| *** Qiming_ has joined #senlin | 08:32 | |
| *** Qiming has quit IRC | 08:32 | |
| Qiming_ | ok | 08:32 |
| *** Qiming_ is now known as Qiming | 08:32 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Tweak connection parameter building for profiles https://review.openstack.org/218765 | 08:41 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Add 'singleton' property to base policy https://review.openstack.org/218708 | 08:42 |
| *** elynn has joined #senlin | 08:46 | |
| *** elynn has quit IRC | 08:49 | |
| Yanyanhu | hi, Qiming, seems there are still problems about the context used in ActionProc | 08:49 |
| Yanyanhu | made a test and found the context that used to store action into DB is the same as the one in line 464 http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/actions/base.py#n464 | 08:50 |
| Qiming | why is that a problem? | 08:52 |
| Qiming | what do you mean by "context that used to store action into DB" ? | 08:52 |
| Yanyanhu | hmm, this is correct I think | 08:52 |
| Qiming | in which phase? | 08:52 |
| Yanyanhu | in service module I think | 08:52 |
| Qiming | lock acquire? | 08:52 |
| Qiming | ... | 08:52 |
| Yanyanhu | when I tried to override some attrs initialized in DB after line 480, e.g. start_time, I found the action can be started correctly | 08:53 |
| Yanyanhu | but it will never be marked completed | 08:53 |
| Yanyanhu | so I guess still some problems here | 08:54 |
| Yanyanhu | keep looking at it | 08:54 |
| Qiming | ok | 08:54 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Add timeout validation for server creation https://review.openstack.org/218774 | 09:08 |
| *** Tennyson has quit IRC | 09:12 | |
| *** mathspanda has quit IRC | 09:13 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Remove half-baked profile types https://review.openstack.org/218782 | 09:28 |
| Qiming | just heads up | 09:54 |
| Qiming | I'm fast approving this patch: https://review.openstack.org/#/c/218765/ | 09:54 |
| Qiming | the problem is that the current connection params building is wrong | 09:55 |
| Qiming | for example, stacks are created in different project | 09:55 |
| Qiming | still looking into the mess | 09:55 |
| openstackgerrit | Merged stackforge/senlin: Tweak connection parameter building for profiles https://review.openstack.org/218765 | 09:56 |
| Yanyanhu | ok | 09:58 |
| Yanyanhu | so does this part can work correctly now? | 09:58 |
| Yanyanhu | hi, Qiming, if you are still working on it, I will keep my local branch for the test | 10:00 |
| Yanyanhu | still didn't find the clue for the action status can not be set correctly issue... | 10:00 |
| Qiming | what do you mean "this part" ? | 10:01 |
| Yanyanhu | it's very weird. The log in engine shows the cluster_action's status is waiting. But when I query it using action-show, the status is ready | 10:01 |
| Yanyanhu | faint | 10:01 |
| Yanyanhu | I mean the profile | 10:01 |
| Yanyanhu | to create nova server and heat stack | 10:01 |
| Qiming | don't understand what you mean | 10:02 |
| Qiming | so you are doing some cluster_action | 10:03 |
| Qiming | what action is that? | 10:03 |
| Yanyanhu | I mean have you finished the tweaking completely or there are still some works coming for the sdk connection issue | 10:03 |
| Yanyanhu | create or delete currently | 10:03 |
| Qiming | connection param problem? | 10:04 |
| Qiming | still debugging | 10:04 |
| Yanyanhu | ok, understand | 10:04 |
| Qiming | it was wrong | 10:04 |
| Qiming | and it is still wrong | 10:04 |
| Qiming | do you know what I mean? | 10:04 |
| Qiming | $ OS_USERNAME=senlin OS_PROJECT_NAME=service heat stack-list | 10:04 |
| Qiming | +--------------------------------------+----------------+--------------------+---------------------+ | 10:04 |
| Qiming | | id | stack_name | stack_status | creation_time | | 10:04 |
| Qiming | +--------------------------------------+----------------+--------------------+---------------------+ | 10:04 |
| Qiming | | 1f4256b0-6a12-4aff-b3a3-0c182fdcd289 | node1-g4j6wGDR | DELETE_IN_PROGRESS | 2015-08-31T09:40:54 | | 10:04 |
| Qiming | | aa4450b6-2087-46a4-98b8-27983feb86f3 | node2-r9C5keaX | CREATE_FAILED | 2015-08-31T09:49:08 | | 10:04 |
| Qiming | | 58baad69-70df-40f8-9da6-ce037e8e3a48 | node1-ukmFGrAm | CREATE_COMPLETE | 2015-08-31T10:00:20 | | 10:04 |
| Qiming | +--------------------------------------+----------------+--------------------+---------------------+ | 10:04 |
| Yanyanhu | hmm, noticed this issue last week. But didn't ensure where it happened | 10:06 |
| Yanyanhu | I found use the requester's credential, I can't see the nova server or heat stack that senlin created | 10:07 |
| *** lawrance_ has quit IRC | 10:08 | |
| *** elynn_ has quit IRC | 10:08 | |
| Qiming | finally ... | 10:19 |
| Qiming | the stack is created in the intended project now | 10:19 |
| Yanyanhu | so this is because we gave incorrect project when create trust? | 10:20 |
| Qiming | no | 10:21 |
| Yanyanhu | umm, seems not | 10:21 |
| Qiming | it is the trust parameter send to SDK | 10:21 |
| Qiming | SDK can only recognize "trust_id" | 10:21 |
| Qiming | for whatever reason, we are providing "trusts" | 10:22 |
| Qiming | and that "trusts" is a list ... | 10:22 |
| Qiming | so basically, the trust mechanism all failed to achieve its goal | 10:22 |
| Yanyanhu | so we actually didn't provide the trust correctly...? | 10:22 |
| Qiming | yes | 10:23 |
| Yanyanhu | so that means we only provided senlin's credential to sdk... | 10:23 |
| Qiming | and we preserved project_name, project_domain_name, username, passwrod, all credential for the senlin service user | 10:23 |
| Yanyanhu | sigh | 10:24 |
| Qiming | that is the reason stacks are created into the service domain, because that is 'senlin's default project | 10:24 |
| Yanyanhu | ok | 10:24 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Fix trust-based connection building https://review.openstack.org/218796 | 10:25 |
| Qiming | the fix is pretty simple, ^ | 10:25 |
| Qiming | however, it is based on a previous patch | 10:25 |
| Qiming | now that this kind of annoying bugs solved, I'm moving on to revise profile YAML | 10:26 |
| Yanyanhu | ok | 10:26 |
| Yanyanhu | oh, Qiming, I remeber sometimes, sdk complained scope conflict if we provide both project_id and trusts | 10:27 |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Add timeout validation for server creation https://review.openstack.org/218774 | 10:29 |
| Qiming | right | 10:29 |
| Qiming | that is why we are not removing project_name from the params | 10:30 |
| Qiming | previously, it was there mainly because trusts didn't work | 10:30 |
| Yanyanhu | hi, sorry just back | 10:41 |
| Yanyanhu | ok, understand | 10:42 |
| Qiming | please help review this: https://review.openstack.org/218774 | 10:44 |
| Yanyanhu | sure | 10:44 |
| Qiming | then I can start the huge revision | 10:44 |
| Yanyanhu | hi, Qiming, about the timeout patch https://review.openstack.org/#/c/218774/2, do we need the same change for heat stack? | 11:07 |
| Qiming | I think so | 11:08 |
| Qiming | pls submit a patch there | 11:08 |
| Yanyanhu | ok | 11:08 |
| Qiming | 252 test failures, still 191 under way | 11:08 |
| Yanyanhu | ... | 11:09 |
| Qiming | hope this is a once for all change | 11:09 |
| Yanyanhu | ok, that will be the best | 11:10 |
| openstackgerrit | Merged stackforge/senlin: Fix trust-based connection building https://review.openstack.org/218796 | 11:11 |
| openstackgerrit | Merged stackforge/senlin: Add timeout validation for server creation https://review.openstack.org/218774 | 11:14 |
| Qiming | 181 now | 11:14 |
| Yanyanhu | :) | 11:15 |
| *** lawrancejing has joined #senlin | 11:42 | |
| Qiming | still 146 | 11:43 |
| Yanyanhu | ... | 11:43 |
| Qiming | profiles are not like policies | 11:44 |
| Qiming | they are used in almost all unit tests ... | 11:44 |
| Yanyanhu | yes | 11:44 |
| *** openstackgerrit has quit IRC | 11:46 | |
| Qiming | 123 ... | 11:47 |
| *** openstackgerrit has joined #senlin | 11:47 | |
| Yanyanhu | seems can be finished in another hour... | 11:47 |
| *** Yanyanhu has quit IRC | 11:55 | |
| *** Qiming has quit IRC | 12:09 | |
| *** huangtianhua has quit IRC | 12:30 | |
| *** elynn_ has joined #senlin | 13:07 | |
| *** Qiming has joined #senlin | 13:12 | |
| *** jdandrea has joined #senlin | 13:24 | |
| *** Qiming has quit IRC | 13:25 | |
| *** lkarm has joined #senlin | 14:10 | |
| *** lawrancejing has quit IRC | 14:21 | |
| *** huangtianhua has joined #senlin | 14:31 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Make profile schema versioned https://review.openstack.org/218888 | 14:48 |
| *** Qiming has joined #senlin | 14:48 | |
| *** jruano has joined #senlin | 15:02 | |
| *** Qiming has quit IRC | 15:25 | |
| *** lkarm has quit IRC | 21:24 | |
| *** lkarm has joined #senlin | 21:24 | |
| *** lkarm has quit IRC | 21:29 | |
| *** lkarm has joined #senlin | 21:53 | |
| *** lkarm has quit IRC | 21:57 | |
| *** jruano has quit IRC | 22:14 | |
| *** jruano has joined #senlin | 22:58 | |
| *** jruano has quit IRC | 23:29 | |
| *** Qiming has joined #senlin | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!