| *** Qiming has quit IRC | 00:07 | |
| openstackgerrit | Merged stackforge/senlin-dashboard: Updated from global requirements https://review.openstack.org/219118 | 00:07 |
|---|---|---|
| *** zhenguo has joined #senlin | 00:30 | |
| *** xuhaiwei has joined #senlin | 00:39 | |
| *** Qiming has joined #senlin | 01:06 | |
| *** lawrancejing has joined #senlin | 01:33 | |
| *** mathspanda has joined #senlin | 01:36 | |
| *** jdandrea has quit IRC | 01:55 | |
| *** Yanyanhu has joined #senlin | 01:55 | |
| branw | the new version senlin，senlin create-profile with nova_server.spec，the spec add some item that must specify. such as type,version,properties..., i don't know type, version, properties should be, and the spec item "name" can not recognizable | 01:58 |
| Qiming | yes, branw | 01:58 |
| branw | anyone give me a new spec file example | 01:59 |
| Qiming | did you check the senlin/examples/profiles dir? | 01:59 |
| branw | yes | 01:59 |
| branw | i am in the dir | 01:59 |
| branw | if the spec item type specify profile-type like os.nova.server, then senlin create profile shoud remove -t | 02:02 |
| Qiming | branw, the client side change is there for approval | 02:03 |
| openstackgerrit | Merged stackforge/python-senlinclient: Revise support to profile-create/show https://review.openstack.org/219110 | 02:03 |
| Qiming | it was checked in yesterday, and just approved today, ^ | 02:03 |
| *** LiuWei has joined #senlin | 02:05 | |
| branw | o | 02:05 |
| openstackgerrit | Merged stackforge/senlin: Updated from global requirements https://review.openstack.org/219507 | 02:08 |
| Yanyanhu | hi, Qiming, about that bug caused by incorrect context usage in Action, I will try to propose a patch to differentiate the assignment of context inpurt params for those two different cases first. | 02:12 |
| Yanyanhu | like we discussed yesterday | 02:12 |
| Yanyanhu | but I found a problem that the target param is now the ID of target object | 02:13 |
| Yanyanhu | so should we change it to target object? | 02:13 |
| *** Yanyanhu has quit IRC | 02:16 | |
| *** Yanyanhu has joined #senlin | 02:17 | |
| Yanyanhu | just dropped | 02:19 |
| Qiming | pass an object reference over RPC? | 02:23 |
| Yanyanhu | no, just pass an object when create Action instance in engine service module | 02:24 |
| Yanyanhu | http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/service.py#n507 | 02:25 |
| Yanyanhu | like this | 02:25 |
| Yanyanhu | pass cluster rather than cluster.id when creating ClusterAction instance | 02:26 |
| *** elynn has joined #senlin | 02:26 | |
| Qiming | that's fine | 02:26 |
| Yanyanhu | ok | 02:26 |
| *** weli__ has joined #senlin | 02:31 | |
| *** LiuWei has quit IRC | 02:31 | |
| openstackgerrit | Merged stackforge/senlin: Sample profiles with type and version keys https://review.openstack.org/219092 | 02:36 |
| *** lkarm has joined #senlin | 02:58 | |
| *** lkarm has quit IRC | 03:02 | |
| *** weli__ has quit IRC | 03:02 | |
| *** LiuWei has joined #senlin | 03:02 | |
| LiuWei | hi,when I execute cluster create action,cluster create failed ,log prints that start_time in action is null. | 03:31 |
| LiuWei | here is my log errors:http://paste.openstack.org/show/439661/ | 03:31 |
| *** weli__ has joined #senlin | 03:31 | |
| *** weli__ has quit IRC | 03:34 | |
| *** LiuWei has quit IRC | 03:36 | |
| *** LiuWei has joined #senlin | 03:38 | |
| LiuWei | compute just reboot | 03:39 |
| LiuWei | can someone give me some tips? | 03:39 |
| elynn | This might be a bug... | 05:10 |
| LiuWei | Is that you also meet this question? | 05:12 |
| Yanyanhu | hi, LiuWei, this is a bug | 05:22 |
| Yanyanhu | we are now trying to fix it | 05:22 |
| LiuWei | en,thanks! | 05:23 |
| Yanyanhu | but since it is related to the refactoring of context usage in Action progress, it will take for a while to resolve this problem | 05:23 |
| Yanyanhu | no problem :) | 05:23 |
| *** lkarm has joined #senlin | 05:40 | |
| *** lkarm has quit IRC | 05:45 | |
| *** mathspanda has quit IRC | 06:01 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Unit test case for keystone v3 driver https://review.openstack.org/219569 | 06:10 |
| *** Qiming_ has joined #senlin | 06:12 | |
| Qiming_ | Test message from phone | 06:14 |
| Qiming_ | It works | 06:15 |
| Yanyanhu | hi, Qiming_, about refactoring context usage in action object, I found we have no place to store the 'is_admin' value if no context is passed to Action.__init__... | 06:20 |
| Yanyanhu | unless we use target to pass it | 06:20 |
| Yanyanhu | this is not a correct way | 06:22 |
| Qiming | let me try propose a fix soon | 06:26 |
| Yanyanhu | ok | 06:26 |
| Qiming | pls check in your current fix regarding the new code in __init__ | 06:26 |
| Yanyanhu | you mean propose the patch I'm working on about contex? | 06:27 |
| Qiming | I'm wondering if there have been already a lot of code on it | 06:32 |
| Yanyanhu | so maybe I should hold my patch since it still doesn't work | 06:33 |
| Qiming | ok | 06:33 |
| Yanyanhu | just don't want to make thing worse :) | 06:35 |
| openstackgerrit | Merged stackforge/senlin: Add 'singleton' property to base policy https://review.openstack.org/218708 | 07:11 |
| Qiming | it is gonna be a huge revision again | 07:12 |
| Yanyanhu | yes | 07:13 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Add functional test for cluster scale in/out https://review.openstack.org/218142 | 07:14 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Revise policy_type functional test https://review.openstack.org/218707 | 07:14 |
| openstackgerrit | Merged stackforge/senlin: Fix functional test for policy type listing https://review.openstack.org/219159 | 07:14 |
| openstackgerrit | Merged stackforge/senlin: Revise policy_type functional test https://review.openstack.org/218707 | 07:28 |
| *** lawrancejing has quit IRC | 07:46 | |
| *** lkarm has joined #senlin | 07:52 | |
| *** lkarm has quit IRC | 07:56 | |
| Qiming | Yanyanhu, I am afraid the bug of concurrency is actually caused by the list data type | 08:04 |
| Yanyanhu | you mean the list data type provided by python? | 08:05 |
| Qiming | senlin/db/sqlalchemy/types.py | 08:06 |
| Qiming | this one | 08:06 |
| Yanyanhu | oh | 08:06 |
| Yanyanhu | how it happened | 08:07 |
| Qiming | it is a layer between what a threads sees from in-memory data and the db data | 08:07 |
| Yanyanhu | ok, so just like a cache? | 08:07 |
| Qiming | I heard complaints from heat team on this, it was copied to Heat and later deleted due to some data problems and it was not that useful in Heat anyway | 08:08 |
| Yanyanhu | ok | 08:09 |
| Yanyanhu | but we use it for storing dependents | 08:09 |
| Qiming | yes | 08:11 |
| Yanyanhu | em, can we control the construction and destruction of these List objects? | 08:14 |
| Qiming | not sure | 08:15 |
| Qiming | still digging | 08:16 |
| Yanyanhu | ok | 08:16 |
| Yanyanhu | I was writing functional test for cluster resize and I think I found a bug which breaks the size contraints of cluster | 08:17 |
| Yanyanhu | will fix it | 08:17 |
| Qiming | ok | 08:17 |
| Qiming | be careful though | 08:17 |
| Qiming | that part is getting complicated too | 08:17 |
| Yanyanhu | got it | 08:17 |
| Yanyanhu | ah, my mistake, the default value of strict param is False, not True | 08:33 |
| Qiming | it is really weird | 08:50 |
| Qiming | I even tried overriding the context of the derived actions | 08:50 |
| Yanyanhu | you mean actually the two actions in cluster_action and node_action are the same? | 08:51 |
| Yanyanhu | in the test | 08:51 |
| Qiming | trying to mock that | 08:52 |
| Qiming | actions are dispatched through RPC | 08:54 |
| Qiming | the dispatcher/scheduler is creating new context instance? | 08:54 |
| Qiming | the context is not passed over | 08:54 |
| openstackgerrit | Yanyan Hu proposed stackforge/senlin: Fix a bug in _wait_for_dependents method of ClusterAction https://review.openstack.org/219608 | 08:54 |
| Yanyanhu | let me check the code | 08:54 |
| Yanyanhu | I guess the dispatcher/scheduler won't create a new context | 08:55 |
| Yanyanhu | it just used the one in service module I think | 08:56 |
| Yanyanhu | the context created in engine should be passed to start_action method of Dispatcher class | 08:57 |
| Qiming | no | 09:03 |
| Qiming | that is a misunderstanding | 09:03 |
| Qiming | under current framework, there is no way to pass the context or DB session from "parent" action to "child" action | 09:05 |
| Qiming | the reason: | 09:05 |
| Qiming | this line is still using the "parent" action's context: http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/dispatcher.py#n102 | 09:06 |
| Qiming | but when the Dispatcher (subclass of service.Service) receives this request: http://git.openstack.org/cgit/stackforge/senlin/tree/senlin/engine/dispatcher.py#n54 | 09:06 |
| Qiming | a new context is created by the service.Service framework | 09:07 |
| Qiming | they are not the samething | 09:07 |
| Yanyanhu | oh, so oslo_service.Service adds context decorator for all memeber methods? | 09:08 |
| Yanyanhu | since we didn't add it explicitly | 09:08 |
| Qiming | some kind of that | 09:09 |
| Yanyanhu | Qiming, but I found oslo_service.server.Services class isn't decorated | 09:10 |
| Qiming | ... | 09:10 |
| Yanyanhu | so weird | 09:10 |
| Qiming | the context parameter | 09:11 |
| Qiming | I didn't say it comes from decorator | 09:11 |
| Yanyanhu | so you mean the context object is reconstructed when it was passed through the rpc | 09:13 |
| Yanyanhu | the one sent in rpcclient side is not the same one that received in server side | 09:13 |
| Yanyanhu | hmm, I also doubted that transmitting an 'object' through rpc might be incorrect | 09:15 |
| Yanyanhu | no matter whether olso messaging handle the construction and destruction correctly, the object in client side and the one in server side should not be the same one | 09:16 |
| *** elynn has quit IRC | 09:22 | |
| *** Yanyanhu has quit IRC | 09:23 | |
| *** LiuWei has quit IRC | 09:43 | |
| *** branw has quit IRC | 10:41 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Fix cluster status refresh error https://review.openstack.org/219635 | 10:49 |
| *** Qiming has quit IRC | 10:54 | |
| *** Qiming_ is now known as Qiming | 10:54 | |
| *** Qiming_ has joined #senlin | 11:49 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Fix cluster status refresh error https://review.openstack.org/219635 | 11:56 |
| *** lkarm has joined #senlin | 12:27 | |
| openstackgerrit | Merged stackforge/senlin: Fix a bug in _wait_for_dependents method of ClusterAction https://review.openstack.org/219608 | 12:42 |
| *** jdandrea has joined #senlin | 13:13 | |
| *** zhenguo has quit IRC | 14:24 | |
| openstackgerrit | Qiming Teng proposed stackforge/senlin: Delete dead code in sdk module https://review.openstack.org/219711 | 14:28 |
| openstackgerrit | Merged stackforge/senlin: Fix cluster status refresh error https://review.openstack.org/219635 | 14:33 |
| openstackgerrit | Merged stackforge/senlin: Remove half-baked profile types https://review.openstack.org/218782 | 15:10 |
| openstackgerrit | Merged stackforge/senlin: Revise doc to reflect latest changes https://review.openstack.org/219147 | 15:10 |
| openstackgerrit | Merged stackforge/senlin: Unit test case for keystone v3 driver https://review.openstack.org/219569 | 15:10 |
| *** Qiming_ has quit IRC | 15:13 | |
| openstackgerrit | Merged stackforge/senlin: Delete dead code in sdk module https://review.openstack.org/219711 | 15:13 |
| *** lkarm has quit IRC | 16:41 | |
| *** lkarm has joined #senlin | 16:42 | |
| *** lkarm has quit IRC | 16:44 | |
| *** lkarm has joined #senlin | 16:44 | |
| *** lkarm has quit IRC | 17:00 | |
| *** lkarm has joined #senlin | 17:37 | |
| *** lkarm has quit IRC | 17:55 | |
| *** lkarm has joined #senlin | 18:06 | |
| *** lkarm has quit IRC | 18:34 | |
| *** lkarm has joined #senlin | 18:35 | |
| *** lkarm has quit IRC | 20:29 | |
| *** lkarm has joined #senlin | 20:40 | |
| *** lkarm has quit IRC | 21:25 | |
| *** Qiming_ has joined #senlin | 23:26 | |
| *** elynn has joined #senlin | 23:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!