*** pratikma_ has quit IRC | 00:06 | |
*** lkarm has joined #senlin | 01:03 | |
*** zhenguo has joined #senlin | 01:09 | |
*** lvdongbing has joined #senlin | 01:20 | |
*** Liuqing has joined #senlin | 01:35 | |
*** Qiming has joined #senlin | 01:36 | |
*** Yanyanhu has joined #senlin | 01:36 | |
*** elynn has joined #senlin | 01:52 | |
elynn | morning | 01:55 |
---|---|---|
openstackgerrit | lvdongbing proposed openstack/senlin: Put py34 first in the env order of tox https://review.openstack.org/241070 | 02:09 |
Yanyanhu | morning | 02:13 |
lvdongbing | morning | 02:16 |
*** lkarm_ has joined #senlin | 02:20 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Revised client interface https://review.openstack.org/240805 | 02:22 |
*** lkarm has quit IRC | 02:22 | |
Qiming | hi, guys, patch 240805 is a more complete revision to the client interface | 02:23 |
Qiming | please help test each and every of them | 02:23 |
Qiming | I'm trapped by something else at the moment, will get back to your review comments later this week | 02:23 |
Qiming | thanks | 02:24 |
Yanyanhu | got it | 02:24 |
elynn | Looking at it | 02:27 |
Qiming | the primary problem I have is about the passing of dicts, currently, we have a mix of passing dict as a whole and passing them as keyword arguments | 02:29 |
Yanyanhu | yes, that's true | 02:31 |
Yanyanhu | maybe we can unify the usage and pass dict as kwargs for all cases? | 02:32 |
Yanyanhu | AFK for a while, back soon | 02:33 |
Qiming | at interface layer, this patch is trying to propose a unified scheme, which is using keyword arguments | 02:33 |
Qiming | under that layer, we still some times pass dict as a whole, I think that can be another patch though | 02:33 |
*** lkarm_ has quit IRC | 02:37 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Revised client interface https://review.openstack.org/240805 | 02:39 |
Qiming | sorry about the pep8 errors | 02:39 |
Yanyanhu | just back | 02:44 |
Yanyanhu | Yes, that can be resolved in another patch | 02:45 |
Qiming | actually there are other methods we can remove from client.py | 03:00 |
openstackgerrit | lvdongbing proposed openstack/senlin: API resource names should not include underscores https://review.openstack.org/240740 | 03:27 |
*** Qiming has quit IRC | 03:36 | |
*** gongysh has joined #senlin | 04:33 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/241096 | 04:35 |
*** lkarm has joined #senlin | 04:48 | |
*** lkarm has quit IRC | 04:53 | |
*** Liuqing has quit IRC | 05:03 | |
*** Liuqing has joined #senlin | 05:04 | |
*** Qiming has joined #senlin | 05:56 | |
Yanyanhu | hi, Qiming, I'm thinking whether 'cluster-node-add' cmd is functional duplicated with 'node-join' cmd? | 06:13 |
Yanyanhu | and also the 'cluster-node-del' and 'node-leave' | 06:13 |
Qiming | funtionally, it is an overlap | 06:14 |
Qiming | yes, it is for convenience | 06:14 |
Yanyanhu | ok | 06:14 |
*** Liuqing has quit IRC | 06:35 | |
*** Liuqing has joined #senlin | 06:35 | |
*** gongysh has quit IRC | 07:18 | |
*** gongysh has joined #senlin | 07:19 | |
*** lkarm has joined #senlin | 07:38 | |
*** lkarm has quit IRC | 07:42 | |
*** Liuqing has quit IRC | 07:47 | |
*** Liuqing has joined #senlin | 07:48 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Adapt resource path to server revision https://review.openstack.org/241128 | 08:03 |
Qiming | looks like patch 240740 is ready, thanks, lvdongbing | 08:06 |
*** Liuqing has quit IRC | 08:08 | |
*** Liuqing has joined #senlin | 08:09 | |
lvdongbing | Thanks, Qiming :) | 08:15 |
Qiming | Yanyanhu, you have helped tested all the calls? | 08:18 |
Yanyanhu | yes, almost all of them. And still have a issue that I'm not very sure about the reason happened when creating webhook with count parameter | 08:19 |
Qiming | !!! | 08:19 |
openstack | Qiming: Error: "!!" is not a valid command. | 08:19 |
Qiming | so nice of you | 08:19 |
Yanyanhu | no problem :) this is an urgent requirement | 08:20 |
Yanyanhu | BTW, if we specify the parameter using '-P count=1' when creating a webhook, the count value 1 will be parsed as an unicode string '1' rather than integer 1 which will finally cause error when calculating count value in cluster_scale_in/out action | 08:21 |
Yanyanhu | will try to fix this | 08:21 |
Qiming | data type conversion problem? | 08:29 |
Yanyanhu | yes, I think we forget to make data type conversion in scaling policy. | 08:30 |
Yanyanhu | this conversion is done correctly in service module and thus prevent this error happening in cluster action progress | 08:31 |
Yanyanhu | so I guess we need to add the same conversion in pre_op of scaling policy | 08:32 |
Qiming | okay | 08:32 |
Qiming | speaking of the default value for 'count', in the context of scale_in and scale_out | 08:33 |
Qiming | I think it is okay to have a default value of 1 | 08:33 |
Qiming | the default value is consistent with server side logic | 08:34 |
Qiming | the default value will make some of the logic at server side not that useful, but no inconsistency | 08:34 |
Qiming | the default value is only impacting command line interface, not from other services that talk to senlinclient | 08:35 |
Qiming | the reason I added the 'default=1' for both operations is that I saw inconsistency in existing shell logic (before the current patch) | 08:36 |
Yanyanhu | yes, I agree with this change. Currently, the default value=1 is implemented in engine side. | 08:37 |
Yanyanhu | Just because the 'count' value provided in action input will always override the count result calculated by scaling policy, the scaling policy actually doesn't get chance to take effect if 'count' input is provided for cluster_scale_in/out action. | 08:37 |
Yanyanhu | like this: http://git.openstack.org/cgit/openstack/senlin/tree/senlin/policies/scaling_policy.py#n144 | 08:37 |
*** Liuqing has quit IRC | 08:38 | |
Qiming | okay, that makes sense | 08:38 |
Qiming | so I'm leaving them as unset and see what happens? | 08:38 |
Yanyanhu | ok | 08:39 |
*** Liuqing has joined #senlin | 08:39 | |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Revised client interface https://review.openstack.org/240805 | 08:42 |
Yanyanhu | hi, Qiming, the new patchset works well | 08:50 |
Qiming | good to know! | 08:50 |
Yanyanhu | hi, Qiming, just made a test and didn't reproduce the error Avi mentioned. | 09:13 |
lvdongbing | Hi, Qiming, I proposed a patch before: Update node status when fail to create nova instance https://review.openstack.org/#/c/238753 , it failed in py34 test. I found it might be a bug of python3.4: http://bugs.python.org/issue23003 | 09:14 |
Qiming | lvdongbing, yes, it is only solved in py3.5 | 09:17 |
Qiming | so the current workaround, sadly, is to avoid dumping stack trace outside of a exception context | 09:17 |
Qiming | Yanyanhu, thanks. Will check with Avi | 09:17 |
lvdongbing | OK, I'll fix it | 09:19 |
openstackgerrit | Merged openstack/senlin: API resource names should not include underscores https://review.openstack.org/240740 | 09:21 |
*** jdandrea has quit IRC | 09:22 | |
Qiming | https://review.openstack.org/209743 | 09:25 |
Qiming | profile resource merged into sdk | 09:25 |
Yanyanhu | nice! much helpful for elynn's work :) | 09:28 |
elynn | cool, thanks a lot. | 09:28 |
elynn | Seems stackalytics didn't cover senlin ? | 09:30 |
Qiming | it is there | 09:31 |
Qiming | but it is ... openstack-others | 09:31 |
Qiming | all non-official projects fall into that category | 09:31 |
Qiming | elynn, http://stackalytics.com/?project_type=openstack-others&module=senlin | 09:35 |
elynn | Oh, I see that. | 09:35 |
elynn | Hope we can change project type to openstack after tonight :D | 09:37 |
openstackgerrit | lvdongbing proposed openstack/senlin: Update node status when fail to create nova instance https://review.openstack.org/238753 | 09:38 |
*** lvdongbing has quit IRC | 09:40 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Convert count value into integer in scaling policy https://review.openstack.org/241145 | 09:44 |
Qiming | https://review.openstack.org/225560 stack update patch merged in sdk | 09:47 |
Yanyanhu | o/ | 09:48 |
*** Liuqing has quit IRC | 09:55 | |
*** Yanyanhu has quit IRC | 09:55 | |
*** Qiming has quit IRC | 09:56 | |
*** zhenguo has quit IRC | 10:03 | |
*** lkarm has joined #senlin | 10:09 | |
*** lkarm has quit IRC | 10:14 | |
*** elynn has quit IRC | 10:17 | |
*** Liuqing has joined #senlin | 10:31 | |
*** Qiming has joined #senlin | 10:54 | |
*** gongysh has quit IRC | 10:55 | |
*** gongysh has joined #senlin | 10:57 | |
*** Liuqing has quit IRC | 11:17 | |
*** Liuqing has joined #senlin | 11:19 | |
*** lixinhui has joined #senlin | 11:50 | |
*** lkarm has joined #senlin | 12:26 | |
*** lkarm has quit IRC | 12:30 | |
*** elynn has joined #senlin | 12:50 | |
*** haiwei_ has joined #senlin | 12:52 | |
*** yanyanhu has joined #senlin | 12:55 | |
openstackgerrit | Merged openstack/senlin: Move policy detach from action to cluster https://review.openstack.org/240685 | 13:01 |
yanyanhu | hi, Qiming, I found ttx in the etherpad of senlin's meetup | 13:19 |
Qiming | ok | 13:20 |
*** pratikmallya has joined #senlin | 13:25 | |
haiwei_ | yanyanhu, maybe ttx is reviewing senlin joining the big tent patch | 13:28 |
yanyanhu | I guess so :) | 13:30 |
openstackgerrit | Merged openstack/senlin: Convert count value into integer in scaling policy https://review.openstack.org/241145 | 13:37 |
openstackgerrit | Merged openstack/senlin: Put py34 first in the env order of tox https://review.openstack.org/241070 | 13:40 |
Qiming | yanyanhu, haiwei_ still on? | 14:00 |
yanyanhu | yes | 14:00 |
Qiming | for the mitaka workitems page | 14:00 |
haiwei_ | Qiming, I have some additional jobs for the summit recently, after that, I will start client test | 14:00 |
*** jruano has joined #senlin | 14:00 | |
Qiming | I'll start tune it | 14:01 |
Qiming | there are things we cannot finish in a month | 14:01 |
Qiming | I'm moving them into a backlog section | 14:01 |
yanyanhu | ok | 14:01 |
haiwei_ | ok | 14:01 |
Qiming | yanyanhu, please help consolidate them into the rst files later | 14:01 |
yanyanhu | sure | 14:02 |
Qiming | need to sleep a little earlier today | 14:02 |
Qiming | 4am morning call | 14:02 |
haiwei_ | anything else? | 14:02 |
haiwei_ | ok, me too | 14:02 |
yanyanhu | em... | 14:02 |
Qiming | nothing now | 14:03 |
yanyanhu | in the meeting channel? | 14:03 |
haiwei_ | though I had a holiday today | 14:03 |
Qiming | yes | 14:03 |
yanyanhu | the tc discussion | 14:03 |
jruano | are we meeting this morning? | 14:03 |
yanyanhu | ok, will check the irc | 14:03 |
Qiming | yes jruano | 14:03 |
Qiming | just finished | 14:03 |
haiwei_ | see you tomorrow guys | 14:03 |
*** lixinhui has quit IRC | 14:03 | |
jruano | oh | 14:03 |
Qiming | bye haiwei_ | 14:03 |
jruano | my apologies | 14:04 |
Qiming | no worry, jruano | 14:04 |
Qiming | how was your trip back? still suffering from jet lag? | 14:04 |
jruano | ah, i got messed up with the time change for us | 14:04 |
jruano | on sunday | 14:04 |
jruano | my fault | 14:04 |
jruano | im great today. yesterday and sunday were bad | 14:04 |
Qiming | next week, I'll be tortured :) | 14:05 |
jruano | we observe daylight savings and move the clock back an hour on sunday | 14:05 |
Qiming | 11.8 -> San Francisco, 11.12 -> Austin, 11.15 -> New York, 11.18 -> Beijing | 14:05 |
jruano | wow | 14:06 |
jruano | what is happening in austin? | 14:06 |
Qiming | China tried daylight savings a few decades ago, it didn't work | 14:06 |
jruano | lol | 14:06 |
*** lkarm has joined #senlin | 14:06 | |
Qiming | I was a child, cannot remember the reason, :) | 14:06 |
Qiming | I'm meeting Sandy and trying to figure out how to get close to product/service team | 14:07 |
*** haiwei_ has quit IRC | 14:07 | |
jruano | cool, well ping me when you get in. we can do lunch or something | 14:08 |
Qiming | surely I will | 14:08 |
jruano | let me know if you need any help as well | 14:08 |
jruano | ill be around | 14:08 |
Qiming | thanks | 14:09 |
*** elynn has quit IRC | 14:10 | |
*** yanyanhu has quit IRC | 14:12 | |
*** gongysh has quit IRC | 14:12 | |
*** gongysh has joined #senlin | 14:13 | |
*** jruano has quit IRC | 14:21 | |
*** elynn has joined #senlin | 14:32 | |
*** Qiming has quit IRC | 14:32 | |
*** elynn has quit IRC | 14:37 | |
*** Liuqing has quit IRC | 15:24 | |
*** jdandrea has joined #senlin | 15:29 | |
*** pratikmallya has quit IRC | 16:02 | |
*** gongysh has quit IRC | 16:06 | |
*** gongysh has joined #senlin | 16:07 | |
*** jruano has joined #senlin | 16:24 | |
*** pratikmallya has joined #senlin | 16:24 | |
*** pratikmallya has quit IRC | 16:30 | |
*** pratikmallya has joined #senlin | 16:30 | |
*** pratikma_ has joined #senlin | 16:34 | |
*** jruano has quit IRC | 16:35 | |
*** pratikmallya has quit IRC | 16:37 | |
*** pratikma_ is now known as pratikmallya | 16:40 | |
*** pratikmallya has quit IRC | 17:26 | |
*** pratikmallya has joined #senlin | 17:29 | |
*** lkarm has quit IRC | 18:02 | |
*** lkarm has joined #senlin | 18:03 | |
*** lkarm has quit IRC | 18:07 | |
*** lkarm has joined #senlin | 18:17 | |
*** rebase has joined #senlin | 18:49 | |
*** jruano has joined #senlin | 19:15 | |
*** Qiming has joined #senlin | 19:33 | |
*** pratikmallya has quit IRC | 19:46 | |
*** pratikmallya has joined #senlin | 20:15 | |
*** rebase has quit IRC | 20:50 | |
*** Qiming has quit IRC | 21:07 | |
*** jruano has quit IRC | 21:12 | |
*** pratikmallya has quit IRC | 21:38 | |
*** pratikmallya has joined #senlin | 22:15 | |
*** pratikma_ has joined #senlin | 22:18 | |
*** pratikmallya has quit IRC | 22:21 | |
*** lkarm has quit IRC | 22:23 | |
*** lkarm has joined #senlin | 22:24 | |
*** lkarm has quit IRC | 22:28 | |
*** yuanying has quit IRC | 23:16 | |
*** yuanying has joined #senlin | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!