| *** pm90_ has joined #senlin | 00:00 | |
| *** shu has joined #senlin | 00:01 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Fix SDK exception message parse https://review.openstack.org/243959 | 00:14 |
|---|---|---|
| *** lvdongbing has joined #senlin | 00:35 | |
| *** pm90_ has quit IRC | 00:59 | |
| *** zhenguo has joined #senlin | 01:18 | |
| *** Yanyanhu has joined #senlin | 01:29 | |
| *** gongysh_ has joined #senlin | 01:52 | |
| *** elynn has joined #senlin | 02:10 | |
| elynn | morning | 02:13 |
| Yanyanhu | morning | 02:14 |
| *** Yanyan has joined #senlin | 02:20 | |
| *** Yanyanhu has quit IRC | 02:22 | |
| *** openstackgerrit has quit IRC | 02:22 | |
| *** openstackgerrit has joined #senlin | 02:24 | |
| xuhaiwei | morning | 02:25 |
| *** jdandrea has quit IRC | 02:36 | |
| elynn | Hi xuhaiwei | 02:37 |
| xuhaiwei | yes | 02:37 |
| elynn | I reply your comment at https://review.openstack.org/#/c/244452/ | 02:38 |
| xuhaiwei | will check it, thanks | 02:39 |
| *** jdandrea has joined #senlin | 02:41 | |
| xuhaiwei | lvdongbing, are you around? | 03:02 |
| elynn | Hi Yanyan xuhaiwei , saw your comments. So you mean there's no need to add this function? | 03:12 |
| xuhaiwei | I think so, elynn, in senlinclient, we have give min_size and max_size the default value, so nothing wrong happens when you are using senlinclient | 03:13 |
| elynn | I have some concern that besides min_size and max_size, there are other value might have this problems too. | 03:14 |
| elynn | Since if use heat resources, we will directly call rest API | 03:14 |
| xuhaiwei | like your test, if you test the API directly, the bug happens, so in the API side, we just need to complete client side's job( add default value) | 03:14 |
| xuhaiwei | I know that, we can't fix this kind of bugs at one time | 03:15 |
| xuhaiwei | that's why Nova is doing the API validation | 03:15 |
| xuhaiwei | maybe one day we can do the same work in Senlin | 03:15 |
| Yanyan | elynn, sorry, just back | 03:15 |
| xuhaiwei | We should check all the API entrance parameters | 03:16 |
| xuhaiwei | Yanyan, can you review this patch ? https://review.openstack.org/#/c/238753/1 | 03:17 |
| Yanyan | xuhaiwei, sure | 03:17 |
| xuhaiwei | it's a bug brought by you :) | 03:17 |
| Yanyan | xuhaiwei, ok :) | 03:17 |
| Yanyan | hi, elynn, I think maybe we can check all those parameters to find similar problem. If it is common, I think it's worthy to define such a function | 03:17 |
| xuhaiwei | qiming and julio have misunderstood lvdongbing's intension I think | 03:17 |
| xuhaiwei | I will go for lunch, talk to you later | 03:18 |
| Yanyan | ttyl | 03:18 |
| elynn | xuhaiwei, yes, we should take care of all parameters, so that's why I add this function. | 03:18 |
| xuhaiwei | elynn, I think your fix is an option, but from the code's view, it will make the code unreadable and a little dirty, honestly :) | 03:19 |
| elynn | ok, if you insist, I will fix min_size and max_size for now, and if we found any bugs that happens, we can add a more common function. | 03:21 |
| *** yuanying has quit IRC | 03:21 | |
| Yanyan | elynn, agree with this. If it's become a common question(I guess it will be), we define a function for it. | 03:22 |
| elynn | IMO, adding a common function to handle kwargs can make codes more readable, maybe we should choose a better name for it ;) | 03:22 |
| Yanyan | bingo | 03:23 |
| Yanyan | 'extract_kwargs' really can't reflect the 'None value is allowable(or not)' logic clearly :) | 03:24 |
| *** yuanying has joined #senlin | 03:25 | |
| *** yuanying has quit IRC | 03:29 | |
| elynn | kwargs.get('ATTR_NAME', None) is the same as extract_kwargs(kwargs, 'ATTR_NAME', None) , maybe need more discussion if adding such a function. | 03:30 |
| elynn | About metadata value, can we accept it as None? | 03:31 |
| Yanyan | elynn, let me check it | 03:37 |
| *** yuanying has joined #senlin | 03:38 | |
| Yanyan | hi, elynn, I think if kwargs.get('ATTR_NAME', None) is the same as extract_kwargs(kwargs, 'ATTR_NAME', None), we should use the former one since it is built-in support of python language:) | 03:38 |
| Yanyan | yes, metadata can be none | 03:39 |
| Yanyan | oh, sorry, can be empty dict | 03:40 |
| Yanyan | lunch time, ttyl | 03:41 |
| elynn | ttyl, will submit a patch to just fix min_size and max_size problem ;) | 03:42 |
| *** jdandrea has quit IRC | 03:49 | |
| *** yuanying_ has joined #senlin | 03:52 | |
| *** yuanying has quit IRC | 03:55 | |
| *** yuanying_ has quit IRC | 04:05 | |
| *** yuanying has joined #senlin | 04:08 | |
| *** lvdongbing has quit IRC | 07:08 | |
| openstackgerrit | Ethan Lynn proposed openstack/senlin: Correct set the default value for min_size/max_size https://review.openstack.org/245011 | 07:08 |
| *** lvdongbing has joined #senlin | 07:08 | |
| *** elynn has quit IRC | 07:45 | |
| *** shu has quit IRC | 08:52 | |
| *** openstackgerrit has quit IRC | 09:01 | |
| *** openstackgerrit has joined #senlin | 09:02 | |
| *** Yanyan has quit IRC | 09:26 | |
| *** openstackgerrit has quit IRC | 10:16 | |
| *** openstackgerrit has joined #senlin | 10:16 | |
| *** lvdongbing has quit IRC | 12:22 | |
| *** gongysh_ has quit IRC | 12:23 | |
| *** pm90_ has joined #senlin | 13:56 | |
| *** openstackgerrit has quit IRC | 14:01 | |
| *** openstackgerrit has joined #senlin | 14:02 | |
| *** lkarm has joined #senlin | 14:04 | |
| *** jdandrea has joined #senlin | 14:47 | |
| *** lkarm has quit IRC | 15:51 | |
| *** lkarm has joined #senlin | 16:01 | |
| *** pm90_ has quit IRC | 16:15 | |
| *** pm90__ has joined #senlin | 16:15 | |
| *** pm90__ has quit IRC | 17:17 | |
| *** pm90_ has joined #senlin | 17:45 | |
| *** lkarm has quit IRC | 17:53 | |
| *** Qiming has joined #senlin | 18:00 | |
| *** Qiming has quit IRC | 18:34 | |
| *** lkarm has joined #senlin | 18:50 | |
| *** lkarm has quit IRC | 18:54 | |
| *** lkarm has joined #senlin | 18:55 | |
| *** pm90_ has quit IRC | 19:53 | |
| *** pm90_ has joined #senlin | 20:11 | |
| *** Qiming has joined #senlin | 20:28 | |
| *** Qiming has quit IRC | 21:00 | |
| *** lkarm has quit IRC | 21:27 | |
| *** pm90_ has quit IRC | 21:50 | |
| *** pm90_ has joined #senlin | 23:00 | |
| *** gongysh has quit IRC | 23:51 | |
| *** gongysh has joined #senlin | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!