openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin: Updated from global requirements https://review.openstack.org/246105 | 00:23 |
---|---|---|
openstackgerrit | Qiming Teng proposed openstack/senlin: Disallow profile update for spec https://review.openstack.org/246694 | 00:45 |
*** pratikmallya has quit IRC | 00:48 | |
*** lvdongbing has joined #senlin | 01:17 | |
Qiming | lvdongbing, there? | 01:27 |
lvdongbing | yes | 01:29 |
lvdongbing | morning | 01:29 |
lvdongbing | Qiming, morning | 01:31 |
Qiming | hi, lvdongbing, about the patch https://review.openstack.org/#/c/238753/ | 01:32 |
Qiming | please check my comment and see if it works for you | 01:32 |
Qiming | not sure if you are aware of the huge effort we put on managing exceptions | 01:33 |
Qiming | regarding the bug report you are working on, an easier solution would be checking the return value directly in the node.py module | 01:34 |
Qiming | exceptions are already handled in a lower level of abstraction, there doesn't seem a need to propagate it up and handle it again | 01:34 |
Qiming | or, in other words, trying to catch an exception in the node.py module was a mistake | 01:35 |
Qiming | please think about it and see it it makes sense to you | 01:35 |
lvdongbing | That will make the _handle_exception useless | 01:36 |
Qiming | yes, if it is useless, kill it | 01:36 |
Qiming | checking return value is much easier, right? | 01:37 |
lvdongbing | Yes | 01:37 |
lvdongbing | OK, I'll think about it and fix it | 01:37 |
Qiming | unless we do need the exception details for some reasons | 01:37 |
Qiming | many thanks | 01:37 |
lvdongbing | Thanks for you suggestion:) | 01:38 |
*** zhenguo has joined #senlin | 01:42 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Add jobs related to gating/publishing (API) docs https://review.openstack.org/246710 | 01:42 |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Support creating policy https://review.openstack.org/245824 | 01:44 |
openstackgerrit | Liuqing Jing proposed openstack/python-senlinclient: Fix typo s/beteen/between/ https://review.openstack.org/246712 | 01:48 |
*** pratikmallya has joined #senlin | 01:48 | |
*** shu has joined #senlin | 01:49 | |
*** pratikmallya has quit IRC | 01:53 | |
openstackgerrit | Merged openstack/senlin-dashboard: Add link for physical id https://review.openstack.org/245756 | 01:53 |
openstackgerrit | Qiming Teng proposed openstack/python-senlinclient: Remove spec file profile-update command https://review.openstack.org/246715 | 01:56 |
*** Liuqing has joined #senlin | 01:58 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Change developer/user docs about profile-update https://review.openstack.org/246717 | 02:06 |
openstackgerrit | Qiming Teng proposed openstack/senlin: API doc change for profile-update operation https://review.openstack.org/246720 | 02:09 |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove 'spec' from profile-update service api https://review.openstack.org/246726 | 02:41 |
*** Yanyanhu has joined #senlin | 02:42 | |
openstackgerrit | Qiming Teng proposed openstack/senlin: Remove 'spec' from profile-update service api https://review.openstack.org/246726 | 02:54 |
*** Liuqing has quit IRC | 02:55 | |
*** Liuqing has joined #senlin | 02:55 | |
openstackgerrit | Merged openstack/python-senlinclient: Fix typo s/beteen/between/ https://review.openstack.org/246712 | 03:02 |
*** jdandrea has quit IRC | 03:04 | |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable initiative action selecting in start_action https://review.openstack.org/244026 | 03:10 |
openstackgerrit | Merged openstack/senlin-dashboard: Support creating policy https://review.openstack.org/245824 | 03:12 |
*** yuanying_ has joined #senlin | 03:17 | |
*** yuanying has quit IRC | 03:19 | |
*** yuanying_ has quit IRC | 03:21 | |
*** Qiming has quit IRC | 03:47 | |
*** lvdongbing has quit IRC | 04:04 | |
*** lvdongbing has joined #senlin | 04:04 | |
*** yuanying has joined #senlin | 04:10 | |
openstackgerrit | Merged openstack/senlin: Enable initiative action selecting in start_action https://review.openstack.org/244026 | 05:45 |
openstackgerrit | Merged openstack/python-senlinclient: Remove spec file profile-update command https://review.openstack.org/246715 | 05:57 |
openstackgerrit | Merged openstack/senlin: Updated from global requirements https://review.openstack.org/246105 | 06:02 |
openstackgerrit | Merged openstack/senlin: Remove 'spec' from profile-update service api https://review.openstack.org/246726 | 06:02 |
openstackgerrit | Yanyan Hu proposed openstack/senlin: Enable network update of nova server profile https://review.openstack.org/241561 | 06:06 |
*** Liuqing has quit IRC | 06:10 | |
*** Liuqing has joined #senlin | 06:11 | |
*** elynn has joined #senlin | 07:01 | |
*** Liuqing has quit IRC | 07:05 | |
*** Liuqing has joined #senlin | 07:06 | |
*** Liuqing has quit IRC | 08:23 | |
*** Liuqing has joined #senlin | 08:24 | |
*** Liuqing has quit IRC | 08:53 | |
*** Liuqing has joined #senlin | 08:54 | |
*** Liuqing has quit IRC | 09:32 | |
*** lvdongbing has quit IRC | 09:36 | |
*** elynn has quit IRC | 09:55 | |
*** Yanyanhu has quit IRC | 09:57 | |
*** Liuqing has joined #senlin | 10:03 | |
*** ziggypup has joined #senlin | 10:23 | |
*** ziggypup has left #senlin | 10:23 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Add policy deletion action https://review.openstack.org/246859 | 11:05 |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Add policy deletion action https://review.openstack.org/246859 | 11:24 |
*** zhenguo has quit IRC | 11:27 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Make node status value translatable https://review.openstack.org/246882 | 11:36 |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Make cluster status value translatable https://review.openstack.org/246885 | 11:46 |
*** Qiming has joined #senlin | 11:47 | |
*** Qiming has quit IRC | 12:01 | |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Hide in detail page while it's value is None https://review.openstack.org/246896 | 12:17 |
openstackgerrit | Liuqing Jing proposed openstack/senlin-dashboard: Hide `Updated` in detail page while it's value is None https://review.openstack.org/246896 | 12:26 |
*** Liuqing_ has joined #senlin | 13:31 | |
*** Liuqing has quit IRC | 13:33 | |
*** lkarm has joined #senlin | 13:50 | |
*** openstackgerrit has quit IRC | 14:31 | |
*** openstackgerrit has joined #senlin | 14:32 | |
*** jdandrea has joined #senlin | 14:43 | |
*** Liuqing_ has quit IRC | 15:11 | |
*** lkarm has quit IRC | 15:22 | |
*** pratikmallya has joined #senlin | 15:25 | |
*** pratikma_ has joined #senlin | 15:25 | |
*** pratikmallya has quit IRC | 15:30 | |
*** pratikma_ is now known as pratikmallya | 16:02 | |
*** lkarm has joined #senlin | 16:37 | |
*** lkarm has quit IRC | 16:38 | |
*** lkarm has joined #senlin | 16:39 | |
*** lkarm has quit IRC | 17:49 | |
*** pratikmallya has quit IRC | 17:52 | |
*** pratikmallya has joined #senlin | 18:18 | |
*** lkarm has joined #senlin | 18:38 | |
*** lkarm has quit IRC | 18:41 | |
*** lkarm has joined #senlin | 18:41 | |
*** pratikma_ has joined #senlin | 18:50 | |
*** pratikmallya has quit IRC | 18:52 | |
*** rebase has joined #senlin | 20:53 | |
*** openstack has joined #senlin | 21:06 | |
*** pratikma_ has quit IRC | 21:35 | |
*** pratikmallya has joined #senlin | 21:35 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/senlin-dashboard: Updated from global requirements https://review.openstack.org/247197 | 21:52 |
*** pratikmallya has quit IRC | 22:01 | |
*** lkarm has quit IRC | 22:25 | |
*** lkarm has joined #senlin | 22:25 | |
*** lkarm has quit IRC | 22:30 | |
*** pratikmallya has joined #senlin | 22:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!