| *** xuhaiwei has quit IRC | 00:02 | |
| *** pratikmallya has quit IRC | 00:03 | |
| *** yuanying has quit IRC | 00:04 | |
| *** yuanying has joined #senlin | 00:05 | |
| *** lixinhui has joined #senlin | 00:06 | |
| *** tianc has quit IRC | 00:22 | |
| *** tianc has joined #senlin | 00:23 | |
| *** yuanying has quit IRC | 00:32 | |
| *** yuanying has joined #senlin | 00:34 | |
| *** yuanying has quit IRC | 00:44 | |
| *** yuanying has joined #senlin | 00:47 | |
| *** openstackstatus has quit IRC | 00:50 | |
| *** openstack has joined #senlin | 00:54 | |
| *** xuhaiwei has joined #senlin | 01:16 | |
| openstackgerrit | lvdongbing proposed openstack/senlin: Format time to cut microsecond https://review.openstack.org/254814 | 01:22 |
|---|---|---|
| *** zhenguo has joined #senlin | 01:24 | |
| *** Yanyanhu has joined #senlin | 01:27 | |
| *** Liuqing has joined #senlin | 01:48 | |
| *** Liuqing has quit IRC | 01:58 | |
| *** elynn__ has joined #senlin | 01:58 | |
| *** elynn___ has joined #senlin | 02:03 | |
| *** pratikmallya has joined #senlin | 02:03 | |
| *** elynn__ has quit IRC | 02:04 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Make cluster actions API return a location header https://review.openstack.org/254636 | 02:06 |
| elynn___ | Morning ;) | 02:27 |
| *** elynn___ has quit IRC | 02:31 | |
| *** elynn has joined #senlin | 02:32 | |
| openstackgerrit | zhangguoqing proposed openstack/python-senlinclient: Fix pep8 error about D300 https://review.openstack.org/255046 | 02:33 |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Make node-create return a location header https://review.openstack.org/255048 | 02:40 |
| openstackgerrit | Ethan Lynn proposed openstack/python-senlinclient: Try to show policy after policy created https://review.openstack.org/254254 | 02:46 |
| xuhaiwei | can anyone show the senlin api manual PDF version? | 02:47 |
| elynn | xuhaiwei: http://docs-draft.openstack.org/45/252245/10/check/gate-api-site-tox-doc-publish-checkbuild/d1f26a1//publish-docs/api-ref-guides/bk-api-ref-clustering-v1.pdf | 02:48 |
| xuhaiwei | thanks | 02:48 |
| elynn | xuhaiwei: np | 02:48 |
| *** Qiming has joined #senlin | 02:56 | |
| openstackgerrit | Merged openstack/python-senlinclient: Cluster's timeout is in seconds not minutes https://review.openstack.org/254601 | 02:58 |
| openstackgerrit | Merged openstack/python-senlinclient: Try to show policy after policy created https://review.openstack.org/254254 | 02:58 |
| Qiming | xuhaiwei, there? | 03:07 |
| xuhaiwei | yes | 03:07 |
| Qiming | about patch #254636 | 03:07 |
| Qiming | I'm afraid returning the cluster dict is not helpful | 03:07 |
| Qiming | none of the results from executing those actions can be reflected from the cluster dict | 03:08 |
| Qiming | including cluster_policy_update | 03:08 |
| xuhaiwei | you mean update cluster policy may not return cluster body? | 03:09 |
| Qiming | so it seems we don't have things to return other than the action itself | 03:09 |
| Qiming | yes, returning the cluster body is not helpful | 03:09 |
| Qiming | the object that gets updated is the cluster-policy binding | 03:09 |
| xuhaiwei | just return location heare and action id? | 03:09 |
| xuhaiwei | yes | 03:10 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix DB sync issue happened during action dependency update https://review.openstack.org/252231 | 03:10 |
| xuhaiwei | by the way, I also find a bug of cluster_policy_update | 03:10 |
| Qiming | right, you may choose to return the action dict in body | 03:10 |
| xuhaiwei | ok | 03:10 |
| Qiming | as we have mentioned yesterday, no one is preventing us from returning something in body for 202 | 03:10 |
| Qiming | file a bug then | 03:11 |
| xuhaiwei | ok, I am reading the api docs | 03:11 |
| xuhaiwei | find some tiny problems | 03:11 |
| xuhaiwei | you may need to fix them, but really cost time | 03:12 |
| xuhaiwei | I will go for lunch, talk to you later | 03:15 |
| *** lvdongbing has joined #senlin | 03:15 | |
| Qiming | ok | 03:19 |
| *** pratikmallya has quit IRC | 03:21 | |
| *** yuanying has quit IRC | 03:23 | |
| lvdongbing | Hello, everyone, I have a question about: https://review.openstack.org/#/c/254254/ | 03:47 |
| lvdongbing | Why retrieve again if it's not needed? | 03:47 |
| Qiming | lvdongbing, we don't know if it is needed | 03:50 |
| Qiming | it is only about maitaining consistency | 03:51 |
| lvdongbing | Ok, for webhook creation, we are sure it's not needed? Cause it doesn't retrieve again. | 03:53 |
| *** pratikmallya has joined #senlin | 03:57 | |
| *** elynn has quit IRC | 03:58 | |
| *** pratikmallya has quit IRC | 04:05 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Make cluster actions API return a location header https://review.openstack.org/254636 | 04:11 |
| *** lkarm has joined #senlin | 04:15 | |
| *** lkarm has quit IRC | 04:19 | |
| *** shu-mutou has joined #senlin | 04:20 | |
| xuhaiwei | Qiming, are you there? | 04:28 |
| *** yuanying has joined #senlin | 04:28 | |
| Qiming | yes sir | 04:28 |
| xuhaiwei | about the api doc | 04:29 |
| xuhaiwei | find some nits | 04:29 |
| xuhaiwei | first is English, some verbs on the head of one sentense does not use 'xxxs' | 04:30 |
| xuhaiwei | for example. 'lists the clusters' | 04:30 |
| xuhaiwei | something like that | 04:30 |
| xuhaiwei | http://paste.openstack.org/show/481270/ | 04:31 |
| xuhaiwei | I listed it here | 04:31 |
| xuhaiwei | the created_time problem maybe caused by a bug | 04:32 |
| xuhaiwei | the URI ones I dont know it wrong or right | 04:32 |
| *** elynn_ has joined #senlin | 04:34 | |
| Qiming | URI is right | 04:35 |
| Qiming | it is derived from the query string | 04:36 |
| xuhaiwei | page38 's uri is wrong I think | 04:36 |
| Qiming | empty page cannot be avoided, it is also created from the pdf gen tool | 04:36 |
| xuhaiwei | p38 /v1/nodes/{node_id}{?show_details} | 04:37 |
| xuhaiwei | why {?show_details} comes out | 04:37 |
| Qiming | it is a query string | 04:37 |
| Qiming | it is correct I think | 04:37 |
| xuhaiwei | ok | 04:38 |
| Qiming | if we cannot parse this uri, it is server's problem | 04:38 |
| Qiming | diane flemming has kindly revised the whole wsdl | 04:38 |
| Qiming | for your info | 04:38 |
| Qiming | so I'm not very concerned about the English problems now | 04:38 |
| xuhaiwei | ok | 04:39 |
| Qiming | created_time may not be of right format, let's first get the server response done right and then fix the sample json file | 04:39 |
| xuhaiwei | yes, agree | 04:40 |
| openstackgerrit | Merged openstack/senlin: Make node-create return a location header https://review.openstack.org/255048 | 04:42 |
| *** yuanying has quit IRC | 04:46 | |
| openstackgerrit | Merged openstack/senlin: Make cluster actions API return a location header https://review.openstack.org/254636 | 04:47 |
| openstackgerrit | Merged openstack/senlin: Make node join/leave return a location header https://review.openstack.org/254641 | 04:51 |
| *** yuanying has joined #senlin | 05:00 | |
| *** Qiming has quit IRC | 05:22 | |
| xuhaiwei | lvdongbing, are you around? | 05:25 |
| lvdongbing | yes | 05:25 |
| openstackgerrit | Merged openstack/python-senlinclient: Add py34 to tox.ini https://review.openstack.org/254086 | 05:26 |
| xuhaiwei | the webhook show also needs a fix? | 05:26 |
| *** Qiming has joined #senlin | 05:27 | |
| xuhaiwei | Qiming, for webhook-create, we don't GET webhook when creating it? | 05:27 |
| xuhaiwei | for security concern? | 05:28 |
| Qiming | no | 05:29 |
| Qiming | still working on a fix now | 05:29 |
| Qiming | previously we return everything about a webhook | 05:29 |
| xuhaiwei | you are fixing it? | 05:29 |
| Qiming | then we tried to avoid returning the key everytime | 05:30 |
| xuhaiwei | ok, I will wait for your patch | 05:30 |
| Qiming | because the concern is that if you are returning everything everytime, the security doesn't exist at all | 05:30 |
| Qiming | it maybe that we are doing it wrong | 05:31 |
| xuhaiwei | so we should cover the url? | 05:31 |
| Qiming | I'm taking over the receiver design now, will come up with some patches later | 05:31 |
| lvdongbing | Nice | 05:31 |
| Qiming | yes, we should return the url | 05:31 |
| Qiming | and everything | 05:32 |
| Qiming | provided that you are the admin or the owner of the webhook | 05:32 |
| Qiming | the url won't be the top level key | 05:33 |
| Qiming | because it is not generic | 05:33 |
| Qiming | it only makes sense to webhook kind of receiver | 05:34 |
| xuhaiwei | but if I am the admin, I may want to use the webhook many times, so I need somewhere to store the url | 05:35 |
| xuhaiwei | if webhook show doesn't contain the url, I have to memo it somewhere else by myself | 05:35 |
| Qiming | it was a design decision previously | 05:37 |
| Yanyanhu | xuhaiwei, I think we should let user take the responsibility to store the webhook carefully | 05:37 |
| Qiming | yes, that is how you will use Amazon services | 05:38 |
| Yanyanhu | since that url contains credential information | 05:38 |
| Qiming | you will get a key, and the key has to be stored safely by yourself | 05:38 |
| xuhaiwei | maybe use barbican to store it? | 05:38 |
| Qiming | it doesn't matter if the encrypted data is stored in senlin db or in barbican | 05:38 |
| Qiming | it is an implementation detail | 05:39 |
| Qiming | the key question here is about how users are supposed to use this interface | 05:39 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Rework functional tests of cluster_list and node_list https://review.openstack.org/255077 | 05:49 |
| *** lixinhui has quit IRC | 05:52 | |
| *** lixinhui has joined #senlin | 06:18 | |
| *** lkarm has joined #senlin | 06:42 | |
| *** lkarm has quit IRC | 06:46 | |
| *** pratikmallya has joined #senlin | 07:00 | |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Add test case for v1/shell.py part2 https://review.openstack.org/251798 | 07:08 |
| openstackgerrit | lvdongbing proposed openstack/senlin: Format time to cut microsecond https://review.openstack.org/254814 | 07:28 |
| xuhaiwei | Qiming, create action API is not included in the API doc, should we make a fix to let it return location header? | 07:31 |
| Qiming | creat action should return 201 will a full body? | 07:32 |
| Qiming | it doesn't sound like an async operations | 07:32 |
| Qiming | well, maybe and maybe not | 07:34 |
| Qiming | it all depends on whether we want an action to be launched immediately after creation | 07:35 |
| xuhaiwei | currently it is a 200 | 07:35 |
| xuhaiwei | 201 | 07:35 |
| Qiming | then leave it there? | 07:35 |
| xuhaiwei | ok | 07:35 |
| *** pratikmallya has quit IRC | 07:45 | |
| *** lvdongbing has quit IRC | 07:50 | |
| *** lvdongbing has joined #senlin | 08:05 | |
| openstackgerrit | lvdongbing proposed openstack/senlin: Format time to cut microsecond https://review.openstack.org/254814 | 08:10 |
| *** lvdongbing has quit IRC | 08:15 | |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Add test case for v1/shell.py part2 https://review.openstack.org/251798 | 08:19 |
| *** lvdongbing has joined #senlin | 08:44 | |
| *** openstackstatus has quit IRC | 09:05 | |
| *** openstack has joined #senlin | 09:09 | |
| -wolfe.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 09:09 | |
| openstackgerrit | xu-haiwei proposed openstack/senlin: Make webhook-trigger return a location header https://review.openstack.org/255142 | 09:13 |
| elynn_ | Hi Qiming | 09:20 |
| elynn_ | How to initialize senlinclient? I got an error when using senlinclient in heat | 09:21 |
| elynn_ | http://paste.openstack.org/show/481285/ | 09:21 |
| elynn_ | Seems codes are not fit for senlin now https://github.com/openstack/heat/blob/master/heat/engine/clients/os/senlin.py#L28-L32 | 09:22 |
| elynn_ | Yanyanhu ^ | 09:23 |
| elynn_ | Could you give me some hint? | 09:24 |
| *** lkarm has joined #senlin | 09:25 | |
| Qiming | it is an authentication failure | 09:25 |
| elynn_ | What args should I use now? | 09:26 |
| Qiming | the 'passwordCredentials' looks strange to me | 09:26 |
| elynn_ | Seems need to pass username in args now. | 09:27 |
| Qiming | yes, either username + user_project_name or userid | 09:28 |
| elynn_ | ok, Add userid and try again... | 09:28 |
| *** lkarm has quit IRC | 09:29 | |
| Qiming | http://git.openstack.org/cgit/openstack/python-senlinclient/tree/senlinclient/shell.py#n216 | 09:29 |
| elynn_ | Need password now? | 09:31 |
| Qiming | certainly | 09:32 |
| *** openstackgerrit has quit IRC | 09:32 | |
| Qiming | Yanyanhu, xuhaiwei are you there? | 09:32 |
| elynn_ | heat can't get password in context | 09:33 |
| *** openstackgerrit has joined #senlin | 09:33 | |
| elynn_ | http://paste.openstack.org/show/481287/ adjust codes and met a new error message... | 09:33 |
| Qiming | then you will have a token | 09:33 |
| xuhaiwei | yes | 09:34 |
| Qiming | elynn_, you are using a token but you are getting error message about password? | 09:34 |
| elynn_ | Qiming: Yes... | 09:35 |
| Qiming | I see | 09:35 |
| Qiming | the senlinclient is defaulting to 'password' authentication at the moment | 09:36 |
| elynn_ | And I don't see any error message in senlin-engine | 09:36 |
| Qiming | you are currently blocked by keystone | 09:37 |
| Qiming | the request has not yet arrived at senlin-api | 09:37 |
| elynn_ | auth_plugin can be? | 09:37 |
| elynn_ | trust? | 09:37 |
| Qiming | token | 09:39 |
| Qiming | http://git.openstack.org/cgit/openstack/keystoneauth/tree/setup.cfg#n37 | 09:40 |
| Qiming | xuhaiwei, I'm working on the "new" receiver design | 09:41 |
| xuhaiwei | yes | 09:41 |
| Qiming | one way of getting this landed piece by piece is to modify the api, the rpc client, the engine, the database, in this order | 09:41 |
| Qiming | then the client, the api doc and user doc | 09:42 |
| Qiming | this is gonna be a disruptive change to any existing webhook related code and test case | 09:42 |
| elynn_ | Qiming: token seems not work. http://paste.openstack.org/show/481288/ | 09:42 |
| xuhaiwei | so ? | 09:43 |
| Qiming | right, sometimes we are getting 404 directly | 09:43 |
| xuhaiwei | this bad 404 description is from keystoneauth1 | 09:44 |
| xuhaiwei | too simple | 09:44 |
| Qiming | one way of testing this is to use senlin CLI directly | 09:44 |
| Qiming | sometimes naive? | 09:45 |
| xuhaiwei | always naive | 09:45 |
| Qiming | elynn_, you can unset all your OS_xxx environment variables | 09:45 |
| Qiming | then start with export OS_AUTH_URL=abc OS_PROJECT_ID=def .. | 09:45 |
| *** lvdongbing has quit IRC | 09:45 | |
| Qiming | and see why we are getting that authentication failure | 09:46 |
| Qiming | one thing to notice is the auth url, is it v2.0 or v3 | 09:46 |
| Qiming | as you can see from keystoneauth, they also have v2token, v3token ... | 09:46 |
| Qiming | they are trying to make some guesses, but I'm suspecting that they are doing things wrong | 09:47 |
| elynn_ | v2token doesn't work either... I will follow your way and try again... | 09:47 |
| Qiming | xuhaiwei, regarding the webhook -> receiver transition | 09:47 |
| openstackgerrit | Merged openstack/senlin: Format time to cut microsecond https://review.openstack.org/254814 | 09:47 |
| xuhaiwei | yes? | 09:47 |
| Qiming | I'm thinking of adding the receiver abstraction step by step: db -> engine -> rpc -> api -> client -> api doc -> user doc | 09:48 |
| Qiming | then we remove the webhook abstraction in the reverse order | 09:48 |
| Qiming | this could help avoid pains in breaking existing code | 09:49 |
| xuhaiwei | when we have the receiver, webhook is not needed? | 09:50 |
| Qiming | yes | 09:50 |
| xuhaiwei | receiver contains webhook? | 09:50 |
| Qiming | it will be a replacement | 09:50 |
| Qiming | a more generic form of webhook | 09:50 |
| xuhaiwei | oh | 09:50 |
| xuhaiwei | ok | 09:50 |
| Qiming | I was just trying to avoid modifying the webhook code directly | 09:51 |
| xuhaiwei | yes, that's good I think | 09:51 |
| Qiming | still working on the BP | 09:52 |
| Qiming | will start with DB layer patches when we have a BP draft | 09:52 |
| xuhaiwei | cool | 09:52 |
| xuhaiwei | wait for your patch | 09:52 |
| Qiming | then wait ... | 09:53 |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** zhenguo has quit IRC | 10:02 | |
| *** openstackgerrit has joined #senlin | 10:03 | |
| openstackgerrit | xu-haiwei proposed openstack/python-senlinclient: Make cluster-policy-update help message clear https://review.openstack.org/255177 | 10:04 |
| elynn_ | Seems my env is broken... | 10:17 |
| elynn_ | always got an 404 not found error when doing cluster-list | 10:18 |
| elynn_ | Ah, I need to register the endpoints... | 10:18 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Rework functional tests of cluster_list and node_list https://review.openstack.org/255077 | 10:20 |
| openstackgerrit | Yanyan Hu proposed openstack/senlin: Fix DB sync issue happened during action dependency update https://review.openstack.org/252231 | 10:20 |
| *** Yanyanhu has quit IRC | 10:26 | |
| *** yuanying has quit IRC | 11:07 | |
| *** gongysh has quit IRC | 11:35 | |
| *** elynn_ has quit IRC | 11:59 | |
| *** cschulz has quit IRC | 12:04 | |
| *** Liuqing has joined #senlin | 13:05 | |
| *** cschulz has joined #senlin | 13:08 | |
| cschulz | Qiming can my team start looking into the bug I found yesterday? | 13:10 |
| Qiming | sure | 13:10 |
| Qiming | thanks for the help | 13:10 |
| cschulz | OK Thanks. _shruti and _mayur are part of my team if they show up on the chat. | 13:11 |
| Qiming | great! | 13:12 |
| openstackgerrit | zhangguoqing proposed openstack/python-senlinclient: Fix pep8 error about D300 https://review.openstack.org/255046 | 13:27 |
| *** lkarm has joined #senlin | 13:31 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Fix MutableList implementation https://review.openstack.org/255267 | 13:46 |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Improve logging in functional testings https://review.openstack.org/255273 | 14:05 |
| *** pratikmallya has joined #senlin | 14:12 | |
| openstackgerrit | Qiming Teng proposed openstack/senlin: Shorten the event ID in log output for reability https://review.openstack.org/255276 | 14:17 |
| *** pratikmallya has quit IRC | 14:22 | |
| *** lixinhui has quit IRC | 14:31 | |
| *** pratikmallya has joined #senlin | 14:45 | |
| *** pratikma_ has joined #senlin | 14:46 | |
| *** pratikmallya has quit IRC | 14:50 | |
| *** Qiming has quit IRC | 15:45 | |
| *** Liuqing has quit IRC | 15:47 | |
| *** pratikma_ has quit IRC | 17:51 | |
| *** pratikmallya has joined #senlin | 18:18 | |
| *** lkarm has quit IRC | 19:40 | |
| *** lkarm has joined #senlin | 19:44 | |
| *** lkarm has quit IRC | 19:56 | |
| *** lkarm has joined #senlin | 19:57 | |
| *** lkarm has quit IRC | 19:58 | |
| *** lkarm has joined #senlin | 20:05 | |
| *** lkarm has quit IRC | 20:10 | |
| *** cschulz has quit IRC | 21:52 | |
| *** pratikma_ has joined #senlin | 22:02 | |
| *** pratikma_ has quit IRC | 22:03 | |
| *** pratikma_ has joined #senlin | 22:03 | |
| *** pratikmallya has quit IRC | 22:03 | |
| *** pratikmallya has joined #senlin | 22:43 | |
| *** pratikma_ has quit IRC | 22:46 | |
| *** pratikmallya has quit IRC | 22:47 | |
| *** yuanying has joined #senlin | 22:56 | |
| *** cschulz has joined #senlin | 23:16 | |
| *** Qiming has joined #senlin | 23:51 | |
| *** lixinhui has joined #senlin | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!