Thursday, 2016-01-14

*** pratikmallya has quit IRC00:03
*** xuhaiwei has joined #senlin01:18
*** Qiming has joined #senlin01:20
*** Yanyanhu has joined #senlin01:41
openstackgerritMerged openstack/senlin: Optimize Zone Distribution Get Logic for Placement  https://review.openstack.org/26508601:49
*** Qiming_ has joined #senlin02:01
*** Qiming has quit IRC02:04
openstackgerritMerged openstack/senlin: Remove 'priority' and 'level' from API layer  https://review.openstack.org/26680502:07
*** gongysh has quit IRC02:12
*** gongysh has joined #senlin02:12
*** elynn has joined #senlin02:35
elynnmorning02:36
lixinhuimorning, elynn02:44
elynnmorning lixinhui :)02:44
openstackgerritMerged openstack/senlin: use oslo.utils.reflection extract the class name  https://review.openstack.org/26680703:02
*** yuanying_ has quit IRC03:34
openstackgerritEthan Lynn proposed openstack/senlin: Fix action sort  https://review.openstack.org/26677803:44
*** yuanying has joined #senlin03:46
*** Qiming_ has quit IRC03:54
*** yuanying_ has joined #senlin03:56
*** yuanying has quit IRC03:59
*** yuanying_ has quit IRC04:00
*** yuanying has joined #senlin04:06
*** yuanying has quit IRC04:07
*** yuanying_ has joined #senlin04:07
*** Qiming_ has joined #senlin04:11
openstackgerritMerged openstack/senlin: Trival: Remove unused logging import  https://review.openstack.org/26686304:37
openstackgerritting wang proposed openstack/senlin: Remove H402 rule of HACKING check  https://review.openstack.org/26729804:40
openstackgerritting wang proposed openstack/senlin: ADD E402 rule of HACKING check  https://review.openstack.org/26729804:46
openstackgerritting wang proposed openstack/senlin: ADD H402 rule of HACKING check and fix flake8  https://review.openstack.org/26729805:13
openstackgerritting wang proposed openstack/senlin: ADD H402 rule of HACKING check and fix flake8  https://review.openstack.org/26729805:23
openstackgerritMerged openstack/senlin: Remove 'level' and 'cooldown' from policies  https://review.openstack.org/26687905:44
openstackgerritMerged openstack/senlin: Remove old properties from cluster-policy-binding (API)  https://review.openstack.org/26689205:44
openstackgerritYanyan Hu proposed openstack/senlin: Add metadata updating support for os.nova.server profile  https://review.openstack.org/26265805:46
openstackgerritQiming Teng proposed openstack/senlin: Remove old properties of c-p binding (engine)  https://review.openstack.org/26693105:50
openstackgerritCindia-blue proposed openstack/senlin: Add Description about Recover Function in Profile  https://review.openstack.org/26472705:55
elynnHi do you have time to review https://review.openstack.org/#/c/266778/ ?06:13
openstackgerritYanyan Hu proposed openstack/senlin: Add metadata update support for os.nova.server profile  https://review.openstack.org/26265806:13
openstackgerritMerged openstack/senlin: Add Description about Recover Function in Profile  https://review.openstack.org/26472706:14
xuhaiweiEngine lock problem happened again when having a test06:28
xuhaiweicurrently we are modifying a lot for api and db, not sure why this happened06:29
xuhaiweiI am testing cluster-scale-out by using placement policy06:29
Qiming_elynn, either you or I have to rebase I guess06:30
elynnlock breaker are not enable for now.06:30
elynnQiming_, I can do a rebase.06:30
Qiming_xuhaiwei, at this stage, the whole service is not suitable for a testing06:30
Qiming_you may be well aware that we are in the middle of a huge change06:31
openstackgerritMerged openstack/senlin: Remove old properties of c-p binding (engine)  https://review.openstack.org/26693106:31
xuhaiweiyes, I will test it later again06:31
elynnQiming_, Oh... both of our patch are merging, let's see what will happend.06:31
Qiming_for example, http://git.openstack.org/cgit/openstack/senlin/tree/senlin/engine/actions/base.py#n38306:31
Qiming_the line elynn is modifying06:32
Qiming_and the for loop on line 39006:32
Qiming_this is all broken06:32
Qiming_after we are removing 'priority', 'level' and 'cooldown'06:32
Qiming_we don't know which policy will be checked first, which will be checked next06:32
Qiming_after all these disruptive changes are in, we will need Yanyan's patch : https://review.openstack.org/#/c/264670/06:34
openstackgerritMerged openstack/senlin: Fix action sort  https://review.openstack.org/26677806:34
Qiming_so ... it doesn't make any sense to do a placement policy test06:34
Qiming_at least at this moment06:34
Qiming_we have higer priority things to do06:34
xuhaiweiyes, so lets make all of these done first06:35
Qiming_elynn, both patches merged, conflict solved by git automatically06:36
Qiming_\o/06:36
elynnthat's good.06:36
xuhaiweidon't understand well why gerrit has a conflict lists at the patch page06:37
Qiming_it is confusing06:37
Qiming_it is actually listing some patch dependencies, but it is calling them as 'conflicts'06:38
openstackgerritYanyan Hu proposed openstack/senlin: [WIP]Rework policy check for built-in policy types  https://review.openstack.org/26467006:45
openstackgerritYanyan Hu proposed openstack/senlin: Rework policy check for built-in policy types  https://review.openstack.org/26467006:51
openstackgerritEthan Lynn proposed openstack/senlin: Fix action columns in db migration scripts  https://review.openstack.org/26734307:06
openstackgerritYanyan Hu proposed openstack/senlin: Revise policy functional test  https://review.openstack.org/26735207:21
openstackgerritMerged openstack/senlin: Fix action columns in db migration scripts  https://review.openstack.org/26734307:32
openstackgerritMerged openstack/senlin: Revise policy functional test  https://review.openstack.org/26735207:34
openstackgerritMerged openstack/senlin: Add metadata update support for os.nova.server profile  https://review.openstack.org/26265807:36
openstackgerritQiming Teng proposed openstack/senlin: Further cleanse useless properties of cp/policies  https://review.openstack.org/26736307:39
openstackgerritYanyan Hu proposed openstack/senlin: Remove level, priority and cooldown kwargs from cluster methods  https://review.openstack.org/26736407:42
Yanyanhulost all my draft comments after refreshing the webpage of patch review... sigh07:46
Yanyanhuneed to rewrite them all07:47
xuhaiweixixi07:47
Yanyanhudidn't know what happened...07:48
elynnbad gerrit07:48
Yanyanhuyea07:48
xuhaiweiit should be there07:48
Qiming_it is still there07:48
xuhaiweiyou saved it , right?07:48
Qiming_you will need to switch to the proper patchset, but clicking the upper right corner07:48
Qiming_switch to the patchset07:49
xuhaiweiI think so07:49
Yanyanhuah, I see07:49
YanyanhuI first replied qiming's comments07:50
Yanyanhuthan haiwei's07:50
Yanyanhubut those reply comments in draft status will not be shown in the same reply post07:50
Yanyanhusigh, that is because you guys comments are not in the same patchset07:51
xuhaiweiof course07:51
Yanyanhumy fault. I shouldn't blame gerrit for this :)07:52
openstackgerritEthan Lynn proposed openstack/senlin: Add 'service' table in db  https://review.openstack.org/26736907:52
xuhaiweiI often make the same mistake07:52
Yanyanhu:)08:00
openstackgerritEthan Lynn proposed openstack/senlin: Make senlin-manage a console_script entry point  https://review.openstack.org/26737408:09
openstackgerritEthan Lynn proposed openstack/senlin: Make senlin-api a console script entry point  https://review.openstack.org/26737508:09
openstackgerritEthan Lynn proposed openstack/senlin: Make senlin-engine a console script entry point  https://review.openstack.org/26737608:09
openstackgerritQiming Teng proposed openstack/senlin: Revise user docs for policy and bindings changes  https://review.openstack.org/26737808:13
openstackgerritMerged openstack/senlin: Replace deprecated library function os.popen() with subprocess  https://review.openstack.org/26684908:14
Yanyanhuhi, Qiming_, around?08:39
Qiming_yes sir08:39
Yanyanhudo you think it's necessary to add 'policy_type' attribute to cluster_policy db model?08:39
Yanyanhufor filtering08:39
Qiming_wait08:40
Yanyanhuok08:40
Qiming_we already have a policy in it08:42
Qiming_as a backref08:42
Qiming_if needed, I'd suggest we add a db api for this purpose instead of adding a redundant column into the 'cluster_policy' table08:43
Qiming_I understand the requirement to do a policy type based filtering though08:43
Qiming_that can be done via a DB API08:44
YanyanhuQiming_, understand, I think this is better to add 'policy_type' property08:48
Yanyanhuthanks08:48
Yanyanhus/better to/better than08:48
openstackgerritCindia-blue proposed openstack/senlin: Add Recover into Node Actions and Node Model  https://review.openstack.org/26456808:55
openstackgerritCindia-blue proposed openstack/senlin: Add Recover as a Cluster Action  https://review.openstack.org/26741909:07
openstackgerritYanyan Hu proposed openstack/senlin: Support to filter cluster_policy with policy_type  https://review.openstack.org/26742209:15
openstackgerritQiming Teng proposed openstack/senlin: Further cleanse developer doc  https://review.openstack.org/26742409:16
openstackgerritEthan Lynn proposed openstack/senlin: Add db api for service table  https://review.openstack.org/26742509:18
Yanyanhuhi, elynn, which patch is the last one in this dependency chain? https://review.openstack.org/#/c/267374/09:21
Yanyanhuso patch for senlin-manage depends on the one for senlin-api?09:21
Yanyanhuand the one for senlin-api relies on the one for senlin-engine?09:22
elynnsenlin-engine depends on senlin-api09:22
Yanyanhuoh09:22
elynnsenlin-api depends on senlin-manage09:22
YanyanhuI see09:22
elynnfrom bottom to top09:22
Yanyanhugot it09:22
openstackgerritMerged openstack/senlin: Further cleanse useless properties of cp/policies  https://review.openstack.org/26736309:23
openstackgerritQiming Teng proposed openstack/senlin: Revert "Fix action columns in db migration scripts"  https://review.openstack.org/26743009:35
Qiming_hi, we were getting some complaints a few weeks before from some early users09:35
Qiming_we are not gonna change the DB schema freely09:35
Qiming_we have to start managing DB schema in a stricter way09:36
elynnOK, let's follow the guided way to migrate our db schema.09:36
Qiming_right09:37
Qiming_chuck sent me an email complaining that after reinstall senlin service and do db migration, we were deleting all database entries09:37
openstackgerritxu-haiwei proposed openstack/senlin: Remove 'level', 'priority' and 'cooldown' from DB  https://review.openstack.org/26743209:38
Qiming_that is another problem09:38
Qiming_xuhaiwei, let's keep those columns in database09:38
xuhaiweiwhy09:38
elynnI think it's better to add another script to remove deleted columns.09:38
Qiming_elynn, we can improve the script to do a clean install or an upgrade09:39
Qiming_xuhaiwei, okay, you are only removing them from the db models, that is fine09:40
elynnok, let me have a try.09:40
Qiming_we are not so sure whether things will work properly after this huge change09:40
Qiming_xuhaiwei, so I'd suggest we keep those columns in database until we are pretty sure09:41
xuhaiweiI am afraid it will harm something if we dont clean them all09:42
YanyanhuI agree with keeping these columes since some users have started using senlin now09:42
Yanyanhuotherwise, they have to rebuild their db...09:43
Yanyanhuor we add a DB version migration?09:44
Qiming_xuhaiwei, we are not using them09:44
Qiming_we are not sure whether 'cooldown' should be just an in-memory status or a db column, until we complete the scaling policy revision09:45
openstackgerritMerged openstack/senlin: Revert "Fix action columns in db migration scripts"  https://review.openstack.org/26743009:49
Qiming_elynn, reverted the previous change to action table09:49
xuhaiweiQiming_, in fact it really harm things, if these elements remain in DB, when attaching a policy to a cluster, it will fail09:49
openstackgerritMerged openstack/senlin: Remove 'level', 'priority' and 'cooldown' from DB  https://review.openstack.org/26743209:49
xuhaiweiI am afraid we need to remove them all not only models09:50
elynnQiming_, I saw it. I will work on another patch to improve scripts.09:50
Qiming_we will need another patch for removing useless columns, including profile.permission09:50
Qiming_xuhaiwei, tell me a case why and where things fail09:50
xuhaiweijust made a test: create a policy and a cluster, then attach the policy to the cluster09:51
Qiming_how it fails?09:51
xuhaiweiwait a minite09:52
Qiming_do you have this patch?09:52
Qiming_https://review.openstack.org/26693109:52
Qiming_are you helping rework the client side to remove those 'level', 'cooldown', 'priority' properties?09:52
Yanyanhuhi, xuhaiwei, I guess that error is resolved by this patch https://review.openstack.org/26736309:53
xuhaiweiI have the latest code I think09:53
YanyanhuI also met it when doing the functional test, but I think it's gone after applying this patch09:53
xuhaiweiI am not starting client fix for this09:54
Yanyanhuerror happened during cluster policy attaching09:54
Qiming_we are not supposed to do functional tests09:54
Qiming_we are crazy for fixing a lot of things09:54
YanyanhuQiming_, I'm trying to test my change on lb_policy09:54
Qiming_anyone is working on sdk side fixes besides complaining?09:54
Yanyanhuso I run lb_policy functional test separately09:54
Qiming_Yanyanhu, that may mean something is still not cleansed09:55
xuhaiwei:q09:55
YanyanhuQiming_, yes09:55
Yanyanhubut I think that error is gone after 267363 was merged09:55
xuhaiweithat is a quit command09:55
YanyanhuI also proposed a change for this issue and then abandoned it since it duplicated with 267363 :)09:56
Qiming_please take a look at the todos09:56
Qiming_remove level/cooldown from consts09:56
Qiming_remove level/cooldown from api doc09:56
Qiming_remove level/cooldown from sdk09:56
Qiming_remove level/cooldown from client09:56
Qiming_add rpc test for cluster_policy_attach/detach/09:56
Qiming_remove cluster_policy_enable/disable sdk call09:56
Qiming_remove node_join/leave api09:56
Qiming_remove node_join/leave from rpc09:56
Qiming_remove node_join/leave from node_actions09:56
Qiming_remove node_join/leave from doc09:56
Qiming_remove node_join/leave from api doc09:56
Qiming_remove node_join/leave from SDK09:56
Qiming_remove node_join/leave from client09:56
Qiming_until all parts of code get cleansed09:56
Qiming_I'm not interested in any functional test results09:56
Yanyanhuok, I see09:56
Yanyanhuso will keep on fixing builtin policy issue after the code is cleansed09:58
xuhaiwei:q09:58
xuhaiweisorry again09:58
Qiming_never mind09:59
Qiming_just want to make sure I understand if something is really broken09:59
xuhaiweiI will show you soon10:00
Qiming_xuhaiwei, have you merged this? https://review.openstack.org/26736310:00
xuhaiweihttp://paste.openstack.org/show/483858/10:01
xuhaiweiyes, 267363 is also merged10:02
Qiming_that one is an error from api layer10:02
Qiming_it hasn't reached the RPC layer yet10:02
xuhaiweiit is not because those elements are still in DB?10:03
elynnIs that because we are not remove them from openstacksdk?10:03
Qiming_the client and the sdk side are not yet changed, so they are sending in a priority value which is not acceptable any more at api10:03
Qiming_xuhaiwei, no, the request was blocked by the api layer10:04
YanyanhuI didn't find error when directly invoking API interface of cluster_policy_attach10:04
Qiming_I'm planning to do that10:04
Qiming_but I don't want to propose too many trivial patches to SDK10:04
Qiming_I was trying to propose a change to SDK after node-join and node-leave is removed10:05
Qiming_and permission is removed ('hidden') from apis10:05
Qiming_then with a single patch, we can get the SDK side work right10:05
xuhaiweiok, I will fix client10:05
Qiming_then finally we will fix the client10:05
xuhaiweiyou fix client?10:05
Qiming_anyone can do that10:06
*** elynn has quit IRC10:06
Qiming_there are other things missing if you are looking for something to do, :)10:06
Yanyanhuactually I tried to fix client about an hour ago, but I guessed you guys was also doing that, so I stopped working on it :)10:07
Qiming_rpc client module, we don't have test cases for  cluster_policy_attach/detach10:07
Qiming_okay, that is a happy pain10:07
Qiming_we don't have unit tests for the receivers releated calls in senlin/engine/service10:08
Qiming_Regarding the error you pasted, xuhaiwei, I don't like this error report in its current format10:09
Qiming_I mean the http://paste.openstack.org/show/483858/10:09
Qiming_maybe we can return a more useful information to client instead of a stack trace10:09
xuhaiweithat error report is from API side10:10
Qiming_so you will see it from client side?10:10
xuhaiweino10:11
Qiming_okay10:12
Qiming_there are some cases we are showing call stack dumps at client side10:12
Qiming_it is crazy ...10:12
Qiming_another change proposal, guys10:12
xuhaiweiThe server could not comply with the request since it is either malformed or otherwise incorrect. (HTTP 400) (Request- ID: req-49cb9e47-969d-4b0f-8b3e-f5c724ae5cd9)10:12
Qiming_since we don't have a systematic way for access control10:12
xuhaiweiin client side, I only got this10:13
Qiming_xuhaiwei, yes, that is not very helpful10:13
xuhaiweiyes10:13
Qiming_I'm not sure how we can improve that10:13
xuhaiweiI am not sure either10:13
Qiming_it may imply that for all 400 errors, a client will see this "uniform"/"official" error message10:14
xuhaiweithis error comes from keystoneauth110:14
Qiming_which is, sadly, useless10:14
xuhaiweievery time when we got exceptions from keystoneauth1, it is in bad format10:14
Qiming_if we parse the exception carefully, the useful message should be inside the exception10:14
xuhaiweiI am doubting keystoneauth1 is making things bad10:15
Qiming_maybe, maybe not10:15
Qiming_having a single source of exception, on the other hand, does help us manage exceptions10:16
xuhaiweikeystoneauth1.exceptions.http.BadRequest: The server could not comply with the request since it is either malformed or  otherwise incorrect. (HTTP 400) (Request-ID: req-0b2abacb-7617-4f4e-a302-0723aa2c1d6b)10:16
Qiming_the only problem as I see it is about extracting meaningful message and display them to users10:16
xuhaiweithis is the message when I use '-d' to show the debug details10:16
Qiming_...10:17
Qiming_each HTTPError class has a consructor:10:17
Qiming_65 class HttpError(base.ClientException):10:17
Qiming_ 66     """The base exception class for all HTTP exceptions."""10:17
Qiming_ 67     http_status = 010:17
Qiming_ 68     message = "HTTP Error"10:17
Qiming_ 6910:17
Qiming_ 70     def __init__(self, message=None, details=None,10:17
Qiming_ 71                  response=None, request_id=None,10:17
Qiming_ 72                  url=None, method=None, http_status=None):10:17
Qiming_ 73         self.http_status = http_status or self.http_status10:17
Qiming_ 74         self.message = message or self.message10:17
Qiming_ 75         self.details = details10:17
Qiming_ 76         self.request_id = request_id10:17
Qiming_ 77         self.response = response10:17
Qiming_ 78         self.url = url10:17
Qiming_ 79         self.method = method10:17
Qiming_ 80         formatted_string = "%s (HTTP %s)" % (self.message, self.http_status)10:17
Qiming_ 81         if request_id:10:18
Qiming_ 82             formatted_string += " (Request-ID: %s)" % request_id10:18
Qiming_ 83         super(HttpError, self).__init__(formatted_string)10:18
Qiming_can we examine the details field?10:18
xuhaiweiI read this source before10:18
xuhaiweiit's not good I think, I also made a patch to fix it, but they want me to add a test case10:18
xuhaiweihonstly, some exceptions have not good format, so it's difficult to parse it10:20
Qiming_anyone want to help remove 'permission' from profiles?10:29
Qiming_it is a similar problem like the properties of a policy10:30
xuhaiweiI can do it, but must do it tomorrow10:31
Qiming_alright10:31
Qiming_it will involve a lot of changes10:31
Qiming_engine, rpc, api, doc10:31
Qiming_I'll start killing node-join and node-leave10:32
xuhaiweiAfter I fixed SDK, senlin client, and DB, cluster-policy-attach still failed10:32
Qiming_hopefully, by tomorrow, we are well situated to propose a single patch to sdk10:32
Qiming_leaving, very tired a day10:34
Qiming_bye guys10:34
xuhaiweibye10:34
Yanyanhusee u tomorrow10:34
Yanyanhuhi, xuhaiwei, you mean use the latest code with fix in senlinclient and sdk, cluster-policy-attach still failed?10:35
xuhaiweisorry Yanyanhu10:37
xuhaiweiI missed one thing in client10:37
xuhaiweidamn10:37
openstackgerritMerged openstack/senlin: add debug testenv in tox  https://review.openstack.org/26685410:37
*** Qiming_ has quit IRC10:39
Yanyanhualso prepare to leave, see U guys tomorrow10:39
xuhaiweisee u10:39
openstackgerritxu-haiwei proposed openstack/python-senlinclient: Remove 'level', 'cooldown' and 'priority' properties in client  https://review.openstack.org/26745810:45
*** Yanyanhu has quit IRC10:51
*** dixiaoli has joined #senlin11:06
*** Qiming_ has joined #senlin11:30
*** Qiming_ has quit IRC11:30
*** Qiming_ has joined #senlin11:30
openstackgerritQiming Teng proposed openstack/senlin: Remove node actions from api layer  https://review.openstack.org/26748911:49
*** dixiaoli has quit IRC12:01
*** Qiming_ has quit IRC12:14
*** Qiming_ has joined #senlin12:14
openstackgerritMerged openstack/senlin: Revise user docs for policy and bindings changes  https://review.openstack.org/26737812:19
openstackgerritMerged openstack/senlin: Further cleanse developer doc  https://review.openstack.org/26742412:19
openstackgerritQiming Teng proposed openstack/senlin: Remove node actions from api layer  https://review.openstack.org/26748912:47
openstackgerritMerged openstack/senlin: Remove node actions from api layer  https://review.openstack.org/26748913:14
openstackgerritQiming Teng proposed openstack/senlin: Remove node actions from engine service  https://review.openstack.org/26754613:15
openstackgerritMerged openstack/python-senlinclient: Revise client to support new sorting option  https://review.openstack.org/26549713:26
openstackgerritMerged openstack/senlin: Remove node actions from engine service  https://review.openstack.org/26754613:52
openstackgerritQiming Teng proposed openstack/senlin: Revise docs about node-join and node-leave  https://review.openstack.org/26758013:56
openstackgerritMerged openstack/senlin: Fix sample placement policies  https://review.openstack.org/26477314:00
*** dixiaoli has joined #senlin14:12
openstackgerritQiming Teng proposed openstack/senlin: Remove 'permission' from profiles  https://review.openstack.org/26758914:13
openstackgerritMerged openstack/senlin: Revise docs about node-join and node-leave  https://review.openstack.org/26758015:20
openstackgerritMerged openstack/senlin: Remove 'permission' from profiles  https://review.openstack.org/26758915:20
*** pratikmallya has joined #senlin15:22
*** pratikma_ has joined #senlin15:31
*** pratikmallya has quit IRC15:34
*** Qiming_ has quit IRC15:38
*** dixiaoli has quit IRC16:26
*** dixiaoli has joined #senlin16:26
*** dixiaoli has quit IRC17:02
*** pratikma_ has quit IRC19:39
*** pratikmallya has joined #senlin19:46
*** pratikmallya has quit IRC20:05
*** pratikmallya has joined #senlin21:06
*** pratikmallya has quit IRC21:07
*** pratikmallya has joined #senlin21:08
*** pratikma_ has joined #senlin21:09
*** pratikmallya has quit IRC21:13
*** pratikma_ has quit IRC21:37
*** pratikmallya has joined #senlin22:17
*** xuhaiwei has quit IRC22:19
*** pratikmallya has quit IRC23:25
*** Qiming has joined #senlin23:46
*** Qiming has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!